Creates new function, setUpPreliminaries, in RegTune.
(details / githubweb)
For RegTune, adds capability to prescribe (not tune) a parameter
(details / githubweb)
Hides print statements in RegTune by using beVerbose=False.
(details / githubweb)
Fixes bug in QuadTune's code that prescribes parameter values.
(details / githubweb)
Adds basic cost function printouts to QuadTune.
(details / githubweb)
QuadTune: refactored to use more subroutines
(details / githubweb)
Fixed some oversights for the bv_efold commits and increased string length for tuning field names for invrs_tau variables - CLUBB ticket #1069 (#1106)
(details / githubweb)
BIT_CHANGING! brunt_vaisala_freq_sqd_mixed now replaces brunt_vaisala_freq_sqd for later calculations - CLUBB ticket #1102
(details / githubweb)
Added option to plot "Lumped Buoyance Budgets" (wpxp_bp combined with
(details / githubweb)
Added a statement that I had previously omitted. The new combined budget
(details / githubweb)
Updating pyplotgen to include a "contour" plot of rcm in the background.
(details / githubweb)
I added the --background-rcm optional flag to pyplotgen.
(details / githubweb)
Small additions that allow all cases to run with pyplotgen.
(details / githubweb)
In the previous commits for the --background-rcm option of pyplotgen,
(details / githubweb)
I am updating the --background-rcm option of pyplotgen to make two
(details / githubweb)
BIT_CHANGING for lscale setup. Updated configurable_model_flags.in and model_flags.F90 - CLUBB ticket #1102 (#1108)
(details / githubweb)
QuadTune: Adds chisqd metric and bar chart for a global run.
(details / githubweb)
QuadTune: adds commented-out attempt to vary the bar base
(details / githubweb)
Likely BIT_CHANGING because of added output fields. Added code outputting C6_term and different Brunt Vaisala frequencies to disk - CLUBB ticket #1102 (#1109)
(details / githubweb)
Changed sqrt_Ri_zm to Ri_zm in preparation of changing the exponent for calculation of invrs_tau_wpxp_zm in mixing_length.F90 - CLUBB ticket #1102 (#1110)
(details / githubweb)
BIT_CHANGING! Removed Richardson_num and all corresponding code - CLUBB ticket #1102 (#1111)
(details / githubweb)
QuadTune: Adds fnc to plot a horizonal bar chart for metrics.
(details / githubweb)
QuadTune: Includes full perturbation in params bar chart
(details / githubweb)
QuadTune: Adds new parameter correlation matrix plot.
(details / githubweb)
stats_metadata needs to be threadprivate to make our standalone thread test work.
(details / githubweb)
Changing order of sqrt and **3 to improve stability, see clubb#1126. Since this is a change to the order of operations, it is BIT_CHANGING.
(details / githubweb)
Setting the minimum tolerance to be epsilon, this is BIT_CHANGING but only for single precision. See larson-group/clubb#1126
(details / githubweb)
Adding new argument list variables to openacc copyin statements
(details / githubweb)
Limiting gabls2 to 500 timesteps in new jenkins test
(details / githubweb)
Changing sclr test case to cobra, keeping 500 timestpes, gabls2 appears less stable as a result of commit 77ce77409e9da770515f66bbb50a869da74aca7d
(details / githubweb)
Setting l_smooth_Heaviside_tau_wpxp to .true. by default
(details / githubweb)
Undoing accidental changes to compiler config
(details / githubweb)
Making nightly cpu vs gpu test use a new config script for the cpu compile. This is the minimize the differences to be only whether or not the openacc GPU code is enabled.
(details / githubweb)
Limiting mpace_b to 250 timestpes for gpu vs cpu test. The mpace_b test passed on my home GPU (RTX 3080), but not when run in jenkens on nelson (P4000). So either the tolerance is too strict, or we're running too many timesteps for mpace_b. Currently the largest difference on mpace_b multicol check is 3.31551e-05 on jenkins, so if this fails also I'll up the tolerance for mpace_b instead of further reducing timesteps run.
(details / githubweb)
I am altering the mean advection code in preparation for ghost point
(details / githubweb)
Fixing bug. See https://github.com/larson-group/clubb/issues/1139
(details / githubweb)
Fixing tridiag solver bug. See https://github.com/larson-group/clubb/issues/1139
(details / githubweb)
Slight rework to acc data statements. This allows us to use return calls in advance_clubb_core again. See https://github.com/larson-group/clubb/issues/1139
(details / githubweb)
Changing xm to out in mono flux solver. There is no need for it to be inout, and it confused me for a bit so I'm fixing it.
(details / githubweb)
Adding clubb specific compiler flag -DCLUBB_GPU, intended for use with openmp or openacc running on the GPU. Also adding a compiler flags, -DCUDA, and case statment for generating random numbers in silhs.
(details / githubweb)
Adding new compiler flags to nvfortran GPU compile script
(details / githubweb)
Adding openacc to openmp conversion script, and making some new compiler config files.
(details / githubweb)
Now that the value of wp3 is being set to a boundary value of 0
(details / githubweb)
This is (amazingly) BIT_CHANGING. The differences are due to some compiler optimizations, see https://github.com/larson-group/clubb/pull/1133\#issuecomment-1865156979.
(details / githubweb)
Removing git log print before logging to file. On some systems/configs the command would cause a busy wait until the person running hit q, and it is superfluous since we are already saving the git log to a file.
(details / githubweb)
Removing backslashes. These should be slashes, but gnu,intel,nvidia generate code that treats slashes as whitespace and backslashes as a character, while cray treats backslashes as whitespace as well. This is easily fixed by using quotes, and in the meantime we will change the backslashes to forward slashes. See https://github.com/larson-group/clubb/issues/1138\#issuecomment-1910844013
(details / githubweb)
Adding ifdefs around multicol netcdf outputting.
(details / githubweb)
These should've been single quotes. I didn't tested a files with single quotes, then for some reason did all the changes as double quotes and only retested with gfortran. RESOLVED:9b495acd26a0b009ec84845aa289c36befff0c41
(details / githubweb)
Some files have tabs in them, this broke my previous sed commands in various spots.
(details / githubweb)
Adding -no-declare-mapper to the openmp conversion script. This adds a sort of data mapper for derived types, but we just copy those in explicitly so they are unneccesary. They also cause problems for the cray compiler.
(details / githubweb)
Fixing a bug where the Lscale used in calculating the damping
(details / githubweb)
adding equals sign cuz I've had it up to here with this typo!
(details / githubweb)
fixing bug, name of wm_zt was left as "wm"
(details / githubweb)
README change to add BIT_CHANGING:595e2c13024c1e913815d56ae724823a82bddc03 when using l_diag_Lscale_from_tau=.false. and for the CAM repo we have BIT_CHANGING:d275ac17f3e53d65641c3210df33ce0fad4e5aef as the hash
(details / githubweb)
Add blank line in order to trigger Jenkins tests for CAM
(details / githubweb)
Fixing restarts by changing wm to wm_zt, the stats output name was changed in 4b25d3a
(details / githubweb)
Fixing bug with C6 parameters, see https://github.com/larson-group/clubb/pull/1147. This is technically BIT_CHANGING, but only when C6thl != C6thlb and l_diag_Lscale_from_tau=.false.
(details / githubweb)
Adding space to make commit because last commit RESOLVED:35d228ebbb66b1463f30659321cd4f7d76adffa2
(details / githubweb)
Fixing a bug. These directives get added when running the ACC to OMP conversion script. I'm unsure how I accidentally commited this, and equally unsure of how only one file is affected. This was found while debugging the clubb thread test
(details / githubweb)
At the ghost point below the surface, which does not matter in
(details / githubweb)
The code that advances um and vm when l_predict_upwp_vpwp is turned off
(details / githubweb)
It was discovered that the location where the ghost point values
(details / githubweb)
I accidentally committed a couple things in the previous commit
(details / githubweb)
Pushing loop into calc_ref_z_linear_thvm to prevent erroneous inlining optimizations by nvfortran. This is BFB on nvhpc 24.3 with -O0 and BFB on nvhpc 22.5 with -O2. https://github.com/larson-group/clubb/issues/1148
(details / githubweb)
Making change to add RESOLVED:a492228d3adfed56f8777d12176fcd7d165260f6, which was technically bit changing because it undid changes to the config flags AND was tested relative to the previous commit (which introduced the flag changes) because that one was labelled as bit changing.
(details / githubweb)
While it doesn't affect results, I fixed what appears to be an
(details / githubweb)
I am updating the loop in subroutine diagnose_xpwp so that it doesn't
(details / githubweb)
This commit is being made to keep the stats zt output from the
(details / githubweb)
I am committing a bug fix to the code that calculates mixed Brunt
(details / githubweb)
Adding -noacc to nvhpc openmp config script, sometimes nvhpc compiles acc code automatically, and this shuts it off.
(details / githubweb)
I am committing a stats change to the ghost point values of zt
(details / githubweb)
Committing some thresholding around positive-definite fields after
(details / githubweb)
Changing the linear interpolation in the zt2zm function at momentum
(details / githubweb)
I'm changing the way ddzt handles the derivative over momentum level 1.
(details / githubweb)
Adding space to include BIT_CHANGING:84588a46852a812266d19e36a8220f71ad56043a. This (https://github.com/larson-group/clubb/commit/84588a46852a812266d19e36a8220f71ad56043a) is described as not bit changing, but that seems to depend on the compiler version and some flags. The bin diff tests detected differences in only twp_ice when using e3sm flags on nelson, and both e3sm flags and default flags on carson.
(details / githubweb)
Moved the ghost-point setting of xm(1) = xm(2) to the last line
(details / githubweb)
Optional arguments are just best sometimes (#1150)
(details / githubweb)
Fixing bug. RESOLVED:556370c6406e6b943b88affbe7728a5036b1ba22, this was catchable by using debugging flags, but seems to otherwise cause no issues. Investigating I found that it only clips the below ground level, so that must not have been affecting other levels. This is technically BIT_CHANGING since it resolves an issue.
(details / githubweb)
Making num_draw_points in fill_holes a constant. We were already using this value as a constant everywhere, but passing a constant by argument list makes it difficult/impossible for a compiler to optimize using that constant, unless it does inlining. Now, rather than passing the constant num_hf_draw_points (or sometimes a hardcoded 2) we just use num_hf_draw_points directly from constants_clubb. This massively improves the performance of a loop in fill holes when using nvhpc+omp, which was the motivation for this, but should also improve the performance on CPUs. Everything is BFB.
(details / githubweb)
Making compatible with latest clubb changes.
(details / githubweb)
The variable rc_coef_zm needed to be passed in and saved from
(details / githubweb)
QuadTune: Moves plotting code to new fnc, createFigs.
(details / githubweb)
Making the f in f90 capital for consistency.
(details / githubweb)
Surrounding print statement with debug flag check.
(details / githubweb)
Making multicol diffness script rely on the largest difference detected, rather the the sum/total of differences. This is essentially to relax the cpu vs gpu diffness test because mpace_b is noisey and often causes the test to fail for innocent bit changing commits. Looking at the largest difference does have the advantage of the check being less sensitive to case differences, such as number of timesteps, vertical levels, number of columns, etc.
(details / githubweb)
Making the only change required to make clubb run with openacc in cam.
(details / githubweb)
QuadTune: Removes LWCF and PRECT from 2-point dpMin plot.
(details / githubweb)
I fixed a bug where the array declarations for X_mixt_comp_all_levs,
(details / githubweb)
QuadTune: Customizes inputs to threeDotFig.
(details / githubweb)
QuadTune: Customizes metrics shown in parameter adjustment bar chart.
(details / githubweb)
Adds blank line so that I can note BIT_CHANGING:5df5fcb3d6c51d6af2e8017d270336eefa75ad3e
(details / githubweb)
QuadTune: Adds more flags to toggle plots.
(details / githubweb)
This commit fixes 2 issues in regards to hydrometeor sedimentation:
(details / githubweb)
Updated the turbulent sedimentation code to account for ghost point
(details / githubweb)
QuadTune: Feeds in 20degree_CAM_TAUS_202404 runs.
(details / githubweb)
QuadTune: Feeds in 20degree_CAM_TAUS_2020404, take 2.
(details / githubweb)
Ri_zm calc (Part 2) - Move the brunt_vaisala smoothing into calc_brunt_vaisala_freq_sqd (#1156)
(details / githubweb)
Testing the new module system with our GPU diffness test. See https://github.com/larson-group/sys_admin/issues/829
(details / githubweb)
The module system is setup via paths in /etc/profile.d/larson-group.sh, so we need to source it. https://github.com/larson-group/sys_admin/issues/829
(details / githubweb)
Making our mkl compile config work directly in the compile script rather than relying on a correspondence with the config files. Also settig main config scripts to use new ifx compiler.
(details / githubweb)
Removing allocatable status of some variables. These need not be declared allocatable and ifx seems to have a problem with it. The allocatable status is an artifact from when we had these as arrays of initially unknown size.
(details / githubweb)
Fixing the run agent to be carson, since it has the only GPU capable of running with openmp gpu offloading.
(details / githubweb)
Making jenkins bit diff tests only run on carson. This is because these tests are defined by a file we store on carson that needs to be updated after each test.
(details / githubweb)
Replacing pgi references with nvhpc, and adding nvhpc_debug config script along with new jenkins tests.
(details / githubweb)
This code in adj_low_res_nu was using the ghost point when
(details / githubweb)
This technically BIT_CHANGING commit is being made to keep results in
(details / githubweb)
I am updating the SILHS code that calculates k_lh_start to work
(details / githubweb)
QuadTune: Adds arrow plot and plot of bias vs. a diagnostic field such as U10.
(details / githubweb)
I am making this commit because, as part of deghosting, I discovered 2
(details / githubweb)
I am updating the snowslope output stat so it matches bit-for-bit
(details / githubweb)
Setting the value of K_hm to 0 at the non-interactive upper and lower
(details / githubweb)
I am committing changes to stats output for cloud_cover, rcm_in_layer,
(details / githubweb)
There were furhter issues found with the k_lh_start code.
(details / githubweb)
Ri_zm calc (Part 3) - Moving calculations for Ri_zm out of diagnose_Lscale_from_taus (#1157)
(details / githubweb)
In my previous commit, I changed the domain of the maxloc commands
(details / githubweb)
This commit brings the stats output from the all cases run with
(details / githubweb)
Updates README so that I can note that BIT_CHANGING:9ca167aa8b04cbebe4a1177a72f13731454e1e11
(details / githubweb)
Committing a change that will initialize this set of variables
(details / githubweb)
Making a change to the l_C2_cloud_frac option with advance_xp2_xpyp.
(details / githubweb)
Fixing bug. qclvar copying is handled by the api, but we were deleting it with an unstructured data statement. I added this due as a fix before thinking qclvar was a local variable, which happened because I mixed up the CLUBB_CAM and CLUBBND_CAM flags. https://github.com/larson-group/cam/issues/175
(details / githubweb)
When l_vert_avg_closure is enabled, the flags l_call_pdf_closure_twice,
(details / githubweb)
Fixing GPU bug. There is a vertical dependency with wpxp. This is what was breaking the ECT test, see larson-group/cam#175
(details / githubweb)
Fixing bugs that are only caught when not outputting w_[up/down]_in_cloud stats or if l_host_applies_sfc_fluxes=.true. The l_host_applies_sfc_fluxes=.true. isn't testable (at least not in clubb_standalone), and I just caught that visually. The cloudy_updraft_frac and cloudy_downdraft_frac fields not being set were only noticable in cam, because we always run with iw_up_in_cloud>0 and iw_down_in_cloud>0 to output stats.
(details / githubweb)
Moving pdf_params copying to copyin. This is the data structure that contains pointers, and these pointers will be different on the host and device, so it is bad in theory to copy the structure back to the CPU as it might overwrite cpu memory pointers with gpu memory pointers. In practice though I've seen no problems caused by this, I'm just making this commit preemptively, and it has already been tested with the ECT test.
(details / githubweb)
Updating input fields so that the zt2zm function is used for
(details / githubweb)
Added zt2zm2zt-smoothing to remove noise in MPACE_B winds (#1161)
(details / githubweb)
Changing openacc to openmp migration repo to a fork with a change to switch the order of copyins and copies. This is to allow us to only copyin the pdf_params structure, but copy the internal arrays. When the copying of the internal arrays happens first, followed by the copyin of the structure, we overwrite the pointers to the internal arrays on the GPU version of the structure. Hence why we want the copyins to precede the copy statements.
(details / githubweb)
QuadTune: Plots subsets of 20x20-degree regions.
(details / githubweb)
Small bugs fix in bugsrad code. This was only caught when compiling with intel debug and using '-warn all', which compares interface dimensions/declaration between files.
(details / githubweb)
Variable name correction in acc data statement.
(details / githubweb)
Splitting zeros_vector into versions with nzt or nzm size to match sizes in subroutine.
(details / githubweb)
Making radf size correct in api and clubb_driver.
(details / githubweb)
![[Jenkins]](/jenkins/static/57c8a776/images/svgs/logo.svg){kind=logo}
