Started by an SCM change76d3946a586f66f155af6c32d7c6f9ed92389388cfd3946a586f66f155af6c32d7c6f9ed92389388cforigin/masterd3946a586f66f155af6c32d7c6f9ed92389388cfd3946a586f66f155af6c32d7c6f9ed92389388cforigin/master72c7eb33836dd22870dc48b2acd2b5b340dbeef909c7eb33836dd22870dc48b2acd2b5b340dbeef909origin/changes_to_not_breakc7eb33836dd22870dc48b2acd2b5b340dbeef909c7eb33836dd22870dc48b2acd2b5b340dbeef909origin/changes_to_not_break89f36fb6f15642811bfaef6fec448571efe405d70bf36fb6f15642811bfaef6fec448571efe405d70brefs/remotes/origin/masterf36fb6f15642811bfaef6fec448571efe405d70bf36fb6f15642811bfaef6fec448571efe405d70brefs/remotes/origin/masterf36fb6f15642811bfaef6fec448571efe405d70bf36fb6f15642811bfaef6fec448571efe405d70brefs/remotes/origin/masterhttps://github.com/larson-group/wrf.githttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/wrf_clubb_silhs_parallel_ifort/detail/wrf_clubb_silhs_parallel_ifort/89/artifactshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/wrf_clubb_silhs_parallel_ifort/detail/wrf_clubb_silhs_parallel_ifort/89/changeshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/wrf_clubb_silhs_parallel_ifort/detail/wrf_clubb_silhs_parallel_ifort/89/http://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/wrf_clubb_silhs_parallel_ifort/detail/wrf_clubb_silhs_parallel_ifort/89/testsfalsefalse#8956545921496309wrf_clubb_silhs_parallel_ifort #8989false897257SUCCESS1627460406420http://carson.math.uwm.edu/jenkins/job/wrf_clubb_silhs_parallel_ifort/89/WRF/phys/clubb/stats_variables.F90WRF/phys/module_bl_clubb.FWRF/phys/silhs/silhs_api_module.F90WRF/phys/clubb/clubb_api_module.F90WRF/phys/clubb/new_hybrid_pdf_main.F90WRF/phys/silhs/latin_hypercube_driver_module.F90bcdcd12ba477b8e6512c3265b24d8fc4a5d69c7b1627409236000http://carson.math.uwm.edu/jenkins/user/72510114+rhodeskeegan72510114+RhodesKeegan72510114+RhodesKeegan@users.noreply.github.comPassing stats variables through needed subroutines arg lists 2021-07-27 13:07:16 -0500bcdcd12ba477b8e6512c3265b24d8fc4a5d69c7bPassing stats variables through needed subroutines arg listseditWRF/phys/clubb/stats_variables.F90editWRF/phys/clubb/clubb_api_module.F90editWRF/phys/silhs/latin_hypercube_driver_module.F90editWRF/phys/silhs/silhs_api_module.F90editWRF/phys/clubb/new_hybrid_pdf_main.F90editWRF/phys/module_bl_clubb.FWRF/phys/module_bl_clubb.F3a841a43abd7472cac6e27f53d976814490960321627409236000http://carson.math.uwm.edu/jenkins/user/72510114+rhodeskeegan72510114+RhodesKeegan72510114+RhodesKeegan@users.noreply.github.comFixing compiliation errors 2021-07-27 13:07:16 -05003a841a43abd7472cac6e27f53d97681449096032Fixing compiliation errorseditWRF/phys/module_bl_clubb.FWRF/phys/module_bl_clubb.F83191efcbbeab9650d218c94152981cda9b59fbc1627409236000http://carson.math.uwm.edu/jenkins/user/72510114+rhodeskeegan72510114+RhodesKeegan72510114+RhodesKeegan@users.noreply.github.comFixing compiliation errors 2021-07-27 13:07:16 -050083191efcbbeab9650d218c94152981cda9b59fbcFixing compiliation errorseditWRF/phys/module_bl_clubb.FWRF/phys/module_bl_clubb.F84b1902670511b6f10311574939d4115001f0c611627409236000http://carson.math.uwm.edu/jenkins/user/72510114+rhodeskeegan72510114+RhodesKeegan72510114+RhodesKeegan@users.noreply.github.comFixing not including stats typing 2021-07-27 13:07:16 -050084b1902670511b6f10311574939d4115001f0c61Fixing not including stats typingeditWRF/phys/module_bl_clubb.FWRF/phys/module_bl_clubb.Fbdf54ece5fa9be68ff6a9d89c315fb4c5f47a9161627409236000http://carson.math.uwm.edu/jenkins/user/72510114+rhodeskeegan72510114+RhodesKeegan72510114+RhodesKeegan@users.noreply.github.comFixing compiliation errors 2021-07-27 13:07:16 -0500bdf54ece5fa9be68ff6a9d89c315fb4c5f47a916Fixing compiliation errorseditWRF/phys/module_bl_clubb.FWRF/phys/module_bl_clubb.F7b0276731fe029ef904f4e577c80eba087a82f6f1627409236000http://carson.math.uwm.edu/jenkins/user/72510114+rhodeskeegan72510114+RhodesKeegan72510114+RhodesKeegan@users.noreply.github.comFixing compiliation errors 2021-07-27 13:07:16 -05007b0276731fe029ef904f4e577c80eba087a82f6fFixing compiliation errorseditWRF/phys/module_bl_clubb.FWRF/main/module_wrf_top.FWRF/phys/module_est_subcol_microphys_tndcy.Fcec73e7c2aba1b5451e24f1dea4910e9357975611627409236000http://carson.math.uwm.edu/jenkins/user/72510114+rhodeskeegan72510114+RhodesKeegan72510114+RhodesKeegan@users.noreply.github.comFixing compiliation errors 2021-07-27 13:07:16 -0500cec73e7c2aba1b5451e24f1dea4910e935797561Fixing compiliation errorseditWRF/main/module_wrf_top.FeditWRF/phys/module_est_subcol_microphys_tndcy.FWRF/phys/clubb/stats_variables.F90WRF/phys/silhs/silhs_api_module.F90WRF/phys/clubb/new_hybrid_pdf_main.F90WRF/phys/clubb/clubb_api_module.F90WRF/phys/silhs/latin_hypercube_driver_module.F90a4ec66b1d8c87c3d5d91cb3b5adc927bd8c9338c1627409236000http://carson.math.uwm.edu/jenkins/user/72510114+rhodeskeegan72510114+RhodesKeegan72510114+RhodesKeegan@users.noreply.github.comRemoving updated and silhs directories 2021-07-27 13:07:16 -0500a4ec66b1d8c87c3d5d91cb3b5adc927bd8c9338cRemoving updated and silhs directorieseditWRF/phys/silhs/latin_hypercube_driver_module.F90editWRF/phys/silhs/silhs_api_module.F90editWRF/phys/clubb/new_hybrid_pdf_main.F90editWRF/phys/clubb/clubb_api_module.F90editWRF/phys/clubb/stats_variables.F90stats_variables.F90clubb_api_module.F903e33479b7b92dbd3b3195f0b18730302ae188bd01627409573000http://carson.math.uwm.edu/jenkins/user/72510114+rhodeskeegan72510114+RhodesKeegan72510114+RhodesKeegan@users.noreply.github.comMoving the stats variables to module variables of clubb_driver. This change means I had to modify clubb_api_module's arg list along with other arg lists throughout clubb. Everything compiles and results remain BFB identical. For ticket #733. 2021-07-27 13:12:53 -05003e33479b7b92dbd3b3195f0b18730302ae188bd0Moving the stats variables to module variables of clubb_driver.editstats_variables.F90editclubb_api_module.F90silhs_api_module.F90latin_hypercube_driver_module.F9029b6903d922283c188dba7426812537e02c8a5f81627409573000http://carson.math.uwm.edu/jenkins/user/72510114+rhodeskeegan72510114+RhodesKeegan72510114+RhodesKeegan@users.noreply.github.comMoving the stats variables to module variables of clubb_driver. This change means I had to modify clubb_api_module's arg list along with other arg lists throughout clubb. Everything compiles and results remain BFB identical. For ticket #733. 2021-07-27 13:12:53 -050029b6903d922283c188dba7426812537e02c8a5f8Moving the stats variables to module variables of clubb_driver.editsilhs_api_module.F90editlatin_hypercube_driver_module.F90githttp://carson.math.uwm.edu/jenkins/user/72510114+rhodeskeegan72510114+RhodesKeegan72510114+rhodeskeeganfalseStarted by an SCM change76d3946a586f66f155af6c32d7c6f9ed92389388cfd3946a586f66f155af6c32d7c6f9ed92389388cforigin/masterd3946a586f66f155af6c32d7c6f9ed92389388cfd3946a586f66f155af6c32d7c6f9ed92389388cforigin/master72c7eb33836dd22870dc48b2acd2b5b340dbeef909c7eb33836dd22870dc48b2acd2b5b340dbeef909origin/changes_to_not_breakc7eb33836dd22870dc48b2acd2b5b340dbeef909c7eb33836dd22870dc48b2acd2b5b340dbeef909origin/changes_to_not_break905c3373dc55906d021b80bfe2fb7a1d26d220e4155c3373dc55906d021b80bfe2fb7a1d26d220e415refs/remotes/origin/master5c3373dc55906d021b80bfe2fb7a1d26d220e4155c3373dc55906d021b80bfe2fb7a1d26d220e415refs/remotes/origin/master5c3373dc55906d021b80bfe2fb7a1d26d220e4155c3373dc55906d021b80bfe2fb7a1d26d220e415refs/remotes/origin/masterhttps://github.com/larson-group/wrf.gitfalse#9058274001496309wrf_clubb_silhs_parallel_ifort #9090false907371SUCCESS1627633207543http://carson.math.uwm.edu/jenkins/job/wrf_clubb_silhs_parallel_ifort/90/advance_clubb_core_module.F90setup_clubb_pdf_params.F90advance_xp2_xpyp_module.F90e542998c8db09fe108f69821eef74868caba2c461627569049000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduFixing coding standard viloation of lines exceeding 100 characters. Violations were introduced as a result of changes made by ticket #733, this commit resolves the coding standard violations. Results BFB identical. 2021-07-29 09:30:49 -0500e542998c8db09fe108f69821eef74868caba2c46Fixing coding standard viloation of lines exceeding 100 characters.editadvance_clubb_core_module.F90editadvance_xp2_xpyp_module.F90editsetup_clubb_pdf_params.F90silhs_api_module.F90d5bdc8fbbb988928416a1fff23ec2592bb6142cd1627569049000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduFixing coding standard viloation of lines exceeding 100 characters. Violations were introduced as a result of changes made by ticket #733, this commit resolves the coding standard violations. Results BFB identical. 2021-07-29 09:30:49 -0500d5bdc8fbbb988928416a1fff23ec2592bb6142cdFixing coding standard viloation of lines exceeding 100 characters.editsilhs_api_module.F90advance_wp2_wp3_module.F90parameters_tunable.F90stats_variables.F90parameter_indices.F90stats_zt_module.F90b1418c5d2b27c7560b6e18d9b05837722e7b13bb1627579701000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comAdding wp3_pr_tp (aka "negative nose" term) to wp3 equation. Related to #920. This is not set up to change results currently, since the coefficient of the new term is zero, but it is BIT_CHANGING since it will include new output in the netcdf files. Also includes updates to pyplotgen to accommodate the new term. 2021-07-29 12:28:21 -0500b1418c5d2b27c7560b6e18d9b05837722e7b13bbAdding wp3_pr_tp (aka "negative nose" term) to wp3 equation. Related to #920.editstats_zt_module.F90editparameter_indices.F90editparameters_tunable.F90editstats_variables.F90editadvance_wp2_wp3_module.F90advance_wp2_wp3_module.F90parameters_tunable.F90stats_zt_module.F903c12f9c674cc1a5d8e49b0f2c71ca8e2159fcc991627579701000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comChanging the way the new wp3_pr_tp term works, by generalizing the wp3_terp_pr_lhs subroutine. Also cleaning up comments and changing the description of the wp3_pr_tp variable in the netcdf output files, hence this commit is BIT_CHANGING, although it will not affect numerical results since the wp3_pr_tp coefficient (C_wp3_pr_tp) is set to zero. Related to #920. 2021-07-29 12:28:21 -05003c12f9c674cc1a5d8e49b0f2c71ca8e2159fcc99Changing the way the new wp3_pr_tp term works, by generalizing the wp3_terp_pr_lhs subroutine. Also cleaning up comments and changing the description of the wp3_pr_tp variable in the netcdf output files, hence this commit is BIT_CHANGING, although it will not affect numerical results since the wp3_pr_tp coefficient (C_wp3_pr_tp) is set to zero.editadvance_wp2_wp3_module.F90editparameters_tunable.F90editstats_zt_module.F90standard_stats.inall_stats.ind09f2b7cd78484c019e1a64d70ecfb7e707d5f511627579701000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comAdding wp3_pr_tp (aka "negative nose" term) to wp3 equation. Related to #920. This is not set up to change results currently, since the coefficient of the new term is zero, but it is BIT_CHANGING since it will include new output in the netcdf files. Also includes updates to pyplotgen to accommodate the new term. 2021-07-29 12:28:21 -0500d09f2b7cd78484c019e1a64d70ecfb7e707d5f51Adding wp3_pr_tp (aka "negative nose" term) to wp3 equation. Related to #920.editstandard_stats.ineditall_stats.intunable_parameters.in1899d62de19c4c16461498a80c03507fda61910f1627579701000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comAdding wp3_pr_tp (aka "negative nose" term) to wp3 equation. Related to #920. This is not set up to change results currently, since the coefficient of the new term is zero, but it is BIT_CHANGING since it will include new output in the netcdf files. Also includes updates to pyplotgen to accommodate the new term. 2021-07-29 12:28:21 -05001899d62de19c4c16461498a80c03507fda61910fAdding wp3_pr_tp (aka "negative nose" term) to wp3 equation. Related to #920.edittunable_parameters.ingithttp://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens82http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskfalse91http://carson.math.uwm.edu/jenkins/job/wrf_clubb_silhs_parallel_ifort/91/89http://carson.math.uwm.edu/jenkins/job/wrf_clubb_silhs_parallel_ifort/89/Started by an SCM change76d3946a586f66f155af6c32d7c6f9ed92389388cfd3946a586f66f155af6c32d7c6f9ed92389388cforigin/masterd3946a586f66f155af6c32d7c6f9ed92389388cfd3946a586f66f155af6c32d7c6f9ed92389388cforigin/master72c7eb33836dd22870dc48b2acd2b5b340dbeef909c7eb33836dd22870dc48b2acd2b5b340dbeef909origin/changes_to_not_breakc7eb33836dd22870dc48b2acd2b5b340dbeef909c7eb33836dd22870dc48b2acd2b5b340dbeef909origin/changes_to_not_break88b0e8668f8002f4ace6f881a382303f8c710e8c25b0e8668f8002f4ace6f881a382303f8c710e8c25refs/remotes/origin/masterb0e8668f8002f4ace6f881a382303f8c710e8c25b0e8668f8002f4ace6f881a382303f8c710e8c25refs/remotes/origin/masterb0e8668f8002f4ace6f881a382303f8c710e8c25b0e8668f8002f4ace6f881a382303f8c710e8c25refs/remotes/origin/masterhttps://github.com/larson-group/wrf.gitfalse#8858132611496309wrf_clubb_silhs_parallel_ifort #8888false887153SUCCESS1627374007905http://carson.math.uwm.edu/jenkins/job/wrf_clubb_silhs_parallel_ifort/88/advance_wp2_wp3_module.F90advance_clubb_core_module.F90parameter_indices.F90stats_zt_module.F90pdf_closure_module.F90stats_zm_module.F90parameters_tunable.F90stats_clubb_utilities.F90stats_variables.F90c7775211705fd48dec941135fc4a9fd44d2b98b91627323773000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comCode changes to introduce wp2_pr_dfsn, the wp2 pressure diffusion term, consistent with Lumley 1978. Related to #920. This is BIT_CHANGING, but only because it will introduce some new output variables in the netcdf files. It will not affect results currently since the pressure diffusion coefficient is set to zero. 2021-07-26 13:22:53 -0500c7775211705fd48dec941135fc4a9fd44d2b98b9Code changes to introduce wp2_pr_dfsn, the wp2 pressure diffusion term, consistent with Lumley 1978. Related to #920.editadvance_clubb_core_module.F90editstats_zm_module.F90editpdf_closure_module.F90editparameters_tunable.F90editstats_clubb_utilities.F90editparameter_indices.F90editadvance_wp2_wp3_module.F90editstats_variables.F90editstats_zt_module.F90advance_wp2_wp3_module.F909da282e948a7779026d75c8251148c3db0c86e081627323773000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comFixing comment for the wp2_term_pr_dfsn subroutine. Related to #920. 2021-07-26 13:22:53 -05009da282e948a7779026d75c8251148c3db0c86e08Fixing comment for the wp2_term_pr_dfsn subroutine. Related to #920.editadvance_wp2_wp3_module.F90advance_wp2_wp3_module.F90f6dcf5918b70b39693d2f4c2396ddf03fb6ef8c21627323773000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comUpdating wp3 pressure diffusion term to be consistent with the Lumley 1978 formula for the perturbation pressure. For #920. 2021-07-26 13:22:53 -0500f6dcf5918b70b39693d2f4c2396ddf03fb6ef8c2Updating wp3 pressure diffusion term to be consistent with the Lumley 1978 formula for the perturbation pressure. For #920.editadvance_wp2_wp3_module.F90advance_wp2_wp3_module.F90advance_clubb_core_module.F90bdfc25a13cf9388a0cdba98fc9cfded02f0f4f741627323773000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comMaking requested changes to the wp2 pressure diffuion additions, including correcting some grid-level related issues. Related to #920. 2021-07-26 13:22:53 -0500bdfc25a13cf9388a0cdba98fc9cfded02f0f4f74Making requested changes to the wp2 pressure diffuion additions, including correcting some grid-level related issues. Related to #920.editadvance_wp2_wp3_module.F90editadvance_clubb_core_module.F90advance_clubb_core_module.F90stats_clubb_utilities.F90advance_wp2_wp3_module.F90c1c60fe744dc2e7e126babeb6548151e13d96a941627323773000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comFixing some comments. 2021-07-26 13:22:53 -0500c1c60fe744dc2e7e126babeb6548151e13d96a94Fixing some comments.editadvance_clubb_core_module.F90editstats_clubb_utilities.F90editadvance_wp2_wp3_module.F90standard_stats.inall_stats.inee285a439f152f10c6025f097775de6714694d811627323773000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comCode changes to introduce wp2_pr_dfsn, the wp2 pressure diffusion term, consistent with Lumley 1978. Related to #920. This is BIT_CHANGING, but only because it will introduce some new output variables in the netcdf files. It will not affect results currently since the pressure diffusion coefficient is set to zero. 2021-07-26 13:22:53 -0500ee285a439f152f10c6025f097775de6714694d81Code changes to introduce wp2_pr_dfsn, the wp2 pressure diffusion term, consistent with Lumley 1978. Related to #920.editstandard_stats.ineditall_stats.intunable_parameters.ind3fd7f765678ac1d0d5e9ab019b9726ddd3cbebd1627323773000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comCode changes to introduce wp2_pr_dfsn, the wp2 pressure diffusion term, consistent with Lumley 1978. Related to #920. This is BIT_CHANGING, but only because it will introduce some new output variables in the netcdf files. It will not affect results currently since the pressure diffusion coefficient is set to zero. 2021-07-26 13:22:53 -0500d3fd7f765678ac1d0d5e9ab019b9726ddd3cbebdCode changes to introduce wp2_pr_dfsn, the wp2 pressure diffusion term, consistent with Lumley 1978. Related to #920.edittunable_parameters.inpdf_closure_module.F90stats_zt_module.F902a15f13230db5f5ca0dddbda5245b0dc67dd707a1627331205000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comCorrecting a typo bug and adding some descriptive comments to two new variables. This is a BIT_CHANGING commit becuase it will affect the newly calculated variables and descriptions in the output files, but it won't affect any plotted results. Related to #920. 2021-07-26 15:26:45 -05002a15f13230db5f5ca0dddbda5245b0dc67dd707aCorrecting a typo bug and adding some descriptive comments to two new variables. This is a BIT_CHANGING commit becuase it will affect the newly calculated variables and descriptions in the output files, but it won't affect any plotted results. Related to #920.editpdf_closure_module.F90editstats_zt_module.F90githttp://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephenshttp://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens82false89http://carson.math.uwm.edu/jenkins/job/wrf_clubb_silhs_parallel_ifort/89/87http://carson.math.uwm.edu/jenkins/job/wrf_clubb_silhs_parallel_ifort/87/