Started by an SCM change00058608154853950780.6117650765076d3946a586f66f155af6c32d7c6f9ed92389388cfd3946a586f66f155af6c32d7c6f9ed92389388cforigin/masterd3946a586f66f155af6c32d7c6f9ed92389388cfd3946a586f66f155af6c32d7c6f9ed92389388cforigin/master72c7eb33836dd22870dc48b2acd2b5b340dbeef909c7eb33836dd22870dc48b2acd2b5b340dbeef909origin/changes_to_not_breakc7eb33836dd22870dc48b2acd2b5b340dbeef909c7eb33836dd22870dc48b2acd2b5b340dbeef909origin/changes_to_not_break537ef64f9bea054a77446f80a4d410275663fc32ff0ef64f9bea054a77446f80a4d410275663fc32ff0refs/remotes/origin/masteref64f9bea054a77446f80a4d410275663fc32ff0ef64f9bea054a77446f80a4d410275663fc32ff0refs/remotes/origin/masteref64f9bea054a77446f80a4d410275663fc32ff0ef64f9bea054a77446f80a4d410275663fc32ff0refs/remotes/origin/masterhttps://github.com/larson-group/wrf.gitfalse#5371548531746099wrf_clubb_silhs_parallel_ifort #537537false53710515FAILURE1791966008940https://carson.math.uwm.edu/jenkins/job/wrf_clubb_silhs_parallel_ifort/537/calc_roots.F9076464de9f694cb3148b0ae07f9eb0098afc4a4e41791911400000https://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comFixed bug in cubic equation solve function. Only relevant if pdf is L… (#1387) * Fixed bug in cubic equation solve function. Only relevant if pdf is Luhar or iiPDF_type=4 Therefore technically BIT_CHANGING... The bug existed because the old code used the principal cube root which has an imaginary part for negative bases. The fix is to simply calc: -|w|**(1/3) for negative real numbers. * Replaced determinant with discriminant Verified via a new Fortran unit test and also manually checked with wolfram alpha. There is no way to actually run this code :/ would only work for iiPDF_types: iiPDF_3D_Luhar = 3 and iiPDF_3D_Luhar = 3 (and those are currently (Oct 2026) broken ) 2026-10-13 12:10:00 -050076464de9f694cb3148b0ae07f9eb0098afc4a4e4Fixed bug in cubic equation solve function. Only relevant if pdf is L… (#1387)editcalc_roots.F90githttps://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse538https://carson.math.uwm.edu/jenkins/job/wrf_clubb_silhs_parallel_ifort/538/536https://carson.math.uwm.edu/jenkins/job/wrf_clubb_silhs_parallel_ifort/536/