Started by an SCM change76d3946a586f66f155af6c32d7c6f9ed92389388cfd3946a586f66f155af6c32d7c6f9ed92389388cforigin/masterd3946a586f66f155af6c32d7c6f9ed92389388cfd3946a586f66f155af6c32d7c6f9ed92389388cforigin/master72c7eb33836dd22870dc48b2acd2b5b340dbeef909c7eb33836dd22870dc48b2acd2b5b340dbeef909origin/changes_to_not_breakc7eb33836dd22870dc48b2acd2b5b340dbeef909c7eb33836dd22870dc48b2acd2b5b340dbeef909origin/changes_to_not_break2426c35485046f20a6bb97442ea9b27e85959bb760d6c35485046f20a6bb97442ea9b27e85959bb760drefs/remotes/origin/master6c35485046f20a6bb97442ea9b27e85959bb760d6c35485046f20a6bb97442ea9b27e85959bb760drefs/remotes/origin/master6c35485046f20a6bb97442ea9b27e85959bb760d6c35485046f20a6bb97442ea9b27e85959bb760drefs/remotes/origin/masterhttps://github.com/larson-group/wrf.githttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/wrf_clubb_silhs_parallel_ifort/detail/wrf_clubb_silhs_parallel_ifort/242/artifactshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/wrf_clubb_silhs_parallel_ifort/detail/wrf_clubb_silhs_parallel_ifort/242/changeshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/wrf_clubb_silhs_parallel_ifort/detail/wrf_clubb_silhs_parallel_ifort/242/http://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/wrf_clubb_silhs_parallel_ifort/detail/wrf_clubb_silhs_parallel_ifort/242/testsfalseRun WRF_Parallel_test.shfalse#24226555131496309wrf_clubb_silhs_parallel_ifort #242242false24219921SUCCESS1673601610892http://carson.math.uwm.edu/jenkins/job/wrf_clubb_silhs_parallel_ifort/242/mixing_length.F90saturation.F90model_flags.F90constants_clubb.F9021426fea400c37cfd10dbde5beb0f96690a2f8381673549655000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRestructuring and Porting of Compute_mixing_length subroutine(Phase 1) (#1052) * Restructuring and Porting of Compute_mixing_length subroutine(Phase 1) Restructure: The compute_mixing_length is one of the top most routine taking 35-50% of the total time in a single timestep. The subroutine has been restructured to push the i-loop further down to extract vectorization and parallelization. The restructuring also involves introduction of sat_mixrat_liq_acc routines to extract parallelism when called inside a OpenACC parallel region. Porting: OpenACC directives are inserted to port the restructured compute_mixing_length code on to the GPUs. This port is currently unoptimized and there is still room for improvement. NOTE: Currently, l_sat_mixrat_lookup = false and saturation_formula = saturation_flatau (Earthworks config options) case is supported on OpenACC build. Any other options works on CPUs as usual. OpenACC declare create directives are inserted in model_flags and constants_clubb, as these module variables are used inside the saturation routines. * Added debug message about only supporting l_sat_mixrat_lookup = false and saturation_formula = saturation_flatau on GPUs Answers are Bit for Bit with arm-multicolumn case + nvhpc compiler. * Changing CLUBB debug level 1 to 0 for the saturation formula support running on GPUs * Changing indentation to make gfortran happy, it wants ifdefs to start at the beginning of the line. * Adding use statements for error checks and printouts, also making the errors set err_code to clubb_fatal_error. Co-authored-by: huebler <huebler@uwm.edu> 2023-01-12 12:54:15 -060021426fea400c37cfd10dbde5beb0f96690a2f838Restructuring and Porting of Compute_mixing_length subroutine(Phase 1) (#1052)editsaturation.F90editconstants_clubb.F90editmixing_length.F90editmodel_flags.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreplyfalseStarted by an SCM change76d3946a586f66f155af6c32d7c6f9ed92389388cfd3946a586f66f155af6c32d7c6f9ed92389388cforigin/masterd3946a586f66f155af6c32d7c6f9ed92389388cfd3946a586f66f155af6c32d7c6f9ed92389388cforigin/master72c7eb33836dd22870dc48b2acd2b5b340dbeef909c7eb33836dd22870dc48b2acd2b5b340dbeef909origin/changes_to_not_breakc7eb33836dd22870dc48b2acd2b5b340dbeef909c7eb33836dd22870dc48b2acd2b5b340dbeef909origin/changes_to_not_break2430ee1d3e76cd4919578a6233ef29f9e1fc2d8be650ee1d3e76cd4919578a6233ef29f9e1fc2d8be65refs/remotes/origin/master0ee1d3e76cd4919578a6233ef29f9e1fc2d8be650ee1d3e76cd4919578a6233ef29f9e1fc2d8be65refs/remotes/origin/master0ee1d3e76cd4919578a6233ef29f9e1fc2d8be650ee1d3e76cd4919578a6233ef29f9e1fc2d8be65refs/remotes/origin/masterhttps://github.com/larson-group/wrf.gitfalse#24330940991496309wrf_clubb_silhs_parallel_ifort #243243false24320013SUCCESS1674120008501http://carson.math.uwm.edu/jenkins/job/wrf_clubb_silhs_parallel_ifort/243/mixing_length.F90saturation.F90advance_clubb_core_module.F90model_flags.F9038b63ff28ea145707d4ee1d9469013ee20b1697b1674081416000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRestructuring and Porting of Compute_mixing_length subroutine(Phase 2) (#1054) * Restructuring and Porting of Compute_mixing_length subroutine(Phase 2) Restructure: sat_mixrat_liq_2D_acc is being directly called instead of calling the 1D version inside the column loop. Changing sat_mixrat_liq_2D_acc to a subroutine from a function and adding output array, start_index as additional argument. This is a workaround for passing sub-arrays. The OpenACC doen't like the sub-arrays being passed and fails the validation. Porting: OpenACC directives are added inside sat_mixrat_liq_2D_acc for porting Validation: Answers are Bit for Bit with arm-multicolumn case + nvhpc compiler * Fix for compilation issues Issue 1: Missed out declaring 'start_index' while intergrating the change Issue 2: The use of error_code module and the procedures inside it causes OpenACC compilation issues when run on the device. * Removing the sat_mixrat_liq_acc and sat_mixrat_liq_2D_acc, making the normal sat_mixrat_liq work for all current use cases, and making the other versions of sat_mixrat_liq (bolton,gfdl,lookup) functional with OPENACC. Co-authored-by: huebler <huebler@uwm.edu> 2023-01-18 16:36:56 -060038b63ff28ea145707d4ee1d9469013ee20b1697bRestructuring and Porting of Compute_mixing_length subroutine(Phase 2) (#1054)editadvance_clubb_core_module.F90editmixing_length.F90editsaturation.F90editmodel_flags.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse244http://carson.math.uwm.edu/jenkins/job/wrf_clubb_silhs_parallel_ifort/244/242http://carson.math.uwm.edu/jenkins/job/wrf_clubb_silhs_parallel_ifort/242/Started by an SCM change76d3946a586f66f155af6c32d7c6f9ed92389388cfd3946a586f66f155af6c32d7c6f9ed92389388cforigin/masterd3946a586f66f155af6c32d7c6f9ed92389388cfd3946a586f66f155af6c32d7c6f9ed92389388cforigin/master72c7eb33836dd22870dc48b2acd2b5b340dbeef909c7eb33836dd22870dc48b2acd2b5b340dbeef909origin/changes_to_not_breakc7eb33836dd22870dc48b2acd2b5b340dbeef909c7eb33836dd22870dc48b2acd2b5b340dbeef909origin/changes_to_not_break24177f795cb7b7539c09bfc554d34a2437187ef413e77f795cb7b7539c09bfc554d34a2437187ef413erefs/remotes/origin/master77f795cb7b7539c09bfc554d34a2437187ef413e77f795cb7b7539c09bfc554d34a2437187ef413erefs/remotes/origin/master77f795cb7b7539c09bfc554d34a2437187ef413e77f795cb7b7539c09bfc554d34a2437187ef413erefs/remotes/origin/masterhttps://github.com/larson-group/wrf.gitfalse#24125890111496309wrf_clubb_silhs_parallel_ifort #241241false24119849SUCCESS1673515209198http://carson.math.uwm.edu/jenkins/job/wrf_clubb_silhs_parallel_ifort/241/matrix_solver_wrapper.F90lapack_wrap.F9038f9da3d580e38623856fb89bf73e274c5207f791673472578000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comPushing column loop into lapack wrap. 2023-01-11 15:29:38 -060038f9da3d580e38623856fb89bf73e274c5207f79Pushing column loop into lapack wrap.editmatrix_solver_wrapper.F90editlapack_wrap.F90githttp://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwmfalse242http://carson.math.uwm.edu/jenkins/job/wrf_clubb_silhs_parallel_ifort/242/240http://carson.math.uwm.edu/jenkins/job/wrf_clubb_silhs_parallel_ifort/240/