Started by an SCM change76d3946a586f66f155af6c32d7c6f9ed92389388cfd3946a586f66f155af6c32d7c6f9ed92389388cforigin/masterd3946a586f66f155af6c32d7c6f9ed92389388cfd3946a586f66f155af6c32d7c6f9ed92389388cforigin/master72c7eb33836dd22870dc48b2acd2b5b340dbeef909c7eb33836dd22870dc48b2acd2b5b340dbeef909origin/changes_to_not_breakc7eb33836dd22870dc48b2acd2b5b340dbeef909c7eb33836dd22870dc48b2acd2b5b340dbeef909origin/changes_to_not_break217c9a130e75edce72d1bbca425e82077b526393ae2c9a130e75edce72d1bbca425e82077b526393ae2refs/remotes/origin/masterc9a130e75edce72d1bbca425e82077b526393ae2c9a130e75edce72d1bbca425e82077b526393ae2refs/remotes/origin/masterc9a130e75edce72d1bbca425e82077b526393ae2c9a130e75edce72d1bbca425e82077b526393ae2refs/remotes/origin/masterhttps://github.com/larson-group/wrf.githttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/wrf_clubb_silhs_parallel_ifort/detail/wrf_clubb_silhs_parallel_ifort/217/artifactshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/wrf_clubb_silhs_parallel_ifort/detail/wrf_clubb_silhs_parallel_ifort/217/changeshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/wrf_clubb_silhs_parallel_ifort/detail/wrf_clubb_silhs_parallel_ifort/217/http://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/wrf_clubb_silhs_parallel_ifort/detail/wrf_clubb_silhs_parallel_ifort/217/testsfalseRun WRF_Parallel_test.shfalse#21732964931496309wrf_clubb_silhs_parallel_ifort #217217false21717685SUCCESS1660810808411http://carson.math.uwm.edu/jenkins/job/wrf_clubb_silhs_parallel_ifort/217/pdf_closure_module.F90493cf3aafada57c53b1508b2b5990ce0a7dcafea1660756368000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI have optimized the new w_up_in_cloud and w_down_in_cloud code by only doing repeated operations one time and then saving them as a local variable. Since the numerical order of operations changes for the argument to the EXP term, the results will differ at the level of numerical round-off, making this revision not bit-for-bit with the last revision. This only affects the w_up_in_cloud and w_down_in_cloud statistical output variables, which in turn are not output as part of standard_stats.in. 2022-08-17 12:12:48 -0500493cf3aafada57c53b1508b2b5990ce0a7dcafeaI have optimized the new w_up_in_cloud and w_down_in_cloud code byeditpdf_closure_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2falseStarted by an SCM change76d3946a586f66f155af6c32d7c6f9ed92389388cfd3946a586f66f155af6c32d7c6f9ed92389388cforigin/masterd3946a586f66f155af6c32d7c6f9ed92389388cfd3946a586f66f155af6c32d7c6f9ed92389388cforigin/master72c7eb33836dd22870dc48b2acd2b5b340dbeef909c7eb33836dd22870dc48b2acd2b5b340dbeef909origin/changes_to_not_breakc7eb33836dd22870dc48b2acd2b5b340dbeef909c7eb33836dd22870dc48b2acd2b5b340dbeef909origin/changes_to_not_break2185fd8512865175fe77329db6fd386cc2f27bf8aa25fd8512865175fe77329db6fd386cc2f27bf8aa2refs/remotes/origin/master5fd8512865175fe77329db6fd386cc2f27bf8aa25fd8512865175fe77329db6fd386cc2f27bf8aa2refs/remotes/origin/master5fd8512865175fe77329db6fd386cc2f27bf8aa25fd8512865175fe77329db6fd386cc2f27bf8aa2refs/remotes/origin/masterhttps://github.com/larson-group/wrf.gitfalse#21825825311496309wrf_clubb_silhs_parallel_ifort #218218false21817861FAILURE1661934009776http://carson.math.uwm.edu/jenkins/job/wrf_clubb_silhs_parallel_ifort/218/advance_wp2_wp3_module.F90fill_holes.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90clubb_api_module.F90ab4282b0f6e0a3a1e3404836c96121fb79a872d41661881531000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comRefactored fill_holes_vertical to make GPUization simple. This is BIT_CHANGING, but results are bit-for-bit when using -O0 optimization, thus it is not answer changing. The first pass over each grid column will not parallelize well, the k-loop needs to be done in serial. Maximum parallelization has been exposed for the global hole-filling though, at the cost of occasionally doing unneccesary calculations. larson-group/clubb#972. 2022-08-30 12:45:31 -0500ab4282b0f6e0a3a1e3404836c96121fb79a872d4Refactored fill_holes_vertical to make GPUization simple. This is BIT_CHANGING, but results are bit-for-bit when using -O0 optimization, thus it is not answer changing. The first pass over each grid column will not parallelize well, the k-loop needs to be done in serial. Maximum parallelization has been exposed for the global hole-filling though, at the cost of occasionally doing unneccesary calculations. larson-group/clubb#972.editadvance_wp2_wp3_module.F90editadvance_xm_wpxp_module.F90editadvance_clubb_core_module.F90editfill_holes.F90editadvance_xp2_xpyp_module.F90editclubb_api_module.F90advance_wp2_wp3_module.F90fill_holes.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90constants_clubb.F90b0eeb2ebed4160829305c9a13bc60818b045fb221661881531000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comRemoving fill_holes_multiplicative and replacing magic numbers with parameters from constants_clubb. larson-group/clubb#972 2022-08-30 12:45:31 -0500b0eeb2ebed4160829305c9a13bc60818b045fb22Removing fill_holes_multiplicative and replacing magic numbers with parameters from constants_clubb. larson-group/clubb#972editadvance_xp2_xpyp_module.F90editadvance_wp2_wp3_module.F90editadvance_xm_wpxp_module.F90editfill_holes.F90editconstants_clubb.F90editadvance_clubb_core_module.F90fill_holes.F90advance_clubb_core_module.F90stats_clubb_utilities.F90clubb_api_module.F90mono_flux_limiter.F90advance_helper_module.F900a21a67e8c0d8373ae4315241b338842259b1d691661881531000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comMoving vertical_avg and vertical_integral to advance_helper_module. larson-group/clubb#972 2022-08-30 12:45:31 -05000a21a67e8c0d8373ae4315241b338842259b1d69Moving vertical_avg and vertical_integral to advance_helper_module. larson-group/clubb#972editadvance_clubb_core_module.F90editmono_flux_limiter.F90editclubb_api_module.F90editstats_clubb_utilities.F90editfill_holes.F90editadvance_helper_module.F90latin_hypercube_driver_module.F9018677b4114aff3b59943c43e9207fc7a8630060e1661881531000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comMoving vertical_avg and vertical_integral to advance_helper_module. larson-group/clubb#972 2022-08-30 12:45:31 -050018677b4114aff3b59943c43e9207fc7a8630060eMoving vertical_avg and vertical_integral to advance_helper_module. larson-group/clubb#972editlatin_hypercube_driver_module.F90githttp://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwmfalse219http://carson.math.uwm.edu/jenkins/job/wrf_clubb_silhs_parallel_ifort/219/217http://carson.math.uwm.edu/jenkins/job/wrf_clubb_silhs_parallel_ifort/217/Started by an SCM change76d3946a586f66f155af6c32d7c6f9ed92389388cfd3946a586f66f155af6c32d7c6f9ed92389388cforigin/masterd3946a586f66f155af6c32d7c6f9ed92389388cfd3946a586f66f155af6c32d7c6f9ed92389388cforigin/master72c7eb33836dd22870dc48b2acd2b5b340dbeef909c7eb33836dd22870dc48b2acd2b5b340dbeef909origin/changes_to_not_breakc7eb33836dd22870dc48b2acd2b5b340dbeef909c7eb33836dd22870dc48b2acd2b5b340dbeef909origin/changes_to_not_break21692a055ad3094fb26220474d182c79d2abb0119c892a055ad3094fb26220474d182c79d2abb0119c8refs/remotes/origin/master92a055ad3094fb26220474d182c79d2abb0119c892a055ad3094fb26220474d182c79d2abb0119c8refs/remotes/origin/master92a055ad3094fb26220474d182c79d2abb0119c892a055ad3094fb26220474d182c79d2abb0119c8refs/remotes/origin/masterhttps://github.com/larson-group/wrf.gitfalse#21631140841496309wrf_clubb_silhs_parallel_ifort #216216false21617611SUCCESS1660724410496http://carson.math.uwm.edu/jenkins/job/wrf_clubb_silhs_parallel_ifort/216/pdf_closure_module.F90a7de6b09f4f0e09b48f663e2432b3e98b29bfe601660699106000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI altered the w_up_in_cloud and w_down_in_cloud code so that a thresholding is used similar to what is seen in the cloud fraction and cloud water code. If the PDF component mean of w more than the maximum allow number of standard deviations away from 0, the PDF component is either all-updrafty or all-downdrafty, and the code avoids expensive computations where large magnitude values can potentially be fed into ERF or EXP. Of course, the results are not bit-for-bit with the previous version, meaning that there are some situations where these thresholds come into effect. However, plots of all cases show no visible differences in w_up_in_cloud and w_down_in_cloud. Since w_up_in_cloud and w_down_in_cloud are not included in normal stats output, this commit does not change the bit-for-bitness of CLUBB code. 2022-08-16 20:18:26 -0500a7de6b09f4f0e09b48f663e2432b3e98b29bfe60I altered the w_up_in_cloud and w_down_in_cloud code so that aeditpdf_closure_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2false217http://carson.math.uwm.edu/jenkins/job/wrf_clubb_silhs_parallel_ifort/217/215http://carson.math.uwm.edu/jenkins/job/wrf_clubb_silhs_parallel_ifort/215/