Started by an SCM change6089ef37dcaa5a3dacd6c33a7b290a6bb5ffd1e24b89ef37dcaa5a3dacd6c33a7b290a6bb5ffd1e24brefs/remotes/origin/master89ef37dcaa5a3dacd6c33a7b290a6bb5ffd1e24b89ef37dcaa5a3dacd6c33a7b290a6bb5ffd1e24brefs/remotes/origin/master89ef37dcaa5a3dacd6c33a7b290a6bb5ffd1e24b89ef37dcaa5a3dacd6c33a7b290a6bb5ffd1e24brefs/remotes/origin/masterhttps://github.com/larson-group/sam_clubb.githttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/sam_clubb_silhs_gfortran_build/detail/sam_clubb_silhs_gfortran_build/60/artifactshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/sam_clubb_silhs_gfortran_build/detail/sam_clubb_silhs_gfortran_build/60/changeshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/sam_clubb_silhs_gfortran_build/detail/sam_clubb_silhs_gfortran_build/60/http://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/sam_clubb_silhs_gfortran_build/detail/sam_clubb_silhs_gfortran_build/60/testsfalseEdit MakefileEdit Default CaseCompileRun SAMfalse#6038228727272sam_clubb_silhs_gfortran_build #6060false605143SUCCESS1623831910367http://carson.math.uwm.edu/jenkins/job/sam_clubb_silhs_gfortran_build/60/- clubb_api_module.F90advance_xm_wpxp_module.F90pos_definite_module.F90grid_class.F90setup_clubb_pdf_params.F90mono_flux_limiter.F90advance_helper_module.F90advance_wp2_wp3_module.F90mixing_length.F90advance_xp2_xpyp_module.F90advance_xp3_module.F90advance_clubb_core_module.F90calc_pressure.F90e9c711c356a191855bdf3cdf1c1dca12fdee23221623708447000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduRemoving gr as a module variable from grid_class.
gr is now a module variable in clubb_api_module.
This was done in order to not break host models.
Additonally, gr is now being fed through the
arg list of all functions and subroutines that use
gr within grid_class.
Results are BFB identical.
For ticket #886.
2021-06-14 17:07:27 -0500e9c711c356a191855bdf3cdf1c1dca12fdee2322Removing gr as a module variable from grid_class.editsetup_clubb_pdf_params.F90editadvance_xp3_module.F90editclubb_api_module.F90editmono_flux_limiter.F90editcalc_pressure.F90editadvance_xp2_xpyp_module.F90editgrid_class.F90editadvance_helper_module.F90editadvance_xm_wpxp_module.F90editadvance_wp2_wp3_module.F90editadvance_clubb_core_module.F90editpos_definite_module.F90editmixing_length.F90
- latin_hypercube_driver_module.F902d285b867ee867dd2560429ba631d70db85eb3cc1623708447000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduRemoving gr as a module variable from grid_class.
gr is now a module variable in clubb_api_module.
This was done in order to not break host models.
Additonally, gr is now being fed through the
arg list of all functions and subroutines that use
gr within grid_class.
Results are BFB identical.
For ticket #886.
2021-06-14 17:07:27 -05002d285b867ee867dd2560429ba631d70db85eb3ccRemoving gr as a module variable from grid_class.editlatin_hypercube_driver_module.F90
- SCRIPTS/LES_setup/setup_LES_KK_micro.bash41c7b3b857676ff27bf6461799bf0eaf03f56b081623762941000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comAdding section to LES automation script that will copy the appropriate "grd" file into place for the DYCOMS_RF01 case.
2021-06-15 08:15:41 -050041c7b3b857676ff27bf6461799bf0eaf03f56b08Adding section to LES automation script that will copy the appropriate "grd" file into place for the DYCOMS_RF01 case.editSCRIPTS/LES_setup/setup_LES_KK_micro.bash
githttp://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephenshttp://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodeskfalseStarted by an SCM change617935497557e344817571f50a7d0a1491427650f27935497557e344817571f50a7d0a1491427650f2refs/remotes/origin/master7935497557e344817571f50a7d0a1491427650f27935497557e344817571f50a7d0a1491427650f2refs/remotes/origin/master7935497557e344817571f50a7d0a1491427650f27935497557e344817571f50a7d0a1491427650f2refs/remotes/origin/masterhttps://github.com/larson-group/sam_clubb.gitfalse#6132018727272sam_clubb_silhs_gfortran_build #6161false615216SUCCESS1623918306535http://carson.math.uwm.edu/jenkins/job/sam_clubb_silhs_gfortran_build/61/- stats_zm_module.F90f3acc6329ec1f2ec3085b8429539e9fe4fe2dd8d1623854429000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comFixing typo in stats_zm_module.F90. Background: Since this commit https://github.com/larson-group/clubb/commit/466c5383fa5c0cc85316c6d117826974a5e2e0a3# in August 2020 the upwp budget lines in Pyplotgen have not appeared to be balanced for any cases. It turns out the reason is that a comma and space were added to the upwp_tp variable name in stats_zm_module.F90 in the August 2020 commit. This unusual naming causes pyplotgen not to recognize this variable, so it doesn't get plotted and the lines appear unbalanced. However, since the budget balance test still found the variable, it kept passing successfully. This commit will fix the issue with the pyplotgen plotting by reverting the name to the standard format.
This is BIT_CHANGING since it will affect the name of the upwp_tp variable in the X_zm.nc netcdf file, but it will not change results.
2021-06-16 09:40:29 -0500f3acc6329ec1f2ec3085b8429539e9fe4fe2dd8dFixing typo in stats_zm_module.F90. Background: Since this commit https://github.com/larson-group/clubb/commit/466c5383fa5c0cc85316c6d117826974a5e2e0a3# in August 2020 the upwp budget lines in Pyplotgen have not appeared to be balanced for any cases. It turns out the reason is that a comma and space were added to the upwp_tp variable name in stats_zm_module.F90 in the August 2020 commit. This unusual naming causes pyplotgen not to recognize this variable, so it doesn't get plotted and the lines appear unbalanced. However, since the budget balance test still found the variable, it kept passing successfully. This commit will fix the issue with the pyplotgen plotting by reverting the name to the standard format.editstats_zm_module.F90
- stats_sfc_module.F9012611fa39ab6962bb81a2b6b85ffa1b2b02515b81623855537000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comFixing a typo from an earlier commit.
See comments in this other commit where a similar typo was fixed: https://github.com/larson-group/clubb/commit/a4f5f736cb16168f40fdc01e454930ffa05fbb4d.
2021-06-16 09:58:57 -050012611fa39ab6962bb81a2b6b85ffa1b2b02515b8Fixing a typo from an earlier commit.editstats_sfc_module.F90
githttp://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephenshttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse62http://carson.math.uwm.edu/jenkins/job/sam_clubb_silhs_gfortran_build/62/60http://carson.math.uwm.edu/jenkins/job/sam_clubb_silhs_gfortran_build/60/Started by an SCM change59a4698838c228633a917a89ccb1396ba4a2f4ef59a4698838c228633a917a89ccb1396ba4a2f4ef59refs/remotes/origin/mastera4698838c228633a917a89ccb1396ba4a2f4ef59a4698838c228633a917a89ccb1396ba4a2f4ef59refs/remotes/origin/mastera4698838c228633a917a89ccb1396ba4a2f4ef59a4698838c228633a917a89ccb1396ba4a2f4ef59refs/remotes/origin/masterhttps://github.com/larson-group/sam_clubb.gitfalse#5941092727272sam_clubb_silhs_gfortran_build #5959false595081SUCCESS1623399907052http://carson.math.uwm.edu/jenkins/job/sam_clubb_silhs_gfortran_build/59/- clubb_api_module.F90advance_xm_wpxp_module.F90clip_explicit.F90stats_type_utilities.F90setup_clubb_pdf_params.F90advance_windm_edsclrm_module.F90new_pdf_main.F90advance_helper_module.F90mono_flux_limiter.F90mixing_length.F90new_tsdadg_pdf.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90LY93_pdf.F90pdf_closure_module.F90Skx_module.F90adg1_adg2_3d_luhar_pdf.F90calc_pressure.F90new_hybrid_pdf_main.F90diffusion.F90numerical_check.F90pos_definite_module.F90parameters_tunable.F90new_pdf.F90sponge_layer_damping.F90turbulent_adv_pdf.F90advance_xp3_module.F90advance_clubb_core_module.F90mean_adv.F90fill_holes.F90stats_clubb_utilities.F900cfbaf10bec50578a3d23d60c986191dc8f8f17f1622741937000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduFeeding gr through the arg list where need only in the CLUBB_core dir.
Note, that since some of the functions/subroutines in CLUBB_core are
used elsewhere throughout clubb, other parts of clubb such as a file
in SILHS, and a few in the outer layer of the source folder needed to be
updated in order to reflect the changes.
However, everything outside of the CLUBB_core directory still uses use
statements in order to use gr from grid class.
For ticket #886.
All changes are confirmed BFB identical.
2021-06-03 12:38:57 -05000cfbaf10bec50578a3d23d60c986191dc8f8f17fFeeding gr through the arg list where need only in the CLUBB_core dir.editfill_holes.F90editpdf_closure_module.F90editmixing_length.F90editcalc_pressure.F90editnew_tsdadg_pdf.F90editadvance_wp2_wp3_module.F90editmean_adv.F90editLY93_pdf.F90editadvance_helper_module.F90editSkx_module.F90editnew_pdf.F90editsponge_layer_damping.F90editstats_type_utilities.F90editadvance_windm_edsclrm_module.F90editparameters_tunable.F90editclubb_api_module.F90editnew_hybrid_pdf_main.F90editstats_clubb_utilities.F90editadg1_adg2_3d_luhar_pdf.F90editadvance_xp3_module.F90editsetup_clubb_pdf_params.F90editnew_pdf_main.F90editturbulent_adv_pdf.F90editpos_definite_module.F90editadvance_xm_wpxp_module.F90editnumerical_check.F90editadvance_xp2_xpyp_module.F90editdiffusion.F90editmono_flux_limiter.F90editadvance_clubb_core_module.F90editclip_explicit.F90
- latin_hypercube_driver_module.F901b027ccefb7868330c541c9b332cbd580760d6461622741937000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduFeeding gr through the arg list where need only in the CLUBB_core dir.
Note, that since some of the functions/subroutines in CLUBB_core are
used elsewhere throughout clubb, other parts of clubb such as a file
in SILHS, and a few in the outer layer of the source folder needed to be
updated in order to reflect the changes.
However, everything outside of the CLUBB_core directory still uses use
statements in order to use gr from grid class.
For ticket #886.
All changes are confirmed BFB identical.
2021-06-03 12:38:57 -05001b027ccefb7868330c541c9b332cbd580760d646Feeding gr through the arg list where need only in the CLUBB_core dir.editlatin_hypercube_driver_module.F90
- clubb_api_module.F90a07f02019041c31ee98f96b6100143738ed5a1391622745453000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduReverted changes to clubb_api. For #886
2021-06-03 13:37:33 -0500a07f02019041c31ee98f96b6100143738ed5a139Reverted changes to clubb_api. For #886editclubb_api_module.F90
- clubb_api_module.F90advance_xm_wpxp_module.F90clip_explicit.F90numerical_check.F90new_pdf.F90advance_windm_edsclrm_module.F90new_pdf_main.F90mono_flux_limiter.F90advance_helper_module.F90mixing_length.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90advance_xp3_module.F90advance_clubb_core_module.F90LY93_pdf.F90fill_holes.F90Skx_module.F90pdf_closure_module.F90adg1_adg2_3d_luhar_pdf.F90f69f33864903e6c39a38b0227ab07686d9812d371622821498000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduReplacing use gr statements with feeding gr throught the arg list.
This commit is for slight improvement to the script in order to
better adhere to the coding standard.
For ticket #886.
Results confirmed to be BFB identical.
2021-06-04 10:44:58 -0500f69f33864903e6c39a38b0227ab07686d9812d37Replacing use gr statements with feeding gr throught the arg list.editadvance_windm_edsclrm_module.F90editadvance_xp3_module.F90editclubb_api_module.F90editmono_flux_limiter.F90editadvance_helper_module.F90editadvance_clubb_core_module.F90editSkx_module.F90editadvance_xm_wpxp_module.F90editnumerical_check.F90editadvance_xp2_xpyp_module.F90editmixing_length.F90editpdf_closure_module.F90editclip_explicit.F90editadg1_adg2_3d_luhar_pdf.F90editfill_holes.F90editLY93_pdf.F90editnew_pdf_main.F90editadvance_wp2_wp3_module.F90editnew_pdf.F90
- advance_xm_wpxp_module.F90clip_explicit.F90setup_clubb_pdf_params.F90new_pdf_main.F90advance_windm_edsclrm_module.F90advance_helper_module.F90advance_wp2_wp3_module.F90mixing_length.F90file_functions.F90advance_xp2_xpyp_module.F90output_grads.F90Skx_module.F90calc_pressure.F90clip_semi_implicit.F90numerical_check.F90pos_definite_module.F90output_netcdf.F90stats_lh_sfc_module.F90saturation.F90advance_xp3_module.F90mean_adv.F90stats_sfc_module.F90parameters_model.F90matrix_operations.F90calendar.F90clubb_api_module.F90stats_lh_zt_module.F90input_reader.F90stats_type_utilities.F90diagnose_correlations_module.F90grid_class.F90mono_flux_limiter.F90new_tsdadg_pdf.F90LY93_pdf.F90stats_rad_zm_module.F90pdf_closure_module.F90adg1_adg2_3d_luhar_pdf.F90new_hybrid_pdf_main.F90corr_varnce_module.F90diffusion.F90endian.F90parameters_tunable.F90new_pdf.F90sponge_layer_damping.F90turbulent_adv_pdf.F90advance_clubb_core_module.F90lapack_wrap.F90fill_holes.F90interpolation.F90stats_clubb_utilities.F90T_in_K_module.F909484b3d4d27daff3a31a7c020ba41d96a174f4121623168054000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduFixed spacing issue when adding in gr. BFB identical. For #886.
2021-06-08 11:00:54 -05009484b3d4d27daff3a31a7c020ba41d96a174f412Fixed spacing issue when adding in gr. BFB identical. For #886.editadvance_xp3_module.F90editstats_lh_zt_module.F90editcorr_varnce_module.F90editfill_holes.F90editcalendar.F90editdiffusion.F90editnew_pdf_main.F90editclip_semi_implicit.F90editadvance_helper_module.F90editadvance_xp2_xpyp_module.F90editmono_flux_limiter.F90editpdf_closure_module.F90editpos_definite_module.F90editstats_type_utilities.F90editturbulent_adv_pdf.F90editadvance_clubb_core_module.F90editmean_adv.F90editstats_sfc_module.F90editadvance_windm_edsclrm_module.F90editadg1_adg2_3d_luhar_pdf.F90editadvance_wp2_wp3_module.F90editparameters_model.F90editstats_lh_sfc_module.F90editparameters_tunable.F90editfile_functions.F90editgrid_class.F90editinput_reader.F90editsaturation.F90editLY93_pdf.F90editlapack_wrap.F90editclubb_api_module.F90editSkx_module.F90editmixing_length.F90editadvance_xm_wpxp_module.F90editclip_explicit.F90editnew_hybrid_pdf_main.F90editoutput_netcdf.F90editstats_rad_zm_module.F90editcalc_pressure.F90editnumerical_check.F90editsetup_clubb_pdf_params.F90editinterpolation.F90editmatrix_operations.F90editdiagnose_correlations_module.F90editoutput_grads.F90editnew_pdf.F90editstats_clubb_utilities.F90editsponge_layer_damping.F90editnew_tsdadg_pdf.F90editT_in_K_module.F90editendian.F90
- latin_hypercube_driver_module.F90874b1c9283ea645f551250c83e1e8c357ddcb0dc1623168054000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduFixed spacing issue when adding in gr. BFB identical. For #886.
2021-06-08 11:00:54 -0500874b1c9283ea645f551250c83e1e8c357ddcb0dcFixed spacing issue when adding in gr. BFB identical. For #886.editlatin_hypercube_driver_module.F90
githttp://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskfalse60http://carson.math.uwm.edu/jenkins/job/sam_clubb_silhs_gfortran_build/60/58http://carson.math.uwm.edu/jenkins/job/sam_clubb_silhs_gfortran_build/58/