Started by an SCM change47ab2bd8e707b411f4eb6430a626ff7c3b1e8ac2a4ab2bd8e707b411f4eb6430a626ff7c3b1e8ac2a4refs/remotes/origin/masterab2bd8e707b411f4eb6430a626ff7c3b1e8ac2a4ab2bd8e707b411f4eb6430a626ff7c3b1e8ac2a4refs/remotes/origin/masterab2bd8e707b411f4eb6430a626ff7c3b1e8ac2a4ab2bd8e707b411f4eb6430a626ff7c3b1e8ac2a4refs/remotes/origin/masterhttps://github.com/larson-group/sam_clubb.githttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/sam_clubb_silhs_gfortran_build/detail/sam_clubb_silhs_gfortran_build/47/artifactshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/sam_clubb_silhs_gfortran_build/detail/sam_clubb_silhs_gfortran_build/47/changeshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/sam_clubb_silhs_gfortran_build/detail/sam_clubb_silhs_gfortran_build/47/http://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/sam_clubb_silhs_gfortran_build/detail/sam_clubb_silhs_gfortran_build/47/testsfalseEdit MakefileEdit Default CaseCompileRun SAMfalse#4733527727272sam_clubb_silhs_gfortran_build #4747false474397FAILURE1620807908824http://carson.math.uwm.edu/jenkins/job/sam_clubb_silhs_gfortran_build/47/advance_wp2_wp3_module.F90stats_variables.F90stats_zt_module.F9037095bf5ace54791fd4db1161ba1f8e010cb9ac21620739983000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comAdding some new code that puts the diffusion term d(wp2*em)/dz into a new function, creates a new wp3 budget term (wp3_pr_dfsn), and adds that new budget term to pyplotgen. 2021-05-11 08:33:03 -050037095bf5ace54791fd4db1161ba1f8e010cb9ac2Adding some new code that puts the diffusion term d(wp2*em)/dz into a new function, creates a new wp3 budget term (wp3_pr_dfsn), and adds that new budget term to pyplotgen.editadvance_wp2_wp3_module.F90editstats_variables.F90editstats_zt_module.F90advance_wp2_wp3_module.F90parameters_tunable.F90parameter_indices.F90clubb_api_module.F90bc7ddc176b62b69e5f4d20e730795946851ea82e1620739983000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comAdding new coefficient to control the wp3 pressure diffusion term. 2021-05-11 08:33:03 -0500bc7ddc176b62b69e5f4d20e730795946851ea82eAdding new coefficient to control the wp3 pressure diffusion term.editparameters_tunable.F90editadvance_wp2_wp3_module.F90editparameter_indices.F90editclubb_api_module.F90advance_wp2_wp3_module.F9096e5f1e5197fb6e1e353d02f5b211b1e8c5f96af1620739983000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comSome minor updates to advance_wp2_wp3 relevant to the pr_turb and pr_dfsn terms. 2021-05-11 08:33:03 -050096e5f1e5197fb6e1e353d02f5b211b1e8c5f96afSome minor updates to advance_wp2_wp3 relevant to the pr_turb and pr_dfsn terms.editadvance_wp2_wp3_module.F90advance_wp2_wp3_module.F90stats_clubb_utilities.F906126e2953143ab61f74665b3922ee4cc94894fae1620739983000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comConverting em*d(em)/dz to d(em^2)/dz in the wp3_pr_turb term and fixing a typo. 2021-05-11 08:33:03 -05006126e2953143ab61f74665b3922ee4cc94894faeConverting em*d(em)/dz to d(em^2)/dz in the wp3_pr_turb term and fixing a typo.editadvance_wp2_wp3_module.F90editstats_clubb_utilities.F90advance_wp2_wp3_module.F90parameters_tunable.F90parameter_indices.F90clubb_api_module.F900566da01bc8cc1fa3a19f92f3b19f1a4d453839d1620739983000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comRenaming C_wp3_turb --> C_wp3_pr_turb (BIT_CHANGING due to name change in netcdf output). See #884. 2021-05-11 08:33:03 -05000566da01bc8cc1fa3a19f92f3b19f1a4d453839dRenaming C_wp3_turb --> C_wp3_pr_turb (BIT_CHANGING due to name change in netcdf output).editparameters_tunable.F90editparameter_indices.F90editclubb_api_module.F90editadvance_wp2_wp3_module.F90advance_wp2_wp3_module.F90pdf_closure_module.F90stats_variables.F90stats_zm_module.F90stats_clubb_utilities.F90advance_clubb_core_module.F9045aa88a48da8927786467626eea335eea48498bc1620739983000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comThese changes add the new fourth-order moment variables wp2up2 and wp2vp2 to the CLUBB code. This requires a new function in pdf_closure_module since they must be calculated separately with a new formula, and they are fed through into advance_wp2_wp3 for use with the pr_dfsn subroutine. They are also added to the standard stats file and will be output to netcdf, hence this commit is BIT_CHANGING. The new variables are also added to pyplotgen as part of VariableGroupWs.py where wp4 is found. See #920. 2021-05-11 08:33:03 -050045aa88a48da8927786467626eea335eea48498bcThese changes add the new fourth-order moment variables wp2up2 and wp2vp2 to the CLUBB code. This requires a new function in pdf_closure_module since they must be calculated separately with a new formula, and they are fed through into advance_wp2_wp3 for use with the pr_dfsn subroutine. They are also added to the standard stats file and will be output to netcdf, hence this commit is BIT_CHANGING.editstats_variables.F90editstats_zm_module.F90editpdf_closure_module.F90editadvance_wp2_wp3_module.F90editstats_clubb_utilities.F90editadvance_clubb_core_module.F90tunable_parameters.inf93e240972461676abf906e01b37399306126ead1620739983000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comAdding new coefficient to control the wp3 pressure diffusion term. 2021-05-11 08:33:03 -0500f93e240972461676abf906e01b37399306126eadAdding new coefficient to control the wp3 pressure diffusion term.edittunable_parameters.inadvance_wp2_wp3_module.F9012176c345358d78a4d827cf2b6e7abdbaec0ea8c1620739983000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comPutting the wp3_pr_turb formulation back to its d(rho*wp2*em)/dz form. This would be a BIT_CHANGING commit since it would change the answers for the pr_turb term. However once this branch is merged into the master branch, results should be bit-for-bit since this term was only modified in the alternate branch. See #920. 2021-05-11 08:33:03 -050012176c345358d78a4d827cf2b6e7abdbaec0ea8cPutting the wp3_pr_turb formulation back to its d(rho*wp2*em)/dz form. This would be a BIT_CHANGING commit since it would change the answers for the pr_turb term. However once this branch is merged into the master branch, results should be bit-for-bit since this term was only modified in the alternate branch.editadvance_wp2_wp3_module.F90tunable_parameters.in35540475b191c71945e840eb1b1d43b19ef485121620739983000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comThese changes add the new fourth-order moment variables wp2up2 and wp2vp2 to the CLUBB code. This requires a new function in pdf_closure_module since they must be calculated separately with a new formula, and they are fed through into advance_wp2_wp3 for use with the pr_dfsn subroutine. They are also added to the standard stats file and will be output to netcdf, hence this commit is BIT_CHANGING. The new variables are also added to pyplotgen as part of VariableGroupWs.py where wp4 is found. See #920. 2021-05-11 08:33:03 -050035540475b191c71945e840eb1b1d43b19ef48512These changes add the new fourth-order moment variables wp2up2 and wp2vp2 to the CLUBB code. This requires a new function in pdf_closure_module since they must be calculated separately with a new formula, and they are fed through into advance_wp2_wp3 for use with the pr_dfsn subroutine. They are also added to the standard stats file and will be output to netcdf, hence this commit is BIT_CHANGING.edittunable_parameters.instats_type_utilities.F90interpolation.F90advance_clubb_core_module.F90advance_windm_edsclrm_module.F90calc_pressure.F90advance_helper_module.F901dbc0bf3a0b130e9c249a7142eefba732e17b1e71620766665000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@uwm.eduAdded intent comments for the following files: advance_clubb_core_module, advance_helper_module, and advance_windm_edsclrm_module. These changes are BFB. For ticket #924. 2021-05-11 15:57:45 -05001dbc0bf3a0b130e9c249a7142eefba732e17b1e7Added intent comments for the following files:editinterpolation.F90editstats_type_utilities.F90editadvance_helper_module.F90editadvance_windm_edsclrm_module.F90editadvance_clubb_core_module.F90editcalc_pressure.F90githttp://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodeskfalseStarted by an SCM change481bc0e396ccdf45614c28ebf93babbefc099793ba1bc0e396ccdf45614c28ebf93babbefc099793barefs/remotes/origin/master1bc0e396ccdf45614c28ebf93babbefc099793ba1bc0e396ccdf45614c28ebf93babbefc099793barefs/remotes/origin/master1bc0e396ccdf45614c28ebf93babbefc099793ba1bc0e396ccdf45614c28ebf93babbefc099793barefs/remotes/origin/masterhttps://github.com/larson-group/sam_clubb.gitfalse#4831083727272sam_clubb_silhs_gfortran_build #4848false484455SUCCESS1620894306922http://carson.math.uwm.edu/jenkins/job/sam_clubb_silhs_gfortran_build/48/configurable_model_flags.ine76e585977733881be1a7e0dc5463a473f6dab901620854783000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comSetting l_update_pressure = .false. since it was causing a problem with the MC3E test and is turned off in all host models anyway. This is BIT_CHANGING. See https://github.com/larson-group/e3sm/issues/6. 2021-05-12 16:26:23 -0500e76e585977733881be1a7e0dc5463a473f6dab90Setting l_update_pressure = .false. since it was causing a problem with the MC3E test and is turned off in all host models anyway.editconfigurable_model_flags.inadvance_clubb_core_module.F90pdf_closure_module.F90e4f82e1b3305f7216e84599127b6cd77ee518c291620868004000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comRemoving "if" statement around calculation of wp4 in pdf_closure_module.F90 and the same "if" statement around some further manipulation of wp4 in advance_clubb_core. Results are bit-for-bit with this change, since normally all cases calculate wp4 anyway since the "if" condition was always satisfied in normal runs (but not, for example, in some tuning runs). This was done because the new wp3_pr_dfsn term needs wp4 in its current formulation so it needs to always be calculated. See #920. 2021-05-12 20:06:44 -0500e4f82e1b3305f7216e84599127b6cd77ee518c29Removing "if" statement around calculation of wp4 in pdf_closure_module.F90 and the same "if" statement around some further manipulation of wp4 in advance_clubb_core. Results are bit-for-bit with this change, since normally all cases calculate wp4 anyway since the "if" condition was always satisfied in normal runs (but not, for example, in some tuning runs). This was done because the new wp3_pr_dfsn term needs wp4 in its current formulation so it needs to always be calculated.editpdf_closure_module.F90editadvance_clubb_core_module.F90githttp://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephenshttp://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens82http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskfalse49http://carson.math.uwm.edu/jenkins/job/sam_clubb_silhs_gfortran_build/49/47http://carson.math.uwm.edu/jenkins/job/sam_clubb_silhs_gfortran_build/47/Started by an SCM change46bc96e2f86f9310c0062e75ca48d7b4bbb7a32508bc96e2f86f9310c0062e75ca48d7b4bbb7a32508refs/remotes/origin/masterbc96e2f86f9310c0062e75ca48d7b4bbb7a32508bc96e2f86f9310c0062e75ca48d7b4bbb7a32508refs/remotes/origin/masterbc96e2f86f9310c0062e75ca48d7b4bbb7a32508bc96e2f86f9310c0062e75ca48d7b4bbb7a32508refs/remotes/origin/masterhttps://github.com/larson-group/sam_clubb.gitfalse#4648892727272sam_clubb_silhs_gfortran_build #4646false464335SUCCESS1620203111156http://carson.math.uwm.edu/jenkins/job/sam_clubb_silhs_gfortran_build/46/stats_zm_module.F90sigma_sqd_w_module.F901815b8d8e89cbab82c01be0200dd23e100182fd51620165243000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@uwm.eduChanged safeguard threshold in sigma_sqd_w. This is BIT_CHANGING. For ticket #917. 2021-05-04 16:54:03 -05001815b8d8e89cbab82c01be0200dd23e100182fd5Changed safeguard threshold in sigma_sqd_w.editstats_zm_module.F90editsigma_sqd_w_module.F90githttp://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskfalse47http://carson.math.uwm.edu/jenkins/job/sam_clubb_silhs_gfortran_build/47/45http://carson.math.uwm.edu/jenkins/job/sam_clubb_silhs_gfortran_build/45/