Started by an SCM change823655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master3655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master84d63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixesd63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixes75c5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_breakc5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_break681344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break1344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break811d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates1d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates214975fa97b14103592c782933d685bdc2c460a1147975fa97b14103592c782933d685bdc2c460a1147refs/remotes/origin/master975fa97b14103592c782933d685bdc2c460a1147975fa97b14103592c782933d685bdc2c460a1147refs/remotes/origin/master975fa97b14103592c782933d685bdc2c460a1147975fa97b14103592c782933d685bdc2c460a1147refs/remotes/origin/masterhttps://github.com/larson-group/sam_clubb.githttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/sam_clubb_silhs_gfortran_build/detail/sam_clubb_silhs_gfortran_build/214/artifactshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/sam_clubb_silhs_gfortran_build/detail/sam_clubb_silhs_gfortran_build/214/changeshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/sam_clubb_silhs_gfortran_build/detail/sam_clubb_silhs_gfortran_build/214/http://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/sam_clubb_silhs_gfortran_build/detail/sam_clubb_silhs_gfortran_build/214/testsfalseEdit MakefileEdit Default CaseCompileRun SAMfalse#2141981341727272sam_clubb_silhs_gfortran_build #214214false21417689SUCCESS1660811108438http://carson.math.uwm.edu/jenkins/job/sam_clubb_silhs_gfortran_build/214/pdf_closure_module.F90493cf3aafada57c53b1508b2b5990ce0a7dcafea1660756368000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI have optimized the new w_up_in_cloud and w_down_in_cloud code by only doing repeated operations one time and then saving them as a local variable. Since the numerical order of operations changes for the argument to the EXP term, the results will differ at the level of numerical round-off, making this revision not bit-for-bit with the last revision. This only affects the w_up_in_cloud and w_down_in_cloud statistical output variables, which in turn are not output as part of standard_stats.in. 2022-08-17 12:12:48 -0500493cf3aafada57c53b1508b2b5990ce0a7dcafeaI have optimized the new w_up_in_cloud and w_down_in_cloud code byeditpdf_closure_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2falseStarted by an SCM change823655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master3655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master84d63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixesd63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixes75c5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_breakc5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_break681344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break1344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break811d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates1d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates2153063e93b9803fe442b6d9317a0676b373a45d6583063e93b9803fe442b6d9317a0676b373a45d658refs/remotes/origin/master3063e93b9803fe442b6d9317a0676b373a45d6583063e93b9803fe442b6d9317a0676b373a45d658refs/remotes/origin/master3063e93b9803fe442b6d9317a0676b373a45d6583063e93b9803fe442b6d9317a0676b373a45d658refs/remotes/origin/masterhttps://github.com/larson-group/sam_clubb.gitfalse#2151674470727272sam_clubb_silhs_gfortran_build #215215false21517865FAILURE1661934309864http://carson.math.uwm.edu/jenkins/job/sam_clubb_silhs_gfortran_build/215/fill_holes.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90clubb_api_module.F90ab4282b0f6e0a3a1e3404836c96121fb79a872d41661881531000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comRefactored fill_holes_vertical to make GPUization simple. This is BIT_CHANGING, but results are bit-for-bit when using -O0 optimization, thus it is not answer changing. The first pass over each grid column will not parallelize well, the k-loop needs to be done in serial. Maximum parallelization has been exposed for the global hole-filling though, at the cost of occasionally doing unneccesary calculations. larson-group/clubb#972. 2022-08-30 12:45:31 -0500ab4282b0f6e0a3a1e3404836c96121fb79a872d4Refactored fill_holes_vertical to make GPUization simple. This is BIT_CHANGING, but results are bit-for-bit when using -O0 optimization, thus it is not answer changing. The first pass over each grid column will not parallelize well, the k-loop needs to be done in serial. Maximum parallelization has been exposed for the global hole-filling though, at the cost of occasionally doing unneccesary calculations. larson-group/clubb#972.editfill_holes.F90editadvance_xm_wpxp_module.F90editclubb_api_module.F90editadvance_wp2_wp3_module.F90editadvance_clubb_core_module.F90editadvance_xp2_xpyp_module.F90advance_wp2_wp3_module.F90fill_holes.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90constants_clubb.F90b0eeb2ebed4160829305c9a13bc60818b045fb221661881531000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comRemoving fill_holes_multiplicative and replacing magic numbers with parameters from constants_clubb. larson-group/clubb#972 2022-08-30 12:45:31 -0500b0eeb2ebed4160829305c9a13bc60818b045fb22Removing fill_holes_multiplicative and replacing magic numbers with parameters from constants_clubb. larson-group/clubb#972editadvance_wp2_wp3_module.F90editadvance_xm_wpxp_module.F90editadvance_clubb_core_module.F90editadvance_xp2_xpyp_module.F90editconstants_clubb.F90editfill_holes.F90fill_holes.F90stats_clubb_utilities.F90advance_clubb_core_module.F90clubb_api_module.F90mono_flux_limiter.F90advance_helper_module.F900a21a67e8c0d8373ae4315241b338842259b1d691661881531000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comMoving vertical_avg and vertical_integral to advance_helper_module. larson-group/clubb#972 2022-08-30 12:45:31 -05000a21a67e8c0d8373ae4315241b338842259b1d69Moving vertical_avg and vertical_integral to advance_helper_module. larson-group/clubb#972editfill_holes.F90editmono_flux_limiter.F90editstats_clubb_utilities.F90editadvance_helper_module.F90editadvance_clubb_core_module.F90editclubb_api_module.F90latin_hypercube_driver_module.F9018677b4114aff3b59943c43e9207fc7a8630060e1661881531000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comMoving vertical_avg and vertical_integral to advance_helper_module. larson-group/clubb#972 2022-08-30 12:45:31 -050018677b4114aff3b59943c43e9207fc7a8630060eMoving vertical_avg and vertical_integral to advance_helper_module. larson-group/clubb#972editlatin_hypercube_driver_module.F90githttp://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwmfalse216http://carson.math.uwm.edu/jenkins/job/sam_clubb_silhs_gfortran_build/216/214http://carson.math.uwm.edu/jenkins/job/sam_clubb_silhs_gfortran_build/214/Started by an SCM change823655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master3655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master84d63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixesd63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixes75c5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_breakc5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_break681344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break1344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break811d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates1d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates213219eb0e64cb07a5fa6cdeeda1bd91b4a07c9aeef219eb0e64cb07a5fa6cdeeda1bd91b4a07c9aeefrefs/remotes/origin/master219eb0e64cb07a5fa6cdeeda1bd91b4a07c9aeef219eb0e64cb07a5fa6cdeeda1bd91b4a07c9aeefrefs/remotes/origin/master219eb0e64cb07a5fa6cdeeda1bd91b4a07c9aeef219eb0e64cb07a5fa6cdeeda1bd91b4a07c9aeefrefs/remotes/origin/masterhttps://github.com/larson-group/sam_clubb.gitfalse#2131720533727272sam_clubb_silhs_gfortran_build #213213false21317615SUCCESS1660724710517http://carson.math.uwm.edu/jenkins/job/sam_clubb_silhs_gfortran_build/213/jenkins_tests/sam_micro_drizzle_intel_test/Jenkinsfilec3df4b35a3ea7f0a68ffd33562ab2df95948546e1660681730000http://carson.math.uwm.edu/jenkins/user/cerniktcerniktcernikt@msoe.eduadding line to fix mpi configuration in micro drizzle test 2022-08-16 15:28:50 -0500c3df4b35a3ea7f0a68ffd33562ab2df95948546eadding line to fix mpi configuration in micro drizzle testeditjenkins_tests/sam_micro_drizzle_intel_test/Jenkinsfilepdf_closure_module.F90a7de6b09f4f0e09b48f663e2432b3e98b29bfe601660699106000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI altered the w_up_in_cloud and w_down_in_cloud code so that a thresholding is used similar to what is seen in the cloud fraction and cloud water code. If the PDF component mean of w more than the maximum allow number of standard deviations away from 0, the PDF component is either all-updrafty or all-downdrafty, and the code avoids expensive computations where large magnitude values can potentially be fed into ERF or EXP. Of course, the results are not bit-for-bit with the previous version, meaning that there are some situations where these thresholds come into effect. However, plots of all cases show no visible differences in w_up_in_cloud and w_down_in_cloud. Since w_up_in_cloud and w_down_in_cloud are not included in normal stats output, this commit does not change the bit-for-bitness of CLUBB code. 2022-08-16 20:18:26 -0500a7de6b09f4f0e09b48f663e2432b3e98b29bfe60I altered the w_up_in_cloud and w_down_in_cloud code so that aeditpdf_closure_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/cerniktcerniktfalse214http://carson.math.uwm.edu/jenkins/job/sam_clubb_silhs_gfortran_build/214/212http://carson.math.uwm.edu/jenkins/job/sam_clubb_silhs_gfortran_build/212/