Started by an SCM change863655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master3655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master88d63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixesd63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixes79c5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_breakc5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_break701344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break1344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break851d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates1d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates487be4ba9e2d1614f2681b8479a753f8ea6de3802b9be4ba9e2d1614f2681b8479a753f8ea6de3802b9refs/remotes/origin/masterbe4ba9e2d1614f2681b8479a753f8ea6de3802b9be4ba9e2d1614f2681b8479a753f8ea6de3802b9refs/remotes/origin/masterbe4ba9e2d1614f2681b8479a753f8ea6de3802b9be4ba9e2d1614f2681b8479a753f8ea6de3802b9refs/remotes/origin/masterhttps://github.com/larson-group/sam_clubb.githttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/sam_clubb_nvhpc_build/detail/sam_clubb_nvhpc_build/487/artifactshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/sam_clubb_nvhpc_build/detail/sam_clubb_nvhpc_build/487/changeshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/sam_clubb_nvhpc_build/detail/sam_clubb_nvhpc_build/487/http://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/sam_clubb_nvhpc_build/detail/sam_clubb_nvhpc_build/487/testsfalseEdit MakefileEdit Default CaseCompileRun SAMfalse#48713444611622982sam_clubb_nvhpc_build #487487false4873946SUCCESS1779871509783http://carson.math.uwm.edu/jenkins/job/sam_clubb_nvhpc_build/487/advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90advance_xp3_module.F90advance_xm_wpxp_module.F90stats_clubb_utilities.F90advance_helper_module.F9072b3ab76bcae108c36fc6d3130c7c9c4539bfc281779832578000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comClubb organization part2 (#1304) A number of fields were being calculated in `advance_clubb_core` (`wp2_zt` `wp3_on_wp2` `wp3_on_wp2_zt` `Skw_zm` `Skw_zt) then passed into other routines, however, all these fields depend on `wp2` and were not being updated after `wp2` was being updated by `calc_sfc_varnce`. This commit fixes that by moving where these fields are calculated - instead of computing in `advance_clubb_core` with the incoming `wp2`, we now calculate them "on-demand" where they are needed using the most recent value of `wp2`. Using our default flag set, there are no numerical differences caused by this change set, only a few stats differences. There are real differences that occur when `l_upwind_xpyp_ta = .false.` (a clubb_config_flag value) or when `l_explicit_turbulent_adv_xpyp = .true.` (a parameter in model_flags.F90), but these are small differences and do not visually affect plots for our stable cases. Changing the order of the `advance_` routines would also cause this to be BIT_CHANGING, since that also affects the update path for `wp2` - now these values that got moved would be using the newest `wp2` instead of being "stale", also causing small (but real) differences. * Calculating wp2_zt and wp3_on_wp2 where needed, rather than passing those values around through advance_clubb_core. This is BIT_CHANGING for a handful of stats only variables be default: wp3_on_wp2, wp3_on_wp2_zt, wp3_on_wp2_cfl_num, term_wprtp2_explicit, term_wprtpthlp_explicit, and term_wpthlp2_explicit. Some Skw_ variables when using lmm_stepping, and has actual differences (not just in stats output) when swapping the order of the advance routines * Moving things around, this seems to all be BFB except for the Skw_ movements, which is BIT_CHANGING if the advance_ order changes * Fixing python API * Reverting some BFB changes 2026-05-26 16:56:18 -050072b3ab76bcae108c36fc6d3130c7c9c4539bfc28Clubb organization part2 (#1304)editadvance_clubb_core_module.F90editstats_clubb_utilities.F90editadvance_wp2_wp3_module.F90editadvance_xm_wpxp_module.F90editadvance_helper_module.F90editadvance_xp2_xpyp_module.F90editadvance_xp3_module.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreplyfalseStarted by an SCM change863655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master3655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master88d63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixesd63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixes79c5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_breakc5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_break701344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break1344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break851d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates1d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates4861f7243e0875d734b8ab31cdbbc33e2d29af11b011f7243e0875d734b8ab31cdbbc33e2d29af11b01refs/remotes/origin/master1f7243e0875d734b8ab31cdbbc33e2d29af11b011f7243e0875d734b8ab31cdbbc33e2d29af11b01refs/remotes/origin/master1f7243e0875d734b8ab31cdbbc33e2d29af11b011f7243e0875d734b8ab31cdbbc33e2d29af11b01refs/remotes/origin/masterhttps://github.com/larson-group/sam_clubb.gitfalse#48611948781622982sam_clubb_nvhpc_build #486486false4863782SUCCESS1779266707356http://carson.math.uwm.edu/jenkins/job/sam_clubb_nvhpc_build/486/pdf_closure_module.F90af96de45b65cdea71bcbd4e2a22562062374a9221779217968000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduRemoving a couple variables from openacc statements to fix the clubb_driver_test - these were causing stats errors on the GPU for chi and chip2. This is technically BIT_CHANGING. 2026-05-19 14:12:48 -0500af96de45b65cdea71bcbd4e2a22562062374a922Removing a couple variables from openacc statements to fix the clubb_driver_test - these were causing stats errors on the GPU for chi and chip2. This is technically BIT_CHANGING.editpdf_closure_module.F90githttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse487http://carson.math.uwm.edu/jenkins/job/sam_clubb_nvhpc_build/487/485http://carson.math.uwm.edu/jenkins/job/sam_clubb_nvhpc_build/485/