Started by an SCM change863655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master3655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master88d63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixesd63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixes79c5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_breakc5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_break701344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break1344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break851d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates1d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates4534f00c694f613248ab7d4bae0333b7fae7c53e61f4f00c694f613248ab7d4bae0333b7fae7c53e61frefs/remotes/origin/master4f00c694f613248ab7d4bae0333b7fae7c53e61f4f00c694f613248ab7d4bae0333b7fae7c53e61frefs/remotes/origin/master4f00c694f613248ab7d4bae0333b7fae7c53e61f4f00c694f613248ab7d4bae0333b7fae7c53e61frefs/remotes/origin/masterhttps://github.com/larson-group/sam_clubb.githttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/sam_clubb_nvhpc_build/detail/sam_clubb_nvhpc_build/453/artifactshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/sam_clubb_nvhpc_build/detail/sam_clubb_nvhpc_build/453/changeshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/sam_clubb_nvhpc_build/detail/sam_clubb_nvhpc_build/453/http://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/sam_clubb_nvhpc_build/detail/sam_clubb_nvhpc_build/453/testsfalseEdit MakefileEdit Default CaseCompileRun SAMfalse#4531412430807834sam_clubb_nvhpc_build #453453false45312027SUCCESS1763113510527http://carson.math.uwm.edu/jenkins/job/sam_clubb_nvhpc_build/453/configurable_model_flags.in5f24af955cc6e7c188fbdc89df9732c457720bcd1763082040000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comNew fill_holes methods (#1262) * Adding little code bits to help explore fill_holes. This is just a diagnostic playground * Improvements * Maybe better algorithm? * Improvements to the new fill holes * Nice progress * Small tweaks * Mainly adding gptl option for cmake and new run_timestep_tests.py * Making namelist input for fill type, and adding ANOTHER new filler that should be completely parallelizable, but right now large hole groups steal too much from nearby points and it looks kinda bad. * Big improvements, new algorithm is good now * Small updates * Making new fill_holes_type flag for clubb_config_flags * New hybrid filler * Small fixes * Changes, mainly for performance, also adding -gptl option to compile.py to make it use the gptl library * Bunch of things * Updates * small fix * Various cleanup and comments * Small improvement to p_atomic * Updates for speed mainly * Small improvement to p_atomic * Potential improvement to p_atomic * Updates for speed mainly * Updates to make G_unit fill holes test * Improving new tests and making widening_windows and smart_window work in flipped grid mode * All methods passing G_unit test, still need a little cleanup * Slight comments update * Cleanup * Adding named constants for fill type * Uncommentting source checks after compile * Adding new file to old compile method * Small fixes * Small fixes * Mainly comments * Making G_unit test use the new python script and compiler method. Small bug fix too * Little fixes 2025-11-13 19:00:40 -06005f24af955cc6e7c188fbdc89df9732c457720bcdNew fill_holes methods (#1262)editconfigurable_model_flags.inmodel_flags.modadvance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90model_flags.F90advance_xm_wpxp_module.F90clubb_api_module.F90fill_holes.F90output_netcdf.F90CMakeLists.txt8aa1a13718befffb2cd6506f57eef8991f152a011763082040000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comNew fill_holes methods (#1262) * Adding little code bits to help explore fill_holes. This is just a diagnostic playground * Improvements * Maybe better algorithm? * Improvements to the new fill holes * Nice progress * Small tweaks * Mainly adding gptl option for cmake and new run_timestep_tests.py * Making namelist input for fill type, and adding ANOTHER new filler that should be completely parallelizable, but right now large hole groups steal too much from nearby points and it looks kinda bad. * Big improvements, new algorithm is good now * Small updates * Making new fill_holes_type flag for clubb_config_flags * New hybrid filler * Small fixes * Changes, mainly for performance, also adding -gptl option to compile.py to make it use the gptl library * Bunch of things * Updates * small fix * Various cleanup and comments * Small improvement to p_atomic * Updates for speed mainly * Small improvement to p_atomic * Potential improvement to p_atomic * Updates for speed mainly * Updates to make G_unit fill holes test * Improving new tests and making widening_windows and smart_window work in flipped grid mode * All methods passing G_unit test, still need a little cleanup * Slight comments update * Cleanup * Adding named constants for fill type * Uncommentting source checks after compile * Adding new file to old compile method * Small fixes * Small fixes * Mainly comments * Making G_unit test use the new python script and compiler method. Small bug fix too * Little fixes 2025-11-13 19:00:40 -06008aa1a13718befffb2cd6506f57eef8991f152a01New fill_holes methods (#1262)editmodel_flags.F90editCMakeLists.txtaddmodel_flags.modeditadvance_clubb_core_module.F90editadvance_xm_wpxp_module.F90editfill_holes.F90editadvance_wp2_wp3_module.F90editadvance_xp2_xpyp_module.F90editclubb_api_module.F90editoutput_netcdf.F90SRC/MICRO_M2005_UWM/microphysics.F90SRC/micro_field_utils.F90jenkins_tests/sam_clubb_silhs_gfortran_build/JenkinsfileBuildSRC/SGS_CLUBB/clubb_sgs.F90d54a1aa69c0181c09238fcb5e15c32ed23aaf1dd1763082148000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comMaking compatible with new version of clubb (#167) 2025-11-13 19:02:28 -0600d54a1aa69c0181c09238fcb5e15c32ed23aaf1ddMaking compatible with new version of clubb (#167)editSRC/MICRO_M2005_UWM/microphysics.F90editjenkins_tests/sam_clubb_silhs_gfortran_build/JenkinsfileeditSRC/micro_field_utils.F90editBuildeditSRC/SGS_CLUBB/clubb_sgs.F90fill_holes.F906df93a7b24b982fe08a25e35472d2d618f5099e51763105789000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduSmall bug fix in fill_holes_parallel on GPU 2025-11-14 01:36:29 -06006df93a7b24b982fe08a25e35472d2d618f5099e5Small bug fix in fill_holes_parallel on GPUeditfill_holes.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther HueblerhueblerfalseStarted by an SCM change863655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master3655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master88d63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixesd63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixes79c5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_breakc5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_break701344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break1344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break851d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates1d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates454c7fbb679bffeb3e355e3fd6ba957a7b40853e0d6c7fbb679bffeb3e355e3fd6ba957a7b40853e0d6refs/remotes/origin/masterc7fbb679bffeb3e355e3fd6ba957a7b40853e0d6c7fbb679bffeb3e355e3fd6ba957a7b40853e0d6refs/remotes/origin/masterc7fbb679bffeb3e355e3fd6ba957a7b40853e0d6c7fbb679bffeb3e355e3fd6ba957a7b40853e0d6refs/remotes/origin/masterhttps://github.com/larson-group/sam_clubb.gitfalse#45456816807834sam_clubb_nvhpc_build #454454false45412174SUCCESS1763286309810http://carson.math.uwm.edu/jenkins/job/sam_clubb_nvhpc_build/454/fill_holes.F90advance_wp2_wp3_module.F90error_code.F90error_code.modclip_explicit.F901e5a08c884195b6881a87df95750c474ce83c1881763184888000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking clubb_at_least_debug_level not a device routine. It confuses the poor little nvidia compiler when compiling inside cam. Also making the compile script a little more robust. 2025-11-14 23:34:48 -06001e5a08c884195b6881a87df95750c474ce83c188Making clubb_at_least_debug_level not a device routine. It confuses the poor little nvidia compiler when compiling inside cam. Also making the compile script a little more robust.editclip_explicit.F90adderror_code.modediterror_code.F90editfill_holes.F90editadvance_wp2_wp3_module.F90githttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse455http://carson.math.uwm.edu/jenkins/job/sam_clubb_nvhpc_build/455/453http://carson.math.uwm.edu/jenkins/job/sam_clubb_nvhpc_build/453/Started by user Gunther HueblerhueblerGunther Huebler863655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master3655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master88d63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixesd63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixes79c5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_breakc5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_break701344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break1344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break851d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates1d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates452e90794954660547af780fc0330b963efa8afbe25e90794954660547af780fc0330b963efa8afbe25refs/remotes/origin/mastere90794954660547af780fc0330b963efa8afbe25e90794954660547af780fc0330b963efa8afbe25refs/remotes/origin/mastere90794954660547af780fc0330b963efa8afbe25e90794954660547af780fc0330b963efa8afbe25refs/remotes/origin/masterhttps://github.com/larson-group/sam_clubb.gitfalse#45271023807834sam_clubb_nvhpc_build #452452false45211708SUCCESS1759719346808http://carson.math.uwm.edu/jenkins/job/sam_clubb_nvhpc_build/452/model_flags.F90advance_xm_wpxp_module.F90clubb_api_module.F90clip_explicit.F90numerical_check.F90output_netcdf.F90mt95.F90pdf_parameter_module.F90parameters_tunable.F90hydromet_pdf_parameter_module.F90grid_class.F90CMakeLists.txtadvance_windm_edsclrm_module.F90advance_helper_module.F90mixing_length.F90grid_adaptation_module.F90advance_clubb_core_module.F90pdf_closure_module.F90stats_clubb_utilities.F90sfc_varnce_module.F90parameters_model.F906061db38ecdeb1e2e7a5f50a1c0dfdb784e7a1551759715158000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comClubb driver upgrades part2 (#1257) * Initial commit. Breaking up clubb driver into sections. This should be bfb on everything, but this hasn't been checked well yet. * Combining namelist read into case init, same stuff really * Reorganizing many things, mainly in the pursuit of sectioning off code into groups like Microphys or Radiation * Organizing clubb_driver. All cases still BFB. * Mostly cosmetic improvements * Small improvements, comments, making clubb_driver_test to ensure consistency functionality of new compartmentalized model run components * Removing accidentally added files. * Mostly breaking up structure initialization behavior, split into init_ and zero_ so that we don't have to allocate to reset. * Doing away with clubb_model_settings and parameters_module in the spirit of consolidating functionality and spiting module variables. * Missed some changes to commit, should've been included in previous commit * Splitting up funcionality of setup_parameters. Now theres one part that calculates and another checks flag values. * GPU code working, but not BFB yet * GPU all BFB with mutliple columns, except gabls3, and driver test doesnt work (pass reinitialize, fails double timestep test) * Turning off multi_column output for the new driver test * Changes needed after rebase * Name changes, comments, and threadprivate additions for parallel runs * Adding variables to openacc data statements. Without this, the code crashes when using the GPU with l_godunov_upwind_xpyp_ta=.true. * Modifying compiler configurations (mainly optimization level) in order to prepare for switching scipts and tests to cmake, specifically separating out this BIT_CHANGING commit from the rest * thlm_ed and rtm_ed caused GPU errors since those variables were added to a acc loop, but never added to the acc data statement. This change makes it so they're only calculated on the CPU, since they are only used for stats, fixing the issue without adding the GPU memory footprint. * Adding -Mstack_arrays to the nvfortran flags causes us to use more stack space, which means we need to allow processes to use more stack space (when using lots of columns, since that increases memory footprint). We do by using using 'ulimit BIGNUMBER'. * Making old compiler script work with new file structure, also making Input_fields directory and library. * Missed text_writer_lib * Undoing Input_fields directory, it has too many depencencies currently, certainly can be simplified with argument lists. * Adding library dependency * Small changes to cmake list * Adding openmp flag back to gfortran script, needed for jenkins test * Making the init_inputfields get called for restarts too, because restart code call input_field code. * Making pdf_implicit_coefs_terms conditional in generalized grid test * Adding microphys directory to acc_to_omp script * Renaming -iters option in run_scm.py to -max_iters * Making run_scm_all.py and new driver test * Test and script improvements * Limiting iterations in jenkins test * Name change * adding ulimit * name update * jenkins script update * jenkins script update * jenkins script update * jenkins script update * jenkins script and run_scm_all.py update * jenkins script update * Turning calc_lmin_nu into calc_derrived_params, which is more general, and now calculates mixt_frac_max_mag * Small improvement for GPU * Small updates needed for host model integration * Removing accidentally added file * Small cleanup 2025-10-05 20:45:58 -05006061db38ecdeb1e2e7a5f50a1c0dfdb784e7a155Clubb driver upgrades part2 (#1257)editnumerical_check.F90editstats_clubb_utilities.F90editpdf_parameter_module.F90editadvance_xm_wpxp_module.F90editparameters_tunable.F90deletemt95.F90editCMakeLists.txteditsfc_varnce_module.F90editmixing_length.F90deleteparameters_model.F90edithydromet_pdf_parameter_module.F90editpdf_closure_module.F90editgrid_class.F90editclubb_api_module.F90editgrid_adaptation_module.F90editoutput_netcdf.F90editmodel_flags.F90editadvance_clubb_core_module.F90editadvance_windm_edsclrm_module.F90editadvance_helper_module.F90editclip_explicit.F90silhs_api_module.F90mt95.F90CMakeLists.txtlatin_hypercube_driver_module.F90output_2D_samples_module.F9065c0ff8e7f89aa0cf15f016d0bec345de92a4b1f1759715158000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comClubb driver upgrades part2 (#1257) * Initial commit. Breaking up clubb driver into sections. This should be bfb on everything, but this hasn't been checked well yet. * Combining namelist read into case init, same stuff really * Reorganizing many things, mainly in the pursuit of sectioning off code into groups like Microphys or Radiation * Organizing clubb_driver. All cases still BFB. * Mostly cosmetic improvements * Small improvements, comments, making clubb_driver_test to ensure consistency functionality of new compartmentalized model run components * Removing accidentally added files. * Mostly breaking up structure initialization behavior, split into init_ and zero_ so that we don't have to allocate to reset. * Doing away with clubb_model_settings and parameters_module in the spirit of consolidating functionality and spiting module variables. * Missed some changes to commit, should've been included in previous commit * Splitting up funcionality of setup_parameters. Now theres one part that calculates and another checks flag values. * GPU code working, but not BFB yet * GPU all BFB with mutliple columns, except gabls3, and driver test doesnt work (pass reinitialize, fails double timestep test) * Turning off multi_column output for the new driver test * Changes needed after rebase * Name changes, comments, and threadprivate additions for parallel runs * Adding variables to openacc data statements. Without this, the code crashes when using the GPU with l_godunov_upwind_xpyp_ta=.true. * Modifying compiler configurations (mainly optimization level) in order to prepare for switching scipts and tests to cmake, specifically separating out this BIT_CHANGING commit from the rest * thlm_ed and rtm_ed caused GPU errors since those variables were added to a acc loop, but never added to the acc data statement. This change makes it so they're only calculated on the CPU, since they are only used for stats, fixing the issue without adding the GPU memory footprint. * Adding -Mstack_arrays to the nvfortran flags causes us to use more stack space, which means we need to allow processes to use more stack space (when using lots of columns, since that increases memory footprint). We do by using using 'ulimit BIGNUMBER'. * Making old compiler script work with new file structure, also making Input_fields directory and library. * Missed text_writer_lib * Undoing Input_fields directory, it has too many depencencies currently, certainly can be simplified with argument lists. * Adding library dependency * Small changes to cmake list * Adding openmp flag back to gfortran script, needed for jenkins test * Making the init_inputfields get called for restarts too, because restart code call input_field code. * Making pdf_implicit_coefs_terms conditional in generalized grid test * Adding microphys directory to acc_to_omp script * Renaming -iters option in run_scm.py to -max_iters * Making run_scm_all.py and new driver test * Test and script improvements * Limiting iterations in jenkins test * Name change * adding ulimit * name update * jenkins script update * jenkins script update * jenkins script update * jenkins script update * jenkins script and run_scm_all.py update * jenkins script update * Turning calc_lmin_nu into calc_derrived_params, which is more general, and now calculates mixt_frac_max_mag * Small improvement for GPU * Small updates needed for host model integration * Removing accidentally added file * Small cleanup 2025-10-05 20:45:58 -050065c0ff8e7f89aa0cf15f016d0bec345de92a4b1fClubb driver upgrades part2 (#1257)editCMakeLists.txteditsilhs_api_module.F90editlatin_hypercube_driver_module.F90addmt95.F90editoutput_2D_samples_module.F90SRC/restart.F90SRC/SGS_CLUBB/clubb_silhs_vars.F90SRC/SGS_CLUBB/clubb_sgs.F90e90794954660547af780fc0330b963efa8afbe251759719262000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comCompatibility upgrades (#166) * Changes needed for compatibility with clubb_driver_upgrades_part2, from PR https://github.com/larson-group/clubb/pull/1257 * Tiny cleanup and comment upgrade 2025-10-05 21:54:22 -0500e90794954660547af780fc0330b963efa8afbe25Compatibility upgrades (#166)editSRC/SGS_CLUBB/clubb_silhs_vars.F90editSRC/restart.F90editSRC/SGS_CLUBB/clubb_sgs.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse453http://carson.math.uwm.edu/jenkins/job/sam_clubb_nvhpc_build/453/451http://carson.math.uwm.edu/jenkins/job/sam_clubb_nvhpc_build/451/