Started by an SCM change863655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master3655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master88d63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixesd63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixes79c5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_breakc5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_break701344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break1344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break851d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates1d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates432f9016182a2d9aaa96a20c05f7b87dba7f18b0cb4f9016182a2d9aaa96a20c05f7b87dba7f18b0cb4refs/remotes/origin/masterf9016182a2d9aaa96a20c05f7b87dba7f18b0cb4f9016182a2d9aaa96a20c05f7b87dba7f18b0cb4refs/remotes/origin/masterf9016182a2d9aaa96a20c05f7b87dba7f18b0cb4f9016182a2d9aaa96a20c05f7b87dba7f18b0cb4refs/remotes/origin/masterhttps://github.com/larson-group/sam_clubb.githttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/sam_clubb_nvhpc_build/detail/sam_clubb_nvhpc_build/432/artifactshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/sam_clubb_nvhpc_build/detail/sam_clubb_nvhpc_build/432/changeshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/sam_clubb_nvhpc_build/detail/sam_clubb_nvhpc_build/432/http://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/sam_clubb_nvhpc_build/detail/sam_clubb_nvhpc_build/432/testsfalseEdit MakefileEdit Default CaseCompileRun SAMfalse#43282086807834sam_clubb_nvhpc_build #432432false4328770SUCCESS1745397907258http://carson.math.uwm.edu/jenkins/job/sam_clubb_nvhpc_build/432/parameters_tunable.F9038c8aa0c03693c9148f9468f2b4fa2026fe69fb91745348257000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI updated adj_low_res_nu for use with a generalized grid. It is not called from within advance_clubb_core or from within SILHS. It is not necessary to be generalized for tests within standalone CLUBB. However, it is necessary to generalize this code for use within host models, particularly for CAM and E3SM. 2025-04-22 13:57:37 -050038c8aa0c03693c9148f9468f2b4fa2026fe69fb9I updated adj_low_res_nu for use with a generalized grid. It iseditparameters_tunable.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2falseStarted by an SCM change863655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master3655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master88d63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixesd63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixes79c5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_breakc5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_break701344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break1344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break851d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates1d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates433cfd98352c22184a2f621719675b8f0f9511a96e7cfd98352c22184a2f621719675b8f0f9511a96e7refs/remotes/origin/mastercfd98352c22184a2f621719675b8f0f9511a96e7cfd98352c22184a2f621719675b8f0f9511a96e7refs/remotes/origin/mastercfd98352c22184a2f621719675b8f0f9511a96e7cfd98352c22184a2f621719675b8f0f9511a96e7refs/remotes/origin/masterhttps://github.com/larson-group/sam_clubb.gitfalse#43375593807834sam_clubb_nvhpc_build #433433false4338926SUCCESS1745484306360http://carson.math.uwm.edu/jenkins/job/sam_clubb_nvhpc_build/433/precipitation_fraction.F90advance_xm_wpxp_module.F90clubb_api_module.F90numerical_check.F90output_netcdf.F90grid_class.F90parameters_tunable.F90setup_clubb_pdf_params.F90advance_windm_edsclrm_module.F90mono_flux_limiter.F90mixing_length.F90advance_wp2_wp3_module.F90err_info_type_module.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90lapack_wrap.F90pdf_closure_module.F90stats_clubb_utilities.F90grid_adaptation.F90matrix_solver_wrapper.F90sfc_varnce_module.F90corr_varnce_module.F903d241e564776b535580a2b78d3f29fe1578676e61745422568000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comErr code struct (#1238) Added err_info type to CLUBB to extend old err_code integer flag CLUBB ticket #975 Created a new err_info type replacing the old err_code integer. It contains MPI rank and (OMP) chunk index so we can identify the specific process that caused an error. It also contains latitude and longitude so a person trying to debug a host model run can pinpoint the column that caused an error. It contains error headers that combine all the info into a string that can be printed when an error happens. And it comes with subroutines that handle initialization, value setting, and cleanup. Host models will be modified accordingly. Possible TODO: Implement a subroutine that identifies the index of the column with the error after the fact so we can have more specific info at the higher call levels by applying `where` to the err_code member array. 2025-04-23 10:36:08 -05003d241e564776b535580a2b78d3f29fe1578676e6Err code struct (#1238)editadvance_xm_wpxp_module.F90editoutput_netcdf.F90editgrid_adaptation.F90editcorr_varnce_module.F90adderr_info_type_module.F90editadvance_windm_edsclrm_module.F90editsfc_varnce_module.F90editsetup_clubb_pdf_params.F90editgrid_class.F90editprecipitation_fraction.F90editmatrix_solver_wrapper.F90editmono_flux_limiter.F90editstats_clubb_utilities.F90editmixing_length.F90editnumerical_check.F90editpdf_closure_module.F90editadvance_wp2_wp3_module.F90editadvance_xp2_xpyp_module.F90editlapack_wrap.F90editparameters_tunable.F90editclubb_api_module.F90editadvance_clubb_core_module.F90silhs_api_module.F90output_2D_samples_module.F90latin_hypercube_driver_module.F901a4c3cc982a84bba46f59cacdf819a7a4153153a1745422568000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comErr code struct (#1238) Added err_info type to CLUBB to extend old err_code integer flag CLUBB ticket #975 Created a new err_info type replacing the old err_code integer. It contains MPI rank and (OMP) chunk index so we can identify the specific process that caused an error. It also contains latitude and longitude so a person trying to debug a host model run can pinpoint the column that caused an error. It contains error headers that combine all the info into a string that can be printed when an error happens. And it comes with subroutines that handle initialization, value setting, and cleanup. Host models will be modified accordingly. Possible TODO: Implement a subroutine that identifies the index of the column with the error after the fact so we can have more specific info at the higher call levels by applying `where` to the err_code member array. 2025-04-23 10:36:08 -05001a4c3cc982a84bba46f59cacdf819a7a4153153aErr code struct (#1238)editoutput_2D_samples_module.F90editlatin_hypercube_driver_module.F90editsilhs_api_module.F90SRC/SGS_CLUBB/clubb_sgs.F90cfd98352c22184a2f621719675b8f0f9511a96e71745436195000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdate clubb_sgs.F90 to incorporate err_info (#165) Update clubb_sgs.F90 to incorporate err_info 2025-04-23 14:23:15 -0500cfd98352c22184a2f621719675b8f0f9511a96e7Update clubb_sgs.F90 to incorporate err_info (#165)editSRC/SGS_CLUBB/clubb_sgs.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse434http://carson.math.uwm.edu/jenkins/job/sam_clubb_nvhpc_build/434/432http://carson.math.uwm.edu/jenkins/job/sam_clubb_nvhpc_build/432/Started by an SCM change863655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master3655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master88d63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixesd63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixes79c5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_breakc5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_break701344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break1344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break851d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates1d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates431267ea2a1c073a344cda9941e2b2d3c08abc5eaa0267ea2a1c073a344cda9941e2b2d3c08abc5eaa0refs/remotes/origin/master267ea2a1c073a344cda9941e2b2d3c08abc5eaa0267ea2a1c073a344cda9941e2b2d3c08abc5eaa0refs/remotes/origin/master267ea2a1c073a344cda9941e2b2d3c08abc5eaa0267ea2a1c073a344cda9941e2b2d3c08abc5eaa0refs/remotes/origin/masterhttps://github.com/larson-group/sam_clubb.gitfalse#43157975807834sam_clubb_nvhpc_build #431431false4318633SUCCESS1744274709892http://carson.math.uwm.edu/jenkins/job/sam_clubb_nvhpc_build/431/precipitation_fraction.F90setup_clubb_pdf_params.F9055eae9b809c45299075475da2f488ecaac258a831744204547000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comClubb silhs gg (#1239) * I added new subroutine pdf_hydromet_microphys_prep to encompass the code that calls the hydrometeor PDF and then ultimately handles the setup of SILHS sample points when SILHS is in use. * Placeholder subroutine for SILHS grid generalization test. * I have now connected the new subroutine to run_clubb. The results for all cases match bit-for-bit to the previous revision. * Cleaning up from the refactoring of the hydrometeor PDF and SILHS code into a wrapper subroutine. * I'm moving pdf_hydromet_microphys_prep to its own file to avoid circular dependency once it finally needs to be called from the generalized grid test code soon. * Added some code to the SILHS generalized grid test. * Changes to make this a fully functioning grid generalization test for the part of the microphysics code that encompasses setup_pdf_parameters and hydrometeor_mixed_moments. * I have completed the code for the SILHS generalized grid test. * I generalized precipitation fraction for ascending vs. descending grid. * Fixing a bug that I noticed in the precipitation fraction calculation when the component precip frac calculation was set to option 1 (which is currently not the default). * The code should now be successfully grid-generalized for SILHS. The ascending vs descending grid test should work now for all cases. * Updating the core flags .json file to change some of the SILHS flags. * I moved the call to advance_clubb_core_api (the default run option) to the top of the "if" block, ahead of the grid generalization test option that is now in the "else" block. * Adding a new, hardwired constant flag called l_ascending_grid and setting it to true in clubb_driver.F90. * Keeping lines under 100 characters in length. * Making it so the ascending vs. descending grid tests pass for the l_lh_random_start flag. 2025-04-09 08:15:47 -050055eae9b809c45299075475da2f488ecaac258a83Clubb silhs gg (#1239)editprecipitation_fraction.F90editsetup_clubb_pdf_params.F90silhs_api_module.F90latin_hypercube_driver_module.F9022f5d492241112ab03918dbd8041883b5b2ae28b1744204547000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comClubb silhs gg (#1239) * I added new subroutine pdf_hydromet_microphys_prep to encompass the code that calls the hydrometeor PDF and then ultimately handles the setup of SILHS sample points when SILHS is in use. * Placeholder subroutine for SILHS grid generalization test. * I have now connected the new subroutine to run_clubb. The results for all cases match bit-for-bit to the previous revision. * Cleaning up from the refactoring of the hydrometeor PDF and SILHS code into a wrapper subroutine. * I'm moving pdf_hydromet_microphys_prep to its own file to avoid circular dependency once it finally needs to be called from the generalized grid test code soon. * Added some code to the SILHS generalized grid test. * Changes to make this a fully functioning grid generalization test for the part of the microphysics code that encompasses setup_pdf_parameters and hydrometeor_mixed_moments. * I have completed the code for the SILHS generalized grid test. * I generalized precipitation fraction for ascending vs. descending grid. * Fixing a bug that I noticed in the precipitation fraction calculation when the component precip frac calculation was set to option 1 (which is currently not the default). * The code should now be successfully grid-generalized for SILHS. The ascending vs descending grid test should work now for all cases. * Updating the core flags .json file to change some of the SILHS flags. * I moved the call to advance_clubb_core_api (the default run option) to the top of the "if" block, ahead of the grid generalization test option that is now in the "else" block. * Adding a new, hardwired constant flag called l_ascending_grid and setting it to true in clubb_driver.F90. * Keeping lines under 100 characters in length. * Making it so the ascending vs. descending grid tests pass for the l_lh_random_start flag. 2025-04-09 08:15:47 -050022f5d492241112ab03918dbd8041883b5b2ae28bClubb silhs gg (#1239)editsilhs_api_module.F90editlatin_hypercube_driver_module.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse432http://carson.math.uwm.edu/jenkins/job/sam_clubb_nvhpc_build/432/430http://carson.math.uwm.edu/jenkins/job/sam_clubb_nvhpc_build/430/