Started by user Brian GriffingriffinbBrian Griffin863655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master3655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master88d63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixesd63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixes79c5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_breakc5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_break701344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break1344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break851d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates1d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates423963872093d812df3d20d84ef28ab11d95b858f7d963872093d812df3d20d84ef28ab11d95b858f7drefs/remotes/origin/master963872093d812df3d20d84ef28ab11d95b858f7d963872093d812df3d20d84ef28ab11d95b858f7drefs/remotes/origin/master963872093d812df3d20d84ef28ab11d95b858f7d963872093d812df3d20d84ef28ab11d95b858f7drefs/remotes/origin/masterhttps://github.com/larson-group/sam_clubb.githttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/sam_clubb_nvhpc_build/detail/sam_clubb_nvhpc_build/423/artifactshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/sam_clubb_nvhpc_build/detail/sam_clubb_nvhpc_build/423/changeshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/sam_clubb_nvhpc_build/detail/sam_clubb_nvhpc_build/423/http://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/sam_clubb_nvhpc_build/detail/sam_clubb_nvhpc_build/423/testsfalseEdit MakefileEdit Default CaseCompileRun SAMfalse#42372004807834sam_clubb_nvhpc_build #423423false4237355SUCCESS1741018444132http://carson.math.uwm.edu/jenkins/job/sam_clubb_nvhpc_build/423/SRC/MICRO_M2005_UWM/microphysics.F90SRC/micro_field_utils.F90SRC/SGS_CLUBB/clubb_sgs.F90963872093d812df3d20d84ef28ab11d95b858f7d1741018392000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduUpdated calls to some CLUBB subroutines in the wake of recent CLUBB commits. 2025-03-03 10:13:12 -0600963872093d812df3d20d84ef28ab11d95b858f7dUpdated calls to some CLUBB subroutines in the wake of recent CLUBBeditSRC/SGS_CLUBB/clubb_sgs.F90editSRC/MICRO_M2005_UWM/microphysics.F90editSRC/micro_field_utils.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreplyfalseStarted by an SCM change863655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master3655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master88d63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixesd63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixes79c5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_breakc5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_break701344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break1344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break851d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates1d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates4242af47f5f3f222447acc62c871ed73debfc72db4c2af47f5f3f222447acc62c871ed73debfc72db4crefs/remotes/origin/master2af47f5f3f222447acc62c871ed73debfc72db4c2af47f5f3f222447acc62c871ed73debfc72db4crefs/remotes/origin/master2af47f5f3f222447acc62c871ed73debfc72db4c2af47f5f3f222447acc62c871ed73debfc72db4crefs/remotes/origin/masterhttps://github.com/larson-group/sam_clubb.gitfalse#42474055807834sam_clubb_nvhpc_build #424424false4247493SUCCESS1741167909801http://carson.math.uwm.edu/jenkins/job/sam_clubb_nvhpc_build/424/grid_class.F90d080994ebfce2a1aae5509e6a1727a5fe4ef876b1741120069000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI changed the variable type within grid function flip from dp to core_rknd. I then needed to make some changes to BUGSrad driver to compensate. The "dp" issue was discovered when WRF-CLUBB wouldn't compile because of it (discrepancy between dp and core_rknd in WRF-CLUBB that caused compilation errors for calls to flip from advance_xm_wpxp, etc.) 2025-03-04 14:27:49 -0600d080994ebfce2a1aae5509e6a1727a5fe4ef876bI changed the variable type within grid function flip from dp toeditgrid_class.F90advance_clubb_core_module.F90781a8ecf164f73570d972e8e49d46399b4eee0221741135026000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduFixed a compiling issue with CAM-CLUBB. 2025-03-04 18:37:06 -0600781a8ecf164f73570d972e8e49d46399b4eee022Fixed a compiling issue with CAM-CLUBB.editadvance_clubb_core_module.F90saturation.F90b7d415425bda941b81468bee63c68dcc9541a0051741139829000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduHopefully this helps the cpu vs. gpu tests. 2025-03-04 19:57:09 -0600b7d415425bda941b81468bee63c68dcc9541a005Hopefully this helps the cpu vs. gpu tests.editsaturation.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2false425http://carson.math.uwm.edu/jenkins/job/sam_clubb_nvhpc_build/425/423http://carson.math.uwm.edu/jenkins/job/sam_clubb_nvhpc_build/423/Started by an SCM change863655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master3655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master88d63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixesd63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixes79c5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_breakc5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_break701344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break1344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break851d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates1d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates4223862ff9ae29c531f8b656d46b1ef2a8a583909173862ff9ae29c531f8b656d46b1ef2a8a58390917refs/remotes/origin/master3862ff9ae29c531f8b656d46b1ef2a8a583909173862ff9ae29c531f8b656d46b1ef2a8a58390917refs/remotes/origin/master3862ff9ae29c531f8b656d46b1ef2a8a583909173862ff9ae29c531f8b656d46b1ef2a8a58390917refs/remotes/origin/masterhttps://github.com/larson-group/sam_clubb.gitfalse#42245487807834sam_clubb_nvhpc_build #422422false4227336FAILURE1740908708008http://carson.math.uwm.edu/jenkins/job/sam_clubb_nvhpc_build/422/diffusion.F90model_flags.F90clip_explicit.F90advance_xm_wpxp_module.F90clubb_api_module.F90pos_definite_module.F90grid_class.F90sponge_layer_damping.F90advance_windm_edsclrm_module.F90turbulent_adv_pdf.F90advance_helper_module.F90mono_flux_limiter.F90advance_wp2_wp3_module.F90mixing_length.F90advance_xp2_xpyp_module.F90saturation.F90advance_clubb_core_module.F90mean_adv.F90fill_holes.F90pdf_closure_module.F90grid_adaptation.F90sfc_varnce_module.F90c4ffc9479567a66c1a43824ed79cc82b6a5c64a41740847122000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comGeneralized grid (#1230) * Added the necessary grid variables to the grid type (they're hardwired for an Ascending Grid for now). I also made the necessary changes, using those new variables, to advance_wp2_wp3_module.F90. * Added code to generalize advance_xm_wpxp_module.F90. * Updated some of the boundary conditions for generalization in grid_class.F90. * Developing a unit test for CLUBB's grid functions. * Adding the ability to toggle on or off the reverse direction grid test. * Updating for development of a unit test comparing the ascending and descending grids. * I updated the generalized grid unit test to complete testing on all the variables within the grid derived type for both the ascending and descending grid directions. * I updated the code to work symmetrically for an ascending and descending grid for the zm2zt and zt2zm functions. This commit, as well as the previous commit, is BIT_CHANGING. * Updated to improve notes and comments in grid_class.F90 and to enhance the reverse grid unit tests. * Got rid of the compiler warnings in the new reverse direction grid unit test. * Updating the reverse grid unit tests so some random perturbations are added to the grid heights when they are declared either on the thermodynamic grid or on the momentum grid. * Made some changes where the fstdout stream is exclusively used and added some print statements. * Mean advection has been modified for generalized directional gridding and a test of the calls to mean advection has been added to the reverse direction unit test. * Updating diffusion so results are bit-for-bit identical between using an ascending grid and using a descending grid at -O0 optimization. This now works for both standard diffusion and also diffusion with the l_upwind_Kh_dp_term flag turned on. * I forgot to add the zm diffusion test, but the results are the same -- all pass! * I have completed the unit tests for the PDF turbulent advection subroutines and modified the appropriate sections of code so that ascending and descending grids produce a bit-for-bit match wiht -O0 optimization. * Updated code for producing a bit-for-bit match (on -O0 optimization) when comparing ascending grid direction against descending grid direction for advance_wp2_wp3. * The check for the LHS of advance_xp2_xpyp now passes. * The ascending vs. descending bit-for-bit test (wiht optimization set to -O0) now passes for advance_xp2_xpyp. * I have successfully generalized the grid for advance_windm_edscrlm. Ascending and descending runs now produce bit-for-bit results to each other under -O0 optimization with the default flag configuration. * Fixing the ascending vs. descending grid test for advance_windm_edsclrm for the case where l_imp_sfc_momentum_flux is set to false. * Only perform check when l_predict_upwp_vpwp is turned off. * This commit makes an ascending vs. descending test work for all cases for advance_xm_wpxp when the mono flux limiter is turned off. * The ascending vs. descending grid tests are finally working with the monotonic flux limiter turned on (default settings). * Removed some commented-out prints that I accidentally added during the last commit. * Updating positive_definite_module.F90 so that it works for ascending vs. descending grids. * The ascending vs. descending grid generalization test now works for the Lscale_up portion of mixing length. * The ascending vs. descending grid generalization now works successfully for Lscale_down. * Lscale is now generalized for ascending vs. descending gridding. * Updated for generalizing sfc_varnce_module * Updating advance_clubb_core_module for grid generalization. * With this commit, the ascending vs. descending grid tests works by calling advance_clubb_core twice from clubb_driver. They produce bit-for-bit results on -O0 optimization for all intent(inout) and intent(out) variables found in the call to advance_clubb_core. This has only been tested for the default flag configuration. * I am updating the ascending vs. descending grid test to check both pdf_params and pdf_params_zm. * I added pdf_implicit_coefs_terms and the sclr and edsclr family of variables to the list of variables that are checked after coming out of the calls to advance_clubb_core in the ascending vs. descending bit-for-bit grid test. * I added an improved display for the print messages for the ascending vs. descending grid test. * I moved the generalized grid test to its own file, which is called from run_clubb. * I removed much of the junk and clutter from the code. It had been added over time for local tests of ascending vs. descending grid types. * Adding the l_generalized_grid_test flag to the code. * I needed to alter the monotonic flux limiter that I just merged in from the master branch so that the ascending vs. descending grid generalization test works once again. * Updated a piece of code in the solve routine for the monotonic flux limiter for the grid generalization test. * Clarified some comments * I added a Jenkins file for the new clubb_generalized_vertical_grid_test, which performs a run comparing ascending and descending grids with -O0 optimization and expects bit-for-bit results. * The l_rev_direction_grid_test (part of the G unit tests) needs to be compiled specially with -O0 optimization. Thus, I will set the flag to run this test to .false. by default. A special Jenkins test will be made to compile with the correct optimization and run only this particular test. * I updated the generalized vertical grid Jenkins test to turn off sponge damping (thlm and rtm sponge damping) in the case files for the CGILS S6, S11, and S12 cases. * Caught a stats bug I had previously introduced for the um_ta and vm_ta stats terms when l_predict_upwp_vpwp is turned off. 2025-03-01 10:38:42 -0600c4ffc9479567a66c1a43824ed79cc82b6a5c64a4Generalized grid (#1230)editsaturation.F90editpdf_closure_module.F90editgrid_class.F90editadvance_wp2_wp3_module.F90editdiffusion.F90editadvance_helper_module.F90editadvance_xp2_xpyp_module.F90editadvance_windm_edsclrm_module.F90editadvance_clubb_core_module.F90editmean_adv.F90editclip_explicit.F90editmixing_length.F90editgrid_adaptation.F90editturbulent_adv_pdf.F90editfill_holes.F90editmono_flux_limiter.F90editpos_definite_module.F90editsfc_varnce_module.F90editadvance_xm_wpxp_module.F90editsponge_layer_damping.F90editclubb_api_module.F90editmodel_flags.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse423http://carson.math.uwm.edu/jenkins/job/sam_clubb_nvhpc_build/423/421http://carson.math.uwm.edu/jenkins/job/sam_clubb_nvhpc_build/421/