Started by an SCM change863655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master3655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master88d63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixesd63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixes79c5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_breakc5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_break701344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break1344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break851d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates1d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates389685528b4499bf2e518c074640b8298042396c0cb685528b4499bf2e518c074640b8298042396c0cbrefs/remotes/origin/master685528b4499bf2e518c074640b8298042396c0cb685528b4499bf2e518c074640b8298042396c0cbrefs/remotes/origin/master685528b4499bf2e518c074640b8298042396c0cb685528b4499bf2e518c074640b8298042396c0cbrefs/remotes/origin/masterhttps://github.com/larson-group/sam_clubb.githttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/sam_clubb_nvhpc_build/detail/sam_clubb_nvhpc_build/389/artifactshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/sam_clubb_nvhpc_build/detail/sam_clubb_nvhpc_build/389/changeshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/sam_clubb_nvhpc_build/detail/sam_clubb_nvhpc_build/389/http://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/sam_clubb_nvhpc_build/detail/sam_clubb_nvhpc_build/389/testsfalsefalse#389116096633887sam_clubb_nvhpc_build #389389false3893380SUCCESS1728117907622http://carson.math.uwm.edu/jenkins/job/sam_clubb_nvhpc_build/389/fill_holes.F90saturation.F90advance_clubb_core_module.F90parameters_tunable.F90clubb_api_module.F90e25a2a10f127157f8f597674d2b1a2478dc96a7c1728050904000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comrefactoring to remove compiler warnings (#1187) * refactor code to remove warnings for exceeding 100 characters per line * remove unused variables * remove unused parameters #1174 * fix for the GPU * remove new unused parameters * remove unused dummy arguments * make small changes to reduce compiler warnings * put solve_name back in as input variable to band_solve methods * combine intent in and out parameters from calc_trapezoid_zm and calc_trapezoid_zt to intent inout parameters * remove unused functions init_parameters_999 and sat_vapor_press_ice_* * remove unused dummy arguments * fix merge error * remove unnecessary loop 2024-10-04 09:08:24 -0500e25a2a10f127157f8f597674d2b1a2478dc96a7crefactoring to remove compiler warnings (#1187)editclubb_api_module.F90editadvance_clubb_core_module.F90editparameters_tunable.F90editfill_holes.F90editsaturation.F90silhs_api_module.F90ade7da06f81dbd0fc358fb9ca8e63a50b95386641728050904000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comrefactoring to remove compiler warnings (#1187) * refactor code to remove warnings for exceeding 100 characters per line * remove unused variables * remove unused parameters #1174 * fix for the GPU * remove new unused parameters * remove unused dummy arguments * make small changes to reduce compiler warnings * put solve_name back in as input variable to band_solve methods * combine intent in and out parameters from calc_trapezoid_zm and calc_trapezoid_zt to intent inout parameters * remove unused functions init_parameters_999 and sat_vapor_press_ice_* * remove unused dummy arguments * fix merge error * remove unnecessary loop 2024-10-04 09:08:24 -0500ade7da06f81dbd0fc358fb9ca8e63a50b9538664refactoring to remove compiler warnings (#1187)editsilhs_api_module.F90SRC/SGS_CLUBB/clubb_sgs.F90f6d9d57e5890b8c57bd5c35806b9a3df15cee3491728051692000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comremove unused dummy arguments (#159) These SAM changes correspond to CLUBB changes larson-group/clubb#1174 and larson-group/clubb#1187. 2024-10-04 09:21:32 -0500f6d9d57e5890b8c57bd5c35806b9a3df15cee349remove unused dummy arguments (#159)editSRC/SGS_CLUBB/clubb_sgs.F90grid_class.F90919336b9bc062541373a38408c9db3bc104f92e01728074121000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am copying the round-off level changes made to grid weights and grid interpolation functions from the generalized_grid branch over to the master branch. This is being done ahead of merging code from the master over to the generalized_grid branch. This code is necessary to get results in the generalized grid branch bit-for-bit between ascending and descending grid directions when optimization is set to -O0. This change produces changes at the numerical round-off level in the affected calculations, making this commit BIT_CHANGING. Plots show lines overlap for almost all cases besides the most sensitive cases (ARM 97, TWP ICE, etc. -- looking at those shows you how much of a difference a simple numerical round-off can make). 2024-10-04 15:35:21 -0500919336b9bc062541373a38408c9db3bc104f92e0I am copying the round-off level changes made to grid weightseditgrid_class.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreplyfalseStarted by an SCM change863655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master3655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master88d63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixesd63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixes79c5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_breakc5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_break701344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break1344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break851d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates1d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates390357bcc8e1c4165c3c911734d4d17d332ca443b07357bcc8e1c4165c3c911734d4d17d332ca443b07refs/remotes/origin/master357bcc8e1c4165c3c911734d4d17d332ca443b07357bcc8e1c4165c3c911734d4d17d332ca443b07refs/remotes/origin/master357bcc8e1c4165c3c911734d4d17d332ca443b07357bcc8e1c4165c3c911734d4d17d332ca443b07refs/remotes/origin/masterhttps://github.com/larson-group/sam_clubb.gitfalse#39067777633887sam_clubb_nvhpc_build #390390false3903466SUCCESS1728377109754http://carson.math.uwm.edu/jenkins/job/sam_clubb_nvhpc_build/390/mono_flux_limiter.F90414ffbb09cdcd4ea2b175a5d8569e4a6efbd80071728328341000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comMono Flux Optimizations (#1189) * Performance optimizations. This is BIT_CHANGING but not answer changing. * Small bug fix * Fix for uninitialized value in stats call and use of zero over 0.0_core_rknd * Adding new variables to CPU data statements. * Slight improvements to monoflux_test script. * Making monoflux test script test with multiple columns * Renaming and cleanup. 2024-10-07 14:12:21 -0500414ffbb09cdcd4ea2b175a5d8569e4a6efbd8007Mono Flux Optimizations (#1189)editmono_flux_limiter.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse391http://carson.math.uwm.edu/jenkins/job/sam_clubb_nvhpc_build/391/389http://carson.math.uwm.edu/jenkins/job/sam_clubb_nvhpc_build/389/Started by an SCM change863655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master3655285cd4ce9d65cec1b44cf2e6e578f4d08fe73655285cd4ce9d65cec1b44cf2e6e578f4d08fe7origin/master88d63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixesd63a0f595d93dccafcc9e7917c00fe97fd034a35d63a0f595d93dccafcc9e7917c00fe97fd034a35origin/grid_fixes79c5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_breakc5c01fc5da140dc13df06c2919c4f4f5a0318b5fc5c01fc5da140dc13df06c2919c4f4f5a0318b5forigin/changes_to_not_break701344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break1344f8a40d6116af1b567307eb389b4be1009fc41344f8a40d6116af1b567307eb389b4be1009fc4refs/remotes/origin/changes_to_not_break851d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates1d226e398bae00fe10255274a70f3451b5cc7d9e1d226e398bae00fe10255274a70f3451b5cc7d9eorigin/wangara_updates388f6b79b6e7fedc409e4ba70969aa1f67503e4911ff6b79b6e7fedc409e4ba70969aa1f67503e4911frefs/remotes/origin/masterf6b79b6e7fedc409e4ba70969aa1f67503e4911ff6b79b6e7fedc409e4ba70969aa1f67503e4911frefs/remotes/origin/masterf6b79b6e7fedc409e4ba70969aa1f67503e4911ff6b79b6e7fedc409e4ba70969aa1f67503e4911frefs/remotes/origin/masterhttps://github.com/larson-group/sam_clubb.gitfalse#38869910633887sam_clubb_nvhpc_build #388388false3883298SUCCESS1728031508240http://carson.math.uwm.edu/jenkins/job/sam_clubb_nvhpc_build/388/mixing_length.F90advance_helper_module.F900e78da1cb43ae234acfb9a59b99e90d80cb5767e1727973450000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRi zm calc cleanup (#1186) CLUBB ticket #1145 - Removed redundant smooth_max call on Ri_zm in diagnose_Lscale_from_tau - Renamed Ri_zm to Ri_zm_Cx in compute_Cx_fnc_Richardson to distinguish it from the Ri_zm used to caluculate invrs_tau_wpxp_zm 2024-10-03 11:37:30 -05000e78da1cb43ae234acfb9a59b99e90d80cb5767eRi zm calc cleanup (#1186)editmixing_length.F90editadvance_helper_module.F90mono_flux_limiter.F90b66228d768a7cafb64c4c1af750b62c39208a3101727989859000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comMonoflux test (#1188) * Adding comments in code * Adding test script * Updating test script * Adding jenkins file to run new test * Adding descriptions, cleanup, and name change to indiciate this is a GPU test. * Cleaup and adding references 2024-10-03 16:10:59 -0500b66228d768a7cafb64c4c1af750b62c39208a310Monoflux test (#1188)editmono_flux_limiter.F90mono_flux_limiter.F9086ad303494c4dc2150a14bc92566f0550669cea51727990108000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing bug. This loop has a vertical dependency prevent the use of collapse(2). See https://github.com/larson-group/cam/issues/175\#issuecomment-2261283301 2024-10-03 16:15:08 -050086ad303494c4dc2150a14bc92566f0550669cea5Fixing bug. This loop has a vertical dependency prevent the use of collapse(2). See https://github.com/larson-group/cam/issues/175\#issuecomment-2261283301editmono_flux_limiter.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse389http://carson.math.uwm.edu/jenkins/job/sam_clubb_nvhpc_build/389/387http://carson.math.uwm.edu/jenkins/job/sam_clubb_nvhpc_build/387/