For other:ticket:362, adding our current license agreement to the source code.
(details / githubweb)
For clubb:ticket:740, I added `l_rcm_in_cloud_k_lh_start` and `l_random_k_lh_start` to the microphysics namelist for experimentation.
(details / githubweb)
I made the changes necessary to get 2D output working.
(details / githubweb)
I patched a memory leak related to clubb:ticket:740.
(details / githubweb)
For clubb:ticket:740, I implemented an algorithm to limit the sample point weights to a prescribed maximum. The algorithm ended up being a bit more convoluted that I originally thought it would, but it works!
(details / githubweb)
For clubb:ticket:740, I am adding an output, "rrm_mc_nonadj", that contains the value of the tendenc
(details / githubweb)
For clubb:ticket:740, I added `prob_thresh` to the microphysics namelist as `importance_prob_thresh` in preparation of finalizing a configuration for the paper.
(details / githubweb)
For clubb:tickets:770, I am merging my branch into the trunk. This code includes a 3D_Luhar pdf closure and is provided 'as is' and without warranty.
(details / githubweb)
For clubb:ticket:740, I generalized the clustering code to handle different numbers of categories in each cluster.
(details / githubweb)
I am committing, into a feature branch (because I hear they are the hot new thing), some untested code that proportionally allocates categories only in the cloud or precipitation regions.
(details / githubweb)
For clubb:ticket:770, cleaning up some compiler warnings. In the process, found a bug where Skrt_zm was not being computed. I deleted diagnose_xp3_module since it is unfinished and unused. If we want to add a third order moment for interactive runs, the Ticket_770 branch has diagnose_xp3_module.F90 for one to continue work on.
(details / githubweb)
I renamed `new_scheme` to `two_cluster_cp_nocp`.
(details / githubweb)
A small bug fix for an assertion check was committed herein.
(details / githubweb)
For clubb:ticket:770, the Oracle compiler was throwing a floating point exception here. wpxp2 and xp2 were being fed in as Nans.
(details / githubweb)
For clubb:ticket:740, I am making some changes to the importance sampling code to support zero prescribed probability in a cluster.
(details / githubweb)
For clubb:ticket:740, I changed some SILHS parameters and added others to the namelist so they can be changed at runtime. At this point, the configuration of SILHS to be used in the paper can be enabled without editing any source code.
(details / githubweb)
The new file calc_roots.F90 contains functions that solve for the roots of a
(details / githubweb)
For clubb:ticket:740, I implemented the algorithm to prescribe `f_j` (called the "variance fraction" in the code) rather than `S_j` (called the "prescribed probability" in the code). The algorithm ended up being short and elegant because transferrence is not required when prescribing `f_j`. (When prescribing `f_j`, `p_j = 0` implies `S_j = 0`, so transferrence is not needed.)
(details / githubweb)
For clubb:ticket:740, I added `l_lh_var_frac` to the namelist.
(details / githubweb)
For clubb:ticket:740, I am handling the scariest divide-by-zero situation you've ever seen, just in case.
(details / githubweb)
I tweaked the precipitation fraction code so that the weighted ith PDF component
(details / githubweb)
For clubb:ticket:740, I had, in an earlier commit, left out a block of code that should be there. Now it is there.
(details / githubweb)
I moved the subroutine `determine_sample_categories` to the module `silhs_importance_sample_module` to make it available to modules within the `SILHS` subfolder.
(details / githubweb)
For clubb:ticket:740, I added an output for the "sampling fractions" in each category, which are the SILHS approximations of S_j.
(details / githubweb)
For clubb:ticket:740, I added an output for the "sampling fractions" in each category, which are the SILHS approximations of S_j.
(details / githubweb)
I have discovered a better way to do the assertion check for consistency between `chi_i`, `stdev_chi_i`, and `cloud_frac_i`.
(details / githubweb)
For cam:ticket:36#comment:132, I removed `gr` from the use statement in `setup_grid_heights_api`.
(details / githubweb)
For clubb:ticket:773, I fixed some unsoundness in our code regarding kinds, specifically in `parameters_model.F90` and `endian.F90`.
(details / githubweb)
For cam:ticket:41, the change in clubb:r7921 should be applied to the trunk as well.
(details / githubweb)
For clubb:ticket:778, I am setting the tolerance on an assertion check based on epsilon. Hopefully, this assertion will no longer trip in single precision mode.
(details / githubweb)
For cam:ticket:59, I refactored the calculation of `brunt_vaisala_freq` into a subroutine, and renamed it `brunt_vaisala_freq_sqd`.
(details / githubweb)
I am setting `l_lh_normalize_weights=T` by default in both the source code and the namelist.
(details / githubweb)
It is more robust to check the average of the sample point weights rather than the sum of the sample point weights for unity-ness.
(details / githubweb)
Vince noticed that `sat_mixrat_liq` or `sat_mixrat_ice` will be left uninitialized if `sat_ice_ratio == 0` or `sat_ice_ratio == 1`. No more!
(details / githubweb)
For cam:ticket:32, I made `hydrometp2` `intent(out)` in CLUBB, since the input value is not used.
(details / githubweb)
For clubb:ticket:792, I added a new stats output, `rcm_supersat_adj`, to record the degree of rcm adjustment. It is not output by default. This changeset does not change output.
(details / githubweb)
For clubb:ticket:788, I added a threadprivate entry for `iwp3_pr3`, which will hopefully resolve the failure of the OpenMP test (build:16010).
(details / githubweb)
I have interfaced the new subroutine containing all of the PDF closure-related
(details / githubweb)
I got rid of some variables that were brought into advance_clubb_core by use statements
(details / githubweb)
I cleaned up more compiler warnings for unused variables. The warnings came from g95.
(details / githubweb)
I have added a second call to subroutine generate_pdf_params. This one occurs
(details / githubweb)
I moved the setting of qclvar and thlprcp_out to after the second call to
(details / githubweb)
I have declared the l_use_ice_latent option and the l_call_pdf_closure_twice
(details / githubweb)
I added a local cslculation of sigma_sqd_w near the top of subroutine
(details / githubweb)
I am changing the inputs and outputs of subroutine advance_clubb_core so that
(details / githubweb)
I added code so that stats that are internal to subroutine generate_pdf_params
(details / githubweb)
I have updated subroutine advance_clubb_core so that pdf_params_zm is now passed
(details / githubweb)
Ticket #799 -- Moved iiPDF_... module variables from module corr_varnce_module to module array_index -- The results of the priority cases are bin-diff identical
(details / githubweb)
Ticket #799 -- Moved iiPDF_... module variables from module corr_varnce_module to module array_index -- The results of the priority cases are bin-diff identical
(details / githubweb)
Ticket #798 -- Renamed d_variables to pdf_dim -- The results of the priority cases are bin-diff identical
(details / githubweb)
Ticket #798 -- Renamed d_variables to pdf_dim -- The results of the priority cases are bin-diff identical
(details / githubweb)
I updated the call to the new PDF so that Skrt and Skthl are intent INOUT
(details / githubweb)
Removed many eqaulity comparison warnings in precipitation_fraction.F90 clubb:ticket:803
(details / githubweb)
I am adding a new function, calc_wpxpyp_pdf, to pdf_closure_module.F90. This
(details / githubweb)
I finished adding the units to the variable descriptions in
(details / githubweb)
The calculation of higher-order scalar terms <w'^2^ sclr'>, <w'sclr'^2^>,
(details / githubweb)
I added the tunable or adjustable parameters for the new PDF to CLUBB's list
(details / githubweb)
Fixed various warnings. Mainly by removing unused variables and commenting out unused procedures. See clubb:ticket:803
(details / githubweb)
I am committing a line of code that limits the adjusted correlation of rt and
(details / githubweb)
I implemented a new method to handle cumulus momentum fluxes.
(details / githubweb)
Switched from using the erf function defined by anl_erf to the intristic erf function. This should be BIT_CHANGING see clubb:ticket:804
(details / githubweb)
Switched from using the erf function defined by anl_erf to the intristic erf function. This should be BIT_CHANGING see clubb:ticket:804
(details / githubweb)
Removed file anl_erf.F90, it is no longer used
(details / githubweb)
I am altering the solution to the wp3 predictive equation to calculate the
(details / githubweb)
I fixed the problem with the wp3 budgets as a result of r8584. The budgets in
(details / githubweb)
I altered the names of the turbulent advection functions that are closed by
(details / githubweb)
I added a couple comments about how the discretization of the turbulent
(details / githubweb)
I added the function that sets up the implicit calculation of the wp3 turbulent
(details / githubweb)
I added a function that calculates the explicit form of the wp3 turbulent
(details / githubweb)
I am adding a function to calculate the turbulent advection of wpxp explicitly.
(details / githubweb)
I am adding a function to calculate the turbulent advection of xp2 and xpyp
(details / githubweb)
I interfaced the wp3 explicit turbulent advection code with CLUBB. It is
(details / githubweb)
I am interfacing the wpxp explicit turbulent advection option with the rest of
(details / githubweb)
I fixed a small bug with the explicit turbulent advection option for wpxp.
(details / githubweb)
I am interfacing the xp2/xpyp explicit turbulent advection term with CLUBB code.
(details / githubweb)
I added the l_explicit_turbulent_adv_* family of flags to the new PDF, for some
(details / githubweb)
I am packing up the implicit coefficients and explicit terms calculated by the
(details / githubweb)
Made epss variable based on its use by adding flag l_high_accuracy_parab_cyl_fnc. Low accuracy for runs (epss=1e-4) and high accuracy for tests (epss=1e-15), see clubb:ticket:804
(details / githubweb)
I made a slight change to function calc_coef_wpxp2_implicit in new_pdf.F90.
(details / githubweb)
I have completed interfacing the implicit form of the wp3 turbulent advection
(details / githubweb)
When the l_explicit_turbulent_adv_wp3 flag is enabled, the turbulent advection
(details / githubweb)
I cleaned up the Skx_module and added an additional function,
(details / githubweb)
I fixed a bug in the calculation of scalar skewness. It was being set to 0,
(details / githubweb)
I moved the location of the LG 2005 ansatz to calculate xp3 because it would be
(details / githubweb)
I reverted clubb:r8611 because (1) having the code in the other location
(details / githubweb)
I have added a new function, term_ta_new_pdf_lhs, to
(details / githubweb)
I have linked the implicit turbulent advection code for rtp2 and thlp2 to the
(details / githubweb)
I have added a new file that has two options for handling the xp3 term for
(details / githubweb)
I have interface the new xp3 code to the rest of CLUBB. It can be turned on
(details / githubweb)
I added a driver level subroutine for the new advance xp3 code. This will make
(details / githubweb)
I added budget stats for rtp3 and thlp3 to CLUBB.
(details / githubweb)
I am adding code that allows the turbulent advection of wpxp to be treated
(details / githubweb)
Redesigned error code system. Errors are now treated as strictly fatal, meaning they are only thrown by procedures which cannot continue or has detected something that will crash the code. When the error occurs the procedure which detected it should immediately report it and either return to its calling procedure or stop the program, this is to avoid a cascade of error reports due to a single error. Other problems are now reported at level 1 and 2 debugging and only write the error out rather than set a code.
(details / githubweb)
Redesigned error code system. Errors are now treated as strictly fatal, meaning they are only thrown by procedures which cannot continue or has detected something that will crash the code. When the error occurs the procedure which detected it should immediately report it and either return to its calling procedure or stop the program, this is to avoid a cascade of error reports due to a single error. Other problems are now reported at level 1 and 2 debugging and only write the error out rather than set a code.
(details / githubweb)
Various small comment removals and returned some functionality to api interface clubb:ticket:800
(details / githubweb)
A variable found to be less than zero now only gives a warning rather than setting an error code. Some fatal error checks also changed from debug level 2 to 0 clubb:ticket:800
(details / githubweb)
This is the first part of a two-part change. I am updating plotgen plots so
(details / githubweb)
In part 2 of this two part commit, I have added rc_coef to the list of
(details / githubweb)
Various debug checks added/improved. Negative value checks changed back to throw fatal errors. Parameterization check changes to disclude thermodynamic variables at grid level 1 clubb:ticket:800
(details / githubweb)
Check negative no longer assumes array sizes are gr%nz, this should fix the SAM-CLUBB-SILHS error in the nightly tests clubb:ticket:800
(details / githubweb)
I'm pretty sure this will fix the check negative issues this time, fortran has some lacking features when it comes to arrays clubb:ticket:800
(details / githubweb)
Changed calls to parameterization check to work with the new check negative implementation clubb:ticket:800
(details / githubweb)
Removed rtm(5) = -1 line, it was a test accidentally left in and caused many nightly tests to fail clubb:ticket:800
(details / githubweb)
Changed error checking if statements to check for equality to clubb_fatal_error rather than inequality to clubb_no_error, makes them more readable clubb:ticket:800
(details / githubweb)
Fixed unused variable warnings related to error code changes
(details / githubweb)
I am generalizing the wprcp, wp2rcp, rtprcp, and thlprcp equations to account
(details / githubweb)
Added error header functionality. Using the err_header character array from error_code in a write statment will print out either the thread number or process ID along with CLUBB -- ERROR: . This is mainly to keep track of error messages is multithreaded scenarios clubb:ticket:800
(details / githubweb)
In r8659, I accidentally overwrote some code. This commit restores the prior
(details / githubweb)
Removed failure_test cases from input/case_setups, they neither work properly nor are needed anymore. Added test_fatal_error_handling.bash script which tests for various errors defined by an identifier in the code, more description available in the bash file. Also added more descriptive error output to some parts of code. This change focuses only on output and comments and is BIT IDENTICAL clubb:ticket:800
(details / githubweb)
Removed reference to run_type 'failure_test' as it no longer exists. Added more description to fatal errors produced by calls to xm_wpxp_solve. This change is BIT IDENTICAL clubb:ticket:800
(details / githubweb)
I am fixing a bug with the CLUBB tuner. Variables that were allocated at the
(details / githubweb)
Completed the list of variables that get reported from errors within advance_wp2_wp3 and advance_xm_wpxp. Also added a check that outputs an error message when T_in_K is less than 200K in the lowest 10 grid levels, this check is done in subroutine parameterization_check. clubb:ticket:800
(details / githubweb)
Made all debug levels produce the same output, see clubb:ticket:823
(details / githubweb)
I am moving type variable implicit_coefs_terms from new_pdf_main.F90 to
(details / githubweb)
Modified many aspects of the tuner, mostly within esa_driver. Also added check to ensure that C7 and C11 have valid values before the run is tried, this should stop the fire tuning nightly test from crashing. See clubb:ticket:802
(details / githubweb)
Added checks in subroutine setup_parameters() to ensure that C7b and C11b are within [0:1] see clubb:ticket:802
(details / githubweb)
This should fix the thlm out of bounds error on clubb:ticket:828
(details / githubweb)
I changed the name of type variable new_pdf_implct_coefs_terms to
(details / githubweb)
Changed T_in_K check within subroutine parameterization_check to instead check thlm, see clubb:ticket:800 and clubb:ticket:828
(details / githubweb)
I added a flag option to clip the (large, negative) effects of microphysics on
(details / githubweb)
I added a flag option to calculate the minimum threshold for xp2 (rtp2 and
(details / githubweb)
I added a special max magnitude correlation for fluxes wprtp and wpthlp. This
(details / githubweb)
Made better esa_driver, made tuner_test to test the driver, added variable range checks. Tried to make the tuner in better in general, but that whole bunch of code needs nothing short of replacement. This commit is bit identical execpt for tuning results, see clubb:ticket:802 for a bunch more information
(details / githubweb)
This commit sets C8b=0.02, changes the non-linear damping on wp3
(details / githubweb)
Added a flag and moved Skw_max_mag from constants to parameters, this allows the changes made in commit clubb:r8719 to be reverted by modifying the configuration flags and the tunable parameters list, see clubb:ticket:829
(details / githubweb)
I am adding a general purpose function for the turbulent advection of CLUBB's
(details / githubweb)
I added/changed a couple comments for the rhs portion of the generalized
(details / githubweb)
The turbulent advection file that handles turbulent advection for predictive
(details / githubweb)
I added a function to turbulent_adv_pdf.F90, called sgn_turbulent_velocity, that
(details / githubweb)
Whoops, I forgot to make wpxpyp_zm and xpyp intent (in).
(details / githubweb)
Added functionality to make the hydrometeor variances depend on the horizontal grid spacing, see clubb:ticket:830
(details / githubweb)
I am updating the code that advances predictive variances and covariances in
(details / githubweb)
Renamed init_pdf_hydromet_arrays to init_pdf_hydromet_arrays_api since it is meant to be used by host models, clubb:ticket:830
(details / githubweb)
I am updating the code that advances predictive scalar fluxes (<w'x'>) in
(details / githubweb)
As a first step toward having code that can clip mean values of hydrometeor
(details / githubweb)
init_pdf_hydromet_arrays_api now sets the value of hydromet_dim as well, this should fix the wrf tests, but doesn't seem to fix cam. clubb:ticket:830 other:ticket:562
(details / githubweb)
I have now interfaced the subroutine that I made out of the code that clips
(details / githubweb)
I have added a call to the subroutine that clips hydrometeor concentrations from
(details / githubweb)
I added new code that clips the overall correlation of w and rt or the overall
(details / githubweb)
I added stats for term_wprtp2_explicit and term_wpthlp2_explicit, which are
(details / githubweb)
Made clubb_fatal_error public so host model code can detect fatal errors. clubb:ticket:800
(details / githubweb)
Reverted advance_windm_edsclrm_module.F90, accidentally committed test code, clubb:ticket:800
(details / githubweb)
I have added code to allow C2 to be adjusted by multiplying by the greater of
(details / githubweb)
I moved the location of the declaration and setting of new model flags to
(details / githubweb)
Improved computational speed of windm_edsclrm_rhs and added subroutine. This commit should be BIT_CHANGING as it does calculations in different orders. Only the most sensitive cases have any noticable plot differences. See clubb:ticket:834
(details / githubweb)
Fixed nightly uninitialized variables test. Renamed diffusion_zt_lhs_inner to diffusion_zt_lhs_all, it is now also capable of calculating all values including boundaries now, it's beneficial to calculate the upper boundary value in this case and I imagine other may need the lower boundary calculated as well. Cleaned up windm_edsclrm_rhs A LOT, it's more readable and has clearly ordered steps now. clubb:ticket:834
(details / githubweb)
Actually fixed nightly tests now (hopefully). A loop variable was being used outside a loop, which is an error that passes all the compiler tests. Also the intel compiler config file does not cause errors running if a index variable has not been initialized either, which resulted in correct seeming plots, timing, and output. I'm going to have to be stricter with the testing during these changes as loop variables and such will be often modified, I'll be sure to do a run after compiling with each compiler on top of confirming the output and running the uninitialized variable test manually. Because the last commit fixed the 2nd value of the rhs array the change will be BIT_CHANGING, but the plot output is identical for all but the most sensitive cases. clubb:ticket:834
(details / githubweb)
Optimized the array setup procedures within advance_xp2_xpyp. Added more functions which handle entire arrays at a time rather than single terms to calculate the turbulence, mean advection, and diffusion terms. Because these changes reordered some calculations the results are BIT_CHANGING, but the plots are the same for all but the most sensitive cases. clubb:ticket:834
(details / githubweb)
This should fix the nightly budget test. We may want to look into reducing the redone calculations for the stats code in the future, this lhs/rhs improving endeavour is definitely helping with that but more could be done. clubb:ticket:834 clubb:ticket:837
(details / githubweb)
Impoved the computational efficiency of xm_wpxp_rhs and xm_wpxp_lhs, see clubb:ticket:834
(details / githubweb)
This commit implements the effects of splatting on wp3.
(details / githubweb)
I am making the first step toward committing code that allows for the option
(details / githubweb)
I added code to allow the option of predicting upwp and vpwp by using the
(details / githubweb)
I took the liberty of upgrading CLUBB's PDF closure and related code to a vector
(details / githubweb)
I updated the monotonic flux limiter to account for vector variables u and v.
(details / githubweb)
I am adding two new budget stats, um_mfl and vm_mfl, to CLUBB's zt stats output.
(details / githubweb)
In r8775, I forgot to add the new um_mfl and vm_mfl stats to the monotonic flux
(details / githubweb)
I am turning on the l_predict_upwp_vpwp code!
(details / githubweb)
Improved the computational efficiency of the LHS and RHS setup procedures in advance_wp2_wp3_module. This involved changing the order of calculations which casues this commit to be BIT_CHANGING for only the most sensitive cases. See clubb:ticket:834
(details / githubweb)
Improved computational efficiency of windm_edsclr_lhs. See clubb:ticket:834
(details / githubweb)
Changed the name of _turb to _ta, and _advm to _ma to keep with the current naming conventions. Also fixed line length warnings. clubb:ticket:834
(details / githubweb)
Added grid_class to the dependency lists of the pdf files that were changed in commit 8773
(details / githubweb)
I am changing the default setting of flags l_min_wp2_from_corr_wx and
(details / githubweb)
Modified compute_Cx_fnc_Richardson. Made it a subroutine, modified the algorithm slightly, removed use of allocates and deallocates from it, removed verical_avg call to avoid redoing calculations and precalculated some divides. This saved clubb_core about 8% runtime overall. see clubb:issues:834
(details / githubweb)
Removed print line. Also this commit is BIT_CHANGING since it reorders some calculations, but the difference only affects the most sensitive cases.
(details / githubweb)
Changed the way that init_pdf_params zeros out values as well as a spot in pdf_closure which does the same type of thing. Also changed the debug level for pdf_closure_check to 2. This all saved about 3% overall. see clubb issue 834
(details / githubweb)
I am adding source code for the introduction of budgets for predictive upwp
(details / githubweb)
Improved computational speed of compute mixing length by modiying the algorithm slightly, avoiding unnecessary divides, and precalculating values. This saves about 6.5% overall. #834
(details / githubweb)
Improved computational efficiency of band_solve by reworking the way that the lulhs matrix is set up. #834
(details / githubweb)
Modified flatau equation which calculates saturation vapor pressure. This was done by modifying the form of the polynomial to allow the cpu to take advantage of out-of-order computations. The new coefficients were obtainted from matlab by finding the roots and multiplying/adding them where I needed to removed the complex numbers. The differences in any values are negligible, and the plots are only affected in the most sensitive cases, but this is BIT_CHANGING. #834
(details / githubweb)
Copied code from linear_interp_factor to linear_interpolated_azt/_azm. This allows those sections of code to become vectorized. Also reversed the calculation order of linear_interpolated_azt allowing for contiguous memory access. This saves about 3% overall and there are no visible differences in the plots when compared to last commit. #834
(details / githubweb)
Changed vertical_avg and vertical_intergral to use dz rather than the inverse, they were dividing by an inverse and divisions are expensive. Also modified vertical_avg algorithm to no longer use vertical_integral, this saves some calculations. #834
(details / githubweb)
Changed vertical_avg and vertical_intergral to use dz rather than the inverse, they were dividing by an inverse and divisions are expensive. Also modified vertical_avg algorithm to no longer use vertical_integral, this saves some calculations. #834
(details / githubweb)
Improved efficiency of clip_covar. The only change is saving the result of max_mag_corr * sqrt( xp2(k) * yp2(k) ) rather than calculating it three times. #834
(details / githubweb)
I made the surface splatting terms conservative. That is, I subtracted from wp2_sfc
(details / githubweb)
I added clipping on up2 and vp2 that prevents these fields from exceeding 1000 m^2/s^2.
(details / githubweb)
This commit turns on splatting of thermals (i.e., C_wp2_splat is nonzero). Hence it is BIT_CHANGING.
(details / githubweb)
Added functionality to allow cloud_frac to be better estimated at extreme values which produce either 0 or 1 when computed. The amount of estimation is controlled by the variable max_num_stdevs, indicating the number of standard deviations away from the mean of a pdf a value can be before being considered statistically insignificant. This speeds up the code but reducing the calculations required in calc_cloud_frac_component and calc_xprcp_component, and avoiding underflow errors when computing exponentials with too small of a number. By comparing plots and mathematical evaluation (erf(5)~=0), it seems the best value for max_num_stdevs is 5. This increases computational efficiency by about 10% #834
(details / githubweb)
I clipped sigma_sqd_w to prevent interpolated values of it
(details / githubweb)
I added a new option to diagnose the dissipation time scale, tau, first
(details / githubweb)
I found a new way to diagnose upthvp. Instead of using a bound on correlations, it relies
(details / githubweb)
introducing error into clubb core for testing larson-group/sys_admin#533
(details / githubweb)
reverting error that was introduced larson-group/sys_admin#533
(details / githubweb)
I am briefly changing some of the flag and parameter settings in CLUBB
(details / githubweb)
Revert "I am briefly changing some of the flag and parameter settings in CLUBB"
(details / githubweb)
I am adding code that clips the sample point value of chi under
(details / githubweb)
I have updated the SILHS code to omit the assert_consistent_cf_component
(details / githubweb)
I added a couple of comments reminding users to change the conditions in
(details / githubweb)
I added a couple of comments reminding users to change the conditions in
(details / githubweb)
Revert "Revert "I am briefly changing some of the flag and parameter settings in CLUBB""
(details / githubweb)
Revert "Revert "Revert "I am briefly changing some of the flag and parameter settings in CLUBB"""
(details / githubweb)
I committed a subroutine, diagnose_upxp, that calculates
(details / githubweb)
Improved the computational efficiency of pdf_closure. This speed the code up by about 6% overall. Because it changed the order of some calculations it is BIT_CHANGING but does not change plots. clubb issue #834
(details / githubweb)
I am modifying one part of setup_clubb_pdf_params.F90 to be taken out of a large
(details / githubweb)
I am updating the code within setup_clubb_pdf_parameters.F90 in order to take
(details / githubweb)
To diagnose uprcp using CLUBB's PDF machinery,
(details / githubweb)
Continuing with diagnosis of uprcp using CLUBB's PDF,
(details / githubweb)
More code to diagnose uprcp using CLUBB's PDF.
(details / githubweb)
Correction for the last uprcp-related commit:
(details / githubweb)
I am correcting the code so that the Nightly Uninitialized Variables Test
(details / githubweb)
I am continuing to pull parts of setup_pdf_parameters outside of a large "do"
(details / githubweb)
I am pulling statistical output subroutine pdf_param_ln_hm_stats outside
(details / githubweb)
Changing the range of the correlation values determined in calc_comp_corrs_binormal from [ -1.0, 1.0 ] to [ -0.99, 0.99 ] (based on value of max_mag_correlation = .99). This is the subroutine that calculates corr_rt_thl_x and should fix the issue with the WRF WPS Katrina bitten test as discussed in the commets of commit ad0ee5b9b3c253329df1208560b46d1dc4fca1c2. I suspect that it will fix the WRF-CLUBB-SILHS Restart Test as well, but I am basing that mostly off hope.
(details / githubweb)
commenting out threadprivate command to test openmp bitten test larson-group/sys_admin#566
(details / githubweb)
I have changed the structure of setup_pdf_parameters so that the subroutine that
(details / githubweb)
Returned max check to the calculation of rcm. This should fix the PGI Compiler Nightly Test and could be BIT_CHANGING.
(details / githubweb)
I am turning on the new calculation of uprcp that uses CLUBB's PDF.
(details / githubweb)
I modified the code in setup_clubb_pdf_params.F90 to use only one call to
(details / githubweb)
I am updating CLUBB_core and SILHS in the clubb_E3SM_silhs branch to
(details / githubweb)
I am setting model flags and tunable parameters in the clubb_E3SM_silhs branch
(details / githubweb)
I temporarily set l_clip_extreme_chi_sample_pts back to false in the
(details / githubweb)
Revert "I temporarily set l_clip_extreme_chi_sample_pts back to false in the"
(details / githubweb)
The value of nz is passed into SILHS, so we don't need to use gr%nz.
(details / githubweb)
I improved the error messages when LU decomp. fails within
(details / githubweb)
Improved error message prints in advance_xm_wpxp.
(details / githubweb)
I added improved LHS and RHS print statements when a LU decomp. error occurs
(details / githubweb)
I added params_list to the list of variables that are accessible through
(details / githubweb)
I am making the first step for updating the code that calculates sigma_sqd_w.
(details / githubweb)
I added a log-law height dependence to the code that diagnoses
(details / githubweb)
I added fill_holes_hydromet_api to clubb_api_module.F90.
(details / githubweb)
I added a new python script, check_for_missing_threadprivate.py,
(details / githubweb)
Modifying clubb's pdf_parameter type. It's now a type containing arrays, whereas before it was a type containing scalars, but used everywhere as an array of these types. This new way allows the elements of pdf_parameter to exist in contiguous memory sections, which improves computational efficiency when accessing a given parameter over all vertical levels. clubb issue #834
(details / githubweb)
Modifying clubb's pdf_parameter type. It's now a type containing arrays, whereas before it was a type containing scalars, but used everywhere as an array of these types. This new way allows the elements of pdf_parameter to exist in contiguous memory sections, which improves computational efficiency when accessing a given parameter over all vertical levels. clubb issue #834
(details / githubweb)
Fixed dycoms restart run failure. The pdf_parameter variables are accessed via a use statement in the section of code where the restart run attempts to set their values, but since they are allocatable they do not retain their allocated status once out of scope. Adding the save attribute to pdf_params and pdf_params_zm fixes the problem. These pdf_parameter variables used in clubb standalone are not used by host models, yet they are still allocated during host model runs, something that has been noted before and will be changed. clubb issue #834
(details / githubweb)
Adding conditional statement around compute_Cx_Fnc_Richardson, see clubb issue #855. This change is bit identical.
(details / githubweb)
Optimizing procedures within Skx_module. The reduction in runtime is greatly dependent on system and compiler option. See clubb issue #855 and comment by Gunther on 7-1-19 for explanation. This is BIT_CHANGING but the plots only differ in the sensitive cases.
(details / githubweb)
ticket #842 we added 4 tunable parameters for tau, they are Coefficient of inverse tau term contributed by background constant value, Coefficient of inverse tau term contributed by surface log law, Coefficient of inverse tau term contributed by vertical wind shear and Coefficient of inverse tau term contributed by Brunt Vaisala frequency
(details / githubweb)
Modifying ADG1_ADG2_responder_params for efficiency reasons. It changes the way varnce_x_(1/2) is set when wp2 > w_tol_sqd and xp2 <= x_tol. Previously in that case it set the variances to 0, but now it sets them to xp2 since xp2 ~= 0 in that case anyway. This allows the where statement to have only two cases, and less cases is more efficient. This is BIT_CHANGING, but only affect the sensitive cases and passes the G unit tests. larson-group/clubb#855
(details / githubweb)
Replacing the local variables used in pdf_closure_module with references to the variables in pdf_params which they are meant to be stored in. This removes the need to copy the local variables into the pdf_params structure at the end, saving about 3% runtime. This is not bit changing, but does make the code a little uglier. larson-group/clubb#855
(details / githubweb)
Making procedure calls consistent with procedure definitions. Required updating after previous pdf_parameter related commit. larson-group/clubb#855
(details / githubweb)
I have added a new file, calc_pressure.F90, which contains code for initializing
(details / githubweb)
I updated CLUBB so that pressure is updated after mean fields have been
(details / githubweb)
Removing gmres code. The files gmres_wrap.F90, gmres_cache.F90, and csr_matrix_module.F90 have been removed, and any sections of code which refer to or are needed only for gmres have been removed as well. larson-group/clubb#855
(details / githubweb)
Forgot to run previous commit with --all, so the gmres files were not removed. larson-group/clubb#855
(details / githubweb)
We added two new tunuable parameters: C_invrs_tau_N2_xp2 and C_invrs_tau_N2_wp2. e.g. invrs_tau_wp2_zm = invrs_tau_zm_simp + C_invrs_tau_N2_wp2 * sqrt( max( zero_threshold,zt2zm( zm2zt( brunt_vaisala_freq_sqd ) ) - 1e-4_core_rknd) ). Correspondingly, invrs_tau_wp2_zm and invrs_tau_xp2_zm are used in advance_wp2_wp3 and advance_xp2_xpyp respectively.
(details / githubweb)
We added two new tunuable parameters: C_invrs_tau_N2_xp2 and C_invrs_tau_N2_wp2. e.g. invrs_tau_wp2_zm = invrs_tau_zm_simp + C_invrs_tau_N2_wp2 * sqrt( max( zero_threshold,zt2zm( zm2zt( brunt_vaisala_freq_sqd ) ) - 1e-4_core_rknd) ). Correspondingly, invrs_tau_wp2_zm and invrs_tau_xp2_zm are used in advance_wp2_wp3 and advance_xp2_xpyp respectively. 1. Some typos are corrected. 2. New tunuable parameters are added in files named errer_$casename.in (issue #842)
(details / githubweb)
We put Lscale's calculation into mixing_length.F90 (subroutine calc_Lscale_directly)
(details / githubweb)
Efficiency improvements to calc_turb_adv_range, more specifically the parts which split w into upward and downward components. This adds a case to zero out upward and downward components for values of w that are too small to matter, and now utilizes mkl_vml math functions to improve vectorization. These mkl_vml functions are only used when compiled with MKL, specified by adding -DMKL to compiler configuration files. This is BIT_CHANGING, plots only differ in the usual sensitive cases, and the budgets, G_unit_tests and time step tests all pass. larson-group/clubb#855
(details / githubweb)
This should fix the uninitialized variables test. mean_vert_vel_up_down was using the upper and lower grid levels, but calc_mean_w_up_down_component was not setting them. These levels aren't actually used by the algorithm in calc_turb_adv_range, but I made calc_mean_w_up_down_component set them to zero anyway since it seems like the simplest and safest solution. larson-group/clubb#855
(details / githubweb)
An additional damping is added to the invrs_tau term in the C8 equation. ticket #842
(details / githubweb)
Adding comment because commit 561fa037e7c3c326bc4bd71b6fc486e5d2a46065 was BIT_CHANGING, but missing the commit message specifying that. It was bit changing because the upper and lower levels of mean_w_up and mean_w_down are being output to stats as of commit 0b3ec0d5fc4b89b4a6f34964af3cfda8cb89b9f7, so changing the upper and lower level values changed the stats output, even though those values are not used in any calculations.
(details / githubweb)
We use zt2zm(ice_supersat_frac) replace ice_supersat_frac_zm in the additional damping of C8.
(details / githubweb)
Changing ADG1_ADG2_responder_params to use a do loop with ifs instead of a where statement. This is about 1.5% faster and is bit identical. larson-group/clubb#855
(details / githubweb)
Pulling the calculation of p_in_Pa(_zm) out of the vertical loop in update_pressure, and precalculates one/kappa. This improved vectorization capabilities of the calculation of exponents, which is slow so that's important. Also added the option to use MKL_VML functions if -DMKL is specified, which is slightly more efficient. This saves about 1.5-2.5% and is bit identical if not using MKL. larson-group/clubb#855
(details / githubweb)
Renaming width_factor to width_factor_1 to indicate that it is intended for use with the first pdf component, (two-width_factor_1) is the value for the second component. larson-group/clubb#855
(details / githubweb)
Efficiency improvements to transform_pdf_chi_eta_component. Moving the where statement to if statement inside loop to avoid sqrt operations. Reducing number of divide operations, and putting some code in a loop which reduces cache misses. This is BIT_CHANGING, but not answer changing, plots only differ slightly in the most sensitive cases. larson-group/clubb#855.
(details / githubweb)
Modifying calc_cloud_frac_component to optionally use mkl_vml functions. Added a different version of the procedure to handle the liquid cloud fraction specifically, so the ice_supersat_frac could remain as is. The structure of the procedure when using the MKL functions is based on the changes to calc_turb_adv_range in commit 0b3ec0d5fc4b89b4a6f34964af3cfda8cb89b9f7, since I've already tested that well and it seems to make sense to keep the code similar if it does similar things. This reduces runtime by about 2% when using MKL functions and about 0.5% otherwise. The procedures also use precalculated inverses where possible, so the results are BIT_CHANGING, but not answer changing. larson-group/clubb#855
(details / githubweb)
Refactoring the lhs and rhs setup procedures for xm_wpxp. There are a number of lhs terms that are very general, and used by all the lhs matricies. The code now calculates these terms in a new procedure calc_xm_wpxp_lhs_terms and passes those terms into the lhs setup. The same sort of thing is done with the first pressure terms and turbulent advection terms, those terms are shared between pairs of lhs/rhs calls. This is BIT_CHANGING, but is not answer changing. See comment on Jul 3 on ticket larson-group/clubb#855
(details / githubweb)
I switched on direct diagnosis of tau rather than Lscale.
(details / githubweb)
I updated the pressure initialization for cases that use sounding that is given
(details / githubweb)
I changed the function calculate_thvm from a pre-defined vector of size nz to
(details / githubweb)
I updated the calculation of thvm in advance_clubb_core to use the
(details / githubweb)
Adding SAVE attribute to some stats variables, as it was causing compiler errors when using the newest version of the gfortran compiler. Also commenting out Lapack library dependency from gfortran config file, this required additional Lapack source files be added. Now, no Lapack library files are required to compile CLUBB, whereas before, the source was being compiled, but the missing dependencies we're being added from libraries. This is BIT_CHANGING in all cases when using the gfortran compiler, but only in some cases when using the ifort compiler. Some plots, such as rico, are noticably different when compiled with gfortran, but are bit identical when compiled with ifort. The intel implementation of Lapack used by the ifort compiler must be more similar to the source Lapack than was the Lapack library that was being used for the gfortran compiler.
(details / githubweb)
Adding a subroutine in advance_xp2_xpyp to calculate the turbulent advection terms and modying the rhs and lhs setup procedures to accept these turbulent advection terms as inputs. Before, the turbulent advection terms were calcualted within the rhs and lhs setup procedures, but this resulted in expensive redundant calculations. larson-group/clubb#855
(details / githubweb)
Changing where statement that was causing floating point errors to a do with if's. This should allow code compiled with the newest version of gfortran to run to completion for microphysics enabled cases. This is BIT_CHANING in microphysics cases, but the values of the output arrays of the only changed subroutine only differ starting around roughly the 13th decimal place. larson-group/clubb#859 larson-group/sys_admin#626
(details / githubweb)
I am committing a test where I changed subroutine ADG1_w_closure
(details / githubweb)
Changing determination of threshold used to clip large values of rtp2. Before it was possible that this large value clipping introduced a value before tolerance, if rtm was too small. Causing addition problems and potentially crashes. This is BIT_CHANGING. larson-group/clubb#862
(details / githubweb)
Finally fixing line length error in pdf_closure
(details / githubweb)
Adding more Lapack source files, and a new file to interface with Lapack routines in general. This allows us to call a general interface procedure that can handle single or double precision routines. This should fix the ifort bug we've been seeing, and should be a more robust way to handle this double/single precision situation in general. Works with all compilers, and in single or double precision, producing bit identical results. See larson-group/clubb#861
(details / githubweb)
Adding more Lapack source files, and a new file to interface with Lapack routines in general. This allows us to call a general interface procedure that can handle single or double precision routines. This should fix the ifort bug we've been seeing, and should be a more robust way to handle this double/single precision situation in general. Works with all compilers, and in single or double precision, producing bit identical results. See larson-group/clubb#861
(details / githubweb)
Adding blunt clipping to below ground level of xm variables, keeping their value at least tolerance. This prevents the crashing of mc3e caused by rtm being < 0. This is BIT_CHANGING, but only for mc3e, and the plots are very similar. Which must mean that mc3e is our only case where rtm becomes too small. larson-group/clubb#862
(details / githubweb)
This commit is BIT_CHANGING. It is mainly because 1) We changed the equation of tau_xp2_zm, producing a better agreement with LES. 2) Many parameters have been retuned. We reduce nu2 and c_k2, because they bring us stronger scalar variances,especially for RFO1. We set C1=1, because it helps to reduce wp2 near cloud top. We also set C6=2 to generate stronger fluxes etc.
(details / githubweb)
Adding C_invrs_tau_N2_wpxp to the initmax namelist. This should fix the fire tuning crashes. larson-group/sys_admin#626
(details / githubweb)
I am adding a file for the new hybrid PDF, which combines the w equation set
(details / githubweb)
I updated the function to calculate the implicit coefficient for the wp4 term,
(details / githubweb)
I made some changes to new_hybrid_pdf.F90 so that it would compile in its
(details / githubweb)
I edited that subroutine that calculates the implicit coefficient and explicit
(details / githubweb)
I updated the subroutine that calculates the implicit coefficient and explicit
(details / githubweb)
Replaced rrm_cond with rrm_evap and Nrm_cond with Nrm_evap because they described the same quantity. This is BIT_CHANGING just because the output now contains the N/rrm_evap instead of N/rrm_cond variable name. No changes were made to the values themselves.
(details / githubweb)
I am adding a new file, new_hybrid_pdf_main.F90, as a driver file for the new
(details / githubweb)
I worked more the functions for the new hybrid PDF.
(details / githubweb)
Refactoring advance_xp2_xpyp to have the capability to perform only one combined solve when the lhs matricies are equivalent. larson-group/clubb#855
(details / githubweb)
I changed all the PDF utility functions in pdf_utilities.F90 to elemental
(details / githubweb)
Removed all use statements involving silhs flags from the SILHS files below the API level and putting the flags into the argument lists.
(details / githubweb)
Adding intent(in) attribute to rhs_ta terms and making scalar forcings local variables, since that is what they were supposed to be. larson-group/clubb#855
(details / githubweb)
Adding case to and modifying xp2_xpyp_solve to remove the need for xp2_xpyp_solve_multiple. larson-group/clubb#855
(details / githubweb)
Refactoring advance_xm_wpxp to clean up code. Now subroutines solve_xm_wpxp_with_multiple_lhs and solve_xm_wpxp_with_single_lhs are called, rather than having huge chunks of similar code. Also changing the way calc_xm_wpxp_ta_terms works, it uses other input variables rather than coef_ and term_ arguements and instead calculates those locally to abstract functionality. This is BIT_CHANGING for some cases, but idenetical for some with some compilers. There are no visible differences in plots when tested with a number of different flags, and gabls2 (which uses scalars) are also the same. larson-group/clubb#855
(details / githubweb)
I am continuing to build the driver subroutine for the new hybrid PDF.
(details / githubweb)
I am continuing to work on the driver file for the new hybrid PDF.
(details / githubweb)
I have completed the main parts of the driver subroutine for the new hybrid PDF.
(details / githubweb)
The code for the new hybrid PDF now compiles.
(details / githubweb)
I have added the new hybrid PDF to the G unit tests.
(details / githubweb)
Mathematically, sigma_x_1_sqd and sigma_x_2_sqd cannot be less than 0.
(details / githubweb)
I added code to interface the call to the new hybrid PDF with pdf_closure
(details / githubweb)
I interfaced the implicit coefficients and explicit terms used in the turbulent
(details / githubweb)
I fixed a small error. The code compiles again now.
(details / githubweb)
Updated the larson-group.com urls to http://carson.math.uwm.edu/larson-group
(details / githubweb)
Updated the larson-group.com urls to http://carson.math.uwm.edu/larson-group
(details / githubweb)
Pushing down loops over transform_uniform_samples_to_pdf and resolving many if statments beforehand by copying values to new arrays with an additional sample index. This is all bit-for-bit. larson-group/clubb#869
(details / githubweb)
Replacing the lapack function with a simple loop to multiply a pdf_dim x pdf_dim array by a pdf_dim vector. The arrays are too small to justify using lapack. This ends up slightly faster and allows a lot more flexibility which is going to be needed shortly. This is BIT_CHANGING, but not answer changing. larson-group/clubb#869
(details / githubweb)
I have added code that allows CLUBB to run interactively using the new hybrid
(details / githubweb)
I am updating the subroutine that calculates PDF component means and standard
(details / githubweb)
I placed proper thresholding on interpolated up2 and interpolated vp2
(details / githubweb)
I introduced the silhs_config_flags_type in clubb which now handles all SILHS config flags.
(details / githubweb)
I added a limiter to keep the maximum magnitude of the correlations of
(details / githubweb)
I upgraded Nc_Ncn_eqns.F90 to use elemental functions.
(details / githubweb)
The new hybrid PDF also uses this bit of code that sets the correlation
(details / githubweb)
I made modifications to the new hybrid PDF so that that calculation of F_w
(details / githubweb)
Minor clean-up. Writing 'Intent(in)' in call to 'generate_uniform_sample_at_k_lh_start' and adding descriptions for input and output arguments in 'initialize_silhs_config_flags_type(_api)' and 'set_default_silhs_config_flags(_api)'. #856
(details / githubweb)
Fixed small typo I accidentally introduced in my last commit.
(details / githubweb)
I added the ability to handle scalars interactively to the new hybrid PDF.
(details / githubweb)
I found a couple of spots in the new hybrid PDF where I needed to add
(details / githubweb)
I added init_pdf_implicit_coefs_terms_api to clubb_api_module.F90.
(details / githubweb)
The variable type implicit_coefs_terms needs to be made public
(details / githubweb)
I changed the value of the coefficient in the F_w equation to 0.45
(details / githubweb)
I am updating the code to pass up3, vp3, and sclrp3 out of advance_clubb_core
(details / githubweb)
Replacing algorithm that calculates the inverse CDF. It's only accurate to single precision, so the uniform samples are clipped to be within a valid range for the algorithm to always be accurate. This is BIT_CHANGING for silhs enabled cases, but plots are visibly identical for rico_silhs. larson-group/clubb#869
(details / githubweb)
I have added a print subroutine for the SILHS configurable flags. #856
(details / githubweb)
I have started the process of adding the coding infrastructure
(details / githubweb)
I have completed the addition of the ability to use different up2
(details / githubweb)
I have added 'l_use_precip_frac', 'l_do_expldiff_rtm_thlm', 'l_use_C11_Richardson' and 'l_prescribed_avg_deltaz' to the 'configurable_clubb_flags_nl' namelist. The latter was moved from 'model_setting' namelist. #856
(details / githubweb)
I made the l_calc_w_corr code (turned off by default) run again by
(details / githubweb)
I added a few more flags to the 'configurable_clubb_flags_nl' namelist. Also I gave 'l_use_wp3_pr3' the parameter attribute.
(details / githubweb)
I have started altering argument lists to feed clubb configurable flags through them. This commit has 'l_use_precip_frac',
(details / githubweb)
I continued to alter argument lists. This commit covers 'l_C2_cloud_frac', 'l_diffuse_rtm_and_thlm', 'l_stability_correct_Kh_N2_zm',
(details / githubweb)
I continued to alter argument lists. This commit covers ' l_vert_avg_closure', 'l_trapezoidal_rule_zt', 'l_trapezoidal_rule_zm',
(details / githubweb)
Adding more clipping to the uniform sample values, and reducing the treshold. This is BIT_CHANGING. larson-group/clubb#869
(details / githubweb)
I continued to alter argument lists. This commit covers the last flags in the namelist 'configurable_clubb_flags_nl', namely 'l_predict_upwp_vpwp',
(details / githubweb)
I continued to alter argument lists. This commit covers the last flags in the namelist 'configurable_clubb_flags_nl', namely 'l_predict_upwp_vpwp',
(details / githubweb)
Changing values to use core_rknd precision. larson-group/clubb#869
(details / githubweb)
Cleaning up clip_transform_silhs_output and removing the X_nl_all_levs_raw variable. This is all bit-for-bit. larson-group/clubb#869
(details / githubweb)
Changing X_nl_all_levs to inout in clip_transform_silhs_output_api, this was missed in the last commit. larson-group/clubb#869
(details / githubweb)
Finished altering argument lists. This commit covers the final seven flags, which are in different namelists.
(details / githubweb)
Finished altering argument lists. This commit covers the final seven flags, which are in different namelists.
(details / githubweb)
Pushing a loop down and other small performance refactorings. This is bit-for-bit. larson-group/clubb#869
(details / githubweb)
I introduced the 'clubb_config_flags_type'. Furthermore, I have created subroutines to set default values, to initialize the derived type and to print the derived type.
(details / githubweb)
I enabled the use of the 'clubb_config_flags_type'. I changed 'clubb_standalone', 'clubb_tuner' and the G_unit_tests so that they now use it. The results are bit-for-bit identical. #856
(details / githubweb)
I enabled the use of the 'clubb_config_flags_type'. I changed 'clubb_standalone', 'clubb_tuner' and the G_unit_tests so that they now use it. The results are bit-for-bit identical. #856
(details / githubweb)
I have removed the 'rc_estimate' subroutine in 'src/SILHS/est_kessler_microphys_module.F90' because it was not working properly. I changed the 'autoconv_estimate' subroutine in the same file to be able to calculate both 'lh_AKm' and 'lh_rcm_avg' with it. I renamed that subroutine to 'calc_estimate'. #692
(details / githubweb)
I fed pdf_params_frz into subroutine advance_clubb_core
(details / githubweb)
Adding error code to arguement list of non-api routines where it was included in the api version.
(details / githubweb)
Moving location of error messages that were in advance_clubb_core. Adding error code setting to those spots as well, they should be fatal.
(details / githubweb)
Added use statement for pdf_params_frz in src/CLUBB_core/clubb_api_module.f90 and made it public.
(details / githubweb)
I have fixed the warnings for lines exceeding 100 characters.
(details / githubweb)
I have fixed the warnings for lines exceeding 100 characters.
(details / githubweb)
Passing individual flags into setup_clubb_core, rather than the type container for them. This is done for code clarity.
(details / githubweb)
Adding GPU code to portion of SILHS, and refactoring minor aspects of code structure. larson-group/clubb#869
(details / githubweb)
Removing problems. This should fix the compiler error.
(details / githubweb)
Making subroutine to generate random samples and weights on CPU's, this will be accompanied by one for GPU's shortly. This is bit-for-bit. larson-group/clubb#869
(details / githubweb)
Simplifiying call trees a bit, removing unused procedures, and creating a random pool to be used where random numbers were being used. This pool allows all randoms to be generated at the same time, which is better for CPUs and (as far as I know) the only decent way to do this on GPUs. Becuase of the different random numbers, this is BIT_CHANGING. larson-group/clubb#869
(details / githubweb)
Trivial update to test if cams autoupdate works
(details / githubweb)
Changing clipping of uniform samples. This is the same fix from commit afe34fb444a47aa4cb8bcc8b9cbcaeceb0539c9f, but was accidentally reverted in commit 766a5934a8352a556ed5ba2cfeac6aa547f76f86. larson-group/clubb#869
(details / githubweb)
Commiting a space, because the last commit, be3699d840ed6bc3ff52dc5d397a74767ecdc414, is BIT_CHANGING.
(details / githubweb)
Simplifying call tree some more, moving around where calculations are done so that GPU code doesn't have to be interrupted with data copies or CPU code. This is bit-for-bit. larson-group/clubb#869
(details / githubweb)
Lots of GPUizing and reorganizing calls. This is bit-for-bit. larson-group/clubb#869
(details / githubweb)
Revert "I am setting model flags and tunable parameters in the clubb_E3SM_silhs branch"
(details / githubweb)
Moving sample point clipping to after the sampling drivers, rather than immediately after generate_uniform_lh_sample. This was causing sample points to end up out of range when compiling in single precision, which is why the nightly tests were failing for PGI. This should be BIT_CHANGING. larson-group/clubb#869
(details / githubweb)
I placed E3SM preprocessor commands around E3SM-specific code in
(details / githubweb)
Restoring assertion check for the vertical correlation calculation. larson-group/clubb#869
(details / githubweb)
Changing the error treshold in assert_correct_cloud_normal to use the previously defined single precision threshold. This should fix occasional errors. larson-group/clubb#869
(details / githubweb)
I added E3SM's clubb_ parameters that can be read in from the
(details / githubweb)
I added the remainder the clubb_ terms that were added previously to
(details / githubweb)
Changing error threshold in assert_correct_cloud_normal and fixing bug where we weren't passing the correct array section. This should fix the WRF parallel test and the PGI test. larson-group/clubb#869
(details / githubweb)
Small updates to acc kernel statments for general performance improvement. This is bit-for-bit. larson-group/clubb#869
(details / githubweb)
Redoing some data directives to only copy data that we need off the device. Data that is needed by assertion checks and stats will be updated conditionally. This will make the code faster when no stats/assertion checks are being done, but slower when it is. This is all bit-for-bit. larson-group/clubb#869
(details / githubweb)
Adding space because commit a8e61923fa19887baef220aa1a7c8be0f773770f was BIT_CHANGING. larson-group/clubb#869
(details / githubweb)
Simple performance improvement refactoring. Merging loops and creating tmp variable to use to help reduce memory usage. This changes the order of operations so this is BIT_CHANGING. larson-group/clubb#869
(details / githubweb)
Small performance improvement. Almost reverting the loops to their previous form using the unbounded_point variable. This is all bit-for-bit. larson-group/clubb#869
(details / githubweb)
Removing lh_clipped_vars and replacing functionality with arrays. larson-group/clubb#869
(details / githubweb)
GPUizing clip_transform_silhs_output and pushing data directives up call tree. This is all bit-for-bit. larson-group/clubb#869
(details / githubweb)
Making some data copying regions asyncronous with compute regions, improving performance. This is bit-for-bit. larson-group/clubb#869
(details / githubweb)
I changed the dummy argument 'value' in the 'stat_update_var' subroutine from explicit to assumed size. #874
(details / githubweb)
I added the new l_update_pressure configurable flag to clubb_config_flags.
(details / githubweb)
I added some code I used in the special input fields branch to make
(details / githubweb)
An improved NaN-Inf checker. It is based on IEEE_ARITHMETIC. (issue#875)[https://github.com/larson-group/clubb/issues/875]
(details / githubweb)
I revert the changes from commit 'fbcbd86' from February 14th 2020 to resolve an issue with SAM CLUBB. For details see #874.
(details / githubweb)
I got rid of the "allocatable", "allocate", and "deallocate" statements
(details / githubweb)
I placed an ifndef CLUBB_CAM preprocessor flag around the code in
(details / githubweb)
I reduced the minimum possible value of lmin from 4.0 to 1.0.
(details / githubweb)
I made a print/write statement debug level 3
(details / githubweb)
I made a second print/write statement debug level 3
(details / githubweb)
I fix a print/write statement debug level3. For #755 and #800
(details / githubweb)
I am replacing the "use" statements that referenced
(details / githubweb)
I "brought back the stats" by passing the stats from advance_clubb_core
(details / githubweb)
Removing the reference to variables_diagnostic_module (sigma_sqd_w_zt and rtm_ref)
(details / githubweb)
Results were changed yesterday for some cases because thlprcp was
(details / githubweb)
I have resolved all the issues surrounding recent CLUBB commits that
(details / githubweb)
I removed code that stops a run if the output time step is less than a minute.
(details / githubweb)
I removed references to variables_prognostic_module and
(details / githubweb)
Removed a comma that I missed while removing unused imports (#878)
(details / githubweb)
I am adding l_partial_upwind_wp3 to the list of clubb_config_flags.
(details / githubweb)
Deprecating use of l_Lscale_vert_avg in SILHS. This is causing problems with the GPUization efforts, described in larson-group/cam#129
(details / githubweb)
I started the process of paring 2 subprograms back down to 1 in
(details / githubweb)
I pared two more sets of equivalent subprograms down to 1 (each).
(details / githubweb)
Paring down 2 equivalent subprograms to 1 again.
(details / githubweb)
I condensed two more sets of doubled subprograms down to 1 (each)
(details / githubweb)
Reduced two more sets of "doubled" subprograms down.
(details / githubweb)
Updating silhs to prepare the column loop commit. This is being committed seperately because it is BIT_CHANGING, due to the way we are initializing the random number generator on CPUs. larson-group/cam#129
(details / githubweb)
Adding column loop index to silhs, and pushing loops down to allow parallelization over the column index. This requries changing the api, but it is bit-for-bit running on both gpus and cpus. larson-group/cam#129
(details / githubweb)
Adding interface in silhs_api to distinguish single vs multiple comulmn calls. This seems to be a better solution than the previous attempt that broke the nightly tests. When calling silhs a single column at a time, the api will copy the single column data into arrays with a grid column index, allowing us to leave the host models the same. larson-group/cam#129
(details / githubweb)
Removed styleguide violations from my code
(details / githubweb)
Fixed a backwards epsilon comparison from 8e8e71e
(details / githubweb)
Removed the "doubling" of the remainder of the subprograms from
(details / githubweb)
Changing epsilon used in equality comparison. The previous epsilon seems to be too large, and was causing failures in runs. larson-group/clubb#878
(details / githubweb)
Small changes to generate_all_uniform_samples. I was encountering a gpu problem with this code when run in cam. I'm not certain why this is an issue, but this changes fixes it and is bit-for-bit on both cpus and gpus. larson-group/cam#129
(details / githubweb)
Changed the length of solve_type_str to 20 [-Wcharacter-trucation]
(details / githubweb)
Adding functionality to pass in a seed for the random number generator. This allows CPU restart runs to function correctly. Because this also changes the seed, this is BIT_CHANGING. larson-group/cam#129
(details / githubweb)
Removed import without only as it was unused
(details / githubweb)
Adds mpishorthand back with only, it appears to be used somewhere
(details / githubweb)
I have pared two subprograms down to one again, this time for the
(details / githubweb)
I pared down subprogram pairs again, this time for mean advection.
(details / githubweb)
I added altitude_threshold to the list of CLUBB's tunable parameters.
(details / githubweb)
Updating clubb variables to output their var_description in the form '[variable name using sci notation], [Textual descirption]' in an effort to provide more standardized titles for pyplotgenplots.
(details / githubweb)
Updating previous commit to not have lines over 100 characters. This commit shouldn't be BIT_CHANGING, but the previous commit was (and was supposed to be).
(details / githubweb)
Changes length of units variable in stat_file_module from 20 to 25
(details / githubweb)
This commit resolves issue #885 and gets the 2D output working, if the relevant flags are set to true. A duplicated allocate statement is eliminated, and to ensure that the 2D output occurs at the right intervals (every stats_tout seconds) I have also added approrpiate if statements at the beginning of the 2D output subroutines.
(details / githubweb)
Adding API subroutines for latin_hypercube_2D_output and latin_hypercube_2D_close. This will aid in implementing the SILHS 2D output subroutines in host models. The new API subroutines necessitated some minor changes in clubb_driver.F90 as well. Mainly relevant to https://github.com/larson-group/wrf/issues/110 (WRF repo), but see also #885 (CLUBB repo).
(details / githubweb)
I updated the stats code in setup_clubb_pdf_params.F90 and in
(details / githubweb)
I updated the stats code in setup_clubb_pdf_params.F90 and in
(details / githubweb)
This commit primarily overhauls the way the 2D SILHS samples are output to netCDF. Now, instead of being output along the latitude dimension in a 4d netCDF file, the SILHS samples are output along the "lh_sample_number" dimension of a 5d netCDF file. Furthermore the lat/lon dimensions of the 2D SILHS sample files are now output with the correct lat/lon information.
(details / githubweb)
This commit primarily overhauls the way the 2D SILHS samples are output to netCDF. Now, instead of being output along the latitude dimension in a 4d netCDF file, the SILHS samples are output along the "lh_sample_number" dimension of a 5d netCDF file. Furthermore the lat/lon dimensions of the 2D SILHS sample files are now output with the correct lat/lon information.
(details / githubweb)
Undoing accidental find and replace. larson-group/cam#129
(details / githubweb)
Updated titles listed for change here: https://github.com/larson-group/sys_admin/issues/542#issuecomment-685963832
(details / githubweb)
Fix super serious 1 character bug that broke all of the things
(details / githubweb)
I am committing Zhun's changes to the CLUBB portion of his
(details / githubweb)
I added Cx_min, Cx_max, Richardson_num_min, and Richardson_num_max
(details / githubweb)
I connected the new tunable parameters to advance_helper_module.F90.
(details / githubweb)
I added l_use_shear_Richardson to CLUBB's configurable model flags.
(details / githubweb)
Adding linear multistep method (LMM) stepping flag (l_lmm_stepping) to provide capability of overstepping-and-then-averaging results from advance_wp2_wp3, advance_xm_xpwp, and advance_xp2_xpyp. This is intended to help smooth high-frequency oscillations. Flag is set to false by default so has no impact on standard runs.
(details / githubweb)
In order to prevent dycoms2_rf02_so from crashing,
(details / githubweb)
I updated the recording of the budget terms for upwp_pr4 and vpwp_pr4.
(details / githubweb)
Adding the smooth_min and smooth_max functions to the repo. These are not yet implemented in CLUBB but are now available for use and testing. See issue #894.
(details / githubweb)
Adding some comments describing zm and zt for the new interface functions, and fixing a problem in the "array_sclr" versions of the functions. See issue #894.
(details / githubweb)
Modifying some array dimensions to speed up multiply_Cholesky. This cuts the cost of multiply_Cholesky by about 60% in cam but only about 15% in clubb_standalone. larson-group/cam#129
(details / githubweb)
This commit replaces division by tau with multiplication by inverse tau in most cases. It is BIT_CHANGING, not only because the results change (only very slightly in some cases, but more significantly in sensitive cases like ARM_97, RICO, etc.) but also because some of the old tau_*_zm or tau_*_zt output variables are replaced with invrs_tau_* variables, hence the netcdf files will differ and there are minor changes to stats input files. Spurious source test also needed to be slightly modified to accommodate a new variable fed into the advance_xm_wpxp subroutine.
(details / githubweb)
I am committing a bug fix to the invrs_tau_zm equation that was
(details / githubweb)
This commit introduces a new flag, l_e3sm_config, which enables the user to switch on or off some of the changes introduced in connection with the E3SM merge (see commit https://github.com/larson-group/clubb/commit/cf5b2e4b80d8bd3ca411b9b5e6d5a2afece04795). It also introduces two new tunable parameters, C_invrs_tau_wpxp_Ri and C_invrs_tau_wpxp_N2_thresh, to replace two "magic numbers" in the code. The primary code changes are in advance_clubb_core_module.F90.
(details / githubweb)
Adding new flag that allows the user to implement the TKE formulation of the wp3 C15 term (known currently as bp2, but ultimately will be called pr3). See issue #884.
(details / githubweb)
Separating out the parameter C5 into C_uu_shr and C_uu_buoy, consistent with the formalism of Mironov and Machulskaya 2017. C5 has been effectively renamed C_uu_shr, and a new parameter C_uu_buoy has been introduced. See https://github.com/larson-group/clubb/issues/901.
(details / githubweb)
I am now passing vert_decorr_coef into SILHS instead of involving
(details / githubweb)
This commits further updates related to splitting the parameter C5 into C_uu_shr and C_uu_buoy (see this commit: https://github.com/larson-group/clubb/commit/3f75a27dd94673a2b8603c24b989da106e759b39). Changes include correcting one instance where C_uu_shr was passed to a function when C_uu_buoy should've been passed, and also now applying the changes to up2 and vp2, which was overlooked before. I've also updated the comments to remove, where appropriate, references to "C_5" that were missed before (in a few places I have left the C_5 in place but included a note indicating that it has now been broken up).
(details / githubweb)
Adding a test to make sure new C_uu_buoy parameter is within the valid range. See #901.
(details / githubweb)
This commit renames the wp3 budget term from "bp2" to "pr_turb", and renames the related parameter "C15" to "C_wp3_turb". The majority of files changed are supplemental files such as postprocessing files for plotgen and pyplotgen and tuner files and input files.
(details / githubweb)
This will allow for a better interface of SILHS parameter
(details / githubweb)
Revert "This will allow for a better interface of SILHS parameter"
(details / githubweb)
I updated silhs_api_module so that vert_decorr_coef is publically available
(details / githubweb)
Incorporating Shixuan Zhang's and Chris Vogl's "l_godunov_upwind_wpxp_ta" flag and related code. The flag is set to false by default so results are unaffected. See #902.
(details / githubweb)
Updating advance_xm_wpxp_module so that the upwp_pr4 term uses the parameter C_uu_shr instead of the hard-coded value 0.7. Also updating the value of C_uu_shr from 0.3 to 0.4 after testing priority-cases with the new upwp_pr4 term.
(details / githubweb)
Moving the acc update host directive to after the wait directives in silhs. Since silhs runs with asyncronous kernel calls the update was occasionally happening before some clipping was finished, causing problems in assert_correct_cloud_normal. This is only a problem when compiling with OpenACC enabled, so it should be bit identical for all our tests. larson-group/cam#129
(details / githubweb)
Reording vertical and subcolumn dimensions in SILHS. This is BIT_CHANING in some cases, seemly due to an outputting error for the precip_rate field, but plotted results are identical. larson-group/cam#129
(details / githubweb)
Changing dimension order of rand_pool to make consistent with previous reorderings. This is BIT_CHANGING for silhs cases since it changes the order in which random numbers are used. larson-group/cam#129
(details / githubweb)
Changes non-success `stop` statements to `error stop`
(details / githubweb)
Changes non-success `stop` statements to `error stop`
(details / githubweb)
Adding Shixuan's godunov_xpyp_ta updates here in case we want to merge them into our master branch. See #902.
(details / githubweb)
Changed the variable up2_vp2_factor to up2_sfc_coef in all files
(details / githubweb)
I added an option to improve dry, convecting boundary layers.
(details / githubweb)
This commit switches the names, but not the values, of the dp1 and pr1 variables for up2 and vp2. In other words, up2_dp1 <---> up2_pr1 and vp2_dp1 <---> vp2_pr1. This makes the terms in these equations more consistent with the terms in the wp2 equation. I believe this commit is BIT_CHANGING since it will affect the values of these variables even though the nightly plot profiles should not change (but the budget plots would have these lines swapped).
(details / githubweb)
Changed surface to sfc in all instances where requested
(details / githubweb)
Pushing grid column loop into setup_pdf_params. Adding iterface too, allowing us to call it with single or multiple columns so that the host models don't need updating to work with this change. This is bit-for-bit, tested with clubb_standalone and cam coarse res run. larson-group/cam#129
(details / githubweb)
Broke up column loop inside setup_pdf_params. This is all bit-for-bit. larson-group/cam#129
(details / githubweb)
More loop pushing, all bit-for-bit. larson-group/cam#129
(details / githubweb)
Adding one_half to use statement. This was a bug preventing compilation when using the ifort compiler with the MKL functions.
(details / githubweb)
Moving use statement for one_half inside ifdef, since it is only needed if compilation with MKL functions is enabled.
(details / githubweb)
Reducing the number of calls to Cholesky_factor. This is bit-for-bit for all standalone cases and our coarse res version of cam. larson-group/cam#129
(details / githubweb)
Reordering dimensions of mu, sigma, corr_arrays, and cholesky matrices. This makes the dimension ordering more consistent with similar arrays and should help to reduce computational cost by reducing array slicing. This is all bit-for-bit. larson-group/cam#129
(details / githubweb)
Reordering dimensions of mu, sigma, corr_arrays, and cholesky matrices. This makes the dimension ordering more consistent with similar arrays and should help to reduce computational cost by reducing array slicing. This is all bit-for-bit. larson-group/cam#129
(details / githubweb)
Performance improvements from chaning loop orderings and redundant operation reduction. All bit-for-bit. larson-group/cam#129
(details / githubweb)
Reordering dimensions on some arrays. This is bit-for-bit. larson-group/cam#129
(details / githubweb)
Reducing operations. All bit-for-bit. larson-group/cam#129
(details / githubweb)
Adding 2D subroutine versions of some functions to improve performance. This is all bit-for-bit. larson-group/cam#129
(details / githubweb)
Some small cleanup, all just formatting. larson-group/cam#129
(details / githubweb)
Changed ustar from an array to a scalar issue #909
(details / githubweb)
Renamed Ri_zm to sqrt_Ri_zm and iRi_zm to isqrt_Ri_zm #909
(details / githubweb)
Created new subroutine and ensured it's BFB. All cases run sucessfully #909
(details / githubweb)
added in missing flag which was causing memory errors #909
(details / githubweb)
confirmed BFB with e3sam flag set to false and true, no other issues detected in mixing_length #909
(details / githubweb)
Adding dummy dimensions to calls to procedures that operate over 2 dimensions now, and remove 1D versions of those procedures. larson-group/cam#129
(details / githubweb)
Separating precip fractions from hyrdromet_pdf_params and creating a type of it's own for it. This is bit-for-bit. larson-group/cam#129
(details / githubweb)
Separating precip fractions from hyrdromet_pdf_params and creating a type of it's own for it. This is bit-for-bit. larson-group/cam#129
(details / githubweb)
Formatting and condensing if statements. All bit-for-bit. larson-group/cam#129
(details / githubweb)
Making hydromet_pdf_params optional in setup_pdf_parameters. larson-group/cam#129
(details / githubweb)
Reformatted mixing length to be more compliant with the coding standard #909
(details / githubweb)
Adding second dimension to allocatable arrays in pdf_parameter type. This also requires lots of dummy dimensions in clubb where pdf_params is used, since clubb only works over a single column, but silhs does not need such a dummy dimension. larson-group/cam#129
(details / githubweb)
Adding second dimension to allocatable arrays in pdf_parameter type. This also requires lots of dummy dimensions in clubb where pdf_params is used, since clubb only works over a single column, but silhs does not need such a dummy dimension. larson-group/cam#129
(details / githubweb)
Pushing loops related to pdf_params down. larson-group/cam#129
(details / githubweb)
clubb warnings introduced from merge have been removed #909
(details / githubweb)
Changed safeguard threshold in sigma_sqd_w.
(details / githubweb)
Adding some new code that puts the diffusion term d(wp2*em)/dz into a new function, creates a new wp3 budget term (wp3_pr_dfsn), and adds that new budget term to pyplotgen.
(details / githubweb)
Adding new coefficient to control the wp3 pressure diffusion term.
(details / githubweb)
Some minor updates to advance_wp2_wp3 relevant to the pr_turb and pr_dfsn terms.
(details / githubweb)
Converting em*d(em)/dz to d(em^2)/dz in the wp3_pr_turb term and fixing a typo.
(details / githubweb)
Renaming C_wp3_turb --> C_wp3_pr_turb (BIT_CHANGING due to name change in netcdf output).
(details / githubweb)
These changes add the new fourth-order moment variables wp2up2 and wp2vp2 to the CLUBB code. This requires a new function in pdf_closure_module since they must be calculated separately with a new formula, and they are fed through into advance_wp2_wp3 for use with the pr_dfsn subroutine. They are also added to the standard stats file and will be output to netcdf, hence this commit is BIT_CHANGING.
(details / githubweb)
Putting the wp3_pr_turb formulation back to its d(rho*wp2*em)/dz form. This would be a BIT_CHANGING commit since it would change the answers for the pr_turb term. However once this branch is merged into the master branch, results should be bit-for-bit since this term was only modified in the alternate branch.
(details / githubweb)
Added intent comments for the following files:
(details / githubweb)
Removing "if" statement around calculation of wp4 in pdf_closure_module.F90 and the same "if" statement around some further manipulation of wp4 in advance_clubb_core. Results are bit-for-bit with this change, since normally all cases calculate wp4 anyway since the "if" condition was always satisfied in normal runs (but not, for example, in some tuning runs). This was done because the new wp3_pr_dfsn term needs wp4 in its current formulation so it needs to always be calculated.
(details / githubweb)
Removing some "use" statement variables from advance_clubb_core, since they are no longer used here but are now used in mixing_length.F90.
(details / githubweb)
Added intent comments for advance_xp2_xpyp_module.F90.
(details / githubweb)
Makes surface clipping of wp3 consistent with clipping aloft, per #921. This is BIT_CHANGING since it affects how clipping is applied near the surface.
(details / githubweb)
Deleting comments around the old "magic number" for the near-surface clipping.
(details / githubweb)
Fixing fortran standards violation causing compiler errors with nvfortran. See larson-group/clubb#900 and larson-group/clubb#928.
(details / githubweb)
Changed some elements of clubb to allow for better script execution
(details / githubweb)
Fixed file_functions indentation being off
(details / githubweb)
Fixed indentation on operations being wrong
(details / githubweb)
Reverted incorrect changes to new_pdf and new_hybrid_pdf
(details / githubweb)
Fixed spacing issue when adding in gr. BFB identical. For #886.
(details / githubweb)
Fixed spacing issue when adding in gr. BFB identical. For #886.
(details / githubweb)
Removing gr as a module variable from grid_class.
(details / githubweb)
Removing gr as a module variable from grid_class.
(details / githubweb)
Fixing typo in stats_zm_module.F90. Background: Since this commit https://github.com/larson-group/clubb/commit/466c5383fa5c0cc85316c6d117826974a5e2e0a3# in August 2020 the upwp budget lines in Pyplotgen have not appeared to be balanced for any cases. It turns out the reason is that a comma and space were added to the upwp_tp variable name in stats_zm_module.F90 in the August 2020 commit. This unusual naming causes pyplotgen not to recognize this variable, so it doesn't get plotted and the lines appear unbalanced. However, since the budget balance test still found the variable, it kept passing successfully. This commit will fix the issue with the pyplotgen plotting by reverting the name to the standard format.
(details / githubweb)
Feeding gr through arg list for functions outside of CLUBB_core.
(details / githubweb)
Feeding gr through arg list for functions outside of CLUBB_core.
(details / githubweb)
Moving 'gr' from front of arg list when being used as intent(inout) to conform to standard. #886. BFB.
(details / githubweb)
The purpose of this commit is to see whether or not causing changes in sam's version of clubb will cause errors when the master branch of clubb gets merged intosam. Please ignore this commit unless everything breaks, in which case this is the reason why everything is broken.
(details / githubweb)
Fixing argument list so that way the coding standard is upheld.
(details / githubweb)
I changed the name to calc_responder_driver because I thought that
(details / githubweb)
Code changes to introduce wp2_pr_dfsn, the wp2 pressure diffusion term, consistent with Lumley 1978. Related to #920.
(details / githubweb)
Fixing comment for the wp2_term_pr_dfsn subroutine. Related to #920.
(details / githubweb)
Updating wp3 pressure diffusion term to be consistent with the Lumley 1978 formula for the perturbation pressure. For #920.
(details / githubweb)
Making requested changes to the wp2 pressure diffuion additions, including correcting some grid-level related issues. Related to #920.
(details / githubweb)
Correcting a typo bug and adding some descriptive comments to two new variables. This is a BIT_CHANGING commit becuase it will affect the newly calculated variables and descriptions in the output files, but it won't affect any plotted results. Related to #920.
(details / githubweb)
Moving the stats variables to module variables of clubb_driver.
(details / githubweb)
Moving the stats variables to module variables of clubb_driver.
(details / githubweb)
Fixing coding standard viloation of lines exceeding 100 characters.
(details / githubweb)
Fixing coding standard viloation of lines exceeding 100 characters.
(details / githubweb)
Adding wp3_pr_tp (aka "negative nose" term) to wp3 equation. Related to #920.
(details / githubweb)
Changing the way the new wp3_pr_tp term works, by generalizing the wp3_terp_pr_lhs subroutine. Also cleaning up comments and changing the description of the wp3_pr_tp variable in the netcdf output files, hence this commit is BIT_CHANGING, although it will not affect numerical results since the wp3_pr_tp coefficient (C_wp3_pr_tp) is set to zero.
(details / githubweb)
Removing l_interp_prescribed_params from setup_clubb_pdf_params.
(details / githubweb)
Adding comments labeling subroutine calls with intent.
(details / githubweb)
Adding intent labels for subroutines throughout clubb.
(details / githubweb)
Removing unnecessary constant from use statement
(details / githubweb)
Eliminating l_nu_grid_dependent as requested.
(details / githubweb)
Updating the surface clipping coefficient...
(details / githubweb)
Adding in l_vary_convect_depth as requested.
(details / githubweb)
Removing a couple of unused parameters from use statement.
(details / githubweb)
Pushing k loop down through clip_variance_level.
(details / githubweb)
Udpates to make it possible for us to keep certain parameters equal to each other during tuning.
(details / githubweb)
Further tuner updates. These updates introduce the option to give a minimum value for tuned parameters. Error checks are included.
(details / githubweb)
Updating some comments related to the tuner updates.
(details / githubweb)
I have passed clubb_params down into advance_xm_wpxp_module.F90.
(details / githubweb)
Adding space to trigger autoupdate. larson-group/sys_admin#755
(details / githubweb)
Remove space to trigger autoupdate. larson-group/sys_admin#755
(details / githubweb)
Add space to trigger nightly tests. For larson-group/sys_admin#755.
(details / githubweb)
I am fixing a bug that was introduced in 6b0348e, where the logical
(details / githubweb)
I have passed down CLUBB's tunable parameters into advance_wp2_wp3_module.F90.
(details / githubweb)
added some documentation in pdf_close_module.f90 and started writing of w_up_in_cloud to disk
(details / githubweb)
Updates to separate out C4 and C14 in advance_xp2 module. This will make it easier to control which invrs_tau_* variable multiplies each term for example.
(details / githubweb)
Changing the name of dummy_1d variables for clarity.
(details / githubweb)
I passed down CLUBB's tunable parameters into advance_xp2_xpyp_module.F90
(details / githubweb)
Add a blank line to trigger nightly tests.
(details / githubweb)
Passing down more of CLUBB's tunable parameters.
(details / githubweb)
I accidentally removed an important comment in the previous commit.
(details / githubweb)
Passing down more CLUBB tunable parameters.
(details / githubweb)
More passing down CLUBB parameters ... whoop-de-doo
(details / githubweb)
Passing down more tunable parameters and removing references to
(details / githubweb)
Removing line to trigger the nightly tests for all repos.
(details / githubweb)
See respective messages on the issue 958 on date 10/12/2021
(details / githubweb)
Commented out the k=1 boundary conditions in diffusion_zm_lhs and diffusion_zt_lhs, since these are not currently fed into the final LHS matrix. I included comments to describe why this was done. Results are b4b.
(details / githubweb)
Passing tunable parameters into the new tau code.
(details / githubweb)
Passed down more parameters. Results are bit-for-bit.
(details / githubweb)
Passing through more clubb parameters. Bit-for-bit
(details / githubweb)
Passing down CLUBB's tunable parameters into the setup_pdf_parameters and
(details / githubweb)
These updates incorporate some of Shixuan Zhang's changes, including:
(details / githubweb)
Passing down CLUBB's tunable parameters into the remainder of the
(details / githubweb)
I passed down the forgotten thlp2_rad_coef tunable parameter.
(details / githubweb)
Uncommenting diffusion.F90 k=1 lines again to fix Oracle uninit var test. I've updated the accompanying note to state clearly that the lines have no effect on model output, but I guess we need to keep the lines to avoid uninitialized variables.
(details / githubweb)
I am passing down the forgotten parameter, altitude threshold, in
(details / githubweb)
Adding code wrapped in a flag (l_use_tke_in_K_dfsn) to use u_i'u_i' in the wp2 and wp3 eddy diffusion terms, instead of just wp2 or wp3. Relevant to CLUBB issue #920.
(details / githubweb)
Updates as requested to the l_use_tke_in_K_dfsn code:
(details / githubweb)
I am committing the final stage of the "pass-down params" project.
(details / githubweb)
I am committing the final stage of the "pass-down params" project.
(details / githubweb)
Adding an option to use invrs_tau_N2_iso for C4 terms. The same invrs_tau had been used for C4 and C14 terms, so some adjustments had to be made to separate them out (this was started with an earlier commit: https://github.com/larson-group/clubb/commit/ef3be1b1378bcd1a447f3866c9f88f8cc4764233). The flag is currently set to false so results will be b4b.
(details / githubweb)
Renaming invrs_tau_zt and invrs_tauw3t to "invrs_tau_wp3_zt" in advance_wp2_wp3 to avoid confusion. This variable is only used for the wp3 C8 term, so one consistent name is simpler, and the name "invrs_tau_zt" is already used by another variable in advance_clubb_core.
(details / githubweb)
I forgot to add this necessary subroutine call to the clubb API.
(details / githubweb)
Fixing a minor accounting bug related to the changes in https://github.com/larson-group/clubb/commit/987d63de489d2baa09ad6e1538b2c6dbb7551690. There was some overcounting of the relevant terms.
(details / githubweb)
I have turned the nu_vert_res_dep family of variables into a derived
(details / githubweb)
Added sam file name to DYCOMS_RF02_DO case, fixed the clipping in calc_w_up_in_cloud in pdf_closure_module.f90, and changed long name of w_up_in_cloud in stats_zt_module.f90
(details / githubweb)
Resolved any issues in the pull request. See https://github.com/larson-group/clubb/pull/970 for details
(details / githubweb)
Included a check in pdf_closure_module.f90 to check if flag for iw_up_in_cloud is set. Removed iw_up_in_cloud from standard_stats.in to prevent binary diffs in CLUBB output files after merge
(details / githubweb)
fixed a typo in pdf_closure_module.f90, line 1284
(details / githubweb)
added some documentation in pdf_close_module.f90 and started writing of w_up_in_cloud to disk
(details / githubweb)
See respective messages on the issue 958 on date 10/12/2021
(details / githubweb)
Added sam file name to DYCOMS_RF02_DO case, fixed the clipping in calc_w_up_in_cloud in pdf_closure_module.f90, and changed long name of w_up_in_cloud in stats_zt_module.f90
(details / githubweb)
Resolved any issues in the pull request. See https://github.com/larson-group/clubb/pull/970 for details
(details / githubweb)
Included a check in pdf_closure_module.f90 to check if flag for iw_up_in_cloud is set. Removed iw_up_in_cloud from standard_stats.in to prevent binary diffs in CLUBB output files after merge
(details / githubweb)
fixed a typo in pdf_closure_module.f90, line 1284
(details / githubweb)
Passing w_up_in_cloud out of advance_clubb_core
(details / githubweb)
This should be BIT_CHANGING, but only because the value of Cx_min should change in the netcdf file. This will not be answer changing.
(details / githubweb)
Changing the value of C_invrs_tau_shear from 0.02 to 0.15.
(details / githubweb)
Avoiding stats call for variables that are not set when l_diag_Lscale_from_tau is not true.
(details / githubweb)
Adjusting the value of C_invrs_tau_shear from 0.15 to 0.16 so that
(details / githubweb)
Add l_smooth_Heaviside_tau_wpxp to smooth discontinuity in invrs_tau_wpxp_zm
(details / githubweb)
Pushing column loop into advance_clubb_core, and adding interface for it so that we will not need to update any host models. Everything is bit-for-bit, testing all standalone cases and our cam_coarse res run. larson-group/clubb#972
(details / githubweb)
Adding l_stats check around stats stuff. This fixes the crashing when stats is disabled. larson-group/clubb#972
(details / githubweb)
Making single and multi column versions of advance clubb core available through clubb_api. larson-group/clubb#972
(details / githubweb)
Breaking up column loop in advance_clubb_core. larson-group/clubb#972
(details / githubweb)
Pushing loop into pdf_closure and breaking it up. larson-group/clubb#972
(details / githubweb)
I changed C_invrs_tau_N2_wp2 from 0.1 to 0.2 to help stop turbulence
(details / githubweb)
Pushing loop into pdf_closure_module and breaking it up. larson-group/clubb#972
(details / githubweb)
Making the good version of pdf_params used most places. The bad version is the single column version. larson-group/clubb#972
(details / githubweb)
Making a commit that officially places the call to the PDF in the "post"
(details / githubweb)
Pushing loops into all relevent lowest level routines in pdf_closure. larson-group/clubb#972
(details / githubweb)
We need to initialize our local pdf_implicit_coefs_terms_zm in certain pdf types. We also don't need to zero out pdf_implicit_coefs_terms arrays, since that's done in the initialization. This should fix segfaults when l_call_pdf_closure_twice=.True. larson-group/clubb#972
(details / githubweb)
I am updating ice_supersat_frac to be an intent(inout) variable for
(details / githubweb)
Intializing sigma_sqd_w_zt when not using ADG1. larson-group/clubb#972
(details / githubweb)
Fixing bug, we were not initializng pdf_params for all columns. larson-group/clubb#972
(details / githubweb)
Pushing column index into zm2zt and zt2zm. larson-group/clubb#972
(details / githubweb)
Pushing column index into Skx_func and making it a subroutine. larson-group/clubb#972
(details / githubweb)
A variety of small loop pushing. larson-group/clubb#972
(details / githubweb)
Fixed small bug that slipped through because the G_unit tests use nz=1.
(details / githubweb)
Pushing column index into mixing length routines, not all the way down for the non-tau based calculation. larson-group/clubb#972
(details / githubweb)
I added a subroutine that prints that values of all PDF parameters in
(details / githubweb)
Small changes and a loop push. larson-group/clubb#972
(details / githubweb)
Pushing loop into advance_xm_wpxp. larson-group/clubb#972
(details / githubweb)
Making the G_unit test use a dummy column index. This makes it so we don't need an interface for compute_sigma_sqd_w since now we only use it with 2 dimensions. This is just nicer. larson-group/clubb#972
(details / githubweb)
Breaking up column loop in advance_xm_wpxp_module. larson-group/clubb#972
(details / githubweb)
Pushing column loop into local functions. larson-group/clubb#972
(details / githubweb)
Moving stats call for uprcp and vprcp to after they are calculated. This fixes the silhs restart test. But does not seem to fix the E3SM or CAM tests that are still failing.
(details / githubweb)
Adding 2D version of zt2zm and zm2zt to clubb_api
(details / githubweb)
Pushing loop into solve_xm_wpxp_with_single_lhs (#986)
(details / githubweb)
Refactoring to remove need for global stats scratch variables. (#988)
(details / githubweb)
Fixing small bug that breaks runs with scalars.
(details / githubweb)
Implementations of smooth min, max and heaviside function. Added G-Unit tests
(details / githubweb)
Making setup_pdf_parameters accept ngrdcols size arrays of stats and grid types.
(details / githubweb)
Forgot two small changes. larson-group/cam#129
(details / githubweb)
Removing need for data copies. larson-group/cam#129
(details / githubweb)
Changing column loop index from j to i. larson-group/cam#129
(details / githubweb)
Removing data copies that we don't need anymore. This still runs correctly on GPUs.
(details / githubweb)
Making clip_transform_silhs_output use an array of gr. This is how it should have been once the column loop was pushed down into it, but at the time clubb was using gr through a use statement making that not possible.
(details / githubweb)
No more need for these data copies anymore now that pdf_params is allocated with ngrdcol rather than pcols.
(details / githubweb)
Adds a blank line to trigger git merge with E3SM
(details / githubweb)
![[Jenkins]](/jenkins/static/57c8a776/images/svgs/logo.svg){kind=logo}
