Started by an SCM change389f1e1ad0e80be0a00148ceb1373cd3dd82e9469a9f1e1ad0e80be0a00148ceb1373cd3dd82e9469arefs/remotes/origin/master9f1e1ad0e80be0a00148ceb1373cd3dd82e9469a9f1e1ad0e80be0a00148ceb1373cd3dd82e9469arefs/remotes/origin/master9f1e1ad0e80be0a00148ceb1373cd3dd82e9469a9f1e1ad0e80be0a00148ceb1373cd3dd82e9469arefs/remotes/origin/masterhttps://github.com/larson-group/clubb.githttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_timestep_gfortran_tests/detail/clubb_timestep_gfortran_tests/38/artifactshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_timestep_gfortran_tests/detail/clubb_timestep_gfortran_tests/38/changeshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_timestep_gfortran_tests/detail/clubb_timestep_gfortran_tests/38/http://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_timestep_gfortran_tests/detail/clubb_timestep_gfortran_tests/38/testsfalsefalse#38649973596301clubb_timestep_gfortran_tests #3838false389898FAILURE1635322387102http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/38/src/CLUBB_core/diffusion.F909f1e1ad0e80be0a00148ceb1373cd3dd82e9469a1635271688000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comUncommenting diffusion.F90 k=1 lines again to fix Oracle uninit var test. I've updated the accompanying note to state clearly that the lines have no effect on model output, but I guess we need to keep the lines to avoid uninitialized variables. 2021-10-26 13:08:08 -05009f1e1ad0e80be0a00148ceb1373cd3dd82e9469aUncommenting diffusion.F90 k=1 lines again to fix Oracle uninit var test. I've updated the accompanying note to state clearly that the lines have no effect on model output, but I guess we need to keep the lines to avoid uninitialized variables.editsrc/CLUBB_core/diffusion.F90githttp://carson.math.uwm.edu/jenkins/user/72510114+rhodeskeegan72510114+RhodesKeegan72510114+rhodeskeeganhttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodeskhttp://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephenshttp://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarsonhttp://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhueblerhttp://carson.math.uwm.edu/jenkins/user/pbroelspbroelspbroelsfalseStarted by an SCM change3979bc651171add5b6a340be02cf6f775ddc779aaa79bc651171add5b6a340be02cf6f775ddc779aaarefs/remotes/origin/master79bc651171add5b6a340be02cf6f775ddc779aaa79bc651171add5b6a340be02cf6f775ddc779aaarefs/remotes/origin/master79bc651171add5b6a340be02cf6f775ddc779aaa79bc651171add5b6a340be02cf6f775ddc779aaarefs/remotes/origin/masterhttps://github.com/larson-group/clubb.gitfalse#39703074596301clubb_timestep_gfortran_tests #3939false399968FAILURE1635408788724http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/39/src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_wp2_wp3_module.F90src/G_unit_test_types/spurious_source_test.F90src/CLUBB_core/model_flags.F90src/clubb_driver.F90src/CLUBB_core/clubb_api_module.F90input/tunable_parameters_Lscale/configurable_model_flags.ininput/tunable_parameters_e3sm/configurable_model_flags.insrc/G_unit_test_types/pdf_parameter_tests.F90input/tunable_parameters/configurable_model_flags.insrc/clubb_tuner.F90987d63de489d2baa09ad6e1538b2c6dbb75516901635369371000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comAdding code wrapped in a flag (l_use_tke_in_K_dfsn) to use u_i'u_i' in the wp2 and wp3 eddy diffusion terms, instead of just wp2 or wp3. Relevant to CLUBB issue #920. Results are b4b when the flag is turned off, which it currently is. 2021-10-27 16:16:11 -0500987d63de489d2baa09ad6e1538b2c6dbb7551690Adding code wrapped in a flag (l_use_tke_in_K_dfsn) to use u_i'u_i' in the wp2 and wp3 eddy diffusion terms, instead of just wp2 or wp3. Relevant to CLUBB issue #920.editinput/tunable_parameters_e3sm/configurable_model_flags.ineditinput/tunable_parameters/configurable_model_flags.ineditsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/clubb_api_module.F90editsrc/G_unit_test_types/pdf_parameter_tests.F90editsrc/CLUBB_core/advance_wp2_wp3_module.F90editsrc/G_unit_test_types/spurious_source_test.F90editsrc/clubb_tuner.F90editinput/tunable_parameters_Lscale/configurable_model_flags.ineditsrc/CLUBB_core/model_flags.F90editsrc/clubb_driver.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_wp2_wp3_module.F90src/CLUBB_core/model_flags.F90src/clubb_driver.F90src/G_unit_test_types/spurious_source_test.F90src/CLUBB_core/clubb_api_module.F90input/tunable_parameters_Lscale/configurable_model_flags.ininput/tunable_parameters_e3sm/configurable_model_flags.insrc/G_unit_test_types/pdf_parameter_tests.F90input/tunable_parameters_compatible_r8029/configurable_model_flags.ininput/tunable_parameters/configurable_model_flags.insrc/clubb_tuner.F9079bc651171add5b6a340be02cf6f775ddc779aaa1635369371000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comUpdates as requested to the l_use_tke_in_K_dfsn code: - The name of the flag is changed to l_use_tke_in_wp2_wp3_K_dfsn - Comments are added to the main pieces of code in advance_wp2_wp3 - The flag is added to the "compatible_r8029" configurable flags file. See this comment https://github.com/larson-group/clubb/issues/920#issuecomment-931446401 and following for more information. 2021-10-27 16:16:11 -050079bc651171add5b6a340be02cf6f775ddc779aaaUpdates as requested to the l_use_tke_in_K_dfsn code:editsrc/CLUBB_core/advance_wp2_wp3_module.F90editinput/tunable_parameters/configurable_model_flags.ineditsrc/G_unit_test_types/pdf_parameter_tests.F90editinput/tunable_parameters_compatible_r8029/configurable_model_flags.ineditsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/model_flags.F90editsrc/clubb_tuner.F90editsrc/clubb_driver.F90editsrc/G_unit_test_types/spurious_source_test.F90editinput/tunable_parameters_Lscale/configurable_model_flags.ineditsrc/CLUBB_core/clubb_api_module.F90editinput/tunable_parameters_e3sm/configurable_model_flags.ingithttp://carson.math.uwm.edu/jenkins/user/72510114+rhodeskeegan72510114+RhodesKeeganhttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskhttp://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephenshttp://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonhttp://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens82http://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhttp://carson.math.uwm.edu/jenkins/user/pbroelspbroelsfalse40http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/40/38http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/38/Started by an SCM change3795d7773f81117daff784b8ab91f4211c2edc839095d7773f81117daff784b8ab91f4211c2edc8390refs/remotes/origin/master95d7773f81117daff784b8ab91f4211c2edc839095d7773f81117daff784b8ab91f4211c2edc8390refs/remotes/origin/master95d7773f81117daff784b8ab91f4211c2edc839095d7773f81117daff784b8ab91f4211c2edc8390refs/remotes/origin/masterhttps://github.com/larson-group/clubb.gitfalse#37485335596301clubb_timestep_gfortran_tests #3737false379828FAILURE1634976791239http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/37/src/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/advance_windm_edsclrm_module.F90src/CLUBB_core/advance_wp2_wp3_module.F90src/CLUBB_core/model_flags.F90src/advance_microphys_module.F90src/CLUBB_core/diffusion.F90src/CLUBB_core/mixing_length.F90src/CLUBB_core/advance_xp2_xpyp_module.F9095d7773f81117daff784b8ab91f4211c2edc83901634935501000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comThese updates incorporate some of Shixuan Zhang's changes, including: (1) upwind scheme for the eddy diffusion code, which Shixuan says does not make a huge difference; and (2) l_smooth_heaviside_tau_wpxp flag in the mixing_length.F90 code, which is intended to give smoother results. Both of the flags for these changes are turned off, but these updates are BIT_CHANGING because of some minor changes to the way that factors of rho_ds_* and invrs_rho_ds_* are handled going into the diffusion.F90 subroutines. Most cases look identical in pyplotgen, but sensitive cases like arm_97 and rico look slightly different. These changes were originally in pull request #962, but because of conflicts with the master branch code base that developed, they could not be rebased and merged, so I incorporated them into this new commit. 2021-10-22 15:45:01 -050095d7773f81117daff784b8ab91f4211c2edc8390These updates incorporate some of Shixuan Zhang's changes, including:editsrc/CLUBB_core/advance_wp2_wp3_module.F90editsrc/CLUBB_core/advance_xm_wpxp_module.F90editsrc/CLUBB_core/advance_xp2_xpyp_module.F90editsrc/CLUBB_core/diffusion.F90editsrc/CLUBB_core/advance_windm_edsclrm_module.F90editsrc/CLUBB_core/mixing_length.F90editsrc/CLUBB_core/model_flags.F90editsrc/advance_microphys_module.F90githttp://carson.math.uwm.edu/jenkins/user/72510114+rhodeskeegan72510114+RhodesKeeganhttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskhttp://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephenshttp://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonhttp://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens82http://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhttp://carson.math.uwm.edu/jenkins/user/pbroelspbroelsfalse38http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/38/36http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/36/