Started by an SCM change363b66569c42c4c6ba4c301c1ab41cfc5cbc9554fcfb66569c42c4c6ba4c301c1ab41cfc5cbc9554fcfrefs/remotes/origin/masterb66569c42c4c6ba4c301c1ab41cfc5cbc9554fcfb66569c42c4c6ba4c301c1ab41cfc5cbc9554fcfrefs/remotes/origin/masterb66569c42c4c6ba4c301c1ab41cfc5cbc9554fcfb66569c42c4c6ba4c301c1ab41cfc5cbc9554fcfrefs/remotes/origin/masterhttps://github.com/larson-group/clubb.githttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_timestep_gfortran_tests/detail/clubb_timestep_gfortran_tests/363/artifactshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_timestep_gfortran_tests/detail/clubb_timestep_gfortran_tests/363/changeshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_timestep_gfortran_tests/detail/clubb_timestep_gfortran_tests/363/http://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_timestep_gfortran_tests/detail/clubb_timestep_gfortran_tests/363/testsfalsefalse#363828809596301clubb_timestep_gfortran_tests #363363false3631180SUCCESS1722845589544http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/363/src/input_fields.F9047c5a7c9fede199a6ce4400f50474c7a9e49aaad1722792456000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduUpdating input fields so that the zt2zm function is used for interpolation from thermodynamic to momentum grids in the case of reading in UP2 and Vp2 from SAM LES output. 2024-08-04 12:27:36 -050047c5a7c9fede199a6ce4400f50474c7a9e49aaadUpdating input fields so that the zt2zm function is used foreditsrc/input_fields.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2falseStarted by an SCM change36446fe460263003ad92fd5f942a2c99d006bcbf0fa46fe460263003ad92fd5f942a2c99d006bcbf0farefs/remotes/origin/master46fe460263003ad92fd5f942a2c99d006bcbf0fa46fe460263003ad92fd5f942a2c99d006bcbf0farefs/remotes/origin/master46fe460263003ad92fd5f942a2c99d006bcbf0fa46fe460263003ad92fd5f942a2c99d006bcbf0farefs/remotes/origin/masterhttps://github.com/larson-group/clubb.gitfalse#364859117596301clubb_timestep_gfortran_tests #364364false3641248SUCCESS1723191189453http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/364/src/CLUBB_core/advance_xm_wpxp_module.F90input/tunable_parameters/tunable_parameters.insrc/CLUBB_core/advance_wp2_wp3_module.F90a5e586ca398dcd4733c05082addacaa66e24b2f61723145344000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdded zt2zm2zt-smoothing to remove noise in MPACE_B winds (#1161) BIT_CHANGING In order to remove noise in the wind fields in MPACE_B, we added some smoothing. * Added `zt2zm2zt`-smoothing to `diagnose_upxp` calls in `advance_xm_wpxp` * Added `zm2zt2zm`-smoothing to `wp2` and `em` vars fed into `wp3_term_pr_turb_rhs` in `advance_wp2_wp3` * Changed C_wp2_splat to 0.00 in default tunable_parameters.in 2024-08-08 14:29:04 -0500a5e586ca398dcd4733c05082addacaa66e24b2f6Added zt2zm2zt-smoothing to remove noise in MPACE_B winds (#1161)editinput/tunable_parameters/tunable_parameters.ineditsrc/CLUBB_core/advance_xm_wpxp_module.F90editsrc/CLUBB_core/advance_wp2_wp3_module.F90src/stat_file_utils.F90src/jacobian.F90src/CLUBB_core/parameters_model.F90src/clubb_model_settings.F901f96b03b404757544a6954e41ebea65a4771d3331723145363000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMoving PosInf to clubb_model_settings.F90 2024-08-08 14:29:23 -05001f96b03b404757544a6954e41ebea65a4771d333Moving PosInf to clubb_model_settings.F90editsrc/jacobian.F90editsrc/stat_file_utils.F90editsrc/CLUBB_core/parameters_model.F90editsrc/clubb_model_settings.F90compile/convert_acc_to_omp.bash46fe460263003ad92fd5f942a2c99d006bcbf0fa1723155345000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduChanging openacc to openmp migration repo to a fork with a change to switch the order of copyins and copies. This is to allow us to only copyin the pdf_params structure, but copy the internal arrays. When the copying of the internal arrays happens first, followed by the copyin of the structure, we overwrite the pointers to the internal arrays on the GPU version of the structure. Hence why we want the copyins to precede the copy statements. 2024-08-08 17:15:45 -050046fe460263003ad92fd5f942a2c99d006bcbf0faChanging openacc to openmp migration repo to a fork with a change to switch the order of copyins and copies. This is to allow us to only copyin the pdf_params structure, but copy the internal arrays. When the copying of the internal arrays happens first, followed by the copyin of the structure, we overwrite the pointers to the internal arrays on the GPU version of the structure. Hence why we want the copyins to precede the copy statements.editcompile/convert_acc_to_omp.bashgithttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse365http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/365/363http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/363/Started by an SCM change3623f865924bdcf798fa45acaa67b57c44f40c32d893f865924bdcf798fa45acaa67b57c44f40c32d89refs/remotes/origin/master3f865924bdcf798fa45acaa67b57c44f40c32d893f865924bdcf798fa45acaa67b57c44f40c32d89refs/remotes/origin/master3f865924bdcf798fa45acaa67b57c44f40c32d893f865924bdcf798fa45acaa67b57c44f40c32d89refs/remotes/origin/masterhttps://github.com/larson-group/clubb.gitfalse#362850054596301clubb_timestep_gfortran_tests #362362false3621110SUCCESS1722499989332http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/362/src/CLUBB_core/mono_flux_limiter.F907e50946517204cc06f78f8d12c3bca5b283d83f01722452248000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing GPU bug. There is a vertical dependency with wpxp. This is what was breaking the ECT test, see larson-group/cam#175 2024-07-31 13:57:28 -05007e50946517204cc06f78f8d12c3bca5b283d83f0Fixing GPU bug. There is a vertical dependency with wpxp. This is what was breaking the ECT test, see larson-group/cam#175editsrc/CLUBB_core/mono_flux_limiter.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/pdf_closure_module.F90e7c07d8527cafa4ab3ee16b1b90ce1abe24941f31722455629000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing bugs that are only caught when not outputting w_[up/down]_in_cloud stats or if l_host_applies_sfc_fluxes=.true. The l_host_applies_sfc_fluxes=.true. isn't testable (at least not in clubb_standalone), and I just caught that visually. The cloudy_updraft_frac and cloudy_downdraft_frac fields not being set were only noticable in cam, because we always run with iw_up_in_cloud>0 and iw_down_in_cloud>0 to output stats. 2024-07-31 14:53:49 -0500e7c07d8527cafa4ab3ee16b1b90ce1abe24941f3Fixing bugs that are only caught when not outputting w_[up/down]_in_cloud stats or if l_host_applies_sfc_fluxes=.true. The l_host_applies_sfc_fluxes=.true. isn't testable (at least not in clubb_standalone), and I just caught that visually. The cloudy_updraft_frac and cloudy_downdraft_frac fields not being set were only noticable in cam, because we always run with iw_up_in_cloud>0 and iw_down_in_cloud>0 to output stats.editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/pdf_closure_module.F90src/CLUBB_core/clubb_api_module.F903f865924bdcf798fa45acaa67b57c44f40c32d891722465051000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMoving pdf_params copying to copyin. This is the data structure that contains pointers, and these pointers will be different on the host and device, so it is bad in theory to copy the structure back to the CPU as it might overwrite cpu memory pointers with gpu memory pointers. In practice though I've seen no problems caused by this, I'm just making this commit preemptively, and it has already been tested with the ECT test. 2024-07-31 17:30:51 -05003f865924bdcf798fa45acaa67b57c44f40c32d89Moving pdf_params copying to copyin. This is the data structure that contains pointers, and these pointers will be different on the host and device, so it is bad in theory to copy the structure back to the CPU as it might overwrite cpu memory pointers with gpu memory pointers. In practice though I've seen no problems caused by this, I'm just making this commit preemptively, and it has already been tested with the ECT test.editsrc/CLUBB_core/clubb_api_module.F90githttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse363http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/363/361http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/361/