Started by an SCM change36188e63b7dc56295efbebde1b090107c748daef54188e63b7dc56295efbebde1b090107c748daef541refs/remotes/origin/master88e63b7dc56295efbebde1b090107c748daef54188e63b7dc56295efbebde1b090107c748daef541refs/remotes/origin/master88e63b7dc56295efbebde1b090107c748daef54188e63b7dc56295efbebde1b090107c748daef541refs/remotes/origin/masterhttps://github.com/larson-group/clubb.githttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_timestep_gfortran_tests/detail/clubb_timestep_gfortran_tests/361/artifactshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_timestep_gfortran_tests/detail/clubb_timestep_gfortran_tests/361/changeshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_timestep_gfortran_tests/detail/clubb_timestep_gfortran_tests/361/http://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_timestep_gfortran_tests/detail/clubb_timestep_gfortran_tests/361/testsfalsefalse#361848119596301clubb_timestep_gfortran_tests #361361false3611046SUCCESS1721722389802http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/361/src/clubb_driver.F9088e63b7dc56295efbebde1b090107c748daef5411721689147000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduWhen l_vert_avg_closure is enabled, the flags l_call_pdf_closure_twice, l_trapezoidal_rule_zt, and l_trapezoidal_rule_zm should all be enabled. That is not changed by this commit. However, when l_vert_avg_closure is disabled, then the setting of those other 3 flags should be left to whatever setting they have in the configurable flags file. They should **not** be automatically overwritten to false. Since all 4 of those flags are all turned off by default anyway in CLUBB, this commit will have no effect on the default results. 2024-07-22 17:59:07 -050088e63b7dc56295efbebde1b090107c748daef541When l_vert_avg_closure is enabled, the flags l_call_pdf_closure_twice,editsrc/clubb_driver.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2falseStarted by an SCM change3623f865924bdcf798fa45acaa67b57c44f40c32d893f865924bdcf798fa45acaa67b57c44f40c32d89refs/remotes/origin/master3f865924bdcf798fa45acaa67b57c44f40c32d893f865924bdcf798fa45acaa67b57c44f40c32d89refs/remotes/origin/master3f865924bdcf798fa45acaa67b57c44f40c32d893f865924bdcf798fa45acaa67b57c44f40c32d89refs/remotes/origin/masterhttps://github.com/larson-group/clubb.gitfalse#362850054596301clubb_timestep_gfortran_tests #362362false3621110SUCCESS1722499989332http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/362/src/CLUBB_core/mono_flux_limiter.F907e50946517204cc06f78f8d12c3bca5b283d83f01722452248000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing GPU bug. There is a vertical dependency with wpxp. This is what was breaking the ECT test, see larson-group/cam#175 2024-07-31 13:57:28 -05007e50946517204cc06f78f8d12c3bca5b283d83f0Fixing GPU bug. There is a vertical dependency with wpxp. This is what was breaking the ECT test, see larson-group/cam#175editsrc/CLUBB_core/mono_flux_limiter.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/pdf_closure_module.F90e7c07d8527cafa4ab3ee16b1b90ce1abe24941f31722455629000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing bugs that are only caught when not outputting w_[up/down]_in_cloud stats or if l_host_applies_sfc_fluxes=.true. The l_host_applies_sfc_fluxes=.true. isn't testable (at least not in clubb_standalone), and I just caught that visually. The cloudy_updraft_frac and cloudy_downdraft_frac fields not being set were only noticable in cam, because we always run with iw_up_in_cloud>0 and iw_down_in_cloud>0 to output stats. 2024-07-31 14:53:49 -0500e7c07d8527cafa4ab3ee16b1b90ce1abe24941f3Fixing bugs that are only caught when not outputting w_[up/down]_in_cloud stats or if l_host_applies_sfc_fluxes=.true. The l_host_applies_sfc_fluxes=.true. isn't testable (at least not in clubb_standalone), and I just caught that visually. The cloudy_updraft_frac and cloudy_downdraft_frac fields not being set were only noticable in cam, because we always run with iw_up_in_cloud>0 and iw_down_in_cloud>0 to output stats.editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/pdf_closure_module.F90src/CLUBB_core/clubb_api_module.F903f865924bdcf798fa45acaa67b57c44f40c32d891722465051000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMoving pdf_params copying to copyin. This is the data structure that contains pointers, and these pointers will be different on the host and device, so it is bad in theory to copy the structure back to the CPU as it might overwrite cpu memory pointers with gpu memory pointers. In practice though I've seen no problems caused by this, I'm just making this commit preemptively, and it has already been tested with the ECT test. 2024-07-31 17:30:51 -05003f865924bdcf798fa45acaa67b57c44f40c32d89Moving pdf_params copying to copyin. This is the data structure that contains pointers, and these pointers will be different on the host and device, so it is bad in theory to copy the structure back to the CPU as it might overwrite cpu memory pointers with gpu memory pointers. In practice though I've seen no problems caused by this, I'm just making this commit preemptively, and it has already been tested with the ECT test.editsrc/CLUBB_core/clubb_api_module.F90githttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse363http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/363/361http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/361/Started by an SCM change360a67d637da217289ec8a0ddd2ea464d782b9ca79ca67d637da217289ec8a0ddd2ea464d782b9ca79crefs/remotes/origin/mastera67d637da217289ec8a0ddd2ea464d782b9ca79ca67d637da217289ec8a0ddd2ea464d782b9ca79crefs/remotes/origin/mastera67d637da217289ec8a0ddd2ea464d782b9ca79ca67d637da217289ec8a0ddd2ea464d782b9ca79crefs/remotes/origin/masterhttps://github.com/larson-group/clubb.gitfalse#360848341596301clubb_timestep_gfortran_tests #360360false360976SUCCESS1721463188232http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/360/src/CLUBB_core/advance_xp2_xpyp_module.F908f1115676aa257869d00331d0355159754208e1e1721419124000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduMaking a change to the l_C2_cloud_frac option with advance_xp2_xpyp. Cloud fraction needed to be interpolated to momentum levels for proper use in the code. Since this code change does not change CLUBB's default configuration, results are bit-for-bit for the default configuration. 2024-07-19 14:58:44 -05008f1115676aa257869d00331d0355159754208e1eMaking a change to the l_C2_cloud_frac option with advance_xp2_xpyp.editsrc/CLUBB_core/advance_xp2_xpyp_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/clubb_api_module.F90a67d637da217289ec8a0ddd2ea464d782b9ca79c1721424813000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing bug. qclvar copying is handled by the api, but we were deleting it with an unstructured data statement. I added this due as a fix before thinking qclvar was a local variable, which happened because I mixed up the CLUBB_CAM and CLUBBND_CAM flags. https://github.com/larson-group/cam/issues/175 2024-07-19 15:33:33 -0600a67d637da217289ec8a0ddd2ea464d782b9ca79cFixing bug. qclvar copying is handled by the api, but we were deleting it with an unstructured data statement. I added this due as a fix before thinking qclvar was a local variable, which happened because I mixed up the CLUBB_CAM and CLUBBND_CAM flags. https://github.com/larson-group/cam/issues/175editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/clubb_api_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse361http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/361/359http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/359/