Started by an SCM change3277b429b2f394be33db0348d15755e28d832264e077b429b2f394be33db0348d15755e28d832264e07refs/remotes/origin/master7b429b2f394be33db0348d15755e28d832264e077b429b2f394be33db0348d15755e28d832264e07refs/remotes/origin/master7b429b2f394be33db0348d15755e28d832264e077b429b2f394be33db0348d15755e28d832264e07refs/remotes/origin/masterhttps://github.com/larson-group/clubb.githttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_timestep_gfortran_tests/detail/clubb_timestep_gfortran_tests/327/artifactshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_timestep_gfortran_tests/detail/clubb_timestep_gfortran_tests/327/changeshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_timestep_gfortran_tests/detail/clubb_timestep_gfortran_tests/327/http://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_timestep_gfortran_tests/detail/clubb_timestep_gfortran_tests/327/testsfalsefalse#327937414593391clubb_timestep_gfortran_tests #327327false3271187SUCCESS1714464848915http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/327/README7b429b2f394be33db0348d15755e28d832264e071714415012000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding space to include BIT_CHANGING:84588a46852a812266d19e36a8220f71ad56043a. This (https://github.com/larson-group/clubb/commit/84588a46852a812266d19e36a8220f71ad56043a) is described as not bit changing, but that seems to depend on the compiler version and some flags. The bin diff tests detected differences in only twp_ice when using e3sm flags on nelson, and both e3sm flags and default flags on carson. 2024-04-29 13:23:32 -05007b429b2f394be33db0348d15755e28d832264e07Adding space to include BIT_CHANGING:84588a46852a812266d19e36a8220f71ad56043a. This (https://github.com/larson-group/clubb/commit/84588a46852a812266d19e36a8220f71ad56043a) is described as not bit changing, but that seems to depend on the compiler version and some flags. The bin diff tests detected differences in only twp_ice when using e3sm flags on nelson, and both e3sm flags and default flags on carson.editREADMEgithttp://carson.math.uwm.edu/jenkins/user/hueblerGunther HueblerhueblerfalseStarted by an SCM change328e904e3ffbf83888681ba64f9008890329bd18631e904e3ffbf83888681ba64f9008890329bd18631refs/remotes/origin/mastere904e3ffbf83888681ba64f9008890329bd18631e904e3ffbf83888681ba64f9008890329bd18631refs/remotes/origin/mastere904e3ffbf83888681ba64f9008890329bd18631e904e3ffbf83888681ba64f9008890329bd18631refs/remotes/origin/masterhttps://github.com/larson-group/clubb.gitfalse#3281093351593391clubb_timestep_gfortran_tests #328328false3281239SUCCESS1714551247530http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/328/src/CLUBB_core/advance_xm_wpxp_module.F90b2af0adcfce248292c5d48aefd9226666ee633e51714471119000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduMoved the ghost-point setting of xm(1) = xm(2) to the last line of the subroutine so this command doesn't get overwritten. This is technically BIT_CHANGING because it alters rtm (and some rtm-related calculations) at the ghost point, but it is not answer changing. This is being done in preparation for ghost point removal. 2024-04-30 04:58:39 -0500b2af0adcfce248292c5d48aefd9226666ee633e5Moved the ghost-point setting of xm(1) = xm(2) to the last lineeditsrc/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_windm_edsclrm_module.F90src/CLUBB_core/advance_wp2_wp3_module.F90src/CLUBB_core/advance_xp3_module.F90src/CLUBB_core/grid_class.F90src/CLUBB_core/setup_clubb_pdf_params.F90src/CLUBB_core/calc_pressure.F90src/CLUBB_core/advance_helper_module.F90src/CLUBB_core/mixing_length.F90src/CLUBB_core/advance_xp2_xpyp_module.F90556370c6406e6b943b88affbe7728a5036b1ba221714534975000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comOptional arguments are just best sometimes (#1150) * Adding optional argument to zm2zt/zt2zm to act as threshold. This cuts down on lots of bulk and reduces the chances of breaking the GPU code. All BFB. * Removing TODO * Replacing hardcoded 0.0_core_rknd with zero_threshold 2024-04-30 22:42:55 -0500556370c6406e6b943b88affbe7728a5036b1ba22Optional arguments are just best sometimes (#1150)editsrc/CLUBB_core/advance_xm_wpxp_module.F90editsrc/CLUBB_core/grid_class.F90editsrc/CLUBB_core/setup_clubb_pdf_params.F90editsrc/CLUBB_core/advance_helper_module.F90editsrc/CLUBB_core/advance_xp2_xpyp_module.F90editsrc/CLUBB_core/advance_wp2_wp3_module.F90editsrc/CLUBB_core/advance_xp3_module.F90editsrc/CLUBB_core/calc_pressure.F90editsrc/CLUBB_core/mixing_length.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/advance_windm_edsclrm_module.F90src/CLUBB_core/advance_clubb_core_module.F90e904e3ffbf83888681ba64f9008890329bd186311714537919000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing bug. RESOLVED:556370c6406e6b943b88affbe7728a5036b1ba22, this was catchable by using debugging flags, but seems to otherwise cause no issues. Investigating I found that it only clips the below ground level, so that must not have been affecting other levels. This is technically BIT_CHANGING since it resolves an issue. 2024-04-30 23:31:59 -0500e904e3ffbf83888681ba64f9008890329bd18631Fixing bug. RESOLVED:556370c6406e6b943b88affbe7728a5036b1ba22, this was catchable by using debugging flags, but seems to otherwise cause no issues. Investigating I found that it only clips the below ground level, so that must not have been affecting other levels. This is technically BIT_CHANGING since it resolves an issue.editsrc/CLUBB_core/advance_clubb_core_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse329http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/329/327http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/327/Started by an SCM change3269136bf065fe59e64db24c8a3f2aeee71784502739136bf065fe59e64db24c8a3f2aeee7178450273refs/remotes/origin/master9136bf065fe59e64db24c8a3f2aeee71784502739136bf065fe59e64db24c8a3f2aeee7178450273refs/remotes/origin/master9136bf065fe59e64db24c8a3f2aeee71784502739136bf065fe59e64db24c8a3f2aeee7178450273refs/remotes/origin/masterhttps://github.com/larson-group/clubb.gitfalse#3261080359593391clubb_timestep_gfortran_tests #326326false3261122SUCCESS1714205648314http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/326/src/CLUBB_core/grid_class.F909136bf065fe59e64db24c8a3f2aeee71784502731713916476000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI'm changing the way ddzt handles the derivative over momentum level 1. Previously, it was based on the differential between the ghost point and the first level above the surface. Now, the value of the derivative at momentum level 2 is simply being dropped down to momentum level 1. This is being done in advance of ghost point removal. The results of this commit are BIT_CHANGING. 2024-04-23 18:54:36 -05009136bf065fe59e64db24c8a3f2aeee7178450273I'm changing the way ddzt handles the derivative over momentum level 1.editsrc/CLUBB_core/grid_class.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2false327http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/327/325http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/325/