Started by an SCM change315f4eddbe57c7e8def8bfbcda6a7ef2fa5cdb7af14f4eddbe57c7e8def8bfbcda6a7ef2fa5cdb7af14refs/remotes/origin/masterf4eddbe57c7e8def8bfbcda6a7ef2fa5cdb7af14f4eddbe57c7e8def8bfbcda6a7ef2fa5cdb7af14refs/remotes/origin/masterf4eddbe57c7e8def8bfbcda6a7ef2fa5cdb7af14f4eddbe57c7e8def8bfbcda6a7ef2fa5cdb7af14refs/remotes/origin/masterhttps://github.com/larson-group/clubb.githttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_timestep_gfortran_tests/detail/clubb_timestep_gfortran_tests/315/artifactshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_timestep_gfortran_tests/detail/clubb_timestep_gfortran_tests/315/changeshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_timestep_gfortran_tests/detail/clubb_timestep_gfortran_tests/315/http://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_timestep_gfortran_tests/detail/clubb_timestep_gfortran_tests/315/testsfalsefalse#3151033381596301clubb_timestep_gfortran_tests #315315false315412SUCCESS1712045589448http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/315/src/CLUBB_core/advance_xm_wpxp_module.F906a1e8890090ef11ea420d2868ad6d2f102021cb81712000028000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing bug with C6 parameters, see https://github.com/larson-group/clubb/pull/1147. This is technically BIT_CHANGING, but only when C6thl != C6thlb and l_diag_Lscale_from_tau=.false. 2024-04-01 14:33:48 -05006a1e8890090ef11ea420d2868ad6d2f102021cb8Fixing bug with C6 parameters, see https://github.com/larson-group/clubb/pull/1147. This is technically BIT_CHANGING, but only when C6thl != C6thlb and l_diag_Lscale_from_tau=.false.editsrc/CLUBB_core/advance_xm_wpxp_module.F90README76e4ab2bacd0c770cc861330436f1631dd8c11c41712000383000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding space to make commit because last commit RESOLVED:35d228ebbb66b1463f30659321cd4f7d76adffa2 2024-04-01 14:39:43 -050076e4ab2bacd0c770cc861330436f1631dd8c11c4Adding space to make commit because last commit RESOLVED:35d228ebbb66b1463f30659321cd4f7d76adffa2editREADMEsrc/variables_radiation_module.F90f4eddbe57c7e8def8bfbcda6a7ef2fa5cdb7af141712005481000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing a bug. These directives get added when running the ACC to OMP conversion script. I'm unsure how I accidentally commited this, and equally unsure of how only one file is affected. This was found while debugging the clubb thread test 2024-04-01 16:04:41 -0500f4eddbe57c7e8def8bfbcda6a7ef2fa5cdb7af14Fixing a bug. These directives get added when running the ACC to OMP conversion script. I'm unsure how I accidentally commited this, and equally unsure of how only one file is affected. This was found while debugging the clubb thread testeditsrc/variables_radiation_module.F90githttp://carson.math.uwm.edu/jenkins/user/hueblerGunther HueblerhueblerfalseStarted by an SCM change31645b34a9553d7741f7f6f057941c82b20801c175145b34a9553d7741f7f6f057941c82b20801c1751refs/remotes/origin/master45b34a9553d7741f7f6f057941c82b20801c175145b34a9553d7741f7f6f057941c82b20801c1751refs/remotes/origin/master45b34a9553d7741f7f6f057941c82b20801c175145b34a9553d7741f7f6f057941c82b20801c1751refs/remotes/origin/masterhttps://github.com/larson-group/clubb.gitfalse#316937961596301clubb_timestep_gfortran_tests #316316false316514SUCCESS1712304789980http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/316/src/CLUBB_core/advance_xp2_xpyp_module.F9045b34a9553d7741f7f6f057941c82b20801c17511712297060000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduAt the ghost point below the surface, which does not matter in the calculations, a value of 0 is now being entered for thermodynamic-level output stats coef_wprtp2_implicit, term_wprtp2_explicit, etc. Why would we do this? The answer is "Why Not??!!!!" This is being done to keep the trunk results bit-for-bit with the clubb_ghost_exorcism branch, which is no longer loops over the ghost level below the surface in the region of code where these stats are recorded. In terms of the master, this commit is technically BIT_CHANGING. However, only for these 6 output terms at the ghost point. 2024-04-05 01:04:20 -050045b34a9553d7741f7f6f057941c82b20801c1751At the ghost point below the surface, which does not matter ineditsrc/CLUBB_core/advance_xp2_xpyp_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2false317http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/317/315http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/315/Started by an SCM change31435d228ebbb66b1463f30659321cd4f7d76adffa235d228ebbb66b1463f30659321cd4f7d76adffa2refs/remotes/origin/master35d228ebbb66b1463f30659321cd4f7d76adffa235d228ebbb66b1463f30659321cd4f7d76adffa2refs/remotes/origin/master35d228ebbb66b1463f30659321cd4f7d76adffa235d228ebbb66b1463f30659321cd4f7d76adffa2refs/remotes/origin/masterhttps://github.com/larson-group/clubb.gitfalse#3141040809596301clubb_timestep_gfortran_tests #314314false314330SUCCESS1711959190170http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/314/src/CLUBB_core/new_hybrid_pdf_main.F90src/CLUBB_core/advance_wp2_wp3_module.F90src/CLUBB_core/parameters_tunable.F90src/G_unit_test_types/spurious_source_test.F90src/CLUBB_core/pdf_closure_module.F90src/CLUBB_core/clip_explicit.F90src/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90src/clubb_thread_test.F90src/CLUBB_core/sfc_varnce_module.F90src/CLUBB_core/Skx_module.F90src/CLUBB_core/mixing_length.F90src/CLUBB_core/advance_xp2_xpyp_module.F90src/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/clubb_standalone.F90src/jacobian.F90src/clubb_driver.F90src/CLUBB_core/clubb_api_module.F90src/variables_radiation_module.F90src/G_unit_test_types/pdf_parameter_tests.F90src/error.F90src/CLUBB_core/advance_helper_module.F90src/CLUBB_core/new_pdf_main.F9035d228ebbb66b1463f30659321cd4f7d76adffa21711925174000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comPutting ngrdcol in clubb_params (#1147) * Initial changes to make clubb_params have an ngrdcol dimension. All BFB on CPU and GPU. * pdf_closure done * pdf_closure missed changes * calc_Lscale_directly changes and removed accidentally added files * advance_xp2_xpyp done * Missed file * Added space here because the addition of this line in the last commit is to prevent Ri_zm from being uninitialized when using l_diag_Lscale_from_tau=.false. * advance_wp2_wp3 done * advance_xm_wpxp done * Fixed bugs found by checking l_modify_limiters_for_cnvg_test=.true. * Fixed bug found by checking l_diffuse_rtm_and_thlm and l_stability_correct_Kh_N2_zm * Removing slightly redundant logic * Swapping back order of l_gamma_skw if statements. I'm not sure why I swapped them in the first place. 2024-03-31 17:46:14 -050035d228ebbb66b1463f30659321cd4f7d76adffa2Putting ngrdcol in clubb_params (#1147)editsrc/error.F90editsrc/CLUBB_core/Skx_module.F90editsrc/CLUBB_core/advance_helper_module.F90editsrc/CLUBB_core/advance_wp2_wp3_module.F90editsrc/CLUBB_core/clip_explicit.F90editsrc/CLUBB_core/sfc_varnce_module.F90editsrc/CLUBB_core/new_hybrid_pdf_main.F90editsrc/jacobian.F90editsrc/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90editsrc/CLUBB_core/advance_xm_wpxp_module.F90editsrc/CLUBB_core/new_pdf_main.F90editsrc/clubb_driver.F90editsrc/CLUBB_core/clubb_api_module.F90editsrc/CLUBB_core/pdf_closure_module.F90editsrc/clubb_standalone.F90editsrc/CLUBB_core/advance_xp2_xpyp_module.F90editsrc/G_unit_test_types/spurious_source_test.F90editsrc/variables_radiation_module.F90editsrc/G_unit_test_types/pdf_parameter_tests.F90editsrc/CLUBB_core/parameters_tunable.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/mixing_length.F90editsrc/clubb_thread_test.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse315http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/315/313http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/313/