Started by an SCM change20153c717bb7dd9bddcd720cba58c46d77b7ad36c9c53c717bb7dd9bddcd720cba58c46d77b7ad36c9crefs/remotes/origin/master53c717bb7dd9bddcd720cba58c46d77b7ad36c9c53c717bb7dd9bddcd720cba58c46d77b7ad36c9crefs/remotes/origin/master53c717bb7dd9bddcd720cba58c46d77b7ad36c9c53c717bb7dd9bddcd720cba58c46d77b7ad36c9crefs/remotes/origin/masterhttps://github.com/larson-group/clubb.githttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_timestep_gfortran_tests/detail/clubb_timestep_gfortran_tests/201/artifactshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_timestep_gfortran_tests/detail/clubb_timestep_gfortran_tests/201/changeshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_timestep_gfortran_tests/detail/clubb_timestep_gfortran_tests/201/http://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_timestep_gfortran_tests/detail/clubb_timestep_gfortran_tests/201/testsfalsefalse#201841024596301clubb_timestep_gfortran_tests #201201false20121247SUCCESS1678180390192http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/201/run_scripts/convergence_function.pyrun_scripts/run_cnvg_test_multi_cases.cshrun_scripts/plot_l2_convergence.pyrun_scripts/convergence_config.py0e087bee28254a2bc2da5869a28352e1374b2b911678120205000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduAdd scripts to configure and run convergence test This commit contains new scripts created to configure and run convergence test simulations. There are four scripts: 1. run_scripts/run_cnvg_test_multi_cases.csh. This script is used to compile and run convergence simulations with specific configurations (see details in scripts for explations). After the simulations,the space-time convergence plots will also be generated. 2.run_scripts/convergence_config.py: this script "called" by the first script to generate the namelist file for CLUBB-SCM simulations. With this script, the modified configuration will be applied in the case run directory, while the files in default clubb will not be touched 3.run_scripts/convergence_function.py: this script contains function to modify the initial condition profile for convergence test simulations. It is called by run_scripts/convergence_config.py when the model is configured to use modified initial conditions 4.run_scripts/plot_l2_convergence.py: this is a sample script to generate the space-time convergence plots Originally committed by Shixuan 2023-03-06 10:30:05 -06000e087bee28254a2bc2da5869a28352e1374b2b91Add scripts to configure and run convergence testaddrun_scripts/convergence_function.pyaddrun_scripts/run_cnvg_test_multi_cases.cshaddrun_scripts/plot_l2_convergence.pyaddrun_scripts/convergence_config.pyrun_scripts/convergence_run/convergence_function.pyrun_scripts/convergence_run/run_cnvg_test_multi_cases.cshrun_scripts/convergence_run/convergence_config.pyrun_scripts/plot_l2_convergence.pyrun_scripts/convergence_config.pyrun_scripts/convergence_function.pyrun_scripts/run_cnvg_test_multi_cases.cshrun_scripts/convergence_run/plot_l2_convergence.py53c717bb7dd9bddcd720cba58c46d77b7ad36c9c1678120475000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.edureorgnize the scripts for convergence test simulations Move the script associated with convergence test simulation in the folder of run_scripts/convergence_run Originally committed by Shixuan 2023-03-06 10:34:35 -060053c717bb7dd9bddcd720cba58c46d77b7ad36c9creorgnize the scripts for convergence test simulationsdeleterun_scripts/convergence_config.pyaddrun_scripts/convergence_run/convergence_function.pyaddrun_scripts/convergence_run/convergence_config.pyaddrun_scripts/convergence_run/plot_l2_convergence.pydeleterun_scripts/run_cnvg_test_multi_cases.cshdeleterun_scripts/convergence_function.pydeleterun_scripts/plot_l2_convergence.pyaddrun_scripts/convergence_run/run_cnvg_test_multi_cases.cshgithttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2falseStarted by an SCM change202c5c29600aa8cf9176127e44fbf6ddccf9474722ac5c29600aa8cf9176127e44fbf6ddccf9474722arefs/remotes/origin/masterc5c29600aa8cf9176127e44fbf6ddccf9474722ac5c29600aa8cf9176127e44fbf6ddccf9474722arefs/remotes/origin/masterc5c29600aa8cf9176127e44fbf6ddccf9474722ac5c29600aa8cf9176127e44fbf6ddccf9474722arefs/remotes/origin/masterhttps://github.com/larson-group/clubb.gitfalse#2022375609596301clubb_timestep_gfortran_tests #202202false20221299SUCCESS1678353187445http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/202/READMEdb8d5931d779bc1f776fb80952a1c263c22f84671678293578000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdate README I guess the proper way to do it is this -- BIT_CHANGING:9aeea14 2023-03-08 10:39:38 -0600db8d5931d779bc1f776fb80952a1c263c22f8467Update READMEeditREADMEsrc/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/turbulent_adv_pdf.F90src/CLUBB_core/grid_class.F90src/CLUBB_core/pdf_closure_module.F90src/CLUBB_core/mean_adv.F90src/CLUBB_core/saturation.F90src/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90src/CLUBB_core/pdf_utilities.F90src/CLUBB_core/mixing_length.F90a3bcb0bd343d004b2f085006708b88131be995071678297579000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comGpu updates (#1070) * Fixing bug. This was only triggered when l_input_fields=.true., which I am only testing because it needs to be true so that I can test ADG2_driver. * Removing usage of gr from pdf_closure. It was only ever used for nz, which is now fed in directly. * Making openacc statements more consistent. Ensuring all statments on double loops have specified gang and vector, and that all parallel loops have an end parallel loop statment at the end of them. Everything BFB on CPUs and GPUs. * Pushing acc data region to outermost parts of mixing_length. * Removing pdf_implicit_coefs_terms from acc copyin and copyout. It is only used when iiPDF_type == iiPDF_new .or. iiPDF_type == iiPDF_new_hybrid, so we do not need to do any copying with it. The inclusion of it also caused the data statement to copy unallocated arrays, which are just garbage pointers, and that was causing random occasional crashes (either segfaults or gpu out of memory). * The update device clauses for return variables seems to only be requried for arrays contained in types. See https://github.com/larson-group/clubb/issues/1049\#issuecomment-1440624778 * Moving acc end data to end of pdf_closure. This reuqired removing any conditional return statements that appear before the final return, since we're not allowed to branch out of an acc region early. I also moved a large printout statement outside of a loop. The only reason it was in the loop to begin with was because pdf_params used to be an array of types, but now is a type of arrays, allowing us to print the full arrays directly. * Making loop an acc loop. If we weren't outputting w_[up/down]_in_cloud (iw_up_in_cloud <= 0 .or. iw_down_in_cloud <= 0, then these arrays were only being zerod out on the CPU and would've getting overwritten by the uninitialized GPU data at the end of the data statement. This change causes the arrays to get correctly zerod out on the GPU when we need. * Update VariableGroupNondimMoments.py Fixed a typo * Merging new changes from master * Removing need for -gpu=deepcopy, pushing some acc data statements up call tree, and replacing some acc data statements with acc delare statements so that return statements can be added back in. * Adding back an acc loop that was accidentally removed during a merge. --------- Co-authored-by: Brian Griffin <31553422+bmg929@users.noreply.github.com> 2023-03-08 11:46:19 -0600a3bcb0bd343d004b2f085006708b88131be99507Gpu updates (#1070)editsrc/CLUBB_core/mean_adv.F90editsrc/CLUBB_core/grid_class.F90editsrc/CLUBB_core/saturation.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/pdf_utilities.F90editsrc/CLUBB_core/turbulent_adv_pdf.F90editsrc/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90editsrc/CLUBB_core/pdf_closure_module.F90editsrc/CLUBB_core/mixing_length.F90input/case_setups/dycoms2_rf02_morr_model.insrc/clubb_driver.F90input/case_setups/dycoms2_rf02_nd_model.ininput/case_setups/bomex_model.ininput/case_setups/dycoms2_rf02_ds_model.ininput/case_setups/rico_silhs_model.ininput/case_setups/dycoms2_rf02_so_model.ininput/case_setups/rico_model.ininput/case_setups/wangara_model.ininput/case_setups/dycoms2_rf02_do_model.in8e473e08b858df61c5c5116e37e26f3df2431a0b1678316303000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduCode changes to implement modified boundary condition This commit contains code changes to implement modified boundary conditions for convergence test simulations. These code changes can be activated by setting l_modify_bc_for_cnvg_test = .true. in the CLUBB namelist. Originally committed by Shixuan. 2023-03-08 16:58:23 -06008e473e08b858df61c5c5116e37e26f3df2431a0bCode changes to implement modified boundary conditioneditinput/case_setups/rico_model.ineditinput/case_setups/dycoms2_rf02_so_model.ineditsrc/clubb_driver.F90editinput/case_setups/dycoms2_rf02_nd_model.ineditinput/case_setups/wangara_model.ineditinput/case_setups/dycoms2_rf02_ds_model.ineditinput/case_setups/dycoms2_rf02_do_model.ineditinput/case_setups/rico_silhs_model.ineditinput/case_setups/bomex_model.ineditinput/case_setups/dycoms2_rf02_morr_model.insrc/CLUBB_core/mono_flux_limiter.F90c5c29600aa8cf9176127e44fbf6ddccf9474722a1678350700000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comImplements Thomas Toniazzo's bug fix for spike removal in the monotonic flux limiter. See https://github.com/larson-group/clubb_release/pull/11/files This code change is expected to be BIT_CHANGING for cases in which `l_predict_upwp_vpwp = T`, `l_mono_flux_lim_um = T` or `l_mono_flux_lim_vm = T`, and the monotonic flux limiter is triggered. This bug fix prevents non-conservation of momentum when the vertical integral of either of the wind components `um` or `vm` is negative. 2023-03-09 02:31:40 -0600c5c29600aa8cf9176127e44fbf6ddccf9474722aImplements Thomas Toniazzo's bug fix for spike removaleditsrc/CLUBB_core/mono_flux_limiter.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse203http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/203/201http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/201/Started by an SCM change200a6682998e27e3d01b8ffeb4ec2774872e7311aa4a6682998e27e3d01b8ffeb4ec2774872e7311aa4refs/remotes/origin/mastera6682998e27e3d01b8ffeb4ec2774872e7311aa4a6682998e27e3d01b8ffeb4ec2774872e7311aa4refs/remotes/origin/mastera6682998e27e3d01b8ffeb4ec2774872e7311aa4a6682998e27e3d01b8ffeb4ec2774872e7311aa4refs/remotes/origin/masterhttps://github.com/larson-group/clubb.gitfalse#200842479596301clubb_timestep_gfortran_tests #200200false20021201SUCCESS1677921188616http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/200/utilities/autocommit_message_maker/autocommit_message_maker.py965964e81cc6b58ffbf3213af1d2488080b3371a1677867187000http://carson.math.uwm.edu/jenkins/user/cerniktcernikttjcernik@uwm.eduadded autocommit message maker to clubb so I have an easier time testing it 2023-03-03 12:13:07 -0600965964e81cc6b58ffbf3213af1d2488080b3371aadded autocommit message maker to clubb so I have an easier time testing itaddutilities/autocommit_message_maker/autocommit_message_maker.pyutilities/autocommit_message_maker/autocommit_message_maker.py6e4204729c1b525b0f2fde3d7c715f5982fc79c31677881620000http://carson.math.uwm.edu/jenkins/user/cerniktcernikttjcernik@uwm.educhanges to integrate message maker into gitUpdate scripts 2023-03-03 16:13:40 -06006e4204729c1b525b0f2fde3d7c715f5982fc79c3changes to integrate message maker into gitUpdate scriptseditutilities/autocommit_message_maker/autocommit_message_maker.pyutilities/autocommit_message_maker/autocommit_message_maker.pybe6ab481c56acfc66d65990889dba011d6bcd36a1677881884000http://carson.math.uwm.edu/jenkins/user/cerniktcernikttjcernik@uwm.eduOops, I made 1 small error, should be consistent now. 2023-03-03 16:18:04 -0600be6ab481c56acfc66d65990889dba011d6bcd36aOops, I made 1 small error, should be consistent now.editutilities/autocommit_message_maker/autocommit_message_maker.pyinput/case_setups/bomex_model.ininput/case_setups/rico_sounding.ininput/case_setups/dycoms2_rf02_ds_model.ininput/case_setups/rico_silhs_model.ininput/case_setups/rico_model.ininput/case_setups/dycoms2_rf02_do_model.ininput/case_setups/dycoms2_rf02_morr_model.ininput/case_setups/dycoms2_rf02_nd_model.ininput/case_setups/wangara_sounding.insrc/clubb_driver.F90src/sounding.F90input/case_setups/dycoms2_rf02_so_model.ininput/case_setups/dycoms2_rf02_sounding.ininput/case_setups/bomex_sounding.ininput/case_setups/wangara_model.in9aeea149d5970cb99218344f8bde576e1f036d211677883168000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduImplementing changes to the initial conditions. This commit contains code changes related to the modified initial conditions for convergence test simulations. These code changes can be activated by setting l_modify_ic_with_cubic_int = .true. in the namelist on a case-by-case basis. Along with this option, the sounding profiles are also modified for the BOMEX, RICO, DYCOMS2_RF02 and Wangara cases. -- For BOMEX, RICO, Wangara cases, we add more height levels in the original sounding profiles so that the cubic spline interpolation produces consistent profiles with those with linear interpolation -- For DYCOMS2_RF02, instead of using the formulations in the code to derive the initial condition profiles (which will results in the grid-spacing dependent initial condition when we refine grid), we construct a sounding profiles (still use the same formulas as in the src/sounding.F90) on a high-resolution grid (refine the standard grid by a factor of 2^7), then save the profile in dycoms2_rf02_sounding.in. In this way, the model initiliazation will always read the same sounding profile for initialization when user refine the vertical model grid. Originally committed by Shixuan. 2023-03-03 16:39:28 -06009aeea149d5970cb99218344f8bde576e1f036d21Implementing changes to the initial conditions.editinput/case_setups/rico_model.ineditinput/case_setups/bomex_model.ineditsrc/sounding.F90editinput/case_setups/dycoms2_rf02_do_model.ineditinput/case_setups/dycoms2_rf02_nd_model.ineditinput/case_setups/bomex_sounding.ineditinput/case_setups/dycoms2_rf02_ds_model.ineditinput/case_setups/wangara_sounding.ineditinput/case_setups/dycoms2_rf02_so_model.ineditinput/case_setups/wangara_model.ineditinput/case_setups/dycoms2_rf02_morr_model.ineditsrc/clubb_driver.F90editinput/case_setups/rico_sounding.ineditinput/case_setups/rico_silhs_model.ineditinput/case_setups/dycoms2_rf02_sounding.inREADMEa6682998e27e3d01b8ffeb4ec2774872e7311aa41677905458000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduThis commit most definitely does not change any bits, but commit 67878ef was BIT_CHANGING for the DYCOMS-II RF02 family of cases, RICO (and RICO SILHS), BOMEX, and Wangara. 2023-03-03 22:50:58 -0600a6682998e27e3d01b8ffeb4ec2774872e7311aa4This commit most definitely does not change any bits,editREADMEgithttp://carson.math.uwm.edu/jenkins/user/cerniktcernikthttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2false201http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/201/199http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/199/