Started by an SCM change1827f1decd0252e0b4d80f4b3873b0b48b6d3ec86317f1decd0252e0b4d80f4b3873b0b48b6d3ec8631refs/remotes/origin/master7f1decd0252e0b4d80f4b3873b0b48b6d3ec86317f1decd0252e0b4d80f4b3873b0b48b6d3ec8631refs/remotes/origin/master7f1decd0252e0b4d80f4b3873b0b48b6d3ec86317f1decd0252e0b4d80f4b3873b0b48b6d3ec8631refs/remotes/origin/masterhttps://github.com/larson-group/clubb.githttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_timestep_gfortran_tests/detail/clubb_timestep_gfortran_tests/182/artifactshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_timestep_gfortran_tests/detail/clubb_timestep_gfortran_tests/182/changeshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_timestep_gfortran_tests/detail/clubb_timestep_gfortran_tests/182/http://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_timestep_gfortran_tests/detail/clubb_timestep_gfortran_tests/182/testsfalsefalse#1821816001596301clubb_timestep_gfortran_tests #182182false18220007SUCCESS1674119588455http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/182/src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/model_flags.F90src/CLUBB_core/mixing_length.F90src/CLUBB_core/saturation.F907f1decd0252e0b4d80f4b3873b0b48b6d3ec86311674081416000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRestructuring and Porting of Compute_mixing_length subroutine(Phase 2) (#1054) * Restructuring and Porting of Compute_mixing_length subroutine(Phase 2) Restructure: sat_mixrat_liq_2D_acc is being directly called instead of calling the 1D version inside the column loop. Changing sat_mixrat_liq_2D_acc to a subroutine from a function and adding output array, start_index as additional argument. This is a workaround for passing sub-arrays. The OpenACC doen't like the sub-arrays being passed and fails the validation. Porting: OpenACC directives are added inside sat_mixrat_liq_2D_acc for porting Validation: Answers are Bit for Bit with arm-multicolumn case + nvhpc compiler * Fix for compilation issues Issue 1: Missed out declaring 'start_index' while intergrating the change Issue 2: The use of error_code module and the procedures inside it causes OpenACC compilation issues when run on the device. * Removing the sat_mixrat_liq_acc and sat_mixrat_liq_2D_acc, making the normal sat_mixrat_liq work for all current use cases, and making the other versions of sat_mixrat_liq (bolton,gfdl,lookup) functional with OPENACC. Co-authored-by: huebler <huebler@uwm.edu> 2023-01-18 16:36:56 -06007f1decd0252e0b4d80f4b3873b0b48b6d3ec8631Restructuring and Porting of Compute_mixing_length subroutine(Phase 2) (#1054)editsrc/CLUBB_core/saturation.F90editsrc/CLUBB_core/mixing_length.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/model_flags.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreplyfalseStarted by an SCM change183dda5e8c57edb41b73340c0f9578d7c327b18e076dda5e8c57edb41b73340c0f9578d7c327b18e076refs/remotes/origin/masterdda5e8c57edb41b73340c0f9578d7c327b18e076dda5e8c57edb41b73340c0f9578d7c327b18e076refs/remotes/origin/masterdda5e8c57edb41b73340c0f9578d7c327b18e076dda5e8c57edb41b73340c0f9578d7c327b18e076refs/remotes/origin/masterhttps://github.com/larson-group/clubb.gitfalse#1831793961596301clubb_timestep_gfortran_tests #183183false18320083SUCCESS1674205989628http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/183/src/CLUBB_core/mono_flux_limiter.F90e21e2713eab0f3f228189a4b407c80d4f241038f1674153381000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comBreaking up column loop in mono_flux_limiter. This may not be the final form for GPUization, but it's definitely a start, no longer do we have to copy single column variables to multicolumn ones anywhere. (#1051) 2023-01-19 12:36:21 -0600e21e2713eab0f3f228189a4b407c80d4f241038fBreaking up column loop in mono_flux_limiter. This may not be the final form for GPUization, but it's definitely a start, no longer do we have to copy single column variables to multicolumn ones anywhere. (#1051)editsrc/CLUBB_core/mono_flux_limiter.F90src/CLUBB_core/matrix_solver_wrapper.F90src/CLUBB_core/model_flags.F90src/CLUBB_core/tridiag_lu_solver.F90src/CLUBB_core/lapack_wrap.F90src/CLUBB_core/penta_lu_solver.F90dda5e8c57edb41b73340c0f9578d7c327b18e0761674153404000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdding tridiag_lu solver (#1056) * Adding tridiag_lu solver * Changing low to lower in tridiag_lu and penta_lu, also fixing up some spacing. * Making variables that represent matrix solutions more consistently named. 2023-01-19 12:36:44 -0600dda5e8c57edb41b73340c0f9578d7c327b18e076Adding tridiag_lu solver (#1056)editsrc/CLUBB_core/matrix_solver_wrapper.F90editsrc/CLUBB_core/penta_lu_solver.F90editsrc/CLUBB_core/model_flags.F90editsrc/CLUBB_core/lapack_wrap.F90addsrc/CLUBB_core/tridiag_lu_solver.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse184http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/184/182http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/182/Started by an SCM change18188b8239840f581d76610aa630dab6219d64d68be88b8239840f581d76610aa630dab6219d64d68berefs/remotes/origin/master88b8239840f581d76610aa630dab6219d64d68be88b8239840f581d76610aa630dab6219d64d68berefs/remotes/origin/master88b8239840f581d76610aa630dab6219d64d68be88b8239840f581d76610aa630dab6219d64d68berefs/remotes/origin/masterhttps://github.com/larson-group/clubb.gitfalse#1811433019596301clubb_timestep_gfortran_tests #181181false18119915SUCCESS1673601190840http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/181/compile/config/linux_x86_64_nvhpc_casper.bashsrc/CLUBB_core/constants_clubb.F90src/CLUBB_core/model_flags.F90src/CLUBB_core/mixing_length.F90src/CLUBB_core/saturation.F9088b8239840f581d76610aa630dab6219d64d68be1673549655000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRestructuring and Porting of Compute_mixing_length subroutine(Phase 1) (#1052) * Restructuring and Porting of Compute_mixing_length subroutine(Phase 1) Restructure: The compute_mixing_length is one of the top most routine taking 35-50% of the total time in a single timestep. The subroutine has been restructured to push the i-loop further down to extract vectorization and parallelization. The restructuring also involves introduction of sat_mixrat_liq_acc routines to extract parallelism when called inside a OpenACC parallel region. Porting: OpenACC directives are inserted to port the restructured compute_mixing_length code on to the GPUs. This port is currently unoptimized and there is still room for improvement. NOTE: Currently, l_sat_mixrat_lookup = false and saturation_formula = saturation_flatau (Earthworks config options) case is supported on OpenACC build. Any other options works on CPUs as usual. OpenACC declare create directives are inserted in model_flags and constants_clubb, as these module variables are used inside the saturation routines. * Added debug message about only supporting l_sat_mixrat_lookup = false and saturation_formula = saturation_flatau on GPUs Answers are Bit for Bit with arm-multicolumn case + nvhpc compiler. * Changing CLUBB debug level 1 to 0 for the saturation formula support running on GPUs * Changing indentation to make gfortran happy, it wants ifdefs to start at the beginning of the line. * Adding use statements for error checks and printouts, also making the errors set err_code to clubb_fatal_error. Co-authored-by: huebler <huebler@uwm.edu> 2023-01-12 12:54:15 -060088b8239840f581d76610aa630dab6219d64d68beRestructuring and Porting of Compute_mixing_length subroutine(Phase 1) (#1052)editsrc/CLUBB_core/constants_clubb.F90editsrc/CLUBB_core/model_flags.F90editsrc/CLUBB_core/mixing_length.F90editsrc/CLUBB_core/saturation.F90editcompile/config/linux_x86_64_nvhpc_casper.bashgithttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse182http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/182/180http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/180/