Started by an SCM change1621bf74dd6f173a645d7bd448ab6bc07028c8ffadd1bf74dd6f173a645d7bd448ab6bc07028c8ffaddrefs/remotes/origin/master1bf74dd6f173a645d7bd448ab6bc07028c8ffadd1bf74dd6f173a645d7bd448ab6bc07028c8ffaddrefs/remotes/origin/master1bf74dd6f173a645d7bd448ab6bc07028c8ffadd1bf74dd6f173a645d7bd448ab6bc07028c8ffaddrefs/remotes/origin/masterhttps://github.com/larson-group/clubb.githttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_timestep_gfortran_tests/detail/clubb_timestep_gfortran_tests/162/artifactshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_timestep_gfortran_tests/detail/clubb_timestep_gfortran_tests/162/changeshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_timestep_gfortran_tests/detail/clubb_timestep_gfortran_tests/162/http://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_timestep_gfortran_tests/detail/clubb_timestep_gfortran_tests/162/testsfalsefalse#1621805507596301clubb_timestep_gfortran_tests #162162false16218579SUCCESS1665735186811http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/162/src/CLUBB_core/mono_flux_limiter.F901bf74dd6f173a645d7bd448ab6bc07028c8ffadd1665672953000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdating monotonic flux limiter code to remove spikes. (#1038) Also putting a commented out code change in advance_xm_wpxp, in case shutting of the flux limiter entirely for rtm is preferred. See https://github.com/NCAR/amwg_dev/discussions/134 for discussion. This commit will be BIT_CHANGING although the differences are only obvious in sensitive cases like arm_97. 2022-10-13 08:55:53 -06001bf74dd6f173a645d7bd448ab6bc07028c8ffaddUpdating monotonic flux limiter code to remove spikes. (#1038)editsrc/CLUBB_core/mono_flux_limiter.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreplyfalseStarted by an SCM change163dd43df7acdaec448a6db87daff8537523060d646dd43df7acdaec448a6db87daff8537523060d646refs/remotes/origin/masterdd43df7acdaec448a6db87daff8537523060d646dd43df7acdaec448a6db87daff8537523060d646refs/remotes/origin/masterdd43df7acdaec448a6db87daff8537523060d646dd43df7acdaec448a6db87daff8537523060d646refs/remotes/origin/masterhttps://github.com/larson-group/clubb.gitfalse#1632327239596301clubb_timestep_gfortran_tests #163163false16318663SUCCESS1665821589656http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/163/src/G_unit_test_types/spurious_source_test.F90input/tunable_parameters_compatible_r8029/configurable_model_flags.insrc/clubb_tuner.F90src/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/clubb_driver.F90src/CLUBB_core/model_flags.F90src/CLUBB_core/clubb_api_module.F90input/tunable_parameters_Lscale/configurable_model_flags.ininput/tunable_parameters_e3sm/configurable_model_flags.insrc/CLUBB_core/mono_flux_limiter.F90src/G_unit_test_types/pdf_parameter_tests.F90input/tunable_parameters/configurable_model_flags.in5b79c73c681b98162df10f5500226f69407040161665761524000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comCreating new flags to control monotonic flux limiter (#1039) * Creating new flags to control monotonic flux limiter and the IF statement fix for the spikes found in CAM. * Removing no-longer-necessary logical l_mono_flux_lim. * Adding requested changes from PR (intent statements and editing error statement). * Accidentally set flag to false. Changing to true. 2022-10-14 09:32:04 -06005b79c73c681b98162df10f5500226f6940704016Creating new flags to control monotonic flux limiter (#1039)editsrc/CLUBB_core/mono_flux_limiter.F90editsrc/G_unit_test_types/pdf_parameter_tests.F90editsrc/clubb_tuner.F90editsrc/CLUBB_core/advance_xm_wpxp_module.F90editinput/tunable_parameters/configurable_model_flags.ineditinput/tunable_parameters_Lscale/configurable_model_flags.ineditinput/tunable_parameters_compatible_r8029/configurable_model_flags.ineditsrc/G_unit_test_types/spurious_source_test.F90editsrc/CLUBB_core/clubb_api_module.F90editsrc/clubb_driver.F90editsrc/CLUBB_core/model_flags.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editinput/tunable_parameters_e3sm/configurable_model_flags.insrc/CLUBB_core/advance_clubb_core_module.F90src/clubb_driver.F90src/G_unit_test_types/w_up_in_cloud_tests.F90src/CLUBB_core/clubb_api_module.F90src/CLUBB_core/pdf_closure_module.F90src/CLUBB_core/stats_clubb_utilities.F90src/CLUBB_core/stats_zt_module.F90src/CLUBB_core/stats_variables.F907550b3e11a7b6218c5eedc78f78e6397423141bb1665787786000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am adding cloudy_updraft_frac and cloudy_downdraft_frac as outputs to the calculate_w_up_in_cloud code. These fields are non-interactive for the standard set of cases. Thus, all cases are bit-for-bit identical. However, for the w_up_in_cloud and w_down_in_cloud results themselves, it is possible that results might not be bit-for-bit since the location of the max(eps, ...) clipping in the denominator is changed. However, results should not be appreciable different. 2022-10-14 17:49:46 -05007550b3e11a7b6218c5eedc78f78e6397423141bbI am adding cloudy_updraft_frac and cloudy_downdraft_frac aseditsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/G_unit_test_types/w_up_in_cloud_tests.F90editsrc/CLUBB_core/clubb_api_module.F90editsrc/CLUBB_core/stats_clubb_utilities.F90editsrc/CLUBB_core/pdf_closure_module.F90editsrc/clubb_driver.F90editsrc/CLUBB_core/stats_variables.F90editsrc/CLUBB_core/stats_zt_module.F90input/stats/all_stats.indd43df7acdaec448a6db87daff8537523060d6461665789118000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI forgot to add cld_updr_frac and cld_downdr_frac to all_stats.in in the last commit. 2022-10-14 18:11:58 -0500dd43df7acdaec448a6db87daff8537523060d646I forgot to add cld_updr_frac and cld_downdr_frac to all_stats.ineditinput/stats/all_stats.ingithttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse164http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/164/162http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/162/Started by an SCM change161ee00186816ceb16bee810c897fabe4deb660fcc3ee00186816ceb16bee810c897fabe4deb660fcc3refs/remotes/origin/masteree00186816ceb16bee810c897fabe4deb660fcc3ee00186816ceb16bee810c897fabe4deb660fcc3refs/remotes/origin/masteree00186816ceb16bee810c897fabe4deb660fcc3ee00186816ceb16bee810c897fabe4deb660fcc3refs/remotes/origin/masterhttps://github.com/larson-group/clubb.gitfalse#1611863870596301clubb_timestep_gfortran_tests #161161false16118515SUCCESS1665475987302http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/161/src/CLUBB_core/advance_xm_wpxp_module.F90ee00186816ceb16bee810c897fabe4deb660fcc31665426176000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdds commented-out line that prevents the monotonic flux limiter from acting on rtm. The comments are included to remind us of how to do this in case we choose to do so in the future. 2022-10-10 13:22:56 -0500ee00186816ceb16bee810c897fabe4deb660fcc3Adds commented-out line that prevents the monotonic fluxeditsrc/CLUBB_core/advance_xm_wpxp_module.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse162http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/162/160http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/160/