Started by an SCM change11850a3080a1374291f321eae16b2806e0753e09b2750a3080a1374291f321eae16b2806e0753e09b27refs/remotes/origin/master50a3080a1374291f321eae16b2806e0753e09b2750a3080a1374291f321eae16b2806e0753e09b27refs/remotes/origin/master50a3080a1374291f321eae16b2806e0753e09b2750a3080a1374291f321eae16b2806e0753e09b27refs/remotes/origin/masterhttps://github.com/larson-group/clubb.githttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_timestep_gfortran_tests/detail/clubb_timestep_gfortran_tests/118/artifactshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_timestep_gfortran_tests/detail/clubb_timestep_gfortran_tests/118/changeshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_timestep_gfortran_tests/detail/clubb_timestep_gfortran_tests/118/http://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_timestep_gfortran_tests/detail/clubb_timestep_gfortran_tests/118/testsfalsefalse#1181423527596301clubb_timestep_gfortran_tests #118118false11815792SUCCESS1654243988257http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/118/src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/parameters_tunable.F90src/CLUBB_core/clubb_api_module.F90src/CLUBB_core/mixing_length.F902230f5a91f09608cc496fba43d68e0d454049a981654197815000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking lmin a scalar again, twas a mistake to make it an array, it can only take on one value. 2022-06-02 14:23:35 -05002230f5a91f09608cc496fba43d68e0d454049a98Making lmin a scalar again, twas a mistake to make it an array, it can only take on one value.editsrc/CLUBB_core/mixing_length.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/parameters_tunable.F90editsrc/CLUBB_core/clubb_api_module.F90src/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_windm_edsclrm_module.F90src/CLUBB_core/advance_wp2_wp3_module.F90src/CLUBB_core/parameters_tunable.F90src/G_unit_test_types/spurious_source_test.F90src/CLUBB_core/clubb_api_module.F90src/advance_microphys_module.F90src/CLUBB_core/advance_xp2_xpyp_module.F9050a3080a1374291f321eae16b2806e0753e09b271654200656000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking nu_vert_res_dep a type containing arrays, as opposed to being an array of types. 2022-06-02 15:10:56 -050050a3080a1374291f321eae16b2806e0753e09b27Making nu_vert_res_dep a type containing arrays, as opposed to being an array of types.editsrc/CLUBB_core/advance_wp2_wp3_module.F90editsrc/G_unit_test_types/spurious_source_test.F90editsrc/CLUBB_core/clubb_api_module.F90editsrc/CLUBB_core/advance_xm_wpxp_module.F90editsrc/CLUBB_core/parameters_tunable.F90editsrc/advance_microphys_module.F90editsrc/CLUBB_core/advance_xp2_xpyp_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/advance_windm_edsclrm_module.F90githttp://carson.math.uwm.edu/jenkins/user/hueblerGunther HueblerhueblerfalseStarted by an SCM change1198b68d8a755879613e18a8994bf6b57c36830e5e08b68d8a755879613e18a8994bf6b57c36830e5e0refs/remotes/origin/master8b68d8a755879613e18a8994bf6b57c36830e5e08b68d8a755879613e18a8994bf6b57c36830e5e0refs/remotes/origin/master8b68d8a755879613e18a8994bf6b57c36830e5e08b68d8a755879613e18a8994bf6b57c36830e5e0refs/remotes/origin/masterhttps://github.com/larson-group/clubb.gitfalse#119820051596301clubb_timestep_gfortran_tests #119119false11915916SUCCESS1654675988001http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/119/src/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/turbulent_adv_pdf.F90src/CLUBB_core/advance_windm_edsclrm_module.F90src/CLUBB_core/advance_wp2_wp3_module.F90src/advance_microphys_module.F90src/CLUBB_core/mean_adv.F90src/CLUBB_core/mono_flux_limiter.F90src/CLUBB_core/diffusion.F90src/CLUBB_core/advance_xp2_xpyp_module.F9056f6445964cf3964975cc83560ef13c3084b868b1654647552000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comLots of small loop pushes 2022-06-07 19:19:12 -050056f6445964cf3964975cc83560ef13c3084b868bLots of small loop pusheseditsrc/CLUBB_core/mono_flux_limiter.F90editsrc/advance_microphys_module.F90editsrc/CLUBB_core/advance_wp2_wp3_module.F90editsrc/CLUBB_core/advance_xm_wpxp_module.F90editsrc/CLUBB_core/mean_adv.F90editsrc/CLUBB_core/turbulent_adv_pdf.F90editsrc/CLUBB_core/advance_windm_edsclrm_module.F90editsrc/CLUBB_core/advance_xp2_xpyp_module.F90editsrc/CLUBB_core/diffusion.F90src/CLUBB_core/mixing_length.F9016978e732df65afd3846a1627d4baed75712e4eb1654647552000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comSmall bug fix. This was not a bit changing bug, but could cause crashes if we compile with floating point trapping in a multicolumn run. 2022-06-07 19:19:12 -050016978e732df65afd3846a1627d4baed75712e4ebSmall bug fix. This was not a bit changing bug, but could cause crashes if we compile with floating point trapping in a multicolumn run.editsrc/CLUBB_core/mixing_length.F90src/CLUBB_core/mono_flux_limiter.F90543ba94e0a2a6c7fc6ab445a383e3d6b86aed7fb1654647552000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comSmall refactoring to mfl_xm_lhs, just removing need to pass in gr. 2022-06-07 19:19:12 -0500543ba94e0a2a6c7fc6ab445a383e3d6b86aed7fbSmall refactoring to mfl_xm_lhs, just removing need to pass in gr.editsrc/CLUBB_core/mono_flux_limiter.F90src/CLUBB_core/clubb_api_module.F90src/CLUBB_core/grid_class.F90265227c15e395f24014a0866811801619c01d3f71654647552000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comFinal loop pushes needed before the grid change. 2022-06-07 19:19:12 -0500265227c15e395f24014a0866811801619c01d3f7Final loop pushes needed before the grid change.editsrc/CLUBB_core/clubb_api_module.F90editsrc/CLUBB_core/grid_class.F90src/CLUBB_core/fill_holes.F90src/SILHS/latin_hypercube_driver_module.F9034ebd9e8a5a84097488a7cad9b8299c2d08171841654647552000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comReplacing use of gr with nz 2022-06-07 19:19:12 -050034ebd9e8a5a84097488a7cad9b8299c2d0817184Replacing use of gr with nzeditsrc/CLUBB_core/fill_holes.F90editsrc/SILHS/latin_hypercube_driver_module.F90src/advance_microphys_module.F908b68d8a755879613e18a8994bf6b57c36830e5e01654647552000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comChaning hardcoded 1 to i, where i is set to 1. Just a lil nicer. 2022-06-07 19:19:12 -05008b68d8a755879613e18a8994bf6b57c36830e5e0Chaning hardcoded 1 to i, where i is set to 1. Just a lil nicer.editsrc/advance_microphys_module.F90githttp://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwmfalse120http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/120/118http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/118/Started by an SCM change117ed85915bbcd00d1dba9b17752de763547bfa429bed85915bbcd00d1dba9b17752de763547bfa429brefs/remotes/origin/mastered85915bbcd00d1dba9b17752de763547bfa429bed85915bbcd00d1dba9b17752de763547bfa429brefs/remotes/origin/mastered85915bbcd00d1dba9b17752de763547bfa429bed85915bbcd00d1dba9b17752de763547bfa429brefs/remotes/origin/masterhttps://github.com/larson-group/clubb.gitfalse#1172587000596301clubb_timestep_gfortran_tests #117117false11715722SUCCESS1654157587488http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/117/jenkins_tests/clubb_bin_diff_regression_gfortran_test/Jenkinsfilejenkins_tests/clubb_bin_diff_regression_gfortran_test_new/Jenkinsfilejenkins_tests/clubb_bin_diff_regression_gfortran_test_old/Jenkinsfiled3e945d16e887b46b07827c135f73d33831fa9001654109323000http://carson.math.uwm.edu/jenkins/user/pbroelspbroelspbroels@uwm.eduChanged clubb_bin_diff_regression_gfortran_test_new to clubb_bin_diff_regression_gfortran_test and clubb_bin_diff_regression_gfortran_test to clubb_bin_diff_regression_gfortran_test_old to reflect current usage. 2022-06-01 13:48:43 -0500d3e945d16e887b46b07827c135f73d33831fa900Changed clubb_bin_diff_regression_gfortran_test_new to clubb_bin_diff_regression_gfortran_test and clubb_bin_diff_regression_gfortran_test to clubb_bin_diff_regression_gfortran_test_old to reflect current usage.addjenkins_tests/clubb_bin_diff_regression_gfortran_test_old/Jenkinsfileeditjenkins_tests/clubb_bin_diff_regression_gfortran_test/Jenkinsfiledeletejenkins_tests/clubb_bin_diff_regression_gfortran_test_new/JenkinsfileREADME291e87da51321a48b5c9d5c46e6b4459b51ab2a41654109959000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comThis commit is not bit changing 2022-06-01 13:59:19 -0500291e87da51321a48b5c9d5c46e6b4459b51ab2a4This commit is not bit changingeditREADMEREADME0ff480f574ef756272df942a2cd6e217fba760e21654110299000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comThis commt is not bit changing But commit e4f125ba067ba8083f917e0e06b6b2398483d3e4 was BIT_CHANGING for simulations that use silhs 2022-06-01 14:04:59 -05000ff480f574ef756272df942a2cd6e217fba760e2This commt is not bit changingeditREADMEsrc/G_unit_test_types/pdf_parameter_tests.F90src/CLUBB_core/new_hybrid_pdf_main.F90src/CLUBB_core/new_pdf_main.F90src/G_unit_test_types/spurious_source_test.F90aa26820b4f080d4a8721dd0f578737344061f9a31654112656000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduThe G_unit tests never allocated pdf_implicit_coefs_terms. It's unclear to me how these were working before, but it seems that something about making these 2D allocatable arrays exposed the bug. 2022-06-01 14:44:16 -0500aa26820b4f080d4a8721dd0f578737344061f9a3The G_unit tests never allocated pdf_implicit_coefs_terms. It's unclear to me how these were working before, but it seems that something about making these 2D allocatable arrays exposed the bug.editsrc/G_unit_test_types/pdf_parameter_tests.F90editsrc/CLUBB_core/new_hybrid_pdf_main.F90editsrc/CLUBB_core/new_pdf_main.F90editsrc/G_unit_test_types/spurious_source_test.F90src/CLUBB_core/advance_xp2_xpyp_module.F90b736467752bbdc37c77ea2504d0b4ffcc7383ac81654117361000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking zt2zm calls with pdf_implicit_coefs_terms use the 2D version. 2022-06-01 16:02:41 -0500b736467752bbdc37c77ea2504d0b4ffcc7383ac8Making zt2zm calls with pdf_implicit_coefs_terms use the 2D version.editsrc/CLUBB_core/advance_xp2_xpyp_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/clubb_api_module.F90src/clubb_driver.F908b9b43ecb1c82b2a06882613bbe7e2e61b86e0af1654122180000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduRemoving setup_grid and setup_parameters functionality from setup_clubb_core. This is beacuse in host models the required grid information may not be known during the setup process, resulting in dummy arguments for setup_clubb_core and the grid and paramters being setup during runtime anyway. Now, in the host models we can call these subroutines immediately after setup_clubb_core to maintain identical functionality (sam, wrf), and in others we can wait to call these until the main timestepping procedure (cam,e3sm). 2022-06-01 17:23:00 -05008b9b43ecb1c82b2a06882613bbe7e2e61b86e0afRemoving setup_grid and setup_parameters functionality from setup_clubb_core. This is beacuse in host models the required grid information may not be known during the setup process, resulting in dummy arguments for setup_clubb_core and the grid and paramters being setup during runtime anyway. Now, in the host models we can call these subroutines immediately after setup_clubb_core to maintain identical functionality (sam, wrf), and in others we can wait to call these until the main timestepping procedure (cam,e3sm).editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/clubb_driver.F90editsrc/CLUBB_core/clubb_api_module.F90src/CLUBB_core/parameters_tunable.F90src/G_unit_test_types/spurious_source_test.F90src/CLUBB_core/clubb_api_module.F90src/CLUBB_core/grid_class.F90ed85915bbcd00d1dba9b17752de763547bfa429b1654129942000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking 2D versions of setup_grid and setup_parameters. 2022-06-01 19:32:22 -0500ed85915bbcd00d1dba9b17752de763547bfa429bMaking 2D versions of setup_grid and setup_parameters.editsrc/CLUBB_core/clubb_api_module.F90editsrc/CLUBB_core/parameters_tunable.F90editsrc/G_unit_test_types/spurious_source_test.F90editsrc/CLUBB_core/grid_class.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhttp://carson.math.uwm.edu/jenkins/user/pbroelspbroelsfalse118http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/118/116http://carson.math.uwm.edu/jenkins/job/clubb_timestep_gfortran_tests/116/