Started by an SCM change11712407142b14155687d0d80b174796965d2793b1212407142b14155687d0d80b174796965d2793b12origin/master12407142b14155687d0d80b174796965d2793b1212407142b14155687d0d80b174796965d2793b12origin/master101b19b67713baf175f99baa0cb0bdde6e8c1fbc588b19b67713baf175f99baa0cb0bdde6e8c1fbc588origin/grid_fixesb19b67713baf175f99baa0cb0bdde6e8c1fbc588b19b67713baf175f99baa0cb0bdde6e8c1fbc588origin/grid_fixes96b928767c7238139d599dc55420d2a0956161726ab928767c7238139d599dc55420d2a0956161726aorigin/feeding_gr_to_hostb928767c7238139d599dc55420d2a0956161726ab928767c7238139d599dc55420d2a0956161726aorigin/feeding_gr_to_host65773dc365c77ab4bf2405d753f167307ae9be330a073dc365c77ab4bf2405d753f167307ae9be330a0refs/remotes/origin/master73dc365c77ab4bf2405d753f167307ae9be330a073dc365c77ab4bf2405d753f167307ae9be330a0refs/remotes/origin/master73dc365c77ab4bf2405d753f167307ae9be330a073dc365c77ab4bf2405d753f167307ae9be330a0refs/remotes/origin/masterhttps://github.com/larson-group/clubb.githttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_timestep_convergence_gfortran_test/detail/clubb_timestep_convergence_gfortran_test/657/artifactshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_timestep_convergence_gfortran_test/detail/clubb_timestep_convergence_gfortran_test/657/changeshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_timestep_convergence_gfortran_test/detail/clubb_timestep_convergence_gfortran_test/657/http://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_timestep_convergence_gfortran_test/detail/clubb_timestep_convergence_gfortran_test/657/testsfalseCompileRun the CLUBB convergence test scriptfalse#657124453129915clubb_timestep_convergence_gfortran_test #657657false6574002SUCCESS1779955209617http://carson.math.uwm.edu/jenkins/job/clubb_timestep_convergence_gfortran_test/657/src/CLUBB_core/advance_clubb_core_module.F9073dc365c77ab4bf2405d753f167307ae9be330a01779907751000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduRemoving unneccesary wp2_zt conversion that should've been removed already, but was accidentally added back in the last PR when trying to split BFB from non-BFB changes. This was an unused local variable so this does not affect anything. 2026-05-27 13:49:11 -050073dc365c77ab4bf2405d753f167307ae9be330a0Removing unneccesary wp2_zt conversion that should've been removed already, but was accidentally added back in the last PR when trying to split BFB from non-BFB changes. This was an unused local variable so this does not affect anything.editsrc/CLUBB_core/advance_clubb_core_module.F90githttp://carson.math.uwm.edu/jenkins/user/hueblerGunther HueblerhueblerfalseStarted by an SCM change11712407142b14155687d0d80b174796965d2793b1212407142b14155687d0d80b174796965d2793b12origin/master12407142b14155687d0d80b174796965d2793b1212407142b14155687d0d80b174796965d2793b12origin/master101b19b67713baf175f99baa0cb0bdde6e8c1fbc588b19b67713baf175f99baa0cb0bdde6e8c1fbc588origin/grid_fixesb19b67713baf175f99baa0cb0bdde6e8c1fbc588b19b67713baf175f99baa0cb0bdde6e8c1fbc588origin/grid_fixes96b928767c7238139d599dc55420d2a0956161726ab928767c7238139d599dc55420d2a0956161726aorigin/feeding_gr_to_hostb928767c7238139d599dc55420d2a0956161726ab928767c7238139d599dc55420d2a0956161726aorigin/feeding_gr_to_host658fb12cc1c0be895d2db030ceed981bc5121277b0efb12cc1c0be895d2db030ceed981bc5121277b0erefs/remotes/origin/masterfb12cc1c0be895d2db030ceed981bc5121277b0efb12cc1c0be895d2db030ceed981bc5121277b0erefs/remotes/origin/masterfb12cc1c0be895d2db030ceed981bc5121277b0efb12cc1c0be895d2db030ceed981bc5121277b0erefs/remotes/origin/masterhttps://github.com/larson-group/clubb.gitfalse#658131694129915clubb_timestep_convergence_gfortran_test #658658false6584102SUCCESS1780041609657http://carson.math.uwm.edu/jenkins/job/clubb_timestep_convergence_gfortran_test/658/READMEfb12cc1c0be895d2db030ceed981bc5121277b0e1779992322000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduThe last commit should've been marked as non-BFB since it corrected a crashing bug - so comparing output to no output caused the output to be considered different. This was missed because the BFB checking tests didn't fail, and that was because the commit that caused the crashing was marked non-BFB, so an unusual combo. In general though any commit that fixes crashing behavior should be labelled as bit changing. RESOLVED:73dc365c77ab4bf2405d753f167307ae9be330a0 2026-05-28 13:18:42 -0500fb12cc1c0be895d2db030ceed981bc5121277b0eThe last commit should've been marked as non-BFB since it corrected a crashing bug - so comparing output to no output caused the output to be considered different. This was missed because the BFB checking tests didn't fail, and that was because the commit that caused the crashing was marked non-BFB, so an unusual combo. In general though any commit that fixes crashing behavior should be labelled as bit changing. RESOLVED:73dc365c77ab4bf2405d753f167307ae9be330a0editREADMEgithttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse657http://carson.math.uwm.edu/jenkins/job/clubb_timestep_convergence_gfortran_test/657/Started by an SCM change11712407142b14155687d0d80b174796965d2793b1212407142b14155687d0d80b174796965d2793b12origin/master12407142b14155687d0d80b174796965d2793b1212407142b14155687d0d80b174796965d2793b12origin/master101b19b67713baf175f99baa0cb0bdde6e8c1fbc588b19b67713baf175f99baa0cb0bdde6e8c1fbc588origin/grid_fixesb19b67713baf175f99baa0cb0bdde6e8c1fbc588b19b67713baf175f99baa0cb0bdde6e8c1fbc588origin/grid_fixes96b928767c7238139d599dc55420d2a0956161726ab928767c7238139d599dc55420d2a0956161726aorigin/feeding_gr_to_hostb928767c7238139d599dc55420d2a0956161726ab928767c7238139d599dc55420d2a0956161726aorigin/feeding_gr_to_host6567b5214a7a0382d3b5d2df0f7b8a8f11bd11f4bdb7b5214a7a0382d3b5d2df0f7b8a8f11bd11f4bdbrefs/remotes/origin/master7b5214a7a0382d3b5d2df0f7b8a8f11bd11f4bdb7b5214a7a0382d3b5d2df0f7b8a8f11bd11f4bdbrefs/remotes/origin/master7b5214a7a0382d3b5d2df0f7b8a8f11bd11f4bdb7b5214a7a0382d3b5d2df0f7b8a8f11bd11f4bdbrefs/remotes/origin/masterhttps://github.com/larson-group/clubb.gitfalse#656133597129915clubb_timestep_convergence_gfortran_test #656656false6563876SUCCESS1779868808804http://carson.math.uwm.edu/jenkins/job/clubb_timestep_convergence_gfortran_test/656/clubb_python_api/f2py_fortran_wrappers/advance_helper_module_wrapper.F90src/CLUBB_core/advance_wp2_wp3_module.F90src/CLUBB_core/advance_xp3_module.F90clubb_jax/advance_clubb_core.pyclubb_python_api/clubb_python/clubb_api.pyclubb_python_api/clubb_python/CLUBB_core/stats_clubb_utilities.pyclubb_python_api/f2py_fortran_wrappers/advance_wp2_wp3_module_wrapper.F90clubb_python_driver/advance_clubb_core.pyclubb_python_api/clubb_python/CLUBB_core/advance_helper.pysrc/CLUBB_core/stats_clubb_utilities.F90clubb_python_api/tests/test_call_tree_advance_wp2_wp3.pyclubb_python_api/clubb_python/CLUBB_core/advance_xm_wpxp.pysrc/CLUBB_core/advance_helper_module.F90clubb_python_api/tests/test_call_tree_advance_xm_wpxp.pyclubb_python_api/clubb_python/CLUBB_core/advance_wp2_wp3.pyclubb_python_api/f2py_fortran_wrappers/stats_clubb_utilities_wrapper.F90src/G_unit_test_types/spurious_source_test.F90clubb_python_api/f2py_fortran_wrappers/advance_xm_wpxp_module_wrapper.F90clubb_python_api/f2py_fortran_wrappers/advance_xp2_xpyp_module_wrapper.F90clubb_python_api/tests/test_call_tree_advance_xp3.pyclubb_python_api/tests/test_call_tree_advance_xp2_xpyp.pysrc/CLUBB_core/advance_xp2_xpyp_module.F90src/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/advance_clubb_core_module.F90clubb_python_api/clubb_python/CLUBB_core/advance_xp3.pyclubb_python_api/tests/test_call_tree_stats_accumulate.pyclubb_python_api/clubb_f2py.pyfclubb_python_api/clubb_python/CLUBB_core/advance_xp2_xpyp.py7b5214a7a0382d3b5d2df0f7b8a8f11bd11f4bdb1779832578000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comClubb organization part2 (#1304) A number of fields were being calculated in `advance_clubb_core` (`wp2_zt` `wp3_on_wp2` `wp3_on_wp2_zt` `Skw_zm` `Skw_zt) then passed into other routines, however, all these fields depend on `wp2` and were not being updated after `wp2` was being updated by `calc_sfc_varnce`. This commit fixes that by moving where these fields are calculated - instead of computing in `advance_clubb_core` with the incoming `wp2`, we now calculate them "on-demand" where they are needed using the most recent value of `wp2`. Using our default flag set, there are no numerical differences caused by this change set, only a few stats differences. There are real differences that occur when `l_upwind_xpyp_ta = .false.` (a clubb_config_flag value) or when `l_explicit_turbulent_adv_xpyp = .true.` (a parameter in model_flags.F90), but these are small differences and do not visually affect plots for our stable cases. Changing the order of the `advance_` routines would also cause this to be BIT_CHANGING, since that also affects the update path for `wp2` - now these values that got moved would be using the newest `wp2` instead of being "stale", also causing small (but real) differences. * Calculating wp2_zt and wp3_on_wp2 where needed, rather than passing those values around through advance_clubb_core. This is BIT_CHANGING for a handful of stats only variables be default: wp3_on_wp2, wp3_on_wp2_zt, wp3_on_wp2_cfl_num, term_wprtp2_explicit, term_wprtpthlp_explicit, and term_wpthlp2_explicit. Some Skw_ variables when using lmm_stepping, and has actual differences (not just in stats output) when swapping the order of the advance routines * Moving things around, this seems to all be BFB except for the Skw_ movements, which is BIT_CHANGING if the advance_ order changes * Fixing python API * Reverting some BFB changes 2026-05-26 16:56:18 -05007b5214a7a0382d3b5d2df0f7b8a8f11bd11f4bdbClubb organization part2 (#1304)editclubb_python_api/clubb_python/CLUBB_core/advance_xp2_xpyp.pyeditsrc/CLUBB_core/advance_wp2_wp3_module.F90editclubb_python_api/f2py_fortran_wrappers/advance_wp2_wp3_module_wrapper.F90editclubb_python_api/clubb_python/CLUBB_core/advance_wp2_wp3.pyeditclubb_python_api/f2py_fortran_wrappers/stats_clubb_utilities_wrapper.F90editclubb_python_api/tests/test_call_tree_advance_xp2_xpyp.pyeditclubb_python_api/clubb_python/CLUBB_core/advance_xp3.pyeditclubb_python_api/clubb_python/CLUBB_core/stats_clubb_utilities.pyeditclubb_python_api/clubb_python/CLUBB_core/advance_xm_wpxp.pyeditclubb_python_api/tests/test_call_tree_stats_accumulate.pyeditclubb_python_api/tests/test_call_tree_advance_wp2_wp3.pyeditsrc/CLUBB_core/advance_xm_wpxp_module.F90editclubb_python_api/f2py_fortran_wrappers/advance_helper_module_wrapper.F90editclubb_python_api/f2py_fortran_wrappers/advance_xp2_xpyp_module_wrapper.F90editclubb_python_api/clubb_python/CLUBB_core/advance_helper.pyeditclubb_python_driver/advance_clubb_core.pyeditclubb_python_api/tests/test_call_tree_advance_xm_wpxp.pyeditsrc/CLUBB_core/advance_clubb_core_module.F90editclubb_python_api/clubb_python/clubb_api.pyeditclubb_python_api/f2py_fortran_wrappers/advance_xm_wpxp_module_wrapper.F90editsrc/CLUBB_core/advance_helper_module.F90editclubb_jax/advance_clubb_core.pyeditsrc/G_unit_test_types/spurious_source_test.F90editclubb_python_api/clubb_f2py.pyfeditclubb_python_api/tests/test_call_tree_advance_xp3.pyeditsrc/CLUBB_core/advance_xp2_xpyp_module.F90editsrc/CLUBB_core/stats_clubb_utilities.F90editsrc/CLUBB_core/advance_xp3_module.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse657http://carson.math.uwm.edu/jenkins/job/clubb_timestep_convergence_gfortran_test/657/655http://carson.math.uwm.edu/jenkins/job/clubb_timestep_convergence_gfortran_test/655/