{ "_class" : "org.jenkinsci.plugins.workflow.job.WorkflowRun", "actions" : [ { "_class" : "hudson.model.CauseAction", "causes" : [ { "_class" : "hudson.triggers.SCMTrigger$SCMTriggerCause", "shortDescription" : "Started by an SCM change" } ] }, { }, { "_class" : "org.jenkinsci.plugins.workflow.libs.LibrariesAction" }, { }, { }, { "_class" : "hudson.plugins.git.util.BuildData", "buildsByBranchName" : { "origin/master" : { "_class" : "hudson.plugins.git.util.Build", "buildNumber" : 108, "buildResult" : None, "marked" : { "SHA1" : "12407142b14155687d0d80b174796965d2793b12", "branch" : [ { "SHA1" : "12407142b14155687d0d80b174796965d2793b12", "name" : "origin/master" } ] }, "revision" : { "SHA1" : "12407142b14155687d0d80b174796965d2793b12", "branch" : [ { "SHA1" : "12407142b14155687d0d80b174796965d2793b12", "name" : "origin/master" } ] } }, "origin/grid_fixes" : { "_class" : "hudson.plugins.git.util.Build", "buildNumber" : 92, "buildResult" : None, "marked" : { "SHA1" : "b19b67713baf175f99baa0cb0bdde6e8c1fbc588", "branch" : [ { "SHA1" : "b19b67713baf175f99baa0cb0bdde6e8c1fbc588", "name" : "origin/grid_fixes" } ] }, "revision" : { "SHA1" : "b19b67713baf175f99baa0cb0bdde6e8c1fbc588", "branch" : [ { "SHA1" : "b19b67713baf175f99baa0cb0bdde6e8c1fbc588", "name" : "origin/grid_fixes" } ] } }, "origin/feeding_gr_to_host" : { "_class" : "hudson.plugins.git.util.Build", "buildNumber" : 87, "buildResult" : None, "marked" : { "SHA1" : "b928767c7238139d599dc55420d2a0956161726a", "branch" : [ { "SHA1" : "b928767c7238139d599dc55420d2a0956161726a", "name" : "origin/feeding_gr_to_host" } ] }, "revision" : { "SHA1" : "b928767c7238139d599dc55420d2a0956161726a", "branch" : [ { "SHA1" : "b928767c7238139d599dc55420d2a0956161726a", "name" : "origin/feeding_gr_to_host" } ] } }, "refs/remotes/origin/master" : { "_class" : "hudson.plugins.git.util.Build", "buildNumber" : 650, "buildResult" : None, "marked" : { "SHA1" : "7b5214a7a0382d3b5d2df0f7b8a8f11bd11f4bdb", "branch" : [ { "SHA1" : "7b5214a7a0382d3b5d2df0f7b8a8f11bd11f4bdb", "name" : "refs/remotes/origin/master" } ] }, "revision" : { "SHA1" : "7b5214a7a0382d3b5d2df0f7b8a8f11bd11f4bdb", "branch" : [ { "SHA1" : "7b5214a7a0382d3b5d2df0f7b8a8f11bd11f4bdb", "name" : "refs/remotes/origin/master" } ] } } }, "lastBuiltRevision" : { "SHA1" : "7b5214a7a0382d3b5d2df0f7b8a8f11bd11f4bdb", "branch" : [ { "SHA1" : "7b5214a7a0382d3b5d2df0f7b8a8f11bd11f4bdb", "name" : "refs/remotes/origin/master" } ] }, "remoteUrls" : [ "https://github.com/larson-group/clubb.git" ], "scmName" : "" }, { }, { "_class" : "org.jenkinsci.plugins.workflow.cps.EnvActionImpl" }, { }, { }, { }, { }, { "_class" : "org.jenkinsci.plugins.displayurlapi.actions.RunDisplayAction" }, { "_class" : "org.jenkinsci.plugins.pipeline.modeldefinition.actions.RestartDeclarativePipelineAction" }, { }, { "_class" : "org.jenkinsci.plugins.workflow.job.views.FlowGraphAction" }, { }, { }, { } ], "artifacts" : [ ], "building" : False, "description" : None, "displayName" : "#650", "duration" : 464412, "estimatedDuration" : 725696, "executor" : None, "fullDisplayName" : "clubb_silhs_convergence_gfortran #650", "id" : "650", "keepLog" : False, "number" : 650, "queueId" : 3920, "result" : "SUCCESS", "timestamp" : 1779870369232, "url" : "http://carson.math.uwm.edu/jenkins/job/clubb_silhs_convergence_gfortran/650/", "changeSets" : [ { "_class" : "hudson.plugins.git.GitChangeSetList", "items" : [ { "_class" : "hudson.plugins.git.GitChangeSet", "affectedPaths" : [ "clubb_python_api/f2py_fortran_wrappers/advance_helper_module_wrapper.F90", "src/CLUBB_core/advance_wp2_wp3_module.F90", "src/CLUBB_core/advance_xp3_module.F90", "clubb_jax/advance_clubb_core.py", "clubb_python_api/clubb_python/clubb_api.py", "clubb_python_api/clubb_python/CLUBB_core/stats_clubb_utilities.py", "clubb_python_api/f2py_fortran_wrappers/advance_wp2_wp3_module_wrapper.F90", "clubb_python_driver/advance_clubb_core.py", "clubb_python_api/clubb_python/CLUBB_core/advance_helper.py", "src/CLUBB_core/stats_clubb_utilities.F90", "clubb_python_api/tests/test_call_tree_advance_wp2_wp3.py", "clubb_python_api/clubb_python/CLUBB_core/advance_xm_wpxp.py", "src/CLUBB_core/advance_helper_module.F90", "clubb_python_api/tests/test_call_tree_advance_xm_wpxp.py", "clubb_python_api/clubb_python/CLUBB_core/advance_wp2_wp3.py", "src/G_unit_test_types/spurious_source_test.F90", "clubb_python_api/f2py_fortran_wrappers/stats_clubb_utilities_wrapper.F90", "clubb_python_api/f2py_fortran_wrappers/advance_xm_wpxp_module_wrapper.F90", "clubb_python_api/f2py_fortran_wrappers/advance_xp2_xpyp_module_wrapper.F90", "clubb_python_api/tests/test_call_tree_advance_xp3.py", "clubb_python_api/tests/test_call_tree_advance_xp2_xpyp.py", "src/CLUBB_core/advance_xp2_xpyp_module.F90", "src/CLUBB_core/advance_clubb_core_module.F90", "src/CLUBB_core/advance_xm_wpxp_module.F90", "clubb_python_api/clubb_python/CLUBB_core/advance_xp3.py", "clubb_python_api/tests/test_call_tree_stats_accumulate.py", "clubb_python_api/clubb_f2py.pyf", "clubb_python_api/clubb_python/CLUBB_core/advance_xp2_xpyp.py" ], "commitId" : "7b5214a7a0382d3b5d2df0f7b8a8f11bd11f4bdb", "timestamp" : 1779832578000, "author" : { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" }, "authorEmail" : "noreply@github.com", "comment" : "Clubb organization part2 (#1304)\u000a\u000aA number of fields were being calculated in `advance_clubb_core` (`wp2_zt` `wp3_on_wp2` `wp3_on_wp2_zt` `Skw_zm` `Skw_zt) then passed into other routines, however, all these fields depend on `wp2` and were not being updated after `wp2` was being updated by `calc_sfc_varnce`. This commit fixes that by moving where these fields are calculated - instead of computing in `advance_clubb_core` with the incoming `wp2`, we now calculate them \"on-demand\" where they are needed using the most recent value of `wp2`. \u000a\u000aUsing our default flag set, there are no numerical differences caused by this change set, only a few stats differences. There are real differences that occur when `l_upwind_xpyp_ta = .false.` (a clubb_config_flag value) or when `l_explicit_turbulent_adv_xpyp = .true.` (a parameter in model_flags.F90), but these are small differences and do not visually affect plots for our stable cases. Changing the order of the `advance_` routines would also cause this to be BIT_CHANGING, since that also affects the update path for `wp2` - now these values that got moved would be using the newest `wp2` instead of being \"stale\", also causing small (but real) differences.\u000a\u000a* Calculating wp2_zt and wp3_on_wp2 where needed, rather than passing those values around through advance_clubb_core. This is BIT_CHANGING for a handful of stats only variables be default: wp3_on_wp2, wp3_on_wp2_zt, wp3_on_wp2_cfl_num, term_wprtp2_explicit, term_wprtpthlp_explicit, and term_wpthlp2_explicit. Some Skw_ variables when using lmm_stepping, and has actual differences (not just in stats output) when swapping the order of the advance routines\u000a\u000a* Moving things around, this seems to all be BFB except for the Skw_ movements, which is BIT_CHANGING if the advance_ order changes\u000a\u000a* Fixing python API\u000a\u000a* Reverting some BFB changes\u000a", "date" : "2026-05-26 16:56:18 -0500", "id" : "7b5214a7a0382d3b5d2df0f7b8a8f11bd11f4bdb", "msg" : "Clubb organization part2 (#1304)", "paths" : [ { "editType" : "edit", "file" : "clubb_python_api/f2py_fortran_wrappers/advance_xm_wpxp_module_wrapper.F90" }, { "editType" : "edit", "file" : "clubb_python_api/tests/test_call_tree_advance_xp3.py" }, { "editType" : "edit", "file" : "clubb_python_api/tests/test_call_tree_advance_xp2_xpyp.py" }, { "editType" : "edit", "file" : "src/CLUBB_core/advance_wp2_wp3_module.F90" }, { "editType" : "edit", "file" : "src/CLUBB_core/advance_clubb_core_module.F90" }, { "editType" : "edit", "file" : "clubb_python_api/clubb_f2py.pyf" }, { "editType" : "edit", "file" : "src/CLUBB_core/advance_xm_wpxp_module.F90" }, { "editType" : "edit", "file" : "clubb_python_api/tests/test_call_tree_stats_accumulate.py" }, { "editType" : "edit", "file" : "clubb_python_api/tests/test_call_tree_advance_xm_wpxp.py" }, { "editType" : "edit", "file" : "clubb_python_api/clubb_python/CLUBB_core/advance_wp2_wp3.py" }, { "editType" : "edit", "file" : "src/G_unit_test_types/spurious_source_test.F90" }, { "editType" : "edit", "file" : "clubb_jax/advance_clubb_core.py" }, { "editType" : "edit", "file" : "clubb_python_api/f2py_fortran_wrappers/advance_xp2_xpyp_module_wrapper.F90" }, { "editType" : "edit", "file" : "clubb_python_api/tests/test_call_tree_advance_wp2_wp3.py" }, { "editType" : "edit", "file" : "clubb_python_api/f2py_fortran_wrappers/stats_clubb_utilities_wrapper.F90" }, { "editType" : "edit", "file" : "clubb_python_api/clubb_python/clubb_api.py" }, { "editType" : "edit", "file" : "src/CLUBB_core/advance_helper_module.F90" }, { "editType" : "edit", "file" : "clubb_python_api/clubb_python/CLUBB_core/advance_xp2_xpyp.py" }, { "editType" : "edit", "file" : "clubb_python_api/clubb_python/CLUBB_core/advance_xp3.py" }, { "editType" : "edit", "file" : "clubb_python_api/clubb_python/CLUBB_core/advance_helper.py" }, { "editType" : "edit", "file" : "clubb_python_api/clubb_python/CLUBB_core/stats_clubb_utilities.py" }, { "editType" : "edit", "file" : "src/CLUBB_core/stats_clubb_utilities.F90" }, { "editType" : "edit", "file" : "clubb_python_api/f2py_fortran_wrappers/advance_helper_module_wrapper.F90" }, { "editType" : "edit", "file" : "clubb_python_api/clubb_python/CLUBB_core/advance_xm_wpxp.py" }, { "editType" : "edit", "file" : "src/CLUBB_core/advance_xp2_xpyp_module.F90" }, { "editType" : "edit", "file" : "src/CLUBB_core/advance_xp3_module.F90" }, { "editType" : "edit", "file" : "clubb_python_driver/advance_clubb_core.py" }, { "editType" : "edit", "file" : "clubb_python_api/f2py_fortran_wrappers/advance_wp2_wp3_module_wrapper.F90" } ] } ], "kind" : "git" } ], "culprits" : [ { "absoluteUrl" : "http://carson.math.uwm.edu/jenkins/user/noreply", "fullName" : "noreply" } ], "inProgress" : False, "nextBuild" : None, "previousBuild" : { "number" : 649, "url" : "http://carson.math.uwm.edu/jenkins/job/clubb_silhs_convergence_gfortran/649/" } }