Started by an SCM change777783e3a73fe5643538f55dea8418c8adf0d0e4f87783e3a73fe5643538f55dea8418c8adf0d0e4f8refs/remotes/origin/master7783e3a73fe5643538f55dea8418c8adf0d0e4f87783e3a73fe5643538f55dea8418c8adf0d0e4f8refs/remotes/origin/master7783e3a73fe5643538f55dea8418c8adf0d0e4f87783e3a73fe5643538f55dea8418c8adf0d0e4f8refs/remotes/origin/masterhttps://github.com/larson-group/clubb.githttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_plot_nvhpc_gpu_vs_cpu/detail/clubb_plot_nvhpc_gpu_vs_cpu/77/artifactshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_plot_nvhpc_gpu_vs_cpu/detail/clubb_plot_nvhpc_gpu_vs_cpu/77/changeshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_plot_nvhpc_gpu_vs_cpu/detail/clubb_plot_nvhpc_gpu_vs_cpu/77/http://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_plot_nvhpc_gpu_vs_cpu/detail/clubb_plot_nvhpc_gpu_vs_cpu/77/testsfalsefalse#7720615792843091clubb_plot_nvhpc_gpu_vs_cpu #7777false776918SUCCESS1740128767601http://carson.math.uwm.edu/jenkins/job/clubb_plot_nvhpc_gpu_vs_cpu/77/src/CLUBB_core/clubb_api_module.F90src/CLUBB_core/error_code.F90src/clubb_driver.F90327bc1e35f9f2f5c9e58dadab76aa8a4452f711b1740075254000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRevert clubb api module changes (#1228) * Revert intent changes to err_code_api in clubb_api_module to stay consistent with host models CLUBB ticket #975 Reverted changes in advance_clubb_core_api and to corresponding call in run_clubb Since the module variable is not used anywhere anymore, we can also remove it from the module 2025-02-20 12:14:14 -0600327bc1e35f9f2f5c9e58dadab76aa8a4452f711bRevert clubb api module changes (#1228)editsrc/CLUBB_core/clubb_api_module.F90editsrc/clubb_driver.F90editsrc/CLUBB_core/error_code.F90src/CLUBB_core/pdf_closure_module.F90455fbc12e83f4475429afcff526571537f9be66a1740078773000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comFixed equality check in pdf_closure_module (#1229) CLUBB ticket #975 WRF detected this error. Fixed it. 2025-02-20 13:12:53 -0600455fbc12e83f4475429afcff526571537f9be66aFixed equality check in pdf_closure_module (#1229)editsrc/CLUBB_core/pdf_closure_module.F90src/CLUBB_core/interpolation.F90src/G_unit_test_types/spurious_source_test.F90src/CLUBB_core/model_flags.F90src/clubb_driver.F90src/time_dependent_input.F90src/Benchmark_cases/atex.F90input/grid/31_level_zm_grid_physics9.grdsrc/G_unit_test_types/pdf_parameter_tests.F90input/tunable_parameters/configurable_model_flags.insrc/CLUBB_core/grid_adaptation.F90src/clubb_tuner.F907783e3a73fe5643538f55dea8418c8adf0d0e4f81740100234000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comadd dycore grid with conservative remapping scheme * add tunable parameter interp_from_dycore_grid_method * add dycore interpolation to atex case with conservative remapping by ullrich * remove new gpu commands * add acc annotation for gpu * remove acc annotation again * add acc annotation for parallel loop * add acc annotations for parallel loop execution * change remapping subroutine to take number of levels and levels as input instead of whole grid object * add more general functions to interpolate * add and refactor functions for remapping values given on zm levels * fix compiler errors and refactoring to stay under 100 chars per line * remove TODOs and used new interpolating function in interpolate_forcings * add functions for adaptive grid generation and grid density function normalization * add conservative ullrich remapping to cases with forcing time dependent inputs * add grid adaptation and flag * clean up and add warning for case when remapping from dycore flag cannot be used * some refactoring * add logical flag for dycore and renamed flags for dycore and grid adaptation * remove ifdefs * refactoring * add units * changed Lscale to inverse --------- Co-authored-by: Steffen Carstensen <steffenc34@icloud.com> 2025-02-20 19:10:34 -06007783e3a73fe5643538f55dea8418c8adf0d0e4f8add dycore grid with conservative remapping schemeeditinput/tunable_parameters/configurable_model_flags.ineditsrc/G_unit_test_types/spurious_source_test.F90editsrc/Benchmark_cases/atex.F90editsrc/G_unit_test_types/pdf_parameter_tests.F90editsrc/clubb_tuner.F90editsrc/CLUBB_core/model_flags.F90addsrc/CLUBB_core/grid_adaptation.F90editsrc/clubb_driver.F90addinput/grid/31_level_zm_grid_physics9.grdeditsrc/time_dependent_input.F90editsrc/CLUBB_core/interpolation.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreplyfalseStarted by an SCM change78808fa5089e30e9a5a569f2fda50a334d04d33c71808fa5089e30e9a5a569f2fda50a334d04d33c71refs/remotes/origin/master808fa5089e30e9a5a569f2fda50a334d04d33c71808fa5089e30e9a5a569f2fda50a334d04d33c71refs/remotes/origin/master808fa5089e30e9a5a569f2fda50a334d04d33c71808fa5089e30e9a5a569f2fda50a334d04d33c71refs/remotes/origin/masterhttps://github.com/larson-group/clubb.gitfalse#7823741072843091clubb_plot_nvhpc_gpu_vs_cpu #7878false787011SUCCESS1740215166493http://carson.math.uwm.edu/jenkins/job/clubb_plot_nvhpc_gpu_vs_cpu/78/src/time_dependent_input.F90src/clubb_driver.F90236d6123c9d941c1d713c80143f3bd00ff462c951740168767000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comfix variable l_sfc_already_initialized (#1231) 2025-02-21 14:12:47 -0600236d6123c9d941c1d713c80143f3bd00ff462c95fix variable l_sfc_already_initialized (#1231)editsrc/time_dependent_input.F90editsrc/clubb_driver.F90src/CLUBB_core/mono_flux_limiter.F904b242c02eac785410f827436d822838d769516731740172850000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduGetting rid of a couple of worthless lines of code. It's possible this changes an output stat, making this commit BIT_CHANGING, but not actually answer changing. 2025-02-21 15:20:50 -06004b242c02eac785410f827436d822838d76951673Getting rid of a couple of worthless lines of code. It's possible thiseditsrc/CLUBB_core/mono_flux_limiter.F90src/CLUBB_core/mono_flux_limiter.F90808fa5089e30e9a5a569f2fda50a334d04d33c711740172965000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduShould just delete instead of commenting out. 2025-02-21 15:22:45 -0600808fa5089e30e9a5a569f2fda50a334d04d33c71Should just delete instead of commenting out.editsrc/CLUBB_core/mono_flux_limiter.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse79http://carson.math.uwm.edu/jenkins/job/clubb_plot_nvhpc_gpu_vs_cpu/79/77http://carson.math.uwm.edu/jenkins/job/clubb_plot_nvhpc_gpu_vs_cpu/77/Started by an SCM change760e45d985bab99301c6ca49bbcf69e52109d675500e45d985bab99301c6ca49bbcf69e52109d67550refs/remotes/origin/master0e45d985bab99301c6ca49bbcf69e52109d675500e45d985bab99301c6ca49bbcf69e52109d67550refs/remotes/origin/master0e45d985bab99301c6ca49bbcf69e52109d675500e45d985bab99301c6ca49bbcf69e52109d67550refs/remotes/origin/masterhttps://github.com/larson-group/clubb.gitfalse#7620199692843091clubb_plot_nvhpc_gpu_vs_cpu #7676false766793SUCCESS1740042368428http://carson.math.uwm.edu/jenkins/job/clubb_plot_nvhpc_gpu_vs_cpu/76/src/CLUBB_core/advance_wp2_wp3_module.F90src/CLUBB_core/pdf_closure_module.F90src/CLUBB_core/grid_class.F90src/Benchmark_cases/atex.F90src/CLUBB_core/sfc_varnce_module.F90src/CLUBB_core/error_code.F90src/CLUBB_core/mixing_length.F90src/CLUBB_core/advance_windm_edsclrm_module.F90src/clubb_standalone.F90src/CLUBB_core/output_netcdf.F90src/advance_microphys_module.F90src/CLUBB_core/stats_clubb_utilities.F90src/CLUBB_core/mono_flux_limiter.F90src/CLUBB_core/parameters_tunable.F90src/G_unit_test_types/spurious_source_test.F90src/clubb_thread_test.F90src/CLUBB_core/numerical_check.F90src/CLUBB_core/lapack_wrap.F90src/CLUBB_core/precipitation_fraction.F90src/CLUBB_core/advance_xp2_xpyp_module.F90src/SILHS/output_2D_samples_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_xm_wpxp_module.F90src/jacobian.F90src/CLUBB_core/matrix_solver_wrapper.F90src/simple_rad_module.F90src/clubb_driver.F90src/CLUBB_core/clubb_api_module.F90src/CLUBB_core/corr_varnce_module.F90src/CLUBB_core/setup_clubb_pdf_params.F90src/error.F90c7ac128837133579e64d46c7be3fe907a5d6840d1739985373000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRemove err code (#1218) CLUBB ticket #975 Module variable `err_code` was removed and replaced by intent(inout) subroutine parameters. Added messages to `error stop`s in `clubb_api_module` 2025-02-19 11:16:13 -0600c7ac128837133579e64d46c7be3fe907a5d6840dRemove err code (#1218)editsrc/CLUBB_core/advance_windm_edsclrm_module.F90editsrc/error.F90editsrc/CLUBB_core/error_code.F90editsrc/CLUBB_core/output_netcdf.F90editsrc/clubb_standalone.F90editsrc/G_unit_test_types/spurious_source_test.F90editsrc/Benchmark_cases/atex.F90editsrc/CLUBB_core/advance_wp2_wp3_module.F90editsrc/CLUBB_core/advance_xp2_xpyp_module.F90editsrc/CLUBB_core/sfc_varnce_module.F90editsrc/SILHS/output_2D_samples_module.F90editsrc/clubb_thread_test.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/clubb_api_module.F90editsrc/CLUBB_core/pdf_closure_module.F90editsrc/CLUBB_core/mixing_length.F90editsrc/jacobian.F90editsrc/CLUBB_core/grid_class.F90editsrc/CLUBB_core/corr_varnce_module.F90editsrc/CLUBB_core/advance_xm_wpxp_module.F90editsrc/advance_microphys_module.F90editsrc/CLUBB_core/lapack_wrap.F90editsrc/simple_rad_module.F90editsrc/CLUBB_core/mono_flux_limiter.F90editsrc/CLUBB_core/precipitation_fraction.F90editsrc/CLUBB_core/stats_clubb_utilities.F90editsrc/CLUBB_core/matrix_solver_wrapper.F90editsrc/CLUBB_core/numerical_check.F90editsrc/CLUBB_core/setup_clubb_pdf_params.F90editsrc/CLUBB_core/parameters_tunable.F90editsrc/clubb_driver.F90src/CLUBB_core/numerical_check.F900e45d985bab99301c6ca49bbcf69e52109d675501739987333000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRenamed check_res to err_code in numerical_check.F90 for consistency (#1227) 2025-02-19 11:48:53 -06000e45d985bab99301c6ca49bbcf69e52109d67550Renamed check_res to err_code in numerical_check.F90 for consistency (#1227)editsrc/CLUBB_core/numerical_check.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse77http://carson.math.uwm.edu/jenkins/job/clubb_plot_nvhpc_gpu_vs_cpu/77/75http://carson.math.uwm.edu/jenkins/job/clubb_plot_nvhpc_gpu_vs_cpu/75/