Started by an SCM change12912407142b14155687d0d80b174796965d2793b1212407142b14155687d0d80b174796965d2793b12origin/master12407142b14155687d0d80b174796965d2793b1212407142b14155687d0d80b174796965d2793b12origin/master113b19b67713baf175f99baa0cb0bdde6e8c1fbc588b19b67713baf175f99baa0cb0bdde6e8c1fbc588origin/grid_fixesb19b67713baf175f99baa0cb0bdde6e8c1fbc588b19b67713baf175f99baa0cb0bdde6e8c1fbc588origin/grid_fixes108b928767c7238139d599dc55420d2a0956161726ab928767c7238139d599dc55420d2a0956161726aorigin/feeding_gr_to_hostb928767c7238139d599dc55420d2a0956161726ab928767c7238139d599dc55420d2a0956161726aorigin/feeding_gr_to_host534876a5a7674acbc3609a50dfeb45e791acee01583876a5a7674acbc3609a50dfeb45e791acee01583refs/remotes/origin/master876a5a7674acbc3609a50dfeb45e791acee01583876a5a7674acbc3609a50dfeb45e791acee01583refs/remotes/origin/master876a5a7674acbc3609a50dfeb45e791acee01583876a5a7674acbc3609a50dfeb45e791acee01583refs/remotes/origin/masterhttps://github.com/larson-group/clubb.git53477c39da06b9b1cf4575bed4d1ac77ae6f4be24d177c39da06b9b1cf4575bed4d1ac77ae6f4be24d1refs/remotes/origin/master77c39da06b9b1cf4575bed4d1ac77ae6f4be24d177c39da06b9b1cf4575bed4d1ac77ae6f4be24d1refs/remotes/origin/master77c39da06b9b1cf4575bed4d1ac77ae6f4be24d177c39da06b9b1cf4575bed4d1ac77ae6f4be24d1refs/remotes/origin/masterhttps://github.com/larson-group/sys_adminfalse#5344217401912456clubb_fire_tuning_gfortran_test #534534false534850SUCCESS1721291769388http://carson.math.uwm.edu/jenkins/job/clubb_fire_tuning_gfortran_test/534/src/SILHS/latin_hypercube_driver_module.F901cb88726a7f824b8844fe32eff22b09991b8de6c1721242346000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduThere were furhter issues found with the k_lh_start code. The code would find that sometimes, the maximum location of rcm in cloud would occur at the ghost level, k = 1, and set that level as k_lh_start for SILHS. This is undesirable for two reasons: 1) k_lh_start should be set around a legimate, "within domain" grid level; and 2) Setting k_lh_start to 1 is unachievable for the ghostless branch of the model, making a match between the master and clubb_ghost_exorcism branhes unattainable. The issue is corrected here by allowing the maxloc function to only search over "in-domain levels" for maximum cloud. The results are BIT_CHANGING. 2024-07-17 13:52:26 -05001cb88726a7f824b8844fe32eff22b09991b8de6cThere were furhter issues found with the k_lh_start code.editsrc/SILHS/latin_hypercube_driver_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_helper_module.F90src/CLUBB_core/mixing_length.F90acdd31a8d397f5a8874cba8023e9376fe1d9e6511721258040000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRi_zm calc (Part 3) - Moving calculations for Ri_zm out of diagnose_Lscale_from_taus (#1157) CLUBB tocket #1145 BIT_CHANGING for lscale since Ri_zm was not calculated before. 1. mixing_length.F90: - Removed unused input variables from diagnose_Lscale_from_taus: um, vm, exner, p_in_Pa, rtm, thlm, thvm, rcm, saturation_formula, l_brunt_vaisala_freq_moist, l_use_thvm_in_bv_freq, l_modify_limiters_for_cnvg_test; added ddzt_umvm_sqd as input; changed Ri_zm from out to in - Removed unused brunt_vaisala_freq_sqd variables from diagnose_Lscale_from_tau - Removed calculations for Ri_zm and ddzt_umvm_sqd - Fixed some line length issues 2. advance_helper_module.F90 - Removed unused input variables and imports - Fixed some line length issues 3. advance_clubb_core_module.F90 - Added calculations for ddzt_umvm_sqd and Ri_zm - Adjusted subroutine calls - Fixed some line length issues 2024-07-17 18:14:00 -0500acdd31a8d397f5a8874cba8023e9376fe1d9e651Ri_zm calc (Part 3) - Moving calculations for Ri_zm out of diagnose_Lscale_from_taus (#1157)editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/advance_helper_module.F90editsrc/CLUBB_core/mixing_length.F90src/SILHS/latin_hypercube_driver_module.F90370b85fd1991810e0a1dec311f66ad10fa92275f1721277738000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduIn my previous commit, I changed the domain of the maxloc commands in the computation of k_lh_start to check over the arrays from levels 2:nz. However, when that happens, the output will be offset by 1. Consider a situation where the rcm max is at level 2. By being passed 2 through nz only, maxloc will return a value of 1. I needed to add +1 to the output to rectify this issue. The results are BIT_CHANGING. 2024-07-17 23:42:18 -0500370b85fd1991810e0a1dec311f66ad10fa92275fIn my previous commit, I changed the domain of the maxloc commandseditsrc/SILHS/latin_hypercube_driver_module.F90src/CLUBB_core/precipitation_fraction.F90src/CLUBB_core/stats_clubb_utilities.F90876a5a7674acbc3609a50dfeb45e791acee015831721289115000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduThis commit brings the stats output from the all cases run with the master branch (using the default configuration) in bit-for-bit agreement with the stats output from all cases run with the clubb_ghost_exorcism branch. Of course, this agreement ignores the ghost level output in the zt files run with the master branch. This commit is technically BIT_CHANGING because it alters a few stats for a couple cases, but does not change results. 2024-07-18 02:51:55 -0500876a5a7674acbc3609a50dfeb45e791acee01583This commit brings the stats output from the all cases run witheditsrc/CLUBB_core/precipitation_fraction.F90editsrc/CLUBB_core/stats_clubb_utilities.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse535http://carson.math.uwm.edu/jenkins/job/clubb_fire_tuning_gfortran_test/535/533http://carson.math.uwm.edu/jenkins/job/clubb_fire_tuning_gfortran_test/533/