Started by an SCM change12912407142b14155687d0d80b174796965d2793b1212407142b14155687d0d80b174796965d2793b12origin/master12407142b14155687d0d80b174796965d2793b1212407142b14155687d0d80b174796965d2793b12origin/master113b19b67713baf175f99baa0cb0bdde6e8c1fbc588b19b67713baf175f99baa0cb0bdde6e8c1fbc588origin/grid_fixesb19b67713baf175f99baa0cb0bdde6e8c1fbc588b19b67713baf175f99baa0cb0bdde6e8c1fbc588origin/grid_fixes108b928767c7238139d599dc55420d2a0956161726ab928767c7238139d599dc55420d2a0956161726aorigin/feeding_gr_to_hostb928767c7238139d599dc55420d2a0956161726ab928767c7238139d599dc55420d2a0956161726aorigin/feeding_gr_to_host2738f73b8fa6467a67ca4127c0d17000136433cf29f8f73b8fa6467a67ca4127c0d17000136433cf29frefs/remotes/origin/master8f73b8fa6467a67ca4127c0d17000136433cf29f8f73b8fa6467a67ca4127c0d17000136433cf29frefs/remotes/origin/master8f73b8fa6467a67ca4127c0d17000136433cf29f8f73b8fa6467a67ca4127c0d17000136433cf29frefs/remotes/origin/masterhttps://github.com/larson-group/clubb.git27389f09d7ec262443729e8973fdbf4bad4e539e72a89f09d7ec262443729e8973fdbf4bad4e539e72arefs/remotes/origin/master89f09d7ec262443729e8973fdbf4bad4e539e72a89f09d7ec262443729e8973fdbf4bad4e539e72arefs/remotes/origin/master89f09d7ec262443729e8973fdbf4bad4e539e72a89f09d7ec262443729e8973fdbf4bad4e539e72arefs/remotes/origin/masterhttps://github.com/larson-group/sys_adminhttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_fire_tuning_gfortran_test/detail/clubb_fire_tuning_gfortran_test/273/artifactshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_fire_tuning_gfortran_test/detail/clubb_fire_tuning_gfortran_test/273/changeshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_fire_tuning_gfortran_test/detail/clubb_fire_tuning_gfortran_test/273/http://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_fire_tuning_gfortran_test/detail/clubb_fire_tuning_gfortran_test/273/testsfalseCompileRun fire_tunerfalse#27331801711912456clubb_fire_tuning_gfortran_test #273273false27315676SUCCESS1654072567594http://carson.math.uwm.edu/jenkins/job/clubb_fire_tuning_gfortran_test/273/src/CLUBB_core/new_hybrid_pdf_main.F90src/CLUBB_core/advance_xp3_module.F90src/CLUBB_core/advance_wp2_wp3_module.F90src/CLUBB_core/grid_class.F90src/CLUBB_core/pdf_closure_module.F90src/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90src/CLUBB_core/sponge_layer_damping.F90src/CLUBB_core/mixing_length.F90src/CLUBB_core/stats_type_utilities.F90src/microphys_driver.F90src/CLUBB_core/advance_windm_edsclrm_module.F90src/advance_microphys_module.F90src/CLUBB_core/stats_clubb_utilities.F90src/CLUBB_core/mono_flux_limiter.F90src/G_unit_test_types/pdf_parameter_tests.F90src/CLUBB_core/advance_helper_module.F90src/CLUBB_core/new_tsdadg_pdf.F90src/CLUBB_core/LY93_pdf.F90src/CLUBB_core/clip_explicit.F90src/CLUBB_core/numerical_check.F90src/CLUBB_core/new_pdf.F90src/CLUBB_core/advance_xp2_xpyp_module.F90src/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/turbulent_adv_pdf.F90src/CLUBB_core/advance_clubb_core_module.F90src/clubb_driver.F90src/CLUBB_core/clubb_api_module.F90src/CLUBB_core/setup_clubb_pdf_params.F90src/CLUBB_core/fill_holes.F90src/CLUBB_core/new_pdf_main.F90src/CLUBB_core/pos_definite_module.F90e8deb21c70b21643aee441c04fa17278ac8d7c911654031468000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAlmost final loop pushes (#1012) * Pushing loop into clip_rcm * Pushing column loop into trapezoid routines. * Pushing column loop into clip_covar routines. * Pushing column loop into clip_variance and clip_skewness. * Replacing sgn_turbulent_velocity with built in fortran sign * Removing gr from argument list of stats calls, replacing with just nz * Replacing some usages of gr with just the number of vertical levels * Replacing some usages of gr with just the number of vertical levels again * Missed a couple files to commit * Pushing some loops and removing need for gr to be passed into some routines. * Pushing loop into advance_xp3 * Pushing loop into mixing length * Some more loop pushing * Pushing some loops into mono_flux limit, skipping the lhs routine since it's a bit tricky at the moment, will do after change to grid class. * Removing gr from argument list of stats accumulate * Precalculating zt2zm so that we can use 2d version * Precalculating um/vm ddzt so that we can use 2d version * Precalculating things to use 2d version of zt2zm * Making 2d version of cubic interp for grid class * Small modifications to sponge damping code argument lists * Renaming some variables 2022-05-31 16:11:08 -0500e8deb21c70b21643aee441c04fa17278ac8d7c91Almost final loop pushes (#1012)editsrc/CLUBB_core/advance_xm_wpxp_module.F90editsrc/CLUBB_core/advance_xp3_module.F90editsrc/CLUBB_core/new_pdf_main.F90editsrc/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90editsrc/CLUBB_core/clip_explicit.F90editsrc/CLUBB_core/mixing_length.F90editsrc/CLUBB_core/new_pdf.F90editsrc/microphys_driver.F90editsrc/CLUBB_core/numerical_check.F90editsrc/CLUBB_core/turbulent_adv_pdf.F90editsrc/CLUBB_core/stats_type_utilities.F90editsrc/CLUBB_core/advance_xp2_xpyp_module.F90editsrc/CLUBB_core/clubb_api_module.F90editsrc/CLUBB_core/grid_class.F90editsrc/CLUBB_core/new_hybrid_pdf_main.F90editsrc/advance_microphys_module.F90editsrc/CLUBB_core/advance_windm_edsclrm_module.F90editsrc/CLUBB_core/fill_holes.F90editsrc/CLUBB_core/advance_helper_module.F90editsrc/clubb_driver.F90editsrc/CLUBB_core/LY93_pdf.F90editsrc/CLUBB_core/mono_flux_limiter.F90editsrc/CLUBB_core/stats_clubb_utilities.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/G_unit_test_types/pdf_parameter_tests.F90editsrc/CLUBB_core/new_tsdadg_pdf.F90editsrc/CLUBB_core/pdf_closure_module.F90editsrc/CLUBB_core/sponge_layer_damping.F90editsrc/CLUBB_core/advance_wp2_wp3_module.F90editsrc/CLUBB_core/setup_clubb_pdf_params.F90editsrc/CLUBB_core/pos_definite_module.F90microphysics.F907a9a332ece44f0a0ee2210d5fa63d63fb93a19b81654040073000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking compatible with latest clubb change. 2022-05-31 18:34:33 -05007a9a332ece44f0a0ee2210d5fa63d63fb93a19b8Making compatible with latest clubb change.editmicrophysics.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/new_hybrid_pdf_main.F90src/CLUBB_core/advance_wp2_wp3_module.F90src/clubb_driver.F90src/G_unit_test_types/spurious_source_test.F90src/CLUBB_core/clubb_api_module.F90src/CLUBB_core/pdf_closure_module.F90src/G_unit_test_types/pdf_parameter_tests.F90src/CLUBB_core/new_pdf_main.F90src/CLUBB_core/pdf_parameter_module.F90src/CLUBB_core/advance_xp2_xpyp_module.F901e537bac5d385007334ca3a6f2b16a17ae0016e21654040788000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comMaking pdf_implicit_coefs_terms a type containing 2D arrays. (#1014) 2022-05-31 18:46:28 -05001e537bac5d385007334ca3a6f2b16a17ae0016e2Making pdf_implicit_coefs_terms a type containing 2D arrays. (#1014)editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/advance_wp2_wp3_module.F90editsrc/CLUBB_core/advance_xm_wpxp_module.F90editsrc/CLUBB_core/new_pdf_main.F90editsrc/clubb_driver.F90editsrc/G_unit_test_types/spurious_source_test.F90editsrc/CLUBB_core/advance_xp2_xpyp_module.F90editsrc/CLUBB_core/pdf_parameter_module.F90editsrc/CLUBB_core/clubb_api_module.F90editsrc/CLUBB_core/new_hybrid_pdf_main.F90editsrc/CLUBB_core/pdf_closure_module.F90editsrc/G_unit_test_types/pdf_parameter_tests.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther HueblerhueblerfalseStarted by an SCM change12912407142b14155687d0d80b174796965d2793b1212407142b14155687d0d80b174796965d2793b12origin/master12407142b14155687d0d80b174796965d2793b1212407142b14155687d0d80b174796965d2793b12origin/master113b19b67713baf175f99baa0cb0bdde6e8c1fbc588b19b67713baf175f99baa0cb0bdde6e8c1fbc588origin/grid_fixesb19b67713baf175f99baa0cb0bdde6e8c1fbc588b19b67713baf175f99baa0cb0bdde6e8c1fbc588origin/grid_fixes108b928767c7238139d599dc55420d2a0956161726ab928767c7238139d599dc55420d2a0956161726aorigin/feeding_gr_to_hostb928767c7238139d599dc55420d2a0956161726ab928767c7238139d599dc55420d2a0956161726aorigin/feeding_gr_to_host274ed85915bbcd00d1dba9b17752de763547bfa429bed85915bbcd00d1dba9b17752de763547bfa429brefs/remotes/origin/mastered85915bbcd00d1dba9b17752de763547bfa429bed85915bbcd00d1dba9b17752de763547bfa429brefs/remotes/origin/mastered85915bbcd00d1dba9b17752de763547bfa429bed85915bbcd00d1dba9b17752de763547bfa429brefs/remotes/origin/masterhttps://github.com/larson-group/clubb.git2743e0db5009189cb3670bedd001513f3e98187ab733e0db5009189cb3670bedd001513f3e98187ab73refs/remotes/origin/master3e0db5009189cb3670bedd001513f3e98187ab733e0db5009189cb3670bedd001513f3e98187ab73refs/remotes/origin/master3e0db5009189cb3670bedd001513f3e98187ab733e0db5009189cb3670bedd001513f3e98187ab73refs/remotes/origin/masterhttps://github.com/larson-group/sys_adminfalse#27437978651912456clubb_fire_tuning_gfortran_test #274274false27415748SUCCESS1654158967637http://carson.math.uwm.edu/jenkins/job/clubb_fire_tuning_gfortran_test/274/jenkins_tests/clubb_bin_diff_regression_gfortran_test/Jenkinsfilejenkins_tests/clubb_bin_diff_regression_gfortran_test_new/Jenkinsfilejenkins_tests/clubb_bin_diff_regression_gfortran_test_old/Jenkinsfiled3e945d16e887b46b07827c135f73d33831fa9001654109323000http://carson.math.uwm.edu/jenkins/user/pbroelspbroelspbroels@uwm.eduChanged clubb_bin_diff_regression_gfortran_test_new to clubb_bin_diff_regression_gfortran_test and clubb_bin_diff_regression_gfortran_test to clubb_bin_diff_regression_gfortran_test_old to reflect current usage. 2022-06-01 13:48:43 -0500d3e945d16e887b46b07827c135f73d33831fa900Changed clubb_bin_diff_regression_gfortran_test_new to clubb_bin_diff_regression_gfortran_test and clubb_bin_diff_regression_gfortran_test to clubb_bin_diff_regression_gfortran_test_old to reflect current usage.addjenkins_tests/clubb_bin_diff_regression_gfortran_test_old/Jenkinsfileeditjenkins_tests/clubb_bin_diff_regression_gfortran_test/Jenkinsfiledeletejenkins_tests/clubb_bin_diff_regression_gfortran_test_new/JenkinsfileREADME291e87da51321a48b5c9d5c46e6b4459b51ab2a41654109959000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comThis commit is not bit changing 2022-06-01 13:59:19 -0500291e87da51321a48b5c9d5c46e6b4459b51ab2a4This commit is not bit changingeditREADMEREADME0ff480f574ef756272df942a2cd6e217fba760e21654110299000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comThis commt is not bit changing But commit e4f125ba067ba8083f917e0e06b6b2398483d3e4 was BIT_CHANGING for simulations that use silhs 2022-06-01 14:04:59 -05000ff480f574ef756272df942a2cd6e217fba760e2This commt is not bit changingeditREADMEsrc/CLUBB_core/new_hybrid_pdf_main.F90src/G_unit_test_types/pdf_parameter_tests.F90src/G_unit_test_types/spurious_source_test.F90src/CLUBB_core/new_pdf_main.F90aa26820b4f080d4a8721dd0f578737344061f9a31654112656000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduThe G_unit tests never allocated pdf_implicit_coefs_terms. It's unclear to me how these were working before, but it seems that something about making these 2D allocatable arrays exposed the bug. 2022-06-01 14:44:16 -0500aa26820b4f080d4a8721dd0f578737344061f9a3The G_unit tests never allocated pdf_implicit_coefs_terms. It's unclear to me how these were working before, but it seems that something about making these 2D allocatable arrays exposed the bug.editsrc/G_unit_test_types/spurious_source_test.F90editsrc/CLUBB_core/new_hybrid_pdf_main.F90editsrc/G_unit_test_types/pdf_parameter_tests.F90editsrc/CLUBB_core/new_pdf_main.F90src/CLUBB_core/advance_xp2_xpyp_module.F90b736467752bbdc37c77ea2504d0b4ffcc7383ac81654117361000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking zt2zm calls with pdf_implicit_coefs_terms use the 2D version. 2022-06-01 16:02:41 -0500b736467752bbdc37c77ea2504d0b4ffcc7383ac8Making zt2zm calls with pdf_implicit_coefs_terms use the 2D version.editsrc/CLUBB_core/advance_xp2_xpyp_module.F90src/CLUBB_core/clubb_api_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/clubb_driver.F908b9b43ecb1c82b2a06882613bbe7e2e61b86e0af1654122180000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduRemoving setup_grid and setup_parameters functionality from setup_clubb_core. This is beacuse in host models the required grid information may not be known during the setup process, resulting in dummy arguments for setup_clubb_core and the grid and paramters being setup during runtime anyway. Now, in the host models we can call these subroutines immediately after setup_clubb_core to maintain identical functionality (sam, wrf), and in others we can wait to call these until the main timestepping procedure (cam,e3sm). 2022-06-01 17:23:00 -05008b9b43ecb1c82b2a06882613bbe7e2e61b86e0afRemoving setup_grid and setup_parameters functionality from setup_clubb_core. This is beacuse in host models the required grid information may not be known during the setup process, resulting in dummy arguments for setup_clubb_core and the grid and paramters being setup during runtime anyway. Now, in the host models we can call these subroutines immediately after setup_clubb_core to maintain identical functionality (sam, wrf), and in others we can wait to call these until the main timestepping procedure (cam,e3sm).editsrc/CLUBB_core/clubb_api_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/clubb_driver.F90src/CLUBB_core/parameters_tunable.F90src/G_unit_test_types/spurious_source_test.F90src/CLUBB_core/clubb_api_module.F90src/CLUBB_core/grid_class.F90ed85915bbcd00d1dba9b17752de763547bfa429b1654129942000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking 2D versions of setup_grid and setup_parameters. 2022-06-01 19:32:22 -0500ed85915bbcd00d1dba9b17752de763547bfa429bMaking 2D versions of setup_grid and setup_parameters.editsrc/CLUBB_core/clubb_api_module.F90editsrc/CLUBB_core/parameters_tunable.F90editsrc/CLUBB_core/grid_class.F90editsrc/G_unit_test_types/spurious_source_test.F90gitmonthly_tests/monthly_patrol.bash3e0db5009189cb3670bedd001513f3e98187ab731654092185000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comChanging the monthly script to check surplus_storage instead of Archive 2022-06-01 09:03:05 -05003e0db5009189cb3670bedd001513f3e98187ab73Changing the monthly script to check surplus_storage instead of Archiveeditmonthly_tests/monthly_patrol.bashgithttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhttp://carson.math.uwm.edu/jenkins/user/pbroelspbroelsfalse275http://carson.math.uwm.edu/jenkins/job/clubb_fire_tuning_gfortran_test/275/273http://carson.math.uwm.edu/jenkins/job/clubb_fire_tuning_gfortran_test/273/Started by an SCM change12912407142b14155687d0d80b174796965d2793b1212407142b14155687d0d80b174796965d2793b12origin/master12407142b14155687d0d80b174796965d2793b1212407142b14155687d0d80b174796965d2793b12origin/master113b19b67713baf175f99baa0cb0bdde6e8c1fbc588b19b67713baf175f99baa0cb0bdde6e8c1fbc588origin/grid_fixesb19b67713baf175f99baa0cb0bdde6e8c1fbc588b19b67713baf175f99baa0cb0bdde6e8c1fbc588origin/grid_fixes108b928767c7238139d599dc55420d2a0956161726ab928767c7238139d599dc55420d2a0956161726aorigin/feeding_gr_to_hostb928767c7238139d599dc55420d2a0956161726ab928767c7238139d599dc55420d2a0956161726aorigin/feeding_gr_to_host272e4f125ba067ba8083f917e0e06b6b2398483d3e4e4f125ba067ba8083f917e0e06b6b2398483d3e4refs/remotes/origin/mastere4f125ba067ba8083f917e0e06b6b2398483d3e4e4f125ba067ba8083f917e0e06b6b2398483d3e4refs/remotes/origin/mastere4f125ba067ba8083f917e0e06b6b2398483d3e4e4f125ba067ba8083f917e0e06b6b2398483d3e4refs/remotes/origin/masterhttps://github.com/larson-group/clubb.git27289f09d7ec262443729e8973fdbf4bad4e539e72a89f09d7ec262443729e8973fdbf4bad4e539e72arefs/remotes/origin/master89f09d7ec262443729e8973fdbf4bad4e539e72a89f09d7ec262443729e8973fdbf4bad4e539e72arefs/remotes/origin/master89f09d7ec262443729e8973fdbf4bad4e539e72a89f09d7ec262443729e8973fdbf4bad4e539e72arefs/remotes/origin/masterhttps://github.com/larson-group/sys_adminfalse#27232918791912456clubb_fire_tuning_gfortran_test #272272false27215602SUCCESS1653726971211http://carson.math.uwm.edu/jenkins/job/clubb_fire_tuning_gfortran_test/272/src/SILHS/latin_hypercube_driver_module.F90src/clubb_driver.F90src/CLUBB_core/clubb_api_module.F90src/CLUBB_core/setup_clubb_pdf_params.F90src/SILHS/silhs_api_module.F90e4f125ba067ba8083f917e0e06b6b2398483d3e41653690057000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comConstructing rcm within SILHS (as rcm_pdf) (#1011) * Constructing rcm within SILHS (as rcm_pdf) to avoid having to pass rcm directly to SILHS. Relevant to possibly moving PDF call placement into the "post" position in CAM. See https://github.com/ESCOMP/CAM/issues/582. * Reconstructing rcm inside of setup_pdf_parameters instead of passing it through the argument lists. Might help NCAR move the PDF call placement to "post" position in CAM. See https://github.com/larson-group/clubb/issues/997. * Adding descriptive comment. 2022-05-27 16:20:57 -0600e4f125ba067ba8083f917e0e06b6b2398483d3e4Constructing rcm within SILHS (as rcm_pdf) (#1011)editsrc/CLUBB_core/setup_clubb_pdf_params.F90editsrc/CLUBB_core/clubb_api_module.F90editsrc/clubb_driver.F90editsrc/SILHS/latin_hypercube_driver_module.F90editsrc/SILHS/silhs_api_module.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse273http://carson.math.uwm.edu/jenkins/job/clubb_fire_tuning_gfortran_test/273/271http://carson.math.uwm.edu/jenkins/job/clubb_fire_tuning_gfortran_test/271/