https://carson.math.uwm.edu/jenkins/job/clubb_dash/Staged for activation after pytest_cleanup reaches master.clubb_dashclubb_dashclubb_dashclubb_dashhttps://carson.math.uwm.edu/jenkins/job/clubb_dash/trueStarted by an SCM changeINCLUDE_GENERATED_PYTESTSfalse000163165608200.9618933893388369512fcc6487603491e12ac13376de2aec2a0b8369512fcc6487603491e12ac13376de2aec2a0brefs/remotes/origin/master8369512fcc6487603491e12ac13376de2aec2a0b8369512fcc6487603491e12ac13376de2aec2a0brefs/remotes/origin/master8369512fcc6487603491e12ac13376de2aec2a0b8369512fcc6487603491e12ac13376de2aec2a0brefs/remotes/origin/masterhttps://github.com/larson-group/clubb.git00552testReportfalse#86316555121clubb_dash #88false811113SUCCESS1792483989815https://carson.math.uwm.edu/jenkins/job/clubb_dash/8/src/generalized_grid_test.F90src/CLUBB_core/setup_clubb_pdf_params.F90clubb_python_api/clubb_f2py.pyfsrc/CLUBB_core/fill_holes.F90src/G_unit_test_types/mu_sigma_hm_tests.F90clubb_python_api/pytests/auto_llm_generated_pytests/test_call_tree_precipitation_fraction.pyclubb_python_api/f2py_fortran_wrappers/precipitation_fraction_wrapper.F90src/Microphys/pdf_hydromet_microphys_wrapper.F90clubb_python_api/clubb_python/CLUBB_core/precipitation_fraction.pysrc/CLUBB_core/precipitation_fraction.F908369512fcc6487603491e12ac13376de2aec2a0b1792463005000https://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comClubb params 1d to 2d fix (#1392) * Fix: clubb params is a shape (ngrdcol,nparams) that is passed into subroutines that expect a 1d array Also fixed dependent other places in code and changed the python api. This is BIT_CHANGING for multicol. If a 2d array is passed into a function that expects the arr to be 1d fortran just passes the first col of the arr. Therefore the changes dont affect single col runs. For multicol runs other indexing is needed * fill_holes_vertical_api expects the passed gr%dzt to have shape(ngrdcol,nz) but the code passes the whole gr%dzt array although each column is traversed one by one. So ngrdcol=1 is passed each time. No effect on single col, as with ngrdcol = 1, gr%dzt and gr%dzt(1:1,:) are the same. Affects multicol if l_hole_fill = .true. and the hydrometeor is a mixing ratio (name starts with r) and some value is actually negative Therefore BIT_CHANGING 2026-10-19 21:23:25 -05008369512fcc6487603491e12ac13376de2aec2a0bClubb params 1d to 2d fix (#1392)editsrc/G_unit_test_types/mu_sigma_hm_tests.F90editclubb_python_api/clubb_f2py.pyfeditsrc/CLUBB_core/setup_clubb_pdf_params.F90editsrc/CLUBB_core/precipitation_fraction.F90editsrc/Microphys/pdf_hydromet_microphys_wrapper.F90editsrc/generalized_grid_test.F90editclubb_python_api/pytests/auto_llm_generated_pytests/test_call_tree_precipitation_fraction.pyeditclubb_python_api/clubb_python/CLUBB_core/precipitation_fraction.pyeditclubb_python_api/f2py_fortran_wrappers/precipitation_fraction_wrapper.F90editsrc/CLUBB_core/fill_holes.F90githttps://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse7https://carson.math.uwm.edu/jenkins/job/clubb_dash/7/Started by an SCM changeINCLUDE_GENERATED_PYTESTSfalse000048479464170.961693569357ec5e8070d3173282a6317b067f8673a657a1eb6fec5e8070d3173282a6317b067f8673a657a1eb6frefs/remotes/origin/masterec5e8070d3173282a6317b067f8673a657a1eb6fec5e8070d3173282a6317b067f8673a657a1eb6frefs/remotes/origin/masterec5e8070d3173282a6317b067f8673a657a1eb6fec5e8070d3173282a6317b067f8673a657a1eb6frefs/remotes/origin/masterhttps://github.com/larson-group/clubb.git00552testReportfalse#74847955121clubb_dash #77false711007SUCCESS1792397588253https://carson.math.uwm.edu/jenkins/job/clubb_dash/7/.agents/skills/clubb-bit-changing/SKILL.md.agents/skills/clubb-jax-port/SKILL.mdAGENTS.md.agents/skills/clubb-finalization/SKILL.md.agents/skills/clubb-documentation/change-messages/SKILL.md.agents/skills/clubb-testing-and-reporting/SKILL.mdccafe4f166f956eed26b91f7fdacd5600f60f5b21792344464000https://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comDefine when to declare bit-changing commits (#1403) * Define conservative bit-change declarations Centralize the policy around intentional Fortran numerical answer changes, with named affected BFB tests or precise untested conditions. Preserve standalone coverage and the current JAX parity boundary, keep declarations sparse, and separate answer-changing edits from preserving cleanup. Route message writing, validation and branch finalization to one owner. Skill schemas, local links, heading anchors, parser examples and manual decision scenarios were checked; no model or CI code changes. * Define the optimization level for bitwise preservation Use -O0 as the normal preservation standard. Differences confined to optimized builds do not require an answer-change declaration when -O0 is verified BFB; report known optimized-only differences and their configuration in the PR. The changed skill schema and whitespace checks pass. Inspected current debug compile flags and manually reviewed the optimized-only decision scenario; documentation only, no numerical rerun. 2026-10-18 12:27:44 -0500ccafe4f166f956eed26b91f7fdacd5600f60f5b2Define when to declare bit-changing commits (#1403)edit.agents/skills/clubb-documentation/change-messages/SKILL.mdedit.agents/skills/clubb-testing-and-reporting/SKILL.mdedit.agents/skills/clubb-jax-port/SKILL.mdadd.agents/skills/clubb-bit-changing/SKILL.mdeditAGENTS.mdedit.agents/skills/clubb-finalization/SKILL.mdclubb_jax/src/clubb_standalone.pyclubb_jax/pytests/auto_llm_generated_pytests/test_jax_cli_options.pyrun_scripts/README.mdutilities/clubb_case_runner.pyutilities/pytests/test_time_clubb.pytests/run_timestep_sweep.pyclubb_jax/pytests/auto_llm_generated_pytests/test_case_cache_reuse.pyclubb_python_driver/clubb_standalone.pysrc/clubb_standalone.F90tests/README.mdrun_scripts/run_scm_loss.pyutilities/time_clubb.py.agents/skills/clubb-testing-and-reporting/SKILL.mdutilities/create_case_namelist.pyutilities/pytests/test_create_case_namelist.pytests/run_stats_output_consistency.py.agents/skills/clubb-fortran-port/SKILL.mdtests/run_jax_vs_fortran_cases.pyclubb_jax/src/clubb_case_initalization.pyutilities/pytests/auto_llm_generated_pytests/test_timing_workers.pytests/case_runner_lifecycle_test.pyutilities/README.mdclubb_jax/pytests/auto_llm_generated_pytests/test_device_selection.py.agents/skills/clubb-numerical-diagnosis/SKILL.mdutilities/pytests/auto_llm_generated_pytests/test_loss_cli.pytests/pytests/auto_llm_generated_pytests/test_scm_jax_driver_test.pyrun_scripts/run_scm.py.agents/skills/clubb-fortran-format/SKILL.mdclubb_jax/src/Microphys/microphys_init_cleanup.pyAGENTS.md.agents/skills/clubb-finalization/SKILL.mdjenkins_tests/clubb_driver/Jenkinsfileutilities/timing_profiles.pyclubb_jax/README.mdrun_scripts/run_tuner_job.pyutilities/pytests/auto_llm_generated_pytests/test_clubb_case_runner.pytests/run_restart_test.pyclubb_jax/src/CLUBB_core/calc_pressure.pyutilities/pytests/timing_test_inputs.pytests/run_loss_output_consistency.py4f8368a377989b649fc0ed53c26957e193d210671792350419000https://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdd reusable case runners for timing (#1400) We have multiple entry points now for clubb standalone (fortran,python,jax), and there's additional logic that chooses which fortran installation to use (gfortran,ifort,nvhpc,etc). All of this has historically (~1 year) been done by run_scm.py, but we have a number of other scripts that need this same kind of logic, so instead of making run_scm.py more complicated and letting other scripts import it's pieces, we've made a `clubb_case_runner`. `clubb_case_runner` is a python object that abstracts the backend decisions. The "flow" is roughly: - high level script wants to run a clubb case some how - generates one or more case namelists (arm.in, bomex.in, etc) - creates a `clubb_case_runner` by passing it whatever runtime options (-jax/-python/-exe) the user requested - runs a case by passing this `clubb_case_runner` whatever namelists it wants to run. In addition to deduplicating runtime setting logic, this allows python scripts to create these high level `clubb_case_runner` objects and use those to do things that usually requires duplicate multiprocessesing and error code parsing logic. 2026-10-18 14:06:59 -05004f8368a377989b649fc0ed53c26957e193d21067Add reusable case runners for timing (#1400)editclubb_jax/src/Microphys/microphys_init_cleanup.pyeditclubb_jax/src/CLUBB_core/calc_pressure.pyeditsrc/clubb_standalone.F90editutilities/create_case_namelist.pyeditutilities/pytests/auto_llm_generated_pytests/test_loss_cli.pyaddutilities/pytests/auto_llm_generated_pytests/test_clubb_case_runner.pyedit.agents/skills/clubb-fortran-port/SKILL.mdeditAGENTS.mdeditrun_scripts/run_tuner_job.pyeditutilities/timing_profiles.pyaddutilities/pytests/timing_test_inputs.pyeditutilities/pytests/test_time_clubb.pyeditrun_scripts/run_scm.pyedittests/run_restart_test.pyaddutilities/pytests/auto_llm_generated_pytests/test_timing_workers.pyeditclubb_jax/pytests/auto_llm_generated_pytests/test_jax_cli_options.pyeditclubb_jax/pytests/auto_llm_generated_pytests/test_device_selection.pyaddutilities/clubb_case_runner.pyedittests/run_jax_vs_fortran_cases.pyedit.agents/skills/clubb-fortran-format/SKILL.mdedittests/pytests/auto_llm_generated_pytests/test_scm_jax_driver_test.pyeditrun_scripts/README.mdeditutilities/time_clubb.pyeditclubb_jax/src/clubb_standalone.pyaddclubb_jax/pytests/auto_llm_generated_pytests/test_case_cache_reuse.pyeditclubb_jax/src/clubb_case_initalization.pyeditclubb_jax/README.mdedit.agents/skills/clubb-finalization/SKILL.mdedittests/run_loss_output_consistency.pyedit.agents/skills/clubb-testing-and-reporting/SKILL.mdeditclubb_python_driver/clubb_standalone.pyaddtests/case_runner_lifecycle_test.pyeditutilities/pytests/test_create_case_namelist.pyedittests/run_stats_output_consistency.pyeditjenkins_tests/clubb_driver/Jenkinsfileedittests/run_timestep_sweep.pyedit.agents/skills/clubb-numerical-diagnosis/SKILL.mdedittests/README.mdeditrun_scripts/run_scm_loss.pyeditutilities/README.mdclubb_jax/src/clubb_case_initalization.pyclubb_jax/src/clubb_standalone.pyutilities/README.mdclubb_jax/pytests/auto_llm_generated_pytests/test_device_selection.pyclubb_jax/pytests/auto_llm_generated_pytests/test_jax_cli_options.pyclubb_jax/pytests/auto_llm_generated_pytests/test_code_timer_module.pyclubb_jax/src/clubb_loss_driver.pyrun_scripts/README.mdclubb_jax/view_profile.pyclubb_jax/run_jax.pyclubb_jax/pytests/auto_llm_generated_pytests/test_profile_cli.pyclubb_jax/src/CLUBB_core/code_timer_module.pyutilities/time_clubb.pyclubb_jax/src/advance_clubb_to_end.pyclubb_jax/README.mdclubb_jax/src/clubb_driver_test.pyec5e8070d3173282a6317b067f8673a657a1eb6f1792362852000https://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdd JAX timing and profiling (#1393) * Add JAX timing and persistent benchmark workers Write Fortran-format CPU timing summaries and optional XProf/Perfetto traces from JAX driver phases. Use synchronized persistent workers for full-case warmups and repetitions across Fortran, Python and JAX. Retain compiled JAX programs when initialization settings are unchanged. Validation: 243 focused checks and CPU case workflows passed. Repeated five-step BOMEX/RICO_SILHS numeric outputs matched fresh controls exactly. The two-column BOMEX JAX/Fortran comparison passed 1e-7 absolute and percent thresholds. BFB against the parent is not established by these comparisons. GPU and GPTL execution remain untested. * Making jax timer use wall clock time instead of cpu/process time * Keep JAX timing separate from reusable runners Move process persistence, cache reuse and Python timing adapters to the case-runner branch. Keep JAX wall-clock summaries, optional deep profiles, driver instrumentation and the parser change that reads their clock label. The timing-only shared suite and a three-step CPU BOMEX run pass. BFB against master is not established; physics expressions are unchanged. * Add reusable case runners for timing and tuning Share runtime selection and persistent standalone sessions between SCM, timing and tuning. Support namelist replacement and empty model reruns, plus parameter matrices for loss sessions. Synchronize timing cohorts and record retained-model initialization separately. Use executable loss workers for native tuning instead of requiring F2PY. Restore microphysics defaults between cases (BIT_CHANGING for sessions that previously inherited settings). Short native/CPU JAX sessions match fresh same-backend stats values exactly; broader BFB is not established. Native build, focused suites and repeated loss/tuner/timing workflows pass. * Use F2PY for reusable Fortran loss runs Run persistent Fortran loss sessions through the existing Python API. Restore the native loss standalone and remove its parameter namelist reader and result writers. Python workers pass arrays directly into F2PY; ordinary standalone persistence and JAX execution remain available. Fifteen native loss metric arrays match saved results exactly. Native and CPU JAX repeated loss/tuning workflows, tuner shutdown, the native build, 454 shared checks and four API checks pass. Broader BFB is not established. * Keep case runners persistent without retaining model state Run each ordinary request through full initialization, advancement and cleanup while keeping the process alive for in-memory JIT reuse. Remove retained-model commands, transport, timing/UI options and extra bindings. Restore tuning and loss frontends to their existing allocation-reusing APIs. The native build, 445 shared checks, 121 focused JAX checks and 85 Dash checks pass. Short native/JAX/Python reused-process stats match fresh controls exactly; tuning and synchronized timing sweeps pass. Two full 16-column JAX repeats log no new compilations. These comparisons do not establish blanket BFB. * Separate microphysics initialization fixes from case runners Move native default resets to their own branch/PR and keep the runner focused on shared runtime selection and full-case process reuse. Record the mixed-case native test's dependency on that fix. Refresh the timing base and master, and clarify runner, driver and test documentation under the current skills. The shared checks pass, including output drainage, cancellation, synchronized warmup/repetition barriers and CLI forwarding. Python AST checks confirm the remaining audit edits change only documentation. Jenkins validation follows this published checkpoint. * Complete case-runner procedure descriptions Describe the remaining changed CLI, test and profile routines under the current documentation standards. Executable Python ASTs are unchanged from f66ccf2ff, the revision running in Jenkins; existing validation still applies. * Separate JAX timing from case runner changes Keep runtime selection and process reuse independent so the case runner can merge into master before JAX timing. Shared runner/CLI/timing checks pass (445 tests, including provisional coverage). * Add JAX timing after the case runner Restore the audited wall-clock summaries and optional execution tracing on top of the independent case runner. Keep the existing implementation and review history while reversing the PR merge order. * Add a JAX profiling option and viewer commands Enable captures with -jax=profile and print commands after cleanup. Keep capture export in the timer and viewing in view_profile.py. 181 focused checks pass. CPU BOMEX captures preserve numeric stats; both viewers were verified in-browser. Large full-Python Perfetto exports can truncate; XProf retained all five tested timesteps. * Clarify JAX timing usage and cleanup Document the timer lifecycle, failure handling and Dash wall-time comparison metric. Executable Python AST is unchanged. 2026-10-18 17:34:12 -0500ec5e8070d3173282a6317b067f8673a657a1eb6fAdd JAX timing and profiling (#1393)addclubb_jax/src/CLUBB_core/code_timer_module.pyaddclubb_jax/pytests/auto_llm_generated_pytests/test_code_timer_module.pyeditclubb_jax/run_jax.pyeditclubb_jax/src/clubb_standalone.pyeditclubb_jax/README.mdeditclubb_jax/src/advance_clubb_to_end.pyeditclubb_jax/pytests/auto_llm_generated_pytests/test_device_selection.pyeditrun_scripts/README.mdeditclubb_jax/src/clubb_driver_test.pyeditutilities/time_clubb.pyeditclubb_jax/pytests/auto_llm_generated_pytests/test_jax_cli_options.pyeditutilities/README.mdeditclubb_jax/src/clubb_case_initalization.pyaddclubb_jax/pytests/auto_llm_generated_pytests/test_profile_cli.pyeditclubb_jax/src/clubb_loss_driver.pyaddclubb_jax/view_profile.pygithttps://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse8https://carson.math.uwm.edu/jenkins/job/clubb_dash/8/6https://carson.math.uwm.edu/jenkins/job/clubb_dash/6/Started by an SCM changeINCLUDE_GENERATED_PYTESTSfalse000053719517330.9616262626266e48f97c2a96bc78fb498c82f1ed0bb6902353496e48f97c2a96bc78fb498c82f1ed0bb690235349refs/remotes/origin/master6e48f97c2a96bc78fb498c82f1ed0bb6902353496e48f97c2a96bc78fb498c82f1ed0bb690235349refs/remotes/origin/master6e48f97c2a96bc78fb498c82f1ed0bb6902353496e48f97c2a96bc78fb498c82f1ed0bb690235349refs/remotes/origin/masterhttps://github.com/larson-group/clubb.git00552testReportfalse#65371955121clubb_dash #66false610888SUCCESS1792311187658https://carson.math.uwm.edu/jenkins/job/clubb_dash/6/clubb_jax/pytests/auto_llm_generated_pytests/test_windm_edsclrm_scalar_indices.pyclubb_jax/pytests/auto_llm_generated_pytests/test_xp2_error_diagnostics.pyclubb_jax/pytests/auto_llm_generated_pytests/test_radiation_error_diagnostics.pyclubb_jax/src/CLUBB_core/err_info.pyclubb_jax/src/CLUBB_core/advance_windm_edsclrm_module.pyclubb_jax/pytests/auto_llm_generated_pytests/test_jit_compile.pyclubb_jax/src/CLUBB_core/__init__.pyclubb_jax/src/CLUBB_core/numerical_check.pyclubb_jax/src/advance_clubb_to_end.pyclubb_jax/src/CLUBB_core/advance_xp2_xpyp_module.pyclubb_jax/src/CLUBB_core/err_info_codes.pyclubb_python_api/JAX_INTEROPERABILITY_PROPOSAL.mdclubb_jax/src/Radiation/radiation_module.pyaa8c2aa4037dda69d686ca97bcbbe1a8208401fd1792259885000https://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRemove the JAX error-message code registry (#1401) * Remove the JAX error-message code registry Print failure details at the runtime checks that detect them. Remove the extra reason_code field and its setters, decoder, initialization/reset handling and exports; retain the normal per-column fatal-error status. Update the scalar-guard assertions and add cached-call diagnostic checks. Local CPU checks passed for the ErrInfo pytree, diagnostic output, driver debug gates and state reset/batching behavior (65 cases across five modules). * Correct the multiple-LHS diagnostic test's wp3 grid Allocate synthetic wp3 on thermodynamic levels, as required by calc_wp3_on_wp2, so the test reaches the multiple-LHS guard during tracing. The 21 selected CPU diagnostic checks pass, covering cached-call output, per-column fatal status and preservation of fields on the unsupported path. * Restore the C2 explanation in the multiple-LHS diagnostic Name C2rt, C2thl and C2rtthl when their unequal values prevent a single-LHS solve. Keep the direct runtime print and existing fatal-status handling. The focused CPU cached-call test passes, including the restored explanation, quiet valid calls and preservation of incoming fields on failure. * Revert "Restore the C2 explanation in the multiple-LHS diagnostic" This reverts commit 170a13e2bc7af24e92d8d8bc9de9d9db601921ed. * List single-LHS requirements in the JAX diagnostic Print the approved static requirements after the unsupported multiple-LHS message: explicit turbulent advection or ADG1, plus per-column equivalence of C2thl and C2rtthl to C2rt within the relative epsilon tolerance. The focused CPU cached-call test passes, checking the listed requirements, quiet valid calls and preservation of incoming fields and fatal status. 2026-10-17 12:58:05 -0500aa8c2aa4037dda69d686ca97bcbbe1a8208401fdRemove the JAX error-message code registry (#1401)addclubb_jax/pytests/auto_llm_generated_pytests/test_xp2_error_diagnostics.pyaddclubb_jax/pytests/auto_llm_generated_pytests/test_radiation_error_diagnostics.pyeditclubb_jax/src/CLUBB_core/err_info.pyeditclubb_jax/pytests/auto_llm_generated_pytests/test_windm_edsclrm_scalar_indices.pyeditclubb_jax/src/CLUBB_core/advance_xp2_xpyp_module.pyeditclubb_jax/src/Radiation/radiation_module.pyeditclubb_jax/src/CLUBB_core/__init__.pyeditclubb_jax/pytests/auto_llm_generated_pytests/test_jit_compile.pydeleteclubb_jax/src/CLUBB_core/err_info_codes.pyeditclubb_python_api/JAX_INTEROPERABILITY_PROPOSAL.mdeditclubb_jax/src/CLUBB_core/numerical_check.pyeditclubb_jax/src/CLUBB_core/advance_windm_edsclrm_module.pyeditclubb_jax/src/advance_clubb_to_end.py.agents/skills/clubb-jax-port/SKILL.md.agents/skills/clubb-testing-and-reporting/SKILL.md.agents/skills/clubb-documentation/change-messages/SKILL.md6e48f97c2a96bc78fb498c82f1ed0bb6902353491792260807000https://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRestrict BIT_CHANGING guidance to Fortran result changes (#1399) Keep JAX numerical acceptance focused on agreement with the corresponding Fortran implementation rather than preserving earlier JAX output. Clarify the reporting rule and link it from the JAX porting workflow. All 21 skill schemas, 112 local links and 7 heading anchors pass, along with diff formatting. Only three skill Markdown files change. 2026-10-17 13:13:27 -05006e48f97c2a96bc78fb498c82f1ed0bb690235349Restrict BIT_CHANGING guidance to Fortran result changes (#1399)edit.agents/skills/clubb-testing-and-reporting/SKILL.mdedit.agents/skills/clubb-jax-port/SKILL.mdedit.agents/skills/clubb-documentation/change-messages/SKILL.mdgithttps://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse7https://carson.math.uwm.edu/jenkins/job/clubb_dash/7/5https://carson.math.uwm.edu/jenkins/job/clubb_dash/5/Started by an SCM changeINCLUDE_GENERATED_PYTESTSfalse000050149481950.961771777175c47faf30cea562966e64eedc259a5074c6cf89b1c47faf30cea562966e64eedc259a5074c6cf89b1refs/remotes/origin/masterc47faf30cea562966e64eedc259a5074c6cf89b1c47faf30cea562966e64eedc259a5074c6cf89b1refs/remotes/origin/masterc47faf30cea562966e64eedc259a5074c6cf89b1c47faf30cea562966e64eedc259a5074c6cf89b1refs/remotes/origin/masterhttps://github.com/larson-group/clubb.git00552testReportfalse#55014955121clubb_dash #55false510743SUCCESS1792224789053https://carson.math.uwm.edu/jenkins/job/clubb_dash/5/.agents/skills/clubb-doc-language/SKILL.md.agents/skills/clubb-file-descriptions/SKILL.md.agents/skills/clubb-documentation/SKILL.mdAGENTS.md.agents/skills/clubb-change-messages/SKILL.md.agents/skills/clubb-readmes/SKILL.md.agents/skills/clubb-code-comments/SKILL.mdc179bae7435e6e90a0f796cb621d9de4690429b81792177736000https://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdd CLUBB documentation skills (#1397) * Add CLUBB documentation skills Add focused guidance for READMEs, file descriptions, routine/code comments, and plain language, with a documentation entry skill selected by AGENTS.md. This gives agents one route to the writing rules for the current task. Shorten the existing PR/commit guide and require BFB discussion only when a change could plausibly affect model results or scientific output. All 18 skill definitions and 45 local guidance links validate; git diff --check passes. * Require code reading and checks before finishing documentation Route small documentation edits through the writing skills. Require agents to inspect the implementation before drafting and check facts, coverage, links, and comment syntax before finishing. Clarify that weak file headers need complete descriptions in the appropriate language form. Validation: all 18 skill schemas, 46 local guidance links, and whitespace checks pass. The fresh-agent study uses these exact frozen guidance files. * Clarify documentation wording and optional usage examples Explain meaning before usage and make important ordering clear. Read the applicable language or porting standards for documentation conventions. Describe file interfaces independently of current callers, using callers as optional examples. Recommend examples in file headers when useful, or beside individual routines for collections of independent helpers. Validation: all 18 skill schemas, 49 local guidance links, and whitespace checks pass. These refinements have not had a new fresh-agent trial. 2026-10-16 14:08:56 -0500c179bae7435e6e90a0f796cb621d9de4690429b8Add CLUBB documentation skills (#1397)add.agents/skills/clubb-code-comments/SKILL.mdedit.agents/skills/clubb-change-messages/SKILL.mdadd.agents/skills/clubb-doc-language/SKILL.mdadd.agents/skills/clubb-readmes/SKILL.mdadd.agents/skills/clubb-documentation/SKILL.mdadd.agents/skills/clubb-file-descriptions/SKILL.mdeditAGENTS.md.agents/skills/clubb-column-refactor/SKILL.mdjenkins_tests/README.md.agents/skills/clubb-jenkins/test-authoring/SKILL.md.agents/skills/clubb-jenkins/SKILL.md.agents/skills/clubb-documentation/code-comments/SKILL.md.agents/skills/clubb-documentation/file-descriptions/SKILL.md.agents/skills/clubb-testing-and-reporting/SKILL.md.agents/skills/clubb-script-cli/SKILL.md.agents/skills/clubb-fortran-port/SKILL.md.agents/skills/clubb-python-api/SKILL.md.agents/skills/clubb-documentation/readmes/SKILL.md.agents/skills/clubb-numerical-diagnosis/SKILL.md.agents/skills/clubb-documentation/language/SKILL.md.agents/skills/clubb-readmes/SKILL.md.agents/skills/clubb-code-comments/SKILL.mdjenkins_tests/jenkins_api_login.py.agents/skills/clubb-jax-port/SKILL.md.agents/skills/clubb-doc-language/SKILL.md.agents/skills/clubb-file-descriptions/SKILL.md.agents/skills/clubb-host-compatibility/SKILL.md.agents/skills/clubb-documentation/SKILL.md.agents/skills/clubb-finalization/SKILL.mdAGENTS.md.agents/skills/clubb-documentation/change-messages/SKILL.md.agents/skills/clubb-pytests/SKILL.md.agents/skills/clubb-change-messages/SKILL.mdeb23a4c1b51706cad0060c28d8c5ead8da595e1c1792199605000https://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdd Jenkins workflows and branch finalization guidance (#1396) * Set up Jenkins API login over HTTPS Add an interactive token login script and teach the Jenkins skill to reuse its private local credential file or direct users through setup. This lets each developer use their own Jenkins account without SSH access. Ten focused regression checks and a live HTTPS login/save check passed. BFB is not applicable: login tooling and guidance do not affect model execution or output. * Explain Jenkins login setup and agent use Describe why agents use the saved login, how developers set it up, and what the public routines and failure paths do. Apply the new documentation guidance to the script, test comments and usage documentation. Executable Python statements are unchanged. Ten focused login checks pass. * Remove Jenkins login pytests Remove the provisional test file from the Jenkins login change at the user’s request. Keep the login script and workflow guidance unchanged. * Document Jenkins access and test authoring Add a Jenkins README and a separate authoring skill for simple, reproducible pipelines and coordinated live-job changes. Keep API access in its existing skill and route both workflows from AGENTS.md. Place the login script with the Jenkins files and update its references. Runtime statements and the credential location are unchanged. Login help, import, live HTTPS identity, skill validation and local links pass. * Prefer relevant Jenkins evidence in test reports Add shared guidance for choosing checks and explaining what their results establish. Lead PR reports with relevant Jenkins build links, include local checks when they add evidence, and keep unexpected failures visible. Connect validation and change-message workflows to the shared skill. Skill metadata and local guidance links validate; only Markdown changes. * Keep README verification notes in change reports Remove the authoring-history sentence from the Jenkins README and clarify where the README skill should record example verification. Review the PR documentation for similar notes while retaining reader-relevant setup. Skill metadata, local links and diff formatting checks pass. * Group related skills under their entry points Nest documentation guides and Jenkins test authoring while preserving skill names and workflow text. Rebase links, make shared parent guidance explicit, and use recursive skill discovery for validation. The Codex skill loader discovers every nested child. Recursive schema, link and preservation checks pass. * Clarify Jenkins test authoring scope and when to wait Require a user request before changing Jenkins test definitions, while allowing relevant existing branch builds during normal validation. Align pytest integration guidance with that boundary. Guide intermediate work toward fast meaningful checks and later review of slow builds; weigh longer waits at final validation and report pending results. All 20 skill schemas and 99 local guidance links validate; diff formatting passes. No pipeline or runtime changes, or live Jenkins actions. * Explain Jenkins permissions before promising site changes Describe the permissions needed to read, run, create or edit jobs without assuming a particular account. Link the guidance from authoring and setup, and explain how to use assigned tokens or switch saved accounts. All 20 skill schemas and 101 local guidance links pass, including the new section anchors. Diff formatting passes; this commit changes Markdown only. Prior live HTTPS checks confirmed creation, build and cancellation access, read-only configuration access, and denied configuration writes. * Add branch finalization workflow and agent PR conventions Define merge preparation as a full branch audit followed by current validation and a commit, push and draft-PR handoff. Pause for substantive unintended issues the user has not accepted; allow minor cleanup without interruption. Route finalization from AGENTS and shared testing guidance. Keep agent PRs as drafts and sign PR comments posted through a user account with the agent name. Codex discovers all 21 repo skills. All 21 schemas and 110 local guidance links validate; diff formatting passes. Only agent guidance changes. * Clarify which builds an agent may cancel Limit cancellation to builds and queue items launched for the current task unless the user authorizes stopping others. A shared Jenkins username does not establish ownership. Wrap the nearby setup and authoring text. Final branch audit found no substantive blockers. Login smoke checks passed for live HTTPS authentication, private credential replacement and failure preservation without changing the user credential file. All 21 skill schemas, 110 local links and 5 heading anchors pass; Codex discovers all 21 skills. 2026-10-16 20:13:25 -0500eb23a4c1b51706cad0060c28d8c5ead8da595e1cAdd Jenkins workflows and branch finalization guidance (#1396)add.agents/skills/clubb-documentation/file-descriptions/SKILL.mdadd.agents/skills/clubb-testing-and-reporting/SKILL.mdadd.agents/skills/clubb-documentation/code-comments/SKILL.mdadd.agents/skills/clubb-finalization/SKILL.mdedit.agents/skills/clubb-pytests/SKILL.mddelete.agents/skills/clubb-doc-language/SKILL.mdadd.agents/skills/clubb-documentation/language/SKILL.mdedit.agents/skills/clubb-column-refactor/SKILL.mdaddjenkins_tests/README.mddelete.agents/skills/clubb-file-descriptions/SKILL.mddelete.agents/skills/clubb-code-comments/SKILL.mdedit.agents/skills/clubb-jenkins/SKILL.mddelete.agents/skills/clubb-readmes/SKILL.mdedit.agents/skills/clubb-numerical-diagnosis/SKILL.mdeditAGENTS.mddelete.agents/skills/clubb-change-messages/SKILL.mdadd.agents/skills/clubb-documentation/change-messages/SKILL.mdedit.agents/skills/clubb-script-cli/SKILL.mdadd.agents/skills/clubb-jenkins/test-authoring/SKILL.mdaddjenkins_tests/jenkins_api_login.pyedit.agents/skills/clubb-host-compatibility/SKILL.mdadd.agents/skills/clubb-documentation/readmes/SKILL.mdedit.agents/skills/clubb-documentation/SKILL.mdedit.agents/skills/clubb-fortran-port/SKILL.mdedit.agents/skills/clubb-jax-port/SKILL.mdedit.agents/skills/clubb-python-api/SKILL.mdsrc/Microphys/microphys_init_cleanup.F90d9e8b9588ff7b16679ca79b67fcf5382bcc723c41792209029000https://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comReset microphysics defaults when initializing another case (#1398) Restore module and saved-local namelist defaults before reading a new case. This prevents omitted settings from inheriting the previous case's values. This isn't an issue for any way that clubb is currently run in the codebase, but would potentially cause an issue for a future use case (this is foreshadowing). 2026-10-16 22:50:29 -0500d9e8b9588ff7b16679ca79b67fcf5382bcc723c4Reset microphysics defaults when initializing another case (#1398)editsrc/Microphys/microphys_init_cleanup.F90clubb_jax/src/CLUBB_core/sfc_varnce_module.pyclubb_jax/src/CLUBB_core/model_flags.pyclubb_jax/src/CLUBB_core/new_hybrid_pdf_main.pyclubb_jax/src/CLUBB_core/adg1_adg2_3d_luhar_pdf.pyclubb_jax/src/CLUBB_core/precipitation_fraction.pyclubb_jax/src/CLUBB_core/parameters_tunable.pyclubb_jax/src/CLUBB_core/advance_wp2_wp3_module.pyclubb_jax/src/CLUBB_core/interpolation.pyclubb_jax/src/CLUBB_core/setup_clubb_pdf_params.pyclubb_jax/src/CLUBB_core/advance_windm_edsclrm_module.pyclubb_jax/src/CLUBB_core/jax_stats.pyclubb_jax/src/CLUBB_core/file_functions.pyclubb_jax/src/CLUBB_core/advance_clubb_core_module.pyclubb_jax/src/CLUBB_core/grid_class.pyclubb_jax/src/CLUBB_core/advance_xm_wpxp_module.pyclubb_jax/src/CLUBB_core/advance_xp2_xpyp_module.pyclubb_jax/src/CLUBB_core/mono_flux_limiter.pyclubb_jax/src/CLUBB_core/fill_holes.pyclubb_jax/src/CLUBB_core/stats_netcdf.pyclubb_jax/src/CLUBB_core/clip_explicit.pyclubb_jax/src/CLUBB_core/mixing_length.pyclubb_jax/src/CLUBB_core/err_info.pyclubb_jax/pytests/auto_llm_generated_pytests/test_sfc_varnce_diagnostics.pyclubb_jax/src/CLUBB_core/pdf_params.pyclubb_jax/pytests/auto_llm_generated_pytests/test_core_diagnostics.pyclubb_jax/src/CLUBB_core/remapping_module.pyclubb_jax/src/CLUBB_core/sponge_layer_damping.pyclubb_jax/src/CLUBB_core/new_pdf.pyclubb_jax/src/CLUBB_core/matrix_operations.pyclubb_jax/src/CLUBB_core/pos_definite_module.pyclubb_jax/src/CLUBB_core/pdf_closure_module.pyclubb_jax/src/CLUBB_core/numerical_check.pyclubb_jax/src/CLUBB_core/matrix_solver_wrapper.pyclubb_jax/src/CLUBB_core/new_tsdadg_pdf.pyclubb_jax/src/CLUBB_core/corr_varnce_module.pyc47faf30cea562966e64eedc259a5074c6cf89b11792221315000https://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRestore missing debug printouts in JAX core (#1390) * Restore missing debug printouts in JAX core The port kept many failure checks but omitted their Fortran messages, making failed columns and solvers difficult to diagnose. Restore runtime messages, column headers and available field dumps with the source debug gates. Record diagnostics needing unported machinery in the skip report. BFB is not established by the available comparisons. All 23 curated CPU JAX/Fortran cases matched within default tolerances: absolute 1e-7 and percentage 1e-7%, or 0.001% for the curated Morrison cases. Runs used four columns, standard statistics and existing durations/caps. Separately, 24 starting-tree kernel comparisons found exactly equal result/state values. The CPU JAX suite passed 787 tests, including compiled diagnostic checks; the focused rerun passed 14. Source/diff review and git diff --check passed. * Remove diagnostic restoration report Remove the standalone report on intentionally skipped diagnostics. Observed Fortran differences remain documented in the affected JAX modules. This removes documentation only, so model/output BFB is not applicable. Diff review, a tracked-file reference search and git diff --check passed. Runtime tests were not rerun for this deletion. * Identify scalar fields in solver diagnostics The separate scalar solves all printed the same generic field label. Restore the Fortran names sclrp2, sclrprtp and sclrpthlp so a failure identifies which variance or covariance solve failed. Source comparison confirms the three labels match their Fortran call sites. Python syntax and whitespace checks passed. Jenkins validation will exercise the published revision. 2026-10-17 02:15:15 -0500c47faf30cea562966e64eedc259a5074c6cf89b1Restore missing debug printouts in JAX core (#1390)editclubb_jax/src/CLUBB_core/adg1_adg2_3d_luhar_pdf.pyaddclubb_jax/pytests/auto_llm_generated_pytests/test_core_diagnostics.pyeditclubb_jax/src/CLUBB_core/err_info.pyeditclubb_jax/src/CLUBB_core/precipitation_fraction.pyeditclubb_jax/src/CLUBB_core/jax_stats.pyeditclubb_jax/src/CLUBB_core/advance_clubb_core_module.pyeditclubb_jax/src/CLUBB_core/parameters_tunable.pyeditclubb_jax/src/CLUBB_core/new_tsdadg_pdf.pyeditclubb_jax/src/CLUBB_core/advance_wp2_wp3_module.pyeditclubb_jax/src/CLUBB_core/interpolation.pyeditclubb_jax/src/CLUBB_core/mixing_length.pyeditclubb_jax/src/CLUBB_core/advance_windm_edsclrm_module.pyeditclubb_jax/src/CLUBB_core/clip_explicit.pyeditclubb_jax/src/CLUBB_core/file_functions.pyeditclubb_jax/src/CLUBB_core/mono_flux_limiter.pyeditclubb_jax/src/CLUBB_core/pos_definite_module.pyeditclubb_jax/src/CLUBB_core/pdf_closure_module.pyeditclubb_jax/src/CLUBB_core/matrix_operations.pyaddclubb_jax/pytests/auto_llm_generated_pytests/test_sfc_varnce_diagnostics.pyeditclubb_jax/src/CLUBB_core/sponge_layer_damping.pyeditclubb_jax/src/CLUBB_core/model_flags.pyeditclubb_jax/src/CLUBB_core/stats_netcdf.pyeditclubb_jax/src/CLUBB_core/new_pdf.pyeditclubb_jax/src/CLUBB_core/advance_xm_wpxp_module.pyeditclubb_jax/src/CLUBB_core/pdf_params.pyeditclubb_jax/src/CLUBB_core/grid_class.pyeditclubb_jax/src/CLUBB_core/fill_holes.pyeditclubb_jax/src/CLUBB_core/corr_varnce_module.pyeditclubb_jax/src/CLUBB_core/numerical_check.pyeditclubb_jax/src/CLUBB_core/new_hybrid_pdf_main.pyeditclubb_jax/src/CLUBB_core/setup_clubb_pdf_params.pyeditclubb_jax/src/CLUBB_core/sfc_varnce_module.pyeditclubb_jax/src/CLUBB_core/advance_xp2_xpyp_module.pyeditclubb_jax/src/CLUBB_core/remapping_module.pyeditclubb_jax/src/CLUBB_core/matrix_solver_wrapper.pygithttps://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse6https://carson.math.uwm.edu/jenkins/job/clubb_dash/6/4https://carson.math.uwm.edu/jenkins/job/clubb_dash/4/Started by an SCM changeINCLUDE_GENERATED_PYTESTSfalse000051420493310.96196039603409499c45d0ef25810f48bbd43c8f92afa1497caa09499c45d0ef25810f48bbd43c8f92afa1497caarefs/remotes/origin/master09499c45d0ef25810f48bbd43c8f92afa1497caa09499c45d0ef25810f48bbd43c8f92afa1497caarefs/remotes/origin/master09499c45d0ef25810f48bbd43c8f92afa1497caa09499c45d0ef25810f48bbd43c8f92afa1497caarefs/remotes/origin/masterhttps://github.com/larson-group/clubb.git00552testReportfalse#45142055121clubb_dash #44false410634SUCCESS1792138390970https://carson.math.uwm.edu/jenkins/job/clubb_dash/4/clubb_jax/AGENTS.md.agents/skills/clubb-column-refactor/SKILL.md.agents/skills/clubb-jenkins/SKILL.mdLLM_prompts/port_underlying_fortran_to_other_languages.mdtests/README.mdLLM_prompts/README.mdtuner/pytests/auto_llm_generated_pytests/README.md.agents/skills/clubb-session-retrospective/references/guidance_maintenance.md.agents/skills/clubb-script-cli/SKILL.mdLLM_prompts/SHORTCUTS.mdtests/pytests/auto_llm_generated_pytests/README.mdLLM_prompts/pytest_workflow.mdLLM_prompts/update_host_models_after_clubb_changes.mdclubb_jax/JAX_CONVERSION_PLAN.mdLLM_prompts/fortran_routine_formatting.md.agents/skills/clubb-fortran-port/SKILL.md.agents/skills/clubb-python-api/SKILL.md.agents/skills/clubb-dash/SKILL.mdLLM_prompts/script_cli_conventions.mdutilities/pytests/auto_llm_generated_pytests/README.md.agents/skills/clubb-numerical-diagnosis/SKILL.mdLLM_prompts/update_python_api_and_drivers.md.agents/skills/clubb-session-retrospective/SKILL.mddash_app/pytests/auto_llm_generated_pytests/README.mdLLM_prompts/jenkins_workflow.mdLLM_prompts/change_messages.mdLLM_prompts/dash_app_workflow.md.agents/skills/clubb-jax-port/SKILL.mdLLM_prompts/numerical_regression_workflow.md.agents/skills/clubb-fortran-format/SKILL.md.agents/skills/clubb-host-compatibility/SKILL.mdAGENTS.md.agents/skills/clubb-pytests/SKILL.mdLLM_prompts/session_retrospective.mdLLM_prompts/fortran_column_refactor.md.agents/skills/clubb-change-messages/SKILL.mdLLM_prompts/jax_porting_workflow.md09499c45d0ef25810f48bbd43c8f92afa1497caa1792123599000https://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comConsolidate CLUBB workflows into skills (#1394) * Consolidate CLUBB workflows into skills Move the 13 workflows into repo skills and route to them from AGENTS.md, removing the legacy shortcut index and prompt directory. Keep the existing five skill identities and workflow instructions, including the scope rules previously stored in the index. Update only paths and obsolete routing text. Preservation checks passed for all workflow bodies, existing skill metadata, scope rules and task selectors. All 13 skills validate, all 55 local links resolve, and git diff --check passed. BFB is not applicable to this documentation-only migration. * Clarify skill selection and local guidance Allow multiple relevant skills in the task instructions, name user-facing documentation clearly, and explain that the ignored worklog is local to each checkout and should be created when absent. Add verified private host-repository links near the top of the compatibility skill so readers can identify the models and their access requirements. BFB is not applicable to these documentation-only clarifications. All 13 skill schemas, local guidance links, and git diff --check pass. Existing host workflow instructions are preserved. 2026-10-15 23:06:39 -050009499c45d0ef25810f48bbd43c8f92afa1497caaConsolidate CLUBB workflows into skills (#1394)add.agents/skills/clubb-fortran-format/SKILL.mdadd.agents/skills/clubb-host-compatibility/SKILL.mdeditclubb_jax/AGENTS.mddeleteLLM_prompts/fortran_column_refactor.mddeleteLLM_prompts/port_underlying_fortran_to_other_languages.mddeleteLLM_prompts/pytest_workflow.mdedit.agents/skills/clubb-session-retrospective/SKILL.mdedit.agents/skills/clubb-change-messages/SKILL.mdadd.agents/skills/clubb-python-api/SKILL.mdadd.agents/skills/clubb-jenkins/SKILL.mdedit.agents/skills/clubb-pytests/SKILL.mdedit.agents/skills/clubb-jax-port/SKILL.mdedittuner/pytests/auto_llm_generated_pytests/README.mdeditdash_app/pytests/auto_llm_generated_pytests/README.mddeleteLLM_prompts/fortran_routine_formatting.mdadd.agents/skills/clubb-column-refactor/SKILL.mddeleteLLM_prompts/update_python_api_and_drivers.mdadd.agents/skills/clubb-session-retrospective/references/guidance_maintenance.mddeleteLLM_prompts/session_retrospective.mddeleteLLM_prompts/README.mddeleteLLM_prompts/numerical_regression_workflow.mdadd.agents/skills/clubb-dash/SKILL.mdadd.agents/skills/clubb-numerical-diagnosis/SKILL.mdeditutilities/pytests/auto_llm_generated_pytests/README.mdedittests/README.mddeleteLLM_prompts/script_cli_conventions.mdeditclubb_jax/JAX_CONVERSION_PLAN.mdeditAGENTS.mddeleteLLM_prompts/SHORTCUTS.mdadd.agents/skills/clubb-fortran-port/SKILL.mdedit.agents/skills/clubb-script-cli/SKILL.mddeleteLLM_prompts/change_messages.mddeleteLLM_prompts/dash_app_workflow.mdedittests/pytests/auto_llm_generated_pytests/README.mddeleteLLM_prompts/jax_porting_workflow.mddeleteLLM_prompts/jenkins_workflow.mddeleteLLM_prompts/update_host_models_after_clubb_changes.mdgithttps://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse5https://carson.math.uwm.edu/jenkins/job/clubb_dash/5/3https://carson.math.uwm.edu/jenkins/job/clubb_dash/3/Started by an SCM changeINCLUDE_GENERATED_PYTESTSfalse000057131550290.961703270323a8c952996409f8c94d6a28714171145ed7d2c2aea8c952996409f8c94d6a28714171145ed7d2c2aerefs/remotes/origin/mastera8c952996409f8c94d6a28714171145ed7d2c2aea8c952996409f8c94d6a28714171145ed7d2c2aerefs/remotes/origin/mastera8c952996409f8c94d6a28714171145ed7d2c2aea8c952996409f8c94d6a28714171145ed7d2c2aerefs/remotes/origin/masterhttps://github.com/larson-group/clubb.git00552testReportfalse#35713155121clubb_dash #33false310495SUCCESS1791965588323https://carson.math.uwm.edu/jenkins/job/clubb_dash/3/READMEaf934ad3986d77e381919822755fc51a0168849f1791907259000https://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdd blank line to trigger Jenkins tests 2026-10-13 11:00:59 -0500af934ad3986d77e381919822755fc51a0168849fAdd blank line to trigger Jenkins testseditREADMEsrc/G_unit_tests.F90src/G_unit_test_types/CMakeLists.txtsrc/CLUBB_core/calc_roots.F90tests/run_G_unit_tests.pysrc/G_unit_test_types/cubic_solve_tests.F90input_misc/G_unit_tests.ina8c952996409f8c94d6a28714171145ed7d2c2ae1791911400000https://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comFixed bug in cubic equation solve function. Only relevant if pdf is L… (#1387) * Fixed bug in cubic equation solve function. Only relevant if pdf is Luhar or iiPDF_type=4 Therefore technically BIT_CHANGING... The bug existed because the old code used the principal cube root which has an imaginary part for negative bases. The fix is to simply calc: -|w|**(1/3) for negative real numbers. * Replaced determinant with discriminant Verified via a new Fortran unit test and also manually checked with wolfram alpha. There is no way to actually run this code :/ would only work for iiPDF_types: iiPDF_3D_Luhar = 3 and iiPDF_3D_Luhar = 3 (and those are currently (Oct 2026) broken ) 2026-10-13 12:10:00 -0500a8c952996409f8c94d6a28714171145ed7d2c2aeFixed bug in cubic equation solve function. Only relevant if pdf is L… (#1387)editsrc/CLUBB_core/calc_roots.F90edittests/run_G_unit_tests.pyeditinput_misc/G_unit_tests.ineditsrc/G_unit_test_types/CMakeLists.txtaddsrc/G_unit_test_types/cubic_solve_tests.F90editsrc/G_unit_tests.F90githttps://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse4https://carson.math.uwm.edu/jenkins/job/clubb_dash/4/2https://carson.math.uwm.edu/jenkins/job/clubb_dash/2/Started by an SCM changeINCLUDE_GENERATED_PYTESTSfalse000047772462910.9715171517124292a70f53a6b6c4eab864fe27b8fd9af5d869094292a70f53a6b6c4eab864fe27b8fd9af5d86909refs/remotes/origin/master4292a70f53a6b6c4eab864fe27b8fd9af5d869094292a70f53a6b6c4eab864fe27b8fd9af5d86909refs/remotes/origin/master4292a70f53a6b6c4eab864fe27b8fd9af5d869094292a70f53a6b6c4eab864fe27b8fd9af5d86909refs/remotes/origin/masterhttps://github.com/larson-group/clubb.git00552testReportfalse#24777255121clubb_dash #22false210381SUCCESS1791879186513https://carson.math.uwm.edu/jenkins/job/clubb_dash/2/LLM_prompts/SHORTCUTS.md.agents/skills/clubb-change-messages/SKILL.mdAGENTS.mdLLM_prompts/change_messages.mdfc9087d1a7a4a8f71c74f5763ece34f18328d2001791830025000https://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdd CLUBB commit and PR writing guidance (#1391) * Add CLUBB commit and PR writing guidance Add a canonical workflow and historical examples for writing specific titles and explaining purpose, motivation, results and testing. Scope BFB claims to their comparisons and distinguish tolerance matches from bitwise equality. A thin repo skill, shortcut and AGENTS link make the workflow discoverable. This addresses generated messages that bury the reason for a change or overstate what testing establishes. Six historical PR/commit drafting pairs passed independent review. Skill format, 20 local links, canonical-text consistency and git diff --check passed. BFB is not applicable to these documentation-only changes. * Keep only the final commit and PR writing workflow Remove the worked historical examples and their references. The repository should contain the final reusable guidance; the research and evaluation artifacts stay outside it. The shortcut and repo skill still point to one canonical workflow. Skill-format validation, all 19 local guidance links and git diff --check passed. BFB is not applicable to these documentation-only changes. 2026-10-12 13:33:45 -0500fc9087d1a7a4a8f71c74f5763ece34f18328d200Add CLUBB commit and PR writing guidance (#1391)editLLM_prompts/SHORTCUTS.mdadd.agents/skills/clubb-change-messages/SKILL.mdeditAGENTS.mdaddLLM_prompts/change_messages.mdclubb_python_api/pytests/auto_llm_generated_pytests/test_advance_core_subs.pyclubb_python_api/pytests/auto_llm_generated_pytests/test_call_tree_advance_xp2_xpyp.pyclubb_jax/src/Benchmark_cases/cobra.pyclubb_python_api/pytests/auto_llm_generated_pytests/test_call_tree_advance_wp2_wp3.pyclubb_python_api/clubb_python/prescribe_forcings.pyclubb_jax/src/CLUBB_core/advance_windm_edsclrm_module.pysrc/Benchmark_cases/time_dependent_input.F90clubb_python_api/clubb_python/CLUBB_core/parameters_tunable.pyclubb_python_api/clubb_python/CLUBB_core/numerical_check.pysrc/CLUBB_core/advance_windm_edsclrm_module.F90clubb_jax/pytests/auto_llm_generated_pytests/test_driver_lifecycle.pyclubb_jax/src/Benchmark_cases/time_dependent_input.pyclubb_python_driver/advance_clubb_core.pyutilities/pytests/auto_llm_generated_pytests/test_expldiff_settings_rules.pyclubb_python_api/f2py_fortran_wrappers/advance_windm_edsclrm_module_wrapper.F90clubb_jax/src/CLUBB_core/advance_clubb_core_module.pyclubb_jax/pytests/auto_llm_generated_pytests/test_expldiff_edsclrm_forcing.pyclubb_jax/pytests/auto_llm_generated_pytests/test_pressure_coord_forcing.pyclubb_python_api/pytests/auto_llm_generated_pytests/test_init_sequence.pyclubb_python_api/clubb_python/CLUBB_core/advance_windm_edsclrm.pyclubb_python_api/pytests/auto_llm_generated_pytests/test_call_tree_advance_windm_edsclrm.pyclubb_jax/src/clubb_case_initalization.pyclubb_jax/pytests/auto_llm_generated_pytests/test_windm_edsclrm_scalar_indices.pyexperimental/experimental_pdfs/python/dash_additions/misc_labs/sam_lscale.pyclubb_python_api/clubb_python/derived_types/nu_vert_res_dep.pysrc/CLUBB_core/numerical_check.F90clubb_python_driver/advance_clubb_to_end.pyclubb_python_driver/clubb_case_initalization.pysrc/CLUBB_core/advance_clubb_core_module.F90clubb_jax/pytests/auto_llm_generated_pytests/test_cobra_sfclyr.pyclubb_python_api/pytests/auto_llm_generated_pytests/test_call_tree_advance_core.pyclubb_jax/src/Benchmark_cases/prescribe_forcings.pysrc/clubb_driver.F90utilities/clubb_settings_validation.pytests/run_clubb_settings_validation_test.pysrc/Benchmark_cases/prescribe_forcings.F90clubb_python_api/clubb_f2py.pyfclubb_jax/src/CLUBB_core/numerical_check.pyclubb_jax/src/advance_clubb_to_end.pysrc/Benchmark_cases/cobra.F90clubb_python_api/f2py_fortran_wrappers/numerical_check_wrapper.F90clubb_jax/pytests/auto_llm_generated_pytests/test_forcing_port_structure.pyclubb_python_api/f2py_fortran_wrappers/prescribe_forcings_module_wrapper.F90clubb_jax/src/CLUBB_core/err_info_codes.pyclubb_python_api/pytests/auto_llm_generated_pytests/test_call_tree_advance_xm_wpxp.py4292a70f53a6b6c4eab864fe27b8fd9af5d869091791843053000https://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comFix arm97+l do expldiff rtm thlm+set edsclrm f early (#1386) * Do not force the thlm/rtm copies in the expldiff eddy-scalar solve With l_do_expldiff_rtm_thlm, advance_windm_edsclrm copies thlm into edsclrm(:,:,edsclr_dim-1) and rtm into edsclrm(:,:,edsclr_dim), advances all eddy scalars, and copies those two slots back into thlm and rtm. The solve added edsclrm_forcing of each slot to the copies, but thlm and rtm are already advanced with thlm_forcing and rtm_forcing in advance_xm_wpxp. In the standalone driver the slots are filled by iiedsclr_thl/iiedsclr_rt: - arm_97 (iiedsclr_rt = 1, iiedsclr_thl = 2) put thlm_forcing [K/s] on rtm, so rtm < 0 at ~5.5-8.8 km within the first steps (flag11 / expldiff). - With the slots in expldiff order, rtm_forcing was applied twice and arm_97 still hit rtm < 0 near 12 km after 1379 of 5580 steps. The copies now get no forcing. Mirrored in the JAX port. Only changes runs with l_do_expldiff_rtm_thlm = .true. and non-zero edsclrm_forcing in the last two eddy scalars, therefore BIT_CHANGING for those. Default runs are bit-for-bit identical (arm_97, 1076 variables). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * not hardwire the thlm and rtm edsclrm variables to be the last two; instead use sclr_idx%iiedsclr_thlm and sclr_idx%iiedsclr_rtm Previously l_do_expldiff_rtm_thlm = true forced the last slot to be rtm and the one before that to be thlm. If in the ..._model.in file iiedsclr_rt = 1 ! Location in the edsclrm array to place total water and iiedsclr_thl = 2 ! Location in the edsclrm array to place a scalar like thetal a switcheroo happens. But if we use a not hardcoded indexing we need to check for out of bounds and distinctness of the 2 indices. * Zero edsclrm_forcings early in apply_time_dependent_forcings_from_array Check edsclrm_forcings != 0 instead of zeroing in advance_windm_edsclrm BIT_CHANGING for l_do_expldiff_rtm_thlm = .true. for arm_97 and for cobra. Python changes include: clubb_jax, clubb_python (+f2py) + tests * Check l_do_expldiff_rtm_thlm eddy scalars in check_clubb_settings_api 1. Move the eddy-scalar checks into check_clubb_settings_api check_clubb_settings_api now takes edsclr_dim and sclr_idx. With l_do_expldiff_rtm_thlm = .true. it stops the run if - edsclr_dim <= 1, since the copies of thlm and rtm need two eddy scalars, or - iiedsclr_thl and iiedsclr_rt are not distinct indices in 1:edsclr_dim. The index check moved to check_clubb_settings_api from advance_windm_edsclrm. The check that edsclrm_forcing is zero for the thlm/rtm copies stays in advance_windm_edsclrm, because prescribe_forcings sets edsclrm_forcing every time step, after the settings check has run. Callers in Fortran and mirrors (clubb-jax, python api) are updated Behavior change: l_do_expldiff_rtm_thlm = .true. with fewer than two eddy scalars used to skip explicit diffusion silently and now stops at setup. This affects flag sets that turn the flag on for every case, e.g. flag11 in input/flag_sets/run_bindiff_w_flags_config_core_flags.json. Host models must pass the new arguments; CAM must also set sclr_idx%iiedsclr_thl/iiedsclr_rt when clubb_l_do_expldiff_rtm_thlm is on, since it leaves them at -1. 2. Fix the Python API - calc_derived_params now requires nu_vert_res_dep and always pushes it to the F2PY storage (new helper NuVertResDep.zeros(ngrdcol)). Before, nu_vert_res_dep=None kept the previous call's stored arrays, and calc_derived_params only allocates them when unallocated. So a call with more columns than an earlier one in the same process wrote out of bounds. This crashed the in-process Python API pytest suite once the windm tests used two columns. - clubb_f2py.pyf was missing l_do_expldiff_rtm_thlm for f2py_prescribe_forcings, so the Python driver failed on every case. 3. Gate the JAX rerun settings check at debug level 0 set_case_initial_conditions in the JAX driver now runs check_clubb_settings at debug level >= 0, matching clubb_driver.F90 since 9429ba2f1. Also: put l_do_expldiff_rtm_thlm on its own line in the time_dependent_input/prescribe_forcings argument lists. Bit-for-bit: default-flag output is unchanged, and arm_97 with l_do_expldiff_rtm_thlm = .true. matches the previous commit exactly. Tested: debug + Python build and source checks; settings parity test; Python API pytests (237 passed in one process); JAX pytests (791 passed); utilities settings-rule pytests; python-vs-fortran and jax-vs-fortran bomex/atex; bomex and cobra with the flag stop at setup in the Fortran, Python and JAX drivers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Do not apply surface fluxes to the expldiff thlm/rtm eddy-scalar copies With l_do_expldiff_rtm_thlm, advance_windm_edsclrm copies thlm and rtm into the iiedsclr_thl and iiedsclr_rt eddy scalars, solves all eddy scalars with their surface flux wpedsclrp(:,gr%k_lb_zm,:) (from wpedsclrp_sfc) and copies the two slots back. thlm and rtm already get wpthlp_sfc and wprtp_sfc in advance_xm_wpxp, so a non-zero surface flux on the copies applies it twice. Same approach as the edsclrm_forcing fix: 1. cobra_sfclyr (the only case that sets these fluxes) takes l_do_expldiff_rtm_thlm and sets wpedsclrp_sfc of the thlm/rtm copies to zero when it is on. set_sclr_sfc_rtm_thlm already zeroes all eddy-scalar surface fluxes. 2. advance_windm_edsclrm stops with a fatal error if the surface flux of either copy is non-zero, after the edsclrm_forcing check. Mirrored in the JAX port (new reason code ERR_WINDM_EDSCLRM_SFC_FLUX_EXPLDIFF_COPY; marks the columns fatal without returning early, like the forcing check). No Python API wrapper changes. CAM zeroes all eddy-scalar surface fluxes, so it is unaffected. Default cobra output is unchanged. But technically BIT_CHANGING for cobra + l_use_expldiff_rtm_thlm * Compute cobra's CO2 surface flux per column cobra_sfclyr converted the CO2 surface flux with each column's surface density inside the column loop, but stored it in the scalar CO2_flx2, and the later loops gave every column that one value: - CPU: every column got the last column's CO2 flux. Standalone columns currently share one density profile, so results were unaffected. - OpenACC: the scalar was private to the device loop, and the later loops copied the never-set host value (implicit firstprivate). In the GPU build cobra's CO2 surface flux was 0 at every step. CO2_flx2 is now a per-column array (enter/exit data create/delete like other case routines). The JAX port already computes it per column. Bit-for-bit: CPU cobra output is unchanged (1 and 2 columns, standard stats incl. the CO2 scalars). GPU cobra output changes: before, the CO2 surface flux was 0 and CO2 differed from the CPU run by up to 10%; now the CO2 scalars match the CPU run to ~1e-11 relative, like the other fields. Tested: gfortran debug build and source checks; standalone check of cobra_sfclyr with two columns of different density (before: column 1 got column 2's flux); nvhpc 24.3 OpenACC build and cobra on a Quadro P4000. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * removed the idiot proofing * fully removed idiot proofing for l_do_expldiff_rtm_thlm+esclrdim --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> 2026-10-12 17:10:53 -05004292a70f53a6b6c4eab864fe27b8fd9af5d86909Fix arm97+l do expldiff rtm thlm+set edsclrm f early (#1386)editclubb_python_api/clubb_f2py.pyfeditclubb_python_driver/clubb_case_initalization.pyeditclubb_jax/src/CLUBB_core/advance_windm_edsclrm_module.pyedittests/run_clubb_settings_validation_test.pyeditclubb_jax/src/Benchmark_cases/time_dependent_input.pyeditsrc/Benchmark_cases/prescribe_forcings.F90addutilities/pytests/auto_llm_generated_pytests/test_expldiff_settings_rules.pyeditclubb_python_api/pytests/auto_llm_generated_pytests/test_call_tree_advance_wp2_wp3.pyeditclubb_jax/pytests/auto_llm_generated_pytests/test_cobra_sfclyr.pyaddclubb_jax/pytests/auto_llm_generated_pytests/test_expldiff_edsclrm_forcing.pyeditclubb_python_api/f2py_fortran_wrappers/advance_windm_edsclrm_module_wrapper.F90editutilities/clubb_settings_validation.pyeditclubb_jax/pytests/auto_llm_generated_pytests/test_driver_lifecycle.pyeditexperimental/experimental_pdfs/python/dash_additions/misc_labs/sam_lscale.pyeditsrc/Benchmark_cases/cobra.F90editclubb_jax/pytests/auto_llm_generated_pytests/test_pressure_coord_forcing.pyeditclubb_jax/src/Benchmark_cases/cobra.pyeditclubb_python_driver/advance_clubb_core.pyeditclubb_python_api/clubb_python/derived_types/nu_vert_res_dep.pyeditclubb_python_api/clubb_python/CLUBB_core/numerical_check.pyeditclubb_jax/src/CLUBB_core/advance_clubb_core_module.pyeditclubb_python_api/clubb_python/prescribe_forcings.pyeditclubb_python_api/pytests/auto_llm_generated_pytests/test_call_tree_advance_xm_wpxp.pyeditsrc/Benchmark_cases/time_dependent_input.F90editclubb_python_api/f2py_fortran_wrappers/prescribe_forcings_module_wrapper.F90editclubb_python_api/pytests/auto_llm_generated_pytests/test_call_tree_advance_windm_edsclrm.pyeditclubb_python_api/clubb_python/CLUBB_core/parameters_tunable.pyeditclubb_python_api/pytests/auto_llm_generated_pytests/test_init_sequence.pyeditclubb_python_api/clubb_python/CLUBB_core/advance_windm_edsclrm.pyeditclubb_jax/src/CLUBB_core/err_info_codes.pyeditclubb_python_api/pytests/auto_llm_generated_pytests/test_call_tree_advance_xp2_xpyp.pyeditclubb_jax/src/CLUBB_core/numerical_check.pyeditclubb_python_api/f2py_fortran_wrappers/numerical_check_wrapper.F90editclubb_python_api/pytests/auto_llm_generated_pytests/test_call_tree_advance_core.pyeditsrc/CLUBB_core/advance_windm_edsclrm_module.F90editsrc/CLUBB_core/numerical_check.F90addclubb_jax/pytests/auto_llm_generated_pytests/test_windm_edsclrm_scalar_indices.pyeditclubb_jax/src/clubb_case_initalization.pyeditclubb_jax/src/advance_clubb_to_end.pyeditsrc/CLUBB_core/advance_clubb_core_module.F90editclubb_python_driver/advance_clubb_to_end.pyeditsrc/clubb_driver.F90editclubb_jax/pytests/auto_llm_generated_pytests/test_forcing_port_structure.pyeditclubb_jax/src/Benchmark_cases/prescribe_forcings.pyeditclubb_python_api/pytests/auto_llm_generated_pytests/test_advance_core_subs.pygithttps://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse3https://carson.math.uwm.edu/jenkins/job/clubb_dash/3/1https://carson.math.uwm.edu/jenkins/job/clubb_dash/1/Started by an SCM changeINCLUDE_GENERATED_PYTESTSfalse000152833516800.9818252825219429ba2f18a79e7b17ef53bccc8f17af6649c3fd9429ba2f18a79e7b17ef53bccc8f17af6649c3fdrefs/remotes/origin/master9429ba2f18a79e7b17ef53bccc8f17af6649c3fd9429ba2f18a79e7b17ef53bccc8f17af6649c3fdrefs/remotes/origin/master9429ba2f18a79e7b17ef53bccc8f17af6649c3fd9429ba2f18a79e7b17ef53bccc8f17af6649c3fdrefs/remotes/origin/masterhttps://github.com/larson-group/clubb.git00552testReportfalse#15283355121clubb_dash #11false110368SUCCESS1791706389088https://carson.math.uwm.edu/jenkins/job/clubb_dash/1/false2https://carson.math.uwm.edu/jenkins/job/clubb_dash/2/blueStarted by an SCM changeINCLUDE_GENERATED_PYTESTSfalse000152833516800.9818252825219429ba2f18a79e7b17ef53bccc8f17af6649c3fd9429ba2f18a79e7b17ef53bccc8f17af6649c3fdrefs/remotes/origin/master9429ba2f18a79e7b17ef53bccc8f17af6649c3fd9429ba2f18a79e7b17ef53bccc8f17af6649c3fdrefs/remotes/origin/master9429ba2f18a79e7b17ef53bccc8f17af6649c3fd9429ba2f18a79e7b17ef53bccc8f17af6649c3fdrefs/remotes/origin/masterhttps://github.com/larson-group/clubb.git00552testReportfalse#15283355121clubb_dash #11false110368SUCCESS1791706389088https://carson.math.uwm.edu/jenkins/job/clubb_dash/1/false2https://carson.math.uwm.edu/jenkins/job/clubb_dash/2/Tests: 0 tests failing out of a total of 552 tests.icon-health-80plushealth-80plus.png100Build stability: No recent builds failed.icon-health-80plushealth-80plus.png100falseStarted by an SCM changeINCLUDE_GENERATED_PYTESTSfalse000163165608200.9618933893388369512fcc6487603491e12ac13376de2aec2a0b8369512fcc6487603491e12ac13376de2aec2a0brefs/remotes/origin/master8369512fcc6487603491e12ac13376de2aec2a0b8369512fcc6487603491e12ac13376de2aec2a0brefs/remotes/origin/master8369512fcc6487603491e12ac13376de2aec2a0b8369512fcc6487603491e12ac13376de2aec2a0brefs/remotes/origin/masterhttps://github.com/larson-group/clubb.git00552testReportfalse#86316555121clubb_dash #88false811113SUCCESS1792483989815https://carson.math.uwm.edu/jenkins/job/clubb_dash/8/src/generalized_grid_test.F90src/CLUBB_core/setup_clubb_pdf_params.F90clubb_python_api/clubb_f2py.pyfsrc/CLUBB_core/fill_holes.F90src/G_unit_test_types/mu_sigma_hm_tests.F90clubb_python_api/pytests/auto_llm_generated_pytests/test_call_tree_precipitation_fraction.pyclubb_python_api/f2py_fortran_wrappers/precipitation_fraction_wrapper.F90src/Microphys/pdf_hydromet_microphys_wrapper.F90clubb_python_api/clubb_python/CLUBB_core/precipitation_fraction.pysrc/CLUBB_core/precipitation_fraction.F908369512fcc6487603491e12ac13376de2aec2a0b1792463005000https://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comClubb params 1d to 2d fix (#1392) * Fix: clubb params is a shape (ngrdcol,nparams) that is passed into subroutines that expect a 1d array Also fixed dependent other places in code and changed the python api. This is BIT_CHANGING for multicol. If a 2d array is passed into a function that expects the arr to be 1d fortran just passes the first col of the arr. Therefore the changes dont affect single col runs. For multicol runs other indexing is needed * fill_holes_vertical_api expects the passed gr%dzt to have shape(ngrdcol,nz) but the code passes the whole gr%dzt array although each column is traversed one by one. So ngrdcol=1 is passed each time. No effect on single col, as with ngrdcol = 1, gr%dzt and gr%dzt(1:1,:) are the same. Affects multicol if l_hole_fill = .true. and the hydrometeor is a mixing ratio (name starts with r) and some value is actually negative Therefore BIT_CHANGING 2026-10-19 21:23:25 -05008369512fcc6487603491e12ac13376de2aec2a0bClubb params 1d to 2d fix (#1392)editsrc/G_unit_test_types/mu_sigma_hm_tests.F90editclubb_python_api/clubb_f2py.pyfeditsrc/CLUBB_core/setup_clubb_pdf_params.F90editsrc/CLUBB_core/precipitation_fraction.F90editsrc/Microphys/pdf_hydromet_microphys_wrapper.F90editsrc/generalized_grid_test.F90editclubb_python_api/pytests/auto_llm_generated_pytests/test_call_tree_precipitation_fraction.pyeditclubb_python_api/clubb_python/CLUBB_core/precipitation_fraction.pyeditclubb_python_api/f2py_fortran_wrappers/precipitation_fraction_wrapper.F90editsrc/CLUBB_core/fill_holes.F90githttps://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse7https://carson.math.uwm.edu/jenkins/job/clubb_dash/7/Started by an SCM changeINCLUDE_GENERATED_PYTESTSfalse000163165608200.9618933893388369512fcc6487603491e12ac13376de2aec2a0b8369512fcc6487603491e12ac13376de2aec2a0brefs/remotes/origin/master8369512fcc6487603491e12ac13376de2aec2a0b8369512fcc6487603491e12ac13376de2aec2a0brefs/remotes/origin/master8369512fcc6487603491e12ac13376de2aec2a0b8369512fcc6487603491e12ac13376de2aec2a0brefs/remotes/origin/masterhttps://github.com/larson-group/clubb.git00552testReportfalse#86316555121clubb_dash #88false811113SUCCESS1792483989815https://carson.math.uwm.edu/jenkins/job/clubb_dash/8/src/generalized_grid_test.F90src/CLUBB_core/setup_clubb_pdf_params.F90clubb_python_api/clubb_f2py.pyfsrc/CLUBB_core/fill_holes.F90src/G_unit_test_types/mu_sigma_hm_tests.F90clubb_python_api/pytests/auto_llm_generated_pytests/test_call_tree_precipitation_fraction.pyclubb_python_api/f2py_fortran_wrappers/precipitation_fraction_wrapper.F90src/Microphys/pdf_hydromet_microphys_wrapper.F90clubb_python_api/clubb_python/CLUBB_core/precipitation_fraction.pysrc/CLUBB_core/precipitation_fraction.F908369512fcc6487603491e12ac13376de2aec2a0b1792463005000https://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comClubb params 1d to 2d fix (#1392) * Fix: clubb params is a shape (ngrdcol,nparams) that is passed into subroutines that expect a 1d array Also fixed dependent other places in code and changed the python api. This is BIT_CHANGING for multicol. If a 2d array is passed into a function that expects the arr to be 1d fortran just passes the first col of the arr. Therefore the changes dont affect single col runs. For multicol runs other indexing is needed * fill_holes_vertical_api expects the passed gr%dzt to have shape(ngrdcol,nz) but the code passes the whole gr%dzt array although each column is traversed one by one. So ngrdcol=1 is passed each time. No effect on single col, as with ngrdcol = 1, gr%dzt and gr%dzt(1:1,:) are the same. Affects multicol if l_hole_fill = .true. and the hydrometeor is a mixing ratio (name starts with r) and some value is actually negative Therefore BIT_CHANGING 2026-10-19 21:23:25 -05008369512fcc6487603491e12ac13376de2aec2a0bClubb params 1d to 2d fix (#1392)editsrc/G_unit_test_types/mu_sigma_hm_tests.F90editclubb_python_api/clubb_f2py.pyfeditsrc/CLUBB_core/setup_clubb_pdf_params.F90editsrc/CLUBB_core/precipitation_fraction.F90editsrc/Microphys/pdf_hydromet_microphys_wrapper.F90editsrc/generalized_grid_test.F90editclubb_python_api/pytests/auto_llm_generated_pytests/test_call_tree_precipitation_fraction.pyeditclubb_python_api/clubb_python/CLUBB_core/precipitation_fraction.pyeditclubb_python_api/f2py_fortran_wrappers/precipitation_fraction_wrapper.F90editsrc/CLUBB_core/fill_holes.F90githttps://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse7https://carson.math.uwm.edu/jenkins/job/clubb_dash/7/Started by an SCM changeINCLUDE_GENERATED_PYTESTSfalse000163165608200.9618933893388369512fcc6487603491e12ac13376de2aec2a0b8369512fcc6487603491e12ac13376de2aec2a0brefs/remotes/origin/master8369512fcc6487603491e12ac13376de2aec2a0b8369512fcc6487603491e12ac13376de2aec2a0brefs/remotes/origin/master8369512fcc6487603491e12ac13376de2aec2a0b8369512fcc6487603491e12ac13376de2aec2a0brefs/remotes/origin/masterhttps://github.com/larson-group/clubb.git00552testReportfalse#86316555121clubb_dash #88false811113SUCCESS1792483989815https://carson.math.uwm.edu/jenkins/job/clubb_dash/8/src/generalized_grid_test.F90src/CLUBB_core/setup_clubb_pdf_params.F90clubb_python_api/clubb_f2py.pyfsrc/CLUBB_core/fill_holes.F90src/G_unit_test_types/mu_sigma_hm_tests.F90clubb_python_api/pytests/auto_llm_generated_pytests/test_call_tree_precipitation_fraction.pyclubb_python_api/f2py_fortran_wrappers/precipitation_fraction_wrapper.F90src/Microphys/pdf_hydromet_microphys_wrapper.F90clubb_python_api/clubb_python/CLUBB_core/precipitation_fraction.pysrc/CLUBB_core/precipitation_fraction.F908369512fcc6487603491e12ac13376de2aec2a0b1792463005000https://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comClubb params 1d to 2d fix (#1392) * Fix: clubb params is a shape (ngrdcol,nparams) that is passed into subroutines that expect a 1d array Also fixed dependent other places in code and changed the python api. This is BIT_CHANGING for multicol. If a 2d array is passed into a function that expects the arr to be 1d fortran just passes the first col of the arr. Therefore the changes dont affect single col runs. For multicol runs other indexing is needed * fill_holes_vertical_api expects the passed gr%dzt to have shape(ngrdcol,nz) but the code passes the whole gr%dzt array although each column is traversed one by one. So ngrdcol=1 is passed each time. No effect on single col, as with ngrdcol = 1, gr%dzt and gr%dzt(1:1,:) are the same. Affects multicol if l_hole_fill = .true. and the hydrometeor is a mixing ratio (name starts with r) and some value is actually negative Therefore BIT_CHANGING 2026-10-19 21:23:25 -05008369512fcc6487603491e12ac13376de2aec2a0bClubb params 1d to 2d fix (#1392)editsrc/G_unit_test_types/mu_sigma_hm_tests.F90editclubb_python_api/clubb_f2py.pyfeditsrc/CLUBB_core/setup_clubb_pdf_params.F90editsrc/CLUBB_core/precipitation_fraction.F90editsrc/Microphys/pdf_hydromet_microphys_wrapper.F90editsrc/generalized_grid_test.F90editclubb_python_api/pytests/auto_llm_generated_pytests/test_call_tree_precipitation_fraction.pyeditclubb_python_api/clubb_python/CLUBB_core/precipitation_fraction.pyeditclubb_python_api/f2py_fortran_wrappers/precipitation_fraction_wrapper.F90editsrc/CLUBB_core/fill_holes.F90githttps://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse7https://carson.math.uwm.edu/jenkins/job/clubb_dash/7/Started by an SCM changeINCLUDE_GENERATED_PYTESTSfalse000163165608200.9618933893388369512fcc6487603491e12ac13376de2aec2a0b8369512fcc6487603491e12ac13376de2aec2a0brefs/remotes/origin/master8369512fcc6487603491e12ac13376de2aec2a0b8369512fcc6487603491e12ac13376de2aec2a0brefs/remotes/origin/master8369512fcc6487603491e12ac13376de2aec2a0b8369512fcc6487603491e12ac13376de2aec2a0brefs/remotes/origin/masterhttps://github.com/larson-group/clubb.git00552testReportfalse#86316555121clubb_dash #88false811113SUCCESS1792483989815https://carson.math.uwm.edu/jenkins/job/clubb_dash/8/src/generalized_grid_test.F90src/CLUBB_core/setup_clubb_pdf_params.F90clubb_python_api/clubb_f2py.pyfsrc/CLUBB_core/fill_holes.F90src/G_unit_test_types/mu_sigma_hm_tests.F90clubb_python_api/pytests/auto_llm_generated_pytests/test_call_tree_precipitation_fraction.pyclubb_python_api/f2py_fortran_wrappers/precipitation_fraction_wrapper.F90src/Microphys/pdf_hydromet_microphys_wrapper.F90clubb_python_api/clubb_python/CLUBB_core/precipitation_fraction.pysrc/CLUBB_core/precipitation_fraction.F908369512fcc6487603491e12ac13376de2aec2a0b1792463005000https://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comClubb params 1d to 2d fix (#1392) * Fix: clubb params is a shape (ngrdcol,nparams) that is passed into subroutines that expect a 1d array Also fixed dependent other places in code and changed the python api. This is BIT_CHANGING for multicol. If a 2d array is passed into a function that expects the arr to be 1d fortran just passes the first col of the arr. Therefore the changes dont affect single col runs. For multicol runs other indexing is needed * fill_holes_vertical_api expects the passed gr%dzt to have shape(ngrdcol,nz) but the code passes the whole gr%dzt array although each column is traversed one by one. So ngrdcol=1 is passed each time. No effect on single col, as with ngrdcol = 1, gr%dzt and gr%dzt(1:1,:) are the same. Affects multicol if l_hole_fill = .true. and the hydrometeor is a mixing ratio (name starts with r) and some value is actually negative Therefore BIT_CHANGING 2026-10-19 21:23:25 -05008369512fcc6487603491e12ac13376de2aec2a0bClubb params 1d to 2d fix (#1392)editsrc/G_unit_test_types/mu_sigma_hm_tests.F90editclubb_python_api/clubb_f2py.pyfeditsrc/CLUBB_core/setup_clubb_pdf_params.F90editsrc/CLUBB_core/precipitation_fraction.F90editsrc/Microphys/pdf_hydromet_microphys_wrapper.F90editsrc/generalized_grid_test.F90editclubb_python_api/pytests/auto_llm_generated_pytests/test_call_tree_precipitation_fraction.pyeditclubb_python_api/clubb_python/CLUBB_core/precipitation_fraction.pyeditclubb_python_api/f2py_fortran_wrappers/precipitation_fraction_wrapper.F90editsrc/CLUBB_core/fill_holes.F90githttps://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse7https://carson.math.uwm.edu/jenkins/job/clubb_dash/7/9INCLUDE_GENERATED_PYTESTSfalseInclude provisional agent-written pytests for human review; this does not promote them.INCLUDE_GENERATED_PYTESTSBooleanParameterDefinitiontruefalsefalsefalse