Started by an SCM change10512407142b14155687d0d80b174796965d2793b1212407142b14155687d0d80b174796965d2793b12origin/master12407142b14155687d0d80b174796965d2793b1212407142b14155687d0d80b174796965d2793b12origin/master566e3a6f7750467b5a221ac952479648c047f28bbb1e3a6f7750467b5a221ac952479648c047f28bbb1refs/remotes/origin/mastere3a6f7750467b5a221ac952479648c047f28bbb1e3a6f7750467b5a221ac952479648c047f28bbb1refs/remotes/origin/mastere3a6f7750467b5a221ac952479648c047f28bbb1e3a6f7750467b5a221ac952479648c047f28bbb1refs/remotes/origin/masterhttps://github.com/larson-group/clubb.githttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_G_unit_gfortran_tests/detail/clubb_G_unit_gfortran_tests/566/artifactshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_G_unit_gfortran_tests/detail/clubb_G_unit_gfortran_tests/566/changeshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_G_unit_gfortran_tests/detail/clubb_G_unit_gfortran_tests/566/http://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_G_unit_gfortran_tests/detail/clubb_G_unit_gfortran_tests/566/testsfalsefalse#56616144082226clubb_G_unit_gfortran_tests #566566false5667384SUCCESS1741079470536http://carson.math.uwm.edu/jenkins/job/clubb_G_unit_gfortran_tests/566/microphysics.F90fe14f38dc4183053649f580f02e2f8c540c2f06a1741018392000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduUpdated calls to some CLUBB subroutines in the wake of recent CLUBB commits. 2025-03-03 10:13:12 -0600fe14f38dc4183053649f580f02e2f8c540c2f06aUpdated calls to some CLUBB subroutines in the wake of recent CLUBBeditmicrophysics.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2falseStarted by an SCM change10512407142b14155687d0d80b174796965d2793b1212407142b14155687d0d80b174796965d2793b12origin/master12407142b14155687d0d80b174796965d2793b1212407142b14155687d0d80b174796965d2793b12origin/master56773cc3cbd6b18b700918d2130db73eb11dab81c2573cc3cbd6b18b700918d2130db73eb11dab81c25refs/remotes/origin/master73cc3cbd6b18b700918d2130db73eb11dab81c2573cc3cbd6b18b700918d2130db73eb11dab81c25refs/remotes/origin/master73cc3cbd6b18b700918d2130db73eb11dab81c2573cc3cbd6b18b700918d2130db73eb11dab81c25refs/remotes/origin/masterhttps://github.com/larson-group/clubb.gitfalse#56716797082226clubb_G_unit_gfortran_tests #567567false5677454SUCCESS1741165869572http://carson.math.uwm.edu/jenkins/job/clubb_G_unit_gfortran_tests/567/src/CLUBB_core/grid_class.F90src/bugsrad_driver.F901c06485d4a34378726c7734f4d34bce3b294695d1741120069000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI changed the variable type within grid function flip from dp to core_rknd. I then needed to make some changes to BUGSrad driver to compensate. The "dp" issue was discovered when WRF-CLUBB wouldn't compile because of it (discrepancy between dp and core_rknd in WRF-CLUBB that caused compilation errors for calls to flip from advance_xm_wpxp, etc.) 2025-03-04 14:27:49 -06001c06485d4a34378726c7734f4d34bce3b294695dI changed the variable type within grid function flip from dp toeditsrc/bugsrad_driver.F90editsrc/CLUBB_core/grid_class.F90src/CLUBB_core/advance_clubb_core_module.F900f3bc9f46f93fdd7932e6b047510c77a1c719b171741135026000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduFixed a compiling issue with CAM-CLUBB. 2025-03-04 18:37:06 -06000f3bc9f46f93fdd7932e6b047510c77a1c719b17Fixed a compiling issue with CAM-CLUBB.editsrc/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/saturation.F904c5fa8ce8f53dd868b93cd477e50d8f23bfd9fd81741139829000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduHopefully this helps the cpu vs. gpu tests. 2025-03-04 19:57:09 -06004c5fa8ce8f53dd868b93cd477e50d8f23bfd9fd8Hopefully this helps the cpu vs. gpu tests.editsrc/CLUBB_core/saturation.F90src/clubb_driver.F9073cc3cbd6b18b700918d2130db73eb11dab81c251741143316000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduThere were some flips inside the stats code for BUGSrad that required some restructuring around kind transformation statements. 2025-03-04 20:55:16 -060073cc3cbd6b18b700918d2130db73eb11dab81c25There were some flips inside the stats code for BUGSrad that requirededitsrc/clubb_driver.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2false568http://carson.math.uwm.edu/jenkins/job/clubb_G_unit_gfortran_tests/568/566http://carson.math.uwm.edu/jenkins/job/clubb_G_unit_gfortran_tests/566/Started by an SCM change10512407142b14155687d0d80b174796965d2793b1212407142b14155687d0d80b174796965d2793b12origin/master12407142b14155687d0d80b174796965d2793b1212407142b14155687d0d80b174796965d2793b12origin/master565be901594bb8e40f6b634f35f1488c0e5f9022e8fbe901594bb8e40f6b634f35f1488c0e5f9022e8frefs/remotes/origin/masterbe901594bb8e40f6b634f35f1488c0e5f9022e8fbe901594bb8e40f6b634f35f1488c0e5f9022e8frefs/remotes/origin/masterbe901594bb8e40f6b634f35f1488c0e5f9022e8fbe901594bb8e40f6b634f35f1488c0e5f9022e8frefs/remotes/origin/masterhttps://github.com/larson-group/clubb.gitfalse#56516602982226clubb_G_unit_gfortran_tests #565565false5657295SUCCESS1740906667762http://carson.math.uwm.edu/jenkins/job/clubb_G_unit_gfortran_tests/565/compile/file_list/G_unit_tests_filessrc/G_unit_tests.F90src/CLUBB_core/advance_wp2_wp3_module.F90src/CLUBB_core/pdf_closure_module.F90src/CLUBB_core/grid_class.F90src/CLUBB_core/saturation.F90src/CLUBB_core/mean_adv.F90src/CLUBB_core/sfc_varnce_module.F90src/CLUBB_core/grid_adaptation.F90src/CLUBB_core/sponge_layer_damping.F90src/CLUBB_core/mixing_length.F90src/CLUBB_core/advance_windm_edsclrm_module.F90src/CLUBB_core/model_flags.F90src/advance_microphys_module.F90input_misc/G_unit_tests.insrc/CLUBB_core/mono_flux_limiter.F90src/CLUBB_core/advance_helper_module.F90src/CLUBB_core/diffusion.F90src/generalized_grid_test.F90src/G_unit_test_types/spurious_source_test.F90src/CLUBB_core/clip_explicit.F90jenkins_tests/clubb_generalized_vertical_grid_test/Jenkinsfilecompile/file_list/clubb_model_filessrc/CLUBB_core/advance_xp2_xpyp_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/turbulent_adv_pdf.F90src/clubb_driver.F90src/CLUBB_core/clubb_api_module.F90src/CLUBB_core/fill_holes.F90src/CLUBB_core/pos_definite_module.F90src/G_unit_test_types/rev_direction_grid_test.F90be901594bb8e40f6b634f35f1488c0e5f9022e8f1740847122000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comGeneralized grid (#1230) * Added the necessary grid variables to the grid type (they're hardwired for an Ascending Grid for now). I also made the necessary changes, using those new variables, to advance_wp2_wp3_module.F90. * Added code to generalize advance_xm_wpxp_module.F90. * Updated some of the boundary conditions for generalization in grid_class.F90. * Developing a unit test for CLUBB's grid functions. * Adding the ability to toggle on or off the reverse direction grid test. * Updating for development of a unit test comparing the ascending and descending grids. * I updated the generalized grid unit test to complete testing on all the variables within the grid derived type for both the ascending and descending grid directions. * I updated the code to work symmetrically for an ascending and descending grid for the zm2zt and zt2zm functions. This commit, as well as the previous commit, is BIT_CHANGING. * Updated to improve notes and comments in grid_class.F90 and to enhance the reverse grid unit tests. * Got rid of the compiler warnings in the new reverse direction grid unit test. * Updating the reverse grid unit tests so some random perturbations are added to the grid heights when they are declared either on the thermodynamic grid or on the momentum grid. * Made some changes where the fstdout stream is exclusively used and added some print statements. * Mean advection has been modified for generalized directional gridding and a test of the calls to mean advection has been added to the reverse direction unit test. * Updating diffusion so results are bit-for-bit identical between using an ascending grid and using a descending grid at -O0 optimization. This now works for both standard diffusion and also diffusion with the l_upwind_Kh_dp_term flag turned on. * I forgot to add the zm diffusion test, but the results are the same -- all pass! * I have completed the unit tests for the PDF turbulent advection subroutines and modified the appropriate sections of code so that ascending and descending grids produce a bit-for-bit match wiht -O0 optimization. * Updated code for producing a bit-for-bit match (on -O0 optimization) when comparing ascending grid direction against descending grid direction for advance_wp2_wp3. * The check for the LHS of advance_xp2_xpyp now passes. * The ascending vs. descending bit-for-bit test (wiht optimization set to -O0) now passes for advance_xp2_xpyp. * I have successfully generalized the grid for advance_windm_edscrlm. Ascending and descending runs now produce bit-for-bit results to each other under -O0 optimization with the default flag configuration. * Fixing the ascending vs. descending grid test for advance_windm_edsclrm for the case where l_imp_sfc_momentum_flux is set to false. * Only perform check when l_predict_upwp_vpwp is turned off. * This commit makes an ascending vs. descending test work for all cases for advance_xm_wpxp when the mono flux limiter is turned off. * The ascending vs. descending grid tests are finally working with the monotonic flux limiter turned on (default settings). * Removed some commented-out prints that I accidentally added during the last commit. * Updating positive_definite_module.F90 so that it works for ascending vs. descending grids. * The ascending vs. descending grid generalization test now works for the Lscale_up portion of mixing length. * The ascending vs. descending grid generalization now works successfully for Lscale_down. * Lscale is now generalized for ascending vs. descending gridding. * Updated for generalizing sfc_varnce_module * Updating advance_clubb_core_module for grid generalization. * With this commit, the ascending vs. descending grid tests works by calling advance_clubb_core twice from clubb_driver. They produce bit-for-bit results on -O0 optimization for all intent(inout) and intent(out) variables found in the call to advance_clubb_core. This has only been tested for the default flag configuration. * I am updating the ascending vs. descending grid test to check both pdf_params and pdf_params_zm. * I added pdf_implicit_coefs_terms and the sclr and edsclr family of variables to the list of variables that are checked after coming out of the calls to advance_clubb_core in the ascending vs. descending bit-for-bit grid test. * I added an improved display for the print messages for the ascending vs. descending grid test. * I moved the generalized grid test to its own file, which is called from run_clubb. * I removed much of the junk and clutter from the code. It had been added over time for local tests of ascending vs. descending grid types. * Adding the l_generalized_grid_test flag to the code. * I needed to alter the monotonic flux limiter that I just merged in from the master branch so that the ascending vs. descending grid generalization test works once again. * Updated a piece of code in the solve routine for the monotonic flux limiter for the grid generalization test. * Clarified some comments * I added a Jenkins file for the new clubb_generalized_vertical_grid_test, which performs a run comparing ascending and descending grids with -O0 optimization and expects bit-for-bit results. * The l_rev_direction_grid_test (part of the G unit tests) needs to be compiled specially with -O0 optimization. Thus, I will set the flag to run this test to .false. by default. A special Jenkins test will be made to compile with the correct optimization and run only this particular test. * I updated the generalized vertical grid Jenkins test to turn off sponge damping (thlm and rtm sponge damping) in the case files for the CGILS S6, S11, and S12 cases. * Caught a stats bug I had previously introduced for the um_ta and vm_ta stats terms when l_predict_upwp_vpwp is turned off. 2025-03-01 10:38:42 -0600be901594bb8e40f6b634f35f1488c0e5f9022e8fGeneralized grid (#1230)editsrc/CLUBB_core/saturation.F90editsrc/CLUBB_core/fill_holes.F90editsrc/clubb_driver.F90editsrc/CLUBB_core/clubb_api_module.F90addsrc/G_unit_test_types/rev_direction_grid_test.F90editsrc/advance_microphys_module.F90editsrc/G_unit_tests.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/advance_helper_module.F90editsrc/CLUBB_core/mixing_length.F90editsrc/CLUBB_core/advance_xm_wpxp_module.F90editsrc/CLUBB_core/turbulent_adv_pdf.F90editsrc/CLUBB_core/advance_windm_edsclrm_module.F90editsrc/CLUBB_core/mean_adv.F90addsrc/generalized_grid_test.F90editsrc/CLUBB_core/pdf_closure_module.F90editsrc/CLUBB_core/grid_class.F90editsrc/CLUBB_core/advance_xp2_xpyp_module.F90editsrc/CLUBB_core/advance_wp2_wp3_module.F90editcompile/file_list/G_unit_tests_filesaddjenkins_tests/clubb_generalized_vertical_grid_test/Jenkinsfileeditsrc/CLUBB_core/sponge_layer_damping.F90editcompile/file_list/clubb_model_fileseditinput_misc/G_unit_tests.ineditsrc/CLUBB_core/pos_definite_module.F90editsrc/CLUBB_core/diffusion.F90editsrc/CLUBB_core/sfc_varnce_module.F90editsrc/CLUBB_core/clip_explicit.F90editsrc/CLUBB_core/grid_adaptation.F90editsrc/CLUBB_core/mono_flux_limiter.F90editsrc/G_unit_test_types/spurious_source_test.F90editsrc/CLUBB_core/model_flags.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse566http://carson.math.uwm.edu/jenkins/job/clubb_G_unit_gfortran_tests/566/564http://carson.math.uwm.edu/jenkins/job/clubb_G_unit_gfortran_tests/564/