Started by an SCM change10512407142b14155687d0d80b174796965d2793b1212407142b14155687d0d80b174796965d2793b12origin/master12407142b14155687d0d80b174796965d2793b1212407142b14155687d0d80b174796965d2793b12origin/master4785126b37bdc9edf2f08ad3efe662de9a505dbe0e05126b37bdc9edf2f08ad3efe662de9a505dbe0e0refs/remotes/origin/master5126b37bdc9edf2f08ad3efe662de9a505dbe0e05126b37bdc9edf2f08ad3efe662de9a505dbe0e0refs/remotes/origin/master5126b37bdc9edf2f08ad3efe662de9a505dbe0e05126b37bdc9edf2f08ad3efe662de9a505dbe0e0refs/remotes/origin/masterhttps://github.com/larson-group/clubb.githttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_G_unit_gfortran_tests/detail/clubb_G_unit_gfortran_tests/478/artifactshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_G_unit_gfortran_tests/detail/clubb_G_unit_gfortran_tests/478/changeshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_G_unit_gfortran_tests/detail/clubb_G_unit_gfortran_tests/478/http://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_G_unit_gfortran_tests/detail/clubb_G_unit_gfortran_tests/478/testsfalsefalse#47815161982226clubb_G_unit_gfortran_tests #478478false478898SUCCESS1721376668829http://carson.math.uwm.edu/jenkins/job/clubb_G_unit_gfortran_tests/478/READMEb539e93847e36a7817553cc8b13b1b7c61b814a01721336360000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdates README so that I can note that BIT_CHANGING:9ca167aa8b04cbebe4a1177a72f13731454e1e11 2024-07-18 15:59:20 -0500b539e93847e36a7817553cc8b13b1b7c61b814a0Updates README so that I can note that BIT_CHANGING:9ca167aa8b04cbebe4a1177a72f13731454e1e11editREADMEsrc/CLUBB_core/pdf_closure_module.F90f29869940fc51861eeb04350cdc567727b1e95f21721347695000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduCommitting a change that will initialize this set of variables under all circumstances. This change does not affect output except when the New Hybrid PDF is used. In the case of the New Hybrid PDF, the variables F_rt, F_thl, F_rt_min, F_rt_max, F_thl_min, and F_thl_max were never initialized and never set (they are not part of the New Hybrid PDF -- only in the original New PDF), resulting NaN values being output to stat files. 2024-07-18 19:08:15 -0500f29869940fc51861eeb04350cdc567727b1e95f2Committing a change that will initialize this set of variableseditsrc/CLUBB_core/pdf_closure_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreplyfalseStarted by an SCM change10512407142b14155687d0d80b174796965d2793b1212407142b14155687d0d80b174796965d2793b12origin/master12407142b14155687d0d80b174796965d2793b1212407142b14155687d0d80b174796965d2793b12origin/master479a67d637da217289ec8a0ddd2ea464d782b9ca79ca67d637da217289ec8a0ddd2ea464d782b9ca79crefs/remotes/origin/mastera67d637da217289ec8a0ddd2ea464d782b9ca79ca67d637da217289ec8a0ddd2ea464d782b9ca79crefs/remotes/origin/mastera67d637da217289ec8a0ddd2ea464d782b9ca79ca67d637da217289ec8a0ddd2ea464d782b9ca79crefs/remotes/origin/masterhttps://github.com/larson-group/clubb.gitfalse#47915539982226clubb_G_unit_gfortran_tests #479479false479971SUCCESS1721463068248http://carson.math.uwm.edu/jenkins/job/clubb_G_unit_gfortran_tests/479/src/CLUBB_core/advance_xp2_xpyp_module.F908f1115676aa257869d00331d0355159754208e1e1721419124000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduMaking a change to the l_C2_cloud_frac option with advance_xp2_xpyp. Cloud fraction needed to be interpolated to momentum levels for proper use in the code. Since this code change does not change CLUBB's default configuration, results are bit-for-bit for the default configuration. 2024-07-19 14:58:44 -05008f1115676aa257869d00331d0355159754208e1eMaking a change to the l_C2_cloud_frac option with advance_xp2_xpyp.editsrc/CLUBB_core/advance_xp2_xpyp_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/clubb_api_module.F90a67d637da217289ec8a0ddd2ea464d782b9ca79c1721424813000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing bug. qclvar copying is handled by the api, but we were deleting it with an unstructured data statement. I added this due as a fix before thinking qclvar was a local variable, which happened because I mixed up the CLUBB_CAM and CLUBBND_CAM flags. https://github.com/larson-group/cam/issues/175 2024-07-19 15:33:33 -0600a67d637da217289ec8a0ddd2ea464d782b9ca79cFixing bug. qclvar copying is handled by the api, but we were deleting it with an unstructured data statement. I added this due as a fix before thinking qclvar was a local variable, which happened because I mixed up the CLUBB_CAM and CLUBBND_CAM flags. https://github.com/larson-group/cam/issues/175editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/clubb_api_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse480http://carson.math.uwm.edu/jenkins/job/clubb_G_unit_gfortran_tests/480/478http://carson.math.uwm.edu/jenkins/job/clubb_G_unit_gfortran_tests/478/Started by an SCM change10512407142b14155687d0d80b174796965d2793b1212407142b14155687d0d80b174796965d2793b12origin/master12407142b14155687d0d80b174796965d2793b1212407142b14155687d0d80b174796965d2793b12origin/master477876a5a7674acbc3609a50dfeb45e791acee01583876a5a7674acbc3609a50dfeb45e791acee01583refs/remotes/origin/master876a5a7674acbc3609a50dfeb45e791acee01583876a5a7674acbc3609a50dfeb45e791acee01583refs/remotes/origin/master876a5a7674acbc3609a50dfeb45e791acee01583876a5a7674acbc3609a50dfeb45e791acee01583refs/remotes/origin/masterhttps://github.com/larson-group/clubb.gitfalse#47715405282226clubb_G_unit_gfortran_tests #477477false477820SUCCESS1721290269191http://carson.math.uwm.edu/jenkins/job/clubb_G_unit_gfortran_tests/477/src/SILHS/latin_hypercube_driver_module.F901cb88726a7f824b8844fe32eff22b09991b8de6c1721242346000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduThere were furhter issues found with the k_lh_start code. The code would find that sometimes, the maximum location of rcm in cloud would occur at the ghost level, k = 1, and set that level as k_lh_start for SILHS. This is undesirable for two reasons: 1) k_lh_start should be set around a legimate, "within domain" grid level; and 2) Setting k_lh_start to 1 is unachievable for the ghostless branch of the model, making a match between the master and clubb_ghost_exorcism branhes unattainable. The issue is corrected here by allowing the maxloc function to only search over "in-domain levels" for maximum cloud. The results are BIT_CHANGING. 2024-07-17 13:52:26 -05001cb88726a7f824b8844fe32eff22b09991b8de6cThere were furhter issues found with the k_lh_start code.editsrc/SILHS/latin_hypercube_driver_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/mixing_length.F90src/CLUBB_core/advance_helper_module.F90acdd31a8d397f5a8874cba8023e9376fe1d9e6511721258040000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRi_zm calc (Part 3) - Moving calculations for Ri_zm out of diagnose_Lscale_from_taus (#1157) CLUBB tocket #1145 BIT_CHANGING for lscale since Ri_zm was not calculated before. 1. mixing_length.F90: - Removed unused input variables from diagnose_Lscale_from_taus: um, vm, exner, p_in_Pa, rtm, thlm, thvm, rcm, saturation_formula, l_brunt_vaisala_freq_moist, l_use_thvm_in_bv_freq, l_modify_limiters_for_cnvg_test; added ddzt_umvm_sqd as input; changed Ri_zm from out to in - Removed unused brunt_vaisala_freq_sqd variables from diagnose_Lscale_from_tau - Removed calculations for Ri_zm and ddzt_umvm_sqd - Fixed some line length issues 2. advance_helper_module.F90 - Removed unused input variables and imports - Fixed some line length issues 3. advance_clubb_core_module.F90 - Added calculations for ddzt_umvm_sqd and Ri_zm - Adjusted subroutine calls - Fixed some line length issues 2024-07-17 18:14:00 -0500acdd31a8d397f5a8874cba8023e9376fe1d9e651Ri_zm calc (Part 3) - Moving calculations for Ri_zm out of diagnose_Lscale_from_taus (#1157)editsrc/CLUBB_core/mixing_length.F90editsrc/CLUBB_core/advance_helper_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90src/SILHS/latin_hypercube_driver_module.F90370b85fd1991810e0a1dec311f66ad10fa92275f1721277738000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduIn my previous commit, I changed the domain of the maxloc commands in the computation of k_lh_start to check over the arrays from levels 2:nz. However, when that happens, the output will be offset by 1. Consider a situation where the rcm max is at level 2. By being passed 2 through nz only, maxloc will return a value of 1. I needed to add +1 to the output to rectify this issue. The results are BIT_CHANGING. 2024-07-17 23:42:18 -0500370b85fd1991810e0a1dec311f66ad10fa92275fIn my previous commit, I changed the domain of the maxloc commandseditsrc/SILHS/latin_hypercube_driver_module.F90src/CLUBB_core/stats_clubb_utilities.F90src/CLUBB_core/precipitation_fraction.F90876a5a7674acbc3609a50dfeb45e791acee015831721289115000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduThis commit brings the stats output from the all cases run with the master branch (using the default configuration) in bit-for-bit agreement with the stats output from all cases run with the clubb_ghost_exorcism branch. Of course, this agreement ignores the ghost level output in the zt files run with the master branch. This commit is technically BIT_CHANGING because it alters a few stats for a couple cases, but does not change results. 2024-07-18 02:51:55 -0500876a5a7674acbc3609a50dfeb45e791acee01583This commit brings the stats output from the all cases run witheditsrc/CLUBB_core/stats_clubb_utilities.F90editsrc/CLUBB_core/precipitation_fraction.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse478http://carson.math.uwm.edu/jenkins/job/clubb_G_unit_gfortran_tests/478/476http://carson.math.uwm.edu/jenkins/job/clubb_G_unit_gfortran_tests/476/