Started by an SCM change10512407142b14155687d0d80b174796965d2793b1212407142b14155687d0d80b174796965d2793b12origin/master12407142b14155687d0d80b174796965d2793b1212407142b14155687d0d80b174796965d2793b12origin/master442e904e3ffbf83888681ba64f9008890329bd18631e904e3ffbf83888681ba64f9008890329bd18631refs/remotes/origin/mastere904e3ffbf83888681ba64f9008890329bd18631e904e3ffbf83888681ba64f9008890329bd18631refs/remotes/origin/mastere904e3ffbf83888681ba64f9008890329bd18631e904e3ffbf83888681ba64f9008890329bd18631refs/remotes/origin/masterhttps://github.com/larson-group/clubb.githttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_G_unit_gfortran_tests/detail/clubb_G_unit_gfortran_tests/442/artifactshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_G_unit_gfortran_tests/detail/clubb_G_unit_gfortran_tests/442/changeshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_G_unit_gfortran_tests/detail/clubb_G_unit_gfortran_tests/442/http://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_G_unit_gfortran_tests/detail/clubb_G_unit_gfortran_tests/442/testsfalsefalse#44211388982226clubb_G_unit_gfortran_tests #442442false4421234SUCCESS1714551127533http://carson.math.uwm.edu/jenkins/job/clubb_G_unit_gfortran_tests/442/src/CLUBB_core/advance_xm_wpxp_module.F90b2af0adcfce248292c5d48aefd9226666ee633e51714471119000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduMoved the ghost-point setting of xm(1) = xm(2) to the last line of the subroutine so this command doesn't get overwritten. This is technically BIT_CHANGING because it alters rtm (and some rtm-related calculations) at the ghost point, but it is not answer changing. This is being done in preparation for ghost point removal. 2024-04-30 04:58:39 -0500b2af0adcfce248292c5d48aefd9226666ee633e5Moved the ghost-point setting of xm(1) = xm(2) to the last lineeditsrc/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/advance_windm_edsclrm_module.F90src/CLUBB_core/advance_xp3_module.F90src/CLUBB_core/advance_wp2_wp3_module.F90src/CLUBB_core/grid_class.F90src/CLUBB_core/setup_clubb_pdf_params.F90src/CLUBB_core/calc_pressure.F90src/CLUBB_core/advance_helper_module.F90src/CLUBB_core/mixing_length.F90src/CLUBB_core/advance_xp2_xpyp_module.F90556370c6406e6b943b88affbe7728a5036b1ba221714534975000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comOptional arguments are just best sometimes (#1150) * Adding optional argument to zm2zt/zt2zm to act as threshold. This cuts down on lots of bulk and reduces the chances of breaking the GPU code. All BFB. * Removing TODO * Replacing hardcoded 0.0_core_rknd with zero_threshold 2024-04-30 22:42:55 -0500556370c6406e6b943b88affbe7728a5036b1ba22Optional arguments are just best sometimes (#1150)editsrc/CLUBB_core/advance_helper_module.F90editsrc/CLUBB_core/grid_class.F90editsrc/CLUBB_core/setup_clubb_pdf_params.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/advance_xm_wpxp_module.F90editsrc/CLUBB_core/advance_xp2_xpyp_module.F90editsrc/CLUBB_core/mixing_length.F90editsrc/CLUBB_core/advance_xp3_module.F90editsrc/CLUBB_core/calc_pressure.F90editsrc/CLUBB_core/advance_wp2_wp3_module.F90editsrc/CLUBB_core/advance_windm_edsclrm_module.F90src/CLUBB_core/advance_clubb_core_module.F90e904e3ffbf83888681ba64f9008890329bd186311714537919000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing bug. RESOLVED:556370c6406e6b943b88affbe7728a5036b1ba22, this was catchable by using debugging flags, but seems to otherwise cause no issues. Investigating I found that it only clips the below ground level, so that must not have been affecting other levels. This is technically BIT_CHANGING since it resolves an issue. 2024-04-30 23:31:59 -0500e904e3ffbf83888681ba64f9008890329bd18631Fixing bug. RESOLVED:556370c6406e6b943b88affbe7728a5036b1ba22, this was catchable by using debugging flags, but seems to otherwise cause no issues. Investigating I found that it only clips the below ground level, so that must not have been affecting other levels. This is technically BIT_CHANGING since it resolves an issue.editsrc/CLUBB_core/advance_clubb_core_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther HueblerhueblerfalseStarted by an SCM change10512407142b14155687d0d80b174796965d2793b1212407142b14155687d0d80b174796965d2793b12origin/master12407142b14155687d0d80b174796965d2793b1212407142b14155687d0d80b174796965d2793b12origin/master4432090eb2e167c2bd651d84762128d49894a7d54602090eb2e167c2bd651d84762128d49894a7d5460refs/remotes/origin/master2090eb2e167c2bd651d84762128d49894a7d54602090eb2e167c2bd651d84762128d49894a7d5460refs/remotes/origin/master2090eb2e167c2bd651d84762128d49894a7d54602090eb2e167c2bd651d84762128d49894a7d5460refs/remotes/origin/masterhttps://github.com/larson-group/clubb.gitfalse#44311886682226clubb_G_unit_gfortran_tests #443443false4431301SUCCESS1714637526194http://carson.math.uwm.edu/jenkins/job/clubb_G_unit_gfortran_tests/443/src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/advance_wp2_wp3_module.F90src/Morrison_microphys/microphysics.F90src/CLUBB_core/clubb_api_module.F90src/CLUBB_core/fill_holes.F90src/CLUBB_core/advance_xp2_xpyp_module.F903abb325943da1a557e1213b2908ead3c828aff161714587276000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking num_draw_points in fill_holes a constant. We were already using this value as a constant everywhere, but passing a constant by argument list makes it difficult/impossible for a compiler to optimize using that constant, unless it does inlining. Now, rather than passing the constant num_hf_draw_points (or sometimes a hardcoded 2) we just use num_hf_draw_points directly from constants_clubb. This massively improves the performance of a loop in fill holes when using nvhpc+omp, which was the motivation for this, but should also improve the performance on CPUs. Everything is BFB. 2024-05-01 13:14:36 -05003abb325943da1a557e1213b2908ead3c828aff16Making num_draw_points in fill_holes a constant. We were already using this value as a constant everywhere, but passing a constant by argument list makes it difficult/impossible for a compiler to optimize using that constant, unless it does inlining. Now, rather than passing the constant num_hf_draw_points (or sometimes a hardcoded 2) we just use num_hf_draw_points directly from constants_clubb. This massively improves the performance of a loop in fill holes when using nvhpc+omp, which was the motivation for this, but should also improve the performance on CPUs. Everything is BFB.editsrc/CLUBB_core/fill_holes.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/advance_xp2_xpyp_module.F90editsrc/Morrison_microphys/microphysics.F90editsrc/CLUBB_core/advance_xm_wpxp_module.F90editsrc/CLUBB_core/clubb_api_module.F90editsrc/CLUBB_core/advance_wp2_wp3_module.F90src/Morrison_microphys/microphysics.F902090eb2e167c2bd651d84762128d49894a7d54601714622486000http://carson.math.uwm.edu/jenkins/user/pickettCole Pickettlarsongroupgithub@gmail.comRaw-copy updating src/Morrison_microphys 2024-05-01 23:01:26 -05002090eb2e167c2bd651d84762128d49894a7d5460Raw-copy updating src/Morrison_microphyseditsrc/Morrison_microphys/microphysics.F90githttp://carson.math.uwm.edu/jenkins/user/pickettCole Picketthttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse444http://carson.math.uwm.edu/jenkins/job/clubb_G_unit_gfortran_tests/444/442http://carson.math.uwm.edu/jenkins/job/clubb_G_unit_gfortran_tests/442/Started by an SCM change10512407142b14155687d0d80b174796965d2793b1212407142b14155687d0d80b174796965d2793b12origin/master12407142b14155687d0d80b174796965d2793b1212407142b14155687d0d80b174796965d2793b12origin/master4417b429b2f394be33db0348d15755e28d832264e077b429b2f394be33db0348d15755e28d832264e07refs/remotes/origin/master7b429b2f394be33db0348d15755e28d832264e077b429b2f394be33db0348d15755e28d832264e07refs/remotes/origin/master7b429b2f394be33db0348d15755e28d832264e077b429b2f394be33db0348d15755e28d832264e07refs/remotes/origin/masterhttps://github.com/larson-group/clubb.gitfalse#4419911682226clubb_G_unit_gfortran_tests #441441false4411183SUCCESS1714464728910http://carson.math.uwm.edu/jenkins/job/clubb_G_unit_gfortran_tests/441/README7b429b2f394be33db0348d15755e28d832264e071714415012000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding space to include BIT_CHANGING:84588a46852a812266d19e36a8220f71ad56043a. This (https://github.com/larson-group/clubb/commit/84588a46852a812266d19e36a8220f71ad56043a) is described as not bit changing, but that seems to depend on the compiler version and some flags. The bin diff tests detected differences in only twp_ice when using e3sm flags on nelson, and both e3sm flags and default flags on carson. 2024-04-29 13:23:32 -05007b429b2f394be33db0348d15755e28d832264e07Adding space to include BIT_CHANGING:84588a46852a812266d19e36a8220f71ad56043a. This (https://github.com/larson-group/clubb/commit/84588a46852a812266d19e36a8220f71ad56043a) is described as not bit changing, but that seems to depend on the compiler version and some flags. The bin diff tests detected differences in only twp_ice when using e3sm flags on nelson, and both e3sm flags and default flags on carson.editREADMEgithttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse442http://carson.math.uwm.edu/jenkins/job/clubb_G_unit_gfortran_tests/442/440http://carson.math.uwm.edu/jenkins/job/clubb_G_unit_gfortran_tests/440/