Started by user Gunther HueblerhueblerGunther Huebler10512407142b14155687d0d80b174796965d2793b1212407142b14155687d0d80b174796965d2793b12origin/master12407142b14155687d0d80b174796965d2793b1212407142b14155687d0d80b174796965d2793b12origin/master27373e61e51337b34e2a9c651fc61c7600a1bf6702e73e61e51337b34e2a9c651fc61c7600a1bf6702erefs/remotes/origin/master73e61e51337b34e2a9c651fc61c7600a1bf6702e73e61e51337b34e2a9c651fc61c7600a1bf6702erefs/remotes/origin/master73e61e51337b34e2a9c651fc61c7600a1bf6702e73e61e51337b34e2a9c651fc61c7600a1bf6702erefs/remotes/origin/masterhttps://github.com/larson-group/clubb.githttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_G_unit_gfortran_tests/detail/clubb_G_unit_gfortran_tests/273/artifactshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_G_unit_gfortran_tests/detail/clubb_G_unit_gfortran_tests/273/changeshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_G_unit_gfortran_tests/detail/clubb_G_unit_gfortran_tests/273/http://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_G_unit_gfortran_tests/detail/clubb_G_unit_gfortran_tests/273/testsfalsefalse#273746980082226clubb_G_unit_gfortran_tests #273273false27318473SUCCESS1665418630218http://carson.math.uwm.edu/jenkins/job/clubb_G_unit_gfortran_tests/273/input/tunable_parameters/configurable_model_flags.in946dda9c077bd1889644cf8933d6469cffa517d11665074836000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduNamelists need to be closed with a '/', and omitting it will break many tests. 2022-10-06 11:47:16 -0500946dda9c077bd1889644cf8933d6469cffa517d1Namelists need to be closed with a '/', and omitting it will break many tests.editinput/tunable_parameters/configurable_model_flags.ininput/tunable_parameters/configurable_model_flags.inrun_scripts/check_multicol_error.pysrc/clubb_driver.F9073e61e51337b34e2a9c651fc61c7600a1bf6702e1665088226000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking save variables in the multicol code threadprivate, this fixes the openmp test. Also changing the way we name and save the multicol output, this allows the parallel run to run with multiple columns. I've reflected the changes in comments where relevant. larson-group/clubb#1033 2022-10-06 15:30:26 -050073e61e51337b34e2a9c651fc61c7600a1bf6702eMaking save variables in the multicol code threadprivate, this fixes the openmp test. Also changing the way we name and save the multicol output, this allows the parallel run to run with multiple columns. I've reflected the changes in comments where relevant. larson-group/clubb#1033editinput/tunable_parameters/configurable_model_flags.ineditsrc/clubb_driver.F90editrun_scripts/check_multicol_error.pygithttp://carson.math.uwm.edu/jenkins/user/hueblerGunther HueblerhueblerfalseStarted by an SCM change10512407142b14155687d0d80b174796965d2793b1212407142b14155687d0d80b174796965d2793b12origin/master12407142b14155687d0d80b174796965d2793b1212407142b14155687d0d80b174796965d2793b12origin/master274ee00186816ceb16bee810c897fabe4deb660fcc3ee00186816ceb16bee810c897fabe4deb660fcc3refs/remotes/origin/masteree00186816ceb16bee810c897fabe4deb660fcc3ee00186816ceb16bee810c897fabe4deb660fcc3refs/remotes/origin/masteree00186816ceb16bee810c897fabe4deb660fcc3ee00186816ceb16bee810c897fabe4deb660fcc3refs/remotes/origin/masterhttps://github.com/larson-group/clubb.gitfalse#27415098482226clubb_G_unit_gfortran_tests #274274false27418511SUCCESS1665475867308http://carson.math.uwm.edu/jenkins/job/clubb_G_unit_gfortran_tests/274/src/CLUBB_core/advance_xm_wpxp_module.F90ee00186816ceb16bee810c897fabe4deb660fcc31665426176000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdds commented-out line that prevents the monotonic flux limiter from acting on rtm. The comments are included to remind us of how to do this in case we choose to do so in the future. 2022-10-10 13:22:56 -0500ee00186816ceb16bee810c897fabe4deb660fcc3Adds commented-out line that prevents the monotonic fluxeditsrc/CLUBB_core/advance_xm_wpxp_module.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse275http://carson.math.uwm.edu/jenkins/job/clubb_G_unit_gfortran_tests/275/273http://carson.math.uwm.edu/jenkins/job/clubb_G_unit_gfortran_tests/273/Started by an SCM change10512407142b14155687d0d80b174796965d2793b1212407142b14155687d0d80b174796965d2793b12origin/master12407142b14155687d0d80b174796965d2793b1212407142b14155687d0d80b174796965d2793b12origin/master27272afa580969c647295ee087c7bf605c9bb6c01fe72afa580969c647295ee087c7bf605c9bb6c01ferefs/remotes/origin/master72afa580969c647295ee087c7bf605c9bb6c01fe72afa580969c647295ee087c7bf605c9bb6c01ferefs/remotes/origin/master72afa580969c647295ee087c7bf605c9bb6c01fe72afa580969c647295ee087c7bf605c9bb6c01ferefs/remotes/origin/masterhttps://github.com/larson-group/clubb.gitfalse#27262577982226clubb_G_unit_gfortran_tests #272272false27218352SUCCESS1665043868240http://carson.math.uwm.edu/jenkins/job/clubb_G_unit_gfortran_tests/272/src/clubb_driver.F90b00b88f36d25ff0fc15c2e6c66e09b29f7e5fc071664988430000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comMaking multicolumn version of advance_clubb_core in clubb_driver that accepts a number of columns to run clubb with. All bit-for-bit output on standalone cases, so the first column is correct. 2022-10-05 11:47:10 -0500b00b88f36d25ff0fc15c2e6c66e09b29f7e5fc07Making multicolumn version of advance_clubb_core in clubb_driver that accepts a number of columns to run clubb with. All bit-for-bit output on standalone cases, so the first column is correct.editsrc/clubb_driver.F90src/CLUBB_core/output_netcdf.F90input/tunable_parameters/configurable_model_flags.insrc/clubb_driver.F9052d5b77ea73abf368f0c947b448db59d05a7bf5b1664988430000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comImprovements. Netcdf output is now functional and we can detect errors with multiple columns even when the standard output is identical. 2022-10-05 11:47:10 -050052d5b77ea73abf368f0c947b448db59d05a7bf5bImprovements. Netcdf output is now functional and we can detect errors with multiple columns even when the standard output is identical.editsrc/CLUBB_core/output_netcdf.F90editinput/tunable_parameters/configurable_model_flags.ineditsrc/clubb_driver.F90src/clubb_driver.F908a6e980adc4fd5672287e789ee8f6248c8a585941664988430000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comNow the multicolumn netcdf output is correct. Adding comments too. larson-group/clubb#1033 2022-10-05 11:47:10 -05008a6e980adc4fd5672287e789ee8f6248c8a58594Now the multicolumn netcdf output is correct. Adding comments too. larson-group/clubb#1033editsrc/clubb_driver.F90src/clubb_driver.F9083b151bdb131134d178f58521f468b9bb78b1e7e1664988430000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comMade the multicolumn inout arrays save from timestep to timestep. This makes the extra columns more independent from the main column and allows differences in the extra columns to propagate more. larson-group/clubb#1033 2022-10-05 11:47:10 -050083b151bdb131134d178f58521f468b9bb78b1e7eMade the multicolumn inout arrays save from timestep to timestep. This makes the extra columns more independent from the main column and allows differences in the extra columns to propagate more. larson-group/clubb#1033editsrc/clubb_driver.F90src/clubb_driver.F90421981e323d84914a1fc2199030dc2d89b406d5c1664988430000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comAdding some fields to tweak for extra columns. This might be sufficient, the netcdf data for the column is similar but visually different, and I tested with up to 64 columns and there wasn't any crashes. larson-group/clubb#1033 2022-10-05 11:47:10 -0500421981e323d84914a1fc2199030dc2d89b406d5cAdding some fields to tweak for extra columns. This might be sufficient, the netcdf data for the column is similar but visually different, and I tested with up to 64 columns and there wasn't any crashes. larson-group/clubb#1033editsrc/clubb_driver.F90run_scripts/check_multicol_error.pyfd99b2bd5ba78d01880afc1887accd713fb39a301664988430000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comAdding script to compare netcdf outputs. This will print the max absolute diff and max percent diff for each field. This is made specifically for the multicolumn netcdf output. The script is not done, but this is the basics of it. larson-group/clubb#1033 2022-10-05 11:47:10 -0500fd99b2bd5ba78d01880afc1887accd713fb39a30Adding script to compare netcdf outputs. This will print the max absolute diff and max percent diff for each field. This is made specifically for the multicolumn netcdf output. The script is not done, but this is the basics of it. larson-group/clubb#1033addrun_scripts/check_multicol_error.pysrc/clubb_driver.F90970c22416c2751064f1e25d4a16024e3f126de2e1664988430000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comCasting 0.0 to correct precision that format_date wants. 2022-10-05 11:47:10 -0500970c22416c2751064f1e25d4a16024e3f126de2eCasting 0.0 to correct precision that format_date wants.editsrc/clubb_driver.F90run_scripts/check_multicol_error.pyc25baf3b9171190aab0cba7f7c0564677871cd631664988430000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comUpdating script to compare netcdf output. larson-group/clubb#1033 2022-10-05 11:47:10 -0500c25baf3b9171190aab0cba7f7c0564677871cd63Updating script to compare netcdf output. larson-group/clubb#1033editrun_scripts/check_multicol_error.pyinput/tunable_parameters/configurable_model_flags.inaf14d54b5dbe942882bfa6b67513b8f3781c5afc1664988430000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comUpdating column num input in config flags. larson-group/clubb#1033 2022-10-05 11:47:10 -0500af14d54b5dbe942882bfa6b67513b8f3781c5afcUpdating column num input in config flags. larson-group/clubb#1033editinput/tunable_parameters/configurable_model_flags.insrc/clubb_driver.F90f2cfc4fcd4059a5f5eb2f50efb478f49f22f24761664988430000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comAdding small check to allow configurable_multi_column_nl to be optional. If configurable_multi_column_nl is omitted from configurable_model_flags, then we assume we only want 1 column and a warning is printed. larson-group/clubb#1033 2022-10-05 11:47:10 -0500f2cfc4fcd4059a5f5eb2f50efb478f49f22f2476Adding small check to allow configurable_multi_column_nl to be optional. If configurable_multi_column_nl is omitted from configurable_model_flags, then we assume we only want 1 column and a warning is printed. larson-group/clubb#1033editsrc/clubb_driver.F90run_scripts/check_multicol_error.pyf848105748fb5819000d1244724dd3d04f45f4111664988430000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comSmall script update 2022-10-05 11:47:10 -0500f848105748fb5819000d1244724dd3d04f45f411Small script updateeditrun_scripts/check_multicol_error.pyrun_scripts/check_multicol_error.pye4980f9e4055a1191da42fa0dd175c77a5886d4d1664988430000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comAdding comments to script. 2022-10-05 11:47:10 -0500e4980f9e4055a1191da42fa0dd175c77a5886d4dAdding comments to script.editrun_scripts/check_multicol_error.pyinput/tunable_parameters/configurable_model_flags.insrc/clubb_driver.F9072afa580969c647295ee087c7bf605c9bb6c01fe1664988430000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comAdding comments, setting to num_standalone_columns=1 by default, and preventing multicolumn output when l_stats=false. larson-group/clubb#1033 2022-10-05 11:47:10 -050072afa580969c647295ee087c7bf605c9bb6c01feAdding comments, setting to num_standalone_columns=1 by default, and preventing multicolumn output when l_stats=false. larson-group/clubb#1033editinput/tunable_parameters/configurable_model_flags.ineditsrc/clubb_driver.F90githttp://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwmfalse273http://carson.math.uwm.edu/jenkins/job/clubb_G_unit_gfortran_tests/273/271http://carson.math.uwm.edu/jenkins/job/clubb_G_unit_gfortran_tests/271/