Started by an SCM change10512407142b14155687d0d80b174796965d2793b1212407142b14155687d0d80b174796965d2793b12origin/master12407142b14155687d0d80b174796965d2793b1212407142b14155687d0d80b174796965d2793b12origin/master230ed85915bbcd00d1dba9b17752de763547bfa429bed85915bbcd00d1dba9b17752de763547bfa429brefs/remotes/origin/mastered85915bbcd00d1dba9b17752de763547bfa429bed85915bbcd00d1dba9b17752de763547bfa429brefs/remotes/origin/mastered85915bbcd00d1dba9b17752de763547bfa429bed85915bbcd00d1dba9b17752de763547bfa429brefs/remotes/origin/masterhttps://github.com/larson-group/clubb.githttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_G_unit_gfortran_tests/detail/clubb_G_unit_gfortran_tests/230/artifactshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_G_unit_gfortran_tests/detail/clubb_G_unit_gfortran_tests/230/changeshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_G_unit_gfortran_tests/detail/clubb_G_unit_gfortran_tests/230/http://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_G_unit_gfortran_tests/detail/clubb_G_unit_gfortran_tests/230/testsfalsefalse#230123818882226clubb_G_unit_gfortran_tests #230230false23015716SUCCESS1654157467490http://carson.math.uwm.edu/jenkins/job/clubb_G_unit_gfortran_tests/230/jenkins_tests/clubb_bin_diff_regression_gfortran_test/Jenkinsfilejenkins_tests/clubb_bin_diff_regression_gfortran_test_new/Jenkinsfilejenkins_tests/clubb_bin_diff_regression_gfortran_test_old/Jenkinsfiled3e945d16e887b46b07827c135f73d33831fa9001654109323000http://carson.math.uwm.edu/jenkins/user/pbroelspbroelspbroels@uwm.eduChanged clubb_bin_diff_regression_gfortran_test_new to clubb_bin_diff_regression_gfortran_test and clubb_bin_diff_regression_gfortran_test to clubb_bin_diff_regression_gfortran_test_old to reflect current usage. 2022-06-01 13:48:43 -0500d3e945d16e887b46b07827c135f73d33831fa900Changed clubb_bin_diff_regression_gfortran_test_new to clubb_bin_diff_regression_gfortran_test and clubb_bin_diff_regression_gfortran_test to clubb_bin_diff_regression_gfortran_test_old to reflect current usage.editjenkins_tests/clubb_bin_diff_regression_gfortran_test/Jenkinsfileaddjenkins_tests/clubb_bin_diff_regression_gfortran_test_old/Jenkinsfiledeletejenkins_tests/clubb_bin_diff_regression_gfortran_test_new/JenkinsfileREADME291e87da51321a48b5c9d5c46e6b4459b51ab2a41654109959000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comThis commit is not bit changing 2022-06-01 13:59:19 -0500291e87da51321a48b5c9d5c46e6b4459b51ab2a4This commit is not bit changingeditREADMEREADME0ff480f574ef756272df942a2cd6e217fba760e21654110299000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comThis commt is not bit changing But commit e4f125ba067ba8083f917e0e06b6b2398483d3e4 was BIT_CHANGING for simulations that use silhs 2022-06-01 14:04:59 -05000ff480f574ef756272df942a2cd6e217fba760e2This commt is not bit changingeditREADMEsrc/CLUBB_core/new_hybrid_pdf_main.F90src/G_unit_test_types/pdf_parameter_tests.F90src/G_unit_test_types/spurious_source_test.F90src/CLUBB_core/new_pdf_main.F90aa26820b4f080d4a8721dd0f578737344061f9a31654112656000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduThe G_unit tests never allocated pdf_implicit_coefs_terms. It's unclear to me how these were working before, but it seems that something about making these 2D allocatable arrays exposed the bug. 2022-06-01 14:44:16 -0500aa26820b4f080d4a8721dd0f578737344061f9a3The G_unit tests never allocated pdf_implicit_coefs_terms. It's unclear to me how these were working before, but it seems that something about making these 2D allocatable arrays exposed the bug.editsrc/G_unit_test_types/spurious_source_test.F90editsrc/CLUBB_core/new_pdf_main.F90editsrc/CLUBB_core/new_hybrid_pdf_main.F90editsrc/G_unit_test_types/pdf_parameter_tests.F90src/CLUBB_core/advance_xp2_xpyp_module.F90b736467752bbdc37c77ea2504d0b4ffcc7383ac81654117361000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking zt2zm calls with pdf_implicit_coefs_terms use the 2D version. 2022-06-01 16:02:41 -0500b736467752bbdc37c77ea2504d0b4ffcc7383ac8Making zt2zm calls with pdf_implicit_coefs_terms use the 2D version.editsrc/CLUBB_core/advance_xp2_xpyp_module.F90src/CLUBB_core/clubb_api_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/clubb_driver.F908b9b43ecb1c82b2a06882613bbe7e2e61b86e0af1654122180000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduRemoving setup_grid and setup_parameters functionality from setup_clubb_core. This is beacuse in host models the required grid information may not be known during the setup process, resulting in dummy arguments for setup_clubb_core and the grid and paramters being setup during runtime anyway. Now, in the host models we can call these subroutines immediately after setup_clubb_core to maintain identical functionality (sam, wrf), and in others we can wait to call these until the main timestepping procedure (cam,e3sm). 2022-06-01 17:23:00 -05008b9b43ecb1c82b2a06882613bbe7e2e61b86e0afRemoving setup_grid and setup_parameters functionality from setup_clubb_core. This is beacuse in host models the required grid information may not be known during the setup process, resulting in dummy arguments for setup_clubb_core and the grid and paramters being setup during runtime anyway. Now, in the host models we can call these subroutines immediately after setup_clubb_core to maintain identical functionality (sam, wrf), and in others we can wait to call these until the main timestepping procedure (cam,e3sm).editsrc/CLUBB_core/clubb_api_module.F90editsrc/clubb_driver.F90editsrc/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/parameters_tunable.F90src/G_unit_test_types/spurious_source_test.F90src/CLUBB_core/grid_class.F90src/CLUBB_core/clubb_api_module.F90ed85915bbcd00d1dba9b17752de763547bfa429b1654129942000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking 2D versions of setup_grid and setup_parameters. 2022-06-01 19:32:22 -0500ed85915bbcd00d1dba9b17752de763547bfa429bMaking 2D versions of setup_grid and setup_parameters.editsrc/G_unit_test_types/spurious_source_test.F90editsrc/CLUBB_core/grid_class.F90editsrc/CLUBB_core/parameters_tunable.F90editsrc/CLUBB_core/clubb_api_module.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhueblerhttp://carson.math.uwm.edu/jenkins/user/pbroelspbroelspbroelsfalseStarted by an SCM change10512407142b14155687d0d80b174796965d2793b1212407142b14155687d0d80b174796965d2793b12origin/master12407142b14155687d0d80b174796965d2793b1212407142b14155687d0d80b174796965d2793b12origin/master23150a3080a1374291f321eae16b2806e0753e09b2750a3080a1374291f321eae16b2806e0753e09b27refs/remotes/origin/master50a3080a1374291f321eae16b2806e0753e09b2750a3080a1374291f321eae16b2806e0753e09b27refs/remotes/origin/master50a3080a1374291f321eae16b2806e0753e09b2750a3080a1374291f321eae16b2806e0753e09b27refs/remotes/origin/masterhttps://github.com/larson-group/clubb.gitfalse#23123531582226clubb_G_unit_gfortran_tests #231231false23115786SUCCESS1654243868242http://carson.math.uwm.edu/jenkins/job/clubb_G_unit_gfortran_tests/231/src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/parameters_tunable.F90src/CLUBB_core/clubb_api_module.F90src/CLUBB_core/mixing_length.F902230f5a91f09608cc496fba43d68e0d454049a981654197815000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking lmin a scalar again, twas a mistake to make it an array, it can only take on one value. 2022-06-02 14:23:35 -05002230f5a91f09608cc496fba43d68e0d454049a98Making lmin a scalar again, twas a mistake to make it an array, it can only take on one value.editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/parameters_tunable.F90editsrc/CLUBB_core/mixing_length.F90editsrc/CLUBB_core/clubb_api_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/advance_windm_edsclrm_module.F90src/CLUBB_core/parameters_tunable.F90src/CLUBB_core/advance_wp2_wp3_module.F90src/G_unit_test_types/spurious_source_test.F90src/CLUBB_core/clubb_api_module.F90src/advance_microphys_module.F90src/CLUBB_core/advance_xp2_xpyp_module.F9050a3080a1374291f321eae16b2806e0753e09b271654200656000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking nu_vert_res_dep a type containing arrays, as opposed to being an array of types. 2022-06-02 15:10:56 -050050a3080a1374291f321eae16b2806e0753e09b27Making nu_vert_res_dep a type containing arrays, as opposed to being an array of types.editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/advance_xp2_xpyp_module.F90editsrc/advance_microphys_module.F90editsrc/CLUBB_core/clubb_api_module.F90editsrc/G_unit_test_types/spurious_source_test.F90editsrc/CLUBB_core/parameters_tunable.F90editsrc/CLUBB_core/advance_windm_edsclrm_module.F90editsrc/CLUBB_core/advance_wp2_wp3_module.F90editsrc/CLUBB_core/advance_xm_wpxp_module.F90githttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse232http://carson.math.uwm.edu/jenkins/job/clubb_G_unit_gfortran_tests/232/230http://carson.math.uwm.edu/jenkins/job/clubb_G_unit_gfortran_tests/230/Started by an SCM change10512407142b14155687d0d80b174796965d2793b1212407142b14155687d0d80b174796965d2793b12origin/master12407142b14155687d0d80b174796965d2793b1212407142b14155687d0d80b174796965d2793b12origin/master2298f73b8fa6467a67ca4127c0d17000136433cf29f8f73b8fa6467a67ca4127c0d17000136433cf29frefs/remotes/origin/master8f73b8fa6467a67ca4127c0d17000136433cf29f8f73b8fa6467a67ca4127c0d17000136433cf29frefs/remotes/origin/master8f73b8fa6467a67ca4127c0d17000136433cf29f8f73b8fa6467a67ca4127c0d17000136433cf29frefs/remotes/origin/masterhttps://github.com/larson-group/clubb.gitfalse#229143760182226clubb_G_unit_gfortran_tests #229229false22915646FAILURE1654071067073http://carson.math.uwm.edu/jenkins/job/clubb_G_unit_gfortran_tests/229/src/CLUBB_core/new_hybrid_pdf_main.F90src/CLUBB_core/advance_wp2_wp3_module.F90src/CLUBB_core/advance_xp3_module.F90src/CLUBB_core/pdf_closure_module.F90src/CLUBB_core/grid_class.F90src/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90src/CLUBB_core/sponge_layer_damping.F90src/CLUBB_core/stats_type_utilities.F90src/CLUBB_core/mixing_length.F90src/microphys_driver.F90src/CLUBB_core/advance_windm_edsclrm_module.F90src/advance_microphys_module.F90src/CLUBB_core/stats_clubb_utilities.F90src/CLUBB_core/mono_flux_limiter.F90src/G_unit_test_types/pdf_parameter_tests.F90src/CLUBB_core/advance_helper_module.F90src/CLUBB_core/new_tsdadg_pdf.F90src/CLUBB_core/LY93_pdf.F90src/CLUBB_core/clip_explicit.F90src/CLUBB_core/numerical_check.F90src/CLUBB_core/new_pdf.F90src/CLUBB_core/advance_xp2_xpyp_module.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/turbulent_adv_pdf.F90src/clubb_driver.F90src/CLUBB_core/clubb_api_module.F90src/CLUBB_core/setup_clubb_pdf_params.F90src/CLUBB_core/fill_holes.F90src/CLUBB_core/new_pdf_main.F90src/CLUBB_core/pos_definite_module.F90e8deb21c70b21643aee441c04fa17278ac8d7c911654031468000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAlmost final loop pushes (#1012) * Pushing loop into clip_rcm * Pushing column loop into trapezoid routines. * Pushing column loop into clip_covar routines. * Pushing column loop into clip_variance and clip_skewness. * Replacing sgn_turbulent_velocity with built in fortran sign * Removing gr from argument list of stats calls, replacing with just nz * Replacing some usages of gr with just the number of vertical levels * Replacing some usages of gr with just the number of vertical levels again * Missed a couple files to commit * Pushing some loops and removing need for gr to be passed into some routines. * Pushing loop into advance_xp3 * Pushing loop into mixing length * Some more loop pushing * Pushing some loops into mono_flux limit, skipping the lhs routine since it's a bit tricky at the moment, will do after change to grid class. * Removing gr from argument list of stats accumulate * Precalculating zt2zm so that we can use 2d version * Precalculating um/vm ddzt so that we can use 2d version * Precalculating things to use 2d version of zt2zm * Making 2d version of cubic interp for grid class * Small modifications to sponge damping code argument lists * Renaming some variables 2022-05-31 16:11:08 -0500e8deb21c70b21643aee441c04fa17278ac8d7c91Almost final loop pushes (#1012)editsrc/CLUBB_core/new_pdf.F90editsrc/CLUBB_core/new_pdf_main.F90editsrc/CLUBB_core/pdf_closure_module.F90editsrc/CLUBB_core/advance_helper_module.F90editsrc/CLUBB_core/setup_clubb_pdf_params.F90editsrc/CLUBB_core/LY93_pdf.F90editsrc/CLUBB_core/advance_xp2_xpyp_module.F90editsrc/CLUBB_core/numerical_check.F90editsrc/CLUBB_core/pos_definite_module.F90editsrc/CLUBB_core/adg1_adg2_3d_luhar_pdf.F90editsrc/CLUBB_core/stats_type_utilities.F90editsrc/microphys_driver.F90editsrc/CLUBB_core/advance_wp2_wp3_module.F90editsrc/advance_microphys_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/grid_class.F90editsrc/CLUBB_core/advance_xm_wpxp_module.F90editsrc/CLUBB_core/clip_explicit.F90editsrc/CLUBB_core/advance_xp3_module.F90editsrc/clubb_driver.F90editsrc/CLUBB_core/advance_windm_edsclrm_module.F90editsrc/CLUBB_core/stats_clubb_utilities.F90editsrc/CLUBB_core/fill_holes.F90editsrc/CLUBB_core/mono_flux_limiter.F90editsrc/CLUBB_core/mixing_length.F90editsrc/CLUBB_core/new_tsdadg_pdf.F90editsrc/CLUBB_core/clubb_api_module.F90editsrc/CLUBB_core/new_hybrid_pdf_main.F90editsrc/G_unit_test_types/pdf_parameter_tests.F90editsrc/CLUBB_core/turbulent_adv_pdf.F90editsrc/CLUBB_core/sponge_layer_damping.F90microphysics.F907a9a332ece44f0a0ee2210d5fa63d63fb93a19b81654040073000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking compatible with latest clubb change. 2022-05-31 18:34:33 -05007a9a332ece44f0a0ee2210d5fa63d63fb93a19b8Making compatible with latest clubb change.editmicrophysics.F90src/CLUBB_core/new_hybrid_pdf_main.F90src/CLUBB_core/advance_clubb_core_module.F90src/CLUBB_core/advance_xm_wpxp_module.F90src/CLUBB_core/advance_wp2_wp3_module.F90src/G_unit_test_types/spurious_source_test.F90src/clubb_driver.F90src/CLUBB_core/clubb_api_module.F90src/CLUBB_core/pdf_closure_module.F90src/G_unit_test_types/pdf_parameter_tests.F90src/CLUBB_core/new_pdf_main.F90src/CLUBB_core/pdf_parameter_module.F90src/CLUBB_core/advance_xp2_xpyp_module.F901e537bac5d385007334ca3a6f2b16a17ae0016e21654040788000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comMaking pdf_implicit_coefs_terms a type containing 2D arrays. (#1014) 2022-05-31 18:46:28 -05001e537bac5d385007334ca3a6f2b16a17ae0016e2Making pdf_implicit_coefs_terms a type containing 2D arrays. (#1014)editsrc/CLUBB_core/new_hybrid_pdf_main.F90editsrc/CLUBB_core/new_pdf_main.F90editsrc/CLUBB_core/pdf_parameter_module.F90editsrc/CLUBB_core/advance_clubb_core_module.F90editsrc/CLUBB_core/advance_xp2_xpyp_module.F90editsrc/CLUBB_core/clubb_api_module.F90editsrc/CLUBB_core/pdf_closure_module.F90editsrc/CLUBB_core/advance_wp2_wp3_module.F90editsrc/CLUBB_core/advance_xm_wpxp_module.F90editsrc/G_unit_test_types/spurious_source_test.F90editsrc/G_unit_test_types/pdf_parameter_tests.F90editsrc/clubb_driver.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse230http://carson.math.uwm.edu/jenkins/job/clubb_G_unit_gfortran_tests/230/228http://carson.math.uwm.edu/jenkins/job/clubb_G_unit_gfortran_tests/228/