Started by an SCM change534e25ec88b5e538d090d1d634e3602cf637a24251ce25ec88b5e538d090d1d634e3602cf637a24251crefs/remotes/origin/mastere25ec88b5e538d090d1d634e3602cf637a24251ce25ec88b5e538d090d1d634e3602cf637a24251crefs/remotes/origin/mastere25ec88b5e538d090d1d634e3602cf637a24251ce25ec88b5e538d090d1d634e3602cf637a24251crefs/remotes/origin/masterhttps://github.com/larson-group/clubb.githttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_BFB_gfortran_test/detail/clubb_BFB_gfortran_test/534/artifactshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_BFB_gfortran_test/detail/clubb_BFB_gfortran_test/534/changeshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_BFB_gfortran_test/detail/clubb_BFB_gfortran_test/534/http://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/clubb_BFB_gfortran_test/detail/clubb_BFB_gfortran_test/534/testsfalsefalse#534529132847420clubb_BFB_gfortran_test #534534false5348693SUCCESS1744705749195http://carson.math.uwm.edu/jenkins/job/clubb_BFB_gfortran_test/534/READMEe25ec88b5e538d090d1d634e3602cf637a24251c1744653060000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdd a blank line to README in order to note BIT_CHANGING:969bc4aa2a1db2664c0f92b98d2df5544c554c32 However, the change is only to stats output, not the answer itself. See https://github.com/larson-group/clubb/issues/1170#issuecomment-2802019464. 2025-04-14 12:51:00 -0500e25ec88b5e538d090d1d634e3602cf637a24251cAdd a blank line to README in order to note BIT_CHANGING:969bc4aa2a1db2664c0f92b98d2df5544c554c32editREADMEgithttp://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreplyfalseStarted by an SCM change535fa5edf3c9549a7bf9b076506514aa7445f322c43fa5edf3c9549a7bf9b076506514aa7445f322c43refs/remotes/origin/masterfa5edf3c9549a7bf9b076506514aa7445f322c43fa5edf3c9549a7bf9b076506514aa7445f322c43refs/remotes/origin/masterfa5edf3c9549a7bf9b076506514aa7445f322c43fa5edf3c9549a7bf9b076506514aa7445f322c43refs/remotes/origin/masterhttps://github.com/larson-group/clubb.gitfalse#535639543847420clubb_BFB_gfortran_test #535535false5358759FAILURE1745396947092http://carson.math.uwm.edu/jenkins/job/clubb_BFB_gfortran_test/535/src/CLUBB_core/parameters_tunable.F90cb9c724afbacef68636111b671d273df57166a6d1745348257000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI updated adj_low_res_nu for use with a generalized grid. It is not called from within advance_clubb_core or from within SILHS. It is not necessary to be generalized for tests within standalone CLUBB. However, it is necessary to generalize this code for use within host models, particularly for CAM and E3SM. 2025-04-22 13:57:37 -0500cb9c724afbacef68636111b671d273df57166a6dI updated adj_low_res_nu for use with a generalized grid. It iseditsrc/CLUBB_core/parameters_tunable.F90src/G_unit_test_types/rev_direction_grid_test.F90fa5edf3c9549a7bf9b076506514aa7445f322c431745356651000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduSince the call to adj_low_res_nu is not tested by CLUBB's main ascending vs descending grid test (since it is not called from within advance_clubb_core or from SILHS), I added it to the reverse grid direction G Unit test so that the results from ascending vs. descending grids get checked. 2025-04-22 16:17:31 -0500fa5edf3c9549a7bf9b076506514aa7445f322c43Since the call to adj_low_res_nu is not tested by CLUBB's maineditsrc/G_unit_test_types/rev_direction_grid_test.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2false536http://carson.math.uwm.edu/jenkins/job/clubb_BFB_gfortran_test/536/534http://carson.math.uwm.edu/jenkins/job/clubb_BFB_gfortran_test/534/Started by user Vince LarsonvlarsonVince Larson5332f9bef63460fadecdb3f3679ef29d18beafba72e2f9bef63460fadecdb3f3679ef29d18beafba72erefs/remotes/origin/master2f9bef63460fadecdb3f3679ef29d18beafba72e2f9bef63460fadecdb3f3679ef29d18beafba72erefs/remotes/origin/master2f9bef63460fadecdb3f3679ef29d18beafba72e2f9bef63460fadecdb3f3679ef29d18beafba72erefs/remotes/origin/masterhttps://github.com/larson-group/clubb.gitfalse#533718721847420clubb_BFB_gfortran_test #533533false5338581SUCCESS1744225315615http://carson.math.uwm.edu/jenkins/job/clubb_BFB_gfortran_test/533/src/clubb_driver.F90src/generalized_grid_test.F90run_scripts/run_bindiff_w_flags_config_core_flags.jsonsrc/SILHS/silhs_api_module.F90src/CLUBB_core/setup_clubb_pdf_params.F90src/SILHS/latin_hypercube_driver_module.F90compile/file_list/clubb_model_filessrc/pdf_hydromet_microphys_wrapper.F90src/CLUBB_core/precipitation_fraction.F902f9bef63460fadecdb3f3679ef29d18beafba72e1744204547000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comClubb silhs gg (#1239) * I added new subroutine pdf_hydromet_microphys_prep to encompass the code that calls the hydrometeor PDF and then ultimately handles the setup of SILHS sample points when SILHS is in use. * Placeholder subroutine for SILHS grid generalization test. * I have now connected the new subroutine to run_clubb. The results for all cases match bit-for-bit to the previous revision. * Cleaning up from the refactoring of the hydrometeor PDF and SILHS code into a wrapper subroutine. * I'm moving pdf_hydromet_microphys_prep to its own file to avoid circular dependency once it finally needs to be called from the generalized grid test code soon. * Added some code to the SILHS generalized grid test. * Changes to make this a fully functioning grid generalization test for the part of the microphysics code that encompasses setup_pdf_parameters and hydrometeor_mixed_moments. * I have completed the code for the SILHS generalized grid test. * I generalized precipitation fraction for ascending vs. descending grid. * Fixing a bug that I noticed in the precipitation fraction calculation when the component precip frac calculation was set to option 1 (which is currently not the default). * The code should now be successfully grid-generalized for SILHS. The ascending vs descending grid test should work now for all cases. * Updating the core flags .json file to change some of the SILHS flags. * I moved the call to advance_clubb_core_api (the default run option) to the top of the "if" block, ahead of the grid generalization test option that is now in the "else" block. * Adding a new, hardwired constant flag called l_ascending_grid and setting it to true in clubb_driver.F90. * Keeping lines under 100 characters in length. * Making it so the ascending vs. descending grid tests pass for the l_lh_random_start flag. 2025-04-09 08:15:47 -05002f9bef63460fadecdb3f3679ef29d18beafba72eClubb silhs gg (#1239)editsrc/SILHS/silhs_api_module.F90editcompile/file_list/clubb_model_fileseditsrc/CLUBB_core/setup_clubb_pdf_params.F90editsrc/CLUBB_core/precipitation_fraction.F90editrun_scripts/run_bindiff_w_flags_config_core_flags.jsoneditsrc/SILHS/latin_hypercube_driver_module.F90addsrc/pdf_hydromet_microphys_wrapper.F90editsrc/clubb_driver.F90editsrc/generalized_grid_test.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse534http://carson.math.uwm.edu/jenkins/job/clubb_BFB_gfortran_test/534/532http://carson.math.uwm.edu/jenkins/job/clubb_BFB_gfortran_test/532/