Started by an SCM change756fc57497840efaa7acc394c10ac9c6892ef162206fc57497840efaa7acc394c10ac9c6892ef16220origin/clubb_silhs_devel6fc57497840efaa7acc394c10ac9c6892ef162206fc57497840efaa7acc394c10ac9c6892ef16220origin/clubb_silhs_devel637250e6e77b4c4a4210456e16ddaaa278401e8ae47250e6e77b4c4a4210456e16ddaaa278401e8ae4refs/remotes/origin/changes_to_not_break7250e6e77b4c4a4210456e16ddaaa278401e8ae47250e6e77b4c4a4210456e16ddaaa278401e8ae4refs/remotes/origin/changes_to_not_break424c26d4422b4325a4b592a93dc92e93bb70adf84b0c26d4422b4325a4b592a93dc92e93bb70adf84b0refs/remotes/origin/clubb_silhs_develc26d4422b4325a4b592a93dc92e93bb70adf84b0c26d4422b4325a4b592a93dc92e93bb70adf84b0refs/remotes/origin/clubb_silhs_develc26d4422b4325a4b592a93dc92e93bb70adf84b0c26d4422b4325a4b592a93dc92e93bb70adf84b0refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#42410624201520216cam_scam_gfortran_debug_test #424424false4243382SUCCESS1728117967626http://carson.math.uwm.edu/jenkins/job/cam_scam_gfortran_debug_test/424/fill_holes.F90saturation.F90advance_clubb_core_module.F90parameters_tunable.F90clubb_api_module.F90e25a2a10f127157f8f597674d2b1a2478dc96a7c1728050904000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comrefactoring to remove compiler warnings (#1187) * refactor code to remove warnings for exceeding 100 characters per line * remove unused variables * remove unused parameters #1174 * fix for the GPU * remove new unused parameters * remove unused dummy arguments * make small changes to reduce compiler warnings * put solve_name back in as input variable to band_solve methods * combine intent in and out parameters from calc_trapezoid_zm and calc_trapezoid_zt to intent inout parameters * remove unused functions init_parameters_999 and sat_vapor_press_ice_* * remove unused dummy arguments * fix merge error * remove unnecessary loop 2024-10-04 09:08:24 -0500e25a2a10f127157f8f597674d2b1a2478dc96a7crefactoring to remove compiler warnings (#1187)editadvance_clubb_core_module.F90editclubb_api_module.F90editparameters_tunable.F90editfill_holes.F90editsaturation.F90silhs_api_module.F90ade7da06f81dbd0fc358fb9ca8e63a50b95386641728050904000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comrefactoring to remove compiler warnings (#1187) * refactor code to remove warnings for exceeding 100 characters per line * remove unused variables * remove unused parameters #1174 * fix for the GPU * remove new unused parameters * remove unused dummy arguments * make small changes to reduce compiler warnings * put solve_name back in as input variable to band_solve methods * combine intent in and out parameters from calc_trapezoid_zm and calc_trapezoid_zt to intent inout parameters * remove unused functions init_parameters_999 and sat_vapor_press_ice_* * remove unused dummy arguments * fix merge error * remove unnecessary loop 2024-10-04 09:08:24 -0500ade7da06f81dbd0fc358fb9ca8e63a50b9538664refactoring to remove compiler warnings (#1187)editsilhs_api_module.F90src/physics/cam/clubb_intr.F90src/physics/cam/subcol_SILHS.F9007ecf4a3bc8df6091e7820434d4ccc473e5dcb051728051376000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comremove unused dummy arguments (#182) These CAM changes correspond to CLUBB changes larson-group/clubb#1174 and larson-group/clubb#1187. 2024-10-04 09:16:16 -050007ecf4a3bc8df6091e7820434d4ccc473e5dcb05remove unused dummy arguments (#182)editsrc/physics/cam/clubb_intr.F90editsrc/physics/cam/subcol_SILHS.F90grid_class.F90919336b9bc062541373a38408c9db3bc104f92e01728074121000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am copying the round-off level changes made to grid weights and grid interpolation functions from the generalized_grid branch over to the master branch. This is being done ahead of merging code from the master over to the generalized_grid branch. This code is necessary to get results in the generalized grid branch bit-for-bit between ascending and descending grid directions when optimization is set to -O0. This change produces changes at the numerical round-off level in the affected calculations, making this commit BIT_CHANGING. Plots show lines overlap for almost all cases besides the most sensitive cases (ARM 97, TWP ICE, etc. -- looking at those shows you how much of a difference a simple numerical round-off can make). 2024-10-04 15:35:21 -0500919336b9bc062541373a38408c9db3bc104f92e0I am copying the round-off level changes made to grid weightseditgrid_class.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse425http://carson.math.uwm.edu/jenkins/job/cam_scam_gfortran_debug_test/425/423http://carson.math.uwm.edu/jenkins/job/cam_scam_gfortran_debug_test/423/