Started by an SCM change0000319147131902641.089238926132003948920892019089f9bf13959f92463d0a171d7e710658edf4f5b389f9bf13959f92463d0a171d7e710658edf4f5b3refs/remotes/origin/clubb_silhs_devel89f9bf13959f92463d0a171d7e710658edf4f5b389f9bf13959f92463d0a171d7e710658edf4f5b3refs/remotes/origin/clubb_silhs_devel89f9bf13959f92463d0a171d7e710658edf4f5b389f9bf13959f92463d0a171d7e710658edf4f5b3refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.githttps://carson.math.uwm.edu/jenkins/job/cam_gpu_test/lastSuccessfulBuild/artifacthttps://carson.math.uwm.edu/jenkins/job/cam_gpu_test/changeshttps://carson.math.uwm.edu/jenkins/job/cam_gpu_test/lastSuccessfulBuild/stageshttps://carson.math.uwm.edu/jenkins/job/cam_gpu_test/lastSuccessfulBuild/testReportfalseCheckout Externals and Copy Custom FilesRemove Old OutputRunning ne3 with OpenACCfalse#19031914714137974cam_gpu_test #190190false19011119SUCCESS1792484169774https://carson.math.uwm.edu/jenkins/job/cam_gpu_test/190/src/physics/cam/subcol_SILHS.F903950c5d9b171085dc680b0504c5acfb32e561b331792461786000https://carson.math.uwm.edu/jenkins/user/shellwitzshellwitzshellwitz@thinkpad-E590.localhost model fix for clubb PR 1392. setup_pdf_parameters_api expects a 2d array insead of 1d -> spread clubb_params_single_col 2026-10-19 21:03:06 -05003950c5d9b171085dc680b0504c5acfb32e561b33host model fix for clubb PR 1392.editsrc/physics/cam/subcol_SILHS.F90fill_holes.F90precipitation_fraction.F90setup_clubb_pdf_params.F90ba52dc68541c0f25db8ccc5e18043b92c00b8fe01792463005000https://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comClubb params 1d to 2d fix (#1392) * Fix: clubb params is a shape (ngrdcol,nparams) that is passed into subroutines that expect a 1d array Also fixed dependent other places in code and changed the python api. This is BIT_CHANGING for multicol. If a 2d array is passed into a function that expects the arr to be 1d fortran just passes the first col of the arr. Therefore the changes dont affect single col runs. For multicol runs other indexing is needed * fill_holes_vertical_api expects the passed gr%dzt to have shape(ngrdcol,nz) but the code passes the whole gr%dzt array although each column is traversed one by one. So ngrdcol=1 is passed each time. No effect on single col, as with ngrdcol = 1, gr%dzt and gr%dzt(1:1,:) are the same. Affects multicol if l_hole_fill = .true. and the hydrometeor is a mixing ratio (name starts with r) and some value is actually negative Therefore BIT_CHANGING 2026-10-19 21:23:25 -0500ba52dc68541c0f25db8ccc5e18043b92c00b8fe0Clubb params 1d to 2d fix (#1392)editfill_holes.F90editprecipitation_fraction.F90editsetup_clubb_pdf_params.F90githttps://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreplyhttps://carson.math.uwm.edu/jenkins/user/shellwitzshellwitzshellwitzfalseStarted by an SCM change0000576461157633471.01701570151891eca30798f2886be7d8594c8826320737b7a76cd1eca30798f2886be7d8594c8826320737b7a76cdrefs/remotes/origin/clubb_silhs_devel1eca30798f2886be7d8594c8826320737b7a76cd1eca30798f2886be7d8594c8826320737b7a76cdrefs/remotes/origin/clubb_silhs_devel1eca30798f2886be7d8594c8826320737b7a76cd1eca30798f2886be7d8594c8826320737b7a76cdrefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#18957646114137974cam_gpu_test #189189false18910505SUCCESS1791965768414https://carson.math.uwm.edu/jenkins/job/cam_gpu_test/189/calc_roots.F9076464de9f694cb3148b0ae07f9eb0098afc4a4e41791911400000https://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comFixed bug in cubic equation solve function. Only relevant if pdf is L… (#1387) * Fixed bug in cubic equation solve function. Only relevant if pdf is Luhar or iiPDF_type=4 Therefore technically BIT_CHANGING... The bug existed because the old code used the principal cube root which has an imaginary part for negative bases. The fix is to simply calc: -|w|**(1/3) for negative real numbers. * Replaced determinant with discriminant Verified via a new Fortran unit test and also manually checked with wolfram alpha. There is no way to actually run this code :/ would only work for iiPDF_types: iiPDF_3D_Luhar = 3 and iiPDF_3D_Luhar = 3 (and those are currently (Oct 2026) broken ) 2026-10-13 12:10:00 -050076464de9f694cb3148b0ae07f9eb0098afc4a4e4Fixed bug in cubic equation solve function. Only relevant if pdf is L… (#1387)editcalc_roots.F90githttps://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse190https://carson.math.uwm.edu/jenkins/job/cam_gpu_test/190/188https://carson.math.uwm.edu/jenkins/job/cam_gpu_test/188/