Started by an SCM change746fc57497840efaa7acc394c10ac9c6892ef162206fc57497840efaa7acc394c10ac9c6892ef16220origin/clubb_silhs_devel6fc57497840efaa7acc394c10ac9c6892ef162206fc57497840efaa7acc394c10ac9c6892ef16220origin/clubb_silhs_devel69cca799cfb394e7eeadc21211ae811b4a370d31eecca799cfb394e7eeadc21211ae811b4a370d31eeorigin/changes_to_not_breakcca799cfb394e7eeadc21211ae811b4a370d31eecca799cfb394e7eeadc21211ae811b4a370d31eeorigin/changes_to_not_break365ddd334ee5c7d9ce02588dce06ab537065670fbcfddd334ee5c7d9ce02588dce06ab537065670fbcfrefs/remotes/origin/clubb_silhs_develddd334ee5c7d9ce02588dce06ab537065670fbcfddd334ee5c7d9ce02588dce06ab537065670fbcfrefs/remotes/origin/clubb_silhs_develddd334ee5c7d9ce02588dce06ab537065670fbcfddd334ee5c7d9ce02588dce06ab537065670fbcfrefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.githttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/cam_global_ERP_Ln9_gfortran_test/detail/cam_global_ERP_Ln9_gfortran_test/365/artifactshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/cam_global_ERP_Ln9_gfortran_test/detail/cam_global_ERP_Ln9_gfortran_test/365/changeshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/cam_global_ERP_Ln9_gfortran_test/detail/cam_global_ERP_Ln9_gfortran_test/365/http://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/cam_global_ERP_Ln9_gfortran_test/detail/cam_global_ERP_Ln9_gfortran_test/365/testsfalseCheckout Externals and Copy Custom FilesRun CAMfalse#36524570443605478cam_global_ERP_Ln9_gfortran_test #365365false3651415SUCCESS1714726085106http://carson.math.uwm.edu/jenkins/job/cam_global_ERP_Ln9_gfortran_test/365/advance_xm_wpxp_module.F900e6f459a8ca2110f661d78019a1f717ff9b9407a1714680265000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am committing code that effectively ignores the values of certain zt stats at the ghost level by setting them to 0. This is done to allow for bit-for-bitness comparisons between the master branch and the clubb_ghost_exorcism branch. Technically, since zt stat file output at the irrelevant ghost level is changed for some variables, this commit is BIT_CHANGING. Effectively, this commit doesn't change squat in terms of model results. 2024-05-02 15:04:25 -05000e6f459a8ca2110f661d78019a1f717ff9b9407aI am committing code that effectively ignores the values of certaineditadvance_xm_wpxp_module.F90advance_xm_wpxp_module.F904b4adc89f8fe60d9e9f89fadcab3f1f6c94992501714685456000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am moving the advance_xm_wpxp setting of xm(1) = xm(2) from the end of xm_clipping_and_stats to the very end of advance_xm_wpxp, right before the return to advance_clubb_core. The reason I am doing this is the nudging was done after setting xm(1) = xm(2) and would alter the results. This is no longer the case, as setting xm(1) = xm(2) is now being done after nudging. This is being done in advance of removal of the ghost point from CLUBB. This helps ensure a bit-for-bit match between the ghost exorcism branch and the master branch. This commit technically alter fields such as um, vm, um_bt, vm_bt, wpup2, wpvp2, and shear at level 1 only. Thus, this commit is technically BIT_CHANGING. Effectively, once again, this commit doesn't change squat. 2024-05-02 16:30:56 -05004b4adc89f8fe60d9e9f89fadcab3f1f6c9499250I am moving the advance_xm_wpxp setting of xm(1) = xm(2) from theeditadvance_xm_wpxp_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2falseStarted by an SCM change746fc57497840efaa7acc394c10ac9c6892ef162206fc57497840efaa7acc394c10ac9c6892ef16220origin/clubb_silhs_devel6fc57497840efaa7acc394c10ac9c6892ef162206fc57497840efaa7acc394c10ac9c6892ef16220origin/clubb_silhs_devel69cca799cfb394e7eeadc21211ae811b4a370d31eecca799cfb394e7eeadc21211ae811b4a370d31eeorigin/changes_to_not_breakcca799cfb394e7eeadc21211ae811b4a370d31eecca799cfb394e7eeadc21211ae811b4a370d31eeorigin/changes_to_not_break366fb32238016885fa5709f0ff4152dbfe55db02109fb32238016885fa5709f0ff4152dbfe55db02109refs/remotes/origin/clubb_silhs_develfb32238016885fa5709f0ff4152dbfe55db02109fb32238016885fa5709f0ff4152dbfe55db02109refs/remotes/origin/clubb_silhs_develfb32238016885fa5709f0ff4152dbfe55db02109fb32238016885fa5709f0ff4152dbfe55db02109refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#36624571013605478cam_global_ERP_Ln9_gfortran_test #366366false3661483SUCCESS1714812488804http://carson.math.uwm.edu/jenkins/job/cam_global_ERP_Ln9_gfortran_test/366/advance_xm_wpxp_module.F90243d18ebd39084235f84c52d7ed538639bd23f951714763847000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding extra exclamation to acc statement to comment it out. 2024-05-03 14:17:27 -0500243d18ebd39084235f84c52d7ed538639bd23f95Adding extra exclamation to acc statement to comment it out.editadvance_xm_wpxp_module.F90githttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse367http://carson.math.uwm.edu/jenkins/job/cam_global_ERP_Ln9_gfortran_test/367/365http://carson.math.uwm.edu/jenkins/job/cam_global_ERP_Ln9_gfortran_test/365/Started by an SCM change746fc57497840efaa7acc394c10ac9c6892ef162206fc57497840efaa7acc394c10ac9c6892ef16220origin/clubb_silhs_devel6fc57497840efaa7acc394c10ac9c6892ef162206fc57497840efaa7acc394c10ac9c6892ef16220origin/clubb_silhs_devel69cca799cfb394e7eeadc21211ae811b4a370d31eecca799cfb394e7eeadc21211ae811b4a370d31eeorigin/changes_to_not_breakcca799cfb394e7eeadc21211ae811b4a370d31eecca799cfb394e7eeadc21211ae811b4a370d31eeorigin/changes_to_not_break3646f02cf7b06690e57b01c9761f5a59770aace941a6f02cf7b06690e57b01c9761f5a59770aace941arefs/remotes/origin/clubb_silhs_devel6f02cf7b06690e57b01c9761f5a59770aace941a6f02cf7b06690e57b01c9761f5a59770aace941arefs/remotes/origin/clubb_silhs_devel6f02cf7b06690e57b01c9761f5a59770aace941a6f02cf7b06690e57b01c9761f5a59770aace941arefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#36423969163605478cam_global_ERP_Ln9_gfortran_test #364364false3641347SUCCESS1714639686452http://carson.math.uwm.edu/jenkins/job/cam_global_ERP_Ln9_gfortran_test/364/advance_clubb_core_module.F90d6ca5b0e6179de58c7571bea8650e3cd93c3de5e1714537919000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing bug. RESOLVED:556370c6406e6b943b88affbe7728a5036b1ba22, this was catchable by using debugging flags, but seems to otherwise cause no issues. Investigating I found that it only clips the below ground level, so that must not have been affecting other levels. This is technically BIT_CHANGING since it resolves an issue. 2024-04-30 23:31:59 -0500d6ca5b0e6179de58c7571bea8650e3cd93c3de5eFixing bug. RESOLVED:556370c6406e6b943b88affbe7728a5036b1ba22, this was catchable by using debugging flags, but seems to otherwise cause no issues. Investigating I found that it only clips the below ground level, so that must not have been affecting other levels. This is technically BIT_CHANGING since it resolves an issue.editadvance_clubb_core_module.F90fill_holes.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90clubb_api_module.F90c2849fa3c750562ffdd5abd6bc9937c081e662261714587276000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking num_draw_points in fill_holes a constant. We were already using this value as a constant everywhere, but passing a constant by argument list makes it difficult/impossible for a compiler to optimize using that constant, unless it does inlining. Now, rather than passing the constant num_hf_draw_points (or sometimes a hardcoded 2) we just use num_hf_draw_points directly from constants_clubb. This massively improves the performance of a loop in fill holes when using nvhpc+omp, which was the motivation for this, but should also improve the performance on CPUs. Everything is BFB. 2024-05-01 13:14:36 -0500c2849fa3c750562ffdd5abd6bc9937c081e66226Making num_draw_points in fill_holes a constant. We were already using this value as a constant everywhere, but passing a constant by argument list makes it difficult/impossible for a compiler to optimize using that constant, unless it does inlining. Now, rather than passing the constant num_hf_draw_points (or sometimes a hardcoded 2) we just use num_hf_draw_points directly from constants_clubb. This massively improves the performance of a loop in fill holes when using nvhpc+omp, which was the motivation for this, but should also improve the performance on CPUs. Everything is BFB.editadvance_xp2_xpyp_module.F90editadvance_clubb_core_module.F90editfill_holes.F90editadvance_wp2_wp3_module.F90editadvance_xm_wpxp_module.F90editclubb_api_module.F90githttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse365http://carson.math.uwm.edu/jenkins/job/cam_global_ERP_Ln9_gfortran_test/365/363http://carson.math.uwm.edu/jenkins/job/cam_global_ERP_Ln9_gfortran_test/363/