Started by an SCM change746fc57497840efaa7acc394c10ac9c6892ef162206fc57497840efaa7acc394c10ac9c6892ef16220origin/clubb_silhs_devel6fc57497840efaa7acc394c10ac9c6892ef162206fc57497840efaa7acc394c10ac9c6892ef16220origin/clubb_silhs_devel69cca799cfb394e7eeadc21211ae811b4a370d31eecca799cfb394e7eeadc21211ae811b4a370d31eeorigin/changes_to_not_breakcca799cfb394e7eeadc21211ae811b4a370d31eecca799cfb394e7eeadc21211ae811b4a370d31eeorigin/changes_to_not_break210a8f3bfa1b024d6e44bd8e5b04dc4ba86fe7e5bbaa8f3bfa1b024d6e44bd8e5b04dc4ba86fe7e5bbarefs/remotes/origin/clubb_silhs_devela8f3bfa1b024d6e44bd8e5b04dc4ba86fe7e5bbaa8f3bfa1b024d6e44bd8e5b04dc4ba86fe7e5bbarefs/remotes/origin/clubb_silhs_devela8f3bfa1b024d6e44bd8e5b04dc4ba86fe7e5bbaa8f3bfa1b024d6e44bd8e5b04dc4ba86fe7e5bbarefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.githttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/cam_global_ERP_Ln9_gfortran_test/detail/cam_global_ERP_Ln9_gfortran_test/210/artifactshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/cam_global_ERP_Ln9_gfortran_test/detail/cam_global_ERP_Ln9_gfortran_test/210/changeshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/cam_global_ERP_Ln9_gfortran_test/detail/cam_global_ERP_Ln9_gfortran_test/210/http://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/cam_global_ERP_Ln9_gfortran_test/detail/cam_global_ERP_Ln9_gfortran_test/210/testsfalseCheck out externalsCopy Config FilesMake cprncRun CAMfalse#21048285433605478cam_global_ERP_Ln9_gfortran_test #210210false21015692SUCCESS1654073227669http://carson.math.uwm.edu/jenkins/job/cam_global_ERP_Ln9_gfortran_test/210/clip_explicit.F90clubb_api_module.F90advance_xm_wpxp_module.F90stats_type_utilities.F90grid_class.F90setup_clubb_pdf_params.F90new_pdf_main.F90advance_windm_edsclrm_module.F90advance_helper_module.F90mono_flux_limiter.F90new_tsdadg_pdf.F90mixing_length.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90LY93_pdf.F90pdf_closure_module.F90adg1_adg2_3d_luhar_pdf.F90new_hybrid_pdf_main.F90numerical_check.F90pos_definite_module.F90new_pdf.F90sponge_layer_damping.F90turbulent_adv_pdf.F90advance_xp3_module.F90advance_clubb_core_module.F90fill_holes.F90stats_clubb_utilities.F90db5164bb7ed0c78ce4f06f92e7bf6118d10addf31654031468000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAlmost final loop pushes (#1012) * Pushing loop into clip_rcm * Pushing column loop into trapezoid routines. * Pushing column loop into clip_covar routines. * Pushing column loop into clip_variance and clip_skewness. * Replacing sgn_turbulent_velocity with built in fortran sign * Removing gr from argument list of stats calls, replacing with just nz * Replacing some usages of gr with just the number of vertical levels * Replacing some usages of gr with just the number of vertical levels again * Missed a couple files to commit * Pushing some loops and removing need for gr to be passed into some routines. * Pushing loop into advance_xp3 * Pushing loop into mixing length * Some more loop pushing * Pushing some loops into mono_flux limit, skipping the lhs routine since it's a bit tricky at the moment, will do after change to grid class. * Removing gr from argument list of stats accumulate * Precalculating zt2zm so that we can use 2d version * Precalculating um/vm ddzt so that we can use 2d version * Precalculating things to use 2d version of zt2zm * Making 2d version of cubic interp for grid class * Small modifications to sponge damping code argument lists * Renaming some variables 2022-05-31 16:11:08 -0500db5164bb7ed0c78ce4f06f92e7bf6118d10addf3Almost final loop pushes (#1012)editsetup_clubb_pdf_params.F90editnew_pdf.F90editturbulent_adv_pdf.F90editadg1_adg2_3d_luhar_pdf.F90editclip_explicit.F90editnew_hybrid_pdf_main.F90editpos_definite_module.F90editclubb_api_module.F90editsponge_layer_damping.F90editnew_pdf_main.F90editpdf_closure_module.F90editstats_type_utilities.F90editnew_tsdadg_pdf.F90editgrid_class.F90editadvance_windm_edsclrm_module.F90editLY93_pdf.F90editadvance_helper_module.F90editadvance_xp3_module.F90editadvance_clubb_core_module.F90editnumerical_check.F90editstats_clubb_utilities.F90editadvance_xp2_xpyp_module.F90editmixing_length.F90editadvance_wp2_wp3_module.F90editfill_holes.F90editadvance_xm_wpxp_module.F90editmono_flux_limiter.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90clubb_api_module.F90pdf_closure_module.F90pdf_parameter_module.F90new_hybrid_pdf_main.F90new_pdf_main.F90113beb1ec6663fcef3f6bb75c7ee971ab3c0fa451654040788000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comMaking pdf_implicit_coefs_terms a type containing 2D arrays. (#1014) 2022-05-31 18:46:28 -0500113beb1ec6663fcef3f6bb75c7ee971ab3c0fa45Making pdf_implicit_coefs_terms a type containing 2D arrays. (#1014)editadvance_clubb_core_module.F90editadvance_xm_wpxp_module.F90editnew_hybrid_pdf_main.F90editpdf_parameter_module.F90editadvance_xp2_xpyp_module.F90editpdf_closure_module.F90editclubb_api_module.F90editadvance_wp2_wp3_module.F90editnew_pdf_main.F90src/physics/cam/clubb_intr.F904da100a6a644f98653e747fc976e1909d1be9d8a1654040977000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking compatible with latest clubb change. 2022-05-31 18:49:37 -05004da100a6a644f98653e747fc976e1909d1be9d8aMaking compatible with latest clubb change.editsrc/physics/cam/clubb_intr.F90githttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhueblerhttp://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreplyfalseStarted by an SCM change746fc57497840efaa7acc394c10ac9c6892ef162206fc57497840efaa7acc394c10ac9c6892ef16220origin/clubb_silhs_devel6fc57497840efaa7acc394c10ac9c6892ef162206fc57497840efaa7acc394c10ac9c6892ef16220origin/clubb_silhs_devel69cca799cfb394e7eeadc21211ae811b4a370d31eecca799cfb394e7eeadc21211ae811b4a370d31eeorigin/changes_to_not_breakcca799cfb394e7eeadc21211ae811b4a370d31eecca799cfb394e7eeadc21211ae811b4a370d31eeorigin/changes_to_not_break211bda722f02d98cdd52f813e35f36f7f22784a359ebda722f02d98cdd52f813e35f36f7f22784a359erefs/remotes/origin/clubb_silhs_develbda722f02d98cdd52f813e35f36f7f22784a359ebda722f02d98cdd52f813e35f36f7f22784a359erefs/remotes/origin/clubb_silhs_develbda722f02d98cdd52f813e35f36f7f22784a359ebda722f02d98cdd52f813e35f36f7f22784a359erefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#21154748113605478cam_global_ERP_Ln9_gfortran_test #211211false21115764SUCCESS1654159627960http://carson.math.uwm.edu/jenkins/job/cam_global_ERP_Ln9_gfortran_test/211/run_scripts/run_scam.bashc20662363e47160831e6737942e9f0074f06630d1654110722000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comThis commit is not bit changing but the following commits are BIT_CHANGING:29e08c789aef09db2b76a418d3ab4c35bfc50a04 BIT_CHANGING:741338adec67b4d8d6087af4c8c3e2206692dc04 BIT_CHANGING:ed63800262913a0c130c80cd16067e7d68548613 for simulations that include silhs 2022-06-01 14:12:02 -0500c20662363e47160831e6737942e9f0074f06630dThis commit is not bit changingeditrun_scripts/run_scam.bashnew_pdf_main.F90new_hybrid_pdf_main.F907bc6f76ec8b70bc1789f90b554dca47122c400011654112656000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduThe G_unit tests never allocated pdf_implicit_coefs_terms. It's unclear to me how these were working before, but it seems that something about making these 2D allocatable arrays exposed the bug. 2022-06-01 14:44:16 -05007bc6f76ec8b70bc1789f90b554dca47122c40001The G_unit tests never allocated pdf_implicit_coefs_terms. It's unclear to me how these were working before, but it seems that something about making these 2D allocatable arrays exposed the bug.editnew_pdf_main.F90editnew_hybrid_pdf_main.F90advance_xp2_xpyp_module.F90de73c4eefaee2b50045b4f5e706868e84b0f45501654117361000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking zt2zm calls with pdf_implicit_coefs_terms use the 2D version. 2022-06-01 16:02:41 -0500de73c4eefaee2b50045b4f5e706868e84b0f4550Making zt2zm calls with pdf_implicit_coefs_terms use the 2D version.editadvance_xp2_xpyp_module.F90advance_clubb_core_module.F90clubb_api_module.F903643c78f6fe2260f971bba96ead125858b665f1c1654122180000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduRemoving setup_grid and setup_parameters functionality from setup_clubb_core. This is beacuse in host models the required grid information may not be known during the setup process, resulting in dummy arguments for setup_clubb_core and the grid and paramters being setup during runtime anyway. Now, in the host models we can call these subroutines immediately after setup_clubb_core to maintain identical functionality (sam, wrf), and in others we can wait to call these until the main timestepping procedure (cam,e3sm). 2022-06-01 17:23:00 -05003643c78f6fe2260f971bba96ead125858b665f1cRemoving setup_grid and setup_parameters functionality from setup_clubb_core. This is beacuse in host models the required grid information may not be known during the setup process, resulting in dummy arguments for setup_clubb_core and the grid and paramters being setup during runtime anyway. Now, in the host models we can call these subroutines immediately after setup_clubb_core to maintain identical functionality (sam, wrf), and in others we can wait to call these until the main timestepping procedure (cam,e3sm).editclubb_api_module.F90editadvance_clubb_core_module.F90src/physics/cam/clubb_intr.F9025568b67709f1d52bc277cbd64bca0ee4c6b86c01654122521000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking compatible with latest clubb change. 2022-06-01 17:28:41 -050025568b67709f1d52bc277cbd64bca0ee4c6b86c0Making compatible with latest clubb change.editsrc/physics/cam/clubb_intr.F90grid_class.F90parameters_tunable.F90clubb_api_module.F90c623b91a9bf812b85b51b575233ad00e8b98f16c1654129942000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking 2D versions of setup_grid and setup_parameters. 2022-06-01 19:32:22 -0500c623b91a9bf812b85b51b575233ad00e8b98f16cMaking 2D versions of setup_grid and setup_parameters.editclubb_api_module.F90editgrid_class.F90editparameters_tunable.F90src/physics/cam/clubb_intr.F90ffa8c5c5860210f89bb463fc8aac90c1ba9c5e001654130768000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduNow using 2D versions of setup_grid and setup_parameters 2022-06-01 19:46:08 -0500ffa8c5c5860210f89bb463fc8aac90c1ba9c5e00Now using 2D versions of setup_grid and setup_parameterseditsrc/physics/cam/clubb_intr.F90githttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse212http://carson.math.uwm.edu/jenkins/job/cam_global_ERP_Ln9_gfortran_test/212/210http://carson.math.uwm.edu/jenkins/job/cam_global_ERP_Ln9_gfortran_test/210/Started by an SCM change746fc57497840efaa7acc394c10ac9c6892ef162206fc57497840efaa7acc394c10ac9c6892ef16220origin/clubb_silhs_devel6fc57497840efaa7acc394c10ac9c6892ef162206fc57497840efaa7acc394c10ac9c6892ef16220origin/clubb_silhs_devel69cca799cfb394e7eeadc21211ae811b4a370d31eecca799cfb394e7eeadc21211ae811b4a370d31eeorigin/changes_to_not_breakcca799cfb394e7eeadc21211ae811b4a370d31eecca799cfb394e7eeadc21211ae811b4a370d31eeorigin/changes_to_not_break209ed63800262913a0c130c80cd16067e7d68548613ed63800262913a0c130c80cd16067e7d68548613refs/remotes/origin/clubb_silhs_develed63800262913a0c130c80cd16067e7d68548613ed63800262913a0c130c80cd16067e7d68548613refs/remotes/origin/clubb_silhs_develed63800262913a0c130c80cd16067e7d68548613ed63800262913a0c130c80cd16067e7d68548613refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#20949218913605478cam_global_ERP_Ln9_gfortran_test #209209false20915618SUCCESS1653727631283http://carson.math.uwm.edu/jenkins/job/cam_global_ERP_Ln9_gfortran_test/209/setup_clubb_pdf_params.F90clubb_api_module.F90e3cdb98eb6cc532f8ef187f2d1cc56481a75d1f51653690057000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comConstructing rcm within SILHS (as rcm_pdf) (#1011) * Constructing rcm within SILHS (as rcm_pdf) to avoid having to pass rcm directly to SILHS. Relevant to possibly moving PDF call placement into the "post" position in CAM. See https://github.com/ESCOMP/CAM/issues/582. * Reconstructing rcm inside of setup_pdf_parameters instead of passing it through the argument lists. Might help NCAR move the PDF call placement to "post" position in CAM. See https://github.com/larson-group/clubb/issues/997. * Adding descriptive comment. 2022-05-27 16:20:57 -0600e3cdb98eb6cc532f8ef187f2d1cc56481a75d1f5Constructing rcm within SILHS (as rcm_pdf) (#1011)editclubb_api_module.F90editsetup_clubb_pdf_params.F90silhs_api_module.F90latin_hypercube_driver_module.F90f6c58abafbfc4b18957f9eedff60deeb321bad321653690057000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comConstructing rcm within SILHS (as rcm_pdf) (#1011) * Constructing rcm within SILHS (as rcm_pdf) to avoid having to pass rcm directly to SILHS. Relevant to possibly moving PDF call placement into the "post" position in CAM. See https://github.com/ESCOMP/CAM/issues/582. * Reconstructing rcm inside of setup_pdf_parameters instead of passing it through the argument lists. Might help NCAR move the PDF call placement to "post" position in CAM. See https://github.com/larson-group/clubb/issues/997. * Adding descriptive comment. 2022-05-27 16:20:57 -0600f6c58abafbfc4b18957f9eedff60deeb321bad32Constructing rcm within SILHS (as rcm_pdf) (#1011)editsilhs_api_module.F90editlatin_hypercube_driver_module.F90src/physics/cam/subcol_SILHS.F9029e08c789aef09db2b76a418d3ab4c35bfc50a041653690184000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comUpdating for changes to CLUBB. See https://github.com/larson-group/clubb/commit/e4f125ba067ba8083f917e0e06b6b2398483d3e4. 2022-05-27 17:23:04 -050029e08c789aef09db2b76a418d3ab4c35bfc50a04Updating for changes to CLUBB. See https://github.com/larson-group/clubb/commit/e4f125ba067ba8083f917e0e06b6b2398483d3e4.editsrc/physics/cam/subcol_SILHS.F90githttp://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephenshttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse210http://carson.math.uwm.edu/jenkins/job/cam_global_ERP_Ln9_gfortran_test/210/208http://carson.math.uwm.edu/jenkins/job/cam_global_ERP_Ln9_gfortran_test/208/