Started by an SCM change746fc57497840efaa7acc394c10ac9c6892ef162206fc57497840efaa7acc394c10ac9c6892ef16220origin/clubb_silhs_devel6fc57497840efaa7acc394c10ac9c6892ef162206fc57497840efaa7acc394c10ac9c6892ef16220origin/clubb_silhs_devel69cca799cfb394e7eeadc21211ae811b4a370d31eecca799cfb394e7eeadc21211ae811b4a370d31eeorigin/changes_to_not_breakcca799cfb394e7eeadc21211ae811b4a370d31eecca799cfb394e7eeadc21211ae811b4a370d31eeorigin/changes_to_not_break208348c73edab8bef26630546c316bae4dc4c8dc09d348c73edab8bef26630546c316bae4dc4c8dc09drefs/remotes/origin/clubb_silhs_devel348c73edab8bef26630546c316bae4dc4c8dc09d348c73edab8bef26630546c316bae4dc4c8dc09drefs/remotes/origin/clubb_silhs_devel348c73edab8bef26630546c316bae4dc4c8dc09d348c73edab8bef26630546c316bae4dc4c8dc09drefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.githttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/cam_global_ERP_Ln9_gfortran_test/detail/cam_global_ERP_Ln9_gfortran_test/208/artifactshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/cam_global_ERP_Ln9_gfortran_test/detail/cam_global_ERP_Ln9_gfortran_test/208/changeshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/cam_global_ERP_Ln9_gfortran_test/detail/cam_global_ERP_Ln9_gfortran_test/208/http://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/cam_global_ERP_Ln9_gfortran_test/detail/cam_global_ERP_Ln9_gfortran_test/208/testsfalseCheck out externalsCopy Config FilesMake cprncRun CAMfalse#20886456103605478cam_global_ERP_Ln9_gfortran_test #208208false20815340SUCCESS1652518029892http://carson.math.uwm.edu/jenkins/job/cam_global_ERP_Ln9_gfortran_test/208/mixing_length.F90advance_helper_module.F90612b58c17db79d410f0d7c183c582f38d1ccb1b51652459498000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comAdded ability to apply smooth min max functions in mixing_length.F90 2022-05-13 11:31:38 -0500612b58c17db79d410f0d7c183c582f38d1ccb1b5Added ability to apply smooth min max functions in mixing_length.F90editmixing_length.F90editadvance_helper_module.F90advance_helper_module.F902d9fdafb4596ebd4063d961bc3d1b18c0dbcff3d1652459498000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comUpdated deprecated documentation of smooth min and max functions in advance_helper_module.F90. https://github.com/larson-group/clubb/issues/965 2022-05-13 11:31:38 -05002d9fdafb4596ebd4063d961bc3d1b18c0dbcff3dUpdated deprecated documentation of smooth min and max functions in advance_helper_module.F90. https://github.com/larson-group/clubb/issues/965editadvance_helper_module.F90mixing_length.F90advance_helper_module.F90f050454be526c9ec53c1d5445ba5ea554477010c1652459498000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comChecked whether results really are identical even with round-off when we have l_smooth_min_max=T and smooth_min_max_mag=zero. Next commit rolls some of these changes back for merge into master. https://github.com/larson-group/clubb/issues/965 2022-05-13 11:31:38 -0500f050454be526c9ec53c1d5445ba5ea554477010cChecked whether results really are identical even with round-off when we have l_smooth_min_max=T and smooth_min_max_mag=zero. Next commit rolls some of these changes back for merge into master. https://github.com/larson-group/clubb/issues/965editadvance_helper_module.F90editmixing_length.F90mixing_length.F90d540581ca5c6736c20a89d3b168cd0048f6bf3a21652459498000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comAdded test cases to smooth_min_max_tests.F90 and updated documentation. 2022-05-13 11:31:38 -0500d540581ca5c6736c20a89d3b168cd0048f6bf3a2Added test cases to smooth_min_max_tests.F90 and updated documentation.editmixing_length.F90githttp://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+jangrnfalseStarted by an SCM change746fc57497840efaa7acc394c10ac9c6892ef162206fc57497840efaa7acc394c10ac9c6892ef16220origin/clubb_silhs_devel6fc57497840efaa7acc394c10ac9c6892ef162206fc57497840efaa7acc394c10ac9c6892ef16220origin/clubb_silhs_devel69cca799cfb394e7eeadc21211ae811b4a370d31eecca799cfb394e7eeadc21211ae811b4a370d31eeorigin/changes_to_not_breakcca799cfb394e7eeadc21211ae811b4a370d31eecca799cfb394e7eeadc21211ae811b4a370d31eeorigin/changes_to_not_break209ed63800262913a0c130c80cd16067e7d68548613ed63800262913a0c130c80cd16067e7d68548613refs/remotes/origin/clubb_silhs_develed63800262913a0c130c80cd16067e7d68548613ed63800262913a0c130c80cd16067e7d68548613refs/remotes/origin/clubb_silhs_develed63800262913a0c130c80cd16067e7d68548613ed63800262913a0c130c80cd16067e7d68548613refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#20949218913605478cam_global_ERP_Ln9_gfortran_test #209209false20915618SUCCESS1653727631283http://carson.math.uwm.edu/jenkins/job/cam_global_ERP_Ln9_gfortran_test/209/setup_clubb_pdf_params.F90clubb_api_module.F90e3cdb98eb6cc532f8ef187f2d1cc56481a75d1f51653690057000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comConstructing rcm within SILHS (as rcm_pdf) (#1011) * Constructing rcm within SILHS (as rcm_pdf) to avoid having to pass rcm directly to SILHS. Relevant to possibly moving PDF call placement into the "post" position in CAM. See https://github.com/ESCOMP/CAM/issues/582. * Reconstructing rcm inside of setup_pdf_parameters instead of passing it through the argument lists. Might help NCAR move the PDF call placement to "post" position in CAM. See https://github.com/larson-group/clubb/issues/997. * Adding descriptive comment. 2022-05-27 16:20:57 -0600e3cdb98eb6cc532f8ef187f2d1cc56481a75d1f5Constructing rcm within SILHS (as rcm_pdf) (#1011)editclubb_api_module.F90editsetup_clubb_pdf_params.F90silhs_api_module.F90latin_hypercube_driver_module.F90f6c58abafbfc4b18957f9eedff60deeb321bad321653690057000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comConstructing rcm within SILHS (as rcm_pdf) (#1011) * Constructing rcm within SILHS (as rcm_pdf) to avoid having to pass rcm directly to SILHS. Relevant to possibly moving PDF call placement into the "post" position in CAM. See https://github.com/ESCOMP/CAM/issues/582. * Reconstructing rcm inside of setup_pdf_parameters instead of passing it through the argument lists. Might help NCAR move the PDF call placement to "post" position in CAM. See https://github.com/larson-group/clubb/issues/997. * Adding descriptive comment. 2022-05-27 16:20:57 -0600f6c58abafbfc4b18957f9eedff60deeb321bad32Constructing rcm within SILHS (as rcm_pdf) (#1011)editsilhs_api_module.F90editlatin_hypercube_driver_module.F90src/physics/cam/subcol_SILHS.F9029e08c789aef09db2b76a418d3ab4c35bfc50a041653690184000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comUpdating for changes to CLUBB. See https://github.com/larson-group/clubb/commit/e4f125ba067ba8083f917e0e06b6b2398483d3e4. 2022-05-27 17:23:04 -050029e08c789aef09db2b76a418d3ab4c35bfc50a04Updating for changes to CLUBB. See https://github.com/larson-group/clubb/commit/e4f125ba067ba8083f917e0e06b6b2398483d3e4.editsrc/physics/cam/subcol_SILHS.F90githttp://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephenshttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse210http://carson.math.uwm.edu/jenkins/job/cam_global_ERP_Ln9_gfortran_test/210/208http://carson.math.uwm.edu/jenkins/job/cam_global_ERP_Ln9_gfortran_test/208/Started by an SCM change746fc57497840efaa7acc394c10ac9c6892ef162206fc57497840efaa7acc394c10ac9c6892ef16220origin/clubb_silhs_devel6fc57497840efaa7acc394c10ac9c6892ef162206fc57497840efaa7acc394c10ac9c6892ef16220origin/clubb_silhs_devel69cca799cfb394e7eeadc21211ae811b4a370d31eecca799cfb394e7eeadc21211ae811b4a370d31eeorigin/changes_to_not_breakcca799cfb394e7eeadc21211ae811b4a370d31eecca799cfb394e7eeadc21211ae811b4a370d31eeorigin/changes_to_not_break2073d16e63e94b42455af8f57c03c42ae1e07bb62213d16e63e94b42455af8f57c03c42ae1e07bb6221refs/remotes/origin/clubb_silhs_devel3d16e63e94b42455af8f57c03c42ae1e07bb62213d16e63e94b42455af8f57c03c42ae1e07bb6221refs/remotes/origin/clubb_silhs_devel3d16e63e94b42455af8f57c03c42ae1e07bb62213d16e63e94b42455af8f57c03c42ae1e07bb6221refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#20742363153605478cam_global_ERP_Ln9_gfortran_test #207207false20715214SUCCESS1651826831661http://carson.math.uwm.edu/jenkins/job/cam_global_ERP_Ln9_gfortran_test/207/mixing_length.F90advance_helper_module.F90592d69e2936ee8ce9c706d21a606fe2ed89c5a7f1651762515000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comRenamed smth_range to heaviside_smth_range 2022-05-05 09:55:15 -0500592d69e2936ee8ce9c706d21a606fe2ed89c5a7fRenamed smth_range to heaviside_smth_rangeeditadvance_helper_module.F90editmixing_length.F90stats_sfc_module.F90stats_variables.F90stats_clubb_utilities.F90advance_helper_module.F90c9ccb33dd2dd17ed51136d49262370f980d34efa1651762515000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comAdded tot_vartn_normlzd statistics. Renamed sclr in advance_helper_module to scalar to be more consistent with clubb naming schemes. 2022-05-05 09:55:15 -0500c9ccb33dd2dd17ed51136d49262370f980d34efaAdded tot_vartn_normlzd statistics. Renamed sclr in advance_helper_module to scalar to be more consistent with clubb naming schemes.editstats_variables.F90editstats_clubb_utilities.F90editadvance_helper_module.F90editstats_sfc_module.F90stats_clubb_utilities.F90stats_variables.F90stats_sfc_module.F90e68c14bd04dd6715f4eead46f5252b1cae3d909e1651762515000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comImplemented three further normalized variation stats. Included a (most likely temporary) check because in a few cases, denominator for normalization would be 0. 2022-05-05 09:55:15 -0500e68c14bd04dd6715f4eead46f5252b1cae3d909eImplemented three further normalized variation stats. Included a (most likely temporary) check because in a few cases, denominator for normalization would be 0.editstats_sfc_module.F90editstats_clubb_utilities.F90editstats_variables.F90stats_clubb_utilities.F9036748fbe6efa8a82b6c846fc8ec914e90114bdfb1651762515000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comChanged priorities of total normalized variation stats, included error handling in total normalized variation stats. 2022-05-05 09:55:15 -050036748fbe6efa8a82b6c846fc8ec914e90114bdfbChanged priorities of total normalized variation stats, included error handling in total normalized variation stats.editstats_clubb_utilities.F90stats_clubb_utilities.F9028fb91ccebb1790cc90b29cc7fe8b0b211b727eb1651762515000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comRenamed pdf_output_filename. Added grid_level constant to avoid magic numbers in stats_update_var_pt calls. 2022-05-05 09:55:15 -050028fb91ccebb1790cc90b29cc7fe8b0b211b727ebRenamed pdf_output_filename. Added grid_level constant to avoid magic numbers in stats_update_var_pt calls.editstats_clubb_utilities.F90advance_clubb_core_module.F90setup_clubb_pdf_params.F90advance_windm_edsclrm_module.F90clubb_api_module.F90advance_helper_module.F908b65b741ae34ba9ef8287f3fcafd627092d4ba131651782038000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comGunthers branch 2 (#1002) * Pushing loop down through advance_windm. Other files needed to be touched because they were using a simple function, xpwp_func, which has been replaced in relevenant places by the few lines of code it takes to do. * Cleaned up intents * Moving xpwp calcuations back to procedure, but making procedure a 1/2D interface in advance helper. Other various small tweaks as well. 2022-05-05 15:20:38 -05008b65b741ae34ba9ef8287f3fcafd627092d4ba13Gunthers branch 2 (#1002)editadvance_helper_module.F90editadvance_windm_edsclrm_module.F90editsetup_clubb_pdf_params.F90editadvance_clubb_core_module.F90editclubb_api_module.F90stats_clubb_utilities.F90488bf543bb77e0f48a1958074bd8d468f4421f761651782218000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comBugfix for merge #1000. stderr was not imported in stat_clubb_utilities.F90, causing compilation to fail. 2022-05-05 15:23:38 -0500488bf543bb77e0f48a1958074bd8d468f4421f76Bugfix for merge #1000. stderr was not imported in stat_clubb_utilities.F90, causing compilation to fail.editstats_clubb_utilities.F90githttp://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrnhttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse208http://carson.math.uwm.edu/jenkins/job/cam_global_ERP_Ln9_gfortran_test/208/206http://carson.math.uwm.edu/jenkins/job/cam_global_ERP_Ln9_gfortran_test/206/