http://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/cam_BFB_coarse_res_gfortran_test/cam_BFB_coarse_res_gfortran_testcam_BFB_coarse_res_gfortran_testcam_BFB_coarse_res_gfortran_testcam_BFB_coarse_res_gfortran_testhttp://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/trueStarted by an SCM change22875e11687f38a46e5fe965b35c51406f23ad8f1dd75e11687f38a46e5fe965b35c51406f23ad8f1ddrefs/remotes/origin/clubb_silhs_devel75e11687f38a46e5fe965b35c51406f23ad8f1dd75e11687f38a46e5fe965b35c51406f23ad8f1ddrefs/remotes/origin/clubb_silhs_devel75e11687f38a46e5fe965b35c51406f23ad8f1dd75e11687f38a46e5fe965b35c51406f23ad8f1ddrefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#22830857122373579cam_BFB_coarse_res_gfortran_test #228228false2283043SUCCESS1775723227859http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/228/CMakeLists.txte441799f4c27da552caf213fc19c5bfb32573c1a1775682381000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRemove line to test python scripts 2026-04-08 16:06:21 -0500e441799f4c27da552caf213fc19c5bfb32573c1aRemove line to test python scriptseditCMakeLists.txtCMakeLists.txt67261c9ca97ea2a8b26cd3bbb2ab3d014ad1b6bf1775696339000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdd blank line to test python scripts 2026-04-08 19:58:59 -050067261c9ca97ea2a8b26cd3bbb2ab3d014ad1b6bfAdd blank line to test python scriptseditCMakeLists.txtgithttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse227http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/227/Started by user Gunther HueblerhueblerGunther Huebler227a24c699cfddb6e51cf7d81bb3b7271a401c950a4a24c699cfddb6e51cf7d81bb3b7271a401c950a4refs/remotes/origin/clubb_silhs_devela24c699cfddb6e51cf7d81bb3b7271a401c950a4a24c699cfddb6e51cf7d81bb3b7271a401c950a4refs/remotes/origin/clubb_silhs_devela24c699cfddb6e51cf7d81bb3b7271a401c950a4a24c699cfddb6e51cf7d81bb3b7271a401c950a4refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#22719006532373579cam_BFB_coarse_res_gfortran_test #227227false2272894SUCCESS1775596773636http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/227/stats_netcdf.F90d270660ce78355c1d67d01882310277ffbd9457c1775592422000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding err_info back to stats_end_timestep_api 2026-04-07 15:07:02 -0500d270660ce78355c1d67d01882310277ffbd9457cAdding err_info back to stats_end_timestep_apieditstats_netcdf.F90mono_flux_limiter.F90da324d924105b2a8a4297e3c6ba9274e8c166c121775594520000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing monoflux limiter test - there was a comment that was split across lines, which broke the test 2026-04-07 15:42:00 -0500da324d924105b2a8a4297e3c6ba9274e8c166c12Fixing monoflux limiter test - there was a comment that was split across lines, which broke the testeditmono_flux_limiter.F90stats_netcdf.F90b60dc21a5215872db004bfa9ab3863137458ec4a1775594819000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduRemoving unused variable 2026-04-07 15:46:59 -0500b60dc21a5215872db004bfa9ab3863137458ec4aRemoving unused variableeditstats_netcdf.F90githttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse228http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/228/226http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/226/Started by user Gunther HueblerhueblerGunther Huebler2263c325563d0a2ef8d2ef8803ec4ff7185f46a48a23c325563d0a2ef8d2ef8803ec4ff7185f46a48a2refs/remotes/origin/clubb_silhs_devel3c325563d0a2ef8d2ef8803ec4ff7185f46a48a23c325563d0a2ef8d2ef8803ec4ff7185f46a48a2refs/remotes/origin/clubb_silhs_devel3c325563d0a2ef8d2ef8803ec4ff7185f46a48a23c325563d0a2ef8d2ef8803ec4ff7185f46a48a2refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#22611040462373579cam_BFB_coarse_res_gfortran_test #226226false2262883FAILURE1775591978470http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/226/false227http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/227/225http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/225/Started by an SCM change2253c325563d0a2ef8d2ef8803ec4ff7185f46a48a23c325563d0a2ef8d2ef8803ec4ff7185f46a48a2refs/remotes/origin/clubb_silhs_devel3c325563d0a2ef8d2ef8803ec4ff7185f46a48a23c325563d0a2ef8d2ef8803ec4ff7185f46a48a2refs/remotes/origin/clubb_silhs_devel3c325563d0a2ef8d2ef8803ec4ff7185f46a48a23c325563d0a2ef8d2ef8803ec4ff7185f46a48a2refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#22521343732373579cam_BFB_coarse_res_gfortran_test #225225false2252835SUCCESS1775550428111http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/225/advance_xm_wpxp_module.F90clubb_api_module.F90clip_explicit.F90stats_netcdf.F90grid_class.F90setup_clubb_pdf_params.F90advance_windm_edsclrm_module.F90mono_flux_limiter.F90advance_helper_module.F90advance_wp2_wp3_module.F90mixing_length.F90pdf_utilities.F90err_info_type_module.F90advance_xp2_xpyp_module.F90grid_adaptation_module.F90error_code.F90pdf_closure_module.F90adg1_adg2_3d_luhar_pdf.F90corr_varnce_module.F90diffusion.F90model_flags.F90numerical_check.F90constants_clubb.F90parameters_tunable.F90pdf_parameter_module.F90hydromet_pdf_parameter_module.F90sponge_layer_damping.F90array_index.F90advance_clubb_core_module.F90penta_bicgstab_solver.F90mean_adv.F90fill_holes.F90stats_clubb_utilities.F90interpolation.F90sfc_varnce_module.F901f8ac54716257b7088042832365a33d27881508f1775502171000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comStandards fix (#1288) * Fixing code to comply with clubb standards and making standards check output a little nicer * Fixing unused variable compiler errors * Removing ifdef GFDL option * A bit of cleanup * Little GPU fix * Making the threadprivate check part of the standards, little script improvements, and adding more code to the standards check and also fixing it * Adding missed cmake files * Improving various subroutine edits 2026-04-06 14:02:51 -05001f8ac54716257b7088042832365a33d27881508fStandards fix (#1288)editpdf_closure_module.F90editadvance_wp2_wp3_module.F90editerr_info_type_module.F90editfill_holes.F90editmixing_length.F90editnumerical_check.F90editstats_clubb_utilities.F90editadvance_clubb_core_module.F90editmean_adv.F90editsfc_varnce_module.F90editarray_index.F90editerror_code.F90editconstants_clubb.F90editdiffusion.F90editadvance_xm_wpxp_module.F90editpenta_bicgstab_solver.F90editmodel_flags.F90editmono_flux_limiter.F90editparameters_tunable.F90editadvance_xp2_xpyp_module.F90editsponge_layer_damping.F90editpdf_parameter_module.F90editadg1_adg2_3d_luhar_pdf.F90editgrid_class.F90editsetup_clubb_pdf_params.F90edithydromet_pdf_parameter_module.F90editinterpolation.F90editstats_netcdf.F90editadvance_helper_module.F90editadvance_windm_edsclrm_module.F90editcorr_varnce_module.F90editclubb_api_module.F90editgrid_adaptation_module.F90editpdf_utilities.F90editclip_explicit.F90latin_hypercube_arrays.F90silhs_api_module.F90latin_hypercube_driver_module.F90412e42d133d9b9285384639c4c27f478f1a8821e1775502171000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comStandards fix (#1288) * Fixing code to comply with clubb standards and making standards check output a little nicer * Fixing unused variable compiler errors * Removing ifdef GFDL option * A bit of cleanup * Little GPU fix * Making the threadprivate check part of the standards, little script improvements, and adding more code to the standards check and also fixing it * Adding missed cmake files * Improving various subroutine edits 2026-04-06 14:02:51 -0500412e42d133d9b9285384639c4c27f478f1a8821eStandards fix (#1288)editlatin_hypercube_arrays.F90editsilhs_api_module.F90editlatin_hypercube_driver_module.F90CMakeLists.txt2a35d01af2ca03bb95c4c1aaffa09f0f8c5c963f1775514539000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRemove blank line to trigger git update script 2026-04-06 17:28:59 -05002a35d01af2ca03bb95c4c1aaffa09f0f8c5c963fRemove blank line to trigger git update scripteditCMakeLists.txtCMakeLists.txt38d375249096b55e9e9bd95679d4f1fd9867ba281775514734000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdd blank line to trigger git update scripts 2026-04-06 17:32:14 -050038d375249096b55e9e9bd95679d4f1fd9867ba28Add blank line to trigger git update scriptseditCMakeLists.txtgithttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse226http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/226/224http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/224/Started by an SCM change2248a035571f07d661835b38a57e634fe5cd4b118ac8a035571f07d661835b38a57e634fe5cd4b118acrefs/remotes/origin/clubb_silhs_devel8a035571f07d661835b38a57e634fe5cd4b118ac8a035571f07d661835b38a57e634fe5cd4b118acrefs/remotes/origin/clubb_silhs_devel8a035571f07d661835b38a57e634fe5cd4b118ac8a035571f07d661835b38a57e634fe5cd4b118acrefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#22427184042373579cam_BFB_coarse_res_gfortran_test #224224false2242735SUCCESS1775464027628http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/224/stats_netcdf.F90abb82f56ea5c92ba41aff1a717c341d5609e18531775440060000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking run_bindiff_w_flags.py faster by calling run_scm.py directly and parallelizing over all cases/flag sets, rather than just calling run_scm_all.py and parallelizing over each flag batch. Also fixing a little stats bug that caused the time string to have weird trailing characters, and removing a little states print 2026-04-05 20:47:40 -0500abb82f56ea5c92ba41aff1a717c341d5609e1853Making run_bindiff_w_flags.py faster by calling run_scm.py directly and parallelizing over all cases/flag sets, rather than just calling run_scm_all.py and parallelizing over each flag batch. Also fixing a little stats bug that caused the time string to have weird trailing characters, and removing a little states printeditstats_netcdf.F90githttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse225http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/225/223http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/223/Started by an SCM change22346ff475a97c618b1cb7329f826f0a68b0d5c937b46ff475a97c618b1cb7329f826f0a68b0d5c937brefs/remotes/origin/clubb_silhs_devel46ff475a97c618b1cb7329f826f0a68b0d5c937b46ff475a97c618b1cb7329f826f0a68b0d5c937brefs/remotes/origin/clubb_silhs_devel46ff475a97c618b1cb7329f826f0a68b0d5c937b46ff475a97c618b1cb7329f826f0a68b0d5c937brefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#22321747672373579cam_BFB_coarse_res_gfortran_test #223223false2232524SUCCESS1774340829309http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/223/mixing_length.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90grid_adaptation_module.F90clubb_api_module.F90advance_xm_wpxp_module.F90numerical_check.F90grid_class.F90matrix_solver_wrapper.F90advance_windm_edsclrm_module.F90mono_flux_limiter.F90c0491ff97ed74b6fed914860b18bb16756a9c20c1774297540000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comLittle Fix (#1287) * Making matrix solve checks also trigger if l_implemented is true so that they always are done in CAM, regardless of debug level * Reworking rcond flag in advance_windm * Updating l_implemented flag comments * Adding printouts to make clear where the NaN are (if any) in the soln vector. 2026-03-23 15:25:40 -0500c0491ff97ed74b6fed914860b18bb16756a9c20cLittle Fix (#1287)editadvance_clubb_core_module.F90editadvance_windm_edsclrm_module.F90editmatrix_solver_wrapper.F90editclubb_api_module.F90editnumerical_check.F90editadvance_xp2_xpyp_module.F90editmixing_length.F90editgrid_class.F90editadvance_wp2_wp3_module.F90editgrid_adaptation_module.F90editadvance_xm_wpxp_module.F90editmono_flux_limiter.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse224http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/224/222http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/222/Started by an SCM change222bdd345cc0a92472c9e2c39673bae4b621266c13ebdd345cc0a92472c9e2c39673bae4b621266c13erefs/remotes/origin/clubb_silhs_develbdd345cc0a92472c9e2c39673bae4b621266c13ebdd345cc0a92472c9e2c39673bae4b621266c13erefs/remotes/origin/clubb_silhs_develbdd345cc0a92472c9e2c39673bae4b621266c13ebdd345cc0a92472c9e2c39673bae4b621266c13erefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#22226812522373579cam_BFB_coarse_res_gfortran_test #222222false2222424SUCCESS1774254427864http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/222/interpolation.F906b992b63fb2158639d35fe5861f2e490eb6120381774158992000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduGPUizing most of radiation code 2026-03-22 00:56:32 -05006b992b63fb2158639d35fe5861f2e490eb612038GPUizing most of radiation codeeditinterpolation.F90githttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse223http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/223/221http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/221/Started by an SCM change22126043da64f7276818ec350b42070118741c6772326043da64f7276818ec350b42070118741c67723refs/remotes/origin/clubb_silhs_devel26043da64f7276818ec350b42070118741c6772326043da64f7276818ec350b42070118741c67723refs/remotes/origin/clubb_silhs_devel26043da64f7276818ec350b42070118741c6772326043da64f7276818ec350b42070118741c67723refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#22120886072373579cam_BFB_coarse_res_gfortran_test #221221false2212334SUCCESS1773908825911http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/221/numerical_check.F904c3e62ea9fb1455849859daf0fc91af3b6c12ffd1773867770000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comClubb radiation update (#1283) * Compartmentalizing radiation code a bit * More compartmentalizing * Pushing loop into bugsrad because it makes things cleaner * Small loop pushes * Little cleanup * Moving soil_veg code * GPU fix and a little cleanup * Missed a file to commit * Making work with old build system * Need zeroing routines for set_case_initial_conditions * Adding comment explaining why advance_soil_veg is being packaged with Radiation code now 2026-03-18 16:02:50 -05004c3e62ea9fb1455849859daf0fc91af3b6c12ffdClubb radiation update (#1283)editnumerical_check.F90stats_netcdf.F90154d87c9d163c7ad898aabe42be5ba4484234d281773872129000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comDash app improvements (#1280) * Mainly dash app improvements, but also removing unused args from stats and improving run scripts * Small update to ui in run tab * Improvements to make plotting faster, fixing various bugs, making things more robust, and adding more run modification fields (out_dir/dt_main/etc) * Adding les plotting capabilities, lots of tiny improvements * Reverting run_bindiff_all.py * Tiny quality of life improvements - fixing port conflict, opening in browser automatically, and defaulting to the run_tab instead of requiring a first click 2026-03-18 17:15:29 -0500154d87c9d163c7ad898aabe42be5ba4484234d28Dash app improvements (#1280)editstats_netcdf.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse222http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/222/220http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/220/Started by an SCM change2207ddcdcf1018a59a3eebcb08156f6f19be6ec69457ddcdcf1018a59a3eebcb08156f6f19be6ec6945refs/remotes/origin/clubb_silhs_devel7ddcdcf1018a59a3eebcb08156f6f19be6ec69457ddcdcf1018a59a3eebcb08156f6f19be6ec6945refs/remotes/origin/clubb_silhs_devel7ddcdcf1018a59a3eebcb08156f6f19be6ec69457ddcdcf1018a59a3eebcb08156f6f19be6ec6945refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#22026864002373579cam_BFB_coarse_res_gfortran_test #220220false2202212SUCCESS1773822428462http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/220/adg1_adg2_3d_luhar_pdf.F90e08890831c3c07606716b2b8f620ea1e9029a2c51773804486000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comADG1_w_closure consistency fix (#1282) * G_unit_test / ADG1_w_closure fix. A recent commit (bff619bdb2836f83ac658be8b8c258d41aaa6e14) introduced a change to ADG1_ADG2_responder_params that caused an inconsistency in the pdf calculations that the G_unit tests picked up on. This corrects it, but is also BIT_CHANGING, since it changes the calculation slightly when wp2 is exactly tolerance. * Adding test to ensure err_info is correctly set by adg1 routines when calling with bad inputs - also moving wp2 check to ADG1_w_closure because it makes more sense there 2026-03-17 22:28:06 -0500e08890831c3c07606716b2b8f620ea1e9029a2c5ADG1_w_closure consistency fix (#1282)editadg1_adg2_3d_luhar_pdf.F90matrix_solver_wrapper.F90lapack_wrap.F908c9f81a53ce52fb923adc0fe4e55278910ade1b61773805495000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comFixing clubb_error_handling_gfortran_test (#1281) * Fixing error test by making the code check for NaNs in all solver cases - before it was only checking in Lapack. Also making a python version of the test and updating jenkins script to use it. * A little cleanup * Adding more comments and making a little data structure for the tests 2026-03-17 22:44:55 -05008c9f81a53ce52fb923adc0fe4e55278910ade1b6Fixing clubb_error_handling_gfortran_test (#1281)editmatrix_solver_wrapper.F90editlapack_wrap.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse221http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/221/219http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/219/Started by an SCM change21925ab8e25013d1b8e8efa20d42566185cff8cce8025ab8e25013d1b8e8efa20d42566185cff8cce80refs/remotes/origin/clubb_silhs_devel25ab8e25013d1b8e8efa20d42566185cff8cce8025ab8e25013d1b8e8efa20d42566185cff8cce80refs/remotes/origin/clubb_silhs_devel25ab8e25013d1b8e8efa20d42566185cff8cce8025ab8e25013d1b8e8efa20d42566185cff8cce80refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#21930879592373579cam_BFB_coarse_res_gfortran_test #219219false2191959SUCCESS1773649628110http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/219/pdf_closure_module.F90adg1_adg2_3d_luhar_pdf.F904e8a58b56a14b144d50b72fe11d6d3059751226e1773630552000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comStability fix (#1276) * Adding multiprocesses to run_scm_all.py, making the GPU jenkins tests only use 1 thread though, otherwise the different processes will fight for GPU usage * Making the if statement in ADG1_ADG2_responder_params use a strict inequality - this was causing numerical issues when fields were close to tolerance. This will be slightly BIT_CHANGING for most cases. * Adding comments to run_scm_all.py and removing the if-case in ADG1_ADG2_responder_params in favor of an explicit error check * Changing nprocs to nproc and updating jenkins tests 2026-03-15 22:09:12 -05004e8a58b56a14b144d50b72fe11d6d3059751226eStability fix (#1276)editpdf_closure_module.F90editadg1_adg2_3d_luhar_pdf.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse220http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/220/218http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/218/Started by an SCM change2188160ba2cdf032e1c63a9981826ced50834458c318160ba2cdf032e1c63a9981826ced50834458c31refs/remotes/origin/clubb_silhs_devel8160ba2cdf032e1c63a9981826ced50834458c318160ba2cdf032e1c63a9981826ced50834458c31refs/remotes/origin/clubb_silhs_devel8160ba2cdf032e1c63a9981826ced50834458c318160ba2cdf032e1c63a9981826ced50834458c31refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#21833220822373579cam_BFB_coarse_res_gfortran_test #218218false2181868SUCCESS1773476826841http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/218/model_flags.F90f1a6ede61b31f09344a7fab737df2120f404eb351773197406000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comNew solvers by default (#1275) - BIT_CHANGING * Setting our solvers to use the new LU solvers by default instead of Lapack. This is BIT_CHANGING, but not answer changing. * Also changing default in code 2026-03-10 21:50:06 -0500f1a6ede61b31f09344a7fab737df2120f404eb35New solvers by default (#1275) - BIT_CHANGINGeditmodel_flags.F90CMakeLists.txt156f7a7e22961d15a051d3d9e795d62aa690a4911773317100000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdd blank line in order to trigger git updates (issue #848) 2026-03-12 07:05:00 -0500156f7a7e22961d15a051d3d9e795d62aa690a491Add blank line in order to trigger git updates (issue #848)editCMakeLists.txtcalendar.F90b955bcdba6946a04ddfecab05d875b093482cd491773445654000http://carson.math.uwm.edu/jenkins/user/hancockTrevor Hancockhancoct@uwm.eduAdded blank line 2026-03-13 18:47:34 -0500b955bcdba6946a04ddfecab05d875b093482cd49Added blank lineeditcalendar.F90LY93_pdf.F906f52a8390ba9ec8ee637344cde3798e632fcbbe81773453517000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRemove Id tag from LY93_pdf.F90 in order to trigger git update scripts larson-group/sys_admin#848 2026-03-13 20:58:37 -05006f52a8390ba9ec8ee637344cde3798e632fcbbe8Remove Id tag from LY93_pdf.F90 in order to trigger git update scriptseditLY93_pdf.F90est_kessler_microphys_module.F90f9d5c3e33e006e8af0851e47795510ab6d9d3f191773453655000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRemove unnecessary comments from est_kessler_microphys_module in order to trigger git update scripts. larson-group/sys_admin#848 2026-03-13 21:00:55 -0500f9d5c3e33e006e8af0851e47795510ab6d9d3f19Remove unnecessary comments from est_kessler_microphys_moduleeditest_kessler_microphys_module.F90githttp://carson.math.uwm.edu/jenkins/user/hancockTrevor Hancockhttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse219http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/219/217http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/217/Started by an SCM change2176a2ef4ee3c1a7bb3e904ed95812aeb933a93ed726a2ef4ee3c1a7bb3e904ed95812aeb933a93ed72refs/remotes/origin/clubb_silhs_devel6a2ef4ee3c1a7bb3e904ed95812aeb933a93ed726a2ef4ee3c1a7bb3e904ed95812aeb933a93ed72refs/remotes/origin/clubb_silhs_devel6a2ef4ee3c1a7bb3e904ed95812aeb933a93ed726a2ef4ee3c1a7bb3e904ed95812aeb933a93ed72refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#21728085712373579cam_BFB_coarse_res_gfortran_test #217217false2171612SUCCESS1772530027574http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/217/CMakeLists.txtc309d7a42d72e852de3cb9702f711c58c0a606d21772502018000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdd blank line to test python scripts Testing python scripts from crontab 2026-03-02 19:40:18 -0600c309d7a42d72e852de3cb9702f711c58c0a606d2Add blank line to test python scriptseditCMakeLists.txtgithttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse218http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/218/216http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/216/Started by an SCM change216d0c8eda8d83d973026de33ce9e818f35d3415595d0c8eda8d83d973026de33ce9e818f35d3415595refs/remotes/origin/clubb_silhs_develd0c8eda8d83d973026de33ce9e818f35d3415595d0c8eda8d83d973026de33ce9e818f35d3415595refs/remotes/origin/clubb_silhs_develd0c8eda8d83d973026de33ce9e818f35d3415595d0c8eda8d83d973026de33ce9e818f35d3415595refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#21631561092373579cam_BFB_coarse_res_gfortran_test #216216false2161521SUCCESS1771925227945http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/216/constants_clubb.F90e1212e407aa91a62b415f3f878a1fa09e8dc7df21771881523000http://carson.math.uwm.edu/jenkins/user/hancockTrevor Hancockhancoct@uwm.eduAdded blank line to test new python scripts 2026-02-23 15:18:43 -0600e1212e407aa91a62b415f3f878a1fa09e8dc7df2Added blank line to test new python scriptseditconstants_clubb.F90githttp://carson.math.uwm.edu/jenkins/user/hancockTrevor Hancockfalse217http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/217/215http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/215/Started by user Gunther HueblerhueblerGunther Huebler215231228a130cc514a9762e976d83229ba1d77003c231228a130cc514a9762e976d83229ba1d77003crefs/remotes/origin/clubb_silhs_devel231228a130cc514a9762e976d83229ba1d77003c231228a130cc514a9762e976d83229ba1d77003crefs/remotes/origin/clubb_silhs_devel231228a130cc514a9762e976d83229ba1d77003c231228a130cc514a9762e976d83229ba1d77003crefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#21515505432373579cam_BFB_coarse_res_gfortran_test #215215false2151292SUCCESS1771395761787http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/215/advance_xm_wpxp_module.F90clip_explicit.F90clubb_api_module.F90stats_netcdf.F90input_reader.F90stats_lh_zt_module.F90stats_type_utilities.F90CMakeLists.txtsetup_clubb_pdf_params.F90advance_windm_edsclrm_module.F90advance_helper_module.F90mono_flux_limiter.F90advance_wp2_wp3_module.F90mixing_length.F90advance_xp2_xpyp_module.F90output_grads.F90stats_rad_zt_module.F90stats_rad_zm_module.F90pdf_closure_module.F90matrix_solver_wrapper.F90recl.inccorr_varnce_module.F90remapping_module.F90precipitation_fraction.F90numerical_check.F90output_netcdf.F90stats_lh_sfc_module.F90stat_file_module.F90stats_variables.F90advance_clubb_core_module.F90advance_xp3_module.F90stats_zt_module.F90input_names.F90fill_holes.F90stats_sfc_module.F90stats_type.F90stats_zm_module.F90interpolation.F90stats_clubb_utilities.F90sfc_varnce_module.F90ca2eb415b0b77bdc3831d6ada5249d7a2c3326821771386880000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comNew stats system (#1270) * Initial commit for the new stats system * Adding helper scripts * Fixes and another script * Updates * Improvements * Fixed bug in all_stats.in * Updates * Adding dash app * Updates, also including new dash app since I'm finding it quite useful * Improvements/fixes and adding missing variable to all_stats.in * Updates * Moving wp2sclrp, wpsclrp2, wpsclrprtp, and wpsclrpthlp to the zt netcdf output file, since those are zt variables. Also adding a missing variable, rcm_in_cloud, to all_stats.in and correcting a missing comma bug. This is technically BIT_CHANGING because the variables are moving files, but the stored data is identical from 1:nzt - the nzm level just had garbage for those variables and is now gone. * Updates * Updates * The big stats pull, only new stats remains now * Some cleanup * Lot's of core rework, new index caching system speeds things up * Missed files * Small improvements a bug fix to the grid remapped output * Fixing up logic and ordering things a bit better * Little improvements * Cleanup and simplications to new stats core * Little improvements, mostly to dash app * Mostly cleanup * Making GPU code work * Making more scripts work * Fixing line lengths * Bug fixes * Bug fixes * Bug fixes * Bug fixes * Bug fixes and script updates * Jenkins script update * Jenkins script update * Jenkins script update * Jenkins script update * Jenkins script update * Jenkins script update * Script update * Script update * Script update * Script update * Script update * Script update * Script update * Test update * Jenkins script update * Test update * Fixing bug * Fixing bug * Fixing up comments * Small fixes * Jenkins script update * CMake update * Little fix for cmake * Jenkins script update * Jenkins script updateS * Cmake update * Jenkins script update * Jenkins script update * Jenkins script updates * Adding new stats input * Small fixes * Fixing old compile scripts * Jenkins script updates * Jenkins script updates * Jenkins script updates * Little fixes * Little cmake fix * Little jenkins fix * Mono flux test update and _api renamings * Small Jenkins fix * Adding missing comments back * Even more comments * stats updates * Even more comments * Various small improvements * Removing test statsd * Adding some things back to _api and adding structure explaining comment in stats files. * Many more comments * Removing plan file * Spelling fix 2026-02-17 21:54:40 -0600ca2eb415b0b77bdc3831d6ada5249d7a2c332682New stats system (#1270)editmatrix_solver_wrapper.F90addstats_netcdf.F90deletestats_rad_zt_module.F90editadvance_helper_module.F90deleterecl.inceditadvance_windm_edsclrm_module.F90editadvance_clubb_core_module.F90editCMakeLists.txtdeletestats_lh_sfc_module.F90editsfc_varnce_module.F90editadvance_xm_wpxp_module.F90deleteinput_reader.F90deletestats_zt_module.F90deleteinput_names.F90deletestats_rad_zm_module.F90deletestats_type_utilities.F90deletestats_lh_zt_module.F90editadvance_wp2_wp3_module.F90deletestats_zm_module.F90editcorr_varnce_module.F90editprecipitation_fraction.F90editclip_explicit.F90editmixing_length.F90editnumerical_check.F90editadvance_xp3_module.F90editinterpolation.F90deleteoutput_netcdf.F90deletestat_file_module.F90deleteoutput_grads.F90deletestats_sfc_module.F90deletestats_variables.F90editsetup_clubb_pdf_params.F90deletestats_type.F90editfill_holes.F90editclubb_api_module.F90editmono_flux_limiter.F90editpdf_closure_module.F90editremapping_module.F90editstats_clubb_utilities.F90editadvance_xp2_xpyp_module.F90silhs_api_module.F90CMakeLists.txtoutput_2D_samples_module.F90latin_hypercube_driver_module.F9000e0c2f5df3b257a5bd1125dbaefb99033b0b03e1771386880000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comNew stats system (#1270) * Initial commit for the new stats system * Adding helper scripts * Fixes and another script * Updates * Improvements * Fixed bug in all_stats.in * Updates * Adding dash app * Updates, also including new dash app since I'm finding it quite useful * Improvements/fixes and adding missing variable to all_stats.in * Updates * Moving wp2sclrp, wpsclrp2, wpsclrprtp, and wpsclrpthlp to the zt netcdf output file, since those are zt variables. Also adding a missing variable, rcm_in_cloud, to all_stats.in and correcting a missing comma bug. This is technically BIT_CHANGING because the variables are moving files, but the stored data is identical from 1:nzt - the nzm level just had garbage for those variables and is now gone. * Updates * Updates * The big stats pull, only new stats remains now * Some cleanup * Lot's of core rework, new index caching system speeds things up * Missed files * Small improvements a bug fix to the grid remapped output * Fixing up logic and ordering things a bit better * Little improvements * Cleanup and simplications to new stats core * Little improvements, mostly to dash app * Mostly cleanup * Making GPU code work * Making more scripts work * Fixing line lengths * Bug fixes * Bug fixes * Bug fixes * Bug fixes * Bug fixes and script updates * Jenkins script update * Jenkins script update * Jenkins script update * Jenkins script update * Jenkins script update * Jenkins script update * Script update * Script update * Script update * Script update * Script update * Script update * Script update * Test update * Jenkins script update * Test update * Fixing bug * Fixing bug * Fixing up comments * Small fixes * Jenkins script update * CMake update * Little fix for cmake * Jenkins script update * Jenkins script updateS * Cmake update * Jenkins script update * Jenkins script update * Jenkins script updates * Adding new stats input * Small fixes * Fixing old compile scripts * Jenkins script updates * Jenkins script updates * Jenkins script updates * Little fixes * Little cmake fix * Little jenkins fix * Mono flux test update and _api renamings * Small Jenkins fix * Adding missing comments back * Even more comments * stats updates * Even more comments * Various small improvements * Removing test statsd * Adding some things back to _api and adding structure explaining comment in stats files. * Many more comments * Removing plan file * Spelling fix 2026-02-17 21:54:40 -060000e0c2f5df3b257a5bd1125dbaefb99033b0b03eNew stats system (#1270)deleteoutput_2D_samples_module.F90editsilhs_api_module.F90editCMakeLists.txteditlatin_hypercube_driver_module.F90stats_netcdf.F90231830ece1c7fe859943f627e96d695d36742a8f1771388597000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing fire tuner 2026-02-17 22:23:17 -0600231830ece1c7fe859943f627e96d695d36742a8fFixing fire tunereditstats_netcdf.F90run_scripts/run_cesm_uwm_coarse_res_r8029_flags.shsrc/physics/cam/subcol_SILHS.F90run_scripts/netcdf_3D_vars_diff.pysrc/physics/cam/clubb_intr.F90run_scripts/run_scam.bashbld/namelist_files/namelist_definition.xmlrun_scripts/run_cesm_uwm.shrun_scripts/run_cesm_uwm_coarse_res.shrun_scripts/generate_clubb_stats_registry.pyrun_scripts/all_stats.in231228a130cc514a9762e976d83229ba1d77003c1771392368000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdate to make compatible with new stats. (#214) * Update to make compatible with new stats. This is BIT_CHANGING because it seems to fix some bugs - a few variables with unitialized output, and silhs stats output is now zeroed by the begin_timestep call, rather than just little the last timestep of data slip through as if it was the current timesteps data. * Fixing missing _api * Updating stats list to reflect new ordering and the size->nz change in stats_netcdf 2026-02-17 23:26:08 -0600231228a130cc514a9762e976d83229ba1d77003cUpdate to make compatible with new stats. (#214)editrun_scripts/run_cesm_uwm_coarse_res.shaddrun_scripts/all_stats.ineditrun_scripts/run_scam.basheditrun_scripts/netcdf_3D_vars_diff.pyaddrun_scripts/generate_clubb_stats_registry.pyeditsrc/physics/cam/clubb_intr.F90editrun_scripts/run_cesm_uwm_coarse_res_r8029_flags.sheditsrc/physics/cam/subcol_SILHS.F90editbld/namelist_files/namelist_definition.xmleditrun_scripts/run_cesm_uwm.shgithttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse216http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/216/214http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/214/Started by an SCM change214fc2aea51f7e10943c7ba8a276138380f33cc0a23fc2aea51f7e10943c7ba8a276138380f33cc0a23refs/remotes/origin/clubb_silhs_develfc2aea51f7e10943c7ba8a276138380f33cc0a23fc2aea51f7e10943c7ba8a276138380f33cc0a23refs/remotes/origin/clubb_silhs_develfc2aea51f7e10943c7ba8a276138380f33cc0a23fc2aea51f7e10943c7ba8a276138380f33cc0a23refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#21428568372373579cam_BFB_coarse_res_gfortran_test #214214false214803SUCCESS1770888428254http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/214/CMakeLists.txt5505ad9ac7e87b808b2f91138dcff711bd4ac3581770849785000http://carson.math.uwm.edu/jenkins/user/hancockTrevor Hancockhancoct@uwm.eduRemoved blank line to test python update scripts 2026-02-11 16:43:05 -06005505ad9ac7e87b808b2f91138dcff711bd4ac358Removed blank line to test python update scriptseditCMakeLists.txtgithttp://carson.math.uwm.edu/jenkins/user/hancockTrevor Hancockfalse215http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/215/213http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/213/Started by an SCM change213d8bf668e6f0dce0bfad5cb7ee79ed43ed27df630d8bf668e6f0dce0bfad5cb7ee79ed43ed27df630refs/remotes/origin/clubb_silhs_develd8bf668e6f0dce0bfad5cb7ee79ed43ed27df630d8bf668e6f0dce0bfad5cb7ee79ed43ed27df630refs/remotes/origin/clubb_silhs_develd8bf668e6f0dce0bfad5cb7ee79ed43ed27df630d8bf668e6f0dce0bfad5cb7ee79ed43ed27df630refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#21328595492373579cam_BFB_coarse_res_gfortran_test #213213false213710SUCCESS1770715629495http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/213/CMakeLists.txtd29406cd82e6ea6a7e81e4b94d29d43fb8dd8cdd1770687739000http://carson.math.uwm.edu/jenkins/user/pickettCole Pickettlarsongroupgithub@gmail.comAdded empty line to test update scripts 2026-02-09 19:42:19 -0600d29406cd82e6ea6a7e81e4b94d29d43fb8dd8cddAdded empty line to test update scriptseditCMakeLists.txtgithttp://carson.math.uwm.edu/jenkins/user/pickettCole Pickettfalse214http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/214/212http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/212/Started by an SCM change2126a1b2a1dee4d65fe95d5fcde48d2acccadd943546a1b2a1dee4d65fe95d5fcde48d2acccadd94354refs/remotes/origin/clubb_silhs_devel6a1b2a1dee4d65fe95d5fcde48d2acccadd943546a1b2a1dee4d65fe95d5fcde48d2acccadd94354refs/remotes/origin/clubb_silhs_devel6a1b2a1dee4d65fe95d5fcde48d2acccadd943546a1b2a1dee4d65fe95d5fcde48d2acccadd94354refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#21229096472373579cam_BFB_coarse_res_gfortran_test #212212false212613SUCCESS1770370026486http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/212/stats_clubb_utilities.F90stats_zm_module.F90stats_zt_module.F9048b789e0c834a7eb377c1cf45878c3abb64dae841770322192000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comMoving wp2sclrp, wpsclrp2, wpsclrprtp, and wpsclrpthlp to the zt netcdf output file, since those are zt variables. Also adding a missing variable, rcm_in_cloud, to all_stats.in and correcting a missing comma bug. This is technically BIT_CHANGING because the variables are moving files, but the stored data is identical from 1:nzt - the nzm level just had garbage for those variables and is now gone. (#1271) 2026-02-05 14:09:52 -060048b789e0c834a7eb377c1cf45878c3abb64dae84Moving wp2sclrp, wpsclrp2, wpsclrprtp, and wpsclrpthlp to the zt netcdf output file, since those are zt variables. Also adding a missing variable, rcm_in_cloud, to all_stats.in and correcting a missing comma bug. This is technically BIT_CHANGING because the variables are moving files, but the stored data is identical from 1:nzt - the nzm level just had garbage for those variables and is now gone. (#1271)editstats_clubb_utilities.F90editstats_zm_module.F90editstats_zt_module.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse213http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/213/211http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/211/Started by an SCM change211124719bbb5e203afc13053a60839885756b513b7124719bbb5e203afc13053a60839885756b513b7refs/remotes/origin/clubb_silhs_devel124719bbb5e203afc13053a60839885756b513b7124719bbb5e203afc13053a60839885756b513b7refs/remotes/origin/clubb_silhs_devel124719bbb5e203afc13053a60839885756b513b7124719bbb5e203afc13053a60839885756b513b7refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#21120940102373579cam_BFB_coarse_res_gfortran_test #211211false211522SUCCESS1768037228220http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/211/clubb_api_module.F900aea68bf1d70ce56370dda1f26d1de4c6956ba381767993114000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduRemoving extra acc end statement 2026-01-09 15:11:54 -06000aea68bf1d70ce56370dda1f26d1de4c6956ba38Removing extra acc end statementeditclubb_api_module.F90githttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse212http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/212/210http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/210/Started by user Gunther HueblerhueblerGunther Huebler210795f6eaab0639bef8a6a2cfa8d9368b9dd169db3795f6eaab0639bef8a6a2cfa8d9368b9dd169db3refs/remotes/origin/clubb_silhs_devel795f6eaab0639bef8a6a2cfa8d9368b9dd169db3795f6eaab0639bef8a6a2cfa8d9368b9dd169db3refs/remotes/origin/clubb_silhs_devel795f6eaab0639bef8a6a2cfa8d9368b9dd169db3795f6eaab0639bef8a6a2cfa8d9368b9dd169db3refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#21014123382373579cam_BFB_coarse_res_gfortran_test #210210false210465SUCCESS1767995610433http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/210/advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90a7e3b7169c33a63620e520f7a4447e61def0f8cf1767951630000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduGPU fixed and cgils_s6 fix 2026-01-09 03:40:30 -0600a7e3b7169c33a63620e520f7a4447e61def0f8cfGPU fixed and cgils_s6 fixeditadvance_wp2_wp3_module.F90editadvance_xp2_xpyp_module.F90clubb_api_module.F90pdf_closure_module.F90f52566e1b7170bc3e14dc6dab2411ca77a2baf401767981713000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMore small bug fixes 2026-01-09 12:01:53 -0600f52566e1b7170bc3e14dc6dab2411ca77a2baf40More small bug fixeseditclubb_api_module.F90editpdf_closure_module.F90githttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse211http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/211/209http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/209/Started by user Gunther HueblerhueblerGunther Huebler2095e1b0fb6c44d8b1f12db713c058fefdd96b676065e1b0fb6c44d8b1f12db713c058fefdd96b67606refs/remotes/origin/clubb_silhs_devel5e1b0fb6c44d8b1f12db713c058fefdd96b676065e1b0fb6c44d8b1f12db713c058fefdd96b67606refs/remotes/origin/clubb_silhs_devel5e1b0fb6c44d8b1f12db713c058fefdd96b676065e1b0fb6c44d8b1f12db713c058fefdd96b67606refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#20913885762373579cam_BFB_coarse_res_gfortran_test #209209false209308SUCCESS1767912761268http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/209/false210http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/210/208http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/208/Started by user Gunther HueblerhueblerGunther Huebler2085e1b0fb6c44d8b1f12db713c058fefdd96b676065e1b0fb6c44d8b1f12db713c058fefdd96b67606refs/remotes/origin/clubb_silhs_devel5e1b0fb6c44d8b1f12db713c058fefdd96b676065e1b0fb6c44d8b1f12db713c058fefdd96b67606refs/remotes/origin/clubb_silhs_devel5e1b0fb6c44d8b1f12db713c058fefdd96b676065e1b0fb6c44d8b1f12db713c058fefdd96b67606refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#2081125752373579cam_BFB_coarse_res_gfortran_test #208208false208303SUCCESS1767912030864http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/208/model_flags.F90clubb_api_module.F90advance_xm_wpxp_module.F90constants_clubb.F90numerical_check.F90output_netcdf.F90stats_variables.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90grid_adaptation_module.F90advance_clubb_core_module.F90stats_zt_module.F90pdf_closure_module.F90stats_clubb_utilities.F90stats_zm_module.F907a1bb756cf4c4937e3ed2f2f431666919e52834f1767903824000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comNon trad coriolis (#1267) * Updating the clubb core and silhs version files * Fixing bug. qclvar copying is handled by the api, but we were deleting it with an unstructured data statement. I added this due as a fix before thinking qclvar was a local variable, which happened because I mixed up the CLUBB_CAM and CLUBBND_CAM flags. https://github.com/larson-group/cam/issues/175 * Fixing GPU bug. There is a vertical dependency with wpxp. This is what was breaking the ECT test, see larson-group/cam#175 * Moving pdf_params copying to copyin. This is the data structure that contains pointers, and these pointers will be different on the host and device, so it is bad in theory to copy the structure back to the CPU as it might overwrite cpu memory pointers with gpu memory pointers. In practice though I've seen no problems caused by this, I'm just making this commit preemptively, and it has already been tested with the ECT test. * Moving PosInf to clubb_model_settings.F90 * Updating the clubb core and silhs version files * Add flags for the Coriolis terms. * Pass fcory from api module into advance module * Implement the traditional Coriolis terms * Implement the nontraditional Coriolis terms * Add stats variables for the Coriolis terms * Compute Coriolis parameters from namelist latitude * Create the coriolis_test case * Tune the coriolis_test case. However, oscillation frequency is too slow * Correct a coefficient in Coriolis. "coriolis_test" matches analytical * Update advance_clubb_core_module.F90 Rename fcory as fcor_y and add description * Update advance_wp2_wp3_module.F90 Rename fcory as fcor_y and add description * Update advance_xm_wpxp_module.F90 Rename fcory as fcor_y and add description * Update advance_xp2_xpyp_module.F90 Rename fcory as fcor_y and add description * Update clubb_api_module.F90 Rename fcory as fcor_y and add description * Update spurious_source_test.F90 Rename fcory as fcor_y and add description * Update clubb_driver.F90 Rename fcor as fcor_y and add description. Also, add description for the coriolis_test * Update generalized_grid_test.F90 Rename fcory as fcor_y and add description. * Update coriolis_test_model.in Add description for the Coriolis test case * Stablize the cgils_s6 case with smaller time step * Create the ekman case * Tune the ekman case to match LES * Compute wp2up with PDF and pass along with wp2thvp * Implement the nontraditional Coriolis term for wp3 * Fine-tune parameters for the ekman case * Create the atex_long case * Retune ekman case with l_vary_convect_depth = .true. * Fine-tune the atex_long case * Add atex_long case to pyplotgen * Fine-tune atex_long case with less radical changes * Updating the clubb core and silhs version files * Small bug fix in the wp2up flip and adding new files to the cmakelist * Renmaing, moving some files, and reverting change to cgils_s6 timestep * Adding new flags to flag test file * Updating comment for fcor_y calculation explanation * Removing accidentally added file --------- Co-authored-by: pickett <larsongroupgithub@gmail.com> Co-authored-by: Hing Ong <hing.ong@anl.gov> Co-authored-by: Hing Ong <36782452+HingOng@users.noreply.github.com> 2026-01-08 14:23:44 -06007a1bb756cf4c4937e3ed2f2f431666919e52834fNon trad coriolis (#1267)editadvance_xp2_xpyp_module.F90editmodel_flags.F90editstats_clubb_utilities.F90editoutput_netcdf.F90editadvance_wp2_wp3_module.F90editstats_zm_module.F90editconstants_clubb.F90editstats_variables.F90editstats_zt_module.F90editgrid_adaptation_module.F90editpdf_closure_module.F90editadvance_clubb_core_module.F90editclubb_api_module.F90editadvance_xm_wpxp_module.F90editnumerical_check.F90bld/namelist_files/namelist_definition.xmlbld/build-namelistsrc/physics/cam/clubb_intr.F90bld/namelist_files/namelist_defaults_cam.xmle66e18d3220e298679e1c9ba43349068693d72b41767904703000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comMaking changes needed for clubb's new non traditional coriolis update (#211) * Making changes needed for clubb's new non traditional coriolis update * Also adding namelist entries for new coriolis options * Renaming fcorz to fcor_y 2026-01-08 14:38:23 -0600e66e18d3220e298679e1c9ba43349068693d72b4Making changes needed for clubb's new non traditional coriolis update (#211)editbld/build-namelisteditsrc/physics/cam/clubb_intr.F90editbld/namelist_files/namelist_definition.xmleditbld/namelist_files/namelist_defaults_cam.xmlbld/namelist_files/namelist_definition.xmlbld/build-namelistbld/namelist_files/namelist_defaults_cam.xmlsrc/physics/cam/clubb_intr.F905e1b0fb6c44d8b1f12db713c058fefdd96b676061767911701000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduForgot to rename variables, and also setting fcor and fcor_y to nonzero. Which should be BFB thanks to the l_implemented flag. 2026-01-08 16:35:01 -06005e1b0fb6c44d8b1f12db713c058fefdd96b67606Forgot to rename variables, and also setting fcor and fcor_y to nonzero. Which should be BFB thanks to the l_implemented flag.editbld/namelist_files/namelist_defaults_cam.xmleditsrc/physics/cam/clubb_intr.F90editbld/build-namelisteditbld/namelist_files/namelist_definition.xmlgithttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse209http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/209/207http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/207/Started by an SCM change207fe5c039b9bba8aa4acb3a124acc0ad44cbe4cf2dfe5c039b9bba8aa4acb3a124acc0ad44cbe4cf2drefs/remotes/origin/clubb_silhs_develfe5c039b9bba8aa4acb3a124acc0ad44cbe4cf2dfe5c039b9bba8aa4acb3a124acc0ad44cbe4cf2drefs/remotes/origin/clubb_silhs_develfe5c039b9bba8aa4acb3a124acc0ad44cbe4cf2dfe5c039b9bba8aa4acb3a124acc0ad44cbe4cf2drefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#2072988462373579cam_BFB_coarse_res_gfortran_test #207207false207249SUCCESS1766050027692http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/207/grid_class.F90advance_clubb_core_module.F90fill_holes.F90058f1a75004ea7dc436c9f9b91842ca0f5f84b0a1766005108000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comFixes for fill_holes and edsclr code (#1266) * Fixing bugs in new hole fillers that caused error when ran in descending mode, the issue was that dz is negative in descending mode, so we need abs() around it when calculating the normalized mass. Also fixing a related bug in the way edsclr code calls the hole filler - it was not using the generalized bounds. Also removing the ifdef in favor of normal ifs * Copying the rtm and thm values from arm_97_sounding.in to the edsclr_sounding file. This still allows arm_97 to catch the bugs we want it to. 2025-12-17 14:58:28 -0600058f1a75004ea7dc436c9f9b91842ca0f5f84b0aFixes for fill_holes and edsclr code (#1266)editgrid_class.F90editadvance_clubb_core_module.F90editfill_holes.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse208http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/208/206http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/206/Started by an SCM change206f1c6a5ece8f3616577a7dca89d68f4fe968ffa86f1c6a5ece8f3616577a7dca89d68f4fe968ffa86refs/remotes/origin/clubb_silhs_develf1c6a5ece8f3616577a7dca89d68f4fe968ffa86f1c6a5ece8f3616577a7dca89d68f4fe968ffa86refs/remotes/origin/clubb_silhs_develf1c6a5ece8f3616577a7dca89d68f4fe968ffa86f1c6a5ece8f3616577a7dca89d68f4fe968ffa86refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#2062747292373579cam_BFB_coarse_res_gfortran_test #206206false206149SUCCESS1765445230096http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/206/advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90model_flags.F90advance_xm_wpxp_module.F90advance_windm_edsclrm_module.F90mono_flux_limiter.F90b084a984833e4455d1caab1c3ea163c4a9f325711765406071000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comGrid reverse matrix test (#1265) * Making new flag l_force_descending_solves that forces us to use descending solves. Having it true keeps results BFB between ascending and descending when using -O0. * renaming test * Moving flag * test fix * test fix * test fix * Removing iteration limit on script and adding test error * Removing test error, it was correctly caught * Adding max statement to aid in single precision runs and removing accidentally commited file. 2025-12-10 16:34:31 -0600b084a984833e4455d1caab1c3ea163c4a9f32571Grid reverse matrix test (#1265)editmodel_flags.F90editadvance_xm_wpxp_module.F90editadvance_windm_edsclrm_module.F90editadvance_wp2_wp3_module.F90editadvance_xp2_xpyp_module.F90editmono_flux_limiter.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse207http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/207/205http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/205/Started by an SCM change205f4776e99c62d8fb12936020cbc47f854c088a006f4776e99c62d8fb12936020cbc47f854c088a006refs/remotes/origin/clubb_silhs_develf4776e99c62d8fb12936020cbc47f854c088a006f4776e99c62d8fb12936020cbc47f854c088a006refs/remotes/origin/clubb_silhs_develf4776e99c62d8fb12936020cbc47f854c088a006f4776e99c62d8fb12936020cbc47f854c088a006refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#2051130122373579cam_BFB_coarse_res_gfortran_test #205205false20548SUCCESS1765013231153http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/205/penta_lu_solver.F90419df6ef23f8775f6f3a83b6312f149d43062ffe1764747200000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comBIT_CHANGING bug fix for the penta_lu solver, only BC when using penta_solve_method=2 (#1264) 2025-12-03 01:33:20 -0600419df6ef23f8775f6f3a83b6312f149d43062ffeBIT_CHANGING bug fix for the penta_lu solver, only BC when using penta_solve_method=2 (#1264)editpenta_lu_solver.F90advance_wp2_wp3_module.F90CMakeLists.txtmatrix_solver_wrapper.F90penta_bicgstab_solver.F90advance_xm_wpxp_module.F90c77842f6ac6d78f16c08aed2bfebfceaf2bbc2ad1764884961000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comBicgstab addition (#1261) * Adding 'initial' bicgstab solver * Currently working, lots of diagnostic code still present * Pruning everything unneccesary, adding lots of comments, making names good. * Adding jenkins test to plot results with different solvers * jenkins script update * jenkins script update * jenkins script update * jenkins script update * jenkins script update * jenkins script update * jenkins script update * Removing print statement * Improved naming and comments * Removing print statement * A couple more comments. 2025-12-04 15:49:21 -0600c77842f6ac6d78f16c08aed2bfebfceaf2bbc2adBicgstab addition (#1261)editadvance_xm_wpxp_module.F90editCMakeLists.txteditmatrix_solver_wrapper.F90editadvance_wp2_wp3_module.F90addpenta_bicgstab_solver.F90penta_bicgstab_solver.F9074514b3a007458d588ec67cb92fc99fd927480151764902874000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduSmall bug fix to make gfortran+debug happy, without the _core_rknd this could be a potential type error 2025-12-04 20:47:54 -060074514b3a007458d588ec67cb92fc99fd92748015Small bug fix to make gfortran+debug happy, without the _core_rknd this could be a potential type erroreditpenta_bicgstab_solver.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse206http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/206/204http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/204/Started by an SCM change20497e5861a2d216548b7ab9f32ac60f0423361561d97e5861a2d216548b7ab9f32ac60f0423361561drefs/remotes/origin/clubb_silhs_devel97e5861a2d216548b7ab9f32ac60f0423361561d97e5861a2d216548b7ab9f32ac60f0423361561drefs/remotes/origin/clubb_silhs_devel97e5861a2d216548b7ab9f32ac60f0423361561d97e5861a2d216548b7ab9f32ac60f0423361561drefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#20410770612373579cam_BFB_coarse_res_gfortran_test #204204false20412340SUCCESS1763976430609http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/204/advance_xp2_xpyp_module.F90a3ea9b9a79b5f611682560444ef4f818f3ece9f41763924788000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comMaking update_xp2_mc work with either grid mode (#1263) 2025-11-23 13:06:28 -0600a3ea9b9a79b5f611682560444ef4f818f3ece9f4Making update_xp2_mc work with either grid mode (#1263)editadvance_xp2_xpyp_module.F90advance_wp2_wp3_module.F90fill_holes.F90clip_explicit.F90f73802233285a4f336aa8171515d8e62a1abcdf91763952429000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduImproving variable name 2025-11-23 20:47:09 -0600f73802233285a4f336aa8171515d8e62a1abcdf9Improving variable nameeditclip_explicit.F90editadvance_wp2_wp3_module.F90editfill_holes.F90advance_clubb_core_module.F90stats_clubb_utilities.F905fa665ee419fb2a849cb2534c372cabfcba5699f1763952752000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduSmall bug fix, but this is BIT_CHANGING because it affects stats output. Some zm fields (w_1_zm, w_2_zm, varnce_w_1_zm, varnce_w_2_zm, and mixt_frac_zm) were all nan in the netcdf output when l_call_pdf_closure_twice=.false., because those come from pdf_params_zm. 2025-11-23 20:52:32 -06005fa665ee419fb2a849cb2534c372cabfcba5699fSmall bug fix, but this is BIT_CHANGING because it affects stats output. Some zm fields (w_1_zm, w_2_zm, varnce_w_1_zm, varnce_w_2_zm, and mixt_frac_zm) were all nan in the netcdf output when l_call_pdf_closure_twice=.false., because those come from pdf_params_zm.editadvance_clubb_core_module.F90editstats_clubb_utilities.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse205http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/205/203http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/203/Started by an SCM change203e93995d6d1ce700e02fbab06426d569447acc87ce93995d6d1ce700e02fbab06426d569447acc87crefs/remotes/origin/clubb_silhs_devele93995d6d1ce700e02fbab06426d569447acc87ce93995d6d1ce700e02fbab06426d569447acc87crefs/remotes/origin/clubb_silhs_devele93995d6d1ce700e02fbab06426d569447acc87ce93995d6d1ce700e02fbab06426d569447acc87crefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#20312983872373579cam_BFB_coarse_res_gfortran_test #203203false20312231SUCCESS1763458027941http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/203/model_flags.moderror_code.moda144bd2425e71e751e2bf3ea678b7a3fd98b79261763408615000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduRemoving accidentally added files 2025-11-17 13:43:35 -0600a144bd2425e71e751e2bf3ea678b7a3fd98b7926Removing accidentally added filesdeleteerror_code.moddeletemodel_flags.modgithttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse204http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/204/202http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/202/Started by an SCM change202978c65330575b9e960b9cf70cb854c6301e14630978c65330575b9e960b9cf70cb854c6301e14630refs/remotes/origin/clubb_silhs_devel978c65330575b9e960b9cf70cb854c6301e14630978c65330575b9e960b9cf70cb854c6301e14630refs/remotes/origin/clubb_silhs_devel978c65330575b9e960b9cf70cb854c6301e14630978c65330575b9e960b9cf70cb854c6301e14630refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#2021144742373579cam_BFB_coarse_res_gfortran_test #202202false20212170SUCCESS1763285229756http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/202/advance_wp2_wp3_module.F90fill_holes.F90error_code.F90error_code.modclip_explicit.F901e5a08c884195b6881a87df95750c474ce83c1881763184888000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking clubb_at_least_debug_level not a device routine. It confuses the poor little nvidia compiler when compiling inside cam. Also making the compile script a little more robust. 2025-11-14 23:34:48 -06001e5a08c884195b6881a87df95750c474ce83c188Making clubb_at_least_debug_level not a device routine. It confuses the poor little nvidia compiler when compiling inside cam. Also making the compile script a little more robust.editadvance_wp2_wp3_module.F90editerror_code.F90editclip_explicit.F90adderror_code.modeditfill_holes.F90githttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse203http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/203/201http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/201/Started by an SCM change201e2772a10ee0f76ff8e07673ec85e46ccf041c68ae2772a10ee0f76ff8e07673ec85e46ccf041c68arefs/remotes/origin/clubb_silhs_devele2772a10ee0f76ff8e07673ec85e46ccf041c68ae2772a10ee0f76ff8e07673ec85e46ccf041c68arefs/remotes/origin/clubb_silhs_devele2772a10ee0f76ff8e07673ec85e46ccf041c68ae2772a10ee0f76ff8e07673ec85e46ccf041c68arefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#20130325552373579cam_BFB_coarse_res_gfortran_test #201201false20112008SUCCESS1763112430155http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/201/advance_wp2_wp3_module.F90model_flags.modadvance_xp2_xpyp_module.F90advance_clubb_core_module.F90model_flags.F90clubb_api_module.F90advance_xm_wpxp_module.F90fill_holes.F90output_netcdf.F90CMakeLists.txt8aa1a13718befffb2cd6506f57eef8991f152a011763082040000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comNew fill_holes methods (#1262) * Adding little code bits to help explore fill_holes. This is just a diagnostic playground * Improvements * Maybe better algorithm? * Improvements to the new fill holes * Nice progress * Small tweaks * Mainly adding gptl option for cmake and new run_timestep_tests.py * Making namelist input for fill type, and adding ANOTHER new filler that should be completely parallelizable, but right now large hole groups steal too much from nearby points and it looks kinda bad. * Big improvements, new algorithm is good now * Small updates * Making new fill_holes_type flag for clubb_config_flags * New hybrid filler * Small fixes * Changes, mainly for performance, also adding -gptl option to compile.py to make it use the gptl library * Bunch of things * Updates * small fix * Various cleanup and comments * Small improvement to p_atomic * Updates for speed mainly * Small improvement to p_atomic * Potential improvement to p_atomic * Updates for speed mainly * Updates to make G_unit fill holes test * Improving new tests and making widening_windows and smart_window work in flipped grid mode * All methods passing G_unit test, still need a little cleanup * Slight comments update * Cleanup * Adding named constants for fill type * Uncommentting source checks after compile * Adding new file to old compile method * Small fixes * Small fixes * Mainly comments * Making G_unit test use the new python script and compiler method. Small bug fix too * Little fixes 2025-11-13 19:00:40 -06008aa1a13718befffb2cd6506f57eef8991f152a01New fill_holes methods (#1262)editfill_holes.F90editmodel_flags.F90editadvance_clubb_core_module.F90editadvance_wp2_wp3_module.F90addmodel_flags.modeditoutput_netcdf.F90editCMakeLists.txteditclubb_api_module.F90editadvance_xp2_xpyp_module.F90editadvance_xm_wpxp_module.F90bld/namelist_files/namelist_definition.xmlbld/build-namelistsrc/physics/cam/clubb_intr.F90bld/namelist_files/namelist_defaults_cam.xmlde549bf257cb094273722e62d79a037d8b84e8d41763082097000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comMaking compatible with new fill_holes update (#208) * Making compatible with new version of clubb * Adding fill_holes option to namelist * Adding to last namelist file 2025-11-13 19:01:37 -0600de549bf257cb094273722e62d79a037d8b84e8d4Making compatible with new fill_holes update (#208)editbld/build-namelisteditsrc/physics/cam/clubb_intr.F90editbld/namelist_files/namelist_defaults_cam.xmleditbld/namelist_files/namelist_definition.xmlfill_holes.F906df93a7b24b982fe08a25e35472d2d618f5099e51763105789000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduSmall bug fix in fill_holes_parallel on GPU 2025-11-14 01:36:29 -06006df93a7b24b982fe08a25e35472d2d618f5099e5Small bug fix in fill_holes_parallel on GPUeditfill_holes.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse202http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/202/200http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/200/Started by user Gunther HueblerhueblerGunther Huebler20003ffdce62430d42792ba7bb52c729bb5c6712fa203ffdce62430d42792ba7bb52c729bb5c6712fa2refs/remotes/origin/clubb_silhs_devel03ffdce62430d42792ba7bb52c729bb5c6712fa203ffdce62430d42792ba7bb52c729bb5c6712fa2refs/remotes/origin/clubb_silhs_devel03ffdce62430d42792ba7bb52c729bb5c6712fa203ffdce62430d42792ba7bb52c729bb5c6712fa2refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#20018352552373579cam_BFB_coarse_res_gfortran_test #200200false20011704SUCCESS1759719342369http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/200/model_flags.F90advance_xm_wpxp_module.F90clip_explicit.F90clubb_api_module.F90numerical_check.F90output_netcdf.F90mt95.F90pdf_parameter_module.F90grid_class.F90hydromet_pdf_parameter_module.F90parameters_tunable.F90CMakeLists.txtadvance_windm_edsclrm_module.F90advance_helper_module.F90mixing_length.F90grid_adaptation_module.F90advance_clubb_core_module.F90pdf_closure_module.F90stats_clubb_utilities.F90sfc_varnce_module.F90parameters_model.F906061db38ecdeb1e2e7a5f50a1c0dfdb784e7a1551759715158000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comClubb driver upgrades part2 (#1257) * Initial commit. Breaking up clubb driver into sections. This should be bfb on everything, but this hasn't been checked well yet. * Combining namelist read into case init, same stuff really * Reorganizing many things, mainly in the pursuit of sectioning off code into groups like Microphys or Radiation * Organizing clubb_driver. All cases still BFB. * Mostly cosmetic improvements * Small improvements, comments, making clubb_driver_test to ensure consistency functionality of new compartmentalized model run components * Removing accidentally added files. * Mostly breaking up structure initialization behavior, split into init_ and zero_ so that we don't have to allocate to reset. * Doing away with clubb_model_settings and parameters_module in the spirit of consolidating functionality and spiting module variables. * Missed some changes to commit, should've been included in previous commit * Splitting up funcionality of setup_parameters. Now theres one part that calculates and another checks flag values. * GPU code working, but not BFB yet * GPU all BFB with mutliple columns, except gabls3, and driver test doesnt work (pass reinitialize, fails double timestep test) * Turning off multi_column output for the new driver test * Changes needed after rebase * Name changes, comments, and threadprivate additions for parallel runs * Adding variables to openacc data statements. Without this, the code crashes when using the GPU with l_godunov_upwind_xpyp_ta=.true. * Modifying compiler configurations (mainly optimization level) in order to prepare for switching scipts and tests to cmake, specifically separating out this BIT_CHANGING commit from the rest * thlm_ed and rtm_ed caused GPU errors since those variables were added to a acc loop, but never added to the acc data statement. This change makes it so they're only calculated on the CPU, since they are only used for stats, fixing the issue without adding the GPU memory footprint. * Adding -Mstack_arrays to the nvfortran flags causes us to use more stack space, which means we need to allow processes to use more stack space (when using lots of columns, since that increases memory footprint). We do by using using 'ulimit BIGNUMBER'. * Making old compiler script work with new file structure, also making Input_fields directory and library. * Missed text_writer_lib * Undoing Input_fields directory, it has too many depencencies currently, certainly can be simplified with argument lists. * Adding library dependency * Small changes to cmake list * Adding openmp flag back to gfortran script, needed for jenkins test * Making the init_inputfields get called for restarts too, because restart code call input_field code. * Making pdf_implicit_coefs_terms conditional in generalized grid test * Adding microphys directory to acc_to_omp script * Renaming -iters option in run_scm.py to -max_iters * Making run_scm_all.py and new driver test * Test and script improvements * Limiting iterations in jenkins test * Name change * adding ulimit * name update * jenkins script update * jenkins script update * jenkins script update * jenkins script update * jenkins script and run_scm_all.py update * jenkins script update * Turning calc_lmin_nu into calc_derrived_params, which is more general, and now calculates mixt_frac_max_mag * Small improvement for GPU * Small updates needed for host model integration * Removing accidentally added file * Small cleanup 2025-10-05 20:45:58 -05006061db38ecdeb1e2e7a5f50a1c0dfdb784e7a155Clubb driver upgrades part2 (#1257)deletemt95.F90editadvance_xm_wpxp_module.F90editstats_clubb_utilities.F90editCMakeLists.txteditsfc_varnce_module.F90editclip_explicit.F90editpdf_closure_module.F90editadvance_helper_module.F90editmixing_length.F90deleteparameters_model.F90editgrid_adaptation_module.F90editoutput_netcdf.F90editnumerical_check.F90editpdf_parameter_module.F90editadvance_windm_edsclrm_module.F90editadvance_clubb_core_module.F90editgrid_class.F90edithydromet_pdf_parameter_module.F90editmodel_flags.F90editclubb_api_module.F90editparameters_tunable.F90silhs_api_module.F90mt95.F90CMakeLists.txtoutput_2D_samples_module.F90latin_hypercube_driver_module.F9065c0ff8e7f89aa0cf15f016d0bec345de92a4b1f1759715158000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comClubb driver upgrades part2 (#1257) * Initial commit. Breaking up clubb driver into sections. This should be bfb on everything, but this hasn't been checked well yet. * Combining namelist read into case init, same stuff really * Reorganizing many things, mainly in the pursuit of sectioning off code into groups like Microphys or Radiation * Organizing clubb_driver. All cases still BFB. * Mostly cosmetic improvements * Small improvements, comments, making clubb_driver_test to ensure consistency functionality of new compartmentalized model run components * Removing accidentally added files. * Mostly breaking up structure initialization behavior, split into init_ and zero_ so that we don't have to allocate to reset. * Doing away with clubb_model_settings and parameters_module in the spirit of consolidating functionality and spiting module variables. * Missed some changes to commit, should've been included in previous commit * Splitting up funcionality of setup_parameters. Now theres one part that calculates and another checks flag values. * GPU code working, but not BFB yet * GPU all BFB with mutliple columns, except gabls3, and driver test doesnt work (pass reinitialize, fails double timestep test) * Turning off multi_column output for the new driver test * Changes needed after rebase * Name changes, comments, and threadprivate additions for parallel runs * Adding variables to openacc data statements. Without this, the code crashes when using the GPU with l_godunov_upwind_xpyp_ta=.true. * Modifying compiler configurations (mainly optimization level) in order to prepare for switching scipts and tests to cmake, specifically separating out this BIT_CHANGING commit from the rest * thlm_ed and rtm_ed caused GPU errors since those variables were added to a acc loop, but never added to the acc data statement. This change makes it so they're only calculated on the CPU, since they are only used for stats, fixing the issue without adding the GPU memory footprint. * Adding -Mstack_arrays to the nvfortran flags causes us to use more stack space, which means we need to allow processes to use more stack space (when using lots of columns, since that increases memory footprint). We do by using using 'ulimit BIGNUMBER'. * Making old compiler script work with new file structure, also making Input_fields directory and library. * Missed text_writer_lib * Undoing Input_fields directory, it has too many depencencies currently, certainly can be simplified with argument lists. * Adding library dependency * Small changes to cmake list * Adding openmp flag back to gfortran script, needed for jenkins test * Making the init_inputfields get called for restarts too, because restart code call input_field code. * Making pdf_implicit_coefs_terms conditional in generalized grid test * Adding microphys directory to acc_to_omp script * Renaming -iters option in run_scm.py to -max_iters * Making run_scm_all.py and new driver test * Test and script improvements * Limiting iterations in jenkins test * Name change * adding ulimit * name update * jenkins script update * jenkins script update * jenkins script update * jenkins script update * jenkins script and run_scm_all.py update * jenkins script update * Turning calc_lmin_nu into calc_derrived_params, which is more general, and now calculates mixt_frac_max_mag * Small improvement for GPU * Small updates needed for host model integration * Removing accidentally added file * Small cleanup 2025-10-05 20:45:58 -050065c0ff8e7f89aa0cf15f016d0bec345de92a4b1fClubb driver upgrades part2 (#1257)editsilhs_api_module.F90editoutput_2D_samples_module.F90addmt95.F90editCMakeLists.txteditlatin_hypercube_driver_module.F90src/physics/cam/clubb_intr.F90src/physics/cam/subcol_SILHS.F9003ffdce62430d42792ba7bb52c729bb5c6712fa21759719243000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comChanges needed for compatibility with clubb_driver_upgrades_part2, from PR https://github.com/larson-group/clubb/pull/1257 (#204) 2025-10-05 21:54:03 -050003ffdce62430d42792ba7bb52c729bb5c6712fa2Changes needed for compatibility with clubb_driver_upgrades_part2, from PR https://github.com/larson-group/clubb/pull/1257 (#204)editsrc/physics/cam/clubb_intr.F90editsrc/physics/cam/subcol_SILHS.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse201http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/201/199http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/199/Started by an SCM change19951174997cc51ad7841c74ab1821e139a9f39936d51174997cc51ad7841c74ab1821e139a9f39936drefs/remotes/origin/clubb_silhs_devel51174997cc51ad7841c74ab1821e139a9f39936d51174997cc51ad7841c74ab1821e139a9f39936drefs/remotes/origin/clubb_silhs_devel51174997cc51ad7841c74ab1821e139a9f39936d51174997cc51ad7841c74ab1821e139a9f39936drefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#19930945892373579cam_BFB_coarse_res_gfortran_test #199199false19911552SUCCESS1759480027861http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/199/advance_xp2_xpyp_module.F90406e74ef044da4c2383473bdffd74925641af9241759432819000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding variables to openacc data statements. Without this, the code crashes when using the GPU with l_godunov_upwind_xpyp_ta=.true. 2025-10-02 14:20:19 -0500406e74ef044da4c2383473bdffd74925641af924Adding variables to openacc data statements. Without this, the code crashes when using the GPU with l_godunov_upwind_xpyp_ta=.true.editadvance_xp2_xpyp_module.F90advance_clubb_core_module.F90895048c969404beccab649c27f368c904175a9b41759438529000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduthlm_ed and rtm_ed caused GPU errors since those variables were added to a acc loop, but never added to the acc data statement. This change makes it so they're only calculated on the CPU, since they are only used for stats, fixing the issue without adding the GPU memory footprint. 2025-10-02 15:55:29 -0500895048c969404beccab649c27f368c904175a9b4thlm_ed and rtm_ed caused GPU errors since those variables were added to a acc loop, but never added to the acc data statement. This change makes it so they're only calculated on the CPU, since they are only used for stats, fixing the issue without adding the GPU memory footprint.editadvance_clubb_core_module.F90jenkins_tests/cam_clubb_generalized_grid_scam_test/Jenkinsfilerun_scripts/run_generalized_grid_scam_test.bashsrc/physics/cam/subcol_SILHS.F90src/physics/cam/clubb_intr.F9051174997cc51ad7841c74ab1821e139a9f39936d1759439203000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comClubb intr revert (#203) * Revert "I am officially setting l_ascending_grid to false in CAM-CLUBB, meaning" This reverts commit 1644e80604055cf7a4910e9ace4213ac15f38fbf. * Revert "Cam clubb silhs rev dir (#196)" This reverts commit 5afa946afdb36ccab6009d735fd59a243a881f43. This reverts a BIT_CHANGING commit, making this also BIT_CHANGING, see https://github.com/larson-group/cam/commit/1644e80604055cf7a4910e9ace4213ac15f38fbf 2025-10-02 16:06:43 -050051174997cc51ad7841c74ab1821e139a9f39936dClubb intr revert (#203)deleterun_scripts/run_generalized_grid_scam_test.basheditsrc/physics/cam/clubb_intr.F90editsrc/physics/cam/subcol_SILHS.F90deletejenkins_tests/cam_clubb_generalized_grid_scam_test/Jenkinsfilegithttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse200http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/200/198http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/198/Started by an SCM change19832e7d4adf103e76b7fe05242a69588eb5a6fa29632e7d4adf103e76b7fe05242a69588eb5a6fa296refs/remotes/origin/clubb_silhs_devel32e7d4adf103e76b7fe05242a69588eb5a6fa29632e7d4adf103e76b7fe05242a69588eb5a6fa296refs/remotes/origin/clubb_silhs_devel32e7d4adf103e76b7fe05242a69588eb5a6fa29632e7d4adf103e76b7fe05242a69588eb5a6fa296refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#19825175342373579cam_BFB_coarse_res_gfortran_test #198198false19811311SUCCESS1759393627052http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/198/latin_hypercube_driver_module.F9050f5a9aa2d2a1e4894e9d0aa40f653db463beb151759358185000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking the l_random_k_lh_start set the random generator seed before generating a random. This should fix the generalized grid test, which failed for the only flag set that turned on l_random_k_lh_start. Before, the test passed because we used the same random seed for all timesteps, preventing differences in the random call. But now we use a different seed each timestep, causing differences. To ensure reproducibility, we use the seed each timestep to generate rand_pool, which is an effective solution, but we need to do that for the rand_integer_in_range call in the l_random_k_lh_start code for the same reason. Since this does change the random that comes out, this is BIT_CHANGING, but only for runs using both SILHS and l_random_k_lh_start=.true. 2025-10-01 17:36:25 -050050f5a9aa2d2a1e4894e9d0aa40f653db463beb15Making the l_random_k_lh_start set the random generator seed before generating a random. This should fix the generalized grid test, which failed for the only flag set that turned on l_random_k_lh_start. Before, the test passed because we used the same random seed for all timesteps, preventing differences in the random call. But now we use a different seed each timestep, causing differences. To ensure reproducibility, we use the seed each timestep to generate rand_pool, which is an effective solution, but we need to do that for the rand_integer_in_range call in the l_random_k_lh_start code for the same reason. Since this does change the random that comes out, this is BIT_CHANGING, but only for runs using both SILHS and l_random_k_lh_start=.true.editlatin_hypercube_driver_module.F90githttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse199http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/199/197http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/197/Started by an SCM change1971be51d053905fea48cebe2371a516e113a4963121be51d053905fea48cebe2371a516e113a496312refs/remotes/origin/clubb_silhs_devel1be51d053905fea48cebe2371a516e113a4963121be51d053905fea48cebe2371a516e113a496312refs/remotes/origin/clubb_silhs_devel1be51d053905fea48cebe2371a516e113a4963121be51d053905fea48cebe2371a516e113a496312refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#19727276642373579cam_BFB_coarse_res_gfortran_test #197197false19711225SUCCESS1759307226957http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/197/latin_hypercube_driver_module.F90c65ac4caa14049aac533a666cae096b427ea43881759289999000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comSILHS reproducibility (#1258) * Making the SILHS random number generator on GPUs more reproducible by relying on the lh_seed input every call, which is the same as how the CPU randoms work. Also ensuring that the seed changes each timestep, just to prevent generating the same randoms on different timesteps. Since this does change the randoms, it is BIT_CHANGING for silhs enabled runs. * Improving comment 2025-09-30 22:39:59 -0500c65ac4caa14049aac533a666cae096b427ea4388SILHS reproducibility (#1258)editlatin_hypercube_driver_module.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse198http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/198/196http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/196/Started by an SCM change196aa62f2a748b177007297c0f42dc08bc7539f7cc0aa62f2a748b177007297c0f42dc08bc7539f7cc0refs/remotes/origin/clubb_silhs_develaa62f2a748b177007297c0f42dc08bc7539f7cc0aa62f2a748b177007297c0f42dc08bc7539f7cc0refs/remotes/origin/clubb_silhs_develaa62f2a748b177007297c0f42dc08bc7539f7cc0aa62f2a748b177007297c0f42dc08bc7539f7cc0refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#19625515812373579cam_BFB_coarse_res_gfortran_test #196196false19611083SUCCESS1759048028339http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/196/constants_clubb.F9006d501ccaa052143c7142816c8a30b354593ff061758974591000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comChange tolerance in way that affects only single precision builds (#1256) This fixes a problem with precip_frac exceeding a bound in single precision. The code change is BIT_CHANGING for single precision, but V. Larson wouldn't expect it to be bit changing for double precision, although V. Larson hasn't checked. 2025-09-27 07:03:11 -050006d501ccaa052143c7142816c8a30b354593ff06Change tolerance in way that affects only single precision builds (#1256)editconstants_clubb.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse197http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/197/195http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/195/Started by an SCM change195e94d063b32865a628aea8b86ae7a394883932653e94d063b32865a628aea8b86ae7a394883932653refs/remotes/origin/clubb_silhs_devele94d063b32865a628aea8b86ae7a394883932653e94d063b32865a628aea8b86ae7a394883932653refs/remotes/origin/clubb_silhs_devele94d063b32865a628aea8b86ae7a394883932653e94d063b32865a628aea8b86ae7a394883932653refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#19525847042373579cam_BFB_coarse_res_gfortran_test #195195false19510993SUCCESS1758961628640http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/195/grid_adaptation_module.F904660a606dd89b3b53da4c162f66d6571907d74ee1758908234000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRemove module vars from grid_adaptation_module (#1255) * removed fixed_min_gr_dens module variables * remove gr_dens_old_global variables * remove counter and cumulative module variables 2025-09-26 19:37:14 +02004660a606dd89b3b53da4c162f66d6571907d74eeRemove module vars from grid_adaptation_module (#1255)editgrid_adaptation_module.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse196http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/196/194http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/194/Started by an SCM change194e6a8375659be8bb0f6850a8d0170d5834dc51f20e6a8375659be8bb0f6850a8d0170d5834dc51f20refs/remotes/origin/clubb_silhs_devele6a8375659be8bb0f6850a8d0170d5834dc51f20e6a8375659be8bb0f6850a8d0170d5834dc51f20refs/remotes/origin/clubb_silhs_devele6a8375659be8bb0f6850a8d0170d5834dc51f20e6a8375659be8bb0f6850a8d0170d5834dc51f20refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#19428838592373579cam_BFB_coarse_res_gfortran_test #194194false19410898SUCCESS1758875228674http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/194/precipitation_fraction.F90f68b263becf1bcfb48213729fd4ee43dac9d67801758846454000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comPrecip frac fix (#1254) * Using epsilon() to help check precip_frac against precip_frac_tol * Using clubb version of eps for checks Including BIT_CHANGING:06288ac66a3a26013c135d8aef776cc99202f64f because a ifort compiler option changed, and that changes the results. Otherwise it was all BFB. 2025-09-25 19:27:34 -0500f68b263becf1bcfb48213729fd4ee43dac9d6780Precip frac fix (#1254)editprecipitation_fraction.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse195http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/195/193http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/193/Started by an SCM change19331a990b91e4bb1507048326cb9b66eaa5de409a431a990b91e4bb1507048326cb9b66eaa5de409a4refs/remotes/origin/clubb_silhs_devel31a990b91e4bb1507048326cb9b66eaa5de409a431a990b91e4bb1507048326cb9b66eaa5de409a4refs/remotes/origin/clubb_silhs_devel31a990b91e4bb1507048326cb9b66eaa5de409a431a990b91e4bb1507048326cb9b66eaa5de409a4refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#19325483442373579cam_BFB_coarse_res_gfortran_test #193193false19310811SUCCESS1758788828990http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/193/CMakeLists.txt98d8c4814d6669dae533da157c1da701ec53e92c1758753854000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comThe cmake update (#1253) * Initial cmake additions * Reworking dependency handling and toolchains. * Improvements, intel, gfortran, and nvfortran work with and without debugging, and nvfortran works with openacc or openmp too. * Small changes to toolchains * Little various improvements * Making ctests work * Reworking ctests, we have decided to make the ctests run a small number of quick cases/tests just to facilitate development. * Introducing ctests. Big script updates - run_scm.py and compile.py are new * Introducing run_scm.py to replace run_scm.bash and CLUBBStandardsCheck.py to replace CLUBBStandardsCheck.pl. The new CLUBBStandardsCheck.py is much faster and should be even more capable at detecting issues than the perl version, it also has improved readability. The new run_scm.py is way more capable and managable than the bash version, it's used now in the new ctests. Also, the compile script has improved functionality, and ctests can be invoked when adding -run_tests to the compile.py call. Also the whole system supports maintaining builds with multiple compilers now, e.g. using nvfortran then ifx will not overwrite the nvfortran version now, and the new run_scm.py is smart enough to choose the right one depending on the compiler loaded. * Small changes and adding a -legacy flag to run_scm.py to run the bin/clubb_standalone version from the excruciatingly old compilation system. * Small cleanup and Cmake file simplifications - more to come * Mostly cleanup. Moving stuff around to put it in better places, renaming, removing unnecessary parts, etc. * More cleanup and adding comments * Hopefully final cleanup * Small bug fix * Small changes and new jenkins test * Small fix * Now that our source checking scripts return error codes, we have to ignore them in this make file. This doesn't change their output at all, but causes the error code to be ignored * Accidentally removed output dir * Small fix to jenkins test * Small fix to jenkins test * Small fix to jenkins test * Small fix to jenkins test * Compile script improvements and new run_thread_test.py to replace bash version. * Changing default ENABLE_OMP to default off, and changing the default executable used by the new python version of the thread test to use the cmake install by default. * Making more general cmake test to test various compile options. * Making ctests output better in compile.py and making new jenkins test a little fancier. * Small fix to jenkins test * Small fix to jenkins test * Small fix to jenkins test * Small fix to jenkins test * Reverting some of the fancyness of new test larson-group/clubb#1117 2025-09-24 17:44:14 -050098d8c4814d6669dae533da157c1da701ec53e92cThe cmake update (#1253)addCMakeLists.txtCMakeLists.txt3c612a8f18f66a849f81a234da6df214cd5667201758753854000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comThe cmake update (#1253) * Initial cmake additions * Reworking dependency handling and toolchains. * Improvements, intel, gfortran, and nvfortran work with and without debugging, and nvfortran works with openacc or openmp too. * Small changes to toolchains * Little various improvements * Making ctests work * Reworking ctests, we have decided to make the ctests run a small number of quick cases/tests just to facilitate development. * Introducing ctests. Big script updates - run_scm.py and compile.py are new * Introducing run_scm.py to replace run_scm.bash and CLUBBStandardsCheck.py to replace CLUBBStandardsCheck.pl. The new CLUBBStandardsCheck.py is much faster and should be even more capable at detecting issues than the perl version, it also has improved readability. The new run_scm.py is way more capable and managable than the bash version, it's used now in the new ctests. Also, the compile script has improved functionality, and ctests can be invoked when adding -run_tests to the compile.py call. Also the whole system supports maintaining builds with multiple compilers now, e.g. using nvfortran then ifx will not overwrite the nvfortran version now, and the new run_scm.py is smart enough to choose the right one depending on the compiler loaded. * Small changes and adding a -legacy flag to run_scm.py to run the bin/clubb_standalone version from the excruciatingly old compilation system. * Small cleanup and Cmake file simplifications - more to come * Mostly cleanup. Moving stuff around to put it in better places, renaming, removing unnecessary parts, etc. * More cleanup and adding comments * Hopefully final cleanup * Small bug fix * Small changes and new jenkins test * Small fix * Now that our source checking scripts return error codes, we have to ignore them in this make file. This doesn't change their output at all, but causes the error code to be ignored * Accidentally removed output dir * Small fix to jenkins test * Small fix to jenkins test * Small fix to jenkins test * Small fix to jenkins test * Compile script improvements and new run_thread_test.py to replace bash version. * Changing default ENABLE_OMP to default off, and changing the default executable used by the new python version of the thread test to use the cmake install by default. * Making more general cmake test to test various compile options. * Making ctests output better in compile.py and making new jenkins test a little fancier. * Small fix to jenkins test * Small fix to jenkins test * Small fix to jenkins test * Small fix to jenkins test * Reverting some of the fancyness of new test larson-group/clubb#1117 2025-09-24 17:44:14 -05003c612a8f18f66a849f81a234da6df214cd566720The cmake update (#1253)addCMakeLists.txtgithttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse194http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/194/192http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/192/Started by user Gunther HueblerhueblerGunther Huebler1923435d5ba58c9bd61872a20bdde6ee026743287083435d5ba58c9bd61872a20bdde6ee02674328708refs/remotes/origin/clubb_silhs_devel3435d5ba58c9bd61872a20bdde6ee026743287083435d5ba58c9bd61872a20bdde6ee02674328708refs/remotes/origin/clubb_silhs_devel3435d5ba58c9bd61872a20bdde6ee026743287083435d5ba58c9bd61872a20bdde6ee02674328708refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#19214335942373579cam_BFB_coarse_res_gfortran_test #192192false19210741SUCCESS1758740295691http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/192/http://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse193http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/193/191http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/191/Started by an SCM change1913435d5ba58c9bd61872a20bdde6ee026743287083435d5ba58c9bd61872a20bdde6ee02674328708refs/remotes/origin/clubb_silhs_devel3435d5ba58c9bd61872a20bdde6ee026743287083435d5ba58c9bd61872a20bdde6ee02674328708refs/remotes/origin/clubb_silhs_devel3435d5ba58c9bd61872a20bdde6ee026743287083435d5ba58c9bd61872a20bdde6ee02674328708refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#191377640432373579cam_BFB_coarse_res_gfortran_test #191191false19110698ABORTED1758702428651http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/191/advance_clubb_core_module.F90stats_variables.F90stats_zt_module.F90123a31f755ebf9511f169f5fe1d6312c3b1cdc7a1758642876000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdding expldiff budget terms for thlm and rtm (#1252) * Adding expldiff budget terms for thlm and rtm * Removing unintentional line. * Fixing initialization-to-zero problem * Adding some comments. * Adding thlm_ed and rtm_ed to standard_stats.in * Adding thlm_ed and rtm_ed to all_stats.in * Fixing two bugs. Budget balance test passes and results are b4b. This commit is BIT_CHANGING, but only because it adds additional stats fields to the _zt.nc files. Answers would only change if l_do_expldiff_rtm_thlm=T. 2025-09-23 09:54:36 -0600123a31f755ebf9511f169f5fe1d6312c3b1cdc7aAdding expldiff budget terms for thlm and rtm (#1252)editadvance_clubb_core_module.F90editstats_variables.F90editstats_zt_module.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse192http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/192/190http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/190/Started by user Brian GriffingriffinbBrian Griffin1901644e80604055cf7a4910e9ace4213ac15f38fbf1644e80604055cf7a4910e9ace4213ac15f38fbfrefs/remotes/origin/clubb_silhs_devel1644e80604055cf7a4910e9ace4213ac15f38fbf1644e80604055cf7a4910e9ace4213ac15f38fbfrefs/remotes/origin/clubb_silhs_devel1644e80604055cf7a4910e9ace4213ac15f38fbf1644e80604055cf7a4910e9ace4213ac15f38fbfrefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#19014562492373579cam_BFB_coarse_res_gfortran_test #190190false19010372SUCCESS1748038025879http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/190/src/physics/cam/clubb_intr.F901644e80604055cf7a4910e9ace4213ac15f38fbf1748037675000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am officially setting l_ascending_grid to false in CAM-CLUBB, meaning that CLUBB's grid is now officially in descending mode in CAM, matching CAM's grid direction. With -O0 optimization and with CLUBB's l_test_grid_generalization turned on, results are a bit-for-bit match to the previous revision. However, normally CAM-CLUBB doesn't run with these options, which means these results should be BIT_CHANGING. This is probably my final commit to our battery of repositories. Thank you for 23 years, and God bless you! 2025-05-23 17:01:15 -05001644e80604055cf7a4910e9ace4213ac15f38fbfI am officially setting l_ascending_grid to false in CAM-CLUBB, meaningeditsrc/physics/cam/clubb_intr.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2false191http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/191/189http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/189/Started by an SCM change189294f7921fa437e0b541244f89b96a679d039d4ba294f7921fa437e0b541244f89b96a679d039d4barefs/remotes/origin/clubb_silhs_devel294f7921fa437e0b541244f89b96a679d039d4ba294f7921fa437e0b541244f89b96a679d039d4barefs/remotes/origin/clubb_silhs_devel294f7921fa437e0b541244f89b96a679d039d4ba294f7921fa437e0b541244f89b96a679d039d4barefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#18919704592373579cam_BFB_coarse_res_gfortran_test #189189false18910326SUCCESS1747988827777http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/189/output_netcdf.F90177ee2016e7e4584f9c7c1d420ab3e1e013969601747955296000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comfix precision error of reals 2025-05-22 18:08:16 -0500177ee2016e7e4584f9c7c1d420ab3e1e01396960fix precision error of realseditoutput_netcdf.F90grid_adaptation_module.F90grid_adaptation.F90remapping.F90remapping_module.F900ae10ffa778fe9951dfd3de81a1ffcd38b3e5bdd1747962119000http://carson.math.uwm.edu/jenkins/user/0-freundlich-adenin0-freundlich-adenin0-freundlich-adenin@icloud.comrename grid_adaptation and remapping modules 2025-05-22 20:01:59 -05000ae10ffa778fe9951dfd3de81a1ffcd38b3e5bddrename grid_adaptation and remapping modulesaddgrid_adaptation_module.F90addremapping_module.F90deleteremapping.F90deletegrid_adaptation.F90grid_adaptation_module.F903481c17db470604c208604778051bb11dfa7f9431747963509000http://carson.math.uwm.edu/jenkins/user/0-freundlich-adenin0-freundlich-adenin0-freundlich-adenin@icloud.comadd fix for grid generalization 2025-05-22 20:25:09 -05003481c17db470604c208604778051bb11dfa7f943add fix for grid generalizationeditgrid_adaptation_module.F90githttp://carson.math.uwm.edu/jenkins/user/0-freundlich-adenin0-freundlich-adeninhttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse190http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/190/188http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/188/Started by user Brian GriffingriffinbBrian Griffin188e5ec9afb7da53442bdee3952105faf142b9c3007e5ec9afb7da53442bdee3952105faf142b9c3007refs/remotes/origin/clubb_silhs_devele5ec9afb7da53442bdee3952105faf142b9c3007e5ec9afb7da53442bdee3952105faf142b9c3007refs/remotes/origin/clubb_silhs_devele5ec9afb7da53442bdee3952105faf142b9c3007e5ec9afb7da53442bdee3952105faf142b9c3007refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#18813449002373579cam_BFB_coarse_res_gfortran_test #188188false18810278SUCCESS1747962263452http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/188/src/physics/cam/clubb_intr.F90f3e4feee74e7ead32bdc9e6373c1217b7dbb5e3c1747956100000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI've got the magic fix I know if I can fix it once, I can fix twice I fix the baddest bugs ... Changing the pbuf_get_field calls to only go from 1 to ncol in the column dimension for the variables that are newly being passed directly into advance_clubb_core_api thanks to our removal of the _in variables (e.g. wp2_in) in a recent commit. This solves the problem of trying to shove a (pverp-top_lev+1 x pcols) size box into the hole for a (pverp-top_lev+1 x ncol) size box. G-UNIT!!! 2025-05-22 18:21:40 -0500f3e4feee74e7ead32bdc9e6373c1217b7dbb5e3cI've got the magic fixeditsrc/physics/cam/clubb_intr.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2false189http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/189/187http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/187/Started by an SCM change187151044a3d1ce02bfa4b602cd3f491b2878307dfa151044a3d1ce02bfa4b602cd3f491b2878307dfarefs/remotes/origin/clubb_silhs_devel151044a3d1ce02bfa4b602cd3f491b2878307dfa151044a3d1ce02bfa4b602cd3f491b2878307dfarefs/remotes/origin/clubb_silhs_devel151044a3d1ce02bfa4b602cd3f491b2878307dfa151044a3d1ce02bfa4b602cd3f491b2878307dfarefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#18719904302373579cam_BFB_coarse_res_gfortran_test #187187false18710197SUCCESS1747902429102http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/187/model_flags.F90remapping.F90constants_clubb.F90output_netcdf.F90stats_zm_module.F90interpolation.F90stats_variables.F90stats_clubb_utilities.F90grid_adaptation.F90b558b034dae7a6c45872fe3f91ac6e163472eaaa1747866722000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comMerge grid adaptation implementation (#1249) * add tunable parameter interp_from_dycore_grid_method * add dycore interpolation to atex case with conservative remapping by ullrich * remove new gpu commands * add acc annotation for gpu * remove acc annotation again * add acc annotation for parallel loop * add acc annotations for parallel loop execution * change remapping subroutine to take number of levels and levels as input instead of whole grid object * add more general functions to interpolate * add and refactor functions for remapping values given on zm levels * fix compiler errors and refactoring to stay under 100 chars per line * remove TODOs and used new interpolating function in interpolate_forcings * add functions for adaptive grid generation and grid density function normalization * add conservative ullrich remapping to cases with forcing time dependent inputs * add grid adaptation and flag * clean up and add warning for case when remapping from dycore flag cannot be used * some refactoring * add logical flag for dycore and renamed flags for dycore and grid adaptation * remove ifdefs * refactoring * add units * changed Lscale to inverse * add write to file for grid adaptation (still WIP) * clean up * change parameter for grid adaptation and add file and plot script for grid adaptation * add script for animation * add e3sm dycore grid * refactoring for efficiency * small fix for grid adapt plot script * add new grid adaptation method with prescribed minimum density profile * fix call to setup_grid * add gabls2 case * add refinement criterion and adaptation trigger * small fix and add minimum grid density profile to animation * add grid density to pyplots * add general refinement criteria for astex and gabls2 case (and arm) * update create_evenly_grid script * unfinished save * WIP: save progress * save working configuration * save working config without Lscale * save working config wo the use of Lscale * change call to map1_ppm to use correct iv parameter and order 4 * save code for results in thesis * add code for results * refactor remapping module for grid adaptation * add list of functions/subroutines to remapping module * adjust use statements * add model files for arm, astex and gabls2 * refactor grid_adaptation module * refactor and adjust tim stopping in clubb_driver * clean up * clean up * add grids * add scripts * add changes made to pyplotgen to generate plots for paper * add configurable model flags file that was used to obtain results * clean up and save tunable parameters file * fix error * fix error * add grid adapt output for debug level 2 * change dycore grid * add plot generation script for paper plots * add small changes * add normalization explaination plot to paper plots script * fix plot * clean up for stats output * add comment * fix use of clubb_at_least_debug_api * small deallocation fix * fix merge problems * revert changes made to test grid adaptation * revert tunable_parameters for Lscale * revert changes made to create plots for grid adaptation * add new line * add new line * revert changes * revert changes made to generate grid adaptation plots 2025-05-21 17:32:02 -0500b558b034dae7a6c45872fe3f91ac6e163472eaaaMerge grid adaptation implementation (#1249)editconstants_clubb.F90editstats_zm_module.F90editinterpolation.F90editmodel_flags.F90editoutput_netcdf.F90addremapping.F90editstats_variables.F90editgrid_adaptation.F90editstats_clubb_utilities.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse188http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/188/186http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/186/Started by an SCM change186154fe0431dc356aebf5c39550a0b8c8a9b05e597154fe0431dc356aebf5c39550a0b8c8a9b05e597refs/remotes/origin/clubb_silhs_devel154fe0431dc356aebf5c39550a0b8c8a9b05e597154fe0431dc356aebf5c39550a0b8c8a9b05e597refs/remotes/origin/clubb_silhs_devel154fe0431dc356aebf5c39550a0b8c8a9b05e597154fe0431dc356aebf5c39550a0b8c8a9b05e597refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#18614878032373579cam_BFB_coarse_res_gfortran_test #186186false18610104SUCCESS1747816029709http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/186/advance_xm_wpxp_module.F90a1ccb74c23ed0ba31458eab3cd2101a82c39dcf31747720486000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduzm and zt were mixed up in the error prints argument list. 2025-05-20 00:54:46 -0500a1ccb74c23ed0ba31458eab3cd2101a82c39dcf3zm and zt were mixed up in the error prints argument list.editadvance_xm_wpxp_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2false187http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/187/185http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/185/Started by user Gunther HueblerhueblerGunther Huebler1850a7b056e7e3fb54e702de4e1ea97494a9fff85a90a7b056e7e3fb54e702de4e1ea97494a9fff85a9refs/remotes/origin/clubb_silhs_devel0a7b056e7e3fb54e702de4e1ea97494a9fff85a90a7b056e7e3fb54e702de4e1ea97494a9fff85a9refs/remotes/origin/clubb_silhs_devel0a7b056e7e3fb54e702de4e1ea97494a9fff85a90a7b056e7e3fb54e702de4e1ea97494a9fff85a9refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#18515268262373579cam_BFB_coarse_res_gfortran_test #185185false18510018SUCCESS1747692442452http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/185/src/physics/cam/clubb_intr.F900a7b056e7e3fb54e702de4e1ea97494a9fff85a91747689630000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduBug fix to dimensions that was causing crashes. This is technically BIT_CHANGING. 2025-05-19 16:20:30 -05000a7b056e7e3fb54e702de4e1ea97494a9fff85a9Bug fix to dimensions that was causing crashes. This is technically BIT_CHANGING.editsrc/physics/cam/clubb_intr.F90githttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse186http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/186/184http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/184/Started by an SCM change1845afa946afdb36ccab6009d735fd59a243a881f435afa946afdb36ccab6009d735fd59a243a881f43refs/remotes/origin/clubb_silhs_devel5afa946afdb36ccab6009d735fd59a243a881f435afa946afdb36ccab6009d735fd59a243a881f43refs/remotes/origin/clubb_silhs_devel5afa946afdb36ccab6009d735fd59a243a881f435afa946afdb36ccab6009d735fd59a243a881f43refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#18415237242373579cam_BFB_coarse_res_gfortran_test #184184false1849983SUCCESS1747470428360http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/184/jenkins_tests/cam_clubb_generalized_grid_scam_test/Jenkinsfilesrc/physics/cam/subcol_SILHS.F90run_scripts/run_generalized_grid_scam_test.bashsrc/physics/cam/clubb_intr.F905afa946afdb36ccab6009d735fd59a243a881f431747411956000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comCam clubb silhs rev dir (#196) * Making updates to clubb_intr to reduce the vertical array sizes of many CLUBB variables that are stored in pbuf. * Updated clubb_intr.F90 and subcol_SILHS.F90 with some modifications for generalized gridding. * Fixed compilation bugs in clubb_intr.F90 * More modifications for generalized gridding * Finished generalizing CLUBB and SILHS in CAM. A CAM-CLUBB run comparing ascending vs. descending grids on -O0 optimization now matches bit-for-bit for CLUBB and CLUBB-SILHS runs. * Adding a new file to run a grid generalization test in CAM. * Making run_generalized_grid_scam_test executable. * Updated run_generalized_grid_scam_test.bash for further testing. I also need to note that I love scam testing. It makes me feel like I live in Nigeria! * Added more to the run_generalized_grid_scam_test.bash script. * Added more to the generalized grid test. * Adding a Jenkinsfile for the CAM-CLUBB generalized grid scam test. 2025-05-16 11:12:36 -05005afa946afdb36ccab6009d735fd59a243a881f43Cam clubb silhs rev dir (#196)addjenkins_tests/cam_clubb_generalized_grid_scam_test/Jenkinsfileeditsrc/physics/cam/subcol_SILHS.F90addrun_scripts/run_generalized_grid_scam_test.basheditsrc/physics/cam/clubb_intr.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse185http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/185/183http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/183/Started by an SCM change1834ac72071361c66baf68ee070e095e93d2204afe44ac72071361c66baf68ee070e095e93d2204afe4refs/remotes/origin/clubb_silhs_devel4ac72071361c66baf68ee070e095e93d2204afe44ac72071361c66baf68ee070e095e93d2204afe4refs/remotes/origin/clubb_silhs_devel4ac72071361c66baf68ee070e095e93d2204afe44ac72071361c66baf68ee070e095e93d2204afe4refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#18314148552373579cam_BFB_coarse_res_gfortran_test #183183false1839907SUCCESS1747297630042http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/183/src/physics/cam/clubb_intr.F900d81cc17b85326cf37574349b2a8da9d24f086071747236403000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduOur little problem of having CLUBB's zm stats not match at boundaries when compared between ascending and descending grids led me to discover this bug in CAM-CLUBB stats zm output. 2025-05-14 10:26:43 -05000d81cc17b85326cf37574349b2a8da9d24f08607Our little problem of having CLUBB's zm stats not match at boundarieseditsrc/physics/cam/clubb_intr.F90jenkins_tests/cam_clubb_error_handling_test/Jenkinsfilejenkins_tests/cam_clubb_error_handling_test/cam_test_fatal_error_handling.bash4ac72071361c66baf68ee070e095e93d2204afe41747244912000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comCam clubb error handling jenkins test (#195) * Fixed output for CAM CLUBB error handling Jenkins test CLUBB ticket larson-group/clubb#975 * Eliminated the unnecessary command outputs from sh script in Jenkins * Added more detailed output 2025-05-14 12:48:32 -05004ac72071361c66baf68ee070e095e93d2204afe4Cam clubb error handling jenkins test (#195)editjenkins_tests/cam_clubb_error_handling_test/Jenkinsfileeditjenkins_tests/cam_clubb_error_handling_test/cam_test_fatal_error_handling.bashgithttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse184http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/184/182http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/182/Started by an SCM change182ef17c4e116ce9f8b4c56caee26c37353bd20eaf9ef17c4e116ce9f8b4c56caee26c37353bd20eaf9refs/remotes/origin/clubb_silhs_develef17c4e116ce9f8b4c56caee26c37353bd20eaf9ef17c4e116ce9f8b4c56caee26c37353bd20eaf9refs/remotes/origin/clubb_silhs_develef17c4e116ce9f8b4c56caee26c37353bd20eaf9ef17c4e116ce9f8b4c56caee26c37353bd20eaf9refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#18217892882373579cam_BFB_coarse_res_gfortran_test #182182false1829805SUCCESS1747211230881http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/182/src/physics/cam/clubb_intr.F9005da6cae754fce3ac98db08f8f5bd7595c5fc57a1747156038000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdate clubb_intr.F90 Replaced erroneously committed debug output with more evocative message. 2025-05-13 12:07:18 -050005da6cae754fce3ac98db08f8f5bd7595c5fc57aUpdate clubb_intr.F90editsrc/physics/cam/clubb_intr.F90calendar.F90clubb_api_module.F90advance_xm_wpxp_module.F90clip_explicit.F90stats_type_utilities.F90diagnose_correlations_module.F90grid_class.F90setup_clubb_pdf_params.F90advance_windm_edsclrm_module.F90mono_flux_limiter.F90mixing_length.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90output_grads.F90error_code.F90pdf_closure_module.F90matrix_solver_wrapper.F90corr_varnce_module.F90precipitation_fraction.F90model_flags.F90numerical_check.F90pos_definite_module.F90output_netcdf.F90hydromet_pdf_parameter_module.F90pdf_parameter_module.F90sponge_layer_damping.F90advance_clubb_core_module.F90lapack_wrap.F90fill_holes.F90interpolation.F90stats_clubb_utilities.F90grid_adaptation.F90sfc_varnce_module.F90matrix_operations.F9049db55baddc842d93e891cf0e71e83357b25fa741747158959000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRemoved simple wrappers from clubb_api_module (#1245) * Removed simple wrappers from clubb_api_module CLUBB ticket #1223 Removed wrappers and renamed procedures in original modules: - cleanup_clubb_core_api - compute_current_date_api - set_clubb_debug_level_api - clubb_at_least_debug_level_api - lin_interpolate_on_grid_api - pack_pdf_params_api - unpack_pdf_params_api - init_precip_fracs_api - init_pdf_implicit_coefs_terms_api - stats_end_timestep_api - print_clubb_config_flags_api - initialize_tau_sponge_damp_api - finalize_tau_sponge_damp_api 2025-05-13 12:55:59 -050049db55baddc842d93e891cf0e71e83357b25fa74Removed simple wrappers from clubb_api_module (#1245)editpos_definite_module.F90editclubb_api_module.F90editgrid_adaptation.F90editsfc_varnce_module.F90editnumerical_check.F90editoutput_netcdf.F90editadvance_windm_edsclrm_module.F90edithydromet_pdf_parameter_module.F90editoutput_grads.F90editsetup_clubb_pdf_params.F90editcalendar.F90editcorr_varnce_module.F90editfill_holes.F90editsponge_layer_damping.F90editmono_flux_limiter.F90editstats_type_utilities.F90editpdf_closure_module.F90editmatrix_operations.F90editgrid_class.F90editmixing_length.F90editprecipitation_fraction.F90editadvance_xp2_xpyp_module.F90editpdf_parameter_module.F90editinterpolation.F90editadvance_wp2_wp3_module.F90editerror_code.F90editmodel_flags.F90editadvance_clubb_core_module.F90editadvance_xm_wpxp_module.F90editdiagnose_correlations_module.F90editclip_explicit.F90editmatrix_solver_wrapper.F90editstats_clubb_utilities.F90editlapack_wrap.F90latin_hypercube_driver_module.F90silhs_importance_sample_module.F90c7ab3b99994f99221fae7026adb974f302dc13931747158959000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRemoved simple wrappers from clubb_api_module (#1245) * Removed simple wrappers from clubb_api_module CLUBB ticket #1223 Removed wrappers and renamed procedures in original modules: - cleanup_clubb_core_api - compute_current_date_api - set_clubb_debug_level_api - clubb_at_least_debug_level_api - lin_interpolate_on_grid_api - pack_pdf_params_api - unpack_pdf_params_api - init_precip_fracs_api - init_pdf_implicit_coefs_terms_api - stats_end_timestep_api - print_clubb_config_flags_api - initialize_tau_sponge_damp_api - finalize_tau_sponge_damp_api 2025-05-13 12:55:59 -0500c7ab3b99994f99221fae7026adb974f302dc1393Removed simple wrappers from clubb_api_module (#1245)editlatin_hypercube_driver_module.F90editsilhs_importance_sample_module.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse183http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/183/181http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/181/Started by an SCM change181ab8fae7439ce66431e0d473ed3ba29ef0d35d424ab8fae7439ce66431e0d473ed3ba29ef0d35d424refs/remotes/origin/clubb_silhs_develab8fae7439ce66431e0d473ed3ba29ef0d35d424ab8fae7439ce66431e0d473ed3ba29ef0d35d424refs/remotes/origin/clubb_silhs_develab8fae7439ce66431e0d473ed3ba29ef0d35d424ab8fae7439ce66431e0d473ed3ba29ef0d35d424refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#18117982052373579cam_BFB_coarse_res_gfortran_test #181181false1819714SUCCESS1747124826755http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/181/src/physics/cam/subcol_SILHS.F90ab8fae7439ce66431e0d473ed3ba29ef0d35d4241747065263000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduUsing a CLUBB function to do a linear interpolation. It's possible that this is BIT_CHANGING to round-off level. 2025-05-12 10:54:23 -0500ab8fae7439ce66431e0d473ed3ba29ef0d35d424Using a CLUBB function to do a linear interpolation. It's possible thateditsrc/physics/cam/subcol_SILHS.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2false182http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/182/180http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/180/Started by an SCM change180e62129e81e7780b5ed522f4763ace6452a4040cee62129e81e7780b5ed522f4763ace6452a4040cerefs/remotes/origin/clubb_silhs_devele62129e81e7780b5ed522f4763ace6452a4040cee62129e81e7780b5ed522f4763ace6452a4040cerefs/remotes/origin/clubb_silhs_devele62129e81e7780b5ed522f4763ace6452a4040cee62129e81e7780b5ed522f4763ace6452a4040cerefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#18024518932373579cam_BFB_coarse_res_gfortran_test #180180false1809672SUCCESS1746865630080http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/180/jenkins_tests/cam_clubb_error_handling_test/Jenkinsfilejenkins_tests/cam_clubb_error_handling_test/cam_test_fatal_error_handling.bash3c8451971af21fc8aac0c07f97a7b0babc2752d51746812355000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comCam clubb error handling jenkins test (#194) Wrote Jenkinsfile and bash script similar to CLUBB error handling test 2025-05-09 12:39:15 -05003c8451971af21fc8aac0c07f97a7b0babc2752d5Cam clubb error handling jenkins test (#194)editjenkins_tests/cam_clubb_error_handling_test/cam_test_fatal_error_handling.basheditjenkins_tests/cam_clubb_error_handling_test/Jenkinsfilelapack_wrap.F90e36dc57a454f0700084bf2b81de84ef6f10dbcb41746812441000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comFixed and equalized NaN checks in lapack_wrap (#1246) See CAM pull request larson-group/CAM#188 Added debug_level_at_least(0) checks where missing and changed debug_level(1) to 0 in lapack_band_solve, so the new CAM CLUBB error handling test can do what it's supposed to do. 2025-05-09 12:40:41 -0500e36dc57a454f0700084bf2b81de84ef6f10dbcb4Fixed and equalized NaN checks in lapack_wrap (#1246)editlapack_wrap.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse181http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/181/179http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/179/Started by an SCM change179680ed4b0f4a48c4afc605d6185b27610abe6fc99680ed4b0f4a48c4afc605d6185b27610abe6fc99refs/remotes/origin/clubb_silhs_devel680ed4b0f4a48c4afc605d6185b27610abe6fc99680ed4b0f4a48c4afc605d6185b27610abe6fc99refs/remotes/origin/clubb_silhs_devel680ed4b0f4a48c4afc605d6185b27610abe6fc99680ed4b0f4a48c4afc605d6185b27610abe6fc99refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#17913436212373579cam_BFB_coarse_res_gfortran_test #179179false1799601SUCCESS1746692827014http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/179/jenkins_tests/cam_clubb_error_handling_test/cam_test_fatal_error_handling.bashbb9b49aa64decca39a8d6ff1f360ede01439aef31746632836000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comCam clubb error handling jenkins test (#193) Changed file permissions for jenkins_tests/cam_clubb_error_handling_test/cam_test_fatal_error_handling.bash so Jenkins can execute the script. 2025-05-07 10:47:16 -0500bb9b49aa64decca39a8d6ff1f360ede01439aef3Cam clubb error handling jenkins test (#193)editjenkins_tests/cam_clubb_error_handling_test/cam_test_fatal_error_handling.bashsrc/physics/cam/clubb_intr.F90680ed4b0f4a48c4afc605d6185b27610abe6fc991746644935000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdate clubb_intr.F90 2025-05-07 14:08:55 -0500680ed4b0f4a48c4afc605d6185b27610abe6fc99Update clubb_intr.F90editsrc/physics/cam/clubb_intr.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse180http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/180/178http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/178/Started by an SCM change178e0daee07cf70b2fb116ca3fcbd28df7061538b3ae0daee07cf70b2fb116ca3fcbd28df7061538b3arefs/remotes/origin/clubb_silhs_devele0daee07cf70b2fb116ca3fcbd28df7061538b3ae0daee07cf70b2fb116ca3fcbd28df7061538b3arefs/remotes/origin/clubb_silhs_devele0daee07cf70b2fb116ca3fcbd28df7061538b3ae0daee07cf70b2fb116ca3fcbd28df7061538b3arefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#17819866662373579cam_BFB_coarse_res_gfortran_test #178178false1789517SUCCESS1746606427848http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/178/advance_clubb_core_module.F90mixing_length.F90a986aeb210058b3bb9be04880b99bc61ad2f26ec1746549263000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduCleaning up some grid generalization issues that were found within l_implemented flag blocks. 2025-05-06 11:34:23 -0500a986aeb210058b3bb9be04880b99bc61ad2f26ecCleaning up some grid generalization issues that were found withineditadvance_clubb_core_module.F90editmixing_length.F90jenkins_tests/cam_clubb_error_handling_test/Jenkinsfilejenkins_tests/cam_clubb_error_handling_test/cam_test_fatal_error_handling.bashacb7193331a00d6a06040b2c9e30c65e169b2b381746563621000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comCam clubb error handling jenkins test (#191) * Added CAM CLUBB error handling Jenkins test that is similar to the CLUBB error handling test Wrote Jenkinsfile and bash script similar to CLUBB error handling test 2025-05-06 15:33:41 -0500acb7193331a00d6a06040b2c9e30c65e169b2b38Cam clubb error handling jenkins test (#191)addjenkins_tests/cam_clubb_error_handling_test/Jenkinsfileaddjenkins_tests/cam_clubb_error_handling_test/cam_test_fatal_error_handling.bashjenkins_tests/cam_clubb_error_handling_test/Jenkinsfilea13ae719e0e96bd34563b2584f4dd66210d274261746564025000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comCam clubb error handling jenkins test (#192) * Fixed braces error in Jenkinsfile 2025-05-06 15:40:25 -0500a13ae719e0e96bd34563b2584f4dd66210d27426Cam clubb error handling jenkins test (#192)editjenkins_tests/cam_clubb_error_handling_test/Jenkinsfilegithttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse179http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/179/177http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/177/Started by an SCM change177e4cb0f1cd362cf16338a79e1aa8edfe967fdeb5ee4cb0f1cd362cf16338a79e1aa8edfe967fdeb5erefs/remotes/origin/clubb_silhs_devele4cb0f1cd362cf16338a79e1aa8edfe967fdeb5ee4cb0f1cd362cf16338a79e1aa8edfe967fdeb5erefs/remotes/origin/clubb_silhs_devele4cb0f1cd362cf16338a79e1aa8edfe967fdeb5ee4cb0f1cd362cf16338a79e1aa8edfe967fdeb5erefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#17718462302373579cam_BFB_coarse_res_gfortran_test #177177false1779431SUCCESS1746260826817http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/177/mixing_length.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90grid_class.F90advance_windm_edsclrm_module.F90mono_flux_limiter.F90ed8cf99696028a97975d3af4b3a83983857177da1746207443000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRun scm fixes (#1244) Fixed error output for run?scm?all.bash, added some missing error checks to CLUBB CLUBB ticket #975 * Fixed error output issues for run_scm_all.bash - Changed tail $TMP_OUT to cat $TMP_OUT so we can see the entire stderr output of CLUBB in the log - Added `if allocated` check to subroutine finalize_t_dependent_forcings in time_dependent_input.F90 to avoid runtime errors - Removed unnecessary write statement in clubb_standalone.F90 * Added missing err_code checks - Added err_code checks so we don't get false negative error messages 2025-05-02 12:37:23 -0500ed8cf99696028a97975d3af4b3a83983857177daRun scm fixes (#1244)editadvance_clubb_core_module.F90editadvance_xm_wpxp_module.F90editadvance_xp2_xpyp_module.F90editmixing_length.F90editmono_flux_limiter.F90editadvance_windm_edsclrm_module.F90editgrid_class.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse178http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/178/176http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/176/Started by an SCM change176ae2416d29975b1212cacac1947fc609c2840c1f2ae2416d29975b1212cacac1947fc609c2840c1f2refs/remotes/origin/clubb_silhs_develae2416d29975b1212cacac1947fc609c2840c1f2ae2416d29975b1212cacac1947fc609c2840c1f2refs/remotes/origin/clubb_silhs_develae2416d29975b1212cacac1947fc609c2840c1f2ae2416d29975b1212cacac1947fc609c2840c1f2refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#17620133872373579cam_BFB_coarse_res_gfortran_test #176176false1769346SUCCESS1746174428039http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/176/silhs_api_module.F90parameters_silhs.F90est_kessler_microphys_module.F90lh_microphys_var_covar_module.F90latin_hypercube_driver_module.F9032a5fe09a9455802facfa6ffdf49d01fb4bc181f1746130418000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRemoved renaming operators `=>` and wrapper subroutines from silhs_api_module (#1240) CLUBB ticket #1223 * Removed renaming operators `=>` from silhs_api_module This just affected latin_hypercube_2D_output_api and stats_accumulate_lh_api. * Removed definitions of wrapper subroutines from silhs_api_module Removed wrappers est_kessler_microphys_api, lh_microphys_var_covar_driver_api, set_default_silhs_config_flags_api, initialize_silhs_config_flags_type_api, print_silhs_config_flags_api, latin_hypercube_2D_close_api from silhs_api_module. 2025-05-01 15:13:38 -050032a5fe09a9455802facfa6ffdf49d01fb4bc181fRemoved renaming operators `=>` and wrapper subroutines from silhs_api_module (#1240)editlh_microphys_var_covar_module.F90editlatin_hypercube_driver_module.F90editsilhs_api_module.F90editest_kessler_microphys_module.F90editparameters_silhs.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse177http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/177/175http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/175/Started by an SCM change175a8cb33cde8895f6a21f218bb9fb7f8e120ce1861a8cb33cde8895f6a21f218bb9fb7f8e120ce1861refs/remotes/origin/clubb_silhs_devela8cb33cde8895f6a21f218bb9fb7f8e120ce1861a8cb33cde8895f6a21f218bb9fb7f8e120ce1861refs/remotes/origin/clubb_silhs_devela8cb33cde8895f6a21f218bb9fb7f8e120ce1861a8cb33cde8895f6a21f218bb9fb7f8e120ce1861refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#17515661652373579cam_BFB_coarse_res_gfortran_test #175175false1759100SUCCESS1745656029400http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/175/model_flags.F90a58963f687a893aeaec62026a63bbe71dda262d41745614161000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduRunning CLUBB with l_stability_correct_tau_zm = .true. now requires setting l_damp_wp2_using_em to .false. Thus, these two settings now appear together in flag set 9. Since l_damp_wp2_using_em was already set to .false. for flag set 11, I simply swapped flag sets for l_damp_wp2_using_em = .false. (moved from flag set 11 to set 9) and l_C2_cloud_frac = .true. (moved from flag set 9 to set 11). 2025-04-25 15:49:21 -0500a58963f687a893aeaec62026a63bbe71dda262d4Running CLUBB with l_stability_correct_tau_zm = .true. now requireseditmodel_flags.F90model_flags.F9075c64ae1570a7534e37c51f33160b8a55358e38f1745614367000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduThese changes were accidentally made during the previous commit. The are being returned to their normal setting in this commit. 2025-04-25 15:52:47 -050075c64ae1570a7534e37c51f33160b8a55358e38fThese changes were accidentally made during the previous commit. The areeditmodel_flags.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2false176http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/176/174http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/174/Started by an SCM change17477c7e76bb66f74d9e09bd859e09251c7519ba91d77c7e76bb66f74d9e09bd859e09251c7519ba91drefs/remotes/origin/clubb_silhs_devel77c7e76bb66f74d9e09bd859e09251c7519ba91d77c7e76bb66f74d9e09bd859e09251c7519ba91drefs/remotes/origin/clubb_silhs_devel77c7e76bb66f74d9e09bd859e09251c7519ba91d77c7e76bb66f74d9e09bd859e09251c7519ba91drefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#17420467652373579cam_BFB_coarse_res_gfortran_test #174174false1749025SUCCESS1745569630388http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/174/src/physics/cam/clubb_intr.F90src/physics/cam/subcol_SILHS.F9082bbae0f8003142f4a6d602156507f3665e4933b1745509041000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdated CAM for err_info struct (#189) Updated clubb_intr.F90 and subcol_SILHS.F90 for err_info struct, updated some of the error outputs. 2025-04-24 10:37:21 -050082bbae0f8003142f4a6d602156507f3665e4933bUpdated CAM for err_info struct (#189)editsrc/physics/cam/clubb_intr.F90editsrc/physics/cam/subcol_SILHS.F90advance_wp2_wp3_module.F90mixing_length.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90clubb_api_module.F90advance_xm_wpxp_module.F90f922df0c8c9e9ed60d4ad8fe0368cc7479f480e61745538547000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comErr code gpu fix (#1241) * GPU fix for new err_code system. * Another small fix for OMP GPU code. 2025-04-24 18:49:07 -0500f922df0c8c9e9ed60d4ad8fe0368cc7479f480e6Err code gpu fix (#1241)editadvance_wp2_wp3_module.F90editclubb_api_module.F90editadvance_xp2_xpyp_module.F90editadvance_clubb_core_module.F90editmixing_length.F90editadvance_xm_wpxp_module.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse175http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/175/173http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/173/Started by an SCM change173f1bcc9737ecf48fe8bee867674559406165f572af1bcc9737ecf48fe8bee867674559406165f572arefs/remotes/origin/clubb_silhs_develf1bcc9737ecf48fe8bee867674559406165f572af1bcc9737ecf48fe8bee867674559406165f572arefs/remotes/origin/clubb_silhs_develf1bcc9737ecf48fe8bee867674559406165f572af1bcc9737ecf48fe8bee867674559406165f572arefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#17312610252373579cam_BFB_coarse_res_gfortran_test #173173false1738912SUCCESS1745483226266http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/173/precipitation_fraction.F90clubb_api_module.F90advance_xm_wpxp_module.F90numerical_check.F90output_netcdf.F90parameters_tunable.F90grid_class.F90setup_clubb_pdf_params.F90advance_windm_edsclrm_module.F90mono_flux_limiter.F90mixing_length.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90err_info_type_module.F90advance_clubb_core_module.F90lapack_wrap.F90pdf_closure_module.F90stats_clubb_utilities.F90grid_adaptation.F90matrix_solver_wrapper.F90sfc_varnce_module.F90corr_varnce_module.F903d241e564776b535580a2b78d3f29fe1578676e61745422568000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comErr code struct (#1238) Added err_info type to CLUBB to extend old err_code integer flag CLUBB ticket #975 Created a new err_info type replacing the old err_code integer. It contains MPI rank and (OMP) chunk index so we can identify the specific process that caused an error. It also contains latitude and longitude so a person trying to debug a host model run can pinpoint the column that caused an error. It contains error headers that combine all the info into a string that can be printed when an error happens. And it comes with subroutines that handle initialization, value setting, and cleanup. Host models will be modified accordingly. Possible TODO: Implement a subroutine that identifies the index of the column with the error after the fact so we can have more specific info at the higher call levels by applying `where` to the err_code member array. 2025-04-23 10:36:08 -05003d241e564776b535580a2b78d3f29fe1578676e6Err code struct (#1238)editmixing_length.F90editgrid_adaptation.F90editparameters_tunable.F90editsfc_varnce_module.F90editadvance_clubb_core_module.F90editsetup_clubb_pdf_params.F90editcorr_varnce_module.F90editadvance_wp2_wp3_module.F90editnumerical_check.F90editprecipitation_fraction.F90editoutput_netcdf.F90editgrid_class.F90editmatrix_solver_wrapper.F90editclubb_api_module.F90editstats_clubb_utilities.F90editadvance_xp2_xpyp_module.F90editpdf_closure_module.F90editmono_flux_limiter.F90adderr_info_type_module.F90editlapack_wrap.F90editadvance_xm_wpxp_module.F90editadvance_windm_edsclrm_module.F90silhs_api_module.F90latin_hypercube_driver_module.F90output_2D_samples_module.F901a4c3cc982a84bba46f59cacdf819a7a4153153a1745422568000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comErr code struct (#1238) Added err_info type to CLUBB to extend old err_code integer flag CLUBB ticket #975 Created a new err_info type replacing the old err_code integer. It contains MPI rank and (OMP) chunk index so we can identify the specific process that caused an error. It also contains latitude and longitude so a person trying to debug a host model run can pinpoint the column that caused an error. It contains error headers that combine all the info into a string that can be printed when an error happens. And it comes with subroutines that handle initialization, value setting, and cleanup. Host models will be modified accordingly. Possible TODO: Implement a subroutine that identifies the index of the column with the error after the fact so we can have more specific info at the higher call levels by applying `where` to the err_code member array. 2025-04-23 10:36:08 -05001a4c3cc982a84bba46f59cacdf819a7a4153153aErr code struct (#1238)editlatin_hypercube_driver_module.F90editsilhs_api_module.F90editoutput_2D_samples_module.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse174http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/174/172http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/172/Started by user Steffen DomkesdomkeSteffen Domke17235b3ea889451c9a36beb1e305052ba99b0ec15e035b3ea889451c9a36beb1e305052ba99b0ec15e0refs/remotes/origin/clubb_silhs_devel35b3ea889451c9a36beb1e305052ba99b0ec15e035b3ea889451c9a36beb1e305052ba99b0ec15e0refs/remotes/origin/clubb_silhs_devel35b3ea889451c9a36beb1e305052ba99b0ec15e035b3ea889451c9a36beb1e305052ba99b0ec15e0refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#17215449892373579cam_BFB_coarse_res_gfortran_test #172172false1728793SUCCESS1745420768523http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/172/http://carson.math.uwm.edu/jenkins/user/bmg2bmg2false173http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/173/171http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/171/Started by an SCM change17135b3ea889451c9a36beb1e305052ba99b0ec15e035b3ea889451c9a36beb1e305052ba99b0ec15e0refs/remotes/origin/clubb_silhs_devel35b3ea889451c9a36beb1e305052ba99b0ec15e035b3ea889451c9a36beb1e305052ba99b0ec15e0refs/remotes/origin/clubb_silhs_devel35b3ea889451c9a36beb1e305052ba99b0ec15e035b3ea889451c9a36beb1e305052ba99b0ec15e0refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#1717371682373579cam_BFB_coarse_res_gfortran_test #171171false1718755FAILURE1745396827038http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/171/parameters_tunable.F9038c8aa0c03693c9148f9468f2b4fa2026fe69fb91745348257000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI updated adj_low_res_nu for use with a generalized grid. It is not called from within advance_clubb_core or from within SILHS. It is not necessary to be generalized for tests within standalone CLUBB. However, it is necessary to generalize this code for use within host models, particularly for CAM and E3SM. 2025-04-22 13:57:37 -050038c8aa0c03693c9148f9468f2b4fa2026fe69fb9I updated adj_low_res_nu for use with a generalized grid. It iseditparameters_tunable.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2false172http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/172/170http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/170/Started by an SCM change170418af1b5ff11ae2a379e1c859956c5ac0a14e4fb418af1b5ff11ae2a379e1c859956c5ac0a14e4fbrefs/remotes/origin/clubb_silhs_devel418af1b5ff11ae2a379e1c859956c5ac0a14e4fb418af1b5ff11ae2a379e1c859956c5ac0a14e4fbrefs/remotes/origin/clubb_silhs_devel418af1b5ff11ae2a379e1c859956c5ac0a14e4fb418af1b5ff11ae2a379e1c859956c5ac0a14e4fbrefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#17015893752373579cam_BFB_coarse_res_gfortran_test #170170false1708625SUCCESS1744273629823http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/170/precipitation_fraction.F90setup_clubb_pdf_params.F9055eae9b809c45299075475da2f488ecaac258a831744204547000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comClubb silhs gg (#1239) * I added new subroutine pdf_hydromet_microphys_prep to encompass the code that calls the hydrometeor PDF and then ultimately handles the setup of SILHS sample points when SILHS is in use. * Placeholder subroutine for SILHS grid generalization test. * I have now connected the new subroutine to run_clubb. The results for all cases match bit-for-bit to the previous revision. * Cleaning up from the refactoring of the hydrometeor PDF and SILHS code into a wrapper subroutine. * I'm moving pdf_hydromet_microphys_prep to its own file to avoid circular dependency once it finally needs to be called from the generalized grid test code soon. * Added some code to the SILHS generalized grid test. * Changes to make this a fully functioning grid generalization test for the part of the microphysics code that encompasses setup_pdf_parameters and hydrometeor_mixed_moments. * I have completed the code for the SILHS generalized grid test. * I generalized precipitation fraction for ascending vs. descending grid. * Fixing a bug that I noticed in the precipitation fraction calculation when the component precip frac calculation was set to option 1 (which is currently not the default). * The code should now be successfully grid-generalized for SILHS. The ascending vs descending grid test should work now for all cases. * Updating the core flags .json file to change some of the SILHS flags. * I moved the call to advance_clubb_core_api (the default run option) to the top of the "if" block, ahead of the grid generalization test option that is now in the "else" block. * Adding a new, hardwired constant flag called l_ascending_grid and setting it to true in clubb_driver.F90. * Keeping lines under 100 characters in length. * Making it so the ascending vs. descending grid tests pass for the l_lh_random_start flag. 2025-04-09 08:15:47 -050055eae9b809c45299075475da2f488ecaac258a83Clubb silhs gg (#1239)editprecipitation_fraction.F90editsetup_clubb_pdf_params.F90silhs_api_module.F90latin_hypercube_driver_module.F9022f5d492241112ab03918dbd8041883b5b2ae28b1744204547000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comClubb silhs gg (#1239) * I added new subroutine pdf_hydromet_microphys_prep to encompass the code that calls the hydrometeor PDF and then ultimately handles the setup of SILHS sample points when SILHS is in use. * Placeholder subroutine for SILHS grid generalization test. * I have now connected the new subroutine to run_clubb. The results for all cases match bit-for-bit to the previous revision. * Cleaning up from the refactoring of the hydrometeor PDF and SILHS code into a wrapper subroutine. * I'm moving pdf_hydromet_microphys_prep to its own file to avoid circular dependency once it finally needs to be called from the generalized grid test code soon. * Added some code to the SILHS generalized grid test. * Changes to make this a fully functioning grid generalization test for the part of the microphysics code that encompasses setup_pdf_parameters and hydrometeor_mixed_moments. * I have completed the code for the SILHS generalized grid test. * I generalized precipitation fraction for ascending vs. descending grid. * Fixing a bug that I noticed in the precipitation fraction calculation when the component precip frac calculation was set to option 1 (which is currently not the default). * The code should now be successfully grid-generalized for SILHS. The ascending vs descending grid test should work now for all cases. * Updating the core flags .json file to change some of the SILHS flags. * I moved the call to advance_clubb_core_api (the default run option) to the top of the "if" block, ahead of the grid generalization test option that is now in the "else" block. * Adding a new, hardwired constant flag called l_ascending_grid and setting it to true in clubb_driver.F90. * Keeping lines under 100 characters in length. * Making it so the ascending vs. descending grid tests pass for the l_lh_random_start flag. 2025-04-09 08:15:47 -050022f5d492241112ab03918dbd8041883b5b2ae28bClubb silhs gg (#1239)editsilhs_api_module.F90editlatin_hypercube_driver_module.F90src/physics/cam/subcol_SILHS.F904ee92ccfb630f3f8c3b56d986886b6b114d193b21744205138000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduUpdating CAM-CLUBB for recent changes made to CLUBB-SILHS code. 2025-04-09 08:25:38 -05004ee92ccfb630f3f8c3b56d986886b6b114d193b2Updating CAM-CLUBB for recent changes made to CLUBB-SILHS code.editsrc/physics/cam/subcol_SILHS.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse171http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/171/169http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/169/Started by an SCM change16934f8c82cf0e8bcc0ffb84e75090e9397270582dc34f8c82cf0e8bcc0ffb84e75090e9397270582dcrefs/remotes/origin/clubb_silhs_devel34f8c82cf0e8bcc0ffb84e75090e9397270582dc34f8c82cf0e8bcc0ffb84e75090e9397270582dcrefs/remotes/origin/clubb_silhs_devel34f8c82cf0e8bcc0ffb84e75090e9397270582dc34f8c82cf0e8bcc0ffb84e75090e9397270582dcrefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#16918667482373579cam_BFB_coarse_res_gfortran_test #169169false1698454SUCCESS1743150426278http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/169/advance_clubb_core_module.F90stats_clubb_utilities.F9092f350dce5f7be049b04ad3fbba532c4741c76c71743109355000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comClubb driver upgrades (#1225) * Moving stuff around in preparation for preparation for GPUization * Small modifications, adding explicit loops * Small bug fix and explicit loop additions * Removing ngrdcol dimension from initialize_clubb, essentially reverting changes. * Removing array slicing by using local variables of nzm/nzt dim * GPUization of initialization variables * Removing need for single_col versions of the pdf_params, this (weirdly) saves a huge amount of runtime * Adding comment * Adding 2D version of various routines, including initialize_clubb, but only calling initialize_clubb with 1 column. * Fixes to make work with latest clubb changes * Merging with master 2025-03-27 16:02:35 -050092f350dce5f7be049b04ad3fbba532c4741c76c7Clubb driver upgrades (#1225)editadvance_clubb_core_module.F90editstats_clubb_utilities.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse170http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/170/168http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/168/Started by an SCM change16897aa2c69603ad8dd327196c2190dae80292aa91797aa2c69603ad8dd327196c2190dae80292aa917refs/remotes/origin/clubb_silhs_devel97aa2c69603ad8dd327196c2190dae80292aa91797aa2c69603ad8dd327196c2190dae80292aa917refs/remotes/origin/clubb_silhs_devel97aa2c69603ad8dd327196c2190dae80292aa91797aa2c69603ad8dd327196c2190dae80292aa917refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#16814535942373579cam_BFB_coarse_res_gfortran_test #168168false1688259SUCCESS1742804826553http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/168/advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90interpolation.F90advance_xm_wpxp_module.F90advance_windm_edsclrm_module.F90685fa70650398309cae281d0306ed6437762caad1742704780000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comClubb test correct gg (#1237) * Updated the generalized vertical grid test to use the run_bindiff_w_flags_config_core_flags.json file, which performs 18 overall flag configuration file tests and includes almost every configurable model flag found in CLUBB core. * Fixed a bug. This was caught by running the new hybrid PDF after compiling with the gfortran debug compiler script. * The CLUBB code requires l_min_xp2_from_corr_wx and l_enable_relaxed_clipping to always have opposite values. * Finally fixing the bug where Cx_fnc_Richardson needs to be interpolated to thermodynamic levels in order to be used as C11_Skw_fnc. * I fixed an issue with the generalized grid when the expldiff of rtm and thlm is enabled. * The variable gr now needs to be passed into subroutine pvertinterp (which was formerly found in interpolation.F90) in order to generalize the grid. This created a circular dependency, for grid_class references interpolation, and now interpolation needed to reference grid_class in order to use type grid. This road block prevented the model from compiling. I moved subroutine pvertinterp to advance_clubb_core in order to solve the problem. * Moving the flag required editing the delimiters. * I fixed a bug in the generalized grid test code that was resulting in pdf_implicit_coefs_terms scalar variables not being read in correctly for the flipped (descending) grid. * Improved some error handling in clubb_driver.F90 * Fixed an issue where ascending and descending grids were producing results that were not bit-for-bit to each other where centered discretization was used. The issue occurred because 3 or more terms were being added together in opposite orders between ascending and descending grids. This fix ensures terms are added in the same order. * Commiting changes to keep calculation order the same for additions involving at least 3 terms from different vertical levels between ascending and descending grids.` * I removed bugs that were causing failures of the bit-for-bit matching test (at -O0 optimization) between ascending and descending grids. This group of fixes related to the code that calls pdf_closure twice and calls the trapezoidal rule code. * I have fixed the ascending vs. descending grid error for the situation where l_partial_upwind_wp3 is enabled. * I am removing the flag setting of l_mono_flux_lim_thlm to .false. in flag group 15 of the ascending vs. descending grid tests. Problem: Removing the constraints on thlm was causing one case (MC3E) to blow up with a floating point exception in Morrison microphysics. The issue was that a spike caused an extremely cold temperature to be found. There is a line of code that takes the difference between freezing/melting point temperature (273.15 K) and the temperature at the grid level or sample point, multiplies it by constant, and then takes EXP to that product. The large difference between temperature and freezing/melting point, owing to the spike, caused a numerical overflow to occur and the case to fail with a FPE. Solution: There isn't any relevant code found in the monotonic flux limiter that doesn't get tested if l_mono_flux_lim_thlm remains at a setting of .true. The other parts of conditionals are covered by setting l_mono_flux_lim_rtm to .false. The only parts of the code unique to l_mono_flux_lim_thlm are the recording of stats related directly to thlm. Thus, it makes sense to keep l_mono_flux_lim_thlm set to .true. for the stability of the run while turning off the other monotonic flux limiter flags. * Updated the code to use break or return when clubb fatal error is encountered, which is more consistent with the way CLUBB does business now, then simply Fortran stop in place. This also allows the generalized grid test to finally pass for all cases and all flag sets. 2025-03-22 23:39:40 -0500685fa70650398309cae281d0306ed6437762caadClubb test correct gg (#1237)editadvance_xm_wpxp_module.F90editadvance_windm_edsclrm_module.F90editadvance_clubb_core_module.F90editinterpolation.F90editadvance_wp2_wp3_module.F90editadvance_xp2_xpyp_module.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse169http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/169/167http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/167/Started by an SCM change1676f0563a327d1cfefda2306f4c6d51ff65557810f6f0563a327d1cfefda2306f4c6d51ff65557810frefs/remotes/origin/clubb_silhs_devel6f0563a327d1cfefda2306f4c6d51ff65557810f6f0563a327d1cfefda2306f4c6d51ff65557810frefs/remotes/origin/clubb_silhs_devel6f0563a327d1cfefda2306f4c6d51ff65557810f6f0563a327d1cfefda2306f4c6d51ff65557810frefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#16720174462373579cam_BFB_coarse_res_gfortran_test #167167false1677739SUCCESS1741768028556http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/167/error_code.F908d394f926f93c152f873f1391656bbac6fea64811741731122000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduThe generalized grid test should not output a clubb fatal error when it fails. Rather, they should output a unique error code specific to their failure. Otherwise, failures due to numerical instability, etc., will be confused as generalized grid failures in the Jenkins tests. 2025-03-11 17:12:02 -05008d394f926f93c152f873f1391656bbac6fea6481The generalized grid test should not output a clubb fatal error when itediterror_code.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2false168http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/168/166http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/166/Started by an SCM change1667bca04893f00be9db88d9833009e0e88bf1a16477bca04893f00be9db88d9833009e0e88bf1a1647refs/remotes/origin/clubb_silhs_devel7bca04893f00be9db88d9833009e0e88bf1a16477bca04893f00be9db88d9833009e0e88bf1a1647refs/remotes/origin/clubb_silhs_devel7bca04893f00be9db88d9833009e0e88bf1a16477bca04893f00be9db88d9833009e0e88bf1a1647refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#16619466472373579cam_BFB_coarse_res_gfortran_test #166166false1667658SUCCESS1741426028501http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/166/advance_wp2_wp3_module.F90d13c9049915a1e950527b987950e382dd9e47e7d1741367211000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduRevert "I have no idea if it's appropriate to include gr in this statment," This reverts commit d2b125b12117d18474f2093b40e3e575a93422e7. 2025-03-07 11:06:51 -0600d13c9049915a1e950527b987950e382dd9e47e7dRevert "I have no idea if it's appropriate to include gr in this statment,"editadvance_wp2_wp3_module.F90mono_flux_limiter.F90c39543a1c216e789d89d540d4c30bd9898486e9e1741387523000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI discovered that I inadvertently change an $acc statement that is found in the monotonic flux limiter (why is it ALWAYS the monotonic flux limiter?) back in be90159. In this commit, I am setting the $acc statement back to what it is supposed to be. 2025-03-07 16:45:23 -0600c39543a1c216e789d89d540d4c30bd9898486e9eI discovered that I inadvertently change an $acc statement thateditmono_flux_limiter.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2false167http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/167/165http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/165/Started by an SCM change165f29b8d8d274461772a37c52c9c1b2a642b2daf0df29b8d8d274461772a37c52c9c1b2a642b2daf0drefs/remotes/origin/clubb_silhs_develf29b8d8d274461772a37c52c9c1b2a642b2daf0df29b8d8d274461772a37c52c9c1b2a642b2daf0drefs/remotes/origin/clubb_silhs_develf29b8d8d274461772a37c52c9c1b2a642b2daf0df29b8d8d274461772a37c52c9c1b2a642b2daf0drefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#16517235872373579cam_BFB_coarse_res_gfortran_test #165165false1657564SUCCESS1741253230058http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/165/src/physics/cam/subcol_SILHS.F904406cdbdbd463eb00481376774ca1d8e1f073eb41741185589000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduFixed a compilation bug 2025-03-05 08:39:49 -06004406cdbdbd463eb00481376774ca1d8e1f073eb4Fixed a compilation bugeditsrc/physics/cam/subcol_SILHS.F90stats_clubb_utilities.F90997f0297808643a4ee76621e98fd3c7821948f411741203326000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comEliminate GOTO statement in stats_clubb_utilities (#1233) * Eliminate jump in stats_clubb_utilities CLUBB ticket #975 Hard removed end parameter from read call GOTO marker `100` removed since `end` parameter is gone and added output of read error code to help debugging. Before this change, if the read encountered an EOF error and the jump to marker 100 happened, CLUBB would continue running (err_code=clubb_no_error) but no output files would be created. After this change, err_code will be set to clubb_fatal_error and CLUBB prints an error message and returns. 2025-03-05 13:35:26 -0600997f0297808643a4ee76621e98fd3c7821948f41Eliminate GOTO statement in stats_clubb_utilities (#1233)editstats_clubb_utilities.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90advance_xm_wpxp_module.F90advance_windm_edsclrm_module.F90mono_flux_limiter.F90c65a1eab66b642133992df67073c37f734f9276d1741219550000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduAdded some missing acc parallel statments around some the loops I added to the code for the grid generalization test. 2025-03-05 18:05:50 -0600c65a1eab66b642133992df67073c37f734f9276dAdded some missing acc parallel statments around some the loopseditadvance_xm_wpxp_module.F90editadvance_windm_edsclrm_module.F90editadvance_wp2_wp3_module.F90editadvance_xp2_xpyp_module.F90editmono_flux_limiter.F90stats_clubb_utilities.F901f2eea8f772a494daf1517c840c036245ece8bfd1741219960000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduFixed a bug 2025-03-05 18:12:40 -06001f2eea8f772a494daf1517c840c036245ece8bfdFixed a bugeditstats_clubb_utilities.F90advance_wp2_wp3_module.F90ba693e0d27c04cfbaf7755307a217f9ea44aa09e1741223016000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI have no idea if it's appropriate to include gr in this statment, but I'm just basically throwing dung at the wall at this point. We'll see what sticks. 2025-03-05 19:03:36 -0600ba693e0d27c04cfbaf7755307a217f9ea44aa09eI have no idea if it's appropriate to include gr in this statment,editadvance_wp2_wp3_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse166http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/166/164http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/164/Started by an SCM change1644bb5edc64d1b8adfee7fd9cd778c3eb1d78181e54bb5edc64d1b8adfee7fd9cd778c3eb1d78181e5refs/remotes/origin/clubb_silhs_devel4bb5edc64d1b8adfee7fd9cd778c3eb1d78181e54bb5edc64d1b8adfee7fd9cd778c3eb1d78181e5refs/remotes/origin/clubb_silhs_devel4bb5edc64d1b8adfee7fd9cd778c3eb1d78181e54bb5edc64d1b8adfee7fd9cd778c3eb1d78181e5refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#16417114042373579cam_BFB_coarse_res_gfortran_test #164164false1647480SUCCESS1741166829641http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/164/grid_class.F90d080994ebfce2a1aae5509e6a1727a5fe4ef876b1741120069000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI changed the variable type within grid function flip from dp to core_rknd. I then needed to make some changes to BUGSrad driver to compensate. The "dp" issue was discovered when WRF-CLUBB wouldn't compile because of it (discrepancy between dp and core_rknd in WRF-CLUBB that caused compilation errors for calls to flip from advance_xm_wpxp, etc.) 2025-03-04 14:27:49 -0600d080994ebfce2a1aae5509e6a1727a5fe4ef876bI changed the variable type within grid function flip from dp toeditgrid_class.F90advance_clubb_core_module.F90781a8ecf164f73570d972e8e49d46399b4eee0221741135026000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduFixed a compiling issue with CAM-CLUBB. 2025-03-04 18:37:06 -0600781a8ecf164f73570d972e8e49d46399b4eee022Fixed a compiling issue with CAM-CLUBB.editadvance_clubb_core_module.F90saturation.F90b7d415425bda941b81468bee63c68dcc9541a0051741139829000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduHopefully this helps the cpu vs. gpu tests. 2025-03-04 19:57:09 -0600b7d415425bda941b81468bee63c68dcc9541a005Hopefully this helps the cpu vs. gpu tests.editsaturation.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2false165http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/165/163http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/163/Started by an SCM change16317ee8497050dc3f2a9d872853a0d8c13454e7af817ee8497050dc3f2a9d872853a0d8c13454e7af8refs/remotes/origin/clubb_silhs_devel17ee8497050dc3f2a9d872853a0d8c13454e7af817ee8497050dc3f2a9d872853a0d8c13454e7af8refs/remotes/origin/clubb_silhs_devel17ee8497050dc3f2a9d872853a0d8c13454e7af817ee8497050dc3f2a9d872853a0d8c13454e7af8refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#16313847752373579cam_BFB_coarse_res_gfortran_test #163163false1637404SUCCESS1741080430573http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/163/src/physics/cam/clubb_intr.F90src/physics/cam/subcol_SILHS.F9017ee8497050dc3f2a9d872853a0d8c13454e7af81741021378000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduUpdating subroutine calls for recent changes made to CLUBB. 2025-03-03 11:02:58 -060017ee8497050dc3f2a9d872853a0d8c13454e7af8Updating subroutine calls for recent changes made to CLUBB.editsrc/physics/cam/subcol_SILHS.F90editsrc/physics/cam/clubb_intr.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2false164http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/164/162http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/162/Started by an SCM change162dd174450eacbaa971ce9e1405296ea7f60a671a1dd174450eacbaa971ce9e1405296ea7f60a671a1refs/remotes/origin/clubb_silhs_develdd174450eacbaa971ce9e1405296ea7f60a671a1dd174450eacbaa971ce9e1405296ea7f60a671a1refs/remotes/origin/clubb_silhs_develdd174450eacbaa971ce9e1405296ea7f60a671a1dd174450eacbaa971ce9e1405296ea7f60a671a1refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#16214918702373579cam_BFB_coarse_res_gfortran_test #162162false1627321SUCCESS1740907627854http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/162/diffusion.F90model_flags.F90clubb_api_module.F90clip_explicit.F90advance_xm_wpxp_module.F90pos_definite_module.F90grid_class.F90sponge_layer_damping.F90turbulent_adv_pdf.F90advance_windm_edsclrm_module.F90advance_helper_module.F90mono_flux_limiter.F90advance_wp2_wp3_module.F90mixing_length.F90advance_xp2_xpyp_module.F90saturation.F90advance_clubb_core_module.F90mean_adv.F90fill_holes.F90pdf_closure_module.F90grid_adaptation.F90sfc_varnce_module.F90c4ffc9479567a66c1a43824ed79cc82b6a5c64a41740847122000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comGeneralized grid (#1230) * Added the necessary grid variables to the grid type (they're hardwired for an Ascending Grid for now). I also made the necessary changes, using those new variables, to advance_wp2_wp3_module.F90. * Added code to generalize advance_xm_wpxp_module.F90. * Updated some of the boundary conditions for generalization in grid_class.F90. * Developing a unit test for CLUBB's grid functions. * Adding the ability to toggle on or off the reverse direction grid test. * Updating for development of a unit test comparing the ascending and descending grids. * I updated the generalized grid unit test to complete testing on all the variables within the grid derived type for both the ascending and descending grid directions. * I updated the code to work symmetrically for an ascending and descending grid for the zm2zt and zt2zm functions. This commit, as well as the previous commit, is BIT_CHANGING. * Updated to improve notes and comments in grid_class.F90 and to enhance the reverse grid unit tests. * Got rid of the compiler warnings in the new reverse direction grid unit test. * Updating the reverse grid unit tests so some random perturbations are added to the grid heights when they are declared either on the thermodynamic grid or on the momentum grid. * Made some changes where the fstdout stream is exclusively used and added some print statements. * Mean advection has been modified for generalized directional gridding and a test of the calls to mean advection has been added to the reverse direction unit test. * Updating diffusion so results are bit-for-bit identical between using an ascending grid and using a descending grid at -O0 optimization. This now works for both standard diffusion and also diffusion with the l_upwind_Kh_dp_term flag turned on. * I forgot to add the zm diffusion test, but the results are the same -- all pass! * I have completed the unit tests for the PDF turbulent advection subroutines and modified the appropriate sections of code so that ascending and descending grids produce a bit-for-bit match wiht -O0 optimization. * Updated code for producing a bit-for-bit match (on -O0 optimization) when comparing ascending grid direction against descending grid direction for advance_wp2_wp3. * The check for the LHS of advance_xp2_xpyp now passes. * The ascending vs. descending bit-for-bit test (wiht optimization set to -O0) now passes for advance_xp2_xpyp. * I have successfully generalized the grid for advance_windm_edscrlm. Ascending and descending runs now produce bit-for-bit results to each other under -O0 optimization with the default flag configuration. * Fixing the ascending vs. descending grid test for advance_windm_edsclrm for the case where l_imp_sfc_momentum_flux is set to false. * Only perform check when l_predict_upwp_vpwp is turned off. * This commit makes an ascending vs. descending test work for all cases for advance_xm_wpxp when the mono flux limiter is turned off. * The ascending vs. descending grid tests are finally working with the monotonic flux limiter turned on (default settings). * Removed some commented-out prints that I accidentally added during the last commit. * Updating positive_definite_module.F90 so that it works for ascending vs. descending grids. * The ascending vs. descending grid generalization test now works for the Lscale_up portion of mixing length. * The ascending vs. descending grid generalization now works successfully for Lscale_down. * Lscale is now generalized for ascending vs. descending gridding. * Updated for generalizing sfc_varnce_module * Updating advance_clubb_core_module for grid generalization. * With this commit, the ascending vs. descending grid tests works by calling advance_clubb_core twice from clubb_driver. They produce bit-for-bit results on -O0 optimization for all intent(inout) and intent(out) variables found in the call to advance_clubb_core. This has only been tested for the default flag configuration. * I am updating the ascending vs. descending grid test to check both pdf_params and pdf_params_zm. * I added pdf_implicit_coefs_terms and the sclr and edsclr family of variables to the list of variables that are checked after coming out of the calls to advance_clubb_core in the ascending vs. descending bit-for-bit grid test. * I added an improved display for the print messages for the ascending vs. descending grid test. * I moved the generalized grid test to its own file, which is called from run_clubb. * I removed much of the junk and clutter from the code. It had been added over time for local tests of ascending vs. descending grid types. * Adding the l_generalized_grid_test flag to the code. * I needed to alter the monotonic flux limiter that I just merged in from the master branch so that the ascending vs. descending grid generalization test works once again. * Updated a piece of code in the solve routine for the monotonic flux limiter for the grid generalization test. * Clarified some comments * I added a Jenkins file for the new clubb_generalized_vertical_grid_test, which performs a run comparing ascending and descending grids with -O0 optimization and expects bit-for-bit results. * The l_rev_direction_grid_test (part of the G unit tests) needs to be compiled specially with -O0 optimization. Thus, I will set the flag to run this test to .false. by default. A special Jenkins test will be made to compile with the correct optimization and run only this particular test. * I updated the generalized vertical grid Jenkins test to turn off sponge damping (thlm and rtm sponge damping) in the case files for the CGILS S6, S11, and S12 cases. * Caught a stats bug I had previously introduced for the um_ta and vm_ta stats terms when l_predict_upwp_vpwp is turned off. 2025-03-01 10:38:42 -0600c4ffc9479567a66c1a43824ed79cc82b6a5c64a4Generalized grid (#1230)editadvance_wp2_wp3_module.F90editmodel_flags.F90editgrid_class.F90editfill_holes.F90editclubb_api_module.F90editadvance_helper_module.F90editclip_explicit.F90editgrid_adaptation.F90editsfc_varnce_module.F90editadvance_xm_wpxp_module.F90editmono_flux_limiter.F90editmean_adv.F90editsaturation.F90editdiffusion.F90editmixing_length.F90editturbulent_adv_pdf.F90editadvance_clubb_core_module.F90editpdf_closure_module.F90editadvance_windm_edsclrm_module.F90editpos_definite_module.F90editadvance_xp2_xpyp_module.F90editsponge_layer_damping.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse163http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/163/161http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/161/Started by an SCM change1614df60bde4a9547cf98ad1f6531fdd945a39338fd4df60bde4a9547cf98ad1f6531fdd945a39338fdrefs/remotes/origin/clubb_silhs_devel4df60bde4a9547cf98ad1f6531fdd945a39338fd4df60bde4a9547cf98ad1f6531fdd945a39338fdrefs/remotes/origin/clubb_silhs_devel4df60bde4a9547cf98ad1f6531fdd945a39338fd4df60bde4a9547cf98ad1f6531fdd945a39338fdrefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#16121448652373579cam_BFB_coarse_res_gfortran_test #161161false1617127SUCCESS1740648430576http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/161/clubb_api_module.F90advance_xm_wpxp_module.F90mt95.F90diagnose_correlations_module.F90grid_class.F90setup_clubb_pdf_params.F90advance_windm_edsclrm_module.F90advance_helper_module.F90mono_flux_limiter.F90advance_wp2_wp3_module.F90mixing_length.F90advance_xp2_xpyp_module.F90stats_rad_zm_module.F90stats_rad_zt_module.F90pdf_closure_module.F90calc_pressure.F90corr_varnce_module.F90model_flags.F90numerical_check.F90parameters_tunable.F90saturation.F90advance_clubb_core_module.F90advance_xp3_module.F90mean_adv.F90stats_zt_module.F90fill_holes.F90stats_sfc_module.F90stats_clubb_utilities.F90stats_zm_module.F90T_in_K_module.F90parameters_model.F902b0f47b5ac4af77b353fdeb400a762f30fba819f1740615071000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRemoved renaming operators `=>` from clubb_api_module (#1232) CLUBB ticket #1223 The original procedures were renamed to `<name>_api`. Now, the `clubb_api_module` just has a regular `use` and `public` statement for them. 2025-02-26 18:11:11 -06002b0f47b5ac4af77b353fdeb400a762f30fba819fRemoved renaming operators `=>` from clubb_api_module (#1232)editgrid_class.F90editadvance_windm_edsclrm_module.F90editadvance_clubb_core_module.F90editadvance_wp2_wp3_module.F90editpdf_closure_module.F90editstats_sfc_module.F90editstats_clubb_utilities.F90editstats_zm_module.F90editadvance_helper_module.F90editmean_adv.F90editcalc_pressure.F90editclubb_api_module.F90editparameters_tunable.F90editadvance_xp2_xpyp_module.F90editmodel_flags.F90editT_in_K_module.F90editmt95.F90editadvance_xp3_module.F90editnumerical_check.F90editstats_zt_module.F90editadvance_xm_wpxp_module.F90editmixing_length.F90editparameters_model.F90editmono_flux_limiter.F90editstats_rad_zm_module.F90editcorr_varnce_module.F90editsaturation.F90editsetup_clubb_pdf_params.F90editdiagnose_correlations_module.F90editstats_rad_zt_module.F90editfill_holes.F90latin_hypercube_driver_module.F90245613178bae0ea5945d65285d21a467c6584d921740615071000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRemoved renaming operators `=>` from clubb_api_module (#1232) CLUBB ticket #1223 The original procedures were renamed to `<name>_api`. Now, the `clubb_api_module` just has a regular `use` and `public` statement for them. 2025-02-26 18:11:11 -0600245613178bae0ea5945d65285d21a467c6584d92Removed renaming operators `=>` from clubb_api_module (#1232)editlatin_hypercube_driver_module.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse162http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/162/160http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/160/Started by an SCM change16074b691e61cf8ca5594f2c03a39410b0e2f193e5e74b691e61cf8ca5594f2c03a39410b0e2f193e5erefs/remotes/origin/clubb_silhs_devel74b691e61cf8ca5594f2c03a39410b0e2f193e5e74b691e61cf8ca5594f2c03a39410b0e2f193e5erefs/remotes/origin/clubb_silhs_devel74b691e61cf8ca5594f2c03a39410b0e2f193e5e74b691e61cf8ca5594f2c03a39410b0e2f193e5erefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#16013649812373579cam_BFB_coarse_res_gfortran_test #160160false1607077SUCCESS1740475627874http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/160/jenkins_tests/cam_scam_gfortran_debug_test/Jenkinsfilejenkins_tests/cam_global_ERP_Ln9_gfortran_test/Jenkinsfilejenkins_tests/cam_gpu_test/Jenkinsfilejenkins_tests/cam_silhs_global_ERP_ln9_gfortran_test/Jenkinsfilejenkins_tests/cam_plot_scam_ifort/Jenkinsfile74b691e61cf8ca5594f2c03a39410b0e2f193e5e1740433701000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdates to jenkins scripts to better record output logs (#187) 2025-02-24 15:48:21 -060074b691e61cf8ca5594f2c03a39410b0e2f193e5eUpdates to jenkins scripts to better record output logs (#187)editjenkins_tests/cam_global_ERP_Ln9_gfortran_test/Jenkinsfileeditjenkins_tests/cam_gpu_test/Jenkinsfileeditjenkins_tests/cam_plot_scam_ifort/Jenkinsfileeditjenkins_tests/cam_silhs_global_ERP_ln9_gfortran_test/Jenkinsfileeditjenkins_tests/cam_scam_gfortran_debug_test/Jenkinsfilegithttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse161http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/161/159http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/159/Started by an SCM change1599da09d9a5168b14003c14bd7573cd11cb6d4b01c9da09d9a5168b14003c14bd7573cd11cb6d4b01crefs/remotes/origin/clubb_silhs_devel9da09d9a5168b14003c14bd7573cd11cb6d4b01c9da09d9a5168b14003c14bd7573cd11cb6d4b01crefs/remotes/origin/clubb_silhs_devel9da09d9a5168b14003c14bd7573cd11cb6d4b01c9da09d9a5168b14003c14bd7573cd11cb6d4b01crefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#15920057522373579cam_BFB_coarse_res_gfortran_test #159159false1597040SUCCESS1740216426628http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/159/mono_flux_limiter.F90cdc77c1d92e7005f63ff0a70f2a37c9344f94e7e1740172850000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduGetting rid of a couple of worthless lines of code. It's possible this changes an output stat, making this commit BIT_CHANGING, but not actually answer changing. 2025-02-21 15:20:50 -0600cdc77c1d92e7005f63ff0a70f2a37c9344f94e7eGetting rid of a couple of worthless lines of code. It's possible thiseditmono_flux_limiter.F90mono_flux_limiter.F90fd213807e84e02d4777206d80a90009294782a781740172965000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduShould just delete instead of commenting out. 2025-02-21 15:22:45 -0600fd213807e84e02d4777206d80a90009294782a78Should just delete instead of commenting out.editmono_flux_limiter.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2false160http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/160/158http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/158/Started by an SCM change1588c4af18829b60c47d1e8454797e351b781f71bc18c4af18829b60c47d1e8454797e351b781f71bc1refs/remotes/origin/clubb_silhs_devel8c4af18829b60c47d1e8454797e351b781f71bc18c4af18829b60c47d1e8454797e351b781f71bc1refs/remotes/origin/clubb_silhs_devel8c4af18829b60c47d1e8454797e351b781f71bc18c4af18829b60c47d1e8454797e351b781f71bc1refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#15817894442373579cam_BFB_coarse_res_gfortran_test #158158false1586946SUCCESS1740130027707http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/158/error_code.F90clubb_api_module.F902913cd9a5b791c1e7248d2ad7dcfd89cfc9a2d0e1740075254000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRevert clubb api module changes (#1228) * Revert intent changes to err_code_api in clubb_api_module to stay consistent with host models CLUBB ticket #975 Reverted changes in advance_clubb_core_api and to corresponding call in run_clubb Since the module variable is not used anywhere anymore, we can also remove it from the module 2025-02-20 12:14:14 -06002913cd9a5b791c1e7248d2ad7dcfd89cfc9a2d0eRevert clubb api module changes (#1228)editerror_code.F90editclubb_api_module.F90pdf_closure_module.F9020aceeaecd53a592cea775ac5def92cea74294bd1740078773000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comFixed equality check in pdf_closure_module (#1229) CLUBB ticket #975 WRF detected this error. Fixed it. 2025-02-20 13:12:53 -060020aceeaecd53a592cea775ac5def92cea74294bdFixed equality check in pdf_closure_module (#1229)editpdf_closure_module.F90interpolation.F90grid_adaptation.F90model_flags.F90bdaeacdc2600446ad65b582e5fdef98b97b6e8a81740100234000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comadd dycore grid with conservative remapping scheme * add tunable parameter interp_from_dycore_grid_method * add dycore interpolation to atex case with conservative remapping by ullrich * remove new gpu commands * add acc annotation for gpu * remove acc annotation again * add acc annotation for parallel loop * add acc annotations for parallel loop execution * change remapping subroutine to take number of levels and levels as input instead of whole grid object * add more general functions to interpolate * add and refactor functions for remapping values given on zm levels * fix compiler errors and refactoring to stay under 100 chars per line * remove TODOs and used new interpolating function in interpolate_forcings * add functions for adaptive grid generation and grid density function normalization * add conservative ullrich remapping to cases with forcing time dependent inputs * add grid adaptation and flag * clean up and add warning for case when remapping from dycore flag cannot be used * some refactoring * add logical flag for dycore and renamed flags for dycore and grid adaptation * remove ifdefs * refactoring * add units * changed Lscale to inverse --------- Co-authored-by: Steffen Carstensen <steffenc34@icloud.com> 2025-02-20 19:10:34 -0600bdaeacdc2600446ad65b582e5fdef98b97b6e8a8add dycore grid with conservative remapping schemeeditinterpolation.F90addgrid_adaptation.F90editmodel_flags.F90bld/namelist_files/namelist_definition.xmlbld/build-namelistbld/namelist_files/namelist_defaults_cam.xmlsrc/physics/cam/clubb_intr.F902d33bdfc7819e515df367ea87c81d6d74ad1d6321740100281000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comadd flags (#186) * add two new flags * add unset_i * add new logical flag for dycore and renamed flags for dycore and grid adaptation * small fix 2025-02-20 19:11:21 -06002d33bdfc7819e515df367ea87c81d6d74ad1d632add flags (#186)editbld/namelist_files/namelist_definition.xmleditbld/namelist_files/namelist_defaults_cam.xmleditbld/build-namelisteditsrc/physics/cam/clubb_intr.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse159http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/159/157http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/157/Started by an SCM change157e702b1a3cc8132377983ebae3f7c8e648efb7918e702b1a3cc8132377983ebae3f7c8e648efb7918refs/remotes/origin/clubb_silhs_devele702b1a3cc8132377983ebae3f7c8e648efb7918e702b1a3cc8132377983ebae3f7c8e648efb7918refs/remotes/origin/clubb_silhs_devele702b1a3cc8132377983ebae3f7c8e648efb7918e702b1a3cc8132377983ebae3f7c8e648efb7918refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#15714568672373579cam_BFB_coarse_res_gfortran_test #157157false1576821SUCCESS1740043628636http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/157/precipitation_fraction.F90advance_xm_wpxp_module.F90clubb_api_module.F90numerical_check.F90output_netcdf.F90parameters_tunable.F90grid_class.F90setup_clubb_pdf_params.F90advance_windm_edsclrm_module.F90mono_flux_limiter.F90mixing_length.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90lapack_wrap.F90error_code.F90pdf_closure_module.F90stats_clubb_utilities.F90matrix_solver_wrapper.F90sfc_varnce_module.F90corr_varnce_module.F907379430a943ac3d81c150be7068792be4c3e13e31739985373000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRemove err code (#1218) CLUBB ticket #975 Module variable `err_code` was removed and replaced by intent(inout) subroutine parameters. Added messages to `error stop`s in `clubb_api_module` 2025-02-19 11:16:13 -06007379430a943ac3d81c150be7068792be4c3e13e3Remove err code (#1218)editoutput_netcdf.F90editmono_flux_limiter.F90editsetup_clubb_pdf_params.F90editadvance_xm_wpxp_module.F90editcorr_varnce_module.F90editsfc_varnce_module.F90editlapack_wrap.F90editadvance_windm_edsclrm_module.F90editprecipitation_fraction.F90editmatrix_solver_wrapper.F90editmixing_length.F90editclubb_api_module.F90editnumerical_check.F90editpdf_closure_module.F90editadvance_wp2_wp3_module.F90editparameters_tunable.F90editadvance_xp2_xpyp_module.F90editstats_clubb_utilities.F90editerror_code.F90editgrid_class.F90editadvance_clubb_core_module.F90output_2D_samples_module.F908c82ca7ba8400aa6b5558d4666074f67ea42a2c81739985373000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRemove err code (#1218) CLUBB ticket #975 Module variable `err_code` was removed and replaced by intent(inout) subroutine parameters. Added messages to `error stop`s in `clubb_api_module` 2025-02-19 11:16:13 -06008c82ca7ba8400aa6b5558d4666074f67ea42a2c8Remove err code (#1218)editoutput_2D_samples_module.F90numerical_check.F90a79e7440d2291b9258200180e211896002d72c841739987333000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRenamed check_res to err_code in numerical_check.F90 for consistency (#1227) 2025-02-19 11:48:53 -0600a79e7440d2291b9258200180e211896002d72c84Renamed check_res to err_code in numerical_check.F90 for consistency (#1227)editnumerical_check.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse158http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/158/156http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/156/Started by an SCM change15660760414d3d0122efa228da6b0c424f080ae3fc560760414d3d0122efa228da6b0c424f080ae3fc5refs/remotes/origin/clubb_silhs_devel60760414d3d0122efa228da6b0c424f080ae3fc560760414d3d0122efa228da6b0c424f080ae3fc5refs/remotes/origin/clubb_silhs_devel60760414d3d0122efa228da6b0c424f080ae3fc560760414d3d0122efa228da6b0c424f080ae3fc5refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#15614599972373579cam_BFB_coarse_res_gfortran_test #156156false1566733SUCCESS1739957229159http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/156/model_flags.F90d74095b46f4135608ed1991171a1cc33cdd5260e1739884009000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comSet l_wp2_fill_holes_tke to true by default (#1226) This code change is BIT_CHANGING for extreme cases (e.g. TWP_ICE, LBA, ARM_97). Changed configurable_model_flags.in files and default value in model_flags.F90. For CLUBB ticket #1165. 2025-02-18 07:06:49 -0600d74095b46f4135608ed1991171a1cc33cdd5260eSet l_wp2_fill_holes_tke to true by default (#1226)editmodel_flags.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse157http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/157/155http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/155/Started by an SCM change15553535f3dd78d0fead78591962867a4136891ee8653535f3dd78d0fead78591962867a4136891ee86refs/remotes/origin/clubb_silhs_devel53535f3dd78d0fead78591962867a4136891ee8653535f3dd78d0fead78591962867a4136891ee86refs/remotes/origin/clubb_silhs_devel53535f3dd78d0fead78591962867a4136891ee8653535f3dd78d0fead78591962867a4136891ee86refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#15514498972373579cam_BFB_coarse_res_gfortran_test #155155false1556554SUCCESS1739006826731http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/155/mixing_length.F907cd91435f2c4f37329710d4b5cac241c8b1bd7961738965924000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduSwapping the loop order on a few kernels, I found this faster for the nvhpc compiler and it's BFB 2025-02-07 16:05:24 -06007cd91435f2c4f37329710d4b5cac241c8b1bd796Swapping the loop order on a few kernels, I found this faster for the nvhpc compiler and it's BFBeditmixing_length.F90githttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse156http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/156/154http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/154/Started by an SCM change154a344552609f8246b10d8a782b2aa52fd4ab7df55a344552609f8246b10d8a782b2aa52fd4ab7df55refs/remotes/origin/clubb_silhs_devela344552609f8246b10d8a782b2aa52fd4ab7df55a344552609f8246b10d8a782b2aa52fd4ab7df55refs/remotes/origin/clubb_silhs_devela344552609f8246b10d8a782b2aa52fd4ab7df55a344552609f8246b10d8a782b2aa52fd4ab7df55refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#1548365532373579cam_BFB_coarse_res_gfortran_test #154154false1546468SUCCESS1738661225682http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/154/mono_flux_limiter.F90784f0b93217e86529c33a6f6b2bc424a6baebddf1738606672000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comMonoflux GPU optimization (#1221) * Making a fast version of the serial loop to check if we even need to perform the slow version at all. * Updates * Final touches to make new version logically the same. * Improving comments and variables names 2025-02-03 12:17:52 -0600784f0b93217e86529c33a6f6b2bc424a6baebddfMonoflux GPU optimization (#1221)editmono_flux_limiter.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse155http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/155/153http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/153/Started by an SCM change1539d84cf166952d568ed8f3823649dfd0c48f0bd669d84cf166952d568ed8f3823649dfd0c48f0bd66refs/remotes/origin/clubb_silhs_devel9d84cf166952d568ed8f3823649dfd0c48f0bd669d84cf166952d568ed8f3823649dfd0c48f0bd66refs/remotes/origin/clubb_silhs_devel9d84cf166952d568ed8f3823649dfd0c48f0bd669d84cf166952d568ed8f3823649dfd0c48f0bd66refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#15313628412373579cam_BFB_coarse_res_gfortran_test #153153false1536193SUCCESS1737192425881http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/153/src/physics/cam/clubb_intr.F909d84cf166952d568ed8f3823649dfd0c48f0bd661737152678000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdate clubb_intr.F90 (#185) Added l_wp2_fill_holes_tke to clubb_intr.F90 2025-01-17 16:24:38 -06009d84cf166952d568ed8f3823649dfd0c48f0bd66Update clubb_intr.F90 (#185)editsrc/physics/cam/clubb_intr.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse154http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/154/152http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/152/Started by an SCM change152a64171b81dfe0bfd91289455c71c25230c5ecc6ea64171b81dfe0bfd91289455c71c25230c5ecc6erefs/remotes/origin/clubb_silhs_devela64171b81dfe0bfd91289455c71c25230c5ecc6ea64171b81dfe0bfd91289455c71c25230c5ecc6erefs/remotes/origin/clubb_silhs_devela64171b81dfe0bfd91289455c71c25230c5ecc6ea64171b81dfe0bfd91289455c71c25230c5ecc6erefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#15213491632373579cam_BFB_coarse_res_gfortran_test #152152false1526129SUCCESS1737106064865http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/152/advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90model_flags.F90clip_explicit.F90fill_holes.F90stats_clubb_utilities.F900c7bd6c5950299772d6702dd2eacc6b4fbeb62d91737065191000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdded new hole-filling method which takes TKE from up2 and vp2 (#1217) Added new hole-filling method which takes TKE from up2 and vp2 CLUBB ticket #1165 BIT_CHANGING if flag `l_wp2_fill_holes_tke` is set to true Introduced new flag `l_wp2_fill_holes_tke` to turn on new wp2 hole-filling subroutine that takes TKE from up2 and vp2. 2025-01-16 16:06:31 -06000c7bd6c5950299772d6702dd2eacc6b4fbeb62d9Added new hole-filling method which takes TKE from up2 and vp2 (#1217)editclip_explicit.F90editadvance_wp2_wp3_module.F90editstats_clubb_utilities.F90editmodel_flags.F90editadvance_clubb_core_module.F90editfill_holes.F90editadvance_xp2_xpyp_module.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse153http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/153/151http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/151/Started by an SCM change151b3c6f29d0d1a50b165ee1e44a515e6d23991285cb3c6f29d0d1a50b165ee1e44a515e6d23991285crefs/remotes/origin/clubb_silhs_develb3c6f29d0d1a50b165ee1e44a515e6d23991285cb3c6f29d0d1a50b165ee1e44a515e6d23991285crefs/remotes/origin/clubb_silhs_develb3c6f29d0d1a50b165ee1e44a515e6d23991285cb3c6f29d0d1a50b165ee1e44a515e6d23991285crefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#15119616152373579cam_BFB_coarse_res_gfortran_test #151151false1516047SUCCESS1734686826011http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/151/pdf_utilities.F90pdf_closure_module.F90advance_helper_module.F901d49bab84b798a9220af6e984d9ecc6c884f98811734646199000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comFix binormal correlation clipping (#1199) Fixed clipping in binormal correlation calc CLUBB ticket #1164 BIT_CHANGING * Implemented new denominator with smooth_max clipping * Created subroutine `smooth_corr_quotient` in pdf_utilities.F90, outsourcing smooth correlation division * This subroutine is used `calc_comp_corrs_binormal` and `transform_pdf_chi_eta_component` 2024-12-19 16:09:59 -06001d49bab84b798a9220af6e984d9ecc6c884f9881Fix binormal correlation clipping (#1199)editadvance_helper_module.F90editpdf_closure_module.F90editpdf_utilities.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse152http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/152/150http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/150/Started by an SCM change1505fd1defe00a484aba044b60c03807921b8e895f85fd1defe00a484aba044b60c03807921b8e895f8refs/remotes/origin/clubb_silhs_devel5fd1defe00a484aba044b60c03807921b8e895f85fd1defe00a484aba044b60c03807921b8e895f8refs/remotes/origin/clubb_silhs_devel5fd1defe00a484aba044b60c03807921b8e895f85fd1defe00a484aba044b60c03807921b8e895f8refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#15014192742373579cam_BFB_coarse_res_gfortran_test #150150false1505921SUCCESS1734427628903http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/150/mono_flux_limiter.F9099f0cbcb7ebd50f94c8242b4d6b0141c0040070e1734371299000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduChanging a couple loop limits in mono flux limiter. Results do not change. 2024-12-16 11:48:19 -060099f0cbcb7ebd50f94c8242b4d6b0141c0040070eChanging a couple loop limits in mono flux limiter.editmono_flux_limiter.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2false151http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/151/149http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/149/Started by an SCM change149091073d591d52a7f7a78d033e68e7059e62e68bb091073d591d52a7f7a78d033e68e7059e62e68bbrefs/remotes/origin/clubb_silhs_devel091073d591d52a7f7a78d033e68e7059e62e68bb091073d591d52a7f7a78d033e68e7059e62e68bbrefs/remotes/origin/clubb_silhs_devel091073d591d52a7f7a78d033e68e7059e62e68bb091073d591d52a7f7a78d033e68e7059e62e68bbrefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#14920039352373579cam_BFB_coarse_res_gfortran_test #149149false1495844SUCCESS1734168426289http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/149/mono_flux_limiter.F9066962221d214a079b4b9826630a114f6dd1418601734129641000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduRecoded a loop within the mono flux limiter so that it's written in a more convenient manner to allow for easier coding for generalized gridding. Results are bit-for-bit. 2024-12-13 16:40:41 -060066962221d214a079b4b9826630a114f6dd141860Recoded a loop within the mono flux limiter so that it's writteneditmono_flux_limiter.F90mono_flux_limiter.F90c4c819565c782d449a59498d1ba632bb317878321734130983000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduChanged some variable names so that it is clear that, while they contain the word wpxp_, they are actually thermodynamic-level variables. Results are bit-for-bit. 2024-12-13 17:03:03 -0600c4c819565c782d449a59498d1ba632bb31787832Changed some variable names so that it is clear that, while they containeditmono_flux_limiter.F90mono_flux_limiter.F9039ebca243bd00296e6e7ec261e84586ea08036091734132394000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduWithin the mono flux limiter, a thermodynamic-level variable needed to be interpolated to momentum levels so it could be directly compared to wpxp. The results of this change are BIT_CHANGING for the ARM 97, MC3E, and TWP-ICE cases. 2024-12-13 17:26:34 -060039ebca243bd00296e6e7ec261e84586ea0803609Within the mono flux limiter, a thermodynamic-level variable needed toeditmono_flux_limiter.F90mono_flux_limiter.F90016a671fc4b15c32a7169398a2dfd7952ffc5a5f1734133196000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI forgot to add the new variable to the Atlantic Coast Conference statements in the previous commit. 2024-12-13 17:39:56 -0600016a671fc4b15c32a7169398a2dfd7952ffc5a5fI forgot to add the new variable to the Atlantic Coast Conferenceeditmono_flux_limiter.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2false150http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/150/148http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/148/Started by an SCM change1489c53ae3ba216bd73e36c91494fbe7372c018ab1c9c53ae3ba216bd73e36c91494fbe7372c018ab1crefs/remotes/origin/clubb_silhs_devel9c53ae3ba216bd73e36c91494fbe7372c018ab1c9c53ae3ba216bd73e36c91494fbe7372c018ab1crefs/remotes/origin/clubb_silhs_devel9c53ae3ba216bd73e36c91494fbe7372c018ab1c9c53ae3ba216bd73e36c91494fbe7372c018ab1crefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#14818411742373579cam_BFB_coarse_res_gfortran_test #148148false1485672SUCCESS1733563627665http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/148/model_flags.F9052e5a511669d909c3510660bdf8c7dbcc60746601733514208000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comChanged default setting of flag l_min_wp2_from_corr_wx to false (#1216) CLUBB ticket #1165 BIT_CHANGING Changed default setting in configurable_model_flags.in and model_flags.F90 to decrease clipping contribution to `wp2` and increase clipping to `rtp2` and `thl2`. 2024-12-06 13:43:28 -060052e5a511669d909c3510660bdf8c7dbcc6074660Changed default setting of flag l_min_wp2_from_corr_wx to false (#1216)editmodel_flags.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse149http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/149/147http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/147/Started by an SCM change14792c98c95b70877aecebcae635ab76ebaf419d31192c98c95b70877aecebcae635ab76ebaf419d311refs/remotes/origin/clubb_silhs_devel92c98c95b70877aecebcae635ab76ebaf419d31192c98c95b70877aecebcae635ab76ebaf419d311refs/remotes/origin/clubb_silhs_devel92c98c95b70877aecebcae635ab76ebaf419d31192c98c95b70877aecebcae635ab76ebaf419d311refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#14714242302373579cam_BFB_coarse_res_gfortran_test #147147false1475599SUCCESS1733477228755http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/147/advance_clubb_core_module.F90advance_wp2_wp3_module.F904e0d13d0080c598b5b08359a892c9fa1452650ac1733422068000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdded up2 and vp2 to calculation of wp2_min_array (#1215) CLUBB ticket #1165 This is BIT_CHANGING for the cases ARM_97, ATEX, CGILS_S6, GABLS3_NIGHT, LBA, MPACE_B, and TWP_ICE out of the priority cases. These lines of code were added since the fields `u`, `v`, `rt`, and `thl`, and their correlations with `w` should be treated equally. 2024-12-05 12:07:48 -06004e0d13d0080c598b5b08359a892c9fa1452650acAdded up2 and vp2 to calculation of wp2_min_array (#1215)editadvance_clubb_core_module.F90editadvance_wp2_wp3_module.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse148http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/148/146http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/146/Started by an SCM change1461edef295bb1f9651eb0ae1c2398dc4266388fe8d1edef295bb1f9651eb0ae1c2398dc4266388fe8drefs/remotes/origin/clubb_silhs_devel1edef295bb1f9651eb0ae1c2398dc4266388fe8d1edef295bb1f9651eb0ae1c2398dc4266388fe8drefs/remotes/origin/clubb_silhs_devel1edef295bb1f9651eb0ae1c2398dc4266388fe8d1edef295bb1f9651eb0ae1c2398dc4266388fe8drefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#14614085962373579cam_BFB_coarse_res_gfortran_test #146146false1465525SUCCESS1733390829585http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/146/advance_wp2_wp3_module.F9023cb94c98b8d838afbe647e3dfedac0e5dfd4a921733327941000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comReduced the upper bound for wp2_min_array to 1.0 (#1214) CLUBB ticket #1165 This is BIT_CHANGING for at least the cases ARM_97 and TWP_ICE, and likely any other more non-standard cases. This change will prevent the minimum clipping value for wp2 from exploding when l_min_wp2_from_corr_wx=.true. 2024-12-04 09:59:01 -060023cb94c98b8d838afbe647e3dfedac0e5dfd4a92Reduced the upper bound for wp2_min_array to 1.0 (#1214)editadvance_wp2_wp3_module.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse147http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/147/145http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/145/Started by an SCM change145ab7c6f2d2591fed86c6eb2b4efc80e73af2be84bab7c6f2d2591fed86c6eb2b4efc80e73af2be84brefs/remotes/origin/clubb_silhs_develab7c6f2d2591fed86c6eb2b4efc80e73af2be84bab7c6f2d2591fed86c6eb2b4efc80e73af2be84brefs/remotes/origin/clubb_silhs_develab7c6f2d2591fed86c6eb2b4efc80e73af2be84bab7c6f2d2591fed86c6eb2b4efc80e73af2be84brefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#1458474412373579cam_BFB_coarse_res_gfortran_test #145145false1455452SUCCESS1733304430559http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/145/advance_wp2_wp3_module.F90error_code.F90clip_explicit.F90c5312bc035e586768d959bcaf31d092f5bd3cd401733239180000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comLikely non-bit-changing housekeeping (#1213) Non-bit-changing housekeeping regarding wp2 clipping CLUBB ticket #1165 Renamed threshold_array -> wp2_min_array Moved upper clipping of wp2 into clip_variance Added warning outputs where wp2 is hard-clipped Added debugging checks to hole-filling and wp2_min_array clipping Some necessary OpenACC-modifications 2024-12-03 09:19:40 -0600c5312bc035e586768d959bcaf31d092f5bd3cd40Likely non-bit-changing housekeeping (#1213)editadvance_wp2_wp3_module.F90editclip_explicit.F90editerror_code.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse146http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/146/144http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/144/Started by an SCM change144c94bc13905bf56ce6e16ec6910e15bab08392572c94bc13905bf56ce6e16ec6910e15bab08392572refs/remotes/origin/clubb_silhs_develc94bc13905bf56ce6e16ec6910e15bab08392572c94bc13905bf56ce6e16ec6910e15bab08392572refs/remotes/origin/clubb_silhs_develc94bc13905bf56ce6e16ec6910e15bab08392572c94bc13905bf56ce6e16ec6910e15bab08392572refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#1448459912373579cam_BFB_coarse_res_gfortran_test #144144false1445254SUCCESS1732354026617http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/144/output_netcdf.F909ae63da5ddb4c8dc693b928f342f0ac1b937e27e1732270912000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comMulti col output update (#1211) * Multi_col output update to enable averaging over timesteps and outputting with single precision. This replaces the timestep batched output method used before, which was only noticably faster at low column numbers. This is technically BC (edited during merge, PR no longer BC), because the single precision output will be interpretted as different from the current double precision output. * Small cleanup * Script updates * Script update * Script update * Adding capability to output multi_col as double or single precision using new flag l_output_double_prec. * Removing accidentally added file. * Making new jenkins script run single and double precision tests. * Update to jenkins test 2024-11-22 04:21:52 -06009ae63da5ddb4c8dc693b928f342f0ac1b937e27eMulti col output update (#1211)editoutput_netcdf.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse145http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/145/143http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/143/Started by an SCM change143786953e03d2840b3c737e701024aae136eef8942786953e03d2840b3c737e701024aae136eef8942refs/remotes/origin/clubb_silhs_devel786953e03d2840b3c737e701024aae136eef8942786953e03d2840b3c737e701024aae136eef8942refs/remotes/origin/clubb_silhs_devel786953e03d2840b3c737e701024aae136eef8942786953e03d2840b3c737e701024aae136eef8942refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#1437762532373579cam_BFB_coarse_res_gfortran_test #143143false1435171SUCCESS1732094829942http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/143/src/physics/cam/clubb_intr.F90786953e03d2840b3c737e701024aae136eef89421732040359000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking compatible with latest clubb changes 2024-11-19 12:19:19 -0600786953e03d2840b3c737e701024aae136eef8942Making compatible with latest clubb changeseditsrc/physics/cam/clubb_intr.F90githttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse144http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/144/142http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/142/Started by an SCM change1427a187761ac14a1987d6855c084c7987d2bc23a167a187761ac14a1987d6855c084c7987d2bc23a16refs/remotes/origin/clubb_silhs_devel7a187761ac14a1987d6855c084c7987d2bc23a167a187761ac14a1987d6855c084c7987d2bc23a16refs/remotes/origin/clubb_silhs_devel7a187761ac14a1987d6855c084c7987d2bc23a167a187761ac14a1987d6855c084c7987d2bc23a16refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#14214467772373579cam_BFB_coarse_res_gfortran_test #142142false1425078SUCCESS1732008425736http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/142/pdf_utilities.F90output_netcdf.F90advance_clubb_core_module.F90clubb_api_module.F90mono_flux_limiter.F90855c5676670316769f00d7ccfe64a69a6b16d57a1731982903000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comClubb Driver Semi GPUization Part4 (#1209) * Initial GPUization, and testing multi_col output method as single precision. * advance_clubb_core tweaks * Adding radht acc update * Updates * Adding new flags to the mono_flux test to prevent CPU and GPU divergence which breaks it. * Small changes and improvements. * Making new monoflux test lines * Reworking some SILHS GPUization to make it more similar to the GPU code in the rest of clubb. This adds some extra parts that run on GPUs, so it is BIT_CHANGING * Cleanup and comment update * Cleanup * Removing DCUDA flag from compile config scripts to help GPU and CPU results match for silhs cases * Removing accidentally added file. * Updating script * Updating script * Updating script * Updating tolerance in script to handle rico_silhs differences, and hopefully final GPU updates * Small cleanup * Adding option to multi_col diff check script to scale the differences by the field avg. This is only needed (so far) for thlm differences that are slightly too large * Testing gpu lock method * Adding GPU locking to rest of GPU tests. * Small fixes 2024-11-18 20:21:43 -0600855c5676670316769f00d7ccfe64a69a6b16d57aClubb Driver Semi GPUization Part4 (#1209)editmono_flux_limiter.F90editadvance_clubb_core_module.F90editpdf_utilities.F90editoutput_netcdf.F90editclubb_api_module.F90silhs_api_module.F90transform_to_pdf_module.F90latin_hypercube_driver_module.F90474436dd4a94e1167c527cbf7cd07d0189b1a0b41731982903000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comClubb Driver Semi GPUization Part4 (#1209) * Initial GPUization, and testing multi_col output method as single precision. * advance_clubb_core tweaks * Adding radht acc update * Updates * Adding new flags to the mono_flux test to prevent CPU and GPU divergence which breaks it. * Small changes and improvements. * Making new monoflux test lines * Reworking some SILHS GPUization to make it more similar to the GPU code in the rest of clubb. This adds some extra parts that run on GPUs, so it is BIT_CHANGING * Cleanup and comment update * Cleanup * Removing DCUDA flag from compile config scripts to help GPU and CPU results match for silhs cases * Removing accidentally added file. * Updating script * Updating script * Updating script * Updating tolerance in script to handle rico_silhs differences, and hopefully final GPU updates * Small cleanup * Adding option to multi_col diff check script to scale the differences by the field avg. This is only needed (so far) for thlm differences that are slightly too large * Testing gpu lock method * Adding GPU locking to rest of GPU tests. * Small fixes 2024-11-18 20:21:43 -0600474436dd4a94e1167c527cbf7cd07d0189b1a0b4Clubb Driver Semi GPUization Part4 (#1209)edittransform_to_pdf_module.F90editsilhs_api_module.F90editlatin_hypercube_driver_module.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse143http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/143/141http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/141/Started by an SCM change14186df31ff4b0640c119437d4690e9556fa4ff36e586df31ff4b0640c119437d4690e9556fa4ff36e5refs/remotes/origin/clubb_silhs_devel86df31ff4b0640c119437d4690e9556fa4ff36e586df31ff4b0640c119437d4690e9556fa4ff36e5refs/remotes/origin/clubb_silhs_devel86df31ff4b0640c119437d4690e9556fa4ff36e586df31ff4b0640c119437d4690e9556fa4ff36e5refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#14115503822373579cam_BFB_coarse_res_gfortran_test #141141false1414958SUCCESS1731490027323http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/141/transform_to_pdf_module.F90latin_hypercube_driver_module.F908c6a252b73c14a75407b86668c4fb8da3d5f0cf81731438290000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comMulti Column Mirror Test (#1206) * Making fcor_nl to set multi_col version of fcor. This is a BIT_CHANGING bug fix that only affects the extra columns. * Removing async clauses in silhs. * Adding option to silhs to copy the random number pool from the first column to all the others. * Fixing fcor name in arm_97_model.in * Fixing small bug in cases that run non-silhs radiation. * Fixing missing acc statement in atex code * Adding scripts for new test * Script update * Script update * Script update * Script update * Script update * Script update * Test error * Test error * Test error * Script update * Script update * Script update * Script update * Script update * Script updates * Script updates * Final update to script 2024-11-12 13:04:50 -06008c6a252b73c14a75407b86668c4fb8da3d5f0cf8Multi Column Mirror Test (#1206)edittransform_to_pdf_module.F90editlatin_hypercube_driver_module.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse142http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/142/140http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/140/Started by an SCM change140347646e13207db4729db167a1a55fcba7f49f8d2347646e13207db4729db167a1a55fcba7f49f8d2refs/remotes/origin/clubb_silhs_devel347646e13207db4729db167a1a55fcba7f49f8d2347646e13207db4729db167a1a55fcba7f49f8d2refs/remotes/origin/clubb_silhs_devel347646e13207db4729db167a1a55fcba7f49f8d2347646e13207db4729db167a1a55fcba7f49f8d2refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#14015327992373579cam_BFB_coarse_res_gfortran_test #140140false1404849SUCCESS1731403628177http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/140/advance_xp2_xpyp_module.F900c81e032e7c8627c963780496471ffda1f5330071731347440000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduAs part of generalizing the code to work with both an ascending and descending grid, I discovered an issue. The issue occurs in the xp2/xpyp "upwind" turbulent advection code and involves the "sgn_" variables. Ultimately, for other PDFs, I was setting this variable using equations of the form sign( one, variable) which set the value to either 1 or -1 no matter the value of variable. However, for the ADG1 PDF, I was lazy and simply just set the value of sgn_ to be equal to wp3_on_wp2. The issue arose when wp3_on_wp2 had a value of 0, and therefore is neither negative or positive. To rectifiy the issue, all settings of "sgn_" variables now use equations of the form sign( one, variable ). For a vast majority of cases, this change had absolutely no effect on the results and everything stayed bit-for-bit. However, BIT_CHANGING results were detected for CGILS S6, MC3E, and TWP-ICE. 2024-11-11 11:50:40 -06000c81e032e7c8627c963780496471ffda1f533007As part of generalizing the code to work with both an ascending andeditadvance_xp2_xpyp_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2false141http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/141/139http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/139/Started by an SCM change1390f55f58727106c64e4a8067c5af21d1fe476b5780f55f58727106c64e4a8067c5af21d1fe476b578refs/remotes/origin/clubb_silhs_devel0f55f58727106c64e4a8067c5af21d1fe476b5780f55f58727106c64e4a8067c5af21d1fe476b578refs/remotes/origin/clubb_silhs_devel0f55f58727106c64e4a8067c5af21d1fe476b5780f55f58727106c64e4a8067c5af21d1fe476b578refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#13915354232373579cam_BFB_coarse_res_gfortran_test #139139false1394737SUCCESS1731144426386http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/139/advance_clubb_core_module.F903da14a5f677fd439f17935cbb17edcf5d0c408c51731108979000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduMaking a correction to the doubled plus sign from commit a1fcfe8. 2024-11-08 17:36:19 -06003da14a5f677fd439f17935cbb17edcf5d0c408c5Making a correction to the doubled plus sign from commit a1fcfe8.editadvance_clubb_core_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2false140http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/140/138http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/138/Started by an SCM change1388a40d9a512d0da67ffe91c3232300b3b071a4b678a40d9a512d0da67ffe91c3232300b3b071a4b67refs/remotes/origin/clubb_silhs_devel8a40d9a512d0da67ffe91c3232300b3b071a4b678a40d9a512d0da67ffe91c3232300b3b071a4b67refs/remotes/origin/clubb_silhs_devel8a40d9a512d0da67ffe91c3232300b3b071a4b678a40d9a512d0da67ffe91c3232300b3b071a4b67refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#13815093462373579cam_BFB_coarse_res_gfortran_test #138138false1384668SUCCESS1731058027233http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/138/advance_clubb_core_module.F90clubb_api_module.F903e8029ad73ea28d9d444982e17e0f996e7a93cf21731009552000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMoving Lscale from an acc create statement inside clubb to the acc output statement in clubb_api. This is bug fix that is BIT_CHANGING, but only for silhs cases running on the GPU. Also using this to add BIT_CHANGING:aff1bb12551c5b3a8ab1c4d773ef5c17fb96c53b, as that commit was BC but just missing the message. 2024-11-07 13:59:12 -06003e8029ad73ea28d9d444982e17e0f996e7a93cf2Moving Lscale from an acc create statement inside clubb to the acc output statement in clubb_api. This is bug fix that is BIT_CHANGING, but only for silhs cases running on the GPU. Also using this to add BIT_CHANGING:aff1bb12551c5b3a8ab1c4d773ef5c17fb96c53b, as that commit was BC but just missing the message.editadvance_clubb_core_module.F90editclubb_api_module.F90output_netcdf.F90advance_clubb_core_module.F90clubb_api_module.F90calc_pressure.F90c30ea55fd03ba8807e91c53d43e6d9467ce88d361731015610000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comVarious Small Tweaks (#1205) * Batching multicol output. Unfinished, need to make calls_p_out a namelist input and handle the case that it doesn't evenly divide the total number of timesteps. * Pushin column loop into initialize_clubb_variables * Adding explicit loops in main timestepping loop and pushing columns loop into l_calc_thlp2_rad * Various small loop pushes and improvements. * Adding argument to create_multi_col_params.py to add calls_p_out to namelist. * Final little tweaks * Tiny fixes * Changing var name calls_p_out to calls_per_out 2024-11-07 15:40:10 -0600c30ea55fd03ba8807e91c53d43e6d9467ce88d36Various Small Tweaks (#1205)editadvance_clubb_core_module.F90editclubb_api_module.F90editcalc_pressure.F90editoutput_netcdf.F90src/physics/cam/clubb_intr.F9011b0384e1af546126ad7f9fd616498a9d449ff131731015619000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking compatible with latest clubb changes 2024-11-07 15:40:19 -060011b0384e1af546126ad7f9fd616498a9d449ff13Making compatible with latest clubb changeseditsrc/physics/cam/clubb_intr.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse139http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/139/137http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/137/Started by an SCM change13737cd6eb045fc3dc85f0278d1850df125b7da2b7c37cd6eb045fc3dc85f0278d1850df125b7da2b7crefs/remotes/origin/clubb_silhs_devel37cd6eb045fc3dc85f0278d1850df125b7da2b7c37cd6eb045fc3dc85f0278d1850df125b7da2b7crefs/remotes/origin/clubb_silhs_devel37cd6eb045fc3dc85f0278d1850df125b7da2b7c37cd6eb045fc3dc85f0278d1850df125b7da2b7crefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#13720575802373579cam_BFB_coarse_res_gfortran_test #137137false1374593SUCCESS1730798829967http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/137/interpolation.F902bcbfda78b61e1291c1635fa58c7a9a094ca627d1730750376000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comPrescribe Forcings GPUization (#1204) * First bit of prescribe forcings GPUization. Only tested with arm so far. * Cherry-pick merge * Missed file * GPUizing more cases * Rest of cases GPUized * Little more GPUization and fixes. * Bug fix to minloc calculation affecting cases with l_modify_bc_for_cnvg_test=.true., unclear why this is a bug. Also adding ifdef around print in GPU code * Adding Benchmark_cases to OMP conversion list 2024-11-04 13:59:36 -06002bcbfda78b61e1291c1635fa58c7a9a094ca627dPrescribe Forcings GPUization (#1204)editinterpolation.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse138http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/138/136http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/136/Started by an SCM change136fd8e6875fb2af8688784b390081a8e77f4429162fd8e6875fb2af8688784b390081a8e77f4429162refs/remotes/origin/clubb_silhs_develfd8e6875fb2af8688784b390081a8e77f4429162fd8e6875fb2af8688784b390081a8e77f4429162refs/remotes/origin/clubb_silhs_develfd8e6875fb2af8688784b390081a8e77f4429162fd8e6875fb2af8688784b390081a8e77f4429162refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#13613809632373579cam_BFB_coarse_res_gfortran_test #136136false1364250SUCCESS1729844827550http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/136/advance_wp2_wp3_module.F909072b68949f158fab2142de3e9f3159d61bb584e1729779844000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am making the loops for the wp3 ta term (using ADG1 PDF) symmetric. Prior to this, they ran from thermo levels 2 to nzt-2. This change makes them symmetric by running them from 2 to nzt-1. There are no degradations to the results as a result of this change. This change makes it easier to generalize CLUBB's grid for both ascending and descending grid directions. The results of this change are BIT_CHANGING. 2024-10-24 09:24:04 -05009072b68949f158fab2142de3e9f3159d61bb584eI am making the loops for the wp3 ta term (using ADG1 PDF) symmetric.editadvance_wp2_wp3_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2false137http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/137/135http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/135/Started by an SCM change135f6318d0b524cf667ef008f22ef15c3f4e2e10c34f6318d0b524cf667ef008f22ef15c3f4e2e10c34refs/remotes/origin/clubb_silhs_develf6318d0b524cf667ef008f22ef15c3f4e2e10c34f6318d0b524cf667ef008f22ef15c3f4e2e10c34refs/remotes/origin/clubb_silhs_develf6318d0b524cf667ef008f22ef15c3f4e2e10c34f6318d0b524cf667ef008f22ef15c3f4e2e10c34refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#13510645412373579cam_BFB_coarse_res_gfortran_test #135135false1354184SUCCESS1729758428580http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/135/jenkins_tests/cam_BFB_coarse_res_gfortran_test/Jenkinsfile58cafea0f5f9b03d3009fb4168af9d4fd5a709c21729717665000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduThe BFBness tests can now run on any machine. 2024-10-23 16:07:45 -050058cafea0f5f9b03d3009fb4168af9d4fd5a709c2The BFBness tests can now run on any machine.editjenkins_tests/cam_BFB_coarse_res_gfortran_test/Jenkinsfilejenkins_tests/cam_scam_ifort_ncar_plot/Jenkinsfile29585d8f8e138192e8385d6e62bb3515be33d2df1729719091000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduUpdate to work with new plot location in /home/pub 2024-10-23 16:31:31 -050029585d8f8e138192e8385d6e62bb3515be33d2dfUpdate to work with new plot location in /home/pubeditjenkins_tests/cam_scam_ifort_ncar_plot/Jenkinsfilejenkins_tests/cam_scam_ifort_ncar_plot/Jenkinsfilejenkins_tests/cam_plot_scam_ifort/Jenkinsfilef6318d0b524cf667ef008f22ef15c3f4e2e10c341729721474000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduRenaming test and making it use new script location. 2024-10-23 17:11:14 -0500f6318d0b524cf667ef008f22ef15c3f4e2e10c34Renaming test and making it use new script location.addjenkins_tests/cam_plot_scam_ifort/Jenkinsfiledeletejenkins_tests/cam_scam_ifort_ncar_plot/Jenkinsfilegithttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse136http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/136/134http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/134/Started by user Gunther HueblerhueblerGunther Huebler134fd0ac9c976c9d74ec57367f8ff82d0598da11733fd0ac9c976c9d74ec57367f8ff82d0598da11733refs/remotes/origin/clubb_silhs_develfd0ac9c976c9d74ec57367f8ff82d0598da11733fd0ac9c976c9d74ec57367f8ff82d0598da11733refs/remotes/origin/clubb_silhs_develfd0ac9c976c9d74ec57367f8ff82d0598da11733fd0ac9c976c9d74ec57367f8ff82d0598da11733refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#13411126582373579cam_BFB_coarse_res_gfortran_test #134134false1344136SUCCESS1729717588733http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/134/false135http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/135/133http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/133/Started by user Gunther HueblerhueblerGunther Huebler133fd0ac9c976c9d74ec57367f8ff82d0598da11733fd0ac9c976c9d74ec57367f8ff82d0598da11733refs/remotes/origin/clubb_silhs_develfd0ac9c976c9d74ec57367f8ff82d0598da11733fd0ac9c976c9d74ec57367f8ff82d0598da11733refs/remotes/origin/clubb_silhs_develfd0ac9c976c9d74ec57367f8ff82d0598da11733fd0ac9c976c9d74ec57367f8ff82d0598da11733refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#13351862373579cam_BFB_coarse_res_gfortran_test #133133false1334134SUCCESS1729717362661http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/133/false134http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/134/132http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/132/Started by user Gunther HueblerhueblerGunther Huebler132fd0ac9c976c9d74ec57367f8ff82d0598da11733fd0ac9c976c9d74ec57367f8ff82d0598da11733refs/remotes/origin/clubb_silhs_develfd0ac9c976c9d74ec57367f8ff82d0598da11733fd0ac9c976c9d74ec57367f8ff82d0598da11733refs/remotes/origin/clubb_silhs_develfd0ac9c976c9d74ec57367f8ff82d0598da11733fd0ac9c976c9d74ec57367f8ff82d0598da11733refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#13269162373579cam_BFB_coarse_res_gfortran_test #132132false1324120SUCCESS1729717127584http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/132/http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse133http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/133/131http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/131/Started by user Gunther HueblerhueblerGunther Huebler131fd0ac9c976c9d74ec57367f8ff82d0598da11733fd0ac9c976c9d74ec57367f8ff82d0598da11733refs/remotes/origin/clubb_silhs_develfd0ac9c976c9d74ec57367f8ff82d0598da11733fd0ac9c976c9d74ec57367f8ff82d0598da11733refs/remotes/origin/clubb_silhs_develfd0ac9c976c9d74ec57367f8ff82d0598da11733fd0ac9c976c9d74ec57367f8ff82d0598da11733refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#131645632373579cam_BFB_coarse_res_gfortran_test #131131false1314114FAILURE1729708888290http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/131/http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse132http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/132/130http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/130/Started by user Gunther HueblerhueblerGunther Huebler130fd0ac9c976c9d74ec57367f8ff82d0598da11733fd0ac9c976c9d74ec57367f8ff82d0598da11733refs/remotes/origin/clubb_silhs_develfd0ac9c976c9d74ec57367f8ff82d0598da11733fd0ac9c976c9d74ec57367f8ff82d0598da11733refs/remotes/origin/clubb_silhs_develfd0ac9c976c9d74ec57367f8ff82d0598da11733fd0ac9c976c9d74ec57367f8ff82d0598da11733refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#1301309532373579cam_BFB_coarse_res_gfortran_test #130130false1304110FAILURE1729708589686http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/130/http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse131http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/131/129http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/129/Started by user Gunther HueblerhueblerGunther Huebler129fd0ac9c976c9d74ec57367f8ff82d0598da11733fd0ac9c976c9d74ec57367f8ff82d0598da11733refs/remotes/origin/clubb_silhs_develfd0ac9c976c9d74ec57367f8ff82d0598da11733fd0ac9c976c9d74ec57367f8ff82d0598da11733refs/remotes/origin/clubb_silhs_develfd0ac9c976c9d74ec57367f8ff82d0598da11733fd0ac9c976c9d74ec57367f8ff82d0598da11733refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#129120202373579cam_BFB_coarse_res_gfortran_test #129129false1294107FAILURE1729708260724http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/129/jenkins_tests/cam_BFB_coarse_res_gfortran_test/Jenkinsfilefd0ac9c976c9d74ec57367f8ff82d0598da117331729708253000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing name 2024-10-23 13:30:53 -0500fd0ac9c976c9d74ec57367f8ff82d0598da11733Fixing nameeditjenkins_tests/cam_BFB_coarse_res_gfortran_test/Jenkinsfilegithttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerfalse130http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/130/128http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/128/blueStarted by user Gunther HueblerhueblerGunther Huebler17feb8f539398d5ddfa3e0c6ebba294b699a2b2467feb8f539398d5ddfa3e0c6ebba294b699a2b246refs/remotes/origin/clubb_silhs_devel7feb8f539398d5ddfa3e0c6ebba294b699a2b2467feb8f539398d5ddfa3e0c6ebba294b699a2b246refs/remotes/origin/clubb_silhs_devel7feb8f539398d5ddfa3e0c6ebba294b699a2b2467feb8f539398d5ddfa3e0c6ebba294b699a2b246refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#118819802373579cam_BFB_coarse_res_gfortran_test #11false125680SUCCESS1696278678274http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/1/false2http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/2/Build stability: 1 out of the last 5 builds failed.icon-health-60to79health-60to79.png80falseStarted by an SCM change22875e11687f38a46e5fe965b35c51406f23ad8f1dd75e11687f38a46e5fe965b35c51406f23ad8f1ddrefs/remotes/origin/clubb_silhs_devel75e11687f38a46e5fe965b35c51406f23ad8f1dd75e11687f38a46e5fe965b35c51406f23ad8f1ddrefs/remotes/origin/clubb_silhs_devel75e11687f38a46e5fe965b35c51406f23ad8f1dd75e11687f38a46e5fe965b35c51406f23ad8f1ddrefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#22830857122373579cam_BFB_coarse_res_gfortran_test #228228false2283043SUCCESS1775723227859http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/228/CMakeLists.txte441799f4c27da552caf213fc19c5bfb32573c1a1775682381000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRemove line to test python scripts 2026-04-08 16:06:21 -0500e441799f4c27da552caf213fc19c5bfb32573c1aRemove line to test python scriptseditCMakeLists.txtCMakeLists.txt67261c9ca97ea2a8b26cd3bbb2ab3d014ad1b6bf1775696339000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdd blank line to test python scripts 2026-04-08 19:58:59 -050067261c9ca97ea2a8b26cd3bbb2ab3d014ad1b6bfAdd blank line to test python scriptseditCMakeLists.txtgithttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse227http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/227/Started by an SCM change22875e11687f38a46e5fe965b35c51406f23ad8f1dd75e11687f38a46e5fe965b35c51406f23ad8f1ddrefs/remotes/origin/clubb_silhs_devel75e11687f38a46e5fe965b35c51406f23ad8f1dd75e11687f38a46e5fe965b35c51406f23ad8f1ddrefs/remotes/origin/clubb_silhs_devel75e11687f38a46e5fe965b35c51406f23ad8f1dd75e11687f38a46e5fe965b35c51406f23ad8f1ddrefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#22830857122373579cam_BFB_coarse_res_gfortran_test #228228false2283043SUCCESS1775723227859http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/228/CMakeLists.txte441799f4c27da552caf213fc19c5bfb32573c1a1775682381000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRemove line to test python scripts 2026-04-08 16:06:21 -0500e441799f4c27da552caf213fc19c5bfb32573c1aRemove line to test python scriptseditCMakeLists.txtCMakeLists.txt67261c9ca97ea2a8b26cd3bbb2ab3d014ad1b6bf1775696339000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdd blank line to test python scripts 2026-04-08 19:58:59 -050067261c9ca97ea2a8b26cd3bbb2ab3d014ad1b6bfAdd blank line to test python scriptseditCMakeLists.txtgithttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse227http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/227/Started by user Gunther HueblerhueblerGunther Huebler2263c325563d0a2ef8d2ef8803ec4ff7185f46a48a23c325563d0a2ef8d2ef8803ec4ff7185f46a48a2refs/remotes/origin/clubb_silhs_devel3c325563d0a2ef8d2ef8803ec4ff7185f46a48a23c325563d0a2ef8d2ef8803ec4ff7185f46a48a2refs/remotes/origin/clubb_silhs_devel3c325563d0a2ef8d2ef8803ec4ff7185f46a48a23c325563d0a2ef8d2ef8803ec4ff7185f46a48a2refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#22611040462373579cam_BFB_coarse_res_gfortran_test #226226false2262883FAILURE1775591978470http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/226/false227http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/227/225http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/225/Started by an SCM change22875e11687f38a46e5fe965b35c51406f23ad8f1dd75e11687f38a46e5fe965b35c51406f23ad8f1ddrefs/remotes/origin/clubb_silhs_devel75e11687f38a46e5fe965b35c51406f23ad8f1dd75e11687f38a46e5fe965b35c51406f23ad8f1ddrefs/remotes/origin/clubb_silhs_devel75e11687f38a46e5fe965b35c51406f23ad8f1dd75e11687f38a46e5fe965b35c51406f23ad8f1ddrefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#22830857122373579cam_BFB_coarse_res_gfortran_test #228228false2283043SUCCESS1775723227859http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/228/CMakeLists.txte441799f4c27da552caf213fc19c5bfb32573c1a1775682381000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRemove line to test python scripts 2026-04-08 16:06:21 -0500e441799f4c27da552caf213fc19c5bfb32573c1aRemove line to test python scriptseditCMakeLists.txtCMakeLists.txt67261c9ca97ea2a8b26cd3bbb2ab3d014ad1b6bf1775696339000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdd blank line to test python scripts 2026-04-08 19:58:59 -050067261c9ca97ea2a8b26cd3bbb2ab3d014ad1b6bfAdd blank line to test python scriptseditCMakeLists.txtgithttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse227http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/227/Started by an SCM change22875e11687f38a46e5fe965b35c51406f23ad8f1dd75e11687f38a46e5fe965b35c51406f23ad8f1ddrefs/remotes/origin/clubb_silhs_devel75e11687f38a46e5fe965b35c51406f23ad8f1dd75e11687f38a46e5fe965b35c51406f23ad8f1ddrefs/remotes/origin/clubb_silhs_devel75e11687f38a46e5fe965b35c51406f23ad8f1dd75e11687f38a46e5fe965b35c51406f23ad8f1ddrefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#22830857122373579cam_BFB_coarse_res_gfortran_test #228228false2283043SUCCESS1775723227859http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/228/CMakeLists.txte441799f4c27da552caf213fc19c5bfb32573c1a1775682381000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRemove line to test python scripts 2026-04-08 16:06:21 -0500e441799f4c27da552caf213fc19c5bfb32573c1aRemove line to test python scriptseditCMakeLists.txtCMakeLists.txt67261c9ca97ea2a8b26cd3bbb2ab3d014ad1b6bf1775696339000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdd blank line to test python scripts 2026-04-08 19:58:59 -050067261c9ca97ea2a8b26cd3bbb2ab3d014ad1b6bfAdd blank line to test python scriptseditCMakeLists.txtgithttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse227http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/227/Started by user Gunther HueblerhueblerGunther Huebler2263c325563d0a2ef8d2ef8803ec4ff7185f46a48a23c325563d0a2ef8d2ef8803ec4ff7185f46a48a2refs/remotes/origin/clubb_silhs_devel3c325563d0a2ef8d2ef8803ec4ff7185f46a48a23c325563d0a2ef8d2ef8803ec4ff7185f46a48a2refs/remotes/origin/clubb_silhs_devel3c325563d0a2ef8d2ef8803ec4ff7185f46a48a23c325563d0a2ef8d2ef8803ec4ff7185f46a48a2refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#22611040462373579cam_BFB_coarse_res_gfortran_test #226226false2262883FAILURE1775591978470http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/226/false227http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/227/225http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/225/229truefalsefalsefalse