Started by an SCM change16934f8c82cf0e8bcc0ffb84e75090e9397270582dc34f8c82cf0e8bcc0ffb84e75090e9397270582dcrefs/remotes/origin/clubb_silhs_devel34f8c82cf0e8bcc0ffb84e75090e9397270582dc34f8c82cf0e8bcc0ffb84e75090e9397270582dcrefs/remotes/origin/clubb_silhs_devel34f8c82cf0e8bcc0ffb84e75090e9397270582dc34f8c82cf0e8bcc0ffb84e75090e9397270582dcrefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.githttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/cam_BFB_coarse_res_gfortran_test/detail/cam_BFB_coarse_res_gfortran_test/169/artifactshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/cam_BFB_coarse_res_gfortran_test/detail/cam_BFB_coarse_res_gfortran_test/169/changeshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/cam_BFB_coarse_res_gfortran_test/detail/cam_BFB_coarse_res_gfortran_test/169/http://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/cam_BFB_coarse_res_gfortran_test/detail/cam_BFB_coarse_res_gfortran_test/169/testsfalseUpdate sys_admin RepoRun Python Testfalse#16918667482373579cam_BFB_coarse_res_gfortran_test #169169false1698454SUCCESS1743150426278http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/169/stats_clubb_utilities.F90advance_clubb_core_module.F9092f350dce5f7be049b04ad3fbba532c4741c76c71743109355000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comClubb driver upgrades (#1225) * Moving stuff around in preparation for preparation for GPUization * Small modifications, adding explicit loops * Small bug fix and explicit loop additions * Removing ngrdcol dimension from initialize_clubb, essentially reverting changes. * Removing array slicing by using local variables of nzm/nzt dim * GPUization of initialization variables * Removing need for single_col versions of the pdf_params, this (weirdly) saves a huge amount of runtime * Adding comment * Adding 2D version of various routines, including initialize_clubb, but only calling initialize_clubb with 1 column. * Fixes to make work with latest clubb changes * Merging with master 2025-03-27 16:02:35 -050092f350dce5f7be049b04ad3fbba532c4741c76c7Clubb driver upgrades (#1225)editstats_clubb_utilities.F90editadvance_clubb_core_module.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreplyfalseStarted by an SCM change170418af1b5ff11ae2a379e1c859956c5ac0a14e4fb418af1b5ff11ae2a379e1c859956c5ac0a14e4fbrefs/remotes/origin/clubb_silhs_devel418af1b5ff11ae2a379e1c859956c5ac0a14e4fb418af1b5ff11ae2a379e1c859956c5ac0a14e4fbrefs/remotes/origin/clubb_silhs_devel418af1b5ff11ae2a379e1c859956c5ac0a14e4fb418af1b5ff11ae2a379e1c859956c5ac0a14e4fbrefs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#17015893752373579cam_BFB_coarse_res_gfortran_test #170170false1708625SUCCESS1744273629823http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/170/precipitation_fraction.F90setup_clubb_pdf_params.F9055eae9b809c45299075475da2f488ecaac258a831744204547000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comClubb silhs gg (#1239) * I added new subroutine pdf_hydromet_microphys_prep to encompass the code that calls the hydrometeor PDF and then ultimately handles the setup of SILHS sample points when SILHS is in use. * Placeholder subroutine for SILHS grid generalization test. * I have now connected the new subroutine to run_clubb. The results for all cases match bit-for-bit to the previous revision. * Cleaning up from the refactoring of the hydrometeor PDF and SILHS code into a wrapper subroutine. * I'm moving pdf_hydromet_microphys_prep to its own file to avoid circular dependency once it finally needs to be called from the generalized grid test code soon. * Added some code to the SILHS generalized grid test. * Changes to make this a fully functioning grid generalization test for the part of the microphysics code that encompasses setup_pdf_parameters and hydrometeor_mixed_moments. * I have completed the code for the SILHS generalized grid test. * I generalized precipitation fraction for ascending vs. descending grid. * Fixing a bug that I noticed in the precipitation fraction calculation when the component precip frac calculation was set to option 1 (which is currently not the default). * The code should now be successfully grid-generalized for SILHS. The ascending vs descending grid test should work now for all cases. * Updating the core flags .json file to change some of the SILHS flags. * I moved the call to advance_clubb_core_api (the default run option) to the top of the "if" block, ahead of the grid generalization test option that is now in the "else" block. * Adding a new, hardwired constant flag called l_ascending_grid and setting it to true in clubb_driver.F90. * Keeping lines under 100 characters in length. * Making it so the ascending vs. descending grid tests pass for the l_lh_random_start flag. 2025-04-09 08:15:47 -050055eae9b809c45299075475da2f488ecaac258a83Clubb silhs gg (#1239)editprecipitation_fraction.F90editsetup_clubb_pdf_params.F90silhs_api_module.F90latin_hypercube_driver_module.F9022f5d492241112ab03918dbd8041883b5b2ae28b1744204547000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comClubb silhs gg (#1239) * I added new subroutine pdf_hydromet_microphys_prep to encompass the code that calls the hydrometeor PDF and then ultimately handles the setup of SILHS sample points when SILHS is in use. * Placeholder subroutine for SILHS grid generalization test. * I have now connected the new subroutine to run_clubb. The results for all cases match bit-for-bit to the previous revision. * Cleaning up from the refactoring of the hydrometeor PDF and SILHS code into a wrapper subroutine. * I'm moving pdf_hydromet_microphys_prep to its own file to avoid circular dependency once it finally needs to be called from the generalized grid test code soon. * Added some code to the SILHS generalized grid test. * Changes to make this a fully functioning grid generalization test for the part of the microphysics code that encompasses setup_pdf_parameters and hydrometeor_mixed_moments. * I have completed the code for the SILHS generalized grid test. * I generalized precipitation fraction for ascending vs. descending grid. * Fixing a bug that I noticed in the precipitation fraction calculation when the component precip frac calculation was set to option 1 (which is currently not the default). * The code should now be successfully grid-generalized for SILHS. The ascending vs descending grid test should work now for all cases. * Updating the core flags .json file to change some of the SILHS flags. * I moved the call to advance_clubb_core_api (the default run option) to the top of the "if" block, ahead of the grid generalization test option that is now in the "else" block. * Adding a new, hardwired constant flag called l_ascending_grid and setting it to true in clubb_driver.F90. * Keeping lines under 100 characters in length. * Making it so the ascending vs. descending grid tests pass for the l_lh_random_start flag. 2025-04-09 08:15:47 -050022f5d492241112ab03918dbd8041883b5b2ae28bClubb silhs gg (#1239)editsilhs_api_module.F90editlatin_hypercube_driver_module.F90src/physics/cam/subcol_SILHS.F904ee92ccfb630f3f8c3b56d986886b6b114d193b21744205138000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduUpdating CAM-CLUBB for recent changes made to CLUBB-SILHS code. 2025-04-09 08:25:38 -05004ee92ccfb630f3f8c3b56d986886b6b114d193b2Updating CAM-CLUBB for recent changes made to CLUBB-SILHS code.editsrc/physics/cam/subcol_SILHS.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse171http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/171/169http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/169/Started by an SCM change16897aa2c69603ad8dd327196c2190dae80292aa91797aa2c69603ad8dd327196c2190dae80292aa917refs/remotes/origin/clubb_silhs_devel97aa2c69603ad8dd327196c2190dae80292aa91797aa2c69603ad8dd327196c2190dae80292aa917refs/remotes/origin/clubb_silhs_devel97aa2c69603ad8dd327196c2190dae80292aa91797aa2c69603ad8dd327196c2190dae80292aa917refs/remotes/origin/clubb_silhs_develhttps://github.com/larson-group/cam.gitfalse#16814535942373579cam_BFB_coarse_res_gfortran_test #168168false1688259SUCCESS1742804826553http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/168/advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90interpolation.F90advance_windm_edsclrm_module.F90advance_xm_wpxp_module.F90685fa70650398309cae281d0306ed6437762caad1742704780000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comClubb test correct gg (#1237) * Updated the generalized vertical grid test to use the run_bindiff_w_flags_config_core_flags.json file, which performs 18 overall flag configuration file tests and includes almost every configurable model flag found in CLUBB core. * Fixed a bug. This was caught by running the new hybrid PDF after compiling with the gfortran debug compiler script. * The CLUBB code requires l_min_xp2_from_corr_wx and l_enable_relaxed_clipping to always have opposite values. * Finally fixing the bug where Cx_fnc_Richardson needs to be interpolated to thermodynamic levels in order to be used as C11_Skw_fnc. * I fixed an issue with the generalized grid when the expldiff of rtm and thlm is enabled. * The variable gr now needs to be passed into subroutine pvertinterp (which was formerly found in interpolation.F90) in order to generalize the grid. This created a circular dependency, for grid_class references interpolation, and now interpolation needed to reference grid_class in order to use type grid. This road block prevented the model from compiling. I moved subroutine pvertinterp to advance_clubb_core in order to solve the problem. * Moving the flag required editing the delimiters. * I fixed a bug in the generalized grid test code that was resulting in pdf_implicit_coefs_terms scalar variables not being read in correctly for the flipped (descending) grid. * Improved some error handling in clubb_driver.F90 * Fixed an issue where ascending and descending grids were producing results that were not bit-for-bit to each other where centered discretization was used. The issue occurred because 3 or more terms were being added together in opposite orders between ascending and descending grids. This fix ensures terms are added in the same order. * Commiting changes to keep calculation order the same for additions involving at least 3 terms from different vertical levels between ascending and descending grids.` * I removed bugs that were causing failures of the bit-for-bit matching test (at -O0 optimization) between ascending and descending grids. This group of fixes related to the code that calls pdf_closure twice and calls the trapezoidal rule code. * I have fixed the ascending vs. descending grid error for the situation where l_partial_upwind_wp3 is enabled. * I am removing the flag setting of l_mono_flux_lim_thlm to .false. in flag group 15 of the ascending vs. descending grid tests. Problem: Removing the constraints on thlm was causing one case (MC3E) to blow up with a floating point exception in Morrison microphysics. The issue was that a spike caused an extremely cold temperature to be found. There is a line of code that takes the difference between freezing/melting point temperature (273.15 K) and the temperature at the grid level or sample point, multiplies it by constant, and then takes EXP to that product. The large difference between temperature and freezing/melting point, owing to the spike, caused a numerical overflow to occur and the case to fail with a FPE. Solution: There isn't any relevant code found in the monotonic flux limiter that doesn't get tested if l_mono_flux_lim_thlm remains at a setting of .true. The other parts of conditionals are covered by setting l_mono_flux_lim_rtm to .false. The only parts of the code unique to l_mono_flux_lim_thlm are the recording of stats related directly to thlm. Thus, it makes sense to keep l_mono_flux_lim_thlm set to .true. for the stability of the run while turning off the other monotonic flux limiter flags. * Updated the code to use break or return when clubb fatal error is encountered, which is more consistent with the way CLUBB does business now, then simply Fortran stop in place. This also allows the generalized grid test to finally pass for all cases and all flag sets. 2025-03-22 23:39:40 -0500685fa70650398309cae281d0306ed6437762caadClubb test correct gg (#1237)editadvance_clubb_core_module.F90editadvance_windm_edsclrm_module.F90editinterpolation.F90editadvance_xm_wpxp_module.F90editadvance_wp2_wp3_module.F90editadvance_xp2_xpyp_module.F90githttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse169http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/169/167http://carson.math.uwm.edu/jenkins/job/cam_BFB_coarse_res_gfortran_test/167/