BRANCHorigin/masterTESTsam_clubb_pgi_buildStarted by user pbroelspbroelspbroels409687fd653c50c09e15df81168c05b1fdaa1d8f989687fd653c50c09e15df81168c05b1fdaa1d8f98refs/remotes/origin/flag_removal9687fd653c50c09e15df81168c05b1fdaa1d8f989687fd653c50c09e15df81168c05b1fdaa1d8f98refs/remotes/origin/flag_removal79ddfec7a3b139dfeeb8cfdaf78ad0f09d9c36f829ddfec7a3b139dfeeb8cfdaf78ad0f09d9c36f82refs/remotes/origin/stats_testing9ddfec7a3b139dfeeb8cfdaf78ad0f09d9c36f829ddfec7a3b139dfeeb8cfdaf78ad0f09d9c36f82refs/remotes/origin/stats_testing44ac319abf904ec136d6e0b259b9c74de95e4ac85aac319abf904ec136d6e0b259b9c74de95e4ac85arefs/remotes/origin/l_vary_convect_depth_additionac319abf904ec136d6e0b259b9c74de95e4ac85aac319abf904ec136d6e0b259b9c74de95e4ac85arefs/remotes/origin/l_vary_convect_depth_addition3fcb64a792d6631be39938f67e613ded134dd5dcafcb64a792d6631be39938f67e613ded134dd5dcarefs/remotes/origin/changes_to_not_breakfcb64a792d6631be39938f67e613ded134dd5dcafcb64a792d6631be39938f67e613ded134dd5dcarefs/remotes/origin/changes_to_not_break2814edaf741e6d665c0f89a28cfaeca1a95ea693d714edaf741e6d665c0f89a28cfaeca1a95ea693d7refs/remotes/origin/readiopdata_nf9014edaf741e6d665c0f89a28cfaeca1a95ea693d714edaf741e6d665c0f89a28cfaeca1a95ea693d7refs/remotes/origin/readiopdata_nf9024b8d176c11a7fc2b842245dcaec35cd93959f64c9b8d176c11a7fc2b842245dcaec35cd93959f64c9refs/remotes/origin/stats_for_hostb8d176c11a7fc2b842245dcaec35cd93959f64c9b8d176c11a7fc2b842245dcaec35cd93959f64c9refs/remotes/origin/stats_for_host519cb0c7312d9f7525696ee0fb605c83118548dc3d9cb0c7312d9f7525696ee0fb605c83118548dc3drefs/remotes/origin/master9cb0c7312d9f7525696ee0fb605c83118548dc3d9cb0c7312d9f7525696ee0fb605c83118548dc3drefs/remotes/origin/master9cb0c7312d9f7525696ee0fb605c83118548dc3d9cb0c7312d9f7525696ee0fb605c83118548dc3drefs/remotes/origin/masterhttps://github.com/larson-group/sam_clubb.githttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/branch_sam_test/detail/branch_sam_test/51/artifactshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/branch_sam_test/detail/branch_sam_test/51/changeshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/branch_sam_test/detail/branch_sam_test/51/http://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/branch_sam_test/detail/branch_sam_test/51/testsfalseEdit MakefileEdit Default CaseCompilefalse#519927778629branch_sam_test #5151false5115872FAILURE1654629535314http://carson.math.uwm.edu/jenkins/job/branch_sam_test/51/advance_clubb_core_module.F90clubb_api_module.F90advance_xm_wpxp_module.F90ecf50b7dd71b99418e7b378199bec3f540f9ab8f1631318520000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI have passed clubb_params down into advance_xm_wpxp_module.F90. The results from this revision are an exact match to the results from the previous revision for all cases. 2021-09-10 19:02:00 -0500ecf50b7dd71b99418e7b378199bec3f540f9ab8fI have passed clubb_params down into advance_xm_wpxp_module.F90.editclubb_api_module.F90editadvance_xm_wpxp_module.F90editadvance_clubb_core_module.F90pdf_closure_module.F9069a9f213c5189310355d117e82d7047829f4e5501632504823000http://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldjan.gruenenwald@gmail.comSee ticket #958 2021-09-24 12:33:43 -050069a9f213c5189310355d117e82d7047829f4e550See ticketeditpdf_closure_module.F90advance_wp2_wp3_module.F90advance_clubb_core_module.F90b33af07b27883cd48fed63d9fa1557d3b2d4464d1632791429000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI have passed down CLUBB's tunable parameters into advance_wp2_wp3_module.F90. The results in NetCDF output files from this revision are an exact match to the results in NetCDF output files from the previous revision for all cases. 2021-09-27 20:10:29 -0500b33af07b27883cd48fed63d9fa1557d3b2d4464dI have passed down CLUBB's tunable parameters into advance_wp2_wp3_module.F90.editadvance_wp2_wp3_module.F90editadvance_clubb_core_module.F90stats_clubb_utilities.F90advance_clubb_core_module.F90pdf_closure_module.F90f743922fbd8e78ed86270101cb28dbcbb5f5c0f71633009731000http://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldjan.gruenenwald@gmail.comadded some documentation in pdf_close_module.f90 and started writing of w_up_in_cloud to disk 2021-09-30 08:48:51 -0500f743922fbd8e78ed86270101cb28dbcbb5f5c0f7added some documentation in pdf_close_module.f90 and started writing of w_up_in_cloud to diskeditstats_clubb_utilities.F90editpdf_closure_module.F90editadvance_clubb_core_module.F90advance_clubb_core_module.F90advance_xp2_xpyp_module.F90724a970d8e0b0977d63512e25c4462d2600392901633127377000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI passed down CLUBB's tunable parameters into advance_xp2_xpyp_module.F90 for most parameters, excluding C4 and C14. Results are unchanged. 2021-10-01 17:29:37 -0500724a970d8e0b0977d63512e25c4462d260039290I passed down CLUBB's tunable parameters into advance_xp2_xpyp_module.F90editadvance_clubb_core_module.F90editadvance_xp2_xpyp_module.F90advance_clubb_core_module.F90advance_xp2_xpyp_module.F90pdf_closure_module.F909ac836f8b76e39e820b5fecaae969f70a7b39c211633470307000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduPassing down more of CLUBB's tunable parameters. 2021-10-05 16:45:07 -05009ac836f8b76e39e820b5fecaae969f70a7b39c21Passing down more of CLUBB's tunable parameters.editadvance_xp2_xpyp_module.F90editpdf_closure_module.F90editadvance_clubb_core_module.F90advance_clubb_core_module.F907b950575ac2c00c63de42c11f33c459e649af0281633470537000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI accidentally removed an important comment in the previous commit. 2021-10-05 16:48:57 -05007b950575ac2c00c63de42c11f33c459e649af028I accidentally removed an important comment in the previous commit.editadvance_clubb_core_module.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90advance_helper_module.F90835d3d3155f98b2a9b6ba60cb9fa02a94fb7800b1633637871000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduPassing down more CLUBB tunable parameters. Everything is bit-for-bit. 2021-10-07 15:17:51 -0500835d3d3155f98b2a9b6ba60cb9fa02a94fb7800bPassing down more CLUBB tunable parameters.editadvance_helper_module.F90editadvance_clubb_core_module.F90editadvance_xm_wpxp_module.F90pdf_closure_module.F90adg1_adg2_3d_luhar_pdf.F90b65e4cfa8ab2923db015ef2723e3e69071d2c83c1633728172000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduMore passing down CLUBB parameters ... whoop-de-doo 2021-10-08 16:22:52 -0500b65e4cfa8ab2923db015ef2723e3e69071d2c83cMore passing down CLUBB parameters ... whoop-de-dooeditadg1_adg2_3d_luhar_pdf.F90editpdf_closure_module.F90Skx_module.F90diagnose_correlations_module.F90advance_clubb_core_module.F90sfc_varnce_module.F90351cc9aa27aa212ef6cefb48b6c85ec601a993b01633732238000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduPassing down more tunable parameters and removing references to parameters_tunable. Results are bit-for-bit. 2021-10-08 17:30:38 -0500351cc9aa27aa212ef6cefb48b6c85ec601a993b0Passing down more tunable parameters and removing references toeditdiagnose_correlations_module.F90editadvance_clubb_core_module.F90editSkx_module.F90editsfc_varnce_module.F90advance_clubb_core_module.F903c883d2e41e77b89ea758961d5e11ac577a1fa821634055768000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRemoving line to trigger the nightly tests for all repos. 2021-10-12 11:22:48 -05003c883d2e41e77b89ea758961d5e11ac577a1fa82Removing line to trigger the nightly tests for all repos.editadvance_clubb_core_module.F90pdf_closure_module.F90stats_clubb_utilities.F90advance_clubb_core_module.F90stats_variables.F90model_flags.F90stats_zt_module.F9024ab4b2089583ab183efc1963c23fb3153fd20481634058263000http://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldjan.gruenenwald@gmail.comSee respective messages on the issue 958 on date 10/12/2021 2021-10-12 12:04:23 -050024ab4b2089583ab183efc1963c23fb3153fd2048See respective messages on the issue 958 on date 10/12/2021editstats_clubb_utilities.F90editmodel_flags.F90editadvance_clubb_core_module.F90editstats_variables.F90editstats_zt_module.F90editpdf_closure_module.F90configurable_model_flags.ind7b6d7e387a518684ee4f025ee3f1a32fbfda5a61634058263000http://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldjan.gruenenwald@gmail.comSee respective messages on the issue 958 on date 10/12/2021 2021-10-12 12:04:23 -0500d7b6d7e387a518684ee4f025ee3f1a32fbfda5a6See respective messages on the issue 958 on date 10/12/2021editconfigurable_model_flags.inmixing_length.F90parameters_tunable.F90advance_clubb_core_module.F90clubb_api_module.F9040e87490f501202d6d95e7fd2c9c2ccab164ab731634087718000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduHandling the abomination that is lmin. 2021-10-12 20:15:18 -050040e87490f501202d6d95e7fd2c9c2ccab164ab73Handling the abomination that is lmin.editparameters_tunable.F90editclubb_api_module.F90editmixing_length.F90editadvance_clubb_core_module.F90diffusion.F90db7584133b87452bedc0538fed00f339dca49ae31634219703000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comCommented out the k=1 boundary conditions in diffusion_zm_lhs and diffusion_zt_lhs, since these are not currently fed into the final LHS matrix. I included comments to describe why this was done. Results are b4b. See https://github.com/larson-group/clubb/issues/920#issuecomment-942735433. 2021-10-14 08:55:03 -0500db7584133b87452bedc0538fed00f339dca49ae3Commented out the k=1 boundary conditions in diffusion_zm_lhs and diffusion_zt_lhs, since these are not currently fed into the final LHS matrix. I included comments to describe why this was done. Results are b4b.editdiffusion.F90mixing_length.F90advance_clubb_core_module.F90c8cadb5e9708e898ac688db79e1da0ec0ff2ad291634254172000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduPassing tunable parameters into the new tau code. 2021-10-14 18:29:32 -0500c8cadb5e9708e898ac688db79e1da0ec0ff2ad29Passing tunable parameters into the new tau code.editmixing_length.F90editadvance_clubb_core_module.F90advance_wp2_wp3_module.F90mixing_length.F90advance_clubb_core_module.F90clip_explicit.F90e6aa931ab2aa8134704c137db183ec06ee9dfcee1634768140000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduPassed down more parameters. Results are bit-for-bit. 2021-10-20 17:15:40 -0500e6aa931ab2aa8134704c137db183ec06ee9dfceePassed down more parameters. Results are bit-for-bit.editadvance_wp2_wp3_module.F90editadvance_clubb_core_module.F90editmixing_length.F90editclip_explicit.F90advance_clubb_core_module.F90parameters_model.F90d07f2f6c2df3af24ddc90862bc2a656bdd9015d51634771341000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduPassing through more clubb parameters. Bit-for-bit 2021-10-20 18:09:01 -0500d07f2f6c2df3af24ddc90862bc2a656bdd9015d5Passing through more clubb parameters. Bit-for-biteditadvance_clubb_core_module.F90editparameters_model.F90precipitation_fraction.F90setup_clubb_pdf_params.F90clubb_api_module.F90704eedf20b71e552fe32df3633005d50af58c27f1634854899000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduPassing down CLUBB's tunable parameters into the setup_pdf_parameters and precipitation fraction portions of the code. Everything is bit-for-bit. 2021-10-21 17:21:39 -0500704eedf20b71e552fe32df3633005d50af58c27fPassing down CLUBB's tunable parameters into the setup_pdf_parameters andeditclubb_api_module.F90editprecipitation_fraction.F90editsetup_clubb_pdf_params.F90advance_wp2_wp3_module.F90mixing_length.F90advance_xp2_xpyp_module.F90diffusion.F90model_flags.F90advance_xm_wpxp_module.F90advance_windm_edsclrm_module.F902ee6d2a1e31e43bca3e03a406917c4454cb71e671634935501000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comThese updates incorporate some of Shixuan Zhang's changes, including: (1) upwind scheme for the eddy diffusion code, which Shixuan says does not make a huge difference; and (2) l_smooth_heaviside_tau_wpxp flag in the mixing_length.F90 code, which is intended to give smoother results. Both of the flags for these changes are turned off, but these updates are BIT_CHANGING because of some minor changes to the way that factors of rho_ds_* and invrs_rho_ds_* are handled going into the diffusion.F90 subroutines. Most cases look identical in pyplotgen, but sensitive cases like arm_97 and rico look slightly different. These changes were originally in pull request #962, but because of conflicts with the master branch code base that developed, they could not be rebased and merged, so I incorporated them into this new commit. 2021-10-22 15:45:01 -05002ee6d2a1e31e43bca3e03a406917c4454cb71e67These updates incorporate some of Shixuan Zhang's changes, including:editadvance_windm_edsclrm_module.F90editadvance_xp2_xpyp_module.F90editadvance_xm_wpxp_module.F90editadvance_wp2_wp3_module.F90editmixing_length.F90editmodel_flags.F90editdiffusion.F90pdf_closure_module.F90advance_clubb_core_module.F90new_hybrid_pdf_main.F90new_pdf_main.F9062d364561a81e2b878f95a327df36a4ca4bc31491635207177000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduPassing down CLUBB's tunable parameters into the remainder of the PDF subroutines. Everything is bit-for-bit. 2021-10-25 19:12:57 -050062d364561a81e2b878f95a327df36a4ca4bc3149Passing down CLUBB's tunable parameters into the remainder of theeditadvance_clubb_core_module.F90editnew_hybrid_pdf_main.F90editpdf_closure_module.F90editnew_pdf_main.F90advance_clubb_core_module.F90clubb_api_module.F9040315247ab8dc38382642bf30f1d96b329c1304d1635210039000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI passed down the forgotten thlp2_rad_coef tunable parameter. All bit-for-bit. 2021-10-25 20:00:39 -050040315247ab8dc38382642bf30f1d96b329c1304dI passed down the forgotten thlp2_rad_coef tunable parameter.editclubb_api_module.F90editadvance_clubb_core_module.F90diffusion.F9059c90454cd1a93522940f998c123795db4f23b171635271688000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comUncommenting diffusion.F90 k=1 lines again to fix Oracle uninit var test. I've updated the accompanying note to state clearly that the lines have no effect on model output, but I guess we need to keep the lines to avoid uninitialized variables. 2021-10-26 13:08:08 -050059c90454cd1a93522940f998c123795db4f23b17Uncommenting diffusion.F90 k=1 lines again to fix Oracle uninit var test. I've updated the accompanying note to state clearly that the lines have no effect on model output, but I guess we need to keep the lines to avoid uninitialized variables.editdiffusion.F90advance_xm_wpxp_module.F9024592ec9879d2c704c4d7301c8d18c794f2ff7441635291046000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am passing down the forgotten parameter, altitude threshold, in advance_xm_wpxp_module.F90. 2021-10-26 18:30:46 -050024592ec9879d2c704c4d7301c8d18c794f2ff744I am passing down the forgotten parameter, altitude threshold, ineditadvance_xm_wpxp_module.F90SRC/SGS_CLUBB/clubb_sgs.F900fac7162e55c6478ec570b1b4186d0eb51be59831635369322000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comUpdating for changes to CLUBB. See https://github.com/larson-group/clubb/pull/968. 2021-10-27 16:15:22 -05000fac7162e55c6478ec570b1b4186d0eb51be5983Updating for changes to CLUBB. See https://github.com/larson-group/clubb/pull/968.editSRC/SGS_CLUBB/clubb_sgs.F90advance_wp2_wp3_module.F90advance_clubb_core_module.F90model_flags.F90clubb_api_module.F90bda6b42375dfc09907e7f9b37719b0d149f456711635369371000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comAdding code wrapped in a flag (l_use_tke_in_K_dfsn) to use u_i'u_i' in the wp2 and wp3 eddy diffusion terms, instead of just wp2 or wp3. Relevant to CLUBB issue #920. Results are b4b when the flag is turned off, which it currently is. 2021-10-27 16:16:11 -0500bda6b42375dfc09907e7f9b37719b0d149f45671Adding code wrapped in a flag (l_use_tke_in_K_dfsn) to use u_i'u_i' in the wp2 and wp3 eddy diffusion terms, instead of just wp2 or wp3. Relevant to CLUBB issue #920.editadvance_wp2_wp3_module.F90editmodel_flags.F90editadvance_clubb_core_module.F90editclubb_api_module.F90configurable_model_flags.in12ac897f71f006b5a4d58ec4184ff58548edafd71635369371000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comAdding code wrapped in a flag (l_use_tke_in_K_dfsn) to use u_i'u_i' in the wp2 and wp3 eddy diffusion terms, instead of just wp2 or wp3. Relevant to CLUBB issue #920. Results are b4b when the flag is turned off, which it currently is. 2021-10-27 16:16:11 -050012ac897f71f006b5a4d58ec4184ff58548edafd7Adding code wrapped in a flag (l_use_tke_in_K_dfsn) to use u_i'u_i' in the wp2 and wp3 eddy diffusion terms, instead of just wp2 or wp3. Relevant to CLUBB issue #920.editconfigurable_model_flags.inadvance_wp2_wp3_module.F90advance_clubb_core_module.F90model_flags.F90clubb_api_module.F90fecf90bda798d6330f0c3982e5f24ef5dce274a31635369371000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comUpdates as requested to the l_use_tke_in_K_dfsn code: - The name of the flag is changed to l_use_tke_in_wp2_wp3_K_dfsn - Comments are added to the main pieces of code in advance_wp2_wp3 - The flag is added to the "compatible_r8029" configurable flags file. See this comment https://github.com/larson-group/clubb/issues/920#issuecomment-931446401 and following for more information. 2021-10-27 16:16:11 -0500fecf90bda798d6330f0c3982e5f24ef5dce274a3Updates as requested to the l_use_tke_in_K_dfsn code:editadvance_wp2_wp3_module.F90editclubb_api_module.F90editmodel_flags.F90editadvance_clubb_core_module.F90configurable_model_flags.in6cc56f4656c364acfd417735166741345141a0491635369371000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comUpdates as requested to the l_use_tke_in_K_dfsn code: - The name of the flag is changed to l_use_tke_in_wp2_wp3_K_dfsn - Comments are added to the main pieces of code in advance_wp2_wp3 - The flag is added to the "compatible_r8029" configurable flags file. See this comment https://github.com/larson-group/clubb/issues/920#issuecomment-931446401 and following for more information. 2021-10-27 16:16:11 -05006cc56f4656c364acfd417735166741345141a049Updates as requested to the l_use_tke_in_K_dfsn code:editconfigurable_model_flags.inoutput_netcdf.F90stats_clubb_utilities.F90parameters_tunable.F90clubb_api_module.F9048d34a44dac4e6c069b8edf7484da102a7b3e03c1635542624000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am committing the final stage of the "pass-down params" project. The results are bit-for-bit identical. 2021-10-29 16:23:44 -050048d34a44dac4e6c069b8edf7484da102a7b3e03cI am committing the final stage of the "pass-down params" project.editstats_clubb_utilities.F90editoutput_netcdf.F90editclubb_api_module.F90editparameters_tunable.F90silhs_api_module.F90latin_hypercube_driver_module.F90output_2D_samples_module.F90a59d8a9d971fa58d96ca0c7c0e3a8999903394011635542624000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am committing the final stage of the "pass-down params" project. The results are bit-for-bit identical. 2021-10-29 16:23:44 -0500a59d8a9d971fa58d96ca0c7c0e3a899990339401I am committing the final stage of the "pass-down params" project.editlatin_hypercube_driver_module.F90editoutput_2D_samples_module.F90editsilhs_api_module.F90mixing_length.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90e21f33631a9962fc7af096d0f7c4a7a3f6ff021b1635542673000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comAdding an option to use invrs_tau_N2_iso for C4 terms. The same invrs_tau had been used for C4 and C14 terms, so some adjustments had to be made to separate them out (this was started with an earlier commit: https://github.com/larson-group/clubb/commit/ef3be1b1378bcd1a447f3866c9f88f8cc4764233). The flag is currently set to false so results will be b4b. See also the discussion here: https://github.com/larson-group/clubb/issues/920#issuecomment-920338746 and following comments. 2021-10-29 16:24:33 -0500e21f33631a9962fc7af096d0f7c4a7a3f6ff021bAdding an option to use invrs_tau_N2_iso for C4 terms. The same invrs_tau had been used for C4 and C14 terms, so some adjustments had to be made to separate them out (this was started with an earlier commit: https://github.com/larson-group/clubb/commit/ef3be1b1378bcd1a447f3866c9f88f8cc4764233). The flag is currently set to false so results will be b4b.editadvance_clubb_core_module.F90editmixing_length.F90editadvance_wp2_wp3_module.F90editadvance_xp2_xpyp_module.F90advance_wp2_wp3_module.F90575d6fe14ed80295cce4f30a51ff3d6aac83b5ee1635542673000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comRenaming invrs_tau_zt and invrs_tauw3t to "invrs_tau_wp3_zt" in advance_wp2_wp3 to avoid confusion. This variable is only used for the wp3 C8 term, so one consistent name is simpler, and the name "invrs_tau_zt" is already used by another variable in advance_clubb_core. 2021-10-29 16:24:33 -0500575d6fe14ed80295cce4f30a51ff3d6aac83b5eeRenaming invrs_tau_zt and invrs_tauw3t to "invrs_tau_wp3_zt" in advance_wp2_wp3 to avoid confusion. This variable is only used for the wp3 C8 term, so one consistent name is simpler, and the name "invrs_tau_zt" is already used by another variable in advance_clubb_core.editadvance_wp2_wp3_module.F90mixing_length.F90b1a5dc605454ba0bd6ce90b50c1b1c4e5238daa21635542673000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comAdding comments for clarity. 2021-10-29 16:24:33 -0500b1a5dc605454ba0bd6ce90b50c1b1c4e5238daa2Adding comments for clarity.editmixing_length.F90clubb_api_module.F903cc2a48057cff47763a8de0fc7a9c2d6bd1717821635637985000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI forgot to add this necessary subroutine call to the clubb API. 2021-10-30 18:53:05 -05003cc2a48057cff47763a8de0fc7a9c2d6bd171782I forgot to add this necessary subroutine call to the clubb API.editclubb_api_module.F90advance_wp2_wp3_module.F9043b0e9b176c2c5f8d2537b61e1f1781a147878961635789347000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comFixing a minor accounting bug related to the changes in https://github.com/larson-group/clubb/commit/987d63de489d2baa09ad6e1538b2c6dbb7551690. There was some overcounting of the relevant terms. Results are b4b since the l_use_tke_in_wp2_wp3_K_dfsn flag is false. 2021-11-01 12:55:47 -050043b0e9b176c2c5f8d2537b61e1f1781a14787896Fixing a minor accounting bug related to the changes in https://github.com/larson-group/clubb/commit/987d63de489d2baa09ad6e1538b2c6dbb7551690. There was some overcounting of the relevant terms.editadvance_wp2_wp3_module.F90SRC/SGS_CLUBB/clubb_sgs.F90a5d105911dbaf99c23f15c84813faefa228e124b1635839487000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduThis commit fixes SAM to work with the new version of CLUBB. 2021-11-02 02:51:27 -0500a5d105911dbaf99c23f15c84813faefa228e124bThis commit fixes SAM to work with the new version of CLUBB.editSRC/SGS_CLUBB/clubb_sgs.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90diffusion.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90clubb_api_module.F90parameters_tunable.F90advance_windm_edsclrm_module.F900c99971894e34f471bb13a0608799da3e26fd75b1636150605000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI have turned the nu_vert_res_dep family of variables into a derived type and that variable is now being passed throughout the CLUBB code, rather than accessing variables through a USE statement. Everything is 100% bit-for-bit! 2021-11-05 17:16:45 -05000c99971894e34f471bb13a0608799da3e26fd75bI have turned the nu_vert_res_dep family of variables into a derivededitadvance_clubb_core_module.F90editparameters_tunable.F90editadvance_wp2_wp3_module.F90editadvance_xm_wpxp_module.F90editadvance_windm_edsclrm_module.F90editdiffusion.F90editclubb_api_module.F90editadvance_xp2_xpyp_module.F90SRC/SGS_CLUBB/clubb_sgs.F9025d34344a660518cb6b16d03fa92fa257c2461781636190571000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduUpdating for changes to CLUBB code. 2021-11-06 04:22:51 -050025d34344a660518cb6b16d03fa92fa257c246178Updating for changes to CLUBB code.editSRC/SGS_CLUBB/clubb_sgs.F90pdf_closure_module.F90stats_zt_module.F905aad62fb6b44998c8eeea4e274d53e9f5b6fda2a1636491816000http://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldjan.gruenenwald@gmail.comAdded sam file name to DYCOMS_RF02_DO case, fixed the clipping in calc_w_up_in_cloud in pdf_closure_module.f90, and changed long name of w_up_in_cloud in stats_zt_module.f90 2021-11-09 15:03:36 -06005aad62fb6b44998c8eeea4e274d53e9f5b6fda2aAdded sam file name to DYCOMS_RF02_DO case, fixed the clipping in calc_w_up_in_cloud in pdf_closure_module.f90, and changed long name of w_up_in_cloud in stats_zt_module.f90editpdf_closure_module.F90editstats_zt_module.F90advance_clubb_core_module.F90model_flags.F90pdf_closure_module.F900918704e4ca667f2dd901df9481fcab6d04ad5591636651886000http://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldjan.gruenenwald@gmail.comResolved any issues in the pull request. See https://github.com/larson-group/clubb/pull/970 for details 2021-11-11 11:31:26 -06000918704e4ca667f2dd901df9481fcab6d04ad559Resolved any issues in the pull request. See https://github.com/larson-group/clubb/pull/970 for detailseditmodel_flags.F90editpdf_closure_module.F90editadvance_clubb_core_module.F90configurable_model_flags.ina197aba39c147a59b766de0ffa740bb4924a4b671636651886000http://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldjan.gruenenwald@gmail.comResolved any issues in the pull request. See https://github.com/larson-group/clubb/pull/970 for details 2021-11-11 11:31:26 -0600a197aba39c147a59b766de0ffa740bb4924a4b67Resolved any issues in the pull request. See https://github.com/larson-group/clubb/pull/970 for detailseditconfigurable_model_flags.inpdf_closure_module.F9081d326f9c04198f2635a6b56b25bc395da7414351636664054000http://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldjan.gruenenwald@gmail.comIncluded a check in pdf_closure_module.f90 to check if flag for iw_up_in_cloud is set. Removed iw_up_in_cloud from standard_stats.in to prevent binary diffs in CLUBB output files after merge 2021-11-11 14:54:14 -060081d326f9c04198f2635a6b56b25bc395da741435Included a check in pdf_closure_module.f90 to check if flag for iw_up_in_cloud is set. Removed iw_up_in_cloud from standard_stats.in to prevent binary diffs in CLUBB output files after mergeeditpdf_closure_module.F90pdf_closure_module.F90dc3c4b8f58acb3383731109218706676f789be071636664205000http://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldjan.gruenenwald@gmail.comfixed a typo in pdf_closure_module.f90, line 1284 2021-11-11 14:56:45 -0600dc3c4b8f58acb3383731109218706676f789be07fixed a typo in pdf_closure_module.f90, line 1284editpdf_closure_module.F90pdf_closure_module.F903c5029210448e2a9df59b5757f5cd952d8ab41881636667154000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comSee ticket #958 2021-11-11 15:45:54 -06003c5029210448e2a9df59b5757f5cd952d8ab4188See ticketeditpdf_closure_module.F90stats_clubb_utilities.F90pdf_closure_module.F90a75256d61b53e5e09ec2e386790c89d4e51f04721636667154000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comadded some documentation in pdf_close_module.f90 and started writing of w_up_in_cloud to disk 2021-11-11 15:45:54 -0600a75256d61b53e5e09ec2e386790c89d4e51f0472added some documentation in pdf_close_module.f90 and started writing of w_up_in_cloud to diskeditstats_clubb_utilities.F90editpdf_closure_module.F90pdf_closure_module.F90advance_clubb_core_module.F90stats_variables.F90stats_clubb_utilities.F90model_flags.F90stats_zt_module.F90a83e91f008656f68d7535574cd90be52d82dd50f1636667154000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comSee respective messages on the issue 958 on date 10/12/2021 2021-11-11 15:45:54 -0600a83e91f008656f68d7535574cd90be52d82dd50fSee respective messages on the issue 958 on date 10/12/2021editadvance_clubb_core_module.F90editstats_variables.F90editstats_clubb_utilities.F90editstats_zt_module.F90editmodel_flags.F90editpdf_closure_module.F90pdf_closure_module.F90stats_zt_module.F900ba99cd44f06718d995fadd8eacb1b6b191c8cf51636667154000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comAdded sam file name to DYCOMS_RF02_DO case, fixed the clipping in calc_w_up_in_cloud in pdf_closure_module.f90, and changed long name of w_up_in_cloud in stats_zt_module.f90 2021-11-11 15:45:54 -06000ba99cd44f06718d995fadd8eacb1b6b191c8cf5Added sam file name to DYCOMS_RF02_DO case, fixed the clipping in calc_w_up_in_cloud in pdf_closure_module.f90, and changed long name of w_up_in_cloud in stats_zt_module.f90editstats_zt_module.F90editpdf_closure_module.F90advance_clubb_core_module.F90model_flags.F90pdf_closure_module.F90f4f26820fd4d03cd818e862b342716e11ea0c6731636667154000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comResolved any issues in the pull request. See https://github.com/larson-group/clubb/pull/970 for details 2021-11-11 15:45:54 -0600f4f26820fd4d03cd818e862b342716e11ea0c673Resolved any issues in the pull request. See https://github.com/larson-group/clubb/pull/970 for detailseditpdf_closure_module.F90editadvance_clubb_core_module.F90editmodel_flags.F90pdf_closure_module.F902b90c415701478f497ef1b01769bff21fd75e46a1636667154000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comIncluded a check in pdf_closure_module.f90 to check if flag for iw_up_in_cloud is set. Removed iw_up_in_cloud from standard_stats.in to prevent binary diffs in CLUBB output files after merge 2021-11-11 15:45:54 -06002b90c415701478f497ef1b01769bff21fd75e46aIncluded a check in pdf_closure_module.f90 to check if flag for iw_up_in_cloud is set. Removed iw_up_in_cloud from standard_stats.in to prevent binary diffs in CLUBB output files after mergeeditpdf_closure_module.F90configurable_model_flags.in3c42c31e79e3ab259ae03881eb59b2b6caece01e1636667154000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comSee respective messages on the issue 958 on date 10/12/2021 2021-11-11 15:45:54 -06003c42c31e79e3ab259ae03881eb59b2b6caece01eSee respective messages on the issue 958 on date 10/12/2021editconfigurable_model_flags.inpdf_closure_module.F90e235fe78eae6527a511973ecdc46aaa4cb2b23791636667154000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comfixed a typo in pdf_closure_module.f90, line 1284 2021-11-11 15:45:54 -0600e235fe78eae6527a511973ecdc46aaa4cb2b2379fixed a typo in pdf_closure_module.f90, line 1284editpdf_closure_module.F90configurable_model_flags.inb18ed8a537bcfb9a32b5235afe63f128da5c93371636667154000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comResolved any issues in the pull request. See https://github.com/larson-group/clubb/pull/970 for details 2021-11-11 15:45:54 -0600b18ed8a537bcfb9a32b5235afe63f128da5c9337Resolved any issues in the pull request. See https://github.com/larson-group/clubb/pull/970 for detailseditconfigurable_model_flags.inadvance_clubb_core_module.F90clubb_api_module.F90a3f3633376a9a95a1ddbab690425c6b71a4efbff1637038777000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduPassing w_up_in_cloud out of advance_clubb_core 2021-11-15 22:59:37 -0600a3f3633376a9a95a1ddbab690425c6b71a4efbffPassing w_up_in_cloud out of advance_clubb_coreeditadvance_clubb_core_module.F90editclubb_api_module.F90SRC/SGS_CLUBB/clubb_sgs.F90692c17a0f1638467f2b4310665cd61560ba449581637043428000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduUpdating SAM-CLUBB for the most recent version of CLUBB. 2021-11-16 00:17:08 -0600692c17a0f1638467f2b4310665cd61560ba44958Updating SAM-CLUBB for the most recent version of CLUBB.editSRC/SGS_CLUBB/clubb_sgs.F90SRC/statistics.F9072a614957aa439ae75dbf8be6b4870a7a4c48c4b1638288287000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comAdding some additional statistics output relevant to Stephens Larson Mironov 2022 paper. 2021-11-30 09:04:47 -070072a614957aa439ae75dbf8be6b4870a7a4c48c4bAdding some additional statistics output relevant to Stephens Larson Mironov 2022 paper.editSRC/statistics.F90stats_variables.F90e1572555370199b4fe0abf791462f1a0830a22f71638465215000http://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldjan.gruenenwald@gmail.comfixed compiler warning regarding w_up_in_cloud 2021-12-02 11:13:35 -0600e1572555370199b4fe0abf791462f1a0830a22f7fixed compiler warning regarding w_up_in_cloudeditstats_variables.F90advance_clubb_core_module.F90fcf74be3a201e5043cabaad104cc37cdbb8c0e9d1638567586000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRemove clipping from a3_coef. In principle, removing the clipping should reduce noise. In practice, it makes rico noiser but mpace_b less noisy. It also allows twp_ice to run to completion with the gfortran compiler. This commit is BIT_CHANGING. For #965. 2021-12-03 15:39:46 -0600fcf74be3a201e5043cabaad104cc37cdbb8c0e9dRemove clipping from a3_coef.editadvance_clubb_core_module.F90RUNDATA/lstce4f8f435853b2fcf1f50006e5bf3d4a915088351639686876000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comUpdating RUNDATA/lst so that the new stats I added in https://github.com/larson-group/sam_clubb/commit/72a614957aa439ae75dbf8be6b4870a7a4c48c4b will be output. 2021-12-16 13:34:36 -0700ce4f8f435853b2fcf1f50006e5bf3d4a91508835Updating RUNDATA/lst so that the new stats I added in https://github.com/larson-group/sam_clubb/commit/72a614957aa439ae75dbf8be6b4870a7a4c48c4b will be output.editRUNDATA/lstRUNDATA/lstSRC/statistics.F90db3e00a09cb5c0503e1bf3a728603fe690cb9a3e1639774698000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comUpdates relevant to reproducing results for Stephens, Larson, and Mironov 2022. 2021-12-17 14:58:18 -0600db3e00a09cb5c0503e1bf3a728603fe690cb9a3eUpdates relevant to reproducing results for Stephens, Larson, and Mironov 2022.editRUNDATA/lsteditSRC/statistics.F90SRC/press_grad.F90SRC/statistics.F90c1a85d4d5fddee4909d0568c4ae0df3c51b07f911639774698000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comAdding comments to described SAM's pressure variable. 2021-12-17 14:58:18 -0600c1a85d4d5fddee4909d0568c4ae0df3c51b07f91Adding comments to described SAM's pressure variable.editSRC/press_grad.F90editSRC/statistics.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90advance_windm_edsclrm_module.F90fe10a3988ec9c5ae38f9a6521364e5114303dc971639784185000http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffin31553422+bmg929@users.noreply.github.comThese changes allow you to call the 4 clubb "advance" subroutines in any order that you want to try. In the default order (where the order is the same as found in the current version of the CLUBB master), results are bit-for-bit when compared to CLUBB master. 2021-12-17 17:36:25 -0600fe10a3988ec9c5ae38f9a6521364e5114303dc97These changes allow you to call the 4 clubb "advance" subroutines in anyeditadvance_clubb_core_module.F90editadvance_xm_wpxp_module.F90editadvance_windm_edsclrm_module.F90advance_clubb_core_module.F90da7e393336c65553c3897fdb66f276cc70ba5a581639784185000http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffin31553422+bmg929@users.noreply.github.comPlacing the order variables in a nice, convenient place for testing use. 2021-12-17 17:36:25 -0600da7e393336c65553c3897fdb66f276cc70ba5a58Placing the order variables in a nice, convenient place for testing use.editadvance_clubb_core_module.F90advance_clubb_core_module.F908aae767c4fcc474647d6b76867a06416de8057bd1639784185000http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffin31553422+bmg929@users.noreply.github.comI reordered advance_clubb_core so that the "Advance xp3" (which is a basic calculation of xp3 by the ansatz by default) section is moved out of the way of the "advance loop" to a point that is after advance_windm_edsclrm (or whatever will be called last in the advance loop. This change does not alter the default results. Everything is still bit-for-bit. 2021-12-17 17:36:25 -06008aae767c4fcc474647d6b76867a06416de8057bdI reordered advance_clubb_core so that the "Advance xp3" (which is aeditadvance_clubb_core_module.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90clubb_api_module.F9089ceef8b3be53379b14beba84d90cef1f9ec9a391639784185000http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffin31553422+bmg929@users.noreply.github.comI am committing the idiot-proofing code that forces l_min_xp2_from_corr_wx and l_enable_relaxed_clipping to have opposite values (one must be true and the other must be false). In this commit, both are set to true, so the code will produce an exception. 2021-12-17 17:36:25 -060089ceef8b3be53379b14beba84d90cef1f9ec9a39I am committing the idiot-proofing code that forces l_min_xp2_from_corr_wxeditadvance_xm_wpxp_module.F90editadvance_clubb_core_module.F90editclubb_api_module.F90advance_clubb_core_module.F9051776de85578ab39a37d41b3a28771e66d58657f1639784185000http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffin31553422+bmg929@users.noreply.github.comI am indenting the portion of the code where the advance subroutines are located within the new ordering loop. 2021-12-17 17:36:25 -060051776de85578ab39a37d41b3a28771e66d58657fI am indenting the portion of the code where the advance subroutineseditadvance_clubb_core_module.F90advance_clubb_core_module.F909ffac7f447029ffd2f8bac3d59fb93019127171e1639784185000http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffin31553422+bmg929@users.noreply.github.comTemporarily commenting out the idiot proofing in order to run some tests ... The results from this branch are still bit-for-bit with the master branch. 2021-12-17 17:36:25 -06009ffac7f447029ffd2f8bac3d59fb93019127171eTemporarily commenting out the idiot proofing in order to run some tests ...editadvance_clubb_core_module.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90c587754da66182880513b7c16ccc23c289952ab51639784501000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduNow official reinstating the idiot-proofing and turning off the l_enable_relaxed_clipping flag. This commit is BIT_CHANGING 2021-12-17 17:41:41 -0600c587754da66182880513b7c16ccc23c289952ab5Now official reinstating the idiot-proofing and turning off theeditadvance_xm_wpxp_module.F90editadvance_clubb_core_module.F90advance_clubb_core_module.F90b778226f990c7e852735312d0123c76452338a211639787077000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am committing some idiot proofing in regards to the advance subroutines ordering. No index can have a value of less than 1, greater than 4, and no index can have the same value as any other index. Each adv routine order index must have a unique value. 2021-12-17 18:24:37 -0600b778226f990c7e852735312d0123c76452338a21I am committing some idiot proofing in regards to the advanceeditadvance_clubb_core_module.F90SRC/SGS_CLUBB/clubb_sgs.F90a39e2f8ef110b0a6f71e3c538e1dcae0beceb21a1639788179000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduUpdated for the latest version of CLUBB. 2021-12-17 18:42:59 -0600a39e2f8ef110b0a6f71e3c538e1dcae0beceb21aUpdated for the latest version of CLUBB.editSRC/SGS_CLUBB/clubb_sgs.F90DOC/SAM_WP2_WP3_BUDGETS.pdfcb4f848bbbd8e37282dca8c7635ee17689b4ee101640019408000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comAdding new file to describe in detail SAM's wp2 and wp3 budgets. 2021-12-20 10:56:48 -0600cb4f848bbbd8e37282dca8c7635ee17689b4ee10Adding new file to describe in detail SAM's wp2 and wp3 budgets.addDOC/SAM_WP2_WP3_BUDGETS.pdfSRC/statistics.F90c2520449444aa3a09557635880b93d43207f3b041640032211000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comFixing an array definition issue that created a problem with the PGI compiler. 2021-12-20 14:30:11 -0600c2520449444aa3a09557635880b93d43207f3b04Fixing an array definition issue that created a problem with the PGIeditSRC/statistics.F90advance_clubb_core_module.F90clubb_api_module.F901e234f56b4722f109ec9d657776244a94dadfc181640706464000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduUpdating CLUBB to pass uprcp and vprcp into and out of advance_clubb_core. 2021-12-28 09:47:44 -06001e234f56b4722f109ec9d657776244a94dadfc18Updating CLUBB to pass uprcp and vprcp into and out of advance_clubb_core.editclubb_api_module.F90editadvance_clubb_core_module.F90advance_clubb_core_module.F90aa0da18281105ee85a148af1640952342bc058ec1640706663000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduNow that uprcp and vprcp have been passed through advance_clubb_core, I can get rid of this idiot-proofing code that stops the run when l_predict_upwp_vpwp is enabled and the PDF is in the "post" position. 2021-12-28 09:51:03 -0600aa0da18281105ee85a148af1640952342bc058ecNow that uprcp and vprcp have been passed through advance_clubb_core,editadvance_clubb_core_module.F90advance_clubb_core_module.F90advance_wp2_wp3_module.F90clubb_api_module.F90af8d23225e3393b52c07fbe123f01444d14124f01640825295000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am adding more arguments to the argument list for advance_clubb_core so that the model now runs with the PDF in the post position. Result from this change are still bit-for-bit. 2021-12-29 18:48:15 -0600af8d23225e3393b52c07fbe123f01444d14124f0I am adding more arguments to the argument list for advance_clubb_coreeditadvance_clubb_core_module.F90editadvance_wp2_wp3_module.F90editclubb_api_module.F90SRC/SGS_CLUBB/clubb_sgs.F90SRC/SGS_CLUBB/clubbvars.F907cd8548fbce344a5f4ce9feca89d5282962e4c011640826398000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduUpdating SAM-CLUBB for the latest additions to the call to advance_clubb_core_api 2021-12-29 19:06:38 -06007cd8548fbce344a5f4ce9feca89d5282962e4c01Updating SAM-CLUBB for the latest additions to the call to advance_clubb_core_apieditSRC/SGS_CLUBB/clubb_sgs.F90editSRC/SGS_CLUBB/clubbvars.F90MakefileSRC/SGS_CLUBB/clubb_sgs.F90867b23c54ae21cd8d0adcf5a44925ef3c80a5ca41641504133000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduFixing the sam_clubb_silhs_gfortran build by locally making wp3 the same type (real r4) as the other variables (wp2_zt, etc.) in CLUBB's calls to MPI-ish stuff. Also adding the -fallow-argument-mismatch flag to handle SAM's issues with type mismatches in MPI calls within the bowels of SAM. 2022-01-06 15:22:13 -0600867b23c54ae21cd8d0adcf5a44925ef3c80a5ca4Fixing the sam_clubb_silhs_gfortran build by locally making wp3 theeditSRC/SGS_CLUBB/clubb_sgs.F90editMakefilemodel_flags.F90af2e320388670ca0a57e2f176c1bc5d627b9098d1641839832000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comInsert print about overwriting default flags with namelist values 2022-01-10 12:37:12 -0600af2e320388670ca0a57e2f176c1bc5d627b9098dInsert print about overwriting default flags with namelist valueseditmodel_flags.F90parameters_tunable.F908f225830ad630ade0b0f818521e3420cf71da15d1641840286000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comInsert print about overwriting default parameters with namelist values 2022-01-10 12:44:46 -06008f225830ad630ade0b0f818521e3420cf71da15dInsert print about overwriting default parameters with namelist valueseditparameters_tunable.F90clubb_api_module.F90f3942b808f629c080b43dfaca5c50c6ce080ef9a1641936564000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking api version of setup_grid. larson-group/clubb#972 2022-01-11 15:29:24 -0600f3942b808f629c080b43dfaca5c50c6ce080ef9aMaking api version of setup_grid. larson-group/clubb#972editclubb_api_module.F90silhs_api_module.F903db947c8588aef8f34322cfdf19bc0b3e0e7be791642027821000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking some paramters_silhs variables available from the silhs api 2022-01-12 16:50:21 -06003db947c8588aef8f34322cfdf19bc0b3e0e7be79Making some paramters_silhs variables available from the silhs apieditsilhs_api_module.F90advance_clubb_core_module.F9065acb9b0c8906c6bd4001aa5eb2cb31b117608351642031683000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comComment out setting of fatal error when l_min_xp2_from_corr_wx = F and l_enable_relaxed_clipping = F. The goal is to allow the clubb_backwards_compatibility_gfortran_test Jenkins test to pass again. For #846. 2022-01-12 17:54:43 -060065acb9b0c8906c6bd4001aa5eb2cb31b11760835Comment out setting of fatal erroreditadvance_clubb_core_module.F90parameters_tunable.F907ec140fc6d8e5e40e4dd195f225d62cdaa8fbabe1642115849000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduThis should be BIT_CHANGING, but only because the value of Cx_min should change in the netcdf file. This will not be answer changing. 2022-01-13 17:17:29 -06007ec140fc6d8e5e40e4dd195f225d62cdaa8fbabeThis should be BIT_CHANGING, but only because the value of Cx_min should change in the netcdf file. This will not be answer changing.editparameters_tunable.F90parameters_tunable.F905bf9927ebb2fdd8006f9aee4380dd467515d2c061642119958000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduChanging the value of C_invrs_tau_shear from 0.02 to 0.15. This commit is BIT_CHANGING 2022-01-13 18:25:58 -06005bf9927ebb2fdd8006f9aee4380dd467515d2c06Changing the value of C_invrs_tau_shear from 0.02 to 0.15.editparameters_tunable.F90tunable_parameters.infd648cb14bd2f6434aed39fc86dca28198985a3d1642119958000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduChanging the value of C_invrs_tau_shear from 0.02 to 0.15. This commit is BIT_CHANGING 2022-01-13 18:25:58 -0600fd648cb14bd2f6434aed39fc86dca28198985a3dChanging the value of C_invrs_tau_shear from 0.02 to 0.15.edittunable_parameters.inadvance_clubb_core_module.F9004279f676a57a9710d4b60f0dafcd0c331a4f18e1642120044000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAvoiding stats call for variables that are not set when l_diag_Lscale_from_tau is not true. 2022-01-13 18:27:24 -060004279f676a57a9710d4b60f0dafcd0c331a4f18eAvoiding stats call for variables that are not set when l_diag_Lscale_from_tau is not true.editadvance_clubb_core_module.F90parameters_tunable.F9003f14dd627f8df25c1e8c40b407a2c60b943f9721642203316000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduAdjusting the value of C_invrs_tau_shear from 0.15 to 0.16 so that CLUBB (particularly the MC3E case) completes successfully for all compiler tests. You might say that this is BIT_CHANGING. 2022-01-14 17:35:16 -060003f14dd627f8df25c1e8c40b407a2c60b943f972Adjusting the value of C_invrs_tau_shear from 0.15 to 0.16 so thateditparameters_tunable.F90tunable_parameters.in766f9e3b4618c10af83cad18dae103b39f8841ae1642203316000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduAdjusting the value of C_invrs_tau_shear from 0.15 to 0.16 so that CLUBB (particularly the MC3E case) completes successfully for all compiler tests. You might say that this is BIT_CHANGING. 2022-01-14 17:35:16 -0600766f9e3b4618c10af83cad18dae103b39f8841aeAdjusting the value of C_invrs_tau_shear from 0.15 to 0.16 so thatedittunable_parameters.inmixing_length.F90advance_clubb_core_module.F90model_flags.F90clubb_api_module.F90constants_clubb.F90advance_helper_module.F90d8836de198f0c3f3457f195fb08642497dead21b1642358928000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdd l_smooth_Heaviside_tau_wpxp to smooth discontinuity in invrs_tau_wpxp_zm This option calls subroutine smooth_heaviside_peskin, which implements the smooth Peskin Heaviside function. The option is turned off for now, and so the results should remain bit for bit. For #965. 2022-01-16 12:48:48 -0600d8836de198f0c3f3457f195fb08642497dead21bAdd l_smooth_Heaviside_tau_wpxp to smooth discontinuity in invrs_tau_wpxp_zmeditconstants_clubb.F90editmixing_length.F90editadvance_clubb_core_module.F90editadvance_helper_module.F90editclubb_api_module.F90editmodel_flags.F90configurable_model_flags.in099d2418f85672d98526ce96b365310ce40a99ae1642358928000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdd l_smooth_Heaviside_tau_wpxp to smooth discontinuity in invrs_tau_wpxp_zm This option calls subroutine smooth_heaviside_peskin, which implements the smooth Peskin Heaviside function. The option is turned off for now, and so the results should remain bit for bit. For #965. 2022-01-16 12:48:48 -0600099d2418f85672d98526ce96b365310ce40a99aeAdd l_smooth_Heaviside_tau_wpxp to smooth discontinuity in invrs_tau_wpxp_zmeditconfigurable_model_flags.inSRC/SGS_CLUBB/clubb_sgs.F908782d789ecc106b1da2f147557c07d6358ad0fb51642523255000http://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldjan.gruenenwald@gmail.comadapted SAM because CLUBB API changed 2022-01-18 10:27:35 -06008782d789ecc106b1da2f147557c07d6358ad0fb5adapted SAM because CLUBB API changededitSRC/SGS_CLUBB/clubb_sgs.F90pdf_parameter_module.F90advance_clubb_core_module.F90clubb_api_module.F904d506fc219eb83b1977f318f6b46c3a1f75f09c51642541581000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduPushing column loop into advance_clubb_core, and adding interface for it so that we will not need to update any host models. Everything is bit-for-bit, testing all standalone cases and our cam_coarse res run. larson-group/clubb#972 2022-01-18 15:33:01 -06004d506fc219eb83b1977f318f6b46c3a1f75f09c5Pushing column loop into advance_clubb_core, and adding interface for it so that we will not need to update any host models. Everything is bit-for-bit, testing all standalone cases and our cam_coarse res run. larson-group/clubb#972editclubb_api_module.F90editpdf_parameter_module.F90editadvance_clubb_core_module.F90clubb_api_module.F90946ca541e9acab72c5dbd52b2df8651bfc0bfb761642618464000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding l_stats check around stats stuff. This fixes the crashing when stats is disabled. larson-group/clubb#972 2022-01-19 12:54:24 -0600946ca541e9acab72c5dbd52b2df8651bfc0bfb76Adding l_stats check around stats stuff. This fixes the crashing when stats is disabled. larson-group/clubb#972editclubb_api_module.F90clubb_api_module.F907e6744fa4864a0219f8e4a32d0d72fb2664598d91642631316000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking single and multi column versions of advance clubb core available through clubb_api. larson-group/clubb#972 2022-01-19 16:28:36 -06007e6744fa4864a0219f8e4a32d0d72fb2664598d9Making single and multi column versions of advance clubb core available through clubb_api. larson-group/clubb#972editclubb_api_module.F90advance_clubb_core_module.F900bae8e4aaa7651515c8d5df797909bd9de345c2f1642725231000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduBreaking up column loop in advance_clubb_core. larson-group/clubb#972 2022-01-20 18:33:51 -06000bae8e4aaa7651515c8d5df797909bd9de345c2fBreaking up column loop in advance_clubb_core. larson-group/clubb#972editadvance_clubb_core_module.F90advance_clubb_core_module.F90d55d2cbc2faec828838317f478b04fa8ea410f7a1642801850000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduPushing loop into pdf_closure and breaking it up. larson-group/clubb#972 2022-01-21 15:50:50 -0600d55d2cbc2faec828838317f478b04fa8ea410f7aPushing loop into pdf_closure and breaking it up. larson-group/clubb#972editadvance_clubb_core_module.F90parameters_tunable.F90fabb386b09890bd8a64d59b5ae24bae937af9f931642810666000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI changed C_invrs_tau_N2_wp2 from 0.1 to 0.2 to help stop turbulence from going to the model top, which ultimately caused MC3E to crash by becoming too cold. Additionally, I set C_invrs_tau_shear back to 0.15 from 0.16. This commit is BIT_CHANGING. 2022-01-21 18:17:46 -0600fabb386b09890bd8a64d59b5ae24bae937af9f93I changed C_invrs_tau_N2_wp2 from 0.1 to 0.2 to help stop turbulenceeditparameters_tunable.F90tunable_parameters.ine3d21eff02c10658231240f81937309674ff56831642810666000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI changed C_invrs_tau_N2_wp2 from 0.1 to 0.2 to help stop turbulence from going to the model top, which ultimately caused MC3E to crash by becoming too cold. Additionally, I set C_invrs_tau_shear back to 0.15 from 0.16. This commit is BIT_CHANGING. 2022-01-21 18:17:46 -0600e3d21eff02c10658231240f81937309674ff5683I changed C_invrs_tau_N2_wp2 from 0.1 to 0.2 to help stop turbulenceedittunable_parameters.inadvance_clubb_core_module.F90pdf_closure_module.F902c6b628542302815ac566410bfa583f64b2524641643072201000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduPushing loop into pdf_closure_module and breaking it up. larson-group/clubb#972 2022-01-24 18:56:41 -06002c6b628542302815ac566410bfa583f64b252464Pushing loop into pdf_closure_module and breaking it up. larson-group/clubb#972editadvance_clubb_core_module.F90editpdf_closure_module.F90advance_clubb_core_module.F90pdf_closure_module.F90af9c183212dde92967cca80d87ef80f1aabd76b11643141070000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking the good version of pdf_params used most places. The bad version is the single column version. larson-group/clubb#972 2022-01-25 14:04:30 -0600af9c183212dde92967cca80d87ef80f1aabd76b1Making the good version of pdf_params used most places. The bad version is the single column version. larson-group/clubb#972editadvance_clubb_core_module.F90editpdf_closure_module.F90model_flags.F90c0b2297dad094c1121026e8520de001748c1d0a71643148928000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduMaking a commit that officially places the call to the PDF in the "post" position (meaning after CLUBB's predictive fields have been advanced). This commit is BIT_CHANGING 2022-01-25 16:15:28 -0600c0b2297dad094c1121026e8520de001748c1d0a7Making a commit that officially places the call to the PDF in the "post"editmodel_flags.F90configurable_model_flags.in48bc009f8f95e2158d037396050d5ae424e71a791643148928000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduMaking a commit that officially places the call to the PDF in the "post" position (meaning after CLUBB's predictive fields have been advanced). This commit is BIT_CHANGING 2022-01-25 16:15:28 -060048bc009f8f95e2158d037396050d5ae424e71a79Making a commit that officially places the call to the PDF in the "post"editconfigurable_model_flags.inadvance_clubb_core_module.F90pdf_closure_module.F90adg1_adg2_3d_luhar_pdf.F90f1c545226c133b42ec11c523daee00e938910cf31643158136000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduPushing loops into all relevent lowest level routines in pdf_closure. larson-group/clubb#972 2022-01-25 18:48:56 -0600f1c545226c133b42ec11c523daee00e938910cf3Pushing loops into all relevent lowest level routines in pdf_closure. larson-group/clubb#972editadvance_clubb_core_module.F90editpdf_closure_module.F90editadg1_adg2_3d_luhar_pdf.F90pdf_closure_module.F9007b04afa6c644e22e0a920739ba49eab985c08821643158635000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduForgot an & symbol. 2022-01-25 18:57:15 -060007b04afa6c644e22e0a920739ba49eab985c0882Forgot an & symbol.editpdf_closure_module.F90advance_clubb_core_module.F90pdf_closure_module.F90376d0e4907dc788fce6a52b6d0dc5ad4d7481f341643238890000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduWe need to initialize our local pdf_implicit_coefs_terms_zm in certain pdf types. We also don't need to zero out pdf_implicit_coefs_terms arrays, since that's done in the initialization. This should fix segfaults when l_call_pdf_closure_twice=.True. larson-group/clubb#972 2022-01-26 17:14:50 -0600376d0e4907dc788fce6a52b6d0dc5ad4d7481f34We need to initialize our local pdf_implicit_coefs_terms_zm in certain pdf types. We also don't need to zero out pdf_implicit_coefs_terms arrays, since that's done in the initialization. This should fix segfaults when l_call_pdf_closure_twice=.True. larson-group/clubb#972editadvance_clubb_core_module.F90editpdf_closure_module.F90advance_clubb_core_module.F90clubb_api_module.F900201571e2624e4580ec5e4f44582e187d7908ebb1643342499000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am updating ice_supersat_frac to be an intent(inout) variable for advance_clubb_core. When the PDF is in the "post" position, there is a chance that it can be used before it is set unless it is preserved from timestep to timestep. 2022-01-27 22:01:39 -06000201571e2624e4580ec5e4f44582e187d7908ebbI am updating ice_supersat_frac to be an intent(inout) variable foreditadvance_clubb_core_module.F90editclubb_api_module.F90SRC/SGS_CLUBB/clubb_sgs.F90SRC/SGS_CLUBB/clubbvars.F908f115022ecd190ada3c206747b7fd64508db8cbd1643359087000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduUpdated for recent changes to CLUBB 2022-01-28 02:38:07 -06008f115022ecd190ada3c206747b7fd64508db8cbdUpdated for recent changes to CLUBBeditSRC/SGS_CLUBB/clubb_sgs.F90editSRC/SGS_CLUBB/clubbvars.F90advance_clubb_core_module.F90aa44cb502926842665f158cbfab7c8cf1df5c3c51643406577000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduIntializing sigma_sqd_w_zt when not using ADG1. larson-group/clubb#972 2022-01-28 15:49:37 -0600aa44cb502926842665f158cbfab7c8cf1df5c3c5Intializing sigma_sqd_w_zt when not using ADG1. larson-group/clubb#972editadvance_clubb_core_module.F90pdf_parameter_module.F905088c109e589f0398450ea86996147836b8b75d81643411572000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing bug, we were not initializng pdf_params for all columns. larson-group/clubb#972 2022-01-28 17:12:52 -06005088c109e589f0398450ea86996147836b8b75d8Fixing bug, we were not initializng pdf_params for all columns. larson-group/clubb#972editpdf_parameter_module.F90grid_class.F90advance_clubb_core_module.F90f1154aed2f15410ec35a99adb03d2d517f9fad2d1643747310000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduPushing column index into zm2zt and zt2zm. larson-group/clubb#972 2022-02-01 14:28:30 -0600f1154aed2f15410ec35a99adb03d2d517f9fad2dPushing column index into zm2zt and zt2zm. larson-group/clubb#972editgrid_class.F90editadvance_clubb_core_module.F90advance_clubb_core_module.F90Skx_module.F90932c80e272c18da1ccf51719eed39b370ca459121643751025000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduPushing column index into Skx_func and making it a subroutine. larson-group/clubb#972 2022-02-01 15:30:25 -0600932c80e272c18da1ccf51719eed39b370ca45912Pushing column index into Skx_func and making it a subroutine. larson-group/clubb#972editadvance_clubb_core_module.F90editSkx_module.F90sigma_sqd_w_module.F90grid_class.F90advance_clubb_core_module.F90advance_helper_module.F90a3665dbc5e18abd7e8281d753abed2bbb03d8f1c1643762869000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduA variety of small loop pushing. larson-group/clubb#972 2022-02-01 18:47:49 -0600a3665dbc5e18abd7e8281d753abed2bbb03d8f1cA variety of small loop pushing. larson-group/clubb#972editadvance_helper_module.F90editgrid_class.F90editadvance_clubb_core_module.F90editsigma_sqd_w_module.F90sigma_sqd_w_module.F907f7db11cab062c725e5fe2787d45f0225e4ba60f1643831947000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixed small bug that slipped through because the G_unit tests use nz=1. 2022-02-02 13:59:07 -06007f7db11cab062c725e5fe2787d45f0225e4ba60fFixed small bug that slipped through because the G_unit tests use nz=1.editsigma_sqd_w_module.F90advance_clubb_core_module.F90mixing_length.F90advance_helper_module.F903c97bd65f2133f211f2d8502473f2cf32a025be11643840875000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduPushing column index into mixing length routines, not all the way down for the non-tau based calculation. larson-group/clubb#972 2022-02-02 16:27:55 -06003c97bd65f2133f211f2d8502473f2cf32a025be1Pushing column index into mixing length routines, not all the way down for the non-tau based calculation. larson-group/clubb#972editadvance_clubb_core_module.F90editmixing_length.F90editadvance_helper_module.F90pdf_parameter_module.F90df7da80153115bfa7df377decb342e4aee4481cf1643927836000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added a subroutine that prints that values of all PDF parameters in type pdf_parameter, which is a useful debugging tool. 2022-02-03 16:37:16 -0600df7da80153115bfa7df377decb342e4aee4481cfI added a subroutine that prints that values of all PDF parameters ineditpdf_parameter_module.F90advance_clubb_core_module.F90Skx_module.F90445f590cf1d278eee326fe3a3355fdc0deab0d211643933733000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduSmall changes and a loop push. larson-group/clubb#972 2022-02-03 18:15:33 -0600445f590cf1d278eee326fe3a3355fdc0deab0d21Small changes and a loop push. larson-group/clubb#972editSkx_module.F90editadvance_clubb_core_module.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90c9f575df03cc82bf9e0783bd2608ef27d0b4b6371643933733000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduPushing loop into advance_xm_wpxp. larson-group/clubb#972 2022-02-03 18:15:33 -0600c9f575df03cc82bf9e0783bd2608ef27d0b4b637Pushing loop into advance_xm_wpxp. larson-group/clubb#972editadvance_clubb_core_module.F90editadvance_xm_wpxp_module.F90sigma_sqd_w_module.F90eb106afc75f2daab341edd31b7508557525f6fb21643933733000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking the G_unit test use a dummy column index. This makes it so we don't need an interface for compute_sigma_sqd_w since now we only use it with 2 dimensions. This is just nicer. larson-group/clubb#972 2022-02-03 18:15:33 -0600eb106afc75f2daab341edd31b7508557525f6fb2Making the G_unit test use a dummy column index. This makes it so we don't need an interface for compute_sigma_sqd_w since now we only use it with 2 dimensions. This is just nicer. larson-group/clubb#972editsigma_sqd_w_module.F90advance_xm_wpxp_module.F90bcda3f8c752053316304a5ce21d56977f49c53b41644004220000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduBreaking up column loop in advance_xm_wpxp_module. larson-group/clubb#972 2022-02-04 13:50:20 -0600bcda3f8c752053316304a5ce21d56977f49c53b4Breaking up column loop in advance_xm_wpxp_module. larson-group/clubb#972editadvance_xm_wpxp_module.F90advance_xm_wpxp_module.F90mono_flux_limiter.F900a7b2cda84e35cf4f34a3a582daf8b67a6a621941644016923000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduPushing column loop into local functions. larson-group/clubb#972 2022-02-04 17:22:03 -06000a7b2cda84e35cf4f34a3a582daf8b67a6a62194Pushing column loop into local functions. larson-group/clubb#972editmono_flux_limiter.F90editadvance_xm_wpxp_module.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90775ab377c5ff0ed340e9dbfa0bcb7af76d1687d01644444703000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMoving stats call for uprcp and vprcp to after they are calculated. This fixes the silhs restart test. But does not seem to fix the E3SM or CAM tests that are still failing. 2022-02-09 16:11:43 -0600775ab377c5ff0ed340e9dbfa0bcb7af76d1687d0Moving stats call for uprcp and vprcp to after they are calculated. This fixes the silhs restart test. But does not seem to fix the E3SM or CAM tests that are still failing.editadvance_clubb_core_module.F90editadvance_xm_wpxp_module.F90jenkins_tests/sam_micro_drizzle_intel_test/Jenkinsfilejenkins_tests/sam_clubb_silhs_gfortran_build/Jenkinsfilejenkins_tests/sam_clubb_pgi_build/Jenkinsfile23290414d497232c0ca102e3e56665f39b8766a71644528151000http://carson.math.uwm.edu/jenkins/user/pbroelspbroelspbroels@uwm.eduAdding in Post Step log reporting to ensure we recieve log output even on failed runs. 2022-02-10 15:22:31 -060023290414d497232c0ca102e3e56665f39b8766a7Adding in Post Step log reporting to ensure we recieve log output even on failed runs.editjenkins_tests/sam_clubb_silhs_gfortran_build/Jenkinsfileeditjenkins_tests/sam_micro_drizzle_intel_test/Jenkinsfileeditjenkins_tests/sam_clubb_pgi_build/Jenkinsfilejenkins_tests/sam_micro_drizzle_intel_test/Jenkinsfilejenkins_tests/sam_clubb_silhs_gfortran_build/Jenkinsfilejenkins_tests/sam_clubb_pgi_build/Jenkinsfilea1df97eda01e448a5acf42372bf7c34cb5518e781644862289000http://carson.math.uwm.edu/jenkins/user/pbroelspbroelspbroels@uwm.eduFixing syntax errror in the jenkins file. 2022-02-14 12:11:29 -0600a1df97eda01e448a5acf42372bf7c34cb5518e78Fixing syntax errror in the jenkins file.editjenkins_tests/sam_clubb_silhs_gfortran_build/Jenkinsfileeditjenkins_tests/sam_clubb_pgi_build/Jenkinsfileeditjenkins_tests/sam_micro_drizzle_intel_test/Jenkinsfilejenkins_tests/sam_micro_drizzle_intel_test/Jenkinsfilejenkins_tests/sam_clubb_pgi_build/Jenkinsfilejenkins_tests/sam_clubb_silhs_gfortran_build/Jenkinsfilec8294bf11b3cfebb37577aba4da6ccbad86d42b71644864743000http://carson.math.uwm.edu/jenkins/user/pbroelspbroelspbroels@uwm.eduFixing test deleting log file before it can be read. 2022-02-14 12:52:23 -0600c8294bf11b3cfebb37577aba4da6ccbad86d42b7Fixing test deleting log file before it can be read.editjenkins_tests/sam_clubb_pgi_build/Jenkinsfileeditjenkins_tests/sam_clubb_silhs_gfortran_build/Jenkinsfileeditjenkins_tests/sam_micro_drizzle_intel_test/Jenkinsfileclubb_api_module.F90402036c07820f647c23fbe11eae422423adacad71645044208000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding 2D version of zt2zm and zm2zt to clubb_api 2022-02-16 14:43:28 -0600402036c07820f647c23fbe11eae422423adacad7Adding 2D version of zt2zm and zm2zt to clubb_apieditclubb_api_module.F90advance_xm_wpxp_module.F9076ade90ca6c58592fb9ad1ed4232a03249257f021645143350000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comPushing loop into solve_xm_wpxp_with_single_lhs (#986) Co-authored-by: Peter Roels <56004443+pbroels@users.noreply.github.com> 2022-02-17 18:15:50 -060076ade90ca6c58592fb9ad1ed4232a03249257f02Pushing loop into solve_xm_wpxp_with_single_lhs (#986)editadvance_xm_wpxp_module.F90advance_xm_wpxp_module.F905c71aa30cb7d3a8d1d12c9fcfee59669157b08961645475225000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRefactoring to remove need for global stats scratch variables. (#988) * Refactoring to remove need for global stats scratch variables. larson-group/clubb#972 * Changing name of new stats_scratch variables to be more descriptive. 2022-02-21 14:27:05 -06005c71aa30cb7d3a8d1d12c9fcfee59669157b0896Refactoring to remove need for global stats scratch variables. (#988)editadvance_xm_wpxp_module.F90advance_xm_wpxp_module.F90ed18e641c3b7fa3567c638f8fd52f6f4fe01f43d1645649579000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comGunthers branch (#989) * Refactoring to remove need for global stats scratch variables. larson-group/clubb#972 * Changing name of new stats_scratch variables to be more descriptive. * Breaking up column loop in solve_xm_wpxp_with_single_lhs. larson-group/clubb#972 * Pushing loop into solve_xm_wpxp_with_multiple_lhs and breaking it up. larson-group/clubb#972 * Pusing loop into xm_wpxp_rhs and xm_wpxp_lhs. larson-group/clubb#972 * Pushing loop into xm_wpxp_solve and xm_wpxp_clipping_and_stats. larson-group/clubb#972 2022-02-23 14:52:59 -0600ed18e641c3b7fa3567c638f8fd52f6f4fe01f43dGunthers branch (#989)editadvance_xm_wpxp_module.F90advance_xm_wpxp_module.F900984f81b081d6be7b58a3282fdc3759f6e2f78d41645697712000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing small bug that breaks runs with scalars. 2022-02-24 04:15:12 -06000984f81b081d6be7b58a3282fdc3759f6e2f78d4Fixing small bug that breaks runs with scalars.editadvance_xm_wpxp_module.F90advance_helper_module.F90fd4c092e458fd1143008dd04add873fdeedc836a1645806997000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comImplementations of smooth min, max and heaviside function. Added G-Unit tests 2022-02-25 10:36:37 -0600fd4c092e458fd1143008dd04add873fdeedc836aImplementations of smooth min, max and heaviside function. Added G-Unit testseditadvance_helper_module.F90setup_clubb_pdf_params.F90clubb_api_module.F90bc3082fb4215cf63236c125d1ead5be3a0898c051646171654000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking setup_pdf_parameters accept ngrdcols size arrays of stats and grid types. 2022-03-01 15:54:14 -0600bc3082fb4215cf63236c125d1ead5be3a0898c05Making setup_pdf_parameters accept ngrdcols size arrays of stats and grid types.editclubb_api_module.F90editsetup_clubb_pdf_params.F90setup_clubb_pdf_params.F90clubb_api_module.F908decd62fd4618a4cfc05359ec59aef618950cee51646172170000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduForgot two small changes. larson-group/cam#129 2022-03-01 16:02:50 -06008decd62fd4618a4cfc05359ec59aef618950cee5Forgot two small changes. larson-group/cam#129editclubb_api_module.F90editsetup_clubb_pdf_params.F90precipitation_fraction.F90setup_clubb_pdf_params.F906a574df7e37c1b18df4b266fd75de92528120b031646174455000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduRemoving need for data copies. larson-group/cam#129 2022-03-01 16:40:55 -06006a574df7e37c1b18df4b266fd75de92528120b03Removing need for data copies. larson-group/cam#129editsetup_clubb_pdf_params.F90editprecipitation_fraction.F90setup_clubb_pdf_params.F90a21672f556ca63ae1e7cc4b7851d24cec405ae871646175410000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduChanging column loop index from j to i. larson-group/cam#129 2022-03-01 16:56:50 -0600a21672f556ca63ae1e7cc4b7851d24cec405ae87Changing column loop index from j to i. larson-group/cam#129editsetup_clubb_pdf_params.F90UTIL_CLUBB/sam_plots/cases/LBA_16x1x128_4km_CLUBB.bashUTIL_CLUBB/sam_plots/cases/LBA_4x1x128_16km_CLUBB.bashf3c3443a7314c2ecb7cd1e27d3ff7722faf9bce01646865705000http://carson.math.uwm.edu/jenkins/user/pbroelspbroelsroelspbr@gmail.comChanging microphysics file to UWM from 1MOM for the carson nightly tests. 2022-03-09 16:41:45 -0600f3c3443a7314c2ecb7cd1e27d3ff7722faf9bce0Changing microphysics file to UWM from 1MOM for the carson nightly tests.editUTIL_CLUBB/sam_plots/cases/LBA_16x1x128_4km_CLUBB.basheditUTIL_CLUBB/sam_plots/cases/LBA_4x1x128_16km_CLUBB.bashlatin_hypercube_driver_module.F90f078452993a62351642178c7d76a340f6406c6931646950443000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comRemoving data copies that we don't need anymore. This still runs correctly on GPUs. 2022-03-10 16:14:03 -0600f078452993a62351642178c7d76a340f6406c693Removing data copies that we don't need anymore. This still runs correctly on GPUs.editlatin_hypercube_driver_module.F90silhs_api_module.F90latin_hypercube_driver_module.F908abf9d87614f2fdc27dfaf72324f917be702d5821646950443000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comMaking clip_transform_silhs_output use an array of gr. This is how it should have been once the column loop was pushed down into it, but at the time clubb was using gr through a use statement making that not possible. 2022-03-10 16:14:03 -06008abf9d87614f2fdc27dfaf72324f917be702d582Making clip_transform_silhs_output use an array of gr. This is how it should have been once the column loop was pushed down into it, but at the time clubb was using gr through a use statement making that not possible.editlatin_hypercube_driver_module.F90editsilhs_api_module.F90latin_hypercube_driver_module.F907d2d3a8a4ef4a33a36ce8cc202e27c17e9c9378b1646950443000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comNo more need for these data copies anymore now that pdf_params is allocated with ngrdcol rather than pcols. 2022-03-10 16:14:03 -06007d2d3a8a4ef4a33a36ce8cc202e27c17e9c9378bNo more need for these data copies anymore now that pdf_params is allocated with ngrdcol rather than pcols.editlatin_hypercube_driver_module.F90SRC/hbuffer.F90978ffa30f81c70ae3a9d87acde36a7868efd88a31647288210000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comIncreasing HBUF_MAX_LENGTH to 2000 to account for increase in vaiables. 2022-03-14 15:03:30 -0500978ffa30f81c70ae3a9d87acde36a7868efd88a3Increasing HBUF_MAX_LENGTH to 2000 to account for increase in vaiables.editSRC/hbuffer.F90advance_clubb_core_module.F90960a16c889d0898e95595a6bb59a2f296c3bffa71647296994000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdds a blank line to trigger git merge with E3SM 2022-03-14 17:29:54 -0500960a16c889d0898e95595a6bb59a2f296c3bffa7Adds a blank line to trigger git merge with E3SMeditadvance_clubb_core_module.F90advance_clubb_core_module.F906216b8e6e638a0862df4c9ccde780c0de21dc4841647434771000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRemoves a blank line in order to trigger merge with E3SM 2022-03-16 07:46:11 -05006216b8e6e638a0862df4c9ccde780c0de21dc484Removes a blank line in order to trigger merge with E3SMeditadvance_clubb_core_module.F90advance_xm_wpxp_module.F90mono_flux_limiter.F90e71c3c281fdec86134cae0107f02f9eefd7a6edd1647461903000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comPushing column loop into xm_wpxp_clipping_and_stats and monotonic_turbulent_flux_limit. This essentially completes advance_xm_wpxp for now. larson-group/clubb#972 2022-03-16 15:18:23 -0500e71c3c281fdec86134cae0107f02f9eefd7a6eddPushing column loop into xm_wpxp_clipping_and_stats and monotonic_turbulent_flux_limit. This essentially completes advance_xm_wpxp for now. larson-group/clubb#972editmono_flux_limiter.F90editadvance_xm_wpxp_module.F90advance_xp2_xpyp_module.F902422347813eaf7ab1402e8abb63072fdb362f0fe1647461903000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comReplacing the i loop iterator for scalars with sclr. 2022-03-16 15:18:23 -05002422347813eaf7ab1402e8abb63072fdb362f0feReplacing the i loop iterator for scalars with sclr.editadvance_xp2_xpyp_module.F90advance_clubb_core_module.F90advance_xp2_xpyp_module.F900e2049891bace38ffa03c49004d4dbbb303817fb1647461903000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comPushing loop into advance_xp2_wpxp. 2022-03-16 15:18:23 -05000e2049891bace38ffa03c49004d4dbbb303817fbPushing loop into advance_xp2_wpxp.editadvance_xp2_xpyp_module.F90editadvance_clubb_core_module.F90advance_xp2_xpyp_module.F90548c0002fa64ad11e86a754012f61a0b1fb7ef521647461903000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comMoving the lhs_dp1 calculation to outside of xp2_xpyp_lhs. This gives us more flexibility, since we want to pass lhs_dp1 into xp2_xpyp_implicit_stats. 2022-03-16 15:18:23 -0500548c0002fa64ad11e86a754012f61a0b1fb7ef52Moving the lhs_dp1 calculation to outside of xp2_xpyp_lhs. This gives us more flexibility, since we want to pass lhs_dp1 into xp2_xpyp_implicit_stats.editadvance_xp2_xpyp_module.F90advance_xp2_xpyp_module.F90b042151c9b68a3625a5ed0716f92daca6fd56b6f1647461903000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comMoving the lmm_stepping and stats calls to immediately after calls to xp2_xpyp_solve. This is because xp2_xpyp_implicit_stats saves things that are saved by scratch variables, and these scratch variables are set by the lhs and rhs setup calls. So for the multiple lhs routine, we need to save the scratch variables immediately after these calls before overwriting them by calling lhs and rhs again for a different variable. Since the stats also saves the variable were solving for, we also have to move the lmm_stepping to before this call. 2022-03-16 15:18:23 -0500b042151c9b68a3625a5ed0716f92daca6fd56b6fMoving the lmm_stepping and stats calls to immediately after calls to xp2_xpyp_solve. This is because xp2_xpyp_implicit_stats saves things that are saved by scratch variables, and these scratch variables are set by the lhs and rhs setup calls. So for the multiple lhs routine, we need to save the scratch variables immediately after these calls before overwriting them by calling lhs and rhs again for a different variable. Since the stats also saves the variable were solving for, we also have to move the lmm_stepping to before this call.editadvance_xp2_xpyp_module.F90advance_xp2_xpyp_module.F908c8f3fa1d2bbf4c47cc00e8c15eb63354ac4ba411647461903000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comRemoving need for stats scratch variables by passing lhs terms to save through agument lists. This makes everything better in every way. 2022-03-16 15:18:23 -05008c8f3fa1d2bbf4c47cc00e8c15eb63354ac4ba41Removing need for stats scratch variables by passing lhs terms to save through agument lists. This makes everything better in every way.editadvance_xp2_xpyp_module.F90advance_xp2_xpyp_module.F90d2b10e704a1f3896db7b05eab3249c1db38f27541647461903000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comAdding slicing for some lhs arrays being saved in stats. This was causing bit changing in a few lhs terms when run in multicolumn. 2022-03-16 15:18:23 -0500d2b10e704a1f3896db7b05eab3249c1db38f2754Adding slicing for some lhs arrays being saved in stats. This was causing bit changing in a few lhs terms when run in multicolumn.editadvance_xp2_xpyp_module.F90advance_xp2_xpyp_module.F90ecf272020b8de2182a362ed7eca489443cdcbb941647461903000http://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwm@users.noreply.github.comChanging names of dp1 variables for up2 and vp2. Surrounding where they're set to be within a l_stats_samp. 2022-03-16 15:18:23 -0500ecf272020b8de2182a362ed7eca489443cdcbb94Changing names of dp1 variables for up2 and vp2. Surrounding where they're set to be within a l_stats_samp.editadvance_xp2_xpyp_module.F90UTIL/Makefile2bdeb602878554f3f70dd41db9c653c7a26b3a391647553033000http://carson.math.uwm.edu/jenkins/user/pbroelspbroelsroelspbr@gmail.comChanged the UTIL Makefile to use ifort rather than sunf95 to allow nightly tests to run. 2022-03-17 16:37:13 -05002bdeb602878554f3f70dd41db9c653c7a26b3a39Changed the UTIL Makefile to use ifort rather than sunf95 to allow nightly tests to run.editUTIL/MakefileSCRIPTS/LES_setup/setup_LES_KK_micro.bashSHEAR_DRIVEN/grdSHEAR_DRIVEN/domain.f90.lesSHEAR_DRIVEN/sndSHEAR_DRIVEN/READMESRC/surface.shear_drivenSHEAR_DRIVEN/prm.lesSHEAR_DRIVEN/sfcSHEAR_DRIVEN/lsfdd61130c36a17819494566b291009a2fb1bb58c61647810127000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@users.noreply.github.comAdding files and updates necessary to run new neutral, shear_driven case in SAM. The case is modeled on George Bryan's CM1 shear-driven case from Moeng and Sullivan 1994. See https://github.com/larson-group/clubb/issues/991. 2022-03-20 16:02:07 -0500dd61130c36a17819494566b291009a2fb1bb58c6Adding files and updates necessary to run new neutral, shear_driven case in SAM. The caseaddSHEAR_DRIVEN/prm.lesaddSHEAR_DRIVEN/READMEaddSHEAR_DRIVEN/lsfeditSCRIPTS/LES_setup/setup_LES_KK_micro.bashaddSHEAR_DRIVEN/grdaddSHEAR_DRIVEN/sndaddSHEAR_DRIVEN/domain.f90.lesaddSRC/surface.shear_drivenaddSHEAR_DRIVEN/sfcadvance_clubb_core_module.F90model_flags.F90clubb_api_module.F90advance_xm_wpxp_module.F902d1a62e415c2203ea43159b80f23d66b062d785d1648248221000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added l_relax_clipping to CLUBB's config flags. 2022-03-25 17:43:41 -05002d1a62e415c2203ea43159b80f23d66b062d785dI added l_relax_clipping to CLUBB's config flags.editmodel_flags.F90editclubb_api_module.F90editadvance_xm_wpxp_module.F90editadvance_clubb_core_module.F90configurable_model_flags.in60d82eff914c72972cc1f41cad5c90610de493981648248221000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added l_relax_clipping to CLUBB's config flags. 2022-03-25 17:43:41 -050060d82eff914c72972cc1f41cad5c90610de49398I added l_relax_clipping to CLUBB's config flags.editconfigurable_model_flags.inSRC/SGS_CLUBB/clubb_sgs.F906f784ab9d28b6a179b5b45ee573bfefe217063551648250898000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am updating clubb_sgs.F90 for the addition of the l_enable_relaxed_clipping flag in clubb_config_flags. 2022-03-25 18:28:18 -05006f784ab9d28b6a179b5b45ee573bfefe21706355I am updating clubb_sgs.F90 for the addition of the l_enable_relaxed_clippingeditSRC/SGS_CLUBB/clubb_sgs.F90SRC/SGS_CLUBB/clubb_sgs.F901685619684d72df664230191ecec22c6635e06bb1648251864000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduForgot to add l_enable_relaxed_clipping to the namelist readible flags. 2022-03-25 18:44:24 -05001685619684d72df664230191ecec22c6635e06bbForgot to add l_enable_relaxed_clipping to the namelist readible flags.editSRC/SGS_CLUBB/clubb_sgs.F90parameters_tunable.F90advance_clubb_core_module.F90parameter_indices.F90clubb_api_module.F9036dbc89e7df189d2910e3b3fc2d3bbe5a40841491648591498000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduAdded a3_coef_min to the list of CLUBB's tunable parameter and then commented-in the a3_coef clipping line found in advance_clubb_core.F90. The results of this revision are bit-for-bit. 2022-03-29 17:04:58 -050036dbc89e7df189d2910e3b3fc2d3bbe5a4084149Added a3_coef_min to the list of CLUBB's tunable parameter and theneditparameter_indices.F90editparameters_tunable.F90editadvance_clubb_core_module.F90editclubb_api_module.F90tunable_parameters.inddd10aba970e374e5f9838c5cb15458ed4db425b1648591498000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduAdded a3_coef_min to the list of CLUBB's tunable parameter and then commented-in the a3_coef clipping line found in advance_clubb_core.F90. The results of this revision are bit-for-bit. 2022-03-29 17:04:58 -0500ddd10aba970e374e5f9838c5cb15458ed4db425bAdded a3_coef_min to the list of CLUBB's tunable parameter and thenedittunable_parameters.inSRC/SGS_CLUBB/clubb_sgs.F902e26ab7de4af8c6a63a20b47a00411e684a19a4e1648592673000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduUpdated SAM-CLUBB for CLUBB's new tunable parameter a3_coef_min 2022-03-29 17:24:33 -05002e26ab7de4af8c6a63a20b47a00411e684a19a4eUpdated SAM-CLUBB for CLUBB's new tunable parameter a3_coef_mineditSRC/SGS_CLUBB/clubb_sgs.F90jenkins_tests/samClubbCodeCopy/samClubbCodeCopy.bash04d5762aa5cfee0b6842bb65e711e1b4f34ffafe1648763011000http://carson.math.uwm.edu/jenkins/user/pbroelspbroelspbroels@uwm.eduAdding samClubbCodeCopy.bash to the jenkins directory for testing Clubb changes. larson-group/sys_admin#768 2022-03-31 16:43:31 -050004d5762aa5cfee0b6842bb65e711e1b4f34ffafeAdding samClubbCodeCopy.bash to the jenkins directory for testing Clubb changes. larson-group/sys_admin#768addjenkins_tests/samClubbCodeCopy/samClubbCodeCopy.bashadvance_clubb_core_module.F90clubb_api_module.F90ccb8a9a9a67b277371197b3aadf8aa9cc03fb0861649199568000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduAdded idiot-proofing to print a warning message when l_diag_Lscale_from_tau is being used and C1, C1b, C2rt, C2thl, C2rtthl, C6rt, C6rtb, C6thl, C6thlb, or C14 do not have a value 1. This can later be upgraded to a fatal error when we can finally run this code with the C2 and C6 families of parameters having a value of 1 (that value is currently 2 right now). 2022-04-05 17:59:28 -0500ccb8a9a9a67b277371197b3aadf8aa9cc03fb086Added idiot-proofing to print a warning message when l_diag_Lscale_from_taueditadvance_clubb_core_module.F90editclubb_api_module.F90SRC/SGS_CLUBB/clubb_sgs.F90aa0517b5732c250e1980d14996b07f8629d27d0a1649199951000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduUpdating the call to setup_clubb_core_api based on changes found in CLUBB revision d0c9b34. 2022-04-05 18:05:51 -0500aa0517b5732c250e1980d14996b07f8629d27d0aUpdating the call to setup_clubb_core_api based on changes foundeditSRC/SGS_CLUBB/clubb_sgs.F90configurable_model_flags.inca343cddc87e04ac6932bc66cabd6b01df4e022a1649805129000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added the code for the l_linearize_pbl_winds flag that was originally brought to us by Sean Santos 2022-04-12 18:12:09 -0500ca343cddc87e04ac6932bc66cabd6b01df4e022aI added the code for the l_linearize_pbl_winds flag that was originallyeditconfigurable_model_flags.inclubb_precision.F90advance_clubb_core_module.F90model_flags.F90clip_explicit.F90advance_xm_wpxp_module.F90clubb_api_module.F90advance_windm_edsclrm_module.F90d18ee7f0a7af432d15212a93179f0d3777775f4d1649805129000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added the code for the l_linearize_pbl_winds flag that was originally brought to us by Sean Santos 2022-04-12 18:12:09 -0500d18ee7f0a7af432d15212a93179f0d3777775f4dI added the code for the l_linearize_pbl_winds flag that was originallyeditadvance_windm_edsclrm_module.F90editmodel_flags.F90editclip_explicit.F90editclubb_precision.F90editadvance_xm_wpxp_module.F90editclubb_api_module.F90editadvance_clubb_core_module.F90SRC/SGS_CLUBB/clubb_sgs.F901cc3b813d04bc7de858019eb52053817082fecf31649974303000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduInterfacing SAM-CLUBB with the latest version of CLUBB. 2022-04-14 17:11:43 -05001cc3b813d04bc7de858019eb52053817082fecf3Interfacing SAM-CLUBB with the latest version of CLUBB.editSRC/SGS_CLUBB/clubb_sgs.F90SRC/SGS_CLUBB/clubb_sgs.F9000240a4a6677cb7ff3e4e0e37dd6e38ce71935e71649975225000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduUpdated code so that it actually compiles and runs. 2022-04-14 17:27:05 -050000240a4a6677cb7ff3e4e0e37dd6e38ce71935e7Updated code so that it actually compiles and runs.editSRC/SGS_CLUBB/clubb_sgs.F90jenkins_tests/sam_clubb_code_copy/Jenkinsfilejenkins_tests/samClubbCodeCopy/samClubbCodeCopy.bashjenkins_tests/sam_clubb_code_copy/sam_clubb_code_copy.bash9054a947f4f0da3b43aecce7e14fda3ede896fd91650486841000http://carson.math.uwm.edu/jenkins/user/pbroelspbroelspbroels@uwm.eduRenaming folder and script as well as adding test Jenkinsfile. 2022-04-20 15:34:01 -05009054a947f4f0da3b43aecce7e14fda3ede896fd9Renaming folder and script as well as adding test Jenkinsfile.addjenkins_tests/sam_clubb_code_copy/Jenkinsfileaddjenkins_tests/sam_clubb_code_copy/sam_clubb_code_copy.bashdeletejenkins_tests/samClubbCodeCopy/samClubbCodeCopy.bashjenkins_tests/sam_clubb_code_copy/Jenkinsfile5befef83129439197b0002212c32926e1c9a6cda1650487048000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comFixing cutt off lines and spelling mistakes. 2022-04-20 15:37:28 -05005befef83129439197b0002212c32926e1c9a6cdaFixing cutt off lines and spelling mistakes.editjenkins_tests/sam_clubb_code_copy/Jenkinsfileadvance_xp2_xpyp_module.F9022792d68ce4f823ad5ac389361dae0f25f10bcd81650572938000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comGunthers branch (#996) * Pushing column loop into xm_wpxp_clipping_and_stats and monotonic_turbulent_flux_limit. This essentially completes advance_xm_wpxp for now. larson-group/clubb#972 * Replacing the i loop iterator for scalars with sclr. * Pushing loop into advance_xp2_wpxp. * Moving the lhs_dp1 calculation to outside of xp2_xpyp_lhs. This gives us more flexibility, since we want to pass lhs_dp1 into xp2_xpyp_implicit_stats. * Moving the lmm_stepping and stats calls to immediately after calls to xp2_xpyp_solve. This is because xp2_xpyp_implicit_stats saves things that are saved by scratch variables, and these scratch variables are set by the lhs and rhs setup calls. So for the multiple lhs routine, we need to save the scratch variables immediately after these calls before overwriting them by calling lhs and rhs again for a different variable. Since the stats also saves the variable were solving for, we also have to move the lmm_stepping to before this call. * Removing need for stats scratch variables by passing lhs terms to save through agument lists. This makes everything better in every way. * Adding slicing for some lhs arrays being saved in stats. This was causing bit changing in a few lhs terms when run in multicolumn. * Changing names of dp1 variables for up2 and vp2. Surrounding where they're set to be within a l_stats_samp. * Breaking up column loop in advance_xp2_xpyp and pushing column loop into calc_xp2_xpyp_ta_terms. larson-group/cam#972 * Breaking up column loop in calc_xp2_xpyp_ta_terms. * Pushing loop into solve_xp2_xpyp_with_single_lhs. * Fixing mangled merge. * Pushing loops down. * Pushing loops and small cleanup. 2022-04-21 15:28:58 -050022792d68ce4f823ad5ac389361dae0f25f10bcd8Gunthers branch (#996)editadvance_xp2_xpyp_module.F90pdf_utilities.F90pdf_closure_module.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90027ddbb31fdc89dc29b576b69ae24dcc7cb5b7901650918954000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduVarious simple changes to improve performance. All bit-for-bit. 2022-04-25 15:35:54 -0500027ddbb31fdc89dc29b576b69ae24dcc7cb5b790Various simple changes to improve performance. All bit-for-bit.editpdf_utilities.F90editpdf_closure_module.F90editadvance_clubb_core_module.F90editadvance_xp2_xpyp_module.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90advance_helper_module.F909fbc4c9718f0b333f1cfb08f5b2a134fcd8490701650919440000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduPushing loop into calc_stability_correction. 2022-04-25 15:44:00 -05009fbc4c9718f0b333f1cfb08f5b2a134fcd849070Pushing loop into calc_stability_correction.editadvance_clubb_core_module.F90editadvance_xm_wpxp_module.F90editadvance_helper_module.F90advance_xp2_xpyp_module.F90587b19ef35eacdfa7924ed4c18aa9efd0125e6331650992705000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduSmall bug fix. 2022-04-26 12:05:05 -0500587b19ef35eacdfa7924ed4c18aa9efd0125e633Small bug fix.editadvance_xp2_xpyp_module.F90advance_xp2_xpyp_module.F90f6bb40b687635af5c4c333c02024c3fea93be31d1650994055000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAnother similar small bug fix. 2022-04-26 12:27:35 -0500f6bb40b687635af5c4c333c02024c3fea93be31dAnother similar small bug fix.editadvance_xp2_xpyp_module.F90jenkins_tests/sam_clubb_pgi_build/Jenkinsfilejenkins_tests/sam_micro_drizzle_intel_test/Jenkinsfilejenkins_tests/sam_clubb_code_copy/Jenkinsfilejenkins_tests/sam_clubb_silhs_gfortran_build/Jenkinsfile99eb7c12fda3b8367b96d54094ba6d5b87ff64f61651093665000http://carson.math.uwm.edu/jenkins/user/pbroelspbroelspbroels@uwm.eduAdding in comments to the Jenkinsfiles to clarify advanced syntax usage and commands with unclear purpose. 2022-04-27 16:07:45 -050099eb7c12fda3b8367b96d54094ba6d5b87ff64f6Adding in comments to the Jenkinsfiles to clarify advanced syntax usage and commands with unclear purpose.editjenkins_tests/sam_micro_drizzle_intel_test/Jenkinsfileeditjenkins_tests/sam_clubb_silhs_gfortran_build/Jenkinsfileeditjenkins_tests/sam_clubb_code_copy/Jenkinsfileeditjenkins_tests/sam_clubb_pgi_build/Jenkinsfileadvance_clubb_core_module.F90advance_wp2_wp3_module.F90e2ec97eca0f3244643d61e5d258d7341d579b9ad1651606634000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comGunthers branch (#999) * Reworking the flow to make it good. * Cleaning up. * Pushing loop into advance_xp2_wpxp. * Forgot to commit advance_clubb_core. * Slight improvement to logic of lhs_diff_zm_crank calculation, and fixing stats but present when lhs_diff_zm_crank=true. * Pushing lots of loops down. * Changing dimension ordering. * Cleaning up. This completes advance_wp2_wp3. larson-group/clubb#972 * Changing capitalization of intents. 2022-05-03 14:37:14 -0500e2ec97eca0f3244643d61e5d258d7341d579b9adGunthers branch (#999)editadvance_clubb_core_module.F90editadvance_wp2_wp3_module.F90mixing_length.F90advance_helper_module.F90592d69e2936ee8ce9c706d21a606fe2ed89c5a7f1651762515000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comRenamed smth_range to heaviside_smth_range 2022-05-05 09:55:15 -0500592d69e2936ee8ce9c706d21a606fe2ed89c5a7fRenamed smth_range to heaviside_smth_rangeeditmixing_length.F90editadvance_helper_module.F90stats_sfc_module.F90stats_clubb_utilities.F90stats_variables.F90advance_helper_module.F90c9ccb33dd2dd17ed51136d49262370f980d34efa1651762515000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comAdded tot_vartn_normlzd statistics. Renamed sclr in advance_helper_module to scalar to be more consistent with clubb naming schemes. 2022-05-05 09:55:15 -0500c9ccb33dd2dd17ed51136d49262370f980d34efaAdded tot_vartn_normlzd statistics. Renamed sclr in advance_helper_module to scalar to be more consistent with clubb naming schemes.editstats_clubb_utilities.F90editadvance_helper_module.F90editstats_sfc_module.F90editstats_variables.F90stats_clubb_utilities.F90stats_variables.F90stats_sfc_module.F90e68c14bd04dd6715f4eead46f5252b1cae3d909e1651762515000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comImplemented three further normalized variation stats. Included a (most likely temporary) check because in a few cases, denominator for normalization would be 0. 2022-05-05 09:55:15 -0500e68c14bd04dd6715f4eead46f5252b1cae3d909eImplemented three further normalized variation stats. Included a (most likely temporary) check because in a few cases, denominator for normalization would be 0.editstats_clubb_utilities.F90editstats_sfc_module.F90editstats_variables.F90stats_clubb_utilities.F9036748fbe6efa8a82b6c846fc8ec914e90114bdfb1651762515000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comChanged priorities of total normalized variation stats, included error handling in total normalized variation stats. 2022-05-05 09:55:15 -050036748fbe6efa8a82b6c846fc8ec914e90114bdfbChanged priorities of total normalized variation stats, included error handling in total normalized variation stats.editstats_clubb_utilities.F90stats_clubb_utilities.F9028fb91ccebb1790cc90b29cc7fe8b0b211b727eb1651762515000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comRenamed pdf_output_filename. Added grid_level constant to avoid magic numbers in stats_update_var_pt calls. 2022-05-05 09:55:15 -050028fb91ccebb1790cc90b29cc7fe8b0b211b727ebRenamed pdf_output_filename. Added grid_level constant to avoid magic numbers in stats_update_var_pt calls.editstats_clubb_utilities.F90advance_clubb_core_module.F90setup_clubb_pdf_params.F90clubb_api_module.F90advance_windm_edsclrm_module.F90advance_helper_module.F908b65b741ae34ba9ef8287f3fcafd627092d4ba131651782038000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comGunthers branch 2 (#1002) * Pushing loop down through advance_windm. Other files needed to be touched because they were using a simple function, xpwp_func, which has been replaced in relevenant places by the few lines of code it takes to do. * Cleaned up intents * Moving xpwp calcuations back to procedure, but making procedure a 1/2D interface in advance helper. Other various small tweaks as well. 2022-05-05 15:20:38 -05008b65b741ae34ba9ef8287f3fcafd627092d4ba13Gunthers branch 2 (#1002)editclubb_api_module.F90editsetup_clubb_pdf_params.F90editadvance_clubb_core_module.F90editadvance_windm_edsclrm_module.F90editadvance_helper_module.F90stats_clubb_utilities.F90488bf543bb77e0f48a1958074bd8d468f4421f761651782218000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comBugfix for merge #1000. stderr was not imported in stat_clubb_utilities.F90, causing compilation to fail. 2022-05-05 15:23:38 -0500488bf543bb77e0f48a1958074bd8d468f4421f76Bugfix for merge #1000. stderr was not imported in stat_clubb_utilities.F90, causing compilation to fail.editstats_clubb_utilities.F90SHEAR_DRIVEN/grdNEUTRAL/domain.f90.lesNEUTRAL/sndSHEAR_DRIVEN/sfcNEUTRAL/sfcSCRIPTS/LES_setup/setup_LES_KK_micro.bashNEUTRAL/READMESHEAR_DRIVEN/domain.f90.lesNEUTRAL/lsfSHEAR_DRIVEN/sndNEUTRAL/grdSHEAR_DRIVEN/READMENEUTRAL/prm.lesSHEAR_DRIVEN/prm.lesSHEAR_DRIVEN/lsfc8881c3913d3bf82c215fe8af27e6d27da2f7f401652303639000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comRenaming the new case from SHEAR_DRIVEN to NEUTRAL, and associated mentions in files. See https://github.com/larson-group/clubb/issues/991. 2022-05-11 16:13:59 -0500c8881c3913d3bf82c215fe8af27e6d27da2f7f40Renaming the new case from SHEAR_DRIVEN to NEUTRAL, and associated mentions in files.deleteSHEAR_DRIVEN/lsfaddNEUTRAL/lsfaddNEUTRAL/snddeleteSHEAR_DRIVEN/sfcdeleteSHEAR_DRIVEN/grdaddNEUTRAL/READMEaddNEUTRAL/prm.leseditSCRIPTS/LES_setup/setup_LES_KK_micro.bashaddNEUTRAL/sfcaddNEUTRAL/grddeleteSHEAR_DRIVEN/READMEdeleteSHEAR_DRIVEN/domain.f90.lesdeleteSHEAR_DRIVEN/prm.lesaddNEUTRAL/domain.f90.lesdeleteSHEAR_DRIVEN/sndmixing_length.F90advance_helper_module.F90612b58c17db79d410f0d7c183c582f38d1ccb1b51652459498000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comAdded ability to apply smooth min max functions in mixing_length.F90 2022-05-13 11:31:38 -0500612b58c17db79d410f0d7c183c582f38d1ccb1b5Added ability to apply smooth min max functions in mixing_length.F90editadvance_helper_module.F90editmixing_length.F90advance_helper_module.F902d9fdafb4596ebd4063d961bc3d1b18c0dbcff3d1652459498000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comUpdated deprecated documentation of smooth min and max functions in advance_helper_module.F90. https://github.com/larson-group/clubb/issues/965 2022-05-13 11:31:38 -05002d9fdafb4596ebd4063d961bc3d1b18c0dbcff3dUpdated deprecated documentation of smooth min and max functions in advance_helper_module.F90. https://github.com/larson-group/clubb/issues/965editadvance_helper_module.F90mixing_length.F90advance_helper_module.F90f050454be526c9ec53c1d5445ba5ea554477010c1652459498000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comChecked whether results really are identical even with round-off when we have l_smooth_min_max=T and smooth_min_max_mag=zero. Next commit rolls some of these changes back for merge into master. https://github.com/larson-group/clubb/issues/965 2022-05-13 11:31:38 -0500f050454be526c9ec53c1d5445ba5ea554477010cChecked whether results really are identical even with round-off when we have l_smooth_min_max=T and smooth_min_max_mag=zero. Next commit rolls some of these changes back for merge into master. https://github.com/larson-group/clubb/issues/965editadvance_helper_module.F90editmixing_length.F90mixing_length.F90d540581ca5c6736c20a89d3b168cd0048f6bf3a21652459498000http://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+JanGrn@users.noreply.github.comAdded test cases to smooth_min_max_tests.F90 and updated documentation. 2022-05-13 11:31:38 -0500d540581ca5c6736c20a89d3b168cd0048f6bf3a2Added test cases to smooth_min_max_tests.F90 and updated documentation.editmixing_length.F90DOC/SAM_CLUBB_standards.texDOC/SAM6.10_guide.docDOC/SAM_CLUBB.texDOC/SAM_code_notes.tex312b71b16529ae216c04189c49f66a05752d1cbb1653507511000http://carson.math.uwm.edu/jenkins/user/cerniktcerniktcernikt@msoe.eduremoved SAM_CLUBB_standards.tex, SAM_CLUBB.tex, SAM_code_notes.tex, and SAM6.10_guide.doc larson-group/sys_admin#622 2022-05-25 14:38:31 -0500312b71b16529ae216c04189c49f66a05752d1cbbremoved SAM_CLUBB_standards.tex, SAM_CLUBB.tex, SAM_code_notes.tex, and SAM6.10_guide.doc larson-group/sys_admin#622deleteDOC/SAM_CLUBB_standards.texdeleteDOC/SAM6.10_guide.docdeleteDOC/SAM_CLUBB.texdeleteDOC/SAM_code_notes.texSCRIPTS/LES_setup/setup_LES_KK_micro.bashSRC/surface.neutralSRC/surface.shear_driven4a5bf1865b151f96d5460e2aaddf0de7563104111653507916000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comCOrrecting a couple of omissions from when I was renaming the shear_driven case to "neutral". See https://github.com/larson-group/clubb/issues/991. 2022-05-25 14:45:16 -05004a5bf1865b151f96d5460e2aaddf0de756310411COrrecting a couple of omissions from when I was renaming the shear_driven case to "neutral".addSRC/surface.neutraleditSCRIPTS/LES_setup/setup_LES_KK_micro.bashdeleteSRC/surface.shear_drivensilhs_api_module.F90latin_hypercube_driver_module.F90f6c58abafbfc4b18957f9eedff60deeb321bad321653690057000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comConstructing rcm within SILHS (as rcm_pdf) (#1011) * Constructing rcm within SILHS (as rcm_pdf) to avoid having to pass rcm directly to SILHS. Relevant to possibly moving PDF call placement into the "post" position in CAM. See https://github.com/ESCOMP/CAM/issues/582. * Reconstructing rcm inside of setup_pdf_parameters instead of passing it through the argument lists. Might help NCAR move the PDF call placement to "post" position in CAM. See https://github.com/larson-group/clubb/issues/997. * Adding descriptive comment. 2022-05-27 16:20:57 -0600f6c58abafbfc4b18957f9eedff60deeb321bad32Constructing rcm within SILHS (as rcm_pdf) (#1011)editlatin_hypercube_driver_module.F90editsilhs_api_module.F90setup_clubb_pdf_params.F90clubb_api_module.F90e3cdb98eb6cc532f8ef187f2d1cc56481a75d1f51653690057000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comConstructing rcm within SILHS (as rcm_pdf) (#1011) * Constructing rcm within SILHS (as rcm_pdf) to avoid having to pass rcm directly to SILHS. Relevant to possibly moving PDF call placement into the "post" position in CAM. See https://github.com/ESCOMP/CAM/issues/582. * Reconstructing rcm inside of setup_pdf_parameters instead of passing it through the argument lists. Might help NCAR move the PDF call placement to "post" position in CAM. See https://github.com/larson-group/clubb/issues/997. * Adding descriptive comment. 2022-05-27 16:20:57 -0600e3cdb98eb6cc532f8ef187f2d1cc56481a75d1f5Constructing rcm within SILHS (as rcm_pdf) (#1011)editclubb_api_module.F90editsetup_clubb_pdf_params.F90SRC/SGS_CLUBB/clubb_sgs.F9056d698f9776ce2802dfc991ed50a8dc952f0ec951653690141000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comUpdating for changes to CLUBB. See https://github.com/larson-group/clubb/commit/e4f125ba067ba8083f917e0e06b6b2398483d3e4. 2022-05-27 17:22:21 -050056d698f9776ce2802dfc991ed50a8dc952f0ec95Updating for changes to CLUBB. See https://github.com/larson-group/clubb/commit/e4f125ba067ba8083f917e0e06b6b2398483d3e4.editSRC/SGS_CLUBB/clubb_sgs.F90clip_explicit.F90advance_xm_wpxp_module.F90clubb_api_module.F90stats_type_utilities.F90grid_class.F90setup_clubb_pdf_params.F90advance_windm_edsclrm_module.F90new_pdf_main.F90mono_flux_limiter.F90advance_helper_module.F90advance_wp2_wp3_module.F90mixing_length.F90new_tsdadg_pdf.F90advance_xp2_xpyp_module.F90LY93_pdf.F90pdf_closure_module.F90adg1_adg2_3d_luhar_pdf.F90new_hybrid_pdf_main.F90numerical_check.F90pos_definite_module.F90sponge_layer_damping.F90new_pdf.F90turbulent_adv_pdf.F90advance_clubb_core_module.F90advance_xp3_module.F90fill_holes.F90stats_clubb_utilities.F90db5164bb7ed0c78ce4f06f92e7bf6118d10addf31654031468000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAlmost final loop pushes (#1012) * Pushing loop into clip_rcm * Pushing column loop into trapezoid routines. * Pushing column loop into clip_covar routines. * Pushing column loop into clip_variance and clip_skewness. * Replacing sgn_turbulent_velocity with built in fortran sign * Removing gr from argument list of stats calls, replacing with just nz * Replacing some usages of gr with just the number of vertical levels * Replacing some usages of gr with just the number of vertical levels again * Missed a couple files to commit * Pushing some loops and removing need for gr to be passed into some routines. * Pushing loop into advance_xp3 * Pushing loop into mixing length * Some more loop pushing * Pushing some loops into mono_flux limit, skipping the lhs routine since it's a bit tricky at the moment, will do after change to grid class. * Removing gr from argument list of stats accumulate * Precalculating zt2zm so that we can use 2d version * Precalculating um/vm ddzt so that we can use 2d version * Precalculating things to use 2d version of zt2zm * Making 2d version of cubic interp for grid class * Small modifications to sponge damping code argument lists * Renaming some variables 2022-05-31 16:11:08 -0500db5164bb7ed0c78ce4f06f92e7bf6118d10addf3Almost final loop pushes (#1012)editnew_hybrid_pdf_main.F90editadvance_windm_edsclrm_module.F90editpdf_closure_module.F90editgrid_class.F90editsetup_clubb_pdf_params.F90editsponge_layer_damping.F90editadvance_clubb_core_module.F90editnew_pdf.F90editstats_clubb_utilities.F90editnumerical_check.F90editstats_type_utilities.F90editadvance_xp3_module.F90editadvance_xp2_xpyp_module.F90editclip_explicit.F90editnew_pdf_main.F90editadvance_wp2_wp3_module.F90editadvance_xm_wpxp_module.F90editadg1_adg2_3d_luhar_pdf.F90editmixing_length.F90editclubb_api_module.F90editmono_flux_limiter.F90editLY93_pdf.F90editnew_tsdadg_pdf.F90editadvance_helper_module.F90editfill_holes.F90editpos_definite_module.F90editturbulent_adv_pdf.F90SRC/MICRO_M2005_UWM/microphysics.F90SRC/micro_field_utils.F90SRC/SGS_CLUBB/clubb_sgs.F909701c2054c2b0228fdaf8aefb5844479ef68c66b1654040073000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking compatible with latest clubb change. 2022-05-31 18:34:33 -05009701c2054c2b0228fdaf8aefb5844479ef68c66bMaking compatible with latest clubb change.editSRC/SGS_CLUBB/clubb_sgs.F90editSRC/MICRO_M2005_UWM/microphysics.F90editSRC/micro_field_utils.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90clubb_api_module.F90advance_xm_wpxp_module.F90pdf_closure_module.F90pdf_parameter_module.F90new_hybrid_pdf_main.F90new_pdf_main.F90113beb1ec6663fcef3f6bb75c7ee971ab3c0fa451654040788000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comMaking pdf_implicit_coefs_terms a type containing 2D arrays. (#1014) 2022-05-31 18:46:28 -0500113beb1ec6663fcef3f6bb75c7ee971ab3c0fa45Making pdf_implicit_coefs_terms a type containing 2D arrays. (#1014)editclubb_api_module.F90editadvance_xp2_xpyp_module.F90editpdf_closure_module.F90editadvance_clubb_core_module.F90editnew_hybrid_pdf_main.F90editadvance_wp2_wp3_module.F90editadvance_xm_wpxp_module.F90editnew_pdf_main.F90editpdf_parameter_module.F90new_pdf_main.F90new_hybrid_pdf_main.F907bc6f76ec8b70bc1789f90b554dca47122c400011654112656000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduThe G_unit tests never allocated pdf_implicit_coefs_terms. It's unclear to me how these were working before, but it seems that something about making these 2D allocatable arrays exposed the bug. 2022-06-01 14:44:16 -05007bc6f76ec8b70bc1789f90b554dca47122c40001The G_unit tests never allocated pdf_implicit_coefs_terms. It's unclear to me how these were working before, but it seems that something about making these 2D allocatable arrays exposed the bug.editnew_pdf_main.F90editnew_hybrid_pdf_main.F90advance_xp2_xpyp_module.F90de73c4eefaee2b50045b4f5e706868e84b0f45501654117361000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking zt2zm calls with pdf_implicit_coefs_terms use the 2D version. 2022-06-01 16:02:41 -0500de73c4eefaee2b50045b4f5e706868e84b0f4550Making zt2zm calls with pdf_implicit_coefs_terms use the 2D version.editadvance_xp2_xpyp_module.F90advance_clubb_core_module.F90clubb_api_module.F903643c78f6fe2260f971bba96ead125858b665f1c1654122180000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduRemoving setup_grid and setup_parameters functionality from setup_clubb_core. This is beacuse in host models the required grid information may not be known during the setup process, resulting in dummy arguments for setup_clubb_core and the grid and paramters being setup during runtime anyway. Now, in the host models we can call these subroutines immediately after setup_clubb_core to maintain identical functionality (sam, wrf), and in others we can wait to call these until the main timestepping procedure (cam,e3sm). 2022-06-01 17:23:00 -05003643c78f6fe2260f971bba96ead125858b665f1cRemoving setup_grid and setup_parameters functionality from setup_clubb_core. This is beacuse in host models the required grid information may not be known during the setup process, resulting in dummy arguments for setup_clubb_core and the grid and paramters being setup during runtime anyway. Now, in the host models we can call these subroutines immediately after setup_clubb_core to maintain identical functionality (sam, wrf), and in others we can wait to call these until the main timestepping procedure (cam,e3sm).editclubb_api_module.F90editadvance_clubb_core_module.F90SRC/SGS_CLUBB/clubb_sgs.F90b709f9e50c7ce9642fe0a6c0dcd874a14a472c761654122223000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking compatible with latest clubb change. 2022-06-01 17:23:43 -0500b709f9e50c7ce9642fe0a6c0dcd874a14a472c76Making compatible with latest clubb change.editSRC/SGS_CLUBB/clubb_sgs.F90parameters_tunable.F90grid_class.F90clubb_api_module.F90c623b91a9bf812b85b51b575233ad00e8b98f16c1654129942000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking 2D versions of setup_grid and setup_parameters. 2022-06-01 19:32:22 -0500c623b91a9bf812b85b51b575233ad00e8b98f16cMaking 2D versions of setup_grid and setup_parameters.editparameters_tunable.F90editgrid_class.F90editclubb_api_module.F90mixing_length.F90parameters_tunable.F90advance_clubb_core_module.F90clubb_api_module.F9069aaa53016d97c134fc63c8ebc1a7c029d2b60741654197815000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking lmin a scalar again, twas a mistake to make it an array, it can only take on one value. 2022-06-02 14:23:35 -050069aaa53016d97c134fc63c8ebc1a7c029d2b6074Making lmin a scalar again, twas a mistake to make it an array, it can only take on one value.editmixing_length.F90editparameters_tunable.F90editadvance_clubb_core_module.F90editclubb_api_module.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90clubb_api_module.F90advance_xm_wpxp_module.F90parameters_tunable.F90advance_windm_edsclrm_module.F9002455edff630a52bd333d2b0013748e4bce7e9ff1654200656000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking nu_vert_res_dep a type containing arrays, as opposed to being an array of types. 2022-06-02 15:10:56 -050002455edff630a52bd333d2b0013748e4bce7e9ffMaking nu_vert_res_dep a type containing arrays, as opposed to being an array of types.editadvance_xp2_xpyp_module.F90editadvance_clubb_core_module.F90editclubb_api_module.F90editadvance_wp2_wp3_module.F90editadvance_xm_wpxp_module.F90editparameters_tunable.F90editadvance_windm_edsclrm_module.F90githttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2http://carson.math.uwm.edu/jenkins/user/cerniktcerniktcernikthttp://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephenshttp://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrn68997723+jangrnhttp://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldjan.gruenenwaldhttp://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarsonhttp://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffingriffinbhttp://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwm37674341+huebleruwmhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhueblerhttp://carson.math.uwm.edu/jenkins/user/pbroelspbroelspbroelsfalseBRANCHorigin/masterTESTsam_clubb_pgi_buildStarted by user pbroelspbroelspbroels409687fd653c50c09e15df81168c05b1fdaa1d8f989687fd653c50c09e15df81168c05b1fdaa1d8f98refs/remotes/origin/flag_removal9687fd653c50c09e15df81168c05b1fdaa1d8f989687fd653c50c09e15df81168c05b1fdaa1d8f98refs/remotes/origin/flag_removal79ddfec7a3b139dfeeb8cfdaf78ad0f09d9c36f829ddfec7a3b139dfeeb8cfdaf78ad0f09d9c36f82refs/remotes/origin/stats_testing9ddfec7a3b139dfeeb8cfdaf78ad0f09d9c36f829ddfec7a3b139dfeeb8cfdaf78ad0f09d9c36f82refs/remotes/origin/stats_testing44ac319abf904ec136d6e0b259b9c74de95e4ac85aac319abf904ec136d6e0b259b9c74de95e4ac85arefs/remotes/origin/l_vary_convect_depth_additionac319abf904ec136d6e0b259b9c74de95e4ac85aac319abf904ec136d6e0b259b9c74de95e4ac85arefs/remotes/origin/l_vary_convect_depth_addition3fcb64a792d6631be39938f67e613ded134dd5dcafcb64a792d6631be39938f67e613ded134dd5dcarefs/remotes/origin/changes_to_not_breakfcb64a792d6631be39938f67e613ded134dd5dcafcb64a792d6631be39938f67e613ded134dd5dcarefs/remotes/origin/changes_to_not_break2814edaf741e6d665c0f89a28cfaeca1a95ea693d714edaf741e6d665c0f89a28cfaeca1a95ea693d7refs/remotes/origin/readiopdata_nf9014edaf741e6d665c0f89a28cfaeca1a95ea693d714edaf741e6d665c0f89a28cfaeca1a95ea693d7refs/remotes/origin/readiopdata_nf9024b8d176c11a7fc2b842245dcaec35cd93959f64c9b8d176c11a7fc2b842245dcaec35cd93959f64c9refs/remotes/origin/stats_for_hostb8d176c11a7fc2b842245dcaec35cd93959f64c9b8d176c11a7fc2b842245dcaec35cd93959f64c9refs/remotes/origin/stats_for_host529cb0c7312d9f7525696ee0fb605c83118548dc3d9cb0c7312d9f7525696ee0fb605c83118548dc3drefs/remotes/origin/master9cb0c7312d9f7525696ee0fb605c83118548dc3d9cb0c7312d9f7525696ee0fb605c83118548dc3drefs/remotes/origin/master9cb0c7312d9f7525696ee0fb605c83118548dc3d9cb0c7312d9f7525696ee0fb605c83118548dc3drefs/remotes/origin/masterhttps://github.com/larson-group/sam_clubb.gitfalse#524166778629branch_sam_test #5252false5215874FAILURE1654629629490http://carson.math.uwm.edu/jenkins/job/branch_sam_test/52/http://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/cerniktcernikthttp://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephenshttp://carson.math.uwm.edu/jenkins/user/68997723+jangrn68997723+JanGrnhttp://carson.math.uwm.edu/jenkins/user/jan.gruenenwaldjan.gruenenwaldhttp://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonhttp://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens82http://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffinhttp://carson.math.uwm.edu/jenkins/user/37674341+huebleruwm37674341+huebleruwmhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhttp://carson.math.uwm.edu/jenkins/user/pbroelspbroelsfalse53http://carson.math.uwm.edu/jenkins/job/branch_sam_test/53/51http://carson.math.uwm.edu/jenkins/job/branch_sam_test/51/BRANCHorigin/masterTESTsam_micro_drizzle_intel_testStarted by user pbroelspbroelspbroels409687fd653c50c09e15df81168c05b1fdaa1d8f989687fd653c50c09e15df81168c05b1fdaa1d8f98refs/remotes/origin/flag_removal9687fd653c50c09e15df81168c05b1fdaa1d8f989687fd653c50c09e15df81168c05b1fdaa1d8f98refs/remotes/origin/flag_removal79ddfec7a3b139dfeeb8cfdaf78ad0f09d9c36f829ddfec7a3b139dfeeb8cfdaf78ad0f09d9c36f82refs/remotes/origin/stats_testing9ddfec7a3b139dfeeb8cfdaf78ad0f09d9c36f829ddfec7a3b139dfeeb8cfdaf78ad0f09d9c36f82refs/remotes/origin/stats_testing44ac319abf904ec136d6e0b259b9c74de95e4ac85aac319abf904ec136d6e0b259b9c74de95e4ac85arefs/remotes/origin/l_vary_convect_depth_additionac319abf904ec136d6e0b259b9c74de95e4ac85aac319abf904ec136d6e0b259b9c74de95e4ac85arefs/remotes/origin/l_vary_convect_depth_addition3fcb64a792d6631be39938f67e613ded134dd5dcafcb64a792d6631be39938f67e613ded134dd5dcarefs/remotes/origin/changes_to_not_breakfcb64a792d6631be39938f67e613ded134dd5dcafcb64a792d6631be39938f67e613ded134dd5dcarefs/remotes/origin/changes_to_not_break2814edaf741e6d665c0f89a28cfaeca1a95ea693d714edaf741e6d665c0f89a28cfaeca1a95ea693d7refs/remotes/origin/readiopdata_nf9014edaf741e6d665c0f89a28cfaeca1a95ea693d714edaf741e6d665c0f89a28cfaeca1a95ea693d7refs/remotes/origin/readiopdata_nf9024b8d176c11a7fc2b842245dcaec35cd93959f64c9b8d176c11a7fc2b842245dcaec35cd93959f64c9refs/remotes/origin/stats_for_hostb8d176c11a7fc2b842245dcaec35cd93959f64c9b8d176c11a7fc2b842245dcaec35cd93959f64c9refs/remotes/origin/stats_for_host50209d71a426de0ff00b77e341eb0e4b37f27dcfaa209d71a426de0ff00b77e341eb0e4b37f27dcfaarefs/remotes/origin/master209d71a426de0ff00b77e341eb0e4b37f27dcfaa209d71a426de0ff00b77e341eb0e4b37f27dcfaarefs/remotes/origin/master209d71a426de0ff00b77e341eb0e4b37f27dcfaa209d71a426de0ff00b77e341eb0e4b37f27dcfaarefs/remotes/origin/masterhttps://github.com/larson-group/sam_clubb.gitfalse#501102049778629branch_sam_test #5050false509546SUCCESS1633977547322http://carson.math.uwm.edu/jenkins/job/branch_sam_test/50/http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens82http://carson.math.uwm.edu/jenkins/user/noreplynoreplyfalse51http://carson.math.uwm.edu/jenkins/job/branch_sam_test/51/49http://carson.math.uwm.edu/jenkins/job/branch_sam_test/49/