BRANCHorigin/l_vary_convect_depth_additionTESTsam_micro_drizzle_intel_testStarted by user rhodeskrhodeskrhodesk409687fd653c50c09e15df81168c05b1fdaa1d8f989687fd653c50c09e15df81168c05b1fdaa1d8f98refs/remotes/origin/flag_removal9687fd653c50c09e15df81168c05b1fdaa1d8f989687fd653c50c09e15df81168c05b1fdaa1d8f98refs/remotes/origin/flag_removal79ddfec7a3b139dfeeb8cfdaf78ad0f09d9c36f829ddfec7a3b139dfeeb8cfdaf78ad0f09d9c36f82refs/remotes/origin/stats_testing9ddfec7a3b139dfeeb8cfdaf78ad0f09d9c36f829ddfec7a3b139dfeeb8cfdaf78ad0f09d9c36f82refs/remotes/origin/stats_testing44ac319abf904ec136d6e0b259b9c74de95e4ac85aac319abf904ec136d6e0b259b9c74de95e4ac85arefs/remotes/origin/l_vary_convect_depth_additionac319abf904ec136d6e0b259b9c74de95e4ac85aac319abf904ec136d6e0b259b9c74de95e4ac85arefs/remotes/origin/l_vary_convect_depth_addition3fcb64a792d6631be39938f67e613ded134dd5dcafcb64a792d6631be39938f67e613ded134dd5dcarefs/remotes/origin/changes_to_not_breakfcb64a792d6631be39938f67e613ded134dd5dcafcb64a792d6631be39938f67e613ded134dd5dcarefs/remotes/origin/changes_to_not_break2814edaf741e6d665c0f89a28cfaeca1a95ea693d714edaf741e6d665c0f89a28cfaeca1a95ea693d7refs/remotes/origin/readiopdata_nf9014edaf741e6d665c0f89a28cfaeca1a95ea693d714edaf741e6d665c0f89a28cfaeca1a95ea693d7refs/remotes/origin/readiopdata_nf9024b8d176c11a7fc2b842245dcaec35cd93959f64c9b8d176c11a7fc2b842245dcaec35cd93959f64c9refs/remotes/origin/stats_for_hostb8d176c11a7fc2b842245dcaec35cd93959f64c9b8d176c11a7fc2b842245dcaec35cd93959f64c9refs/remotes/origin/stats_for_host4181de9ac556f33464591d16d960243732834be6f281de9ac556f33464591d16d960243732834be6f2refs/remotes/origin/master81de9ac556f33464591d16d960243732834be6f281de9ac556f33464591d16d960243732834be6f2refs/remotes/origin/masterac319abf904ec136d6e0b259b9c74de95e4ac85aac319abf904ec136d6e0b259b9c74de95e4ac85arefs/remotes/origin/l_vary_convect_depth_additionhttps://github.com/larson-group/sam_clubb.githttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/branch_sam_test/detail/branch_sam_test/44/artifactshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/branch_sam_test/detail/branch_sam_test/44/changeshttp://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/branch_sam_test/detail/branch_sam_test/44/http://carson.math.uwm.edu/jenkins/blue/organizations/jenkins/branch_sam_test/detail/branch_sam_test/44/testsfalseSetup LES_KK_microEdit Make FileEdit Default CaseCompileRun SAMfalse#442539879778629branch_sam_test #4444false448369SUCCESS1629480281817http://carson.math.uwm.edu/jenkins/job/branch_sam_test/44/falseBRANCHorigin/masterTESTsam_clubb_silhs_gfortran_buildStarted by user pbroelspbroelspbroels409687fd653c50c09e15df81168c05b1fdaa1d8f989687fd653c50c09e15df81168c05b1fdaa1d8f98refs/remotes/origin/flag_removal9687fd653c50c09e15df81168c05b1fdaa1d8f989687fd653c50c09e15df81168c05b1fdaa1d8f98refs/remotes/origin/flag_removal79ddfec7a3b139dfeeb8cfdaf78ad0f09d9c36f829ddfec7a3b139dfeeb8cfdaf78ad0f09d9c36f82refs/remotes/origin/stats_testing9ddfec7a3b139dfeeb8cfdaf78ad0f09d9c36f829ddfec7a3b139dfeeb8cfdaf78ad0f09d9c36f82refs/remotes/origin/stats_testing44ac319abf904ec136d6e0b259b9c74de95e4ac85aac319abf904ec136d6e0b259b9c74de95e4ac85arefs/remotes/origin/l_vary_convect_depth_additionac319abf904ec136d6e0b259b9c74de95e4ac85aac319abf904ec136d6e0b259b9c74de95e4ac85arefs/remotes/origin/l_vary_convect_depth_addition3fcb64a792d6631be39938f67e613ded134dd5dcafcb64a792d6631be39938f67e613ded134dd5dcarefs/remotes/origin/changes_to_not_breakfcb64a792d6631be39938f67e613ded134dd5dcafcb64a792d6631be39938f67e613ded134dd5dcarefs/remotes/origin/changes_to_not_break2814edaf741e6d665c0f89a28cfaeca1a95ea693d714edaf741e6d665c0f89a28cfaeca1a95ea693d7refs/remotes/origin/readiopdata_nf9014edaf741e6d665c0f89a28cfaeca1a95ea693d714edaf741e6d665c0f89a28cfaeca1a95ea693d7refs/remotes/origin/readiopdata_nf9024b8d176c11a7fc2b842245dcaec35cd93959f64c9b8d176c11a7fc2b842245dcaec35cd93959f64c9refs/remotes/origin/stats_for_hostb8d176c11a7fc2b842245dcaec35cd93959f64c9b8d176c11a7fc2b842245dcaec35cd93959f64c9refs/remotes/origin/stats_for_host454867cde34210c3e6809922659ca8ad3ab96352d44867cde34210c3e6809922659ca8ad3ab96352d4refs/remotes/origin/master4867cde34210c3e6809922659ca8ad3ab96352d44867cde34210c3e6809922659ca8ad3ab96352d4refs/remotes/origin/master4867cde34210c3e6809922659ca8ad3ab96352d44867cde34210c3e6809922659ca8ad3ab96352d4refs/remotes/origin/masterhttps://github.com/larson-group/sam_clubb.gitfalse#4535340778629branch_sam_test #4545false459339SUCCESS1632955703932http://carson.math.uwm.edu/jenkins/job/branch_sam_test/45/advance_clubb_core_module.F9078cfb14b8fa5de38bd6fb61a3f5aca221d6011e51436554493000http://carson.math.uwm.edu/jenkins/user/weberjkweberjkweberjk@uwm.eduFor clubb:ticket:770, the Oracle compiler was throwing a floating point exception here. wpxp2 and xp2 were being fed in as Nans. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@7819 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 6a633ba12a025460419d06b5f05531cb60776dff 2015-07-10 18:54:53 +000078cfb14b8fa5de38bd6fb61a3f5aca221d6011e5For clubb:ticket:770, the Oracle compiler was throwing a floating point exception here. wpxp2 and xp2 were being fed in as Nans.editadvance_clubb_core_module.F90calc_roots.F9023b83be5cb345e758984087986aa513cfe770db81436899091000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduThe new file calc_roots.F90 contains functions that solve for the roots of a cubic polynomial (function cubic_solve), the roots of a quadratic polynomial (function quadratic_solve), as well as cube root (function cube_root, which is called by the function that solves the cubic polynomial). These are general purpose functions which can aid in many solutions. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@7827 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 9320a395d5164202f5bbe38aa3067fa66372035d 2015-07-14 18:38:11 +000023b83be5cb345e758984087986aa513cfe770db8The new file calc_roots.F90 contains functions that solve for the roots of aaddcalc_roots.F90precipitation_fraction.F90setup_clubb_pdf_params.F90cea3875a9022bfe5bbb7bc6d231f689a42ff91751438106080000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI tweaked the precipitation fraction code so that the weighted ith PDF component preciptation fractions (mixt_frac_i * precip_frac_i) remain proportional to each other when overall precipitation fraction is not equal to the sum of the two weighted component precipitation fractions (e.g. while there can be some slight discrepancies in a standalone run, but this will have the greatest effect when precipitation fraction is supplied by the LES). git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@7868 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: d012def7452f348a844a9f24849730ecd58eb53e 2015-07-28 17:54:40 +0000cea3875a9022bfe5bbb7bc6d231f689a42ff9175I tweaked the precipitation fraction code so that the weighted ith PDF componenteditsetup_clubb_pdf_params.F90editprecipitation_fraction.F90stats_variables.F90stats_clubb_utilities.F90stats_lh_zt_module.F908dd99699dcf36a52272f3ed4fe69e214ff81b6621439353819000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor clubb:ticket:740, I added an output for the "sampling fractions" in each category, which are the SILHS approximations of S_j. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@7881 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 3809b00b3a69243036f98e13528481d72fa50621 2015-08-12 04:30:19 +00008dd99699dcf36a52272f3ed4fe69e214ff81b662For clubb:ticket:740, I added an output for the "sampling fractions" in each category, which are the SILHS approximations of S_j.editstats_lh_zt_module.F90editstats_variables.F90editstats_clubb_utilities.F90pdf_closure_module.F900f34241b7bbf1ccf0805b6357bea04573a51d5c11442593771000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI updated pdf_closure_module.F90 by integrating changes I made in the Brian_special_input_fields_r7565 branch. The changes are formatting, variable names, and some small improvements to the 3-D Luhar closure. This does not effect the default ADG1 closure. The results in GrADS output files from the this revision are an exact match to the results in GrADS output files from the previous revision for all cases. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@7899 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: b74c29c8fdd46473694efb1b2c91a66bd22a85c2 2015-09-18 16:29:31 +00000f34241b7bbf1ccf0805b6357bea04573a51d5c1I updated pdf_closure_module.F90 by integrating changes I made in theeditpdf_closure_module.F90clubb_api_module.F90ab2e38486b0a1adf323e8b58922473771113f37a1446161772000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor cam:ticket:36: I meant to apply clubb:r7916 to the trunk. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@7917 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 4d6ddb360ce0a8fdd50b24bc2d19e0522f2c8bf8 2015-10-29 23:36:12 +0000ab2e38486b0a1adf323e8b58922473771113f37aFor cam:ticket:36:editclubb_api_module.F90clubb_api_module.F90e917230571da0d9992cebe933575a3a0f058bc411446496362000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor cam:ticket:36#comment:132, I removed `gr` from the use statement in `setup_grid_heights_api`. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@7918 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: c625a4f22f57a4ae514f60a2aa8769a678a855c3 2015-11-02 20:32:42 +0000e917230571da0d9992cebe933575a3a0f058bc41For cam:ticket:36#comment:132, I removed `gr` from the use statement in `setup_grid_heights_api`.editclubb_api_module.F90endian.F90parameters_model.F900f06bb5311bde1161de7347d363d3a57d551faf11446868880000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor clubb:ticket:773, I fixed some unsoundness in our code regarding kinds, specifically in `parameters_model.F90` and `endian.F90`. GrADS output is bin-diff identical for all priority cases! git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@7920 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 64a44bab443b257dc08482146a99a9f3b701a694 2015-11-07 04:01:20 +00000f06bb5311bde1161de7347d363d3a57d551faf1For clubb:ticket:773, I fixed some unsoundness in our code regarding kinds, specifically in `parameters_model.F90` and `endian.F90`.editparameters_model.F90editendian.F90clubb_api_module.F90e6bacda8d9b14bf0886c9c840ae2a9892a46188e1448063758000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor cam:ticket:41, the change in clubb:r7921 should be applied to the trunk as well. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@7931 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: a44255272b0264ffa148779ae06623ea74a061d3 2015-11-20 23:55:58 +0000e6bacda8d9b14bf0886c9c840ae2a9892a46188eFor cam:ticket:41, the change in clubb:r7921 should be applied to the trunk as well.editclubb_api_module.F90code_timer_module.F90e48ac26999cd9b7c4cd6df95028cf842693bbee71448328589000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor clubb:ticket:775: I dug up some old timing code from an obsolete CLUBB branch and found that it gives accurate results. Therefore, I am committing it to the trunk of CLUBB, inside the `CLUBB_core` directory. It is not used right now; it is simply designed to be a utility for code analysis. I cleaned up the code and added comments to make it suitable for the "official" CLUBB. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@7934 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 10dcb3e8aaf7b5d36530bcbbb34e3787686f6403 2015-11-24 01:29:49 +0000e48ac26999cd9b7c4cd6df95028cf842693bbee7For clubb:ticket:775:addcode_timer_module.F90code_timer_module.F90de48143312d64ba3c84d8363ed7c164ec1edb73d1448654722000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor clubb:ticket:775: I found a better (more precise) way to time code using `cpu_time`. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@7939 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: ba495771c41d466065d79323fcb3e2065ea870e1 2015-11-27 20:05:22 +0000de48143312d64ba3c84d8363ed7c164ec1edb73dFor clubb:ticket:775:editcode_timer_module.F90code_timer_module.F90dd1186e7c5f4efe426972dc7634d8549de4414b41448654880000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduMisc. code cleanup git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@7940 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: d06b87ca91e3cbb735187dc2534e6a736e46f557 2015-11-27 20:08:00 +0000dd1186e7c5f4efe426972dc7634d8549de4414b4Misc. code cleanupeditcode_timer_module.F90precipitation_fraction.F906915abd02fc590a68cf65e0b1f078fb9044461e51451599338000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am updating default CLUBB to use the same hydrometeor PDF parameters that are used in the Brian_special_input_fields_r7465 branch as well as in the paper on Hydrometeor PDF shapes. There are small changes to all cases that use analytic microphysics or SILHS. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@7963 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 92187f595acfabf21a05e04d24a46688c868e428 2015-12-31 22:02:18 +00006915abd02fc590a68cf65e0b1f078fb9044461e5I am updating default CLUBB to use the same hydrometeor PDF parameters that areeditprecipitation_fraction.F90advance_clubb_core_module.F90b52d3abbdcfaf6908711a08b85a1c64097ceac751454030468000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor cam:ticket:50: I added some fool-proofing to the code that stops the run with an error if the user sets `l_Lscale_plume_centered = .true.` and `l_avg_Lscale = .false.`. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@7972 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: f11ede285a96bf2c04bdd7471bc0f7359b194a80 2016-01-29 01:21:08 +0000b52d3abbdcfaf6908711a08b85a1c64097ceac75For cam:ticket:50:editadvance_clubb_core_module.F90advance_clubb_core_module.F90model_flags.F90c4366bf950382ebbc45905a6a961de1df29c3d7c1455745962000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor cam:ticket:52: I moved `l_stability_correct_tau_zm` to `model_flags.F90`, and made it a variable instead of a compile-time constant. This should be the only change we need to make to CLUBB to do away with the branch. CLUBB standalone output is bin-diff identical for a fine selection of CLUBB cases. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@7978 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 25a8690cba226668f8eb62e75b86b6a43782a8c2 2016-02-17 21:52:42 +0000c4366bf950382ebbc45905a6a961de1df29c3d7cFor cam:ticket:52:editadvance_clubb_core_module.F90editmodel_flags.F90clubb_api_module.F90afd352985083952f77c4cbcfc616f482aa4346711455747785000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor cam:ticket:52, I added some parameter indices to the API. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@7980 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 6e6fa65c78c57c47d118dc5825f370b620bb56cd 2016-02-17 22:23:05 +0000afd352985083952f77c4cbcfc616f482aa434671For cam:ticket:52, I added some parameter indices to the API.editclubb_api_module.F90clubb_api_module.F90cd647d184035d2add22118d108274fe8e330b12c1455748595000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduI forgot a parameter! cam:ticket:52. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@7982 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 2f2dc8e11b099c5aea3986de77b291e945720ec7 2016-02-17 22:36:35 +0000cd647d184035d2add22118d108274fe8e330b12cI forgot a parameter!editclubb_api_module.F90stats_zm_module.F90stats_variables.F9061f401a444b13eb465b007134bbfe7ed447060351456103321000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor clubb:ticket:753: I added statistical output for the SILHS estimates of `rtp2_mc`, `thlp2_mc`, `wprtp_mc`, `wpthlp_mc`, and `rtpthlp_mc`. Output ought to be bin-diff identical for all cases, aside from the new outputs (which are not output by default). git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@7987 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: a8e9a4db95398ec9024a1e17f0763969a102fc36 2016-02-22 01:08:41 +000061f401a444b13eb465b007134bbfe7ed44706035For clubb:ticket:753:editstats_zm_module.F90editstats_variables.F90advance_clubb_core_module.F90interpolation.F90model_flags.F905de08c8becc16a5b83c3bf0a6908bcaeb6cdecd61456190792000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor clubb:ticket:782: I merged in NCAR's changes to `advance_clubb_core_module.F90` and `interpolation.F90`. This is probably at least half the battle. I added some flags to `model_flags.F90`. They are set to the values that preserve answers in CLUBB standalone. Output is bin-diff identical for a comprehensive selection of test cases. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@7989 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 09326d9dfe1aaff864a12cd1c7c0773002d912f4 2016-02-23 01:26:32 +00005de08c8becc16a5b83c3bf0a6908bcaeb6cdecd6For clubb:ticket:782:editmodel_flags.F90editadvance_clubb_core_module.F90editinterpolation.F90advance_clubb_core_module.F901e6552e61c15a0c39c0a556625694c2dc50d00c61456190930000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduI forgot a flag. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@7990 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 36100d67534c0bce1c278b7bd6da1e9e8b3931a7 2016-02-23 01:28:50 +00001e6552e61c15a0c39c0a556625694c2dc50d00c6I forgot a flag.editadvance_clubb_core_module.F90saturation.F90model_flags.F90clubb_api_module.F90mt95.f90csr_matrix_module.F90stats_variables.F90pdf_parameter_module.F90parameters_tunable.F90sponge_layer_damping.F90gmres_cache.F90parameters_model.F90variables_prognostic_module.F905d190297215985f31583c4a206fc173b56bc52e81456259763000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor clubb:ticket:782: I completed merging in NCAR's changes. The changes include a LOT of missing `!$omp threadprivate` directives. I wonder how they manage to find these. Maybe they have a script? I also eliminated all CAM preprocessors from `parameters_tunable.F90`!! Output is bin-diff identical for a selection of cases. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@7991 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 7ac98ef43fe88b5c9936db4becc53e2579b172a7 2016-02-23 20:36:03 +00005d190297215985f31583c4a206fc173b56bc52e8For clubb:ticket:782:editsponge_layer_damping.F90editgmres_cache.F90editsaturation.F90editvariables_prognostic_module.F90editparameters_model.F90editstats_variables.F90editclubb_api_module.F90editmodel_flags.F90editmt95.f90editpdf_parameter_module.F90editcsr_matrix_module.F90editparameters_tunable.F90clubb_api_module.F9068c38299b84040772fd03108779fc63f5c0e34851456268330000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor cam:ticket:55, I added some parameters to CLUBB's API. Output is highly unlikely to change in any configuration. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@7992 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 328e2a42184ddd72b4d584391edef45de2285526 2016-02-23 22:58:50 +000068c38299b84040772fd03108779fc63f5c0e3485For cam:ticket:55, I added some parameters to CLUBB's API.editclubb_api_module.F90clubb_api_module.F9026ad189a39a78c215af30e67ac15fd2369ed90911456269331000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor cam:ticket:55: Apprarently, I had some indices declared twice. Also apparently, `gfortran` accepts this but Intel doesn't. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@7993 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: a47cfe4bd86442b727ba24412b5a52f48e798945 2016-02-23 23:15:31 +000026ad189a39a78c215af30e67ac15fd2369ed9091For cam:ticket:55:editclubb_api_module.F90stats_clubb_utilities.F90clubb_api_module.F90corr_varnce_module.F9056f87be8850c283ce00a8d858ec00d2f6b4af11c1457044956000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduI cleaned up some warnings from the Mac compiler. (build:14977) Output ought to be bin-diff identical for all cases. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8001 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 9b7d4d071dbdd3704e5fe09b274aa82de9b146fd 2016-03-03 22:42:36 +000056f87be8850c283ce00a8d858ec00d2f6b4af11cI cleaned up some warnings from the Mac compiler. (build:14977)editstats_clubb_utilities.F90editcorr_varnce_module.F90editclubb_api_module.F90parameters_tunable.F90parameter_indices.F908025ab1342a7a1b3e085b1783856426c1a92a89e1457567876000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor clubb:ticket:785, I renamed `initvars` to `clubb_params_nl`. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8010 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: bd3995e594614e659c8491539a29167fbd4cb318 2016-03-09 23:57:56 +00008025ab1342a7a1b3e085b1783856426c1a92a89eFor clubb:ticket:785, I renamed `initvars` to `clubb_params_nl`.editparameter_indices.F90editparameters_tunable.F90model_flags.F901889cc7cdabe616805708d52c269b35192b3ec771457568472000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor clubb:ticket:785: I renamed `silhs_flags_nl` to `configurable_silhs_flags_nl` and `configurable_model_flags` (only the namelist) to `configurable_clubb_flags_nl`. The output from this revision is bin-for-diff identical to the output from clubb:r8007. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8011 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 3e443cf08251c8b4b090c622ad44c54933323ea3 2016-03-10 00:07:52 +00001889cc7cdabe616805708d52c269b35192b3ec77For clubb:ticket:785:editmodel_flags.F90output_grads.F90input_reader.F90stats_type.F90csr_matrix_module.F90stats_type_utilities.F90stat_file_module.F90grid_class.F90stats_clubb_utilities.F90sponge_layer_damping.F90gmres_cache.F90c44ad4365657039db80b07ad3e2240211c9c80641457744058000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor clubb:ticket:779: I replaced `pointer` with `allocatable` in (almost) the entirety of `CLUBB_core`. All compilers in `compiler_tests.bash` can compile this version of CLUBB and none emit any warnings related to these changes. Further, with `gfortran`, output is bin-diff identical for all cases. CLUBB has officially joined the 21st century! git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8014 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: b0a141cc435acc5e0343523eb79307d33da7a711 2016-03-12 00:54:18 +0000c44ad4365657039db80b07ad3e2240211c9c8064For clubb:ticket:779:editgrid_class.F90editsponge_layer_damping.F90editstats_type.F90editgmres_cache.F90editoutput_grads.F90editstats_clubb_utilities.F90editcsr_matrix_module.F90editstats_type_utilities.F90editinput_reader.F90editstat_file_module.F90stats_clubb_utilities.F90variables_diagnostic_module.F90variables_prognostic_module.F90cac8541445e3db6df096fc04655670471a646ae91458599317000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor clubb:ticket:786: I am attempting to fix two related problems in CLUBB: 1. We need to make sure CLUBB is completely cleaned up before exiting `run_clubb`, otherwise we have memory leaks and potential errors. 2. We should make sure variables are allocated before we attempt to deallocate them. For (1), I refactored CLUBB's cleanup code into a single subroutine and am calling it in some places that a "return" statement appears. For (2), I attempted to add some appropriate conditions to look for before deallocating variables. Output ought to be bin-diff identical. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8020 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 224a4ecb0e3aebba959a50ffb56f2975de192aff 2016-03-21 22:28:37 +0000cac8541445e3db6df096fc04655670471a646ae9For clubb:ticket:786:editvariables_diagnostic_module.F90editstats_clubb_utilities.F90editvariables_prognostic_module.F90stats_clubb_utilities.F902be0615c817b980139e9df1bbc39b5bd91285cfb1458850471000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor clubb:ticket:786: I fixed two tuner related problems. I made the SILHS parameters namelist optional, so that a warning message is simply printed if the namelist is not found. I'm not particularly fond of this solution, but the difficult alternative is to track down the places in the tuner where the SILHS namelist needs to be placed. Maybe some other day. I also deallocated a variable in SILHS that wasn't deallocated before. Output ought not to change. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8023 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: ccef9fe7bcd6531d3a6903fbe2c6a8db763830ea 2016-03-24 20:14:31 +00002be0615c817b980139e9df1bbc39b5bd91285cfbFor clubb:ticket:786:editstats_clubb_utilities.F90clubb_api_module.F9076ffc1e665c4e26d1668c2efc9df9cdb5bbc142f1459894240000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor clubb:ticket:782, I added all CLUBB's parameter indices to the API. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8029 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 129197ab3782d5708e97fa61b72e3e1d6bc29cdd 2016-04-05 22:10:40 +000076ffc1e665c4e26d1668c2efc9df9cdb5bbc142fFor clubb:ticket:782, I added all CLUBB's parameter indices to the API.editclubb_api_module.F90parameters_tunable.F903a6793ec01bbe473ddf6d0583c662432bbbc45071459899281000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduhelpful note git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8030 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: f1a1a51bab997a8957a9878542c03b55d2eae5ac 2016-04-05 23:34:41 +00003a6793ec01bbe473ddf6d0583c662432bbbc4507helpful noteeditparameters_tunable.F90parameters_tunable.F904d2d0eb0e397482dacaa804e257fdad814b540fc1459899376000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.edumore helpful note git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8031 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 24e0650cb14be00b26b35e9314c0886b249a6099 2016-04-05 23:36:16 +00004d2d0eb0e397482dacaa804e257fdad814b540fcmore helpful noteeditparameters_tunable.F90parameters_tunable.F90ee33663d3cd6174fe4feefaec16f7a837f227bcb1459899640000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.edumost helpful note git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8032 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: fa7f961b7b520e654a30096415d1ba60fd4f1807 2016-04-05 23:40:40 +0000ee33663d3cd6174fe4feefaec16f7a837f227bcbmost helpful noteeditparameters_tunable.F90stats_zm_module.F90stats_zt_module.F9072529d6d77d14863829ec0b2dd173e88561e8ac71460749629000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor cam:ticket:56: While looking through plots, I noticed that for some reason, CLUBB output files list `cloud_frac` as having units of "count", which in fact it is a fraction between 0 and 1. I have changed the units to be "-", as is done elsewhere. Note that this commit is BIT_CHANGING, but only because of the metadata change. Numerical values of all variables should be identical. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8039 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 386dd79390ff0720658e567be846b45f1267b596 2016-04-15 19:47:09 +000072529d6d77d14863829ec0b2dd173e88561e8ac7For cam:ticket:56:editstats_zm_module.F90editstats_zt_module.F90advance_clubb_core_module.F90c6500cfe559a78be80cba8e53e2fdd19ca853f3b1461627613000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduWhile working on cam:ticket:59, I noticed that `tau_N2_zm` is computed twice. I removed one computation. This shouldn't change answers. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8051 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 56c350b1b4e1bd8cbc7337c7f3d3b5d5b6a7f7b3 2016-04-25 23:40:13 +0000c6500cfe559a78be80cba8e53e2fdd19ca853f3bWhile working on cam:ticket:59, I noticed that `tau_N2_zm` is computed twice. I removed one computation.editadvance_clubb_core_module.F90advance_helper_module.F90cb412fb54cc283d26552c72d98c21a225df26cc81461629167000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduDat crazy indentation, though... git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8052 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: bbb1955eaad91f06f5fea34e40eb6ea168b7d959 2016-04-26 00:06:07 +0000cb412fb54cc283d26552c72d98c21a225df26cc8Dat crazy indentation, though...editadvance_helper_module.F90advance_helper_module.F90fb63f2634b6063fef6e6aaa7cd11a2c0175165011461698001000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor cam:ticket:59, I refactored the calculation of `brunt_vaisala_freq` into a subroutine, and renamed it `brunt_vaisala_freq_sqd`. Output is bin-diff identical for a test case. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8053 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: e6131eda3cc0829d2900c24ffeac3e1cfdf9196f 2016-04-26 19:13:21 +0000fb63f2634b6063fef6e6aaa7cd11a2c017516501For cam:ticket:59, I refactored the calculation of `brunt_vaisala_freq` into a subroutine, and renamed it `brunt_vaisala_freq_sqd`.editadvance_helper_module.F90advance_clubb_core_module.F90model_flags.F90advance_xm_wpxp_module.F9042e5348649c5fe2849b9f3f4f75a64cee941e8421461713891000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor cam:ticket:59: I added an option to compute `C7_Skw_fnc` based on the Richardson number. This change is wrapped in a flag, `l_use_C7_Richardson`, which is false by default. Output is bin-diff identical in the default configuration. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8056 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: f545aa262b505691bcbc7a6a0dff5a6561bdb64d 2016-04-26 23:38:11 +000042e5348649c5fe2849b9f3f4f75a64cee941e842For cam:ticket:59:editadvance_xm_wpxp_module.F90editmodel_flags.F90editadvance_clubb_core_module.F90advance_wp2_wp3_module.F90model_flags.F90185167896321573e6a27bb1994ac28aa75203fed1461880889000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor cam:ticket:59: I am incorporating Vince's changes into the trunk. This commit introduces a new flag, `l_damp_wp2_using_em`, which, if true, will use a dissipation formula based on `em` in the `wp2` equation. The flag is false by default, and output is bin-diff identical in the default configuration. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8066 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 39fb65cf92cbd275653e062e6e5603abc28dd1bd 2016-04-28 22:01:29 +0000185167896321573e6a27bb1994ac28aa75203fedFor cam:ticket:59:editmodel_flags.F90editadvance_wp2_wp3_module.F90advance_clubb_core_module.F9029d9ce8ac3458638923b4ac461a5a569774cd6041461883559000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor cam:ticket:59: I added a check that ensures `C1=C14` and `l_stability_correct_tau_zm=F` if `l_damp_wp2_using_em=T`. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8067 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 90a2faf25065f00bda5220403e7cdb654c114f50 2016-04-28 22:45:59 +000029d9ce8ac3458638923b4ac461a5a569774cd604For cam:ticket:59:editadvance_clubb_core_module.F90stats_zm_module.F90stats_variables.F90advance_xm_wpxp_module.F90c32284c78f7aa9070afc4f0b61bed73ccf7ccdf31461896081000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor cam:ticket:59, I added a new output for Richardson number. It is not added to the default output file, so output is bin-diff identical in the default configuration. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8068 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: cad331d6bd01ccc55b8b797a5f502ed45477530f 2016-04-29 02:14:41 +0000c32284c78f7aa9070afc4f0b61bed73ccf7ccdf3For cam:ticket:59, I added a new output for Richardson number.editadvance_xm_wpxp_module.F90editstats_zm_module.F90editstats_variables.F90advance_clubb_core_module.F90model_flags.F90advance_xm_wpxp_module.F90advance_helper_module.F909d61a8bf2a1f6989dec2ad8c2b9d5d4454b4bfe61461965345000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor cam:ticket:59: I am adding an option to use a different formulation of `brunt_vaisala_frequency_sqd` in saturated air. This formula comes from Durran and Klemp (1982). As always, the change is wrapped in a flag, and output is bin-diff identical in the default configuration. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8069 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 41dcf2571aeebbf3725a54ad3c0da5e062769577 2016-04-29 21:29:05 +00009d61a8bf2a1f6989dec2ad8c2b9d5d4454b4bfe6For cam:ticket:59:editadvance_xm_wpxp_module.F90editadvance_helper_module.F90editadvance_clubb_core_module.F90editmodel_flags.F90advance_helper_module.F909e607955d0c529d4ef6b36f9378b6d08fa21137c1461965528000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduPer cam:ticket:59#comment:21, using `T_in_K_zm` in "the formula". git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8070 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 56b84fdb1a791cbe02cc4c810a8bac7f49c7704e 2016-04-29 21:32:08 +00009e607955d0c529d4ef6b36f9378b6d08fa21137cPer cam:ticket:59#comment:21, using `T_in_K_zm` in "the formula".editadvance_helper_module.F90advance_helper_module.F907682bbc205b4cd2c20021752e41e29fc76a4a8d01461966004000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor cam:ticket:59. Also, `rsat` should be `rsat_zm` where it appears in the formula, ''except'' when it appears inside of `ddzt()`. Right? git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8071 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 3f69d0d4521af585b55d8462f1eaa98e180189d6 2016-04-29 21:40:04 +00007682bbc205b4cd2c20021752e41e29fc76a4a8d0For cam:ticket:59.editadvance_helper_module.F90stats_variables.F90stats_zm_module.F90advance_xm_wpxp_module.F90f82218e2933997790453ec1d4f6990fdda8415e51462207493000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor cam:ticket:59 I renamed `Richardson_no` to `Richardson_num`. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8072 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: fdb08f1446b21bf3ba54158aac38d49e4d5ef7bd 2016-05-02 16:44:53 +0000f82218e2933997790453ec1d4f6990fdda8415e5For cam:ticket:59 I renamed `Richardson_no` to `Richardson_num`.editstats_variables.F90editstats_zm_module.F90editadvance_xm_wpxp_module.F90stats_zm_module.F90stats_variables.F90advance_xm_wpxp_module.F90c74225d16f9673c358f062b6f1e77a2c7cbd06381462231736000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor cam:ticket:59, I added kludgy statistical output for `brunt_vaisala_freq_sqd`. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8074 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 8fc0610745db2bf6e686f9d315b46fc8395c1cb9 2016-05-02 23:28:56 +0000c74225d16f9673c358f062b6f1e77a2c7cbd0638For cam:ticket:59, I added kludgy statistical output for `brunt_vaisala_freq_sqd`.editstats_zm_module.F90editadvance_xm_wpxp_module.F90editstats_variables.F90advance_xm_wpxp_module.F90604739065495ff559f032f191e99e9837e6671061462569196000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor cam:ticket:59: I added functionality to vertically average Richardson number based on Lscale. The option is turned off by default, so output should be bin-diff identical by default. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8083 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 6821e86becfff5f3144b4398a27ba261903f486d 2016-05-06 21:13:16 +0000604739065495ff559f032f191e99e9837e667106For cam:ticket:59:editadvance_xm_wpxp_module.F90advance_xm_wpxp_module.F90197f846d43da2f87e5f6f03a1862bd2ceeecc7cf1462570298000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor cam:ticket:59: Oops. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8084 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: e452ee71e4c3a0ec7bbb1dae710efe4b1209806f 2016-05-06 21:31:38 +0000197f846d43da2f87e5f6f03a1862bd2ceeecc7cfFor cam:ticket:59:editadvance_xm_wpxp_module.F90advance_helper_module.F90193b2356409331ff90c897b93d468ed501771a771462843057000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor cam:ticket:59: While reading through the code, I found an important bug in the moist Brunt-Vaisala code. Inside a `where` statement, I had calls to functions that take in an entire profile as input, such as `zt2zm` and `ddzt`. But the arguments to these functions where themselves initialized in the `where` statement! Therefore, much of the input profiles to these functions were likely uninitialized. Not good. This change affects only the case where `l_brunt_vaisala_freq_moist = T`, which is not the default. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8085 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 8ca078a9223a3a07a90e115f1f1d3296ea196896 2016-05-10 01:17:37 +0000193b2356409331ff90c897b93d468ed501771a77For cam:ticket:59:editadvance_helper_module.F90advance_xm_wpxp_module.F90c7d55c72919e58648dae4e5003586d21008765711463004560000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor cam:ticket:59. Refactoring: I renamed function `Richardson_num_vert_avg` to `Lscale_width_vert_avg` to make it clear it can be used for other variables. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8086 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: f56b3f11144798216e670da4f77fcd1579428676 2016-05-11 22:09:20 +0000c7d55c72919e58648dae4e5003586d2100876571For cam:ticket:59.editadvance_xm_wpxp_module.F90advance_xm_wpxp_module.F900522c9f194d6b51ad08844e40e84d5099e7820fc1463018454000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor cam:ticket:59: I set `Richardson_num_max` to five, and enabled by default code that vertically averages `C7_Skw_fnc` over a distance of `Lscale_zm`, as this seems to be closer to what we want. This only affects results when `l_use_C7_Richardson = T`, which is not the default. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8087 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 087970848c0e815d6b87a84d5d538e720ed6e95b 2016-05-12 02:00:54 +00000522c9f194d6b51ad08844e40e84d5099e7820fcFor cam:ticket:59:editadvance_xm_wpxp_module.F90advance_xm_wpxp_module.F904f0028b1d246bd6d16b5435fc172ecb34a354fc91463018684000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduApparently, I didn't have to jump through the hoop of declaring a separate profile to use in the `max` statement. Ref: cam:ticket:59. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8088 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: d3a45797366bc238c5b19441707cc0c9f7d99883 2016-05-12 02:04:44 +00004f0028b1d246bd6d16b5435fc172ecb34a354fc9Apparently, I didn't have to jump through the hoop of declaring a separate profile to use in the `max` statement.editadvance_xm_wpxp_module.F90advance_xm_wpxp_module.F9033af548fec392e63dabb9e2adc048c7c70c9fb861463086723000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor cam:ticket:59: I am adding exciting support for density-weighted vertical averaging (using function `fill_holes`) in averaging `C7_Skw_fnc`. This affects output if and only if `l_use_C7_Richardson = T`, which is not default. Changes are fairly minor. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8089 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: e37640c3132cadc52f0385ba3c8c3c832bccdf28 2016-05-12 20:58:43 +000033af548fec392e63dabb9e2adc048c7c70c9fb86For cam:ticket:59:editadvance_xm_wpxp_module.F90advance_xm_wpxp_module.F90d685dd943a6c479c2997e19bb4e8726eb947042b1463089066000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor cam:ticket:59: Refactoring: Virtual levels!!! I am refactoring the code to make use of "virtual levels". This lays the framework to allow below-ground levels to affect the vertical averaging. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8090 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: a6bdc7a8634bcac9b9caf5beb7f47313d515a0c6 2016-05-12 21:37:46 +0000d685dd943a6c479c2997e19bb4e8726eb947042bFor cam:ticket:59:editadvance_xm_wpxp_module.F90advance_xm_wpxp_module.F90c48216a85ed26f6c6f973e7e9bfad6ae6f6ff1731463093570000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor cam:ticket:59: I have set up the `l_use_C7_Richardson = T` code to include "virtual" vertical levels below ground in the vertical averaging of `C7_Skw_fnc`. Output shouldn't change in the default configuration. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8091 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 54d6826625f5e603cd3e348f3fd91c90a578ff83 2016-05-12 22:52:50 +0000c48216a85ed26f6c6f973e7e9bfad6ae6f6ff173For cam:ticket:59:editadvance_xm_wpxp_module.F90advance_clubb_core_module.F90parameters_tunable.F90parameter_indices.F90advance_windm_edsclrm_module.F90clubb_api_module.F900f756d77d387e7bbf34196f019648ffd855834601463518449000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor clubb:ticket:782: I merged NCAR's tag, !^/tags/ncar_tags/clubb_cK10_tags/clubb_cK10_n05_r8096, into the trunk. This commit mainly adds a new tuning parameter, `c_K10h`, which is related to `c_K10` but `c_K10h` is for thermodynamic levels. Keeping `c_K10 = c_K10h = 1.0` maintains current results. This commit is BIT_CHANGING, but only because a new tuning parameter was added, and apparently we are in the habit of outputting all tunable parameters in our NetCDF files. Numerically, NetCDF results should be identical. GrADS results are bin-diff identical for all (priority) cases. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8099 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 06bb00ff2f9e355d4115f2d3b0023e628fec704a 2016-05-17 20:54:09 +00000f756d77d387e7bbf34196f019648ffd85583460For clubb:ticket:782:editadvance_clubb_core_module.F90editadvance_windm_edsclrm_module.F90editparameter_indices.F90editparameters_tunable.F90editclubb_api_module.F90stats_variables.F90stats_zm_module.F90advance_clubb_core_module.F90model_flags.F90advance_xm_wpxp_module.F90advance_helper_module.F90fabce99c9f3c6239be758f17fa091f1615b44d171463527741000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor cam:ticket:59: I am bringing in the latest and greatest features from the `diag` branch back into the trunk. The changes are enhancements to the case where `l_use_C7_Richardson = T` (not default). Output is bin-diff identical in the default configuration. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8106 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 71595a55488b9463768ec15182052bbe4c767470 2016-05-17 23:29:01 +0000fabce99c9f3c6239be758f17fa091f1615b44d17For cam:ticket:59:editmodel_flags.F90editstats_variables.F90editstats_zm_module.F90editadvance_xm_wpxp_module.F90editadvance_helper_module.F90editadvance_clubb_core_module.F90stats_zm_module.F90d47e9225511e6b87d16e1a95e6aaec700ef71fdd1463590697000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor cam:ticket:59: I had to increase `nvarmax_zm` due to new statistics being added. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8108 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 50ad45cdc9d10b94c9245b6007e09262696c43c5 2016-05-18 16:58:17 +0000d47e9225511e6b87d16e1a95e6aaec700ef71fddFor cam:ticket:59:editstats_zm_module.F90advance_xm_wpxp_module.F90cc7ff036228d237f5777ed263151c838cd0a3d1b1463604255000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor cam:ticket:59: I reintroduced the ability to use `turb_freq_sqd` in the denominator of `Richardson_num` as a option set to false. I suppose this is better than commented out code. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8109 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 4de028682e1994f0206331aba28c9b3ac14c5ab7 2016-05-18 20:44:15 +0000cc7ff036228d237f5777ed263151c838cd0a3d1bFor cam:ticket:59:editadvance_xm_wpxp_module.F90advance_xm_wpxp_module.F902107752e392902007942d6fdf4b344f1f10bdf8e1463605180000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor cam:ticket:59: I am introducing a new option (non-default) to vertically average clipped `Richardson_num`. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8110 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: f5efc2c4006252b3d5f5278dab026c7f2a8ffdd6 2016-05-18 20:59:40 +00002107752e392902007942d6fdf4b344f1f10bdf8eFor cam:ticket:59:editadvance_xm_wpxp_module.F90advance_clubb_core_module.F9097c842511dae89f61397c68fe463edda9a62d84e1463625758000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor clubb:ticket:782: These changes augment clubb:r8099. I confined the declaration of `RHpostPDF` in a `CLUBB_CAM` preprocessor directive to resolve a compiler warning. I also added `c_K10h` to some error_*.in files for the tuner. This resolves the failure of the nightly FIRE tuner test last night. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8111 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: a3e3d9ef33520631972c02276aac7cd4df1459b8 2016-05-19 02:42:38 +000097c842511dae89f61397c68fe463edda9a62d84eFor clubb:ticket:782:editadvance_clubb_core_module.F90advance_xm_wpxp_module.F90491b13f63db3f99e5095c89562ecf4065fc69a181463700393000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor cam:ticket:59: I am committing parameter changes to the `l_use_C7_Richardson = T` code: * `Richardson_num_max = 200` * Vertical averaging of `Richardson_num` is enabled. * `Richardson_num` below ground is `0.5 * Richardson_num_max`. Output should be bin-diff identical in the default configuration. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8112 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: c4131f9f29baedbd678035f8d8aadecb08b68358 2016-05-19 23:26:33 +0000491b13f63db3f99e5095c89562ecf4065fc69a18For cam:ticket:59:editadvance_xm_wpxp_module.F90advance_xm_wpxp_module.F9078b1837f3871084d821505278bbb3f493870d6ed1464124838000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor cam:ticket:59, I fixed bugs in the `l_use_C7_Richardson=T` vertical averaging code: 1. The averaging levels should be within 0.5*Lscale, not Lscale. 2. The equation for the number of "below ground" levels was totally wrong. I must have been half asleep when I wrote that equation. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8113 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 0d38c52c98c6060f95ccb6e35be4b497ff8fff56 2016-05-24 21:20:38 +000078b1837f3871084d821505278bbb3f493870d6edFor cam:ticket:59, I fixed bugs in the `l_use_C7_Richardson=T` vertical averaging code:editadvance_xm_wpxp_module.F90advance_xm_wpxp_module.F90922aa61598b0b75ff0e72446efbc31737cd5b5e71464127537000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduI adjusted a comment. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8114 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: da6f1c25f65f4f89af732ac5081fe1ea932915c3 2016-05-24 22:05:37 +0000922aa61598b0b75ff0e72446efbc31737cd5b5e7I adjusted a comment.editadvance_xm_wpxp_module.F90advance_wp2_wp3_module.F90model_flags.F900fceb83bc012d5304422b23d42dd3b5ab083a9191464137943000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor clubb:ticket:788: I am adding support for "pressure term 3" (pr3) in wp3's equation set. `wp3_pr3` will be included in the equation only if `l_use_wp3_pr3 = T` (default false). The magnitude of `wp3_pr3` is dependent on `C16_fnc`. Currently, `C16_fnc` is hardcoded to be 0.5. In the near future, `wp3_pr3` will instead be based on `Richardson_num`, analogously to `C7_Skw_fnc`. Output is bin-diff identical in the default configuration. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8115 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 216c85147d343dad788bd34689f333e854ffb660 2016-05-25 00:59:03 +00000fceb83bc012d5304422b23d42dd3b5ab083a919For clubb:ticket:788:editmodel_flags.F90editadvance_wp2_wp3_module.F90stats_zm_module.F9065085f8ad1cd4a0a49f60d764d36faa0d47d18691464201509000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor cam:ticket:59: Minor correction to units: the Skw_fnc variables should have units of "-", not "count". Of course, this commit is BIT_CHANGING because units, which are written to the NetCDF files, have been changed. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8116 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: e7d892a1ae271bf6e3c6f8a20ff0ca2046b2b215 2016-05-25 18:38:29 +000065085f8ad1cd4a0a49f60d764d36faa0d47d1869For cam:ticket:59:editstats_zm_module.F90stats_variables.F90advance_wp2_wp3_module.F90stats_zt_module.F90f6f7a5aa8bc79938d9294f1d0d79c93f885daa481464315410000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor clubb:ticket:788: After a long battle, I finally got successful statistics outputting of the `wp3_pr3` term!!! Tests run: 1. Output is bin-diff if `l_use_wp3_pr3 = F` (default). 2. Output is bin-diff if `l_use_wp3_pr3 = T` and `C16_fnc(:) = 0.0`. 3. If `C16_fnc(:) = 1.0`, then the `wp3_pr3` term exactly opposes the sum of the `wp3_ta` and `wp3_tp` terms when overplotted. Furthermore, after adding `wp3_pr3` into the `wp3_residual` equation, `wp3_residual` is zero! (That is, the bu dget balances.) That code in `advance_wp2_wp3_module.F90` is pretty intricate, eh? git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8117 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 313f0faf6a0fc63ab241027943c8498096bbe599 2016-05-27 02:16:50 +0000f6f7a5aa8bc79938d9294f1d0d79c93f885daa48For clubb:ticket:788:editstats_variables.F90editadvance_wp2_wp3_module.F90editstats_zt_module.F90advance_xm_wpxp_module.F90advance_helper_module.F9011fdf543bc3a7f58254d8fbe13b5153b70823f431464625455000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor clubb:ticket:788: Refactoring: I moved `compute_C7_Skw_fnc_Richardson` and `Lscale_width_vert_avg` to `advance_helper_module.F90`. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8118 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 0811835821202839f23ac52b2703a7ef1fc95472 2016-05-30 16:24:15 +000011fdf543bc3a7f58254d8fbe13b5153b70823f43For clubb:ticket:788:editadvance_xm_wpxp_module.F90editadvance_helper_module.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90advance_helper_module.F90206f04854099eb063ed1693d2920c0c7645630c01464628703000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor clubb:ticket:788: Refactoring: I renamed `compute_C7_Skw_fnc_Richardson` to `compute_Cx_fnc_Richardson`. I pulled out the computation of `Cx_fnc_Richardson` to `advance_clubb_core_module` and passed `Cx_fnc_Richardson` to `advance_xm_wpxp`, where it is used to set `C7_Skw_fnc`. Output is bin-diff identical for some test cases. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8119 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: e9d6955c8a6dff6139dbc4945304625a4477c0d1 2016-05-30 17:18:23 +0000206f04854099eb063ed1693d2920c0c7645630c0For clubb:ticket:788:editadvance_clubb_core_module.F90editadvance_helper_module.F90editadvance_xm_wpxp_module.F90advance_clubb_core_module.F90advance_wp2_wp3_module.F904e1247dd422e18086b059476e7133b703d36ac811464629432000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor clubb:ticket:788: I am using `Cx_fnc_Richardson` to set `C16_fnc` in subroutine `advance_wp2_wp3`. This should affect output if and only if `l_use_wp3_pr3 = T` (default `F`). git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8120 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 918f896b3a551678cf5c156adfd2c04000958a12 2016-05-30 17:30:32 +00004e1247dd422e18086b059476e7133b703d36ac81For clubb:ticket:788:editadvance_clubb_core_module.F90editadvance_wp2_wp3_module.F90advance_helper_module.F9043a1c71b99857c13815467fcdacd4d0cc18253f71464747298000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor clubb:ticket:788: Damage control: I am adding lines that clip `C7_Skw_fnc` (which should now be renamed to `Cx_fnc_Richardson` in this context) to be within the range [0,1]. Apparently, on at least Intel (see build:15667), roundoff error can leave `C7_Skw_fnc` slightly outside this range. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8129 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 4675048a0d54c86064366ca667174c5a403d6462 2016-06-01 02:14:58 +000043a1c71b99857c13815467fcdacd4d0cc18253f7For clubb:ticket:788:editadvance_helper_module.F90advance_helper_module.F90a962121436c1d8fe111f625513733b6e28d5c9831465496116000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduRenamed C7 to Cx in appropriate places. Ref: cam:ticket:59 git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8130 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 9db4228a9996907f46488ec7e6733cdf28e58ab0 2016-06-09 18:15:16 +0000a962121436c1d8fe111f625513733b6e28d5c983Renamed C7 to Cx in appropriate places.editadvance_helper_module.F90advance_helper_module.F9071e67a099e4ecd80abfd3d6e0d25acfa5c6334cb1465587760000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor cam:ticket:59: I am effectively disabling the use of `shear_sqd` in computing `Richardson_num` in the default code. Output should be affected only in non-default code. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8131 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 6f10cf99569442c0bfb8b4814d6528669e5f1b00 2016-06-10 19:42:40 +000071e67a099e4ecd80abfd3d6e0d25acfa5c6334cbFor cam:ticket:59:editadvance_helper_module.F90advance_helper_module.F90d49aa6e935a68e226ab41d125afb5e1a8c68d0521465606774000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor cam:ticket:59: I am committing various changes to the `Richardson_num` code, such as increasing the averaging width and the `Richardson_num` below-ground value. Output changes only in non-default (i.e., esoteric) configurations of CLUBB. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8132 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 0fb298192f03271b416be42967f0283db679eade 2016-06-11 00:59:34 +0000d49aa6e935a68e226ab41d125afb5e1a8c68d052For cam:ticket:59:editadvance_helper_module.F90advance_helper_module.F90b5cf8ffd94155c1b1eb83dc383b8adffc62e150a1465758756000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduI made it a default to use 0 instead of cloud_frac_min in the B.V. frequency calculation. I also changed `Richardson_num_max` to 400. This commit will affect CLUBB output only in non-default configurations. Ref: cam:ticket:61. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8133 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 5e9cf12eca6b97bf81881796ef7f1ebcde68a4e7 2016-06-12 19:12:36 +0000b5cf8ffd94155c1b1eb83dc383b8adffc62e150aI made it a default to use 0 instead of cloud_frac_min in the B.V. frequency calculation.editadvance_helper_module.F90mixing_length.F90be1c3106832fe19595c6446e12a254d55b452fc11467930965000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor cam:ticket:67: I refactored the computation of rsatl_par_j into a function. Output is bin-diff identical. In the future, this function will do many exciting things. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8180 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 6939bd1b43cee733a2028da7bbb654f5427a106f 2016-07-07 22:36:05 +0000be1c3106832fe19595c6446e12a254d55b452fc1For cam:ticket:67:editmixing_length.F90mixing_length.F909241d3160bc3f08cea06a367363bac429b0a48011467933236000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor cam:ticket:67: I added the ability to use ice in the computation of rsatl_par. This is wrapped in a flag, `l_include_ice`, which is F by default, keeping output bin-diff. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8182 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: f69754e5f7c966f12ce435d22662adcb41959f50 2016-07-07 23:13:56 +00009241d3160bc3f08cea06a367363bac429b0a4801For cam:ticket:67:editmixing_length.F90mixing_length.F90a65a2716e9a84c14d8ce00274c7d8ceb64cec15b1467934375000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduCode improvements. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8183 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 784a92ac88af2f4b23ccd2a75d95f6044beef1d5 2016-07-07 23:32:55 +0000a65a2716e9a84c14d8ce00274c7d8ceb64cec15bCode improvements.editmixing_length.F90mixing_length.F901241c9306c125114c5e2cf74fa5ddf3c0c575ce21467935024000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduVince noticed that `sat_mixrat_liq` or `sat_mixrat_ice` will be left uninitialized if `sat_ice_ratio == 0` or `sat_ice_ratio == 1`. No more! For cam:ticket:67. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8185 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 1a2d64da0eaa23681153f9377c943ba076f6f7d9 2016-07-07 23:43:44 +00001241c9306c125114c5e2cf74fa5ddf3c0c575ce2Vince noticed that `sat_mixrat_liq` or `sat_mixrat_ice` will be left uninitialized if `sat_ice_ratio == 0` or `sat_ice_ratio == 1`. No more!editmixing_length.F90setup_clubb_pdf_params.F90bb6808a33f9a42df19a9d0a3f2d28fe1e7df96bb1468432966000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor cam:ticket:32, I made `hydrometp2` `intent(out)` in CLUBB, since the input value is not used. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8195 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 4bfa90e34669bb3e6b15b9b4307a62567624763a 2016-07-13 18:02:46 +0000bb6808a33f9a42df19a9d0a3f2d28fe1e7df96bbFor cam:ticket:32, I made `hydrometp2` `intent(out)` in CLUBB, since the input value is not used.editsetup_clubb_pdf_params.F90setup_clubb_pdf_params.F90aa8a3d9da135f520be59cdf4a39b6835519350ab1468433903000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFixed a comment. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8196 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 8551b37c3d21f0eefe0678cb265e12d0d7546021 2016-07-13 18:18:23 +0000aa8a3d9da135f520be59cdf4a39b6835519350abFixed a comment.editsetup_clubb_pdf_params.F90advance_wp2_wp3_module.F904457ce79704986f96788b965685a759a6a14654d1468627919000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor clubb:ticket:788: I made sure `wp3_pr3_rhs` was initialized when `l_use_wp3_pr3 = F`, so that zero is output to stats, rather than an uninitialized variable. This should resolve the failures of the Nightly Uninitialized Variables Test (build:15959) and the Nightly OpenMP Test (build:15953) last night. This commit is BIT_CHANGING because a variable which was output as uninitialized (usually NaN) before is now output as zero. However, answers remain unchanged as long as `l_use_wp3_pr3 = F`. It is worth noting that clubb:r8198 also caused the Nightly Bin Diff Regression Test (build:15948) to fail because it added a stats output and was not marked with a BIT_CHANGING tag. Including the tag in this commit will resolve that failure, and we should see a lovely shade of spring green tomorrow morning. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8199 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 88ee4f1f9682fbaf959972a78008162165f1b04f 2016-07-16 00:11:59 +00004457ce79704986f96788b965685a759a6a14654dFor clubb:ticket:788:editadvance_wp2_wp3_module.F90model_flags.F90942ecdc6d4c071de7a24f6eb24c549ec417eddb41468876031000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor clubb:ticket:792: I changed some CLUBB parameters: {{{ l_vert_avg_closure = .false. l_trapezoidal_rule_zt = .false. l_trapezoidal_rule_zm = .false. l_call_pdf_closure_twice = .false. l_use_cloud_cover = .false. }}} This commit is BIT_CHANGING: answers will be changed in all cases. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8200 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 8b469e885afa1be9b6055abc2a7d52ae6fe7d8fe 2016-07-18 21:07:11 +0000942ecdc6d4c071de7a24f6eb24c549ec417eddb4For clubb:ticket:792:editmodel_flags.F90advance_clubb_core_module.F90842f4771aae526e1c2614eecca67aa77b12ac1ce1468888712000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor clubb:ticket:792: I initialized some variables that were before uninitialized when `l_vert_avg_closure = F`. These uninitialized variables were used only for stats. This commit is BIT_CHANGING in the "_zm" output file because some variables, such as `cloud_frac_zm`, that were output as undefined before are now output as zero. However, the simulation result does not change as a result of this commit. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8201 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 21ad814bfcfd439dd5faf226745d30aad397a9f7 2016-07-19 00:38:32 +0000842f4771aae526e1c2614eecca67aa77b12ac1ceFor clubb:ticket:792:editadvance_clubb_core_module.F90advance_clubb_core_module.F905097bb3b46bc376688d970c63fcfc2b2dbe81ea51468951858000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor clubb:ticket:792, I added more initializations for uninitialized variables. This commit is probably BIT_CHANGING, because output variables that were uninitialized are now output as zero. With this commit, CLUBB runs to completion with the Oracle compiler, resolving build:15997. Hopefully the OpenMP test (build:15991) will follow suit. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8202 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: e37f06af1cecae4ccd91298942c3fc3c9bb3780f 2016-07-19 18:10:58 +00005097bb3b46bc376688d970c63fcfc2b2dbe81ea5For clubb:ticket:792, I added more initializations for uninitialized variables.editadvance_clubb_core_module.F90advance_clubb_core_module.F90afa64ca95f3398b1df10f9d3159711a052d12a6b1468957085000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduWhen l_avg_Lscale is turned on but the plume-centered calculation is disabled, I changed the "sample points" chosen to pick the theta-l point associated with the rt point based on the sign of rtpthlp. Since the l_avg_Lscale flag is turned off my default, the results found in GrADS output files from this revision are an exact match to the results found in GrADS output files from the previous revision for all cases. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8203 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: a98b05fd3e2d332d890fbdf8130ed339f2238b09 2016-07-19 19:38:05 +0000afa64ca95f3398b1df10f9d3159711a052d12a6bWhen l_avg_Lscale is turned on but the plume-centered calculation is disabled,editadvance_clubb_core_module.F90advance_clubb_core_module.F90model_flags.F90output_grads.F90eb0be9200bae51409573b16aaab4d408214770031468966137000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor clubb:ticket:792: I removed the `CLUBB_CAM` preprocessor directive surrounding the RH_postPDF fix, and instead added a new flag, `l_rcm_supersat_adj`, set to false by default. This changeset produces bin-diff identical output. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8204 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: d2869a87f94e19e634e8eaaf6ca296f21994506f 2016-07-19 22:08:57 +0000eb0be9200bae51409573b16aaab4d40821477003For clubb:ticket:792:editoutput_grads.F90editmodel_flags.F90editadvance_clubb_core_module.F90stats_variables.F90stats_clubb_utilities.F90advance_clubb_core_module.F90stats_zt_module.F903137b73c6c8a14a6eec8eee3cf7c53ae38420b2e1468967755000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor clubb:ticket:792, I added a new stats output, `rcm_supersat_adj`, to record the degree of rcm adjustment. It is not output by default. This changeset does not change output. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8205 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: c399236ebfe9a2691198f3f87952e0a757833a2e 2016-07-19 22:35:55 +00003137b73c6c8a14a6eec8eee3cf7c53ae38420b2eFor clubb:ticket:792, I added a new stats output, `rcm_supersat_adj`, to record the degree of rcm adjustment. It is not output by default. This changeset does not change output.editstats_variables.F90editstats_clubb_utilities.F90editstats_zt_module.F90editadvance_clubb_core_module.F90advance_clubb_core_module.F90f61e9048127a441fc4fce451ecf7a25f4a3eb9c51468971135000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduI renamed RH_postPDF to rel_humidity. For clubb:ticket:792. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8206 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: c3a4c87b8438e6b3bd9404e5b16a5fb09d05e391 2016-07-19 23:32:15 +0000f61e9048127a441fc4fce451ecf7a25f4a3eb9c5I renamed RH_postPDF to rel_humidity.editadvance_clubb_core_module.F90advance_clubb_core_module.F902b9c0abf5f05672f14e2ffc9c479ec51c03eb1871468977586000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor clubb:ticket:792. rsat actually should be recomputed here before output, because it will change if `l_rcm_supersat_adj = T`. This commit doesn't change output by default, because `l_rcm_supersat_adj = F`. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8207 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 424d83775df122fb2114c6dc7a3276a63690a881 2016-07-20 01:19:46 +00002b9c0abf5f05672f14e2ffc9c479ec51c03eb187For clubb:ticket:792. rsat actually should be recomputed here before output, because it will change if `l_rcm_supersat_adj = T`.editadvance_clubb_core_module.F90advance_clubb_core_module.F90b5e36c5cc98bee2a71b6e1aac647ef04740481ca1468977936000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor clubb:ticket:792. I am reusing the `rel_humidity` variable for output, for no particular reason. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8208 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: c3aef1ca27eb0b5ce179c9910fe52cea575dbb33 2016-07-20 01:25:36 +0000b5e36c5cc98bee2a71b6e1aac647ef04740481caFor clubb:ticket:792. I am reusing the `rel_humidity` variable for output, for no particular reason.editadvance_clubb_core_module.F90model_flags.F90f0c489f1ec91fede9e93674f5ad8da5adcc72ff21468978272000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor clubb:ticket:792!!!! I set `l_rcm_supersat_adj = T` by default, in both source code and namelist. This commit is BIT_CHANGING. For most cases, results do not change because `l_vert_avg_closure = F`. However, at least twp_ice changes slightly. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8209 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: e6bc9207fc8f2130454a06cbca7fbcffe4860805 2016-07-20 01:31:12 +0000f0c489f1ec91fede9e93674f5ad8da5adcc72ff2For clubb:ticket:792!!!! I set `l_rcm_supersat_adj = T` by default, in both source code and namelist.editmodel_flags.F90advance_clubb_core_module.F9085557a043ebf71d33df4cb766e602ecc4a5073461468979135000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduAs requested, I am adding a warning message (debug level 1) when spurious supersaturation is removed. For clubb:ticket:792. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8210 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: a2c8d6b5c2bfd632c12e47335b95d5fba6e9dc1a 2016-07-20 01:45:35 +000085557a043ebf71d33df4cb766e602ecc4a507346As requested, I am adding a warning message (debug level 1) when spurious supersaturation is removed.editadvance_clubb_core_module.F90advance_clubb_core_module.F905a524a2d05c67e5b0eba255e0804760871ccbca61468979203000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduComment. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8211 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: d58325cd8606f6c4461777a20d0d1b0c3f13a68d 2016-07-20 01:46:43 +00005a524a2d05c67e5b0eba255e0804760871ccbca6Comment.editadvance_clubb_core_module.F90stats_variables.F90421941ece8fe45eff7e5382bf99596c2c681e5271469028463000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor clubb:ticket:788, I added a threadprivate entry for `iwp3_pr3`, which will hopefully resolve the failure of the OpenMP test (build:16010). git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8212 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 41002aa1be883eea7f5cee997cf5384d81c4a333 2016-07-20 15:27:43 +0000421941ece8fe45eff7e5382bf99596c2c681e527For clubb:ticket:788, I added a threadprivate entry for `iwp3_pr3`, which will hopefully resolve the failure of the OpenMP test (build:16010).editstats_variables.F90output_grads.F903cd78611e048d03e25589bae4bd6d754156d9a991469031826000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduI removed a spurious print statement. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8216 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: d0b98149fb8261c773b77d91b7feada06c134e41 2016-07-20 16:23:46 +00003cd78611e048d03e25589bae4bd6d754156d9a99I removed a spurious print statement.editoutput_grads.F90advance_wp2_wp3_module.F90parameters_tunable.F90model_flags.F90parameter_indices.F90clubb_api_module.F90surface_varnce_module.F90e20752ab491ab93d8c23011bad3f73e6c914a7c91469126912000http://carson.math.uwm.edu/jenkins/user/rautrautraut@uwm.eduFor cam:ticket:73: To facilitate committing tuning changes to CAM, I added a new tuning parameter, `up2_vp2_factor`, and a new flag, `l_use_C11_Richardson`. I made various other changes. Output is bin-diff identical for all cases. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8220 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: adaa047dde0e71089e9f336095fa038de4fb2a6d 2016-07-21 18:48:32 +0000e20752ab491ab93d8c23011bad3f73e6c914a7c9For cam:ticket:73:editclubb_api_module.F90editsurface_varnce_module.F90editparameters_tunable.F90editadvance_wp2_wp3_module.F90editmodel_flags.F90editparameter_indices.F90sponge_layer_damping.F90advance_windm_edsclrm_module.F90advance_xm_wpxp_module.F90644805cc11020c09f7f7341fac1620b7cdb6200e1470267879000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am beginning to generalize the sponge damping code so that it can be applied to fields such as wp2, up2, and vp2. As part of this change, I am reverting the interpolation of sponge damping time scale, tau_sponge_damp, from linear interpolation to the kind of interpolation that is used in SAM LES. Since the CGILS cases use sponge damping for mean fields toward the top of the domain, the results of this change will be BIT_CHANGING. However, the effect is minor. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8228 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 23464bb22b7d8a9ce22bd69c0495c047bb5cc36c 2016-08-03 23:44:39 +0000644805cc11020c09f7f7341fac1620b7cdb6200eI am beginning to generalize the sponge damping code so that it can be applied toeditadvance_windm_edsclrm_module.F90editsponge_layer_damping.F90editadvance_xm_wpxp_module.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90stats_variables.F90stats_zm_module.F90sponge_layer_damping.F90stats_zt_module.F900c83ceeaa0aa916808a262473b8df43bb02fdfb31470353741000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI have added all the coding infrastructure to perform sponge damping (and record its effects on the budgets) for wp2, wp3, up2, and vp2. This code is turned off by default. Additionally, I haven't added the stats to stats.in files yet. As a result, the results found in GrADS output files from this revision are an exact match to the results found in GrADS output files from the previous revision for all cases. Larson Group Internal Trac System Reference: papers:ticket:14. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8229 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: abe95893a6e5716d55769a9090c78f29be20d886 2016-08-04 23:35:41 +00000c83ceeaa0aa916808a262473b8df43bb02fdfb3I have added all the coding infrastructure to perform sponge damping (and recordeditstats_zt_module.F90editadvance_wp2_wp3_module.F90editadvance_xp2_xpyp_module.F90editsponge_layer_damping.F90editstats_variables.F90editstats_zm_module.F90index_mapping.F90bde6e65ded8cec97c1df34c94091e882b55408e41475159422000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.edu I added comments about the two sets of indices in CLUBB, the ii indices and the iiPDF indices. These are used to index the hydrometeors and PDF variates, respectively. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8255 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 9657730a0639973c1006be330637e3d9fcc56150 2016-09-29 14:30:22 +0000bde6e65ded8cec97c1df34c94091e882b55408e4editindex_mapping.F90stats_variables.F90stats_lh_sfc_module.F90b6c2764136da24f7734273fe582d1021db667c101476799815000http://carson.math.uwm.edu/jenkins/user/roessle9roessle9roessle9@uwm.educlubb:ticket:796 I added the sum and the average of the sample point weights to the lh surface output. The variables are called lh_sample_weights_sum and lh_sample_weights_avg and will be written with the standard_stats output configuration. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8261 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 367b148899348e1a912288af135c165818fab7e9 2016-10-18 14:10:15 +0000b6c2764136da24f7734273fe582d1021db667c10clubb:ticket:796editstats_lh_sfc_module.F90editstats_variables.F90parameters_tunable.F90a3ffb88e1500efe97673ee2d43487617c0a0ff241476822775000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added some parameter value checking in subroutine setup_parameters. When l_clip_semi_implicit is set to .false. (which it is by default), the new code enforces C6rt = C6thl, C6rtb = C6thlb, C6rtc = C6thlc, and C6rt_Lscale0 = C6thl_Lscale0. This will prevent an inconsistent calculation of wpthlp_pr1 in this scenario, while preventing the user from thinking that the C6thl set of parameters do anything in this scenario. Larson Group Internal Trac System Reference: clubb:ticket:794. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8262 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: bf2c9cc9ecbd57d0b8023e100f1d73156d055b65 2016-10-18 20:32:55 +0000a3ffb88e1500efe97673ee2d43487617c0a0ff24I added some parameter value checking in subroutine setup_parameters.editparameters_tunable.F90advance_clubb_core_module.F90c0f71070adf163ea058fe79592c6d476aadc2aa61480576433000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI finally have a standalone version of the new subroutine, generate_pdf_params, that compiles. It is not currently called from any point in the code. Just getting this ready has been an accomplishment. Larson Group Internal Trac System Reference: cam:ticket:87. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/branches/reorder_advance_clubb_core@8281 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: f8d6c7c4529e72e216b9de62b7dfe2aedf44f438 2016-12-01 07:13:53 +0000c0f71070adf163ea058fe79592c6d476aadc2aa6I finally have a standalone version of the new subroutine, generate_pdf_params,editadvance_clubb_core_module.F90advance_clubb_core_module.F90f5ee4a59559816b441a43d16faeb8b458ea8065a1480577925000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduSome code within advance_clubb_core that is found within CAM_CLUBB preprocessor flags requests rcp2_zt and thlprcp as output. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/branches/reorder_advance_clubb_core@8282 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 198ec6e782719c2321a23acf48820ea841761e1c 2016-12-01 07:38:45 +0000f5ee4a59559816b441a43d16faeb8b458ea8065aSome code within advance_clubb_core that is found within CAM_CLUBB preprocessoreditadvance_clubb_core_module.F90advance_clubb_core_module.F9033092de95e77d84d9857adebcf870b293cb613cd1480581434000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduThe perturbation Lscale code requires rtm_frz, thlm_frz, and pdf_params_frz to be output from generate_pdf_params, and the stats_accumulate code requires that rcm_supersat_adj is output as well. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/branches/reorder_advance_clubb_core@8283 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 1cb9f8be3845cc6a7aa6cf3c372cdf9491c02d19 2016-12-01 08:37:14 +000033092de95e77d84d9857adebcf870b293cb613cdThe perturbation Lscale code requires rtm_frz, thlm_frz, and pdf_params_frz toeditadvance_clubb_core_module.F90advance_clubb_core_module.F90617c5f2a850ab442bd934af221554ae218fcccbb1480581973000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added a missing intent(out) statement. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/branches/reorder_advance_clubb_core@8284 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: b5482df6be9a1bf3edac10c606dfb183ca5c6cd6 2016-12-01 08:46:13 +0000617c5f2a850ab442bd934af221554ae218fcccbbI added a missing intent(out) statement.editadvance_clubb_core_module.F90advance_clubb_core_module.F907cc27e32c42a7c9441b678648e3aa91f8280d0381480615444000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI have interfaced the new subroutine containing all of the PDF closure-related stuff with the code. When the subroutine call is made from the location of the code it is replacing, the results in GrADS output files from the new revision are an exact match to the results in GrADS output files from the previous revision for all cases using CLUBB's default configuration. Larson Group Internal Trac System Reference: cam:ticket:87. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/branches/reorder_advance_clubb_core@8285 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: ce07a9d5a621c43d084c67071fa3f694be010651 2016-12-01 18:04:04 +00007cc27e32c42a7c9441b678648e3aa91f8280d038I have interfaced the new subroutine containing all of the PDF closure-relatededitadvance_clubb_core_module.F90advance_clubb_core_module.F901cece97462a9a5d534b5130012ed38d5b9e23d661480616963000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI got rid of some variables that were brought into advance_clubb_core by use statements that are no longer necessary. This eliminates new compiler warnings. Larson Group Internal Trac System Reference: cam:ticket:87. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/branches/reorder_advance_clubb_core@8286 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 48e38f266be67c2ef7af997b682505434d7541c3 2016-12-01 18:29:23 +00001cece97462a9a5d534b5130012ed38d5b9e23d66I got rid of some variables that were brought into advance_clubb_core by use statementseditadvance_clubb_core_module.F90advance_clubb_core_module.F9074d4f7f23ddc2d22d680a6c63cd3fedd86ab83f91480617705000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI cleaned up more compiler warnings for unused variables. The warnings came from g95. Larson Group Internal Trac System Reference: cam:ticket:87. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/branches/reorder_advance_clubb_core@8287 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: ae7227875369b954d7e996e6ba845fb0cf8e6fdb 2016-12-01 18:41:45 +000074d4f7f23ddc2d22d680a6c63cd3fedd86ab83f9I cleaned up more compiler warnings for unused variables. The warnings came from g95.editadvance_clubb_core_module.F90advance_clubb_core_module.F9065844eccfd6e78d303f9e2b529eabf24f0e95fd61480696738000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI have added a second call to subroutine generate_pdf_params. This one occurs after predictive fields have been advanced. I have also added code to call generate_pdf_params at its original location, at the new location, or at both locations. The appropriate anti-idiot code is currently located in advance_clubb_core, but will be moved in the future. Larson Group Internal Trac System Reference: cam:ticket:87. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/branches/reorder_advance_clubb_core@8288 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: da44da508e6af8609aa44a634f1a8a8ecfef9fd5 2016-12-02 16:38:58 +000065844eccfd6e78d303f9e2b529eabf24f0e95fd6I have added a second call to subroutine generate_pdf_params. This one occurseditadvance_clubb_core_module.F90advance_clubb_core_module.F90652b8ad1bd732665a1c5e813186c434fe84ef4f41480701998000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI moved the setting of qclvar and thlprcp_out to after the second call to subroutine generate_pdf_params. This way, rcp2_zt and thlprcp don't need to be passed in and out of subroutine advance_clubb_core. Larson Group Internal Trac System Reference: cam:ticket:87. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/branches/reorder_advance_clubb_core@8289 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: b0697278dc51c875d2131da2dd818c6566983029 2016-12-02 18:06:38 +0000652b8ad1bd732665a1c5e813186c434fe84ef4f4I moved the setting of qclvar and thlprcp_out to after the second call toeditadvance_clubb_core_module.F90advance_clubb_core_module.F90f2b2a33f8d2799df9309411d6a38c945f6e0d69d1480704149000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI have declared the l_use_ice_latent option and the l_call_pdf_closure_twice option to be imcompatible with the ipdf_post_advance_fields option. This prevents seldom-used variables, such as rtm_frz, thlm_prz, pdf_params_frz, and pdf_params_zm, from having to be passed in and out of subroutine advance_clubb_core when the PDF is only called after predictive fields have been advanced. Larson Group Internal Trac System Reference: cam:ticket:87. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/branches/reorder_advance_clubb_core@8290 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 7fd1cf79fe8112f1d96b0e8eb56b700190daef28 2016-12-02 18:42:29 +0000f2b2a33f8d2799df9309411d6a38c945f6e0d69dI have declared the l_use_ice_latent option and the l_call_pdf_closure_twiceeditadvance_clubb_core_module.F90advance_clubb_core_module.F9066ed30caf14d248db6cf1fcdf4f13abb1a2ec0531480705448000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added a local cslculation of sigma_sqd_w near the top of subroutine advance_clubb_core in a scenario when the PDF is not called until after the advancement of the predictive fields (in other words, when ipdf_post_advance_fields is selected). Larson Group Internal Trac System Reference: cam:ticket:87. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/branches/reorder_advance_clubb_core@8291 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: b8c687375bd2a3ba9f8f113597ee02e6a66b440b 2016-12-02 19:04:08 +000066ed30caf14d248db6cf1fcdf4f13abb1a2ec053I added a local cslculation of sigma_sqd_w near the top of subroutineeditadvance_clubb_core_module.F90advance_clubb_core_module.F90clubb_api_module.F905d635a9256509ec7a5a327a323966cc64f5c58a41480710048000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am changing the inputs and outputs of subroutine advance_clubb_core so that rcm, cloud_frac, wpthvp, wp2thvp, rtpthvp, thlpthvp, sclrpthvp, and pdf_params are all passed through as intent(inout) variables. This change allows for CLUBB's PDF to be called after the predictive fields are advanced when the appropriate option is set. The results in GrADS output files from this revision are an exact match to the results in GrADS output files from the previous revision for all cases. The default option is still to call CLUBB's PDF in its historical location, which is prior to the advancement of the predictive fields. Larson Group Internal Trac System Reference: cam:ticket:87. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/branches/reorder_advance_clubb_core@8293 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 9e49c5e8030cb7838d4a1582f3a6c2aa3ee93f05 2016-12-02 20:20:48 +00005d635a9256509ec7a5a327a323966cc64f5c58a4I am changing the inputs and outputs of subroutine advance_clubb_core so thateditadvance_clubb_core_module.F90editclubb_api_module.F90advance_clubb_core_module.F90090114c800f5dbd574978c07c4d5558ca86c69ee1480785769000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added code so that stats that are internal to subroutine generate_pdf_params are only called once every model timestep when the ipdf_pre_post_advance_fields option, which calls the aforementioned subroutine twice, is called. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/branches/reorder_advance_clubb_core@8294 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 1b25e9166559c4323fc8182969a948e9397c9c39 2016-12-03 17:22:49 +0000090114c800f5dbd574978c07c4d5558ca86c69eeI added code so that stats that are internal to subroutine generate_pdf_paramseditadvance_clubb_core_module.F90advance_clubb_core_module.F90clubb_api_module.F90582c3bf747b2fa69443e8f75e18dae7c861ecb4c1481662775000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI have updated subroutine advance_clubb_core so that pdf_params_zm is now passed into and out of it as an intent(inout) variables. This enables it to be preserved from timestep to timestep. This also removes the flag l_call_pdf_closure_twice from being blacklisted when ipdf_post_advance_fields is used as the ipdf_call_placement option. The results in GrADS output files from this revision are an exact match to the results in GrADS output files from the previous revision of this branch for all cases (with the default configuration of ipdf_call_placement = ipdf_pre_advance_fields). Larson Group Internal Trac System Reference: cam:ticket:87. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/branches/reorder_advance_clubb_core@8314 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 7326a7a09d64f47ad1738b2f42b3752f9ccc1bcf 2016-12-13 20:59:35 +0000582c3bf747b2fa69443e8f75e18dae7c861ecb4cI have updated subroutine advance_clubb_core so that pdf_params_zm is now passededitclubb_api_module.F90editadvance_clubb_core_module.F90index_mapping.F90diagnose_correlations_module.F90setup_clubb_pdf_params.F90array_index.F90clubb_api_module.F90corr_varnce_module.F90cdaeea61eda638c5b85824407830ec4b16a5abe51484122852000http://carson.math.uwm.edu/jenkins/user/savvasavvasavva@uwm.eduTicket #799 -- Moved iiPDF_... module variables from module corr_varnce_module to module array_index -- The results of the priority cases are bin-diff identical git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8339 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: eebc4d9c6aec2d6a54b9769d4dbac2a14ee20c8f 2017-01-11 08:20:52 +0000cdaeea61eda638c5b85824407830ec4b16a5abe5Ticket #799 -- Moved iiPDF_... module variables from module corr_varnce_module to module array_index -- The results of the priority cases are bin-diff identicaleditindex_mapping.F90editarray_index.F90editcorr_varnce_module.F90editdiagnose_correlations_module.F90editclubb_api_module.F90editsetup_clubb_pdf_params.F90diagnose_correlations_module.F90index_mapping.F90setup_clubb_pdf_params.F90clubb_api_module.F90matrix_operations.F90corr_varnce_module.F902d21676fa45bca8e71ae19a0844aba77789b41271484287146000http://carson.math.uwm.edu/jenkins/user/savvasavvasavva@uwm.eduTicket #798 -- Renamed d_variables to pdf_dim -- The results of the priority cases are bin-diff identical git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8341 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 94b0bd96aa64476c342b0fa90bbf9c28df1fb468 2017-01-13 05:59:06 +00002d21676fa45bca8e71ae19a0844aba77789b4127Ticket #798 -- Renamed d_variables to pdf_dim -- The results of the priority cases are bin-diff identicaleditmatrix_operations.F90editdiagnose_correlations_module.F90editsetup_clubb_pdf_params.F90editcorr_varnce_module.F90editclubb_api_module.F90editindex_mapping.F90advance_clubb_core_module.F90729952dc7d1cce36a1243a7968fc10b1f9d5e4821484944004000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.edu I added a blank line, which will not change answers. However, it will test if the AUTO_COMMIT feature is still working after other:r537. For other:ticket:439. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8346 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: b9caa5a3e8936342fc662afee698c65f32fe02cb 2017-01-20 20:26:44 +0000729952dc7d1cce36a1243a7968fc10b1f9d5e482editadvance_clubb_core_module.F90advance_clubb_core_module.F90129209e51573452d8eef3328cff95a1aa34db1e91485187160000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.edu I added a blank line merely to trigger the AUTO_COMMIT updater. It won't change answers. For other:ticket:439. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8347 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 15a16bb6e0e12fb0b4afa9e1f386936a471d7f93 2017-01-23 15:59:20 +0000129209e51573452d8eef3328cff95a1aa34db1e9editadvance_clubb_core_module.F90pdf_parameter_module.F90f613fb4ce5602b4624d4637df30dd3069057a94c1485383631000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added a new subroutine, init_pdf_params, to pdf_parameter_module.F90. This allows for an easier way of initializing variables of type pdf_parameter. The results in GrADS output files from this revision are an exact match to the results in GrADS output files from the previous revision for all cases. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8348 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 0411cc2ab856908a8153bc51bdcdc93638767e24 2017-01-25 22:33:51 +0000f613fb4ce5602b4624d4637df30dd3069057a94cI added a new subroutine, init_pdf_params, to pdf_parameter_module.F90.editpdf_parameter_module.F90pdf_parameter_module.F90setup_clubb_pdf_params.F90baeba5205aa0fdde1c16c1d735011a9d6eeb96fd1485385275000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI renamed the subroutine pack_pdf_params found in setup_clubb_pdf_params.F90 as subroutine pack_hydromet_pdf_params. I took out the ifdef CLUBB_CAM preprocessor flags around some declarations and subroutines in pdf_parameter_module.F90 because they are also going to be called by WRF-CLUBB (and possibly SAM-CLUBB). The results in GrADS output files from this revision is an exact match to the results in GrADS output files from the previous revision for all cases. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8349 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: e7fe6b09e563382cdf65378edd286fa3d6b9c7c9 2017-01-25 23:01:15 +0000baeba5205aa0fdde1c16c1d735011a9d6eeb96fdI renamed the subroutine pack_pdf_params found in setup_clubb_pdf_params.F90editpdf_parameter_module.F90editsetup_clubb_pdf_params.F90variables_diagnostic_module.F90variables_prognostic_module.F9092d57479e3f56b93ba46a1773be93ab46078b8b81485386473000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am now using the new subroutine init_pdf_params to initialize the values of the PDF parameters of type pdf_parameter. The results in GrADS output files from this revision are an exact match to the results in GrADS output files from the previous revision for all cases. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8350 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 24899b7617ce4e89fd6ba4406625230c9f18dfbb 2017-01-25 23:21:13 +000092d57479e3f56b93ba46a1773be93ab46078b8b8I am now using the new subroutine init_pdf_params to initialize theeditvariables_diagnostic_module.F90editvariables_prognostic_module.F90clubb_api_module.F90149845b7ef749677b049d594d2e87e8fd4e0ce921485387548000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI removed the CAM_CLUBB preprocessor directives from pack_pdf_params_api, unpack_pdf_params_api, and num_pdf_params so that they can be accessed from WRF-CLUBB. The results in GrADS output files from this revision are an exact match to the results in GrADS output files from the previous revision for all cases. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8351 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 749c0e32563c60a53b924f1ff350fbc0e82e03e3 2017-01-25 23:39:08 +0000149845b7ef749677b049d594d2e87e8fd4e0ce92I removed the CAM_CLUBB preprocessor directives from pack_pdf_params_api,editclubb_api_module.F90mixing_length.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90pdf_closure_module.F90advance_windm_edsclrm_module.F90matrix_operations.F900e6ad4f7bd68117de009609e955a67219d3966551486693085000http://carson.math.uwm.edu/jenkins/user/savvasavvasavva@uwm.educlubb:ticket:800 -- Changed fatal errors statements to debug level 0. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8355 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 842caa8112d9655db44e72c6906c8b6efd4e60fe 2017-02-10 02:18:05 +00000e6ad4f7bd68117de009609e955a67219d396655clubb:ticket:800 -- Changed fatal errors statements to debug level 0.editadvance_xp2_xpyp_module.F90editpdf_closure_module.F90editmatrix_operations.F90editmixing_length.F90editadvance_wp2_wp3_module.F90editadvance_xm_wpxp_module.F90editadvance_windm_edsclrm_module.F90editadvance_clubb_core_module.F90advance_clubb_core_module.F90stats_clubb_utilities.F908907a3787230cb9be6c3fea6254676a199330a131487706416000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI updated CLUBB stats so that wpthvp, wp2thvp, rtpthvp, and thlpthvp are passed into subroutine stats_accumulate rather than be brought in by USE statements. This will allow these variables to be output correctly in the CLUBB stats grid column in WRF-CLUBB runs. The results in GrADS output files from this revision are an exact match to the results in GrADS output files from the previous revision for all cases. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8361 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: b7dbabdfea13cf54aa5d8f089ccbc780be0ddd1d 2017-02-21 19:46:56 +00008907a3787230cb9be6c3fea6254676a199330a13I updated CLUBB stats so that wpthvp, wp2thvp, rtpthvp, and thlpthvpeditadvance_clubb_core_module.F90editstats_clubb_utilities.F90stats_zm_module.F90stats_clubb_utilities.F90advance_clubb_core_module.F90stats_variables.F90cf19b99a6421ab461a8aba9db5cffe0045a2c8c21487877183000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI have added the coding infrastructure to output additional statistics w_1_zm, w_2_zm, varnce_w_1_zm, varnce_w_2_zm, and mixt_frac_zm. These are necessary for CLUBB restarts if the ipdf_call_placement flag is set to ipdf_post_advance_fields and the l_call_pdf_closure_twice flag is turned on. Additionally, I have added all the necessary CLUBB fields to input fields and to CLUBB restarts so that restarts should be successful if the ipdf_call_placement flag is set to ipdf_post_advance_fields. I have not added the new stats to the stats.in files yet. With that, the results in GrADS output files from this revision are an exact match to the results in GrADS output files from the previous revision for all cases. Larson Group Internal Trac System Reference: cam:ticket:87. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8362 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 4289d2475f8d595b9e6dc2bb91286da307b49241 2017-02-23 19:13:03 +0000cf19b99a6421ab461a8aba9db5cffe0045a2c8c2I have added the coding infrastructure to output additional statisticseditstats_zm_module.F90editstats_clubb_utilities.F90editadvance_clubb_core_module.F90editstats_variables.F90advance_clubb_core_module.F90797509049869e44636489bd02d8d7359dd85ed0d1488057545000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduThis is a bug fix for the Sun compiler. The variables pdf_params_zm and pdf_params_frz, which aren't used with CLUBB's current default settings, are intent(out) of subroutine generate_pdf_params. While they are initialized in CLUBB, they were not initialized in subroutine generate_pdf_params, and since they weren't being used by default, NaN values were being passed out of generate_pdf_params, overwriting the 0 values that they had been initialized to. This bug fix initializes pdf_params_zm and pdf_params_frz locally within subroutine generate_pdf_params. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8366 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: dff11a1927e522b0c5ff0acb47da029ee6750ed5 2017-02-25 21:19:05 +0000797509049869e44636489bd02d8d7359dd85ed0dThis is a bug fix for the Sun compiler. The variables pdf_params_zm andeditadvance_clubb_core_module.F90setup_clubb_pdf_params.F90da1e6e93f57c3b5937ce93743d13f2c8698fafe81488089851000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am updating the hydrometeor PDF code to set mu_hm_1 and mu_hm_2 based on mu_thl_1 and mu_thl_2. This will help improve the increase of thlp2 from evaporation of rain near ground in cases that use analytic microphysics or SILHS. The results of this change are BIT_CHANGING for all cases that use any type of microphysics. Larson Group Internal Trac System Reference: papers:ticket:14. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8368 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: ec62851ec33aa701989b4a4cac6dee344a642277 2017-02-26 06:17:31 +0000da1e6e93f57c3b5937ce93743d13f2c8698fafe8I am updating the hydrometeor PDF code to set mu_hm_1 andeditsetup_clubb_pdf_params.F90advance_clubb_core_module.F902849e9ec8d8be6daa3f5c9db5f17bf33290447f61488347866000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduRunning the Bitten tests. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8370 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 6aaf5c5e07d2bc8e122b2a68f5d92bed5ae7bc78 2017-03-01 05:57:46 +00002849e9ec8d8be6daa3f5c9db5f17bf33290447f6Running the Bitten tests.editadvance_clubb_core_module.F90advance_clubb_core_module.F90eb63cc3ecb36c7abf5b3dc60006f1285c707ffe11494005902000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduI added some comments so that CLUBB-SILHS would be consistent with the CLUBB-SILHS overview document that I am writing. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8375 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: f3f8fc84aa3c36b96796c683052f3f443980e0a7 2017-05-05 17:38:22 +0000eb63cc3ecb36c7abf5b3dc60006f1285c707ffe1I added some comments so that CLUBB-SILHS would be consistent witheditadvance_clubb_core_module.F90advance_clubb_core_module.F90numerical_check.F90stats_zt_module.F90pdf_closure_module.F90stats_variables.F90pdf_parameter_module.F90stats_clubb_utilities.F901bdf138739edb357345723bef5f76f60b0df026c1500069477000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduAs a first step, I changed all instances of rrtthl to corr_rt_thl_1. The results in GrADS output files from this revision are an exact match to the results in GrADS output files from the previous revision for all cases. CLUBB Trac ticket reference: clubb:ticket:806. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8405 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 79fdfb7e6a2ee9170090af10d080d8d936a149c1 2017-07-14 21:57:57 +00001bdf138739edb357345723bef5f76f60b0df026cAs a first step, I changed all instances of rrtthl to corr_rt_thl_1.editstats_variables.F90editpdf_parameter_module.F90editstats_clubb_utilities.F90editadvance_clubb_core_module.F90editpdf_closure_module.F90editnumerical_check.F90editstats_zt_module.F90advance_clubb_core_module.F90stats_zt_module.F90numerical_check.F90pdf_closure_module.F90stats_clubb_utilities.F90pdf_parameter_module.F90stats_variables.F902f64d7d1fad1935e490184a2f226e249b4dadeee1500071690000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI have added corr_rt_thl_2 to the code to go along with corr_rt_thl_2. Since an additional stat has been added to output, this particular change is BIT_CHANGING. However, this is only for GrADS _zt output files. Results in GrADS _zm and _sfc output files remain the same. CLUBB Trac ticket reference: clubb:ticket:806. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8406 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: b4b6c041f955df44b7e95fbcc72b4bfbfabf91a1 2017-07-14 22:34:50 +00002f64d7d1fad1935e490184a2f226e249b4dadeeeI have added corr_rt_thl_2 to the code to go along with corr_rt_thl_2.editpdf_closure_module.F90editstats_zt_module.F90editnumerical_check.F90editstats_clubb_utilities.F90editpdf_parameter_module.F90editadvance_clubb_core_module.F90editstats_variables.F90pdf_closure_module.F90advance_clubb_core_module.F90pdf_parameter_module.F90numerical_check.F909e72781b4211e81e73b40cafe2fc4f0f0ad3a30d1500529380000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI have added some code to add corr_w_rt_1, corr_w_rt_2, corr_w_thl_1, and corr_w_thl_2 to the pdf_parameter derived data type. The value of these variables is simply set to 0 for the ADG1 PDF. They have not yet been output to stats. The results in GrADS output files from this revision are an exact match to the results in GrADS output files from the previous revision for all cases. CLUBB Trac ticket reference: clubb:ticket:806. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8407 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 6a265cc291b093421e23178aaf0a2793a513fdbc 2017-07-20 05:43:00 +00009e72781b4211e81e73b40cafe2fc4f0f0ad3a30dI have added some code to add corr_w_rt_1, corr_w_rt_2, corr_w_thl_1, and corr_w_thl_2editpdf_closure_module.F90editadvance_clubb_core_module.F90editnumerical_check.F90editpdf_parameter_module.F90stats_variables.F90stats_clubb_utilities.F90stats_zt_module.F905c7d2be0e9f62502f81ce75fe3741456dae750ed1500601225000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added new statistics to the CLUBB _zt output files, specifically corr_w_rt_1, corr_w_rt_2, corr_w_thl_1, and corr_w_thl_2. The results in GrADS _zt output files change, owing to additional statistics. This commit is BIT_CHANGING. Otherwise, all the other GrADS output files stay exactly the same. CLUBB Trac ticket reference: clubb:ticket:806. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8408 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 71c2743e87f125b0e60ccae83fc1fff07e69cb6f 2017-07-21 01:40:25 +00005c7d2be0e9f62502f81ce75fe3741456dae750edI added new statistics to the CLUBB _zt output files, specifically corr_w_rt_1, corr_w_rt_2,editstats_variables.F90editstats_clubb_utilities.F90editstats_zt_module.F90pdf_closure_module.F90d854c55ef50cfb617782f166fb066c43ceb8ada71501016894000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am updating the equations for wp2rtp, wp2thlp, wprtp2, and wpthlp2 to include within-component correlations of w and rt or w and theta-l. I am also replacing the hardwired settng of corr_w_rt_1, corr_w_rt_2, corr_w_thl_1, and corr_w_thl_2 to 0 (for ADG1) with the equations that solve for these correlations. For the ADG1, the result of the equation is within-component correlations that have a value of 0 --- well, within numerical roundoff error of 0 (such as 1.0e-14). Since this code change technically changes results, this commit is BIT_CHANGING. However, plotgen shows profiles exactly overlap for almost all cases. The ultra-sensitive ARM 97 case is the most notable exception. CLUBB Trac ticket reference: clubb:ticket:806. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8409 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: e5487001c112145b1f562684e41498d04ef27f89 2017-07-25 21:08:14 +0000d854c55ef50cfb617782f166fb066c43ceb8ada7I am updating the equations for wp2rtp, wp2thlp, wprtp2, and wpthlp2 to includeeditpdf_closure_module.F90pdf_utilities.F9065c599a0a6b342524a4e151d6a5fe6b29f792af21501124070000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am adding a special function to calculate the within-component correlation of eta and variable x (such as w), which depends, in part, on the within-component correlaton of rt and x and the within-component correlation of theta-l and x. CLUBB Trac ticket reference: clubb:ticket:806. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8410 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 7fb019f47f4446c226d298f7219d77628c879392 2017-07-27 02:54:30 +000065c599a0a6b342524a4e151d6a5fe6b29f792af2I am adding a special function to calculate the within-component correlation ofeditpdf_utilities.F90pdf_closure_module.F90ec0c789074314e3ce17bafe76ff0f03d46431f7c1501134625000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added variables corr_w_chi_1, corr_w_chi_2, corr_w_eta_1, and corr_w_eta_2 to subroutine pdf_closure. They calculate the within-component correlations by calling utility functions in PDF utilities. CLUBB Trac ticket reference: clubb:ticket:806. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8411 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: e9ca795e3b8d60784a00b76016f8b209c9a93203 2017-07-27 05:50:25 +0000ec0c789074314e3ce17bafe76ff0f03d46431f7cI added variables corr_w_chi_1, corr_w_chi_2, corr_w_eta_1, and corr_w_eta_2editpdf_closure_module.F90pdf_parameter_module.F90pdf_closure_module.F90numerical_check.F90c5840a13dc0ebcb6ee34e88c8c56ba714373b3121501709183000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am adding corr_w_chi_1, corr_w_chi_2, corr_w_eta_1, and corr_w_eta_2 to type pdf_parameter. The results in GrADS output files from this revision are an exact match to the results in GrADS output files from the previous revision for all cases. CLUBB Trac ticket reference: clubb:ticket:806. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8412 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: a43fc0230324a470f3d7ab7c3f1345b54994ad84 2017-08-02 21:26:23 +0000c5840a13dc0ebcb6ee34e88c8c56ba714373b312I am adding corr_w_chi_1, corr_w_chi_2, corr_w_eta_1, and corr_w_eta_2 to typeeditnumerical_check.F90editpdf_parameter_module.F90editpdf_closure_module.F90stats_variables.F90setup_clubb_pdf_params.F90stats_zt_module.F90a1089add9c25d5324dde3dbd23e95e3b33821b081501714052000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduNow that the PDF component correlations of w and chi, as well as w and eta, will be allowed to be something other than 0 when a new PDF is used, stats needs to account for that. Already in the code, corr_chi_eta_1 is the value calculated in PDF closure, while corr_chi_eta_1_ca is the actual value used in the correlation array. This depends on whether the calculated value or a prescribed value is used in the array. This code is now being mimicked for corr_w_chi_1, corr_w_chi_2, corr_w_eta_1, and corr_w_eta_2. The first step is change the current stats output corr_w_chi_1 to corr_w_chi_1_ca, etc. The results in GrADS *.dat output files from this revision are an exact match to the results in GrADS *.dat output files from the previous revision for all cases. The GrADS *.ctl files differ because the stat names have changed. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8413 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 8a0b4efb9a160adb315c099462bcc07dc5b9359e 2017-08-02 22:47:32 +0000a1089add9c25d5324dde3dbd23e95e3b33821b08Now that the PDF component correlations of w and chi, as well as w and eta,editsetup_clubb_pdf_params.F90editstats_variables.F90editstats_zt_module.F90stats_variables.F90stats_clubb_utilities.F90stats_zt_module.F90ab1a600e7f1f56ee0e69d72ca22eaba8e0e811f61501716478000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am adding statistical output for corr_w_chi_1, corr_w_chi_2, corr_w_eta_1, and corr_w_eta_2. The results in GrADS output files differ because of the additional statistics, so this revision is BIT_CHANGING. However, this is only for the *_zt output files. The results in GrADS *_zm and *_sfc output files from this revision are and exact match to the results in GrADS *_zm and *_sfc files from the previous revision for all cases. CLUBB Trac ticket reference: clubb:ticket:806. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8414 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 309a5fed35104c5422cc4ad24efc8c0c241ad858 2017-08-02 23:27:58 +0000ab1a600e7f1f56ee0e69d72ca22eaba8e0e811f6I am adding statistical output for corr_w_chi_1, corr_w_chi_2, corr_w_eta_1,editstats_variables.F90editstats_clubb_utilities.F90editstats_zt_module.F90setup_clubb_pdf_params.F90model_flags.F90clubb_api_module.F90corr_varnce_module.F908ca31ccec167f25a7f32ddbf3ca7b54d3a8230321501719775000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am changing the name of the flag l_fix_chi_eta_correlations to l_fix_w_chi_eta_correlations. This is because code will need to be introduced to fix the PDF component correlations of w and chi and w and eta for SILHS. The results in GrADS output files from this revision are an exact match to the results in GrADS output files from the previous revision for all cases. CLUBB Trac ticket reference: clubb:ticket:806. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8415 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 32b0f55832325418462852f9fc611c2ed25a7b2c 2017-08-03 00:22:55 +00008ca31ccec167f25a7f32ddbf3ca7b54d3a823032I am changing the name of the flag l_fix_chi_eta_correlations toeditcorr_varnce_module.F90editsetup_clubb_pdf_params.F90editmodel_flags.F90editclubb_api_module.F90pdf_closure_module.F90advance_clubb_core_module.F90model_flags.F90clubb_api_module.F905779b395cf8ca60cdd2b751d238da3b2c45421291501828308000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduThe two component normal (double Gaussian) PDF used by CLUBB will now be selected by an integer index, rather than multiple logical flags. The PDF type used by CLUBB is called iiPDF_type. The value of iiPDF_type can be set to one of the following: iiPDF_ADG1 = 1: ADG1 PDF (default) iiPDF_ADG2 = 2: ADG2 PDF (can only be used with input fields) iiPDF_3D_Luhar = 3: 3D Luhar PDF (can only be used with input fields). Additional PDF types will be added in the near future. The results in GrADS output files from this revision are an exact match to the results in GrADS output files from the previous revision for all cases. CLUBB Trac ticket reference: clubb:ticket:770. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8416 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 9b7157d59487b308c22704bc6f37dc39fb1acb0b 2017-08-04 06:31:48 +00005779b395cf8ca60cdd2b751d238da3b2c4542129The two component normal (double Gaussian) PDF used by CLUBB will now beeditclubb_api_module.F90editpdf_closure_module.F90editadvance_clubb_core_module.F90editmodel_flags.F90advance_clubb_core_module.F908edb8709cbdb95f0e8ae17bf23a57d9863c9d77d1501887618000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI moved the checking of the options for the PDF call placement to subroutine setup_clubb_core, which is the same place where the options for the PDF type are checked. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8418 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 7d2573b3d770b6f6f0b3a899a49f2ea17978e381 2017-08-04 23:00:18 +00008edb8709cbdb95f0e8ae17bf23a57d9863c9d77dI moved the checking of the options for the PDF call placement to subroutineeditadvance_clubb_core_module.F90setup_clubb_pdf_params.F9026a1ae6570d7ca0c695eab9bd90bd6e66bb6f3131502394562000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am altering setup PDF parameters to be able to read in the values of corr_w_chi_1, corr_w_chi_2, corr_w_eta_1, and corr_w_eta_2 calculated by CLUBB's PDF closure when l_fix_w_chi_eta_correlations is turned off. Since RICO and RICO SILHS have l_fix_w_chi_eta_correlations turned off by default, and since the values of corr_w_chi_1 are within numerical roundoff of 0, but are not exactly 0 (since they aren't hardwired to 0 anymore in this situation), the GrADS output results for the RICO cases are technically BIT_CHANGING. However, for all other cases, the results in GrADS output files from this revison are an exact match to the results in GrADS output files from the previous revison. CLUBB Trac ticket reference: clubb:ticket:806. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8420 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: f78b2d5236cd3ee28677ab616d9a3189fb3e1cde 2017-08-10 19:49:22 +000026a1ae6570d7ca0c695eab9bd90bd6e66bb6f313I am altering setup PDF parameters to be able to read in the values ofeditsetup_clubb_pdf_params.F90new_pdf.F90c07ab5ccd5a6e475db0719d161e28b3928b9331c1502937779000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am adding the new file new_pdf.F90 to the CLUBB core directory. So far, it basically contains a few comments. CLUBB Trac ticket reference: clubb:ticket:777. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8424 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 907fafe42349a2f36c433b92f7e96fd9206a182f 2017-08-17 02:42:59 +0000c07ab5ccd5a6e475db0719d161e28b3928b9331cI am adding the new file new_pdf.F90 to the CLUBB core directory. So far, itaddnew_pdf.F90new_pdf.F90ce75f5ce98726c064acad7ff3b291699db00bf2e1503201511000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am adding a large amount of code to the new PDF. I have filled in the driver subroutine, and I have added functions and subroutines for mixture fraction, the PDF component means and standard deviations for the "setter" variable, and the PDF component means and standard deviations for the "responder" variables. CLUBB Trac ticket reference: clubb:ticket:777. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8427 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 014bdf1009c7ade517a2a13b457a8d0dfcbc915e 2017-08-20 03:58:31 +0000ce75f5ce98726c064acad7ff3b291699db00bf2eI am adding a large amount of code to the new PDF. I have filled in the drivereditnew_pdf.F90new_pdf.F9085308f4beb5f735c34d9d8e875a722134919d6a71504037851000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am adding code to the new PDF that calculates the minimum and maximum allowable values of F_x for a responding variable. CLUBB Trac ticket reference: clubb:ticket:777. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8431 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 5e00f9da2367b8a8c40031b8d2f9817458ef1533 2017-08-29 20:17:31 +000085308f4beb5f735c34d9d8e875a722134919d6a7I am adding code to the new PDF that calculates the minimum and maximumeditnew_pdf.F90pdf_closure_module.F9011d7a9d84753ae52c284a70bf29849bc744ed9c41504043430000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added a new iiPDF entry for the new PDF, and I neatened some of the current code. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8432 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 8f478d6814c6a69b3677af8309f4a145fe85090e 2017-08-29 21:50:30 +000011d7a9d84753ae52c284a70bf29849bc744ed9c4I added a new iiPDF entry for the new PDF, and I neatened some of the currenteditpdf_closure_module.F90pdf_closure_module.F907ae91ab288665049bbef456846c14561ab3ac1081504044268000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added an option to call the new PDF from subroutine pdf_closure. CLUBB Trac ticket reference: clubb:ticket:777. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8433 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 208d82318173789a7c7d6e09277832b2d5fb39f4 2017-08-29 22:04:28 +00007ae91ab288665049bbef456846c14561ab3ac108I added an option to call the new PDF from subroutine pdf_closure.editpdf_closure_module.F90advance_clubb_core_module.F90df45d687af4c60ee9f4d8dc3ed58df880c4e90f11504045491000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI had to add checking for the new PDF so someone does not try to run it interactively until it is ready for that. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8435 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: ee48cae5f28e2184bf87cd80351fc1987fddb28d 2017-08-29 22:24:51 +0000df45d687af4c60ee9f4d8dc3ed58df880c4e90f1I had to add checking for the new PDF so someone does not try to run iteditadvance_clubb_core_module.F90advance_clubb_core_module.F90pdf_closure_module.F90250072e68b4e2047771089a721f91f5648f686ee1504104485000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI made a couple changes to (1) initialize two variables that aren't used by the new PDF (alpha_rt and alpha_thl) to default values in order to avoid them being set to NaN and causing a runtime error, and (2) calculate skewness from thlp3 and thlp2 (or rtp3 and rtp2) for the new PDF. CLUBB Trac ticket reference: clubb:ticket:777. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8437 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 7fb0580861183c3d696238bd7168d1cfbc97bcd3 2017-08-30 14:48:05 +0000250072e68b4e2047771089a721f91f5648f686eeI made a couple changes to (1) initialize two variables that aren't used by theeditpdf_closure_module.F90editadvance_clubb_core_module.F90new_pdf.F90122a9c185ebc5211667fef6f3500c821a50366141504114265000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added a conditional to the subroutine that sets the responder parameters. When both Skx and F_x are exactly 0 (and the only Skx that can be represented when F_x is 0 is a Skx of 0), a couple of equations end up with an undefined 0/0. In this scenario, the PDF is converging to a single Gaussian. When both Skx and F_x have a value of 0, the PDF of responder variable x is now defined to be a single Gaussian (which is the shape it was converging to). CLUBB Trac ticket reference: clubb:ticket:777. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8439 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 816a6b607a2d470e1e21faaba2cae46905211943 2017-08-30 17:31:05 +0000122a9c185ebc5211667fef6f3500c821a5036614I added a conditional to the subroutine that sets the responder parameters.editnew_pdf.F90new_pdf.F907760911823e32928409cbe64bf70121141891a341504332693000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI have added the beginnings of a new unit test for the PDF parameters. Currently, it tests the new PDF, but only the "setter" variable. It checks based on a variety of input values and loops over many different tunable parameter values. Once mu_w_1, mu_w_2, sigma_w_1, sigma_w_2, and mixt_frac have been calculated, the values of wm, wp2, wp3, and Skw are recalculated using PDF parameters and compared to their original values. Additionally, the test also checks that sigma_w_1 >= 0, sigma_w_2 >= 0, and 0 < mixt_frac < 1. CLUBB Trac ticket reference: clubb:ticket:777. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8441 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 116cd507bfb549e1fd9678dc1207a98de3d8bb52 2017-09-02 06:11:33 +00007760911823e32928409cbe64bf70121141891a34I have added the beginnings of a new unit test for the PDF parameters.editnew_pdf.F90new_pdf.F9082a034dfa874b3e850244853312a754392e823bd1504736013000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI have updated the PDF parameter unit test to make a call to the full PDF (for the new PDF). CLUBB Trac ticket reference: clubb:ticket:777. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8442 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: b3c8936e8d546569a1877900dc53dcc7cffdb9a4 2017-09-06 22:13:33 +000082a034dfa874b3e850244853312a754392e823bdI have updated the PDF parameter unit test to make a call to the full PDF (foreditnew_pdf.F90pdf_closure_module.F908e609886fe423733d4568c845d91d3847cc808741504766042000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI have added a feature to the PDF parameter unit tests which allows the user to declare which PDF is being tested. With this, I have added some code to test the "setter" variable for ADG1 (which is always w). The test loops over incremental values of sigma_sqd_w for each of the PDF input parameter sets, calculates the PDF component means, component variances, and mixture fraction, and then recalculates wm, wp2, wp3, and Skw. I still have to add code to test the full PDF for ADG1. CLUBB Trac ticket reference: clubb:ticket:777. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8443 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 645ed2b73204952f8d3cc9193f516576d13ef6ae 2017-09-07 06:34:02 +00008e609886fe423733d4568c845d91d3847cc80874I have added a feature to the PDF parameter unit tests which allows the usereditpdf_closure_module.F90new_pdf.F90df8d5977e025ede94c6b058b97856c0bed8cb3261504842829000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduIn the setter variable description and subprograms, I made a name change from mu_w_1, etc., to mu_x_1, etc. This was done because other variables besides w might be used as the setter variable. CLUBB Trac ticket reference: clubb:ticket:777. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8444 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 04ecfc94c1d512f4815f332ea0d6271b413b7394 2017-09-08 03:53:49 +0000df8d5977e025ede94c6b058b97856c0bed8cb326In the setter variable description and subprograms, I made a name change fromeditnew_pdf.F90new_pdf.F90f191465a17f26341952b058689a1d428c0a4bfdd1504846771000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI have updated the method of calculating the setter variable so that mu_x_1 and mu_x_2 are set based on the sign of <w'x'>. This is described in the back pages of the derivation of the method for the setting variable. In a nutshell, sqrt(F_x) is replaced by sqrt(F_x) * sgn( <w'x'> ) in the entire equation set. Most equations use F_x (or an integer power of F_x). Even after the replacement, F_x remains F_x (because the square, etc., of sgn( <w'x'> ) is always 1). The only equations that are altered are the equations for mu_x_1 and mu_x_2. When the sign of <w'x'> is positive, mu_x_1 >= mu_x_2. Otherwise, when the sign of <w'x'> is negative, mu_x_1 <= mu_x_2. When variable x is w, the sign of wp2 is always postive, and mu_w_1 >= mu_w_2, following previous conventions. This change allows for things such as mu_thl_1 <= mu_thl_2 when <w'thl'> < 0 in the event that theta-l is the setting variable. CLUBB Trac ticket reference: clubb:ticket:777. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8445 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 733f5f36dad88f0ecaef746b8e01c4ffbff39ef5 2017-09-08 04:59:31 +0000f191465a17f26341952b058689a1d428c0a4bfddI have updated the method of calculating the setter variable so that mu_x_1editnew_pdf.F90new_pdf.F902dcf994553dc649bcd496308117a8b6a97113d4b1504933930000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added primarily some more documentation and notes. CLUBB Trac ticket reference: clubb:ticket:777. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8446 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: e7b3f11bef3737730d2d558cff2e12e27c75b139 2017-09-09 05:12:10 +00002dcf994553dc649bcd496308117a8b6a97113d4bI added primarily some more documentation and notes.editnew_pdf.F90new_pdf.F90e81daa5f055f4c99b63bd444bce743bd8f92c8971505141754000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added some more comments documenting the code. CLUBB Trac ticket reference: clubb:ticket:777. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8447 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 08c4a3ab5eebcd45cefffb401c35386c88a872b6 2017-09-11 14:55:54 +0000e81daa5f055f4c99b63bd444bce743bd8f92c897I added some more comments documenting the code.editnew_pdf.F90new_pdf.F90pdf_closure_module.F90constants_clubb.F9046632b4b96b05fb8079924794420043194c5ee011505152039000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI got rid of some of the expressions that a script might try to flag as "magic numbers" by doing something that I started a while ago --- declaring those numbers as constant parameters in the code. CLUBB Trac ticket reference: clubb:ticket:777. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8448 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: e99a65715204e9382dfb6357ac1a76ebf4517581 2017-09-11 17:47:19 +000046632b4b96b05fb8079924794420043194c5ee01I got rid of some of the expressions that a script might try to flag aseditnew_pdf.F90editconstants_clubb.F90editpdf_closure_module.F90new_pdf.F90b7a9edf6cdf37b4d301a5426e8f7f787fac26ccc1505255733000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added much more documentation about the responder variable. Specifically, much of the new documentation is about how the limits of F_x are calculated. CLUBB Trac ticket reference: clubb:ticket:777. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8449 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: a8d6f95d883a38bf345324b717d3f1955d5688d5 2017-09-12 22:35:33 +0000b7a9edf6cdf37b4d301a5426e8f7f787fac26cccI added much more documentation about the responder variable. Specifically,editnew_pdf.F90original_pdf.F9096dd4a8d1759e5ed899571e92df95527e3995d871505371440000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am adding the new file, original_pdf.F90, as the new home for the ADG1, ADG2, and 3D Luhar PDF closures. As of right now, the original code still remains in PDF closure, and this code is not currently interface with any part of CLUBB. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8450 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 4d83bf47bf1260f79b1584952743991e1d4af68a 2017-09-14 06:44:00 +000096dd4a8d1759e5ed899571e92df95527e3995d87I am adding the new file, original_pdf.F90, as the new home for the ADG1, ADG2,addoriginal_pdf.F90original_pdf.F90pdf_closure_module.F90e45432703a561cdc6e81c106568c3cab71b56bba1505406315000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI have now switched the PDF closure code over to calling the code that had been moved to original_pdf.F90 in r8450. The code that remained in PDF closure has now been deleted. I have also moved the code to calculate the PDF parameters for passive scalars to inside the driver subroutines for ADG1 and ADG2. The results in GrADS output files from this revision are an exact match to the results in GrADS output files from the previous revision for all cases. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8451 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 5b68933fc999bc8258625b0d9a3fd8c1b3128d46 2017-09-14 16:25:15 +0000e45432703a561cdc6e81c106568c3cab71b56bbaI have now switched the PDF closure code over to calling the code that had beeneditoriginal_pdf.F90editpdf_closure_module.F90new_pdf.F901a2c52b7d840dea49e23776c4d9591929663b5bc1505617261000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI updated the documentation in the code comments for the setter method and generalized the mixture fraction code so that any variable, x, can be used as the setter variable, not just w. CLUBB Trac ticket reference: clubb:ticket:777. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8453 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 319e3ff46c48a3a9efea5d7e7b977ddeb203ee4b 2017-09-17 03:01:01 +00001a2c52b7d840dea49e23776c4d9591929663b5bcI updated the documentation in the code comments for the setter method andeditnew_pdf.F90new_pdf.F901b93dd6436c3a08431325786bfc77e3a0ed10c5f1505617722000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added a comment. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8454 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 476d92833ba72680bb61cee9e1a5846e2df19a53 2017-09-17 03:08:42 +00001b93dd6436c3a08431325786bfc77e3a0ed10c5fI added a comment.editnew_pdf.F90pdf_utilities.F90new_pdf.F90pdf_closure_module.F909638daee00cbed38db5adb3d64ec7cdba43206c51505856406000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added a new function, calc_comp_corrs_binormal, to pdf_utilities.F90. This function calculates the PDF component correlations of two variables that are both distributed as part of a two component normal distribution. The code is a copy of code that was previously found in subroutine pdf_closure. Now, pdf_closure calls this function multiple times over, rather than repeating the same code multiple times in a row. The results in GrADS output files from this revision are an exact match to the results in GrADS output files from the previous revision for all cases. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8455 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: ee93f6bfb3c984fdec7a851189dfc4c502aae5c0 2017-09-19 21:26:46 +00009638daee00cbed38db5adb3d64ec7cdba43206c5I added a new function, calc_comp_corrs_binormal, to pdf_utilities.F90. Thiseditpdf_closure_module.F90editnew_pdf.F90editpdf_utilities.F90new_pdf.F90512906b3f915322181776bee28aa6abd4bb7703a1505887818000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added some more descriptive comments and a new function that calculates the coefficient of the wp4 equation (for implicit time stepping), where: wp4 = coef_wp4_implicit * wp2^2^ CLUBB Trac ticket reference: clubb:ticket:777. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8456 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 4336f01d26892857c38991297e10d652737d4754 2017-09-20 06:10:18 +0000512906b3f915322181776bee28aa6abd4bb7703aI added some more descriptive comments and a new function that calculates theeditnew_pdf.F90new_pdf.F90376bd21e269d7d0c874d2dc5fb12d05f99d8794f1505965326000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI updated the code so that coef_sigma_x_1_sqd and coef_sigma_x_2_sqd are passed out of the subroutine that calculates the PDF parameters for the setter variable. CLUBB Trac ticket reference: clubb:ticket:777. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8457 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: dd22397b49b2096afb51cdefa80f672f93bc5c50 2017-09-21 03:42:06 +0000376bd21e269d7d0c874d2dc5fb12d05f99d8794fI updated the code so that coef_sigma_x_1_sqd and coef_sigma_x_2_sqd are passededitnew_pdf.F90new_pdf.F90ec87600ee30f3e74fb2037e0166318973b4b54161505965630000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI fixed a mistake. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8458 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 56c95f8615f28064b8a74c51c26d791616eb2cb4 2017-09-21 03:47:10 +0000ec87600ee30f3e74fb2037e0166318973b4b5416I fixed a mistake.editnew_pdf.F90new_pdf.F90060c2e9f5a165d0db494d1fa22ead556ef6a717d1506056092000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI have added code to call the new function that calculates wp4 implicitly from the unit testing code. I also added some more comments. CLUBB Trac ticket reference: clubb:ticket:777. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8459 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 98fe8bf67b016720bdc77236c765ea80c681ea57 2017-09-22 04:54:52 +0000060c2e9f5a165d0db494d1fa22ead556ef6a717dI have added code to call the new function that calculates wp4 implicitly fromeditnew_pdf.F90pdf_closure_module.F90a5753ccef073f127ffd2a0c7ea4fbd9026d8ebd51506058934000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI moved the calculations of wp2xp (wp2rtp and wp2thlp), wp4, and wpxp2 (wprtp2 and wpthlp2) into their own functions. At most timesteps, results are exactly the same. On occassion, very, very small discrepancies between the previous version and the new revision show up. The calculations occur with everything in the exact same order as they were performed in previously. They only thing different is passing code out of functions and back to the main program. This odd behavior makes this code technically BIT_CHANGING. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8460 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 79030bc1913e95ecb36bd613713658d726944188 2017-09-22 05:42:14 +0000a5753ccef073f127ffd2a0c7ea4fbd9026d8ebd5I moved the calculations of wp2xp (wp2rtp and wp2thlp), wp4, and wpxp2 (wprtp2editpdf_closure_module.F90new_pdf.F905384d9d0de5cbfa54786e0022ac45d03923528bb1506234447000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added another function to the new PDF. This function helps to calculate wpxp2 implicitly as part of the xp2 predictive equation. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8462 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 33547d862fbf9fecded1db6f1b8f0d4c27db176d 2017-09-24 06:27:27 +00005384d9d0de5cbfa54786e0022ac45d03923528bbI added another function to the new PDF. This function helps to calculateeditnew_pdf.F90new_pdf.F90a104dde34400e73f7996e9b0528415d6529defc61506460821000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added a special case for the wpxp2 implicit code. CLUBB Trac ticket reference: clubb:ticket:777. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8463 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 5d60384202b85e0e30d3b33c1ec996550e5e485f 2017-09-26 21:20:21 +0000a104dde34400e73f7996e9b0528415d6529defc6I added a special case for the wpxp2 implicit code.editnew_pdf.F90pdf_closure_module.F90b20f067da35fa0881ebe6ca019282953548d637d1506464947000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduBack in clubb:r8409, the PDF component correlations of w and rt and w and theta-l were calculated rather than assumed to be 0. For ADG1 and ADG2, the resulting values of the correlations were within numerical roundoff error of 0 (for example, 1.0e-14). However, in the interest of trying to keep results in-line as much as possible with historical results, this commitment introduces code to simply set these PDF component correlations to 0 (and avoid the calculation) when the chosen PDF is ADG1 or ADG2. Otherwise, when other PDFs are used, the correlations will be calculated. This commitment is BIT_CHANGING. CLUBB Trac ticket reference: clubb:ticket:806. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8464 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 03e97996f9e5aace3643cf8da3a7019b8f864ed1 2017-09-26 22:29:07 +0000b20f067da35fa0881ebe6ca019282953548d637dBack in clubb:r8409, the PDF component correlations of w and rt and w andeditpdf_closure_module.F90new_pdf.F90315aa47cfb4f0803b723148723f70a5771b634441506568243000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added a subroutine that calculates the implicit and explicit portions of the wp2xp equation, where: wp2xp = coef_wp2xp_implicit * wpxp + coef_wp2xp_explicit. CLUBB Trac ticket reference: clubb:ticket:777. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8465 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: e6e7a3c61a7ea3f44564e4ab82f73facba6c7115 2017-09-28 03:10:43 +0000315aa47cfb4f0803b723148723f70a5771b63444I added a subroutine that calculates the implicit and explicit portions of theeditnew_pdf.F90pdf_closure_module.F90original_pdf.F90adg1_adg2_3d_luhar_pdf.F90682b8167989760c5e3bdb5fe3112632a480988011506568869000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI renamed original_pdf.F90 as adg1_adg2_3d_luhar_pdf.F90. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8466 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: ea939d307f723c18aba6dff8ef2a0c739263e2a0 2017-09-28 03:21:09 +0000682b8167989760c5e3bdb5fe3112632a48098801I renamed original_pdf.F90 as adg1_adg2_3d_luhar_pdf.F90.addadg1_adg2_3d_luhar_pdf.F90editpdf_closure_module.F90deleteoriginal_pdf.F90pdf_closure_module.F90advance_clubb_core_module.F90stats_variables.F90new_pdf.F90stats_zt_module.F9016b439a231f958d7434c9945fda5b0a33f5659561506643797000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added statistical output for F_w, F_rt, F_thl, min_F_w, max_F_w, min_F_rt, max_F_rt, min_F_thl, and max_F_thl. The results in GrADS output files from this revision are an exact match to the results in GrADS output files from the previous revision for all cases for all output files besides the *_zt.dat output files. Owing to the new stats, the *_zt.dat output files make this revision BIT_CHANGING. CLUBB Trac ticket reference: clubb:ticket:777. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8467 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 2243298ace53299c9e0222adf2cd233026fe6268 2017-09-29 00:09:57 +000016b439a231f958d7434c9945fda5b0a33f565956I added statistical output for F_w, F_rt, F_thl, min_F_w, max_F_w, min_F_rt,editadvance_clubb_core_module.F90editnew_pdf.F90editpdf_closure_module.F90editstats_zt_module.F90editstats_variables.F90new_pdf.F90pdf_closure_module.F90new_pdf_main.F9014cd9184faf1cd20250b7dafa64a794f0097225b1506664323000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI split the new PDF into two files. I added a new file that currently houses the driver. The core functions and subroutines of the new PDF remain in the original file. The Happy Birthday to me CLUBB Trac ticket reference: clubb:ticket:777. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8469 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 68224186fc824f10965e7f887d79f6a3b6d414d4 2017-09-29 05:52:03 +000014cd9184faf1cd20250b7dafa64a794f0097225bI split the new PDF into two files. I added a new file that currently houseseditnew_pdf.F90editpdf_closure_module.F90addnew_pdf_main.F90saturation.F907fa72c493db849383093c4b14b73e1e5567b47c61507128630000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduI clipped temperature within the Goff-Gratch functions for saturation over liquid and ice. The goal was to avoid the creation of NaNs that caused CAM to crash over the Himalayas. The result of applying a minimal threshold on temperature is to set saturation to the same small value in all cold areas. To test the code change, I ran the priority cases and determined that the new code produces bin-diff identical results for these cases. That just means that these cases are not cold. However, the code change might increase saturation in cold areas in CAM, thereby diminishing condensation in the upper atmosphere. It would be prudent to check a WACCM simulation for degradation. If there is degradation, the minimum temperatures could be set to smaller values. For cam:ticket:98. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8470 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 6c2c6fc13a7673bcdf5da93bde0a350086383b4e 2017-10-04 14:50:30 +00007fa72c493db849383093c4b14b73e1e5567b47c6I clipped temperature within the Goff-Gratch functions for saturation over liquid and ice.editsaturation.F90pdf_closure_module.F902056a9a395e6d8d41d25f58d5e65da97dc4f46bf1507164340000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI initialized some output variables in order to prevent a runtime error. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8472 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 3047483573f92b8e310d3f1529a9870a3bdf8446 2017-10-05 00:45:40 +00002056a9a395e6d8d41d25f58d5e65da97dc4f46bfI initialized some output variables in order to prevent a runtime error.editpdf_closure_module.F90new_pdf_main.F90d6bbb281bffd128da2be6a16fa6275df12f972f31507177058000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI made a sub-driver level subroutine for the calculations necessary for a responder variable. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8473 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 9b930c433b4f7c0162637737a57bd4b5dd51c663 2017-10-05 04:17:38 +0000d6bbb281bffd128da2be6a16fa6275df12f972f3I made a sub-driver level subroutine for the calculations necessary for aeditnew_pdf_main.F90new_pdf.F90new_pdf_main.F9009094b52ced98602026e3ba4b157d17c07c46b6e1507338548000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added code to allow the variable (of w, rt, or theta-l) with the greatest magnitude of skewness be the setter variable (the variable that sets the mixture fraction). git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8476 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 5c0be9f8b54edea4f614fe27d7bdcbabf21071d9 2017-10-07 01:09:08 +000009094b52ced98602026e3ba4b157d17c07c46b6eI added code to allow the variable (of w, rt, or theta-l) with the greatesteditnew_pdf.F90editnew_pdf_main.F90new_pdf_main.F90b8df0b0f7f07bbafe999455169a9e03c928f7b741507356781000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added calls to the functions and subroutines that calculate the implicit and explicit components of equations for wp4, wpxp2, and wp2xp. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8477 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: bd5eb61264aed108784e8a104833036e2737d08d 2017-10-07 06:13:01 +0000b8df0b0f7f07bbafe999455169a9e03c928f7b74I added calls to the functions and subroutines that calculate the implicit andeditnew_pdf_main.F90new_pdf.F90new_pdf_main.F90796393862523d0e2dc6dcd049937db3fc8702b861508011950000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI changed coef_wp2xp_explicit (coef_wp2rtp_explicit and coef_wp2thlp_explicit) to term_wp2xp_explicit (term_wp2rtp_explicit and term_wp2thlp_explicit) because "term" is a more accurate description here than "coef". git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8480 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 3518be4233b5b02e269e2f3d65518d5006cc64ee 2017-10-14 20:12:30 +0000796393862523d0e2dc6dcd049937db3fc8702b86I changed coef_wp2xp_explicit (coef_wp2rtp_explicit and coef_wp2thlp_explicit)editnew_pdf.F90editnew_pdf_main.F90new_tsdadg_pdf.F90pdf_closure_module.F9058cd28c513082639da7ed8a8c98ea851cfd53ce91508023017000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am adding a new file for the new trivariate skewness-dependent analaytic double Gaussian (TSDADG) PDF. I have added an interface in the unit tests, although the standard tests aren't conducted yet. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8481 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: f6b6b4d8826565e3a7efe3f7b0ad3004d67fd74b 2017-10-14 23:16:57 +000058cd28c513082639da7ed8a8c98ea851cfd53ce9I am adding a new file for the new trivariate skewness-dependent analayticaddnew_tsdadg_pdf.F90editpdf_closure_module.F90new_tsdadg_pdf.F90628c9ccf8a8ec694e55e2a305f72feadc5fc31341508296514000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI fixed a bug in the new Trivariate skewness-dependent analytic double Gaussian PDF. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8482 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 2bbab551f1c16a8aacee8191faf4e6fe9f078a03 2017-10-18 03:15:14 +0000628c9ccf8a8ec694e55e2a305f72feadc5fc3134I fixed a bug in the new Trivariate skewness-dependent analytic double Gaussianeditnew_tsdadg_pdf.F90new_tsdadg_pdf.F90514ef09cc3bbf7f44f4073b9ac4cdbcbdcf760f11508302674000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduIn order for the TSDADG PDF to work correctly, when Skx * sgn( <w'x'> ) >= 0, l_x_1 > 2/3 and 0 < l_x_2 < 1. However, when Skx * sgn( <w'x'> ) < 0, the limits need to be reversed. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8483 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 430ba9fb82f4868373f7d7b04e9f578d7d2a7aaa 2017-10-18 04:57:54 +0000514ef09cc3bbf7f44f4073b9ac4cdbcbdcf760f1In order for the TSDADG PDF to work correctly, when Skx * sgn( <w'x'> ) >= 0,editnew_tsdadg_pdf.F90pdf_closure_module.F90adg1_adg2_3d_luhar_pdf.F901be60070880272802ecd85639370eaaa7130eead1508884727000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduIn order to clarify coding in CLUBB, I am moving a block of code that is specific to ADG1 and ADG2 to inside their driver subroutines, rather than keep it outside the driver subroutines, in subroutine pdf_closure, where it is more confusing to someone trying to understand the flow of the code. I also added the full PDF unit test for ADG1. The results in GrADS output files from this revision are an exact match to the results in GrADS output files from the previous revision for all cases. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8484 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: dcefdbe88476adfa5843797ca9b175f0532ba91d 2017-10-24 22:38:47 +00001be60070880272802ecd85639370eaaa7130eeadIn order to clarify coding in CLUBB, I am moving a block of code that iseditadg1_adg2_3d_luhar_pdf.F90editpdf_closure_module.F90adg1_adg2_3d_luhar_pdf.F90284816e2267c454cec10b226e2a9e4f5beed04791509086030000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am fixing a bug where rtp2 and thlp2 (and sclrp2) were not preserved when wp2 became very small. This bug is being fixed by treating the rtp2, thlp2, and sclrp2 distributions as single Gaussians in this limit. CLUBB Trac ticket reference: clubb:ticket:809. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8485 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 6fc49c6d8ff3e053530b7120b4085ec62f6b1c3c 2017-10-27 06:33:50 +0000284816e2267c454cec10b226e2a9e4f5beed0479I am fixing a bug where rtp2 and thlp2 (and sclrp2) were not preserved wheneditadg1_adg2_3d_luhar_pdf.F90new_tsdadg_pdf.F90f254c056660b61f160ad0ddb4add793c7fb6cedb1509086289000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI updated the TSDADG PDF by adding the responding variable description, the responding variable subroutine, and the driver subroutine. CLUBB Trac ticket reference: clubb:ticket:777. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8486 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 5aee19d916b7c32862b399d9be7cf52aa8cc95e9 2017-10-27 06:38:09 +0000f254c056660b61f160ad0ddb4add793c7fb6cedbI updated the TSDADG PDF by adding the responding variable description, theeditnew_tsdadg_pdf.F90pdf_closure_module.F908c5f2d26747d7b6a9fbd65eae0ce0a4dc8d6fb241509142043000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduWhen ADG1 or ADG2 are not used, we have to set alpha_rt, alpha_thl, and alpha_sclr to values (their default values) in order to avoid a runtime error from the Oracle compiler. Previous, we had been adding statements after the call to every non-ADG1-or-ADG2 PDF. I am changing that to do it in one spot, similar to the setting of the F_w, etc. output when the new PDF is used. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8488 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 3dda9fdc4aa7793281899453d947140fd8e9e9ab 2017-10-27 22:07:23 +00008c5f2d26747d7b6a9fbd65eae0ce0a4dc8d6fb24When ADG1 or ADG2 are not used, we have to set alpha_rt, alpha_thl, andeditpdf_closure_module.F90advance_clubb_core_module.F90pdf_closure_module.F9082e4512cd314dd9167d6fdf34c1c0131f534bae41509144224000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am calling the new TSDADG PDF from subroutine pdf_closure. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8489 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 47b687afb77aba9f3ad508722183a92a76cafff7 2017-10-27 22:43:44 +000082e4512cd314dd9167d6fdf34c1c0131f534bae4I am calling the new TSDADG PDF from subroutine pdf_closure.editpdf_closure_module.F90editadvance_clubb_core_module.F90new_tsdadg_pdf.F909e30e75783f5497150bf902e5ad196bf0c6644441509146193000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduClarity changes to the new TSDADG PDF. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8490 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 90d307cbedb920815bea8b4cb3e38bbf678ceee6 2017-10-27 23:16:33 +00009e30e75783f5497150bf902e5ad196bf0c664444Clarity changes to the new TSDADG PDF.editnew_tsdadg_pdf.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F904f8df90fd67b0ffb5fd8b8529e1ec87c7b49e7101509402367000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduI added some references to the CLUBB-SILHS tech doc. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8491 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 0909638d763d531940e2c39d0f29781bc944ba30 2017-10-30 22:26:07 +00004f8df90fd67b0ffb5fd8b8529e1ec87c7b49e710I added some references to the CLUBB-SILHS tech doc.editadvance_xm_wpxp_module.F90editadvance_clubb_core_module.F90editadvance_wp2_wp3_module.F90editadvance_xp2_xpyp_module.F90new_tsdadg_pdf.F90d619f5f53cd31fd5e70aed41cdcab497d5e3bde31509666227000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI fixed a bug in the calculation of PDF component variances in the new TSDADG PDF. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8492 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 0f2d324713d9aceaeb79e1068f22a5961d392fdb 2017-11-02 23:43:47 +0000d619f5f53cd31fd5e70aed41cdcab497d5e3bde3I fixed a bug in the calculation of PDF component variances in the new TSDADGeditnew_tsdadg_pdf.F90advance_wp2_wp3_module.F90pdf_closure_module.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90grid_class.F90advance_xm_wpxp_module.F9019feff73609725876ea3aecc264562c49276db711509740754000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduI added more references to the CLUBB-SILHS tech doc. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8493 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 9bbd2e209eb3c3eabfc3bb809173a9c749aa91bf 2017-11-03 20:25:54 +000019feff73609725876ea3aecc264562c49276db71I added more references to the CLUBB-SILHS tech doc.editpdf_closure_module.F90editadvance_clubb_core_module.F90editadvance_xm_wpxp_module.F90editadvance_wp2_wp3_module.F90editadvance_xp2_xpyp_module.F90editgrid_class.F90new_pdf_main.F9098527ca18b054a23337b2f533c07615fa3ea4eaa1510125763000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI have set the tunable parameters F_x and zeta_x to skewness functions for the new PDF. Coefficients are currently declared in the driver subroutine and then passed into subroutines and functions. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8496 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: c22cd4b53994328617fc67e53a7790cf1126a814 2017-11-08 07:22:43 +000098527ca18b054a23337b2f533c07615fa3ea4eaaI have set the tunable parameters F_x and zeta_x to skewness functions for theeditnew_pdf_main.F90stats_clubb_utilities.F90stats_zt_module.F90ccc0b6d541c0713648245747ab1eadaf9cfe888a1510273958000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI needed to increase the limit of nvarmax_zt so that LBA (and other cases that use Morrison microphysics) could be run with all_stats.in. I also improved the warning messages when the number of variables exceeds nvarmax_***. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8500 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 3f2cd8d90c71f059c2a0f5fe634139e31b77e32d 2017-11-10 00:32:38 +0000ccc0b6d541c0713648245747ab1eadaf9cfe888aI needed to increase the limit of nvarmax_zt so that LBA (and othereditstats_clubb_utilities.F90editstats_zt_module.F90advance_wp2_wp3_module.F90pdf_closure_module.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90grid_class.F90advance_xm_wpxp_module.F9010430950c7c61a6d3a595323d24a1307aab1a0571510584442000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduI changed the URL references to the CLUBB-SILHS overview document. Instead of pointing to the larson-group.com webpage, they now point to arxiv.org. The shorter URL forestalls error messages from the CLUBB standards script. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8501 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 9a8b38e22f389eff1c4a482ad5b599746d904ca5 2017-11-13 14:47:22 +000010430950c7c61a6d3a595323d24a1307aab1a057I changed the URL references to the CLUBB-SILHS overview document.editadvance_clubb_core_module.F90editpdf_closure_module.F90editadvance_xm_wpxp_module.F90editadvance_wp2_wp3_module.F90editadvance_xp2_xpyp_module.F90editgrid_class.F90advance_wp2_wp3_module.F90mixing_length.F90index_mapping.F90advance_clubb_core_module.F90clubb_api_module.F90numerical_check.F90Nc_Ncn_eqns.F90stats_clubb_utilities.F90surface_varnce_module.F90array_index.F90corr_varnce_module.F905d4fb30b6c9723bafca4801a43b485a2ff04d90e1510970587000http://carson.math.uwm.edu/jenkins/user/hoc_browserhoc_browserhoc_browserChanged variable and subroutine names, see ticket 810 and 811 git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8505 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 70c6930d3e20937b44ab1952c25f13703271bcf4 2017-11-18 02:03:07 +00005d4fb30b6c9723bafca4801a43b485a2ff04d90eChanged variable and subroutine names, see ticket 810 and 811editindex_mapping.F90editclubb_api_module.F90editNc_Ncn_eqns.F90editnumerical_check.F90editadvance_wp2_wp3_module.F90editmixing_length.F90editcorr_varnce_module.F90editsurface_varnce_module.F90editadvance_clubb_core_module.F90editstats_clubb_utilities.F90editarray_index.F90advance_clubb_core_module.F90LY93_pdf.F90pdf_closure_module.F9087941baa3c7e8cac1b5fc43eb23d3f5376ce79291511303535000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI have added the Lewellen and Yoh (1993) PDF to CLUBB for testing and comparison purposes. It has also been interfaced to CLUBB's unit testing and passes all unit tests. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8507 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 8b69cefc1eaee288c3bb9148f29f217bde5d22c2 2017-11-21 22:32:15 +000087941baa3c7e8cac1b5fc43eb23d3f5376ce7929I have added the Lewellen and Yoh (1993) PDF to CLUBB for testing and comparisoneditadvance_clubb_core_module.F90addLY93_pdf.F90editpdf_closure_module.F90advance_clubb_core_module.F90155144632ea823a8aad31c4e92c5dd2b12bd62fc1511310324000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixed line length exceding 100 characters warnings git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8510 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 5abcc9ff7571f0b1ee60353d593f0c9f6145e5ea 2017-11-22 00:25:24 +0000155144632ea823a8aad31c4e92c5dd2b12bd62fcFixed line length exceding 100 characters warningseditadvance_clubb_core_module.F90advance_clubb_core_module.F90mixing_length.F90cf54191c724355605855f800ef1e96aef010a2cb1512172470000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduChanged the arrangement of variables in the subroutine compute_mixing_length as well as calls to it clubb:ticket:815 git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8513 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: cafe9e697d9af413bdcfeee991fd94f7813cc6b7 2017-12-01 23:54:30 +0000cf54191c724355605855f800ef1e96aef010a2cbChanged the arrangement of variables in the subroutine compute_mixing_length as well as calls to it clubb:ticket:815editadvance_clubb_core_module.F90editmixing_length.F90advance_clubb_core_module.F901261bdb1eb0192241599c0695e77dbb74f33b4ab1512410380000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixed lines exceeding 100 characters warnings clubb:ticket:815 git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8514 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 5706620361cc9b71e02f6527da0fe30869e37fe0 2017-12-04 17:59:40 +00001261bdb1eb0192241599c0695e77dbb74f33b4abFixed lines exceeding 100 characters warnings clubb:ticket:815editadvance_clubb_core_module.F90advance_clubb_core_module.F90b9d643f8efaabb8279bdb89230899dc95569bd321513099575000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduI added an option to incorporate the buoyancy term into CLUBB's eddy diffusivity for momentum. This option is controlled by the flag l_use_buoy_mod_Km_zm, but that flag is set to false, and so this commit should leave the answers bit for bit identical. For clubb:ticket:791. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8515 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 1f56ceb1efb1b3d32e2fe232bdfa180a952e1aaf 2017-12-12 17:26:15 +0000b9d643f8efaabb8279bdb89230899dc95569bd32I added an option to incorporate the buoyancy term into CLUBB's eddy diffusivity for momentum.editadvance_clubb_core_module.F90advance_clubb_core_module.F907dbb97784343b514c33d7f8b85578d0af7b9cb2d1513100152000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduI added c_K10 as a tuning parameter in front of the new momentum eddy diffusivity. Again, the results shouldn't change because the option is shut off. For clubb:ticket:791 git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8516 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: c31cb2119386f1d98fd944e43db018ed1356d27c 2017-12-12 17:35:52 +00007dbb97784343b514c33d7f8b85578d0af7b9cb2dI added c_K10 as a tuning parameter in front of the new momentum eddy diffusivity.editadvance_clubb_core_module.F90output_grads.F90clubb_api_module.F90output_netcdf.F90Skx_module.F90setup_clubb_pdf_params.F90variables_diagnostic_module.F90anl_erf.F90advance_helper_module.F90852d264a2c802e30cd4e0f83cab4c9d417c77d061515116246000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduRemoved unused parameters to clear warnings clubb:ticket:803 git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8519 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 9b8095c6e057e7c0aa9d430ad419ad03a4065683 2018-01-05 01:37:26 +0000852d264a2c802e30cd4e0f83cab4c9d417c77d06Removed unused parameters to clear warnings clubb:ticket:803editoutput_grads.F90editsetup_clubb_pdf_params.F90editclubb_api_module.F90editvariables_diagnostic_module.F90editSkx_module.F90editadvance_helper_module.F90editanl_erf.F90editoutput_netcdf.F90advance_clubb_core_module.F90a63e4c88b6bcbd69a45cd2c6216327a9b01cffb01515451999000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduI multiplied the eddy diffusivity for momentum by a skewness-dependent factor that is intended to reduce momentum flux in cumulus layers. The idea is that the cumuli contribute an upgradient flux that is not taken into account by our prior downgradient formulation. However, the results should be bit-for-bit identical since the flag that implements this, l_use_buoy_mod_Km_zm, is set to false. For ticket:791. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8520 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 4b601fea96554aac3e98e5bc3745bac6d2205c25 2018-01-08 22:53:19 +0000a63e4c88b6bcbd69a45cd2c6216327a9b01cffb0I multiplied the eddy diffusivity for momentum by a skewness-dependent factoreditadvance_clubb_core_module.F90new_pdf_main.F90pdf_closure_module.F90c5944a96c830d5fbbe8595c7673cbfbe30c90c3e1515477099000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI changed the way that F_rt and F_thl are set in the new PDF. They are now set as a constant interpolation between min_F_x and max_F_x (where x is rt or thl), and the F_rt value can be reduced (toward min_F_rt) by exp_factor_rt, which is dependent on the adjusted (overall) correlation of rt and thl. The adjusted (overall) correlation of rt and thl is: adj_corr_rt_thl = rtpthlp / ( sqrt( rtp ) * sqrt( thlp2 ) ) * sgn( wprtp ) * sgn( wpthlp ). The exp_factor_rt is: exp_factor_rt = 1 - exp{ -0.2 * ( adj_corr_rt_thl + 1 )^5^ }. The equation for F_rt is: F_rt = min_F_rt + ( max_F_rt - min_F_rt ) * coef_rt * exp_factor_rt; where 0 <= coef_rt <= 1. The equation for F_thl is: F_thl = min_F_thl + ( max_F_thl - min_F_thl ) * coef_thl; where 0 <= coef_thl <= 1 (and where exp_factor_thl is simply set to 1). CLUBB Trac ticket references: clubb:ticket:777 and clubb:ticket:808. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8521 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: c7465ccca8ca132cae3740697ffb3ecf87b45781 2018-01-09 05:51:39 +0000c5944a96c830d5fbbe8595c7673cbfbe30c90c3eI changed the way that F_rt and F_thl are set in the new PDF. They are now seteditnew_pdf_main.F90editpdf_closure_module.F90new_pdf_main.F90085d3f50af1eebbbaa47033513bccf03506ab3ec1515477557000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI changed the flag setting on the new PDF so that it always uses w as the setter variable. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8522 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: f8df06311b269503e0721d31861f86af7a560f3d 2018-01-09 05:59:17 +0000085d3f50af1eebbbaa47033513bccf03506ab3ecI changed the flag setting on the new PDF so that it always uses w as the settereditnew_pdf_main.F90advance_wp2_wp3_module.F90pdf_utilities.F90mixing_length.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90fill_holes.F90Nc_Ncn_eqns.F90adg1_adg2_3d_luhar_pdf.F90surface_varnce_module.F90corr_varnce_module.F90mono_flux_limiter.F90ae9ae3e3dc30bd359760c86bee918562732d78591516236601000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduChanged many equality comparisons using == to a safer epsilon method, this should end up being BIT_CHANGING, clubb:ticket:803 git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8535 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 83f1ba5f428ff05246a994886955eca43d7cfe7b 2018-01-18 00:50:01 +0000ae9ae3e3dc30bd359760c86bee918562732d7859Changed many equality comparisons using == to a safer epsilon method, this should end up being BIT_CHANGING, clubb:ticket:803editadvance_wp2_wp3_module.F90editadvance_xm_wpxp_module.F90editcorr_varnce_module.F90editmono_flux_limiter.F90editpdf_utilities.F90editNc_Ncn_eqns.F90editmixing_length.F90editadvance_xp2_xpyp_module.F90editfill_holes.F90editsurface_varnce_module.F90editadvance_clubb_core_module.F90editadg1_adg2_3d_luhar_pdf.F90interpolation.F900f8a60bbc1f530c8ff72359bad1438b0a5ee610f1516410520000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduImproved binary search algorithm clubb:ticket:818 git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8536 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 8f8b516d82350d2ceff815e5fa1a153d1908f4ac 2018-01-20 01:08:40 +00000f8a60bbc1f530c8ff72359bad1438b0a5ee610fImproved binary search algorithm clubb:ticket:818editinterpolation.F90interpolation.F901cbe16fb05b01b1b4cf50b2c65deb6c5ceb310981516661233000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdded warning messages to function binary_search clubb:ticket:818 git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8537 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 55a8aaab680d5c3fc8c5d26479a4a3ec00dd25f0 2018-01-22 22:47:13 +00001cbe16fb05b01b1b4cf50b2c65deb6c5ceb31098Added warning messages to function binary_search clubb:ticket:818editinterpolation.F90advance_xp2_xpyp_module.F90Nc_Ncn_eqns.F90adg1_adg2_3d_luhar_pdf.F906f7801daba3f1a59ce0a4c8c41d6c871fe9595021516662112000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduRemoved unused variables causing warnings clubb:ticket:803 git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8538 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 447dda2b6f9f50dbdc0ead7ebb04c82173e5ad39 2018-01-22 23:01:52 +00006f7801daba3f1a59ce0a4c8c41d6c871fe959502Removed unused variables causing warnings clubb:ticket:803editadvance_xp2_xpyp_module.F90editNc_Ncn_eqns.F90editadg1_adg2_3d_luhar_pdf.F90pdf_closure_module.F90new_pdf_main.F9032948e0ff5444ecbf76708f75bd469a8bd2dbf271516688723000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI updated the call to the new PDF so that Skrt and Skthl are intent INOUT variables. In the scenario that either one (or both) of these skewnesses are clipped in the new PDF, the updated values of Skrt and Skthl are passed out. This is necessary for the PDF parameter unit tests to work properly. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8539 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 8c597babe3e55f0052ca3b582ed7f5aaf64a3e3e 2018-01-23 06:25:23 +000032948e0ff5444ecbf76708f75bd469a8bd2dbf27I updated the call to the new PDF so that Skrt and Skthl are intent INOUTeditpdf_closure_module.F90editnew_pdf_main.F90precipitation_fraction.F901911423245af862a7eb5e57f8e9bcc91b8af88d81516832610000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduRemoved many eqaulity comparison warnings in precipitation_fraction.F90 clubb:ticket:803 git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8545 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: bf1ce0c334d2290189095d16da33b3298eea51be 2018-01-24 22:23:30 +00001911423245af862a7eb5e57f8e9bcc91b8af88d8Removed many eqaulity comparison warnings in precipitation_fraction.F90 clubb:ticket:803editprecipitation_fraction.F90pdf_closure_module.F90d56edc54adcaea428260146d038a0f6893a6bcdc1516914489000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am adding a new function, calc_wpxpyp_pdf, to pdf_closure_module.F90. This function calculates the <w'x'y'> term that I derived by integrating over the PDF. This function is used to calculate <w'rt'thl'>. Shortly, it will also be used to calculate <w'sclr'rt'> and <w'sclr'thl'>. This new calculation of <w'x'y'> allows for the PDF component correlations involving w to have a value other than 0. This generalizes the calculation for a PDF other than ADG1 or ADG2. CLUBB's calculation of wprtpthlp in pdf_closure is currently just used for statistical output. For ADG1, the old form and the new form of wprtpthlp produce the same result mathematically. However, owing to numerical roundoff, the results of the wprtpthlp in the new revision are BIT_CHANGING compared to the old revision. Otherwise, the results in GrADS output files for all other outputs from this revision are an exact match to the results in GrADS output files from the previous revision for all cases. CLUBB Trac ticket reference: clubb:ticket:777 and clubb:ticket:806. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8546 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 85a115499facd5577647492c2a1cc8c1419b2426 2018-01-25 21:08:09 +0000d56edc54adcaea428260146d038a0f6893a6bcdcI am adding a new function, calc_wpxpyp_pdf, to pdf_closure_module.F90. Thiseditpdf_closure_module.F90pdf_closure_module.F90fd7aa20bb54009799ca395df136dc7703462c6981516914792000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI finished adding the units to the variable descriptions in function calc_wpxpyp_pdf. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8547 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 227018a956203820e0e6e3deb63d7064442e00ad 2018-01-25 21:13:12 +0000fd7aa20bb54009799ca395df136dc7703462c698I finished adding the units to the variable descriptions ineditpdf_closure_module.F90pdf_closure_module.F905c5313f5a0d4fc7b43a834ff3603f7ea4312d8b31516921136000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduThe calculation of higher-order scalar terms <w'^2^ sclr'>, <w'sclr'^2^>, <w'sclr'rt'>, and <w'sclr'thl'> are now generalzed for any PDF type. For ADG1, the old form and the new form of these scalar terms produce the same results mathematically. However, owing to numerical roundoff, the results of the calculations in the new revision are altered compared to the old revision. Since scalar calculations aren't output to standard stats, the results in GrADS output files from this revision are an exact match to the results in GrADS output files from the previous revision for all cases. CLUBB Trac ticket reference: clubb:ticket:806. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8548 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 1de02e2e856ebe28ccf7fa96e26e146a7c1de5fe 2018-01-25 22:58:56 +00005c5313f5a0d4fc7b43a834ff3603f7ea4312d8b3The calculation of higher-order scalar terms <w'^2^ sclr'>, <w'sclr'^2^>,editpdf_closure_module.F90parameters_tunable.F90parameter_indices.F90clubb_api_module.F90new_pdf_main.F90e6afdac47f9659f2f9d0616bf08f7f036ecde46f1517097814000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added the tunable or adjustable parameters for the new PDF to CLUBB's list of tunable parameters. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8550 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: c2d6df498f894b70febc252006b96502a6877d88 2018-01-28 00:03:34 +0000e6afdac47f9659f2f9d0616bf08f7f036ecde46fI added the tunable or adjustable parameters for the new PDF to CLUBB's listeditparameter_indices.F90editparameters_tunable.F90editclubb_api_module.F90editnew_pdf_main.F90advance_clubb_core_module.F90clubb_api_module.F90advance_xm_wpxp_module.F90numerical_check.F90pdf_closure_module.F90diagnose_correlations_module.F90new_pdf_main.F90advance_helper_module.F903a41920e95d798623cc40f94168d709e0654c81a1517876940000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixed various warnings. Mainly by removing unused variables and commenting out unused procedures. See clubb:ticket:803 git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8567 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 9fcc71ba9fe9e105b1180b1357a4a8513073d9fc 2018-02-06 00:29:00 +00003a41920e95d798623cc40f94168d709e0654c81aFixed various warnings. Mainly by removing unused variables and commenting out unused procedures. See clubb:ticket:803editadvance_helper_module.F90editclubb_api_module.F90editnumerical_check.F90editadvance_xm_wpxp_module.F90editdiagnose_correlations_module.F90editadvance_clubb_core_module.F90editnew_pdf_main.F90editpdf_closure_module.F90new_pdf_main.F904200fe360ce72c7377df0b0f5c80643f8d7497f01517981333000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am committing a line of code that limits the adjusted correlation of rt and theta-l at max_mag_correlation or -max_mag_correlation. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8569 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: b92144149facd0a7521fbcdba3baac2f3cd6a4c6 2018-02-07 05:28:53 +00004200fe360ce72c7377df0b0f5c80643f8d7497f0I am committing a line of code that limits the adjusted correlation of rt andeditnew_pdf_main.F90advance_clubb_core_module.F908dc0d797bb099c02aed79d9360606e549e23ff5e1518207624000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduI implemented a new method to handle cumulus momentum fluxes. It approximates upthvp in terms of dthlm/dz. The old method, based on Skw, has been commented out. This should not change answers because l_use_buoy_mod_Km_zm = .false. For clubb:ticket:791. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8577 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 97de0326fbb8c32763efecac95e27e8fe7204361 2018-02-09 20:20:24 +00008dc0d797bb099c02aed79d9360606e549e23ff5eI implemented a new method to handle cumulus momentum fluxes.editadvance_clubb_core_module.F90Nc_Ncn_eqns.F90pdf_closure_module.F90mono_flux_limiter.F903290e0eba4a72f8a7ec08d543e1105ab05cc85971519264565000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduSwitched from using the erf function defined by anl_erf to the intristic erf function. This should be BIT_CHANGING see clubb:ticket:804 git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8581 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: c47f680bc0e4fa7ba6a8989a2c15a9f3b1a3ece3 2018-02-22 01:56:05 +00003290e0eba4a72f8a7ec08d543e1105ab05cc8597Switched from using the erf function defined by anl_erf to the intristic erf function. This should be BIT_CHANGING see clubb:ticket:804editNc_Ncn_eqns.F90editpdf_closure_module.F90editmono_flux_limiter.F90anl_erf.F9067891bdb3d2819c6e890c4ea998b2c25fc64607a1519264797000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduRemoved file anl_erf.F90, it is no longer used git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8582 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 889fed911d2db4710e36ccacba8ee82ebc6cb85c 2018-02-22 01:59:57 +000067891bdb3d2819c6e890c4ea998b2c25fc64607aRemoved file anl_erf.F90, it is no longer useddeleteanl_erf.F90advance_clubb_core_module.F90advance_wp2_wp3_module.F90496afc42dfa487aa03127eaae63bef0ab026d5531519716378000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am altering the solution to the wp3 predictive equation to calculate the turbulent advection term and the turbulent production term independently. Mathematically, the code is still the same, but numerically, there will be round-off level differences between the old version and the new version. This revision is BIT_CHANGING. However, plotgen shows that lines for the old version and the new version overlap. The only cases that show any differences are the cases that are traditionally extremely sensitive. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8584 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 817ad4cce25c98568f8b5f7239e623c56505195d 2018-02-27 07:26:18 +0000496afc42dfa487aa03127eaae63bef0ab026d553I am altering the solution to the wp3 predictive equation to calculate theeditadvance_clubb_core_module.F90editadvance_wp2_wp3_module.F90advance_wp2_wp3_module.F90model_flags.F9058ac5319ebb7dbec2410e3dff1fa80c3999a9be51519792557000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI fixed the problem with the wp3 budgets as a result of r8584. The budgets in the new revision now match (lines overlap) the budgets from r8583. I also added the l_use_explicit_turbulent_adv flag, which will be used to allow an explicit treatment of the turbulent advection term (for those equations where the turbulent advection term is calculated by integrating over the PDF). git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8585 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 15e67de170ecb2fe141ad76cccf699e67883d1e0 2018-02-28 04:35:57 +000058ac5319ebb7dbec2410e3dff1fa80c3999a9be5I fixed the problem with the wp3 budgets as a result of r8584. The budgets ineditadvance_wp2_wp3_module.F90editmodel_flags.F90advance_xm_wpxp_module.F90advance_xp2_xpyp_module.F900908a71238f2462ae5f5b6b88c52689ba918e13f1519940856000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI altered the names of the turbulent advection functions that are closed by the PDF (from integration over the PDF). The current functions have been altered to include ADG1 in their names, because the closure is done by assuming ADG1 is the PDF used. The results of this revision are an exact match to the results from the previous revision for all cases. However, yesterday's clubb:r8587 changed results without including BIT_CHANGING in the commit message, so that is being added here to reset the appropriate Bitten test. CLUBB Trac ticket reference: clubb:ticket:804. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8589 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 59983e00cb8d7b0d64af979ab088c411ff760466 2018-03-01 21:47:36 +00000908a71238f2462ae5f5b6b88c52689ba918e13fI altered the names of the turbulent advection functions that are closed byeditadvance_xm_wpxp_module.F90editadvance_xp2_xpyp_module.F90advance_xm_wpxp_module.F90advance_xp2_xpyp_module.F9054acce1ef42b67cfeff425f4b147f1a396d108f21519941671000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added a couple comments about how the discretization of the turbulent advection terms are specific to the ADG1 PDF. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8590 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 6759e06e920dd46cbd647292b8f39a9f1fe53acd 2018-03-01 22:01:11 +000054acce1ef42b67cfeff425f4b147f1a396d108f2I added a couple comments about how the discretization of the turbulenteditadvance_xm_wpxp_module.F90editadvance_xp2_xpyp_module.F90advance_wp2_wp3_module.F906bbed2efbc5d562a7f4aded4c5b0d5eadba2912b1519976572000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added the function that sets up the implicit calculation of the wp3 turbulent advection term for the new PDF. This has not yet been interfaced with the code. CLUBB Trac ticket reference: clubb:ticket:777. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8591 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 782eb348eff41c4908448320d84b859108e3bcd6 2018-03-02 07:42:52 +00006bbed2efbc5d562a7f4aded4c5b0d5eadba2912bI added the function that sets up the implicit calculation of the wp3 turbulenteditadvance_wp2_wp3_module.F90advance_wp2_wp3_module.F9060e6f11dd819cafcfa5a4c6b1f7c3ed713d1f6541520044506000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added a function that calculates the explicit form of the wp3 turbulent advection term to advance_wp2_wp3_module.F90. This option works for any PDF type. CLUBB Trac ticket reference: clubb:ticket:777. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8592 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 3e9e64e2476e7196d4b35f62eabb21b4fb684a1f 2018-03-03 02:35:06 +000060e6f11dd819cafcfa5a4c6b1f7c3ed713d1f654I added a function that calculates the explicit form of the wp3 turbulenteditadvance_wp2_wp3_module.F90advance_wp2_wp3_module.F90advance_xm_wpxp_module.F90821c06bfa97f773d98c40085edb2645fd6e407be1520281347000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am adding a function to calculate the turbulent advection of wpxp explicitly. CLUBB Trac ticket reference: clubb:ticket:777. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8593 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 23fe1bf4037d21c1827c4ff9e46012a5f88090b5 2018-03-05 20:22:27 +0000821c06bfa97f773d98c40085edb2645fd6e407beI am adding a function to calculate the turbulent advection of wpxp explicitly.editadvance_wp2_wp3_module.F90editadvance_xm_wpxp_module.F90advance_xp2_xpyp_module.F905234cd6880cd9f87b335bc9ad183df7bb74a59921520286920000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am adding a function to calculate the turbulent advection of xp2 and xpyp explicitly. This option works for any PDF type. CLUBB Trac ticket reference: clubb:ticket:777. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8594 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 501c3fde5d6941d5913c78f7106c70681d33d9b6 2018-03-05 21:55:20 +00005234cd6880cd9f87b335bc9ad183df7bb74a5992I am adding a function to calculate the turbulent advection of xp2 and xpypeditadvance_xp2_xpyp_module.F90advance_wp2_wp3_module.F90pdf_closure_module.F90advance_clubb_core_module.F90model_flags.F90186420004c5507db0ee5040a91b25298e89ca8db1520310367000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI interfaced the wp3 explicit turbulent advection code with CLUBB. It is turned off by default. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8595 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 985667d04c031b0b8feb554b6edb1260a3e94faf 2018-03-06 04:26:07 +0000186420004c5507db0ee5040a91b25298e89ca8dbI interfaced the wp3 explicit turbulent advection code with CLUBB. It iseditadvance_clubb_core_module.F90editmodel_flags.F90editadvance_wp2_wp3_module.F90editpdf_closure_module.F90advance_wp2_wp3_module.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F9048ea03ac7ef620f41952bc774f75e0ee29a68f711520401533000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am interfacing the wpxp explicit turbulent advection option with the rest of the code. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8596 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: b092b91fbe367a6a286ce1eb60b65edb011e5157 2018-03-07 05:45:33 +000048ea03ac7ef620f41952bc774f75e0ee29a68f71I am interfacing the wpxp explicit turbulent advection option with the rest ofeditadvance_wp2_wp3_module.F90editadvance_clubb_core_module.F90editadvance_xm_wpxp_module.F90advance_wp2_wp3_module.F90advance_xm_wpxp_module.F907d58047821a003b123d8388e646c29942dee2ab31520452845000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI fixed a small bug with the explicit turbulent advection option for wpxp. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8597 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: f5b172c76dd5ad50fd0f97c306454957ccad410f 2018-03-07 20:00:45 +00007d58047821a003b123d8388e646c29942dee2ab3I fixed a small bug with the explicit turbulent advection option for wpxp.editadvance_wp2_wp3_module.F90editadvance_xm_wpxp_module.F90advance_xp2_xpyp_module.F90pdf_closure_module.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90ecda7108a1fdb1ec9d9ea3b17af63c07090db3d11520462369000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am interfacing the xp2/xpyp explicit turbulent advection term with CLUBB code. This works generally for any PDF type. CLUBB Trac ticket reference: CLUBB:ticket:777. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8598 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 9af9946863af42ee030e3b4db8c5ae82b5708d49 2018-03-07 22:39:29 +0000ecda7108a1fdb1ec9d9ea3b17af63c07090db3d1I am interfacing the xp2/xpyp explicit turbulent advection term with CLUBB code.editadvance_xp2_xpyp_module.F90editpdf_closure_module.F90editadvance_clubb_core_module.F90editadvance_xm_wpxp_module.F90new_pdf_main.F904c69f1b72a411929d718806f5cda271949ad9a431520551911000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added the l_explicit_turbulent_adv_* family of flags to the new PDF, for some calculations don't need to be made when turbulent advection is being treated explicitly. CLUBB Trac ticket reference: clubb:ticket:777. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8599 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: f477c736d61efd958d2442176fcdf3ca91f10bd2 2018-03-08 23:31:51 +00004c69f1b72a411929d718806f5cda271949ad9a43I added the l_explicit_turbulent_adv_* family of flags to the new PDF, for someeditnew_pdf_main.F90advance_clubb_core_module.F90new_pdf_main.F90pdf_closure_module.F90199de59e71871807cd93bcb4ebc98e799a85a3491520977857000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am packing up the implicit coefficients and explicit terms calculated by the new PDF into a derived type variable. That variable is passed back to advance_clubb_core so it can be used for such things as implicit turbulent advection of wp3, etc. This variable is also passed into the PDF parameter unit tests. There, in the future, it will be used for such things as double checking such things as: wp4 = coef_wp4_implicit * wp2^2^, etc. CLUBB Trac ticket reference: clubb:ticket:777. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8602 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: c69c21bfdbfa0ab19a6545692b1682ecf34cdaba 2018-03-13 21:50:57 +0000199de59e71871807cd93bcb4ebc98e799a85a349I am packing up the implicit coefficients and explicit terms calculated by theeditnew_pdf_main.F90editpdf_closure_module.F90editadvance_clubb_core_module.F90model_flags.F90a89104550d9e46e533fa31bf3bd92c83677614b61520982937000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMade epss variable based on its use by adding flag l_high_accuracy_parab_cyl_fnc. Low accuracy for runs (epss=1e-4) and high accuracy for tests (epss=1e-15), see clubb:ticket:804 git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8603 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: b8da02f687d55e0d56b7d1c141da50be60d06ada 2018-03-13 23:15:37 +0000a89104550d9e46e533fa31bf3bd92c83677614b6Made epss variable based on its use by adding flag l_high_accuracy_parab_cyl_fnc. Low accuracy for runs (epss=1e-4) and high accuracy for tests (epss=1e-15), see clubb:ticket:804editmodel_flags.F90new_pdf.F906d734fcb31a8876c05eae5b5ad869762c825603d1521052615000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI made a slight change to function calc_coef_wpxp2_implicit in new_pdf.F90. A small bug was brought to light by last night's G unit test failure. CLUBB Trac ticket reference: clubb:ticket:777. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8604 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: bfdba85d07239103cc20ee7cf1445976d442f95c 2018-03-14 18:36:55 +00006d734fcb31a8876c05eae5b5ad869762c825603dI made a slight change to function calc_coef_wpxp2_implicit in new_pdf.F90.editnew_pdf.F90advance_clubb_core_module.F90advance_wp2_wp3_module.F901624553b92964a93b60b81bc053b580e43ebd2871521067112000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI have completed interfacing the implicit form of the wp3 turbulent advection term for the new PDF with the rest of the CLUBB code. CLUBB Trac ticket reference: clubb:ticket:777. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8605 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 33dfdbb42d1322be71e5011913a6a57fb2e0aa31 2018-03-14 22:38:32 +00001624553b92964a93b60b81bc053b580e43ebd287I have completed interfacing the implicit form of the wp3 turbulent advectioneditadvance_clubb_core_module.F90editadvance_wp2_wp3_module.F90advance_clubb_core_module.F9042c5e04bcbd0387f44c6b3ac17b9ebbb787579f91521069079000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduWhen the l_explicit_turbulent_adv_wp3 flag is enabled, the turbulent advection of wp3 at thermodynamic level 2 is based on wp4 at momentum levels 1 and 2. The value of wp4 at momentum level 1 is calculated by interpolating the values of wp4_zt that is calculated by integrating over the PDF at thermodynamic levels 1 and 2. However, the values that come from the call to pdf_closure at thermodynamic level 1 (the "below ground" level) are unreliable because the inputs are unreliable at that particular level. The best solution is to simply set wp4 at momentum level 1 to 0. This also matches the value of wp4 at the upper boundary. By default, CLUBB does not use explicit turbulent advection. However, the results are technically BIT_CHANGING because wp4 is still output to statistics. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8606 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: e5488acd9de2a8e9219a27ff57c3cba664c8826c 2018-03-14 23:11:19 +000042c5e04bcbd0387f44c6b3ac17b9ebbb787579f9When the l_explicit_turbulent_adv_wp3 flag is enabled, the turbulent advectioneditadvance_clubb_core_module.F90Skx_module.F90f645a7fa5b5eab7ab36b427730226ba206db0d6a1521147148000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI cleaned up the Skx_module and added an additional function, xp3_LG_2005_ansatz, which calculates xp3 using Skx from the LG 2005 ansatz. The results in GrADS output files from this revision are an exact match to the results in GrADS output files from the previous revision for all cases. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8608 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 709538fce7534b77ec33ae37bbb69353379f7672 2018-03-15 20:52:28 +0000f645a7fa5b5eab7ab36b427730226ba206db0d6aI cleaned up the Skx_module and added an additional function,editSkx_module.F90advance_clubb_core_module.F90model_flags.F90Skx_module.F900f015a9eca1f27ecd084f20d80713c35e94db7c91521151331000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI fixed a bug in the calculation of scalar skewness. It was being set to 0, causing problems with the new PDF. I corrected the bug and I also made the scalar skewness code a little more user friendly. It is now controlled by a flag, l_use_xp3_LG_2005_ansatz, which is set to true by default. In the default ADG1 code, the LG 2005 ansatz is not used interactively. It only outputs to stats. This commit is BIT_CHANGING only because statistics change. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8610 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: d86300fff06c4ae2f1d5673e6a0e1c22cf8566a6 2018-03-15 22:02:11 +00000f015a9eca1f27ecd084f20d80713c35e94db7c9I fixed a bug in the calculation of scalar skewness. It was being set to 0,editmodel_flags.F90editadvance_clubb_core_module.F90editSkx_module.F90advance_clubb_core_module.F90bce822492723d4d4b56113dc49125951ee4f004d1521152411000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI moved the location of the LG 2005 ansatz to calculate xp3 because it would be more helpful for testing purposes before the first call to pdf_closure_driver (which is the call we use). In default CLUBB, this affects only statistics. However, this change is technically BIT_CHANGING. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8611 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 3a1c774648552b4fb8b0d3e4799bd460890f8b3b 2018-03-15 22:20:11 +0000bce822492723d4d4b56113dc49125951ee4f004dI moved the location of the LG 2005 ansatz to calculate xp3 because it would beeditadvance_clubb_core_module.F90advance_clubb_core_module.F90a85dc94233b2feac1f7631b66fc16268f1bd47111521251292000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI reverted clubb:r8611 because (1) having the code in the other location introduced a bug, and (2) upon further review, it just makes more sense in this location, and is more consistent with the rest of the code. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8614 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 71881434bb65be73688a08b4f88bd556f1733a6b 2018-03-17 01:48:12 +0000a85dc94233b2feac1f7631b66fc16268f1bd4711I reverted clubb:r8611 because (1) having the code in the other locationeditadvance_clubb_core_module.F90advance_xp2_xpyp_module.F905eb6a87a6ff59bcc68d56a668a1fddf396f07a4a1521502260000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI have added a new function, term_ta_new_pdf_lhs, to advance_xp2_xpyp_module.F90. This function will handle the implicit turbulent advection for xp2 and the implicit portion of the semi-implicit turbulent advection for xpyp for the new PDF. This code has not yet been interfaced with the rest of CLUBB. The previous commit, r8614, changed statistical results, but I forgot to put a BIT_CHANGING in the log message, so here it is. CLUBB Trac ticket reference: clubb:ticket:777. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8615 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 4a56ec579a61738b9a433cadb76b95ea2e234052 2018-03-19 23:31:00 +00005eb6a87a6ff59bcc68d56a668a1fddf396f07a4aI have added a new function, term_ta_new_pdf_lhs, toeditadvance_xp2_xpyp_module.F90advance_clubb_core_module.F90advance_xp2_xpyp_module.F901a64aba9e0965e5ca2be2ae42114ecfd18324a881521603467000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI have linked the implicit turbulent advection code for rtp2 and thlp2 to the rest of the CLUBB code. CLUBB Trac ticket reference: clubb:ticket:777. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8616 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 5c892b7b825cfdea679a968ea139fa8e360c758a 2018-03-21 03:37:47 +00001a64aba9e0965e5ca2be2ae42114ecfd18324a88I have linked the implicit turbulent advection code for rtp2 and thlp2 to theeditadvance_clubb_core_module.F90editadvance_xp2_xpyp_module.F90advance_xp3_module.F9032ef7b3f76f1eeb30646cd50c0c3f6d0fd9138151521949587000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI have added a new file that has two options for handling the xp3 term for scalars (thlp3, rtp3, and sclrp3). Both options are based on the d(xp3)/dt equation. One option predicts xp3 with the turbulent production, accumulation, and turbulent dissipation terms. The other option uses a steady-state approximation (dxp3/dt = 0) and calculates xp3 from the same three terms, since xp3 is found in the turbulent dissipation term. This has not yet been interfaced with the rest of the CLUBB code. When it is, this code will be one option for calculating xp3, with the other option being the ansatz. CLUBB Trac ticket reference: clubb:ticket:822. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8618 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 7be02a8f18fcc08247c90045078ea95a36bc041e 2018-03-25 03:46:27 +000032ef7b3f76f1eeb30646cd50c0c3f6d0fd913815I have added a new file that has two options for handling the xp3 term foraddadvance_xp3_module.F90advance_xp3_module.F90advance_clubb_core_module.F90model_flags.F9036fc76e515e1809b0c2db8c8acbb6caf6c2bc5e41521954033000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI have interface the new xp3 code to the rest of CLUBB. It can be turned on with the l_advance_xp3 flag in model_flags.F90. It is turned off by default, which means that default CLUBB still continues to use the ansatz to calculate xp3. The results in GrADS output files from this revision are and exact match to the results in GrADS output files from the previous revision for all cases. CLUBB Trac ticket reference: clubb:ticket:822. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8619 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 8b94ac8fb33138049c067c06d5aeae2c4279510b 2018-03-25 05:00:33 +000036fc76e515e1809b0c2db8c8acbb6caf6c2bc5e4I have interface the new xp3 code to the rest of CLUBB. It can be turned oneditmodel_flags.F90editadvance_xp3_module.F90editadvance_clubb_core_module.F90advance_xp3_module.F90advance_clubb_core_module.F90817b7d5301840ee5fa5fe98b74b066903a356caa1522268903000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added a driver level subroutine for the new advance xp3 code. This will make it easier to add xp3 budget statistics. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8622 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: d0f2a8e83ed686b15cee05cecf437abc9528da86 2018-03-28 20:28:23 +0000817b7d5301840ee5fa5fe98b74b066903a356caaI added a driver level subroutine for the new advance xp3 code. This will makeeditadvance_xp3_module.F90editadvance_clubb_core_module.F90stats_variables.F90advance_xp3_module.F90stats_zt_module.F907d820dc808911b68c5bc7b3bc79824426e2e6beb1522276133000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added budget stats for rtp3 and thlp3 to CLUBB. Since this commit adds statistics, it is technically BIT_CHANGING. However, the results in GrADS zm, sfc, etc. output files from this revision are an exact match to the results in the same GrADS output files from the previous revision for all cases. CLUBB Trac ticket reference: clubb:ticket:822. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8624 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: c1f320b0d32ee3c7f42a22465d991fcfa69645df 2018-03-28 22:28:53 +00007d820dc808911b68c5bc7b3bc79824426e2e6bebI added budget stats for rtp3 and thlp3 to CLUBB.editstats_variables.F90editstats_zt_module.F90editadvance_xp3_module.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90ddc181ff3266df2b2d9620d409d13c09cab4d2bd1523057575000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am adding code that allows the turbulent advection of wpxp to be treated semi-implicitly for the new PDF. The wpxp code was already split into two sections based on an "if" statement. One section uses a single left-hand side, and the other section uses three left-hand sides (for wprtp, wpthlp, and wpsclrp). The new code has been added to the section with three left-hand sides. For the section with a single left-hand side, dummy variables are passed instead. The default is to call the single left-hand side, and it will remain that way. When the single left-hand side is called, the new PDF must use explicit turbulent advection. However, since the code was already there for the section with three left-hand sides, it made sense to enter the semi-implicit code in that section. This way, for the new PDF, the semi-implicit turbulent advection can be compared to the explicit turbulent advection to see if there is any downgrade in results. For ADG1, the implicit turbulent advection and the explicit turbulent advection produce very similar results. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8629 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 71546e35186628f4a7290aac600d51d946fe5eda 2018-04-06 23:32:55 +0000ddc181ff3266df2b2d9620d409d13c09cab4d2bdI am adding code that allows the turbulent advection of wpxp to be treatededitadvance_xm_wpxp_module.F90editadvance_clubb_core_module.F90clubb_api_module.F90advance_xm_wpxp_module.F90diagnose_correlations_module.F90stats_type_utilities.F90grid_class.F90setup_clubb_pdf_params.F90surface_varnce_module.F90advance_windm_edsclrm_module.F90mono_flux_limiter.F90advance_wp2_wp3_module.F90mixing_length.F90advance_xp2_xpyp_module.F90error_code.F90pdf_closure_module.F90corr_varnce_module.F90precipitation_fraction.F90numerical_check.F90pos_definite_module.F90gmres_wrap.F90parameters_tunable.F90advance_clubb_core_module.F90lapack_wrap.F90fill_holes.F90interpolation.F90stats_clubb_utilities.F903f1dc0ded1ee5f8b5885043aaf605e2233d04d2e1524171137000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduRedesigned error code system. Errors are now treated as strictly fatal, meaning they are only thrown by procedures which cannot continue or has detected something that will crash the code. When the error occurs the procedure which detected it should immediately report it and either return to its calling procedure or stop the program, this is to avoid a cascade of error reports due to a single error. Other problems are now reported at level 1 and 2 debugging and only write the error out rather than set a code. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8635 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 0864df227743b27686b96e826991a1bf7fd8c18b 2018-04-19 20:52:17 +00003f1dc0ded1ee5f8b5885043aaf605e2233d04d2eRedesigned error code system. Errors are now treated as strictly fatal, meaning they are only thrown by procedures which cannot continue or has detected something that will crash the code. When the error occurs the procedure which detected it should immediately report it and either return to its calling procedure or stop the program, this is to avoid a cascade of error reports due to a single error. Other problems are now reported at level 1 and 2 debugging and only write the error out rather than set a code.editpos_definite_module.F90editdiagnose_correlations_module.F90editinterpolation.F90editgrid_class.F90editnumerical_check.F90editsetup_clubb_pdf_params.F90editpdf_closure_module.F90editparameters_tunable.F90editlapack_wrap.F90editcorr_varnce_module.F90editfill_holes.F90editmono_flux_limiter.F90editsurface_varnce_module.F90editstats_clubb_utilities.F90editadvance_clubb_core_module.F90editprecipitation_fraction.F90editadvance_windm_edsclrm_module.F90editclubb_api_module.F90editgmres_wrap.F90editerror_code.F90editadvance_wp2_wp3_module.F90editadvance_xp2_xpyp_module.F90editstats_type_utilities.F90editmixing_length.F90editadvance_xm_wpxp_module.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90clubb_api_module.F90lapack_wrap.F90pdf_closure_module.F90surface_varnce_module.F90advance_windm_edsclrm_module.F90mono_flux_limiter.F90771489f3d5884d9c350e7027e61919193798dda71524267660000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduVarious small comment removals and returned some functionality to api interface clubb:ticket:800 git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8637 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: fac7d1bad2fad4ffdc0012c6bd39c48dcb299c46 2018-04-20 23:41:00 +0000771489f3d5884d9c350e7027e61919193798dda7Various small comment removals and returned some functionality to api interface clubb:ticket:800editadvance_xm_wpxp_module.F90editpdf_closure_module.F90editadvance_clubb_core_module.F90editsurface_varnce_module.F90editclubb_api_module.F90editadvance_wp2_wp3_module.F90editadvance_xp2_xpyp_module.F90editlapack_wrap.F90editmono_flux_limiter.F90editadvance_windm_edsclrm_module.F90numerical_check.F90e825a918920d5b8f6477c6fac06251a72a67f51b1524613862000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduA variable found to be less than zero now only gives a warning rather than setting an error code. Some fatal error checks also changed from debug level 2 to 0 clubb:ticket:800 git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8640 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 0a7c278ab999293009a3e48ffaa63e7c5e73834e 2018-04-24 23:51:02 +0000e825a918920d5b8f6477c6fac06251a72a67f51bA variable found to be less than zero now only gives a warning rather than setting an error code. Some fatal error checks also changed from debug level 2 to 0 clubb:ticket:800editnumerical_check.F90stats_clubb_utilities.F90advance_clubb_core_module.F90stats_variables.F90stats_zm_module.F90cd544c579e1b8dd3405333d72763477ac77d7d571524689472000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduThis is the first part of a two-part change. I am updating plotgen plots so that they contain wpthvp followed by the contribution of cloud water to wpthvp, wp2thvp followed by the contribution of cloud water to wp2thvp, thlpthvp followed by the contribution of cloud water to thlpthvp, and rtpthvp followed by the contribution of cloud water to rtpthvp. In order to plot the contribution of cloud water, a variable named rc_coef is needed. Previously, this had been output on momentum levels so that it could be used to calculate the contribution of cloud water to wpthvp, thlpthvp, and rtpthvp. However, wp2thvp (and wp2rcp) are thermodynamic-level variables, so the contribution of cloud water to wp2thvp couldn't be plotted because plotgen can't handle variables from two different files (zm and zt) in the same equation. In order to plot everything, rc_coef needs to be output on both momentum levels and thermodynamic levels. As a first step, I have renamed the previous rc_coef as rc_coef_zm. The variable rc_coef is calculated based mainly on constants. However, the does contain exner, which is a thermodynamic-level variable. Additionally, it is calculated as part of pdf_closure, which is called on thermodynamic levels. The results in GrADS output files from this revision are an exact match to the results in GrADS output files from the previous revision for all cases. The variable name rc_coef has been changed to rc_coef_zm in all GrADS _zm *.ctl files. CLUBB Trac ticket reference: clubb:ticket:824. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8641 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 09c06d8ab9627dd30252246f78f48144a01e524c 2018-04-25 20:51:12 +0000cd544c579e1b8dd3405333d72763477ac77d7d57This is the first part of a two-part change. I am updating plotgen plots soeditstats_clubb_utilities.F90editadvance_clubb_core_module.F90editstats_variables.F90editstats_zm_module.F90pdf_closure_module.F90stats_clubb_utilities.F90stats_zm_module.F90stats_variables.F90advance_clubb_core_module.F90stats_zt_module.F9059d3974bbca99650fa4ed55e6572ba5664b732e71524715962000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduIn part 2 of this two part commit, I have added rc_coef to the list of statistical output variables on thermodynamic levels. This will allow plots of the contribution of cloud water to wp2thvp. Since this adds new statistics, this commit is BIT_CHANGING. CLUBB Trac ticket reference:clubb:ticket:824. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8642 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 85cb66d509812298fdc043933fb1c2ee2bf9eadc 2018-04-26 04:12:42 +000059d3974bbca99650fa4ed55e6572ba5664b732e7In part 2 of this two part commit, I have added rc_coef to the list ofeditpdf_closure_module.F90editstats_clubb_utilities.F90editstats_zm_module.F90editstats_variables.F90editadvance_clubb_core_module.F90editstats_zt_module.F90advance_wp2_wp3_module.F90gmres_wrap.F90advance_clubb_core_module.F90numerical_check.F90a53242d5e14b0d2cdc77956a1b7dc25ba0bee2171524785741000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduVarious debug checks added/improved. Negative value checks changed back to throw fatal errors. Parameterization check changes to disclude thermodynamic variables at grid level 1 clubb:ticket:800 git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8645 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: ea6c90ebb091e0edaa253a485bcb0fe74b04e9a2 2018-04-26 23:35:41 +0000a53242d5e14b0d2cdc77956a1b7dc25ba0bee217Various debug checks added/improved. Negative value checks changed back to throw fatal errors. Parameterization check changes to disclude thermodynamic variables at grid level 1 clubb:ticket:800editnumerical_check.F90editadvance_clubb_core_module.F90editgmres_wrap.F90editadvance_wp2_wp3_module.F90numerical_check.F90534a0c72de8873a5009bf671530b47f0d49206f91524870541000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduCheck negative no longer assumes array sizes are gr%nz, this should fix the SAM-CLUBB-SILHS error in the nightly tests clubb:ticket:800 git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8648 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: c5367d31f8d14bf63fe8db9d739ce3556d199437 2018-04-27 23:09:01 +0000534a0c72de8873a5009bf671530b47f0d49206f9Check negative no longer assumes array sizes are gr%nz, this should fix the SAM-CLUBB-SILHS error in the nightly tests clubb:ticket:800editnumerical_check.F90numerical_check.F905c4a849bdb5f53fcf9dfc89fd033336c1efbfc8d1525220380000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduI'm pretty sure this will fix the check negative issues this time, fortran has some lacking features when it comes to arrays clubb:ticket:800 git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8650 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 9e6bfd050584076696a51885cd3617afab1240f2 2018-05-02 00:19:40 +00005c4a849bdb5f53fcf9dfc89fd033336c1efbfc8dI'm pretty sure this will fix the check negative issues this time, fortran has some lacking features when it comes to arrays clubb:ticket:800editnumerical_check.F90advance_clubb_core_module.F905594fe9e9fbe5678de31813cee26b5cb9335667e1525220543000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduChanged calls to parameterization check to work with the new check negative implementation clubb:ticket:800 git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8651 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: ecec6a8815e819b2b51add31db0d3f4995a02a81 2018-05-02 00:22:23 +00005594fe9e9fbe5678de31813cee26b5cb9335667eChanged calls to parameterization check to work with the new check negative implementation clubb:ticket:800editadvance_clubb_core_module.F90advance_clubb_core_module.F900838560e573a27fecf5357fc654ad1e0d3097e6e1525220627000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.edu git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8652 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: b5b67470d5464025531cc981f1b4cd8906fc5450 2018-05-02 00:23:47 +00000838560e573a27fecf5357fc654ad1e0d3097e6eeditadvance_clubb_core_module.F90advance_clubb_core_module.F90710b86bb2771a3ea99f8f49d70eee9f0d7a9fa981525288786000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduRemoved rtm(5) = -1 line, it was a test accidentally left in and caused many nightly tests to fail clubb:ticket:800 git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8653 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 3bb388ad7e3f6068c8a15c50cb53ff038dd98d1f 2018-05-02 19:19:46 +0000710b86bb2771a3ea99f8f49d70eee9f0d7a9fa98Removed rtm(5) = -1 line, it was a test accidentally left in and caused many nightly tests to fail clubb:ticket:800editadvance_clubb_core_module.F90advance_wp2_wp3_module.F90mixing_length.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90numerical_check.F90pdf_closure_module.F90advance_windm_edsclrm_module.F90surface_varnce_module.F90mono_flux_limiter.F907819819232585aa60a22328a59ee1678e1a692f21525383794000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduChanged error checking if statements to check for equality to clubb_fatal_error rather than inequality to clubb_no_error, makes them more readable clubb:ticket:800 git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8656 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: e7594b96ec54ad94de28f8ba06d5508ffcbbfd66 2018-05-03 21:43:14 +00007819819232585aa60a22328a59ee1678e1a692f2Changed error checking if statements to check for equality to clubb_fatal_error rather than inequality to clubb_no_error, makes them more readable clubb:ticket:800editmono_flux_limiter.F90editadvance_windm_edsclrm_module.F90editadvance_xm_wpxp_module.F90editpdf_closure_module.F90editadvance_wp2_wp3_module.F90editsurface_varnce_module.F90editnumerical_check.F90editadvance_clubb_core_module.F90editmixing_length.F90editadvance_xp2_xpyp_module.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90advance_xm_wpxp_module.F90lapack_wrap.F9013831ab3cc6c757038004f5404bb16b6e601d99f1525386155000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixed unused variable warnings related to error code changes git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8657 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 178198f65006fe50b1b5f18b7178987d2d1a3c0b 2018-05-03 22:22:35 +000013831ab3cc6c757038004f5404bb16b6e601d99fFixed unused variable warnings related to error code changeseditadvance_wp2_wp3_module.F90editlapack_wrap.F90editadvance_xm_wpxp_module.F90editadvance_xp2_xpyp_module.F90pdf_closure_module.F90df6f4296f21568086b513f923063d7df9a3aced31525476958000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am generalizing the wprcp, wp2rcp, rtprcp, and thlprcp equations to account for the PDF component correlation of w and rt and the PDF component correlation of w and theta-l. In regards to the PDF transformation, this accounts for the PDF component correlation of w and chi and the PDF component correlation of w and eta. For the default ADG1 code, the plotgen results overlap for all cases except for the most sensitive ones -- ARM 97, TWP-ICE, and MC3E. For ADG1, the calculations are mathematically the same, but numerical roundoff errors account for any changes, making this commit BIT_CHANGING. CLUBB Trac ticket references: clubb:ticket:777 and clubb:ticket:806. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8659 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: a7259659c0a879df9d5e32bd2d3087328bb0304a 2018-05-04 23:35:58 +0000df6f4296f21568086b513f923063d7df9a3aced3I am generalizing the wprcp, wp2rcp, rtprcp, and thlprcp equations to accounteditpdf_closure_module.F90advance_clubb_core_module.F90error_code.F908da2c418b38a9dcfed11d90ee4d963a6c7c727261525715833000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdded error header functionality. Using the err_header character array from error_code in a write statment will print out either the thread number or process ID along with CLUBB -- ERROR: . This is mainly to keep track of error messages is multithreaded scenarios clubb:ticket:800 git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8660 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 1f3a5d4af18e3ebf53f8b821e413b69d5f1f3381 2018-05-07 17:57:13 +00008da2c418b38a9dcfed11d90ee4d963a6c7c72726Added error header functionality. Using the err_header character array from error_code in a write statment will print out either the thread number or process ID along with CLUBB -- ERROR: . This is mainly to keep track of error messages is multithreaded scenarios clubb:ticket:800editerror_code.F90editadvance_clubb_core_module.F90pdf_closure_module.F900ac6d77e9e485ba1860339e34ee86c2dcabd51371525809195000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduIn r8659, I accidentally overwrote some code. This commit restores the prior version. CLUBB Trac ticket reference: clubb:ticket:800. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8661 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: a67cb39ea413c949b2a3432fd5a4d67517d58c0e 2018-05-08 19:53:15 +00000ac6d77e9e485ba1860339e34ee86c2dcabd5137In r8659, I accidentally overwrote some code. This commit restores the prioreditpdf_closure_module.F90pdf_closure_module.F907d6bf061c7354f5a1bf4d48df53aef4d63158ef41525809252000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduSigh git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8662 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 5e94a485df2a451e08b95d4e83532855d4941de1 2018-05-08 19:54:12 +00007d6bf061c7354f5a1bf4d48df53aef4d63158ef4Sigheditpdf_closure_module.F90advance_wp2_wp3_module.F90mixing_length.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90advance_windm_edsclrm_module.F90surface_varnce_module.F90mono_flux_limiter.F900a5bae799b090651a0fbaec135c784eb1e43af791525983695000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdded clubb debug level checks to error checking statements clubb:ticket:800 git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8664 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: d913e4e936096a1222f3571a31802d39f8029f0b 2018-05-10 20:21:35 +00000a5bae799b090651a0fbaec135c784eb1e43af79Added clubb debug level checks to error checking statements clubb:ticket:800editadvance_clubb_core_module.F90editadvance_windm_edsclrm_module.F90editadvance_xm_wpxp_module.F90editadvance_xp2_xpyp_module.F90editadvance_wp2_wp3_module.F90editmono_flux_limiter.F90editmixing_length.F90editsurface_varnce_module.F90precipitation_fraction.F90advance_clubb_core_module.F90clubb_api_module.F90output_netcdf.F90csr_matrix_module.F90stats_clubb_utilities.F90pdf_parameter_module.F90grid_class.F90setup_clubb_pdf_params.F908dd2efb7b881a9decacf6ab60b8cd4595fb795d61526086676000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduChanged many stop commands to return commands and added more err_code checks clubb:ticket:800 git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8665 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 4e6f274e0940c80fd0fdac7c7887f8b6138beeb2 2018-05-12 00:57:56 +00008dd2efb7b881a9decacf6ab60b8cd4595fb795d6Changed many stop commands to return commands and added more err_code checks clubb:ticket:800editadvance_clubb_core_module.F90editstats_clubb_utilities.F90editpdf_parameter_module.F90editclubb_api_module.F90editgrid_class.F90editsetup_clubb_pdf_params.F90editprecipitation_fraction.F90editcsr_matrix_module.F90editoutput_netcdf.F90clubb_api_module.F90931223883ea8311dd6b46251763db82296b8f6171526427162000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduReverted api changes that broke SAM and WRF git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8669 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 5cb5ad6b721ddb72d4c4261a5c538f769b31f4c8 2018-05-15 23:32:42 +0000931223883ea8311dd6b46251763db82296b8f617Reverted api changes that broke SAM and WRFeditclubb_api_module.F90new_pdf.F90new_pdf_main.F909fb1e0ea6977aab5c009b67ff7f2d6a3542974791526933960000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am adding the semi-implicit formulation of wprtpthlp, which is the turbulent advection term in the rtpthlp predictive equation. This form is specific to the new PDF. CLUBB Trac ticket reference: clubb:ticket:777. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8674 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 3ee9e6dc10b2a96e93f73731abc0e689e4f5285d 2018-05-21 20:19:20 +00009fb1e0ea6977aab5c009b67ff7f2d6a354297479I am adding the semi-implicit formulation of wprtpthlp, which is the turbulenteditnew_pdf.F90editnew_pdf_main.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90stats_variables.F90stats_zm_module.F90advance_xm_wpxp_module.F90stats_zt_module.F903edb1f2cd144c0c6f10c9db65c8e899beafaff201527015165000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am adding output statistics for the implicit and semi-implicit coefficients and terms that are used for wp4, wprtp2, wpthlp2, wp2rtp, wp2thlp, and wprtpthlp in the CLUBB predictive equation set. When the ADG1 PDF is used or when turbulent advection is handled explicitly, a value of 0 is simply output for these fields. However, new fields are now added to the *_zt and *_zm statistical output files, making this change BIT_CHANGING. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8678 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: aa2d2842b3845f5fa9ee66237db4e1fc18d65cc1 2018-05-22 18:52:45 +00003edb1f2cd144c0c6f10c9db65c8e899beafaff20I am adding output statistics for the implicit and semi-implicit coefficientseditstats_variables.F90editadvance_wp2_wp3_module.F90editadvance_xm_wpxp_module.F90editstats_zt_module.F90editadvance_xp2_xpyp_module.F90editstats_zm_module.F90new_pdf.F90new_pdf_main.F90a9341697c80d2668d3079c9ae142e1a2ebd70b431527015385000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI corrected the units on a couple of implicit coefficients. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8679 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: cf7e5004ede5dd3c7bdcd925f3cb200af658b317 2018-05-22 18:56:25 +0000a9341697c80d2668d3079c9ae142e1a2ebd70b43I corrected the units on a couple of implicit coefficients.editnew_pdf.F90editnew_pdf_main.F90advance_xm_wpxp_module.F90ce15cc8f9aae4e22a3bddf4992f02f34d723cbd11527204952000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI fixed a bug. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8685 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: ec7f561c61f350ab4ec77e9c5953584ae8c3a2ad 2018-05-24 23:35:52 +0000ce15cc8f9aae4e22a3bddf4992f02f34d723cbd1I fixed a bug.editadvance_xm_wpxp_module.F90advance_wp2_wp3_module.F90interpolation.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90lapack_wrap.F9082b8e1b410e1f524cb976f0261acb1b6e199af761527210440000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduRemoved failure_test cases from input/case_setups, they neither work properly nor are needed anymore. Added test_fatal_error_handling.bash script which tests for various errors defined by an identifier in the code, more description available in the bash file. Also added more descriptive error output to some parts of code. This change focuses only on output and comments and is BIT IDENTICAL clubb:ticket:800 git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8688 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 91ac88eb9164cd49ca80fc713029c1bd4b6ff40e 2018-05-25 01:07:20 +000082b8e1b410e1f524cb976f0261acb1b6e199af76Removed failure_test cases from input/case_setups, they neither work properly nor are needed anymore. Added test_fatal_error_handling.bash script which tests for various errors defined by an identifier in the code, more description available in the bash file. Also added more descriptive error output to some parts of code. This change focuses only on output and comments and is BIT IDENTICAL clubb:ticket:800editinterpolation.F90editadvance_xm_wpxp_module.F90editlapack_wrap.F90editadvance_clubb_core_module.F90editadvance_wp2_wp3_module.F90advance_xm_wpxp_module.F905a5297f9ab35944a45cf8b8e9391c0a861b3905f1527294838000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduRemoved reference to run_type 'failure_test' as it no longer exists. Added more description to fatal errors produced by calls to xm_wpxp_solve. This change is BIT IDENTICAL clubb:ticket:800 git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8690 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 23cc4aa2bc4aa6c27d508bad874a6818b4e9f158 2018-05-26 00:33:58 +00005a5297f9ab35944a45cf8b8e9391c0a861b3905fRemoved reference to run_type 'failure_test' as it no longer exists. Added more description to fatal errors produced by calls to xm_wpxp_solve. This change is BIT IDENTICAL clubb:ticket:800editadvance_xm_wpxp_module.F90stats_clubb_utilities.F909ceaa37d3cc78dbf56569a7d4a08768352d0b01e1527790022000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am fixing a bug with the CLUBB tuner. Variables that were allocated at the start of each CLUBB run were not being deallocated, causing the tuner to crash. I also made some of the code a little bit more easily readable. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8695 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 3bce461a95c155074c37ddaf67a359722684b032 2018-05-31 18:07:02 +00009ceaa37d3cc78dbf56569a7d4a08768352d0b01eI am fixing a bug with the CLUBB tuner. Variables that were allocated at theeditstats_clubb_utilities.F90advance_wp2_wp3_module.F90Skx_module.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90numerical_check.F907a2fad444aefaa42626b4f4f1ba874ad6a9ac9341527792428000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduCompleted the list of variables that get reported from errors within advance_wp2_wp3 and advance_xm_wpxp. Also added a check that outputs an error message when T_in_K is less than 200K in the lowest 10 grid levels, this check is done in subroutine parameterization_check. clubb:ticket:800 git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8697 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 53e78bde17cf1e7916cffca0c52828aea6a78804 2018-05-31 18:47:08 +00007a2fad444aefaa42626b4f4f1ba874ad6a9ac934Completed the list of variables that get reported from errors within advance_wp2_wp3 and advance_xm_wpxp. Also added a check that outputs an error message when T_in_K is less than 200K in the lowest 10 grid levels, this check is done in subroutine parameterization_check. clubb:ticket:800editnumerical_check.F90editSkx_module.F90editadvance_xm_wpxp_module.F90editadvance_wp2_wp3_module.F90editadvance_clubb_core_module.F90fill_holes.F90advance_clubb_core_module.F90numerical_check.F90e5907f835fe697746c161b04ef63ddf67c834a4f1528225011000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMade all debug levels produce the same output, see clubb:ticket:823 git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8700 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: e0155881872223e0415c76a109ea31b51a221779 2018-06-05 18:56:51 +0000e5907f835fe697746c161b04ef63ddf67c834a4fMade all debug levels produce the same output, see clubb:ticket:823editnumerical_check.F90editfill_holes.F90editadvance_clubb_core_module.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90pdf_closure_module.F90pdf_parameter_module.F90new_pdf_main.F90ac9622bf0cc09cc316434886e129bb7314d08a111528401879000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am moving type variable implicit_coefs_terms from new_pdf_main.F90 to pdf_parameter_module.F90. The goal is to use this type variable for all PDF types, not just for the new PDF. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8702 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: e2a336674b0425021f90e328156effd55497e67b 2018-06-07 20:04:39 +0000ac9622bf0cc09cc316434886e129bb7314d08a11I am moving type variable implicit_coefs_terms from new_pdf_main.F90 toeditadvance_wp2_wp3_module.F90editpdf_closure_module.F90editnew_pdf_main.F90editadvance_xm_wpxp_module.F90editadvance_clubb_core_module.F90editadvance_xp2_xpyp_module.F90editpdf_parameter_module.F90parameters_tunable.F907d18837476666806239c9825cf4b67e6f9a23c181529024997000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduModified many aspects of the tuner, mostly within esa_driver. Also added check to ensure that C7 and C11 have valid values before the run is tried, this should stop the fire tuning nightly test from crashing. See clubb:ticket:802 git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8705 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 9cedfb7d28f1ed37f746348dbb9082075ebe26ce 2018-06-15 01:09:57 +00007d18837476666806239c9825cf4b67e6f9a23c18Modified many aspects of the tuner, mostly within esa_driver. Also added check to ensure that C7 and C11 have valid values before the run is tried, this should stop the fire tuning nightly test from crashing. See clubb:ticket:802editparameters_tunable.F90parameters_tunable.F90eabe48e0df1cdb0f1e235c23a9078a4afac1d17e1529121760000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdded checks in subroutine setup_parameters() to ensure that C7b and C11b are within [0:1] see clubb:ticket:802 git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8706 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 02a68858d0eb8c5ae738be483dd9ff80835de531 2018-06-16 04:02:40 +0000eabe48e0df1cdb0f1e235c23a9078a4afac1d17eAdded checks in subroutine setup_parameters() to ensure that C7b and C11b are within [0:1] see clubb:ticket:802editparameters_tunable.F90numerical_check.F90f8e787b9279acee257f8f5239f4d59565a1a31b01529122288000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduThis should fix the thlm out of bounds error on clubb:ticket:828 git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8707 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: b66209934392d16efc4dc1e3787cb8e0301f1dd1 2018-06-16 04:11:28 +0000f8e787b9279acee257f8f5239f4d59565a1a31b0This should fix the thlm out of bounds error on clubb:ticket:828editnumerical_check.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90pdf_closure_module.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90new_pdf_main.F9059dd7cde986a3b07374d847937800451514f23781529347561000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI changed the name of type variable new_pdf_implct_coefs_terms to pdf_implicit_coefs_terms in order to help generalize this variable for use with any type of PDF. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8708 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 06cc2f631557b8f9b584c2260843ca3aef8d1a61 2018-06-18 18:46:01 +000059dd7cde986a3b07374d847937800451514f2378I changed the name of type variable new_pdf_implct_coefs_terms toeditadvance_xp2_xpyp_module.F90editadvance_wp2_wp3_module.F90editadvance_clubb_core_module.F90editadvance_xm_wpxp_module.F90editnew_pdf_main.F90editpdf_closure_module.F90numerical_check.F903a824d458cbfb497e1b920ed3f9b1128924210f61529359496000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduChanged T_in_K check within subroutine parameterization_check to instead check thlm, see clubb:ticket:800 and clubb:ticket:828 git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8709 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: f413987ba6cb3288915c9ee945dbb23ca7ca13e4 2018-06-18 22:04:56 +00003a824d458cbfb497e1b920ed3f9b1128924210f6Changed T_in_K check within subroutine parameterization_check to instead check thlm, see clubb:ticket:800 and clubb:ticket:828editnumerical_check.F90advance_xp2_xpyp_module.F90b1accae6cdf52d3613804d3e868dd2f2259ae9d81529937463000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added a flag option to clip the (large, negative) effects of microphysics on rtp2 and thlp2. Right now, this flag is turned off by default, so the results remain the same. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8712 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 56dcb3ae49ea059027553d6236b35374df61ab73 2018-06-25 14:37:43 +0000b1accae6cdf52d3613804d3e868dd2f2259ae9d8I added a flag option to clip the (large, negative) effects of microphysics oneditadvance_xp2_xpyp_module.F90advance_xp2_xpyp_module.F90clip_explicit.F90313ad512a4c8fdc9f1e171ebb05a4ecf01b749d41529947245000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added a flag option to calculate the minimum threshold for xp2 (rtp2 and thlp2) based on maintaining an overall correlation of w and x that falls between -max_mag_correlation and max_mag_correlation. Right now, this flag is turned off by default, so the results remain the same. CLUBB Trac ticket reference: clubb:ticket:822. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8713 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 827263c713117eec5b4f415f3fab91e7aacd751e 2018-06-25 17:20:45 +0000313ad512a4c8fdc9f1e171ebb05a4ecf01b749d4I added a flag option to calculate the minimum threshold for xp2 (rtp2 andeditadvance_xp2_xpyp_module.F90editclip_explicit.F90clip_explicit.F90advance_xp2_xpyp_module.F90constants_clubb.F90f41025c81a0ff30e00667a02e0060a989d745acc1530036019000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added a special max magnitude correlation for fluxes wprtp and wpthlp. This variable is called max_mag_correlation_flux and it is set to 0.99 by default (the same value as max_mag_correlation) so results remain the same for now. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8714 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 820d0ca1cfb24d472ea0df14d9773a300f7838ca 2018-06-26 18:00:19 +0000f41025c81a0ff30e00667a02e0060a989d745accI added a special max magnitude correlation for fluxes wprtp and wpthlp. Thiseditclip_explicit.F90editadvance_xp2_xpyp_module.F90editconstants_clubb.F90parameters_tunable.F9075959a494104447dc36320e08168100f868558dc1530242220000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMade better esa_driver, made tuner_test to test the driver, added variable range checks. Tried to make the tuner in better in general, but that whole bunch of code needs nothing short of replacement. This commit is bit identical execpt for tuning results, see clubb:ticket:802 for a bunch more information git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8716 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: cb3732ec186d149883164709deaead448d995038 2018-06-29 03:17:00 +000075959a494104447dc36320e08168100f868558dcMade better esa_driver, made tuner_test to test the driver, added variable range checks. Tried to make the tuner in better in general, but that whole bunch of code needs nothing short of replacement. This commit is bit identical execpt for tuning results, see clubb:ticket:802 for a bunch more informationeditparameters_tunable.F90parameters_tunable.F90advance_wp2_wp3_module.F90constants_clubb.F90e3d58ba763369692018fa4a1140ad436623b48401530559519000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduThis commit sets C8b=0.02, changes the non-linear damping on wp3 from Skw^4 to Skw^2, sets C11b=C11, and relaxes Skw_max_mag to 10. These changes are designed to reduce the clipping on wp3 (although the clipping is not eliminated), and to allow greater skewness in cumulus cases without altering the stratocumulus cases. This offers opportunities to increase the contrast between shallow cumulus and stratocumulus in global simulations. This commit is BIT_CHANGING. For clubb:ticket:817. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8719 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: c3b9f880a412da4e3b527cba7a587fdce2c14e3e 2018-07-02 19:25:19 +0000e3d58ba763369692018fa4a1140ad436623b4840This commit sets C8b=0.02, changes the non-linear damping on wp3editconstants_clubb.F90editparameters_tunable.F90editadvance_wp2_wp3_module.F90advance_wp2_wp3_module.F90model_flags.F90parameter_indices.F90clip_explicit.F90constants_clubb.F90Skx_module.F90parameters_tunable.F90parameters_model.F9010a9678f87e1c19f9d20482b6d9e8b9bb86057fa1530836881000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdded a flag and moved Skw_max_mag from constants to parameters, this allows the changes made in commit clubb:r8719 to be reverted by modifying the configuration flags and the tunable parameters list, see clubb:ticket:829 git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8722 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 4a4f3e30a724310cb2342bcd8f99792e63e7922c 2018-07-06 00:28:01 +000010a9678f87e1c19f9d20482b6d9e8b9bb86057faAdded a flag and moved Skw_max_mag from constants to parameters, this allows the changes made in commit clubb:r8719 to be reverted by modifying the configuration flags and the tunable parameters list, see clubb:ticket:829editclip_explicit.F90editadvance_wp2_wp3_module.F90editmodel_flags.F90editparameters_tunable.F90editparameter_indices.F90editconstants_clubb.F90editparameters_model.F90editSkx_module.F90turbulent_adv_pdf.F90cee383b89783f8dba35ea28b766ec787f08691d41530917037000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am adding a general purpose function for the turbulent advection of CLUBB's predictive variances and covariances. This is for the momentum-level predictive fields that handle turbulent advection by integrating over the PDF. Regardless of PDF type, all of these turbulent advection terms can be written in the following form: d<x'y'>/dt = - (1/rho_ds) * d( rho_ds * <w'x'y'> ) / dz; where <w'x'y'> = coef_wpxpyp_implicit * <x'y'> + term_wpxpyp_explicit. This allows for one set of turbulent advection functions that can be reused for multiple variables, for any PDF type, and even for the explicit turbulent advection option. This allows for a much simpler flow of coding, and also has the perk of expanding the "upwind" turbulent advection option to other PDF types (besides ADG1), without adding a whole bunch of specialty functions. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8724 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: dd55be7bcda2c95e11dc19ca4b00a5ed5b07e013 2018-07-06 22:43:57 +0000cee383b89783f8dba35ea28b766ec787f08691d4I am adding a general purpose function for the turbulent advection of CLUBB'saddturbulent_adv_pdf.F90turbulent_adv_pdf.F908229ba9d74d876bcc0698e1ac0e67d554ccee4481530917910000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added/changed a couple comments for the rhs portion of the generalized turbulent advection functions. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8725 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 205652eccb7a8134e56139076588faf4264b0496 2018-07-06 22:58:30 +00008229ba9d74d876bcc0698e1ac0e67d554ccee448I added/changed a couple comments for the rhs portion of the generalizededitturbulent_adv_pdf.F90turbulent_adv_pdf.F90203d7900ea874e5b24af54b97f8d130f72c9ef251531162423000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduThe turbulent advection file that handles turbulent advection for predictive variances and covariances (where turbulent advection is handled by integrating over the PDF) is now set! Functions that handled the LHS (implicit component) and RHS (explicit component) of the turbulent advection term are ready to go! git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8726 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 3894e413ee48034e5a8a75a0f6e49d66d9f9cccf 2018-07-09 18:53:43 +0000203d7900ea874e5b24af54b97f8d130f72c9ef25The turbulent advection file that handles turbulent advection for predictiveeditturbulent_adv_pdf.F90turbulent_adv_pdf.F9074d40e391a81f2ec1ca1d71ac5f93ccbff5278411531262935000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added a function to turbulent_adv_pdf.F90, called sgn_turbulent_velocity, that calculates the turbulent velocity for a predictive variance or covariance for use with the "upwind" turbulent advection option. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8728 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 0fa11b05c00ca08cd1373f15bc8d36f908a2556e 2018-07-10 22:48:55 +000074d40e391a81f2ec1ca1d71ac5f93ccbff527841I added a function to turbulent_adv_pdf.F90, called sgn_turbulent_velocity, thateditturbulent_adv_pdf.F90turbulent_adv_pdf.F9094d2e20139114e5f5009ea286ceccc775534f51d1531263209000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduWhoops, I forgot to make wpxpyp_zm and xpyp intent (in). git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8729 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 00b12f393cc3fd434006faebdbcbf052f1c7d792 2018-07-10 22:53:29 +000094d2e20139114e5f5009ea286ceccc775534f51dWhoops, I forgot to make wpxpyp_zm and xpyp intent (in).editturbulent_adv_pdf.F90array_index.F90clubb_api_module.F90corr_varnce_module.F9067dcf4b14d66f7d4c55095c2d6fd2e63575488511531451904000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdded functionality to make the hydrometeor variances depend on the horizontal grid spacing, see clubb:ticket:830 git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8730 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: e9089dce7bcad2b4b235a03d128216f633136f0f 2018-07-13 03:18:24 +000067dcf4b14d66f7d4c55095c2d6fd2e6357548851Added functionality to make the hydrometeor variances depend on the horizontal grid spacing, see clubb:ticket:830editarray_index.F90editcorr_varnce_module.F90editclubb_api_module.F90advance_xp2_xpyp_module.F906fcdeeeda0f1708e9af2d38d3a47fbc7598b06ad1531457694000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am updating the code that advances predictive variances and covariances in advance_xp2_xpyp_module.F90 to use one set of turbulent advection functions for all turbulent advection options (explicit or implicit/semi-implicit based on PDF type, as well as centered or "upwind" discretization"). Along the way, I discovered that the current ADG1 implementation, which is supposed to be using "upwind" discretization, is only using "upwind" discretization for the implicit component of the turbulent advection term, while using centered discretization for the explicit (RHS) component of the turbulent advection term. An "upwind" discretization for the explicit component was never added to the code. I assumed this was an oversight, and an "upwind" discretization for the explicit component of the turbulent advection term was added as part of the new code for this project (in a prior commit). Both implicit and explicit components now use either centered discretization or "upwind" discretization consistently. Owing to the RHS discretization correct, as well owing to a different order of calculations, this commit is BIT_CHANGING. However, plots of all cases show that the previous revision and the current revision overlap for most cases. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8731 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: fdba5b894298fe351486792a92a521586dc1d9b7 2018-07-13 04:54:54 +00006fcdeeeda0f1708e9af2d38d3a47fbc7598b06adI am updating the code that advances predictive variances and covariances ineditadvance_xp2_xpyp_module.F90clubb_api_module.F90fb8065e129f7e8ea2ba43d10446efafc265554941531767879000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduRenamed init_pdf_hydromet_arrays to init_pdf_hydromet_arrays_api since it is meant to be used by host models, clubb:ticket:830 git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8733 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: fbc3b6719ef6a8a5d8f4f728c77ca6aeac8886d4 2018-07-16 19:04:39 +0000fb8065e129f7e8ea2ba43d10446efafc26555494Renamed init_pdf_hydromet_arrays to init_pdf_hydromet_arrays_api since it is meant to be used by host models, clubb:ticket:830editclubb_api_module.F90advance_xm_wpxp_module.F900249e99c6cd889bb8537572f8e1d83fc21a915e51531947642000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am updating the code that advances predictive scalar fluxes (<w'x'>) in advance_xm_wpxp_module.F90 to use one set of turbulent advection functions for all turbulent advection options (explicit or implicit/semi-implicit based on PDF type, as well as centered or "upwind" discretization). For the default ADG1 PDF, the calculations are mathematically the same. However, they occur in a different order in the new code. This makes this revision BIT_CHANGING. However, plots of all cases show that the previous revision and the current revision overlap for most cases. Only the most sensitive cases show differences on the plots. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8735 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: ef271ff2d4a0fb4b7ca7fdfbaba3a3d2f6cac016 2018-07-18 21:00:42 +00000249e99c6cd889bb8537572f8e1d83fc21a915e5I am updating the code that advances predictive scalar fluxes (<w'x'>) ineditadvance_xm_wpxp_module.F90fill_holes.F9084eb73b8d08f9bc2b3d2d3941bbc7c197b6710931531955549000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduAs a first step toward having code that can clip mean values of hydrometeor concentrations or SILHS sample point values of hydrometeor concentrations, I have made a new subroutine out of the code that clips hydrometeor concentrations. It is not yet interfaced and I haven't deleted the old code yet. CLUBB Trac ticket reference: clubb:ticket:833. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8736 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 7f535b468ffcb92bbded378a263a9d3ffa2bd736 2018-07-18 23:12:29 +000084eb73b8d08f9bc2b3d2d3941bbc7c197b671093As a first step toward having code that can clip mean values of hydrometeoreditfill_holes.F90clubb_api_module.F900a518f3553cb13ad37bf5410f6d638d2ea79f2db1531963960000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduinit_pdf_hydromet_arrays_api now sets the value of hydromet_dim as well, this should fix the wrf tests, but doesn't seem to fix cam. clubb:ticket:830 other:ticket:562 git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8737 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 28016716b08941d7e9ed1b1055b40300eb842b9f 2018-07-19 01:32:40 +00000a518f3553cb13ad37bf5410f6d638d2ea79f2dbinit_pdf_hydromet_arrays_api now sets the value of hydromet_dim as well, this should fix the wrf tests, but doesn't seem to fix cam. clubb:ticket:830 other:ticket:562editclubb_api_module.F90fill_holes.F9089000415c991e9c188c91e11fa80184e507d965f1532030333000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI have now interfaced the subroutine that I made out of the code that clips hydrometeor concentrations with the rest of CLUBB, in place of the old code. The results in GrADS output files from this revision are an exact match to the results in GrADS output files from the previous revision for all cases. CLUBB Trac ticket reference: clubb:ticket:833. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8738 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 1935918c4825f5c4b7b5bed91355b19954edd555 2018-07-19 19:58:53 +000089000415c991e9c188c91e11fa80184e507d965fI have now interfaced the subroutine that I made out of the code that clipseditfill_holes.F90advance_wp2_wp3_module.F90advance_clubb_core_module.F90e31aae7b02811fb9034da4e9e0f97f29603e2a2d1532495361000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added new code that clips the overall correlation of w and rt or the overall correlation of w and theta-l by increasing wp2 (after advancing wp2) when one of the aforementioned correlations is outside of the range that they're supposed to be in. This code is controlled by a flag, which is turned off by default. The results in GrADS files from this revision are an exact match to the results in GrADS output files from the previous revision for all cases. CLUBB Trac ticket reference: clubb:ticket:835. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8740 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 6fc699c3a4be0c178ba1e7e05b3571bf218f5367 2018-07-25 05:09:21 +0000e31aae7b02811fb9034da4e9e0f97f29603e2a2dI added new code that clips the overall correlation of w and rt or the overalleditadvance_wp2_wp3_module.F90editadvance_clubb_core_module.F90stats_variables.F90advance_xp2_xpyp_module.F90stats_zt_module.F90d4e0f942e2c4fea13259aea59151e689111d4eb81532554503000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added stats for term_wprtp2_explicit and term_wpthlp2_explicit, which are part of the semi-implicit turbulent advection term for rtp2 and thlp2, respectively. This is used for ADG1 and for the explicit turbulent advection option. Since new stats are being added, this revision is BIT_CHANGING. However, this is only for *_zt stats files. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8741 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: f8c7a58900f887917c29446fb79f7af1df9ac777 2018-07-25 21:35:03 +0000d4e0f942e2c4fea13259aea59151e689111d4eb8I added stats for term_wprtp2_explicit and term_wpthlp2_explicit, which areeditstats_variables.F90editstats_zt_module.F90editadvance_xp2_xpyp_module.F90advance_windm_edsclrm_module.F90clubb_api_module.F909216aa9dddfd6115909e238aa44fc3b70ced37731532572197000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMade clubb_fatal_error public so host model code can detect fatal errors. clubb:ticket:800 git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8742 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 41e97fd33df9189dcbd8401090b1b6fb9cbfd198 2018-07-26 02:29:57 +00009216aa9dddfd6115909e238aa44fc3b70ced3773Made clubb_fatal_error public so host model code can detect fatal errors. clubb:ticket:800editadvance_windm_edsclrm_module.F90editclubb_api_module.F90advance_windm_edsclrm_module.F90dd55be4737a50a6033e606883382a7085f9b1c261532572383000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduReverted advance_windm_edsclrm_module.F90, accidentally committed test code, clubb:ticket:800 git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8743 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: e89c92fd0f27d2c264c4bdd7cfd54d564d639ceb 2018-07-26 02:33:03 +0000dd55be4737a50a6033e606883382a7085f9b1c26Reverted advance_windm_edsclrm_module.F90, accidentally committed test code, clubb:ticket:800editadvance_windm_edsclrm_module.F90clubb_api_module.F90095ae79bf0437ae71cade1390af663fa0ee5f1b61532626737000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixed nightly tests git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8744 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: ce40ceb7330f98de907410203e620c04fac4f7e9 2018-07-26 17:38:57 +0000095ae79bf0437ae71cade1390af663fa0ee5f1b6Fixed nightly testseditclubb_api_module.F90advance_wp2_wp3_module.F90advance_clubb_core_module.F90advance_xp2_xpyp_module.F905a2c7c73d6490d53ab9a3c7930c37c52d52904e81532726843000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI have added code to allow C2 to be adjusted by multiplying by the greater of cloud fraction or a small constant. This code is turned off by default. The results in GrADS output files from this revision are an exact match to the results in GrADS output files from the previous revision for all cases. CLUBB Trac ticket reference: clubb:ticket:836. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8746 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 0b346735398eebf6d3aa78a2aade0277168bb964 2018-07-27 21:27:23 +00005a2c7c73d6490d53ab9a3c7930c37c52d52904e8I have added code to allow C2 to be adjusted by multiplying by the greater ofeditadvance_wp2_wp3_module.F90editadvance_xp2_xpyp_module.F90editadvance_clubb_core_module.F90advance_wp2_wp3_module.F90model_flags.F90advance_xp2_xpyp_module.F906c918c0f09f47468a92d2893276ae667b0fa5c631532820384000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI moved the location of the declaration and setting of new model flags to model_flags.F90 so that they could be read in through the configurable model flags namelist. CLUBB Trac ticket references: clubb:ticket:835 and clubb:ticket:836. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8747 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: c7148d45f984e40bf473959504068e851c565edc 2018-07-28 23:26:24 +00006c918c0f09f47468a92d2893276ae667b0fa5c63I moved the location of the declaration and setting of new model flags toeditmodel_flags.F90editadvance_wp2_wp3_module.F90editadvance_xp2_xpyp_module.F90advance_windm_edsclrm_module.F90diffusion.F9041c69abbeda07301f40a459338d56333b541b8b61533077694000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduImproved computational speed of windm_edsclrm_rhs and added subroutine. This commit should be BIT_CHANGING as it does calculations in different orders. Only the most sensitive cases have any noticable plot differences. See clubb:ticket:834 git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8751 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 560390daf8556a0a5f94f8887d4e8fa470dcb8a7 2018-07-31 22:54:54 +000041c69abbeda07301f40a459338d56333b541b8b6Improved computational speed of windm_edsclrm_rhs and added subroutine. This commit should be BIT_CHANGING as it does calculations in different orders. Only the most sensitive cases have any noticable plot differences. See clubb:ticket:834editadvance_windm_edsclrm_module.F90editdiffusion.F90advance_windm_edsclrm_module.F90diffusion.F9047cc48c6153c8ac4d46152a54b0b7ab46c6fd8371533169930000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixed nightly uninitialized variables test. Renamed diffusion_zt_lhs_inner to diffusion_zt_lhs_all, it is now also capable of calculating all values including boundaries now, it's beneficial to calculate the upper boundary value in this case and I imagine other may need the lower boundary calculated as well. Cleaned up windm_edsclrm_rhs A LOT, it's more readable and has clearly ordered steps now. clubb:ticket:834 git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8757 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 8c69c81acdc9cc0842ffd162a9e934d586b00c5e 2018-08-02 00:32:10 +000047cc48c6153c8ac4d46152a54b0b7ab46c6fd837Fixed nightly uninitialized variables test. Renamed diffusion_zt_lhs_inner to diffusion_zt_lhs_all, it is now also capable of calculating all values including boundaries now, it's beneficial to calculate the upper boundary value in this case and I imagine other may need the lower boundary calculated as well. Cleaned up windm_edsclrm_rhs A LOT, it's more readable and has clearly ordered steps now. clubb:ticket:834editadvance_windm_edsclrm_module.F90editdiffusion.F90advance_windm_edsclrm_module.F901d391de95c4b312041456ecc13b165a54f2d14021533236343000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduActually fixed nightly tests now (hopefully). A loop variable was being used outside a loop, which is an error that passes all the compiler tests. Also the intel compiler config file does not cause errors running if a index variable has not been initialized either, which resulted in correct seeming plots, timing, and output. I'm going to have to be stricter with the testing during these changes as loop variables and such will be often modified, I'll be sure to do a run after compiling with each compiler on top of confirming the output and running the uninitialized variable test manually. Because the last commit fixed the 2nd value of the rhs array the change will be BIT_CHANGING, but the plot output is identical for all but the most sensitive cases. clubb:ticket:834 git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8758 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: be4e4b3491e9d5cb60f878d34533b97259ae75d5 2018-08-02 18:59:03 +00001d391de95c4b312041456ecc13b165a54f2d1402Actually fixed nightly tests now (hopefully). A loop variable was being used outside a loop, which is an error that passes all the compiler tests. Also the intel compiler config file does not cause errors running if a index variable has not been initialized either, which resulted in correct seeming plots, timing, and output. I'm going to have to be stricter with the testing during these changes as loop variables and such will be often modified, I'll be sure to do a run after compiling with each compiler on top of confirming the output and running the uninitialized variable test manually. Because the last commit fixed the 2nd value of the rhs array the change will be BIT_CHANGING, but the plot output is identical for all but the most sensitive cases. clubb:ticket:834editadvance_windm_edsclrm_module.F90advance_xp2_xpyp_module.F90diffusion.F90stats_clubb_utilities.F90turbulent_adv_pdf.F90advance_windm_edsclrm_module.F90mean_adv.F902186e361695511d0e57bd728903ffddb7a7ada181533673761000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduOptimized the array setup procedures within advance_xp2_xpyp. Added more functions which handle entire arrays at a time rather than single terms to calculate the turbulence, mean advection, and diffusion terms. Because these changes reordered some calculations the results are BIT_CHANGING, but the plots are the same for all but the most sensitive cases. clubb:ticket:834 git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8761 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: e04c8b4d12c19f275a7ffb2c48ca2b0cd1a32539 2018-08-07 20:29:21 +00002186e361695511d0e57bd728903ffddb7a7ada18Optimized the array setup procedures within advance_xp2_xpyp. Added more functions which handle entire arrays at a time rather than single terms to calculate the turbulence, mean advection, and diffusion terms. Because these changes reordered some calculations the results are BIT_CHANGING, but the plots are the same for all but the most sensitive cases. clubb:ticket:834editdiffusion.F90editturbulent_adv_pdf.F90editadvance_xp2_xpyp_module.F90editadvance_windm_edsclrm_module.F90editstats_clubb_utilities.F90editmean_adv.F90stats_clubb_utilities.F902527ef4247d172eeea40ec4e8502a62a3ea67e051533673810000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduReverted stats_clubb_utilities, accidental commit git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8762 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: c1854eb8cedabd6dc0776b86313ed70f8c5c5ee8 2018-08-07 20:30:10 +00002527ef4247d172eeea40ec4e8502a62a3ea67e05Reverted stats_clubb_utilities, accidental commiteditstats_clubb_utilities.F90advance_windm_edsclrm_module.F906e57d219689d582e8d25d0213163984dd64d28c91533777712000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduThis should fix the nightly budget test. We may want to look into reducing the redone calculations for the stats code in the future, this lhs/rhs improving endeavour is definitely helping with that but more could be done. clubb:ticket:834 clubb:ticket:837 git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8763 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 989d179f909385c13ff929975318299b4e86f409 2018-08-09 01:21:52 +00006e57d219689d582e8d25d0213163984dd64d28c9This should fix the nightly budget test. We may want to look into reducing the redone calculations for the stats code in the future, this lhs/rhs improving endeavour is definitely helping with that but more could be done. clubb:ticket:834 clubb:ticket:837editadvance_windm_edsclrm_module.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90parameter_indices.F90clubb_api_module.F90stats_variables.F90stats_zm_module.F90parameters_tunable.F90surface_varnce_module.F90advance_helper_module.F9029ebdfcb8332dbe0cc4c3bc884b831c5752dc3671533830141000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.edu This commit adds splatting terms to the wp2, up2, and vp2 equations. A tuning parameter, C_wp2_splat, has been added, as well as budget term stats. However, C_wp2_splat still needs to be added to the error.in files. In addition, no splatting effect has been added to the wp3 equation yet. This commit is BIT_CHANGING, but only because new budget terms have been added to the zm stats. The results are identical because the value of the tuning parameter C_wp2_splat has been set to zero. I spot checked the output from arm_zt.nc, and it was identical to the prior revision except for the inclusion of C_wp2_splat in the new .nc file. Also, the plots looked identical for the priority cases, even the sensitive cases like arm_97. For clubb:ticket:832. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8765 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: f8b5de7f54101ada0a8d95a5d5dc55760030b464 2018-08-09 15:55:41 +000029ebdfcb8332dbe0cc4c3bc884b831c5752dc367editadvance_xp2_xpyp_module.F90editclubb_api_module.F90editadvance_wp2_wp3_module.F90editstats_variables.F90editsurface_varnce_module.F90editadvance_helper_module.F90editadvance_clubb_core_module.F90editstats_zm_module.F90editparameters_tunable.F90editparameter_indices.F90advance_xm_wpxp_module.F90mean_adv.F90934865a509b3b821c1fd3ba8519456bcc069fbb81533947805000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduImpoved the computational efficiency of xm_wpxp_rhs and xm_wpxp_lhs, see clubb:ticket:834 git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8767 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 090ab653a2e793683920a8a0efc7b22cb5a7ed82 2018-08-11 00:36:45 +0000934865a509b3b821c1fd3ba8519456bcc069fbb8Impoved the computational efficiency of xm_wpxp_rhs and xm_wpxp_lhs, see clubb:ticket:834editmean_adv.F90editadvance_xm_wpxp_module.F90advance_wp2_wp3_module.F90advance_clubb_core_module.F90parameters_tunable.F90stats_variables.F90advance_helper_module.F90stats_zt_module.F9039398fe6f19281b12245d9ff9bcd16468f60d44d1534028076000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduThis commit implements the effects of splatting on wp3. Splatting diminishes wp3 by reducing both vertical motions and skewness near inversions and the ground surface. This commit adds a new term to the wp3 budget, wp3_splat, and hence is BIT_CHANGING. However, otherwise, the results appear to be bit-for-bit identical; at least, they are for the arm_zt.nc file. For clubb:ticket:832. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8769 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 9e1536d8bc22fe532acc78067afa1e35b1c3324f 2018-08-11 22:54:36 +000039398fe6f19281b12245d9ff9bcd16468f60d44dThis commit implements the effects of splatting on wp3.editadvance_clubb_core_module.F90editadvance_helper_module.F90editstats_zt_module.F90editadvance_wp2_wp3_module.F90editparameters_tunable.F90editstats_variables.F90model_flags.F90advance_windm_edsclrm_module.F9016b36fb205bdfc55659c1204a4be16b4258c8dc81534219811000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am making the first step toward committing code that allows for the option of advancing um/upwp and vm/vpwp along with xm/wpxp variables. I have added the l_predict_upwp_vpwp flag and I have modified subroutine advance_windm_edsclrm appropriately. Results in GrADS output files from this revision are an exact match to results in GrADS output files from the previous revision for all cases. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8771 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: c1cb950ae77d865b0e96535a06c49a4c67b95aff 2018-08-14 04:10:11 +000016b36fb205bdfc55659c1204a4be16b4258c8dc8I am making the first step toward committing code that allows for the optioneditadvance_windm_edsclrm_module.F90editmodel_flags.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90c7c4a8728f3beb30a09a265911580c71a5b3303b1534222811000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added code to allow the option of predicting upwp and vpwp by using the advance_xm_wpxp code to predict um and upwp, as well as vm and vpwp, alongside the advancement of other xm and wpxp variables. The option to do this is controlled by the l_predict_upwp_vpwp flag. When the flag is turned off (which it currently is), the traditional code in advance_windm_edsclrm is used for um, vm, upwp, and vpwp. The results in GrADS output files from this revision are an exact match to the results in GrADS output files from the previous revision for all cases. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8772 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 6c5845b594ec8f0221ec8b931f624d3a64efe030 2018-08-14 05:00:11 +0000c7c4a8728f3beb30a09a265911580c71a5b3303bI added code to allow the option of predicting upwp and vpwp by using theeditadvance_xm_wpxp_module.F90editadvance_clubb_core_module.F90new_tsdadg_pdf.F90pdf_utilities.F90LY93_pdf.F90advance_clubb_core_module.F90numerical_check.F90pdf_closure_module.F90adg1_adg2_3d_luhar_pdf.F90calc_roots.F90new_pdf.F90new_pdf_main.F905f3450b73aa08a477fab3fe1c06e3b2eedcfdf181534270528000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI took the liberty of upgrading CLUBB's PDF closure and related code to a vector array rather than a loop over PDF closure over all vertical levels. The majority of the changes were simply promoting single-value variables to vector array variables and changing vertical-level-dependent "if" statements to "where" statements. Otherwise, var_1 = C * var_2 * var_3 works for both single-value variables and vector array variables. The results in GrADS output files from the current revision were an exact match to the results in GRADS output files from the previous revision for all cases when optimization (for gfortran) was set to -O0 for both the previous revision and the current revision. Likewise, the results in GrADS output files from the current revision were an exact match to the results in GrADS output files from the previous revision for all cases when optimization (for gfortran) was set to -O1 for both the previous revision and the current revision. However, when optimization (for gfortran) was set to the default value of -O2, the results are not an exact match between the previous and current versions. Some property of vectorizing the code must cause differences when optimization is set higher (-O2 or -O3). This makes this revision BIT_CHANGING. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8773 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 34d66b14aafa808a28970d51c0f54d43e8654f1f 2018-08-14 18:15:28 +00005f3450b73aa08a477fab3fe1c06e3b2eedcfdf18I took the liberty of upgrading CLUBB's PDF closure and related code to a vectoreditpdf_closure_module.F90editnew_tsdadg_pdf.F90editLY93_pdf.F90editadvance_clubb_core_module.F90editnew_pdf.F90editnew_pdf_main.F90editadg1_adg2_3d_luhar_pdf.F90editpdf_utilities.F90editnumerical_check.F90editcalc_roots.F90mono_flux_limiter.F90d06277e3aa5630a079c12066c053c590b07407c41534278304000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI updated the monotonic flux limiter to account for vector variables u and v. The monotonic flux limiter can now be used with um/upwp and vm/vpwp. Compared to previous results with l_predict_upwp_vpwp turned on and the call to the monotonic flux limiter omitted for um/upwp and vm/vpwp, the results are an exact match for all cases except ATEX, CGILS S6, CGILS S11, CGILS S12, and MC3E. The l_predict_upwp_vpwp flag is still turned off, so default CLUBB results remain the same as the previous version. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8774 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 863243836db1aa00e0e247647ab808ea9462c1c2 2018-08-14 20:25:04 +0000d06277e3aa5630a079c12066c053c590b07407c4I updated the monotonic flux limiter to account for vector variables u and v.editmono_flux_limiter.F90stats_variables.F90advance_clubb_core_module.F90stats_zt_module.F901712c2ec43aed1ce5db0776585a6fe8ecafaaddd1534282717000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am adding two new budget stats, um_mfl and vm_mfl, to CLUBB's zt stats output. I also made small corrections to the upwp and vpwp clipping numbers and I introduced error checking so that l_predict_upwp_vpwp can only currently be used with ADG1 and with implicit turbulent advection. Since new stats have been added to the zt file, this revision is BIT_CHANGING. However, only the zt stats output files are changed. The remaining stats output files from this revision are an exact match to the previous revision for all cases. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8775 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 4b307e4c38a33dedfd187e2bd134de4c5dac6bb0 2018-08-14 21:38:37 +00001712c2ec43aed1ce5db0776585a6fe8ecafaadddI am adding two new budget stats, um_mfl and vm_mfl, to CLUBB's zt stats output.editstats_zt_module.F90editstats_variables.F90editadvance_clubb_core_module.F90mono_flux_limiter.F90e332712a0fa6b7e7c8ec53707e7d36abadf624071534282930000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduIn r8775, I forgot to add the new um_mfl and vm_mfl stats to the monotonic flux limiter. git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8776 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 3bb8862710542400fad91e2e495e4c9358f91496 2018-08-14 21:42:10 +0000e332712a0fa6b7e7c8ec53707e7d36abadf62407In r8775, I forgot to add the new um_mfl and vm_mfl stats to the monotonic fluxeditmono_flux_limiter.F90model_flags.F90667c9ea18924393a999502f05d11138850316c1d1534285132000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am turning on the l_predict_upwp_vpwp code! This revision is BIT_CHANGING, in the best way possible! git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8778 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: fbf124c85d68eda019777aac6790e369e30e829c 2018-08-14 22:18:52 +0000667c9ea18924393a999502f05d11138850316c1dI am turning on the l_predict_upwp_vpwp code!editmodel_flags.F90advance_wp2_wp3_module.F907bdde8bb98e39e33f8c1e0b1beb57ddaf50d4dcd1534366437000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduImproved the computational efficiency of the LHS and RHS setup procedures in advance_wp2_wp3_module. This involved changing the order of calculations which casues this commit to be BIT_CHANGING for only the most sensitive cases. See clubb:ticket:834 git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8780 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 52dc00a1ac3994ccf521d693f0625dee06aa6242 2018-08-15 20:53:57 +00007bdde8bb98e39e33f8c1e0b1beb57ddaf50d4dcdImproved the computational efficiency of the LHS and RHS setup procedures in advance_wp2_wp3_module. This involved changing the order of calculations which casues this commit to be BIT_CHANGING for only the most sensitive cases. See clubb:ticket:834editadvance_wp2_wp3_module.F90advance_windm_edsclrm_module.F90a62d534df9295f8929a7966f6742f1bb5fbc226b1534370242000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduImproved computational efficiency of windm_edsclr_lhs. See clubb:ticket:834 git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8781 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: b30e9584d2828083fc42dd3580ca6438667216c2 2018-08-15 21:57:22 +0000a62d534df9295f8929a7966f6742f1bb5fbc226bImproved computational efficiency of windm_edsclr_lhs. See clubb:ticket:834editadvance_windm_edsclrm_module.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90turbulent_adv_pdf.F90advance_xm_wpxp_module.F90advance_windm_edsclrm_module.F90mean_adv.F90a6b375b1820233dab18dad3bc9e4757a56a451391534373430000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduChanged the name of _turb to _ta, and _advm to _ma to keep with the current naming conventions. Also fixed line length warnings. clubb:ticket:834 git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8782 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: eb87f1b4a5550ecc44fbe749862b6cff656f166e 2018-08-15 22:50:30 +0000a6b375b1820233dab18dad3bc9e4757a56a45139Changed the name of _turb to _ta, and _advm to _ma to keep with the current naming conventions. Also fixed line length warnings. clubb:ticket:834editadvance_xp2_xpyp_module.F90editturbulent_adv_pdf.F90editadvance_wp2_wp3_module.F90editadvance_xm_wpxp_module.F90editadvance_windm_edsclrm_module.F90editmean_adv.F90stats_clubb_utilities.F90pdf_closure_module.F9094a340e184b616d28bd6c155f8ddb84f193d1ab51534448108000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdded grid_class to the dependency lists of the pdf files that were changed in commit 8773 git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8783 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: 9bdea81a104b568440d7e96139ea0b8af8155aeb 2018-08-16 19:35:08 +000094a340e184b616d28bd6c155f8ddb84f193d1ab5Added grid_class to the dependency lists of the pdf files that were changed in commit 8773editstats_clubb_utilities.F90editpdf_closure_module.F90stats_clubb_utilities.F90pdf_closure_module.F9057ccb4777be0ec4b156749677932f99785b9307b1534448231000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAccidental commit, undoing 8783 git-svn-id: file:///usr/local/src/svnroot/clubb_repos/trunk@8784 f1ce5500-ea2b-45e0-a110-28dffb978352 Former-commit-id: cabf23cfdfd5a6e69982c2c8d22c7f2f5899becb 2018-08-16 19:37:11 +000057ccb4777be0ec4b156749677932f99785b9307bAccidental commit, undoing 8783editstats_clubb_utilities.F90editpdf_closure_module.F90model_flags.F90b6174f642f2043d29a8380a5093d18b7a84380511535473340000http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffingriffinb@lyons.math.uwm.eduI am changing the default setting of flags l_min_wp2_from_corr_wx and l_min_xp2_from_corr_wx to true to match what is found in configurable_model_flags.in. This is for #835 in CLUBB GIT Issues. 2018-08-28 11:22:20 -0500b6174f642f2043d29a8380a5093d18b7a8438051I am changing the default setting of flags l_min_wp2_from_corr_wx andeditmodel_flags.F90advance_clubb_core_module.F90advance_helper_module.F9026007da2390b402bded083d130374840ca0c354c1535582510000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduModified compute_Cx_fnc_Richardson. Made it a subroutine, modified the algorithm slightly, removed use of allocates and deallocates from it, removed verical_avg call to avoid redoing calculations and precalculated some divides. This saved clubb_core about 8% runtime overall. see clubb:issues:834 2018-08-29 17:41:50 -050026007da2390b402bded083d130374840ca0c354cModified compute_Cx_fnc_Richardson. Made it a subroutine, modified the algorithm slightly, removed use of allocates and deallocates from it, removed verical_avg call to avoid redoing calculations and precalculated some divides. This saved clubb_core about 8% runtime overall. see clubb:issues:834editadvance_clubb_core_module.F90editadvance_helper_module.F90advance_helper_module.F9025761f981a2c0900733322ee3e3c70342e8cbdb41535585528000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduRemoved print line. Also this commit is BIT_CHANGING since it reorders some calculations, but the difference only affects the most sensitive cases. 2018-08-29 18:32:08 -050025761f981a2c0900733322ee3e3c70342e8cbdb4Removed print line. Also this commit is BIT_CHANGING since it reorders some calculations, but the difference only affects the most sensitive cases.editadvance_helper_module.F90pdf_parameter_module.F90pdf_closure_module.F9072b36ee56fd04d6703723b2a64e1997c166091971535591224000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduChanged the way that init_pdf_params zeros out values as well as a spot in pdf_closure which does the same type of thing. Also changed the debug level for pdf_closure_check to 2. This all saved about 3% overall. see clubb issue 834 2018-08-29 20:07:04 -050072b36ee56fd04d6703723b2a64e1997c16609197Changed the way that init_pdf_params zeros out values as well as a spot in pdf_closure which does the same type of thing. Also changed the debug level for pdf_closure_check to 2. This all saved about 3% overall. see clubb issue 834editpdf_closure_module.F90editpdf_parameter_module.F90stats_zm_module.F90advance_clubb_core_module.F90stats_variables.F90advance_xm_wpxp_module.F90clip_explicit.F90mono_flux_limiter.F908d6e9153ccb95af59afbcd9fad0e0b4258801ccf1535655087000http://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffingriffinb@brock.math.uwm.eduI am adding source code for the introduction of budgets for predictive upwp and vpwp. This is the first commit of a two-stage commit. 2018-08-30 13:51:27 -05008d6e9153ccb95af59afbcd9fad0e0b4258801ccfI am adding source code for the introduction of budgets for predictive upwpeditadvance_xm_wpxp_module.F90editstats_zm_module.F90editadvance_clubb_core_module.F90editmono_flux_limiter.F90editstats_variables.F90editclip_explicit.F90mixing_length.F908b6e616a45f804c498d3ce6ac4a802b30fffbab81535671998000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduImproved computational speed of compute mixing length by modiying the algorithm slightly, avoiding unnecessary divides, and precalculating values. This saves about 6.5% overall. #834 2018-08-30 18:33:18 -05008b6e616a45f804c498d3ce6ac4a802b30fffbab8Improved computational speed of compute mixing length by modiying the algorithm slightly, avoiding unnecessary divides, and precalculating values. This saves about 6.5% overall. #834editmixing_length.F90lapack_wrap.F9085d980ead9d6e04b380fb326fcd63a72d09ac7501535676996000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduImproved computational efficiency of band_solve by reworking the way that the lulhs matrix is set up. #834 2018-08-30 19:56:36 -050085d980ead9d6e04b380fb326fcd63a72d09ac750Improved computational efficiency of band_solve by reworking the way that the lulhs matrix is set up. #834editlapack_wrap.F90saturation.F902b2c9519389dab1529f1ac5fea57ceb6157f902f1535753136000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduModified flatau equation which calculates saturation vapor pressure. This was done by modifying the form of the polynomial to allow the cpu to take advantage of out-of-order computations. The new coefficients were obtainted from matlab by finding the roots and multiplying/adding them where I needed to removed the complex numbers. The differences in any values are negligible, and the plots are only affected in the most sensitive cases, but this is BIT_CHANGING. #834 2018-08-31 17:05:36 -05002b2c9519389dab1529f1ac5fea57ceb6157f902fModified flatau equation which calculates saturation vapor pressure. This was done by modifying the form of the polynomial to allow the cpu to take advantage of out-of-order computations. The new coefficients were obtainted from matlab by finding the roots and multiplying/adding them where I needed to removed the complex numbers. The differences in any values are negligible, and the plots are only affected in the most sensitive cases, but this is BIT_CHANGING. #834editsaturation.F90grid_class.F904a6c2943cad5ec872cc9459201436bc7fc562d6d1535757226000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduCopied code from linear_interp_factor to linear_interpolated_azt/_azm. This allows those sections of code to become vectorized. Also reversed the calculation order of linear_interpolated_azt allowing for contiguous memory access. This saves about 3% overall and there are no visible differences in the plots when compared to last commit. #834 2018-08-31 18:13:46 -05004a6c2943cad5ec872cc9459201436bc7fc562d6dCopied code from linear_interp_factor to linear_interpolated_azt/_azm. This allows those sections of code to become vectorized. Also reversed the calculation order of linear_interpolated_azt allowing for contiguous memory access. This saves about 3% overall and there are no visible differences in the plots when compared to last commit. #834editgrid_class.F90fill_holes.F90advance_clubb_core_module.F90stats_clubb_utilities.F90clubb_api_module.F90mono_flux_limiter.F90a7117763631381c34ab604941651b72b1c7a9b691535760872000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduChanged vertical_avg and vertical_intergral to use dz rather than the inverse, they were dividing by an inverse and divisions are expensive. Also modified vertical_avg algorithm to no longer use vertical_integral, this saves some calculations. #834 2018-08-31 19:14:32 -0500a7117763631381c34ab604941651b72b1c7a9b69Changed vertical_avg and vertical_intergral to use dz rather than the inverse, they were dividing by an inverse and divisions are expensive. Also modified vertical_avg algorithm to no longer use vertical_integral, this saves some calculations. #834editmono_flux_limiter.F90editadvance_clubb_core_module.F90editfill_holes.F90editclubb_api_module.F90editstats_clubb_utilities.F90clip_explicit.F90647260c7c91d494a968c69c0ed377a322c257cd81536110946000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduImproved efficiency of clip_covar. The only change is saving the result of max_mag_corr * sqrt( xp2(k) * yp2(k) ) rather than calculating it three times. #834 2018-09-04 20:29:06 -0500647260c7c91d494a968c69c0ed377a322c257cd8Improved efficiency of clip_covar. The only change is saving the result of max_mag_corr * sqrt( xp2(k) * yp2(k) ) rather than calculating it three times. #834editclip_explicit.F90surface_varnce_module.F908a9a8dd41a238142d1e2f7543fa5b831f004ec331536871092000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduI made the surface splatting terms conservative. That is, I subtracted from wp2_sfc when splatting adds to up2_sfc and vp2_sfc, in such a way that the sum is unchanged. To avoid temporal noise, I needed to preserve the realizability of wpthlp_sfc and wprtp_sfc, rather than allowing wp2_sfc to be clipped all the way down to w_tol_sqd. Because I added clipping on thlp2_sfc and rtp2_sfc, this commit is BIT_CHANGING, but only for the most sensitive cases. For #832. 2018-09-13 15:38:12 -05008a9a8dd41a238142d1e2f7543fa5b831f004ec33I made the surface splatting terms conservative. That is, I subtracted from wp2_sfceditsurface_varnce_module.F90advance_xp2_xpyp_module.F90523ca23a88a67377b230620f84357d520aa6d9041537204202000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduI added clipping on up2 and vp2 that prevents these fields from exceeding 1000 m^2/s^2. The same sort of clipping already exists for wp2. With the splatting terms active, I found a configuration of twp_ice where the clipping on up2 and vp2 is useful. However, in the standard configuration, none of the priority cases changes answers because none have up2 and vp2 > 1000. For #832. 2018-09-17 12:10:02 -0500523ca23a88a67377b230620f84357d520aa6d904I added clipping on up2 and vp2 that prevents these fields from exceeding 1000 m^2/s^2.editadvance_xp2_xpyp_module.F90advance_clubb_core_module.F90surface_varnce_module.F90lapack_wrap.F90advance_helper_module.F9064a6fbc07bc7798dd63cd7fcad47f30a660f315b1537543324000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduThis commit turns on splatting of thermals (i.e., C_wp2_splat is nonzero). Hence it is BIT_CHANGING. To prevent noise in the vertical profiles, the splatting terms needed to be clipped. Unfortunately, this will introduce some undesired dependence on time step. At some point, we may wish to treat the splatting terms in a semi-implicit way. To make the splatting terms more effective, the return-to-isotropy coefficient (C4) has been reduced. This puts it more in accord with standard values, and it allows CLUBB to be more anisotropic. Other coefficients were also retuned. Along the way, I broke up some comment lines to avoid a warning about line length. Also, I commented out the check on the presence of the Id tag. That tag is no longer useful because CLUBB has moved from svn to git. For #832. 2018-09-21 10:22:04 -050064a6fbc07bc7798dd63cd7fcad47f30a660f315bThis commit turns on splatting of thermals (i.e., C_wp2_splat is nonzero). Hence it is BIT_CHANGING.editlapack_wrap.F90editadvance_clubb_core_module.F90editadvance_helper_module.F90editsurface_varnce_module.F90pdf_closure_module.F90constants_clubb.F90f61d9953e79775fa70f6083e07c962aefc6459421537562375000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdded functionality to allow cloud_frac to be better estimated at extreme values which produce either 0 or 1 when computed. The amount of estimation is controlled by the variable max_num_stdevs, indicating the number of standard deviations away from the mean of a pdf a value can be before being considered statistically insignificant. This speeds up the code but reducing the calculations required in calc_cloud_frac_component and calc_xprcp_component, and avoiding underflow errors when computing exponentials with too small of a number. By comparing plots and mathematical evaluation (erf(5)~=0), it seems the best value for max_num_stdevs is 5. This increases computational efficiency by about 10% #834 2018-09-21 15:39:35 -0500f61d9953e79775fa70f6083e07c962aefc645942Added functionality to allow cloud_frac to be better estimated at extreme values which produce either 0 or 1 when computed. The amount of estimation is controlled by the variable max_num_stdevs, indicating the number of standard deviations away from the mean of a pdf a value can be before being considered statistically insignificant. This speeds up the code but reducing the calculations required in calc_cloud_frac_component and calc_xprcp_component, and avoiding underflow errors when computing exponentials with too small of a number. By comparing plots and mathematical evaluation (erf(5)~=0), it seems the best value for max_num_stdevs is 5. This increases computational efficiency by about 10% #834editconstants_clubb.F90editpdf_closure_module.F90advance_clubb_core_module.F90e6ef3b8923f3641f496708629e6fd0239b3ea1601537823184000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdate advance_clubb_core_module.F90 I neatened and/or elaborated comments on the inputs and outputs of advance_clubb_core. 2018-09-24 16:06:24 -0500e6ef3b8923f3641f496708629e6fd0239b3ea160Update advance_clubb_core_module.F90editadvance_clubb_core_module.F90advance_clubb_core_module.F90f28cdc7db7c73dde06d0de691ed5dc78302a2e321538943429000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduI clipped sigma_sqd_w to prevent interpolated values of it from going negative. This avoids crashes in the lba, twp_ice, and mc3e cases when l_call_pdf_closure_twice = .true. Small negative values in sigma_sqd_w were causing small negative values of varnce_w_1 and varnce_w_2 at the lowest grid level, which then caused floating point exceptions in the pdf closure. l_call_pdf_closure_twice = .true. is not the default setting, but it is the setting in CAM6. Hopefully this code change will help allow the new version of CLUBB to be backwards-compatible with the CAM6 version. A few numbers in the output did change in the last digit or two in the arm_97 case. Maybe it was only sigma_sqd_w itself that was changing, and that value wasn't used anywhere? Anyway, technically, this commit is BIT_CHANGING. For issue larson-group/cam#116. 2018-10-07 15:17:09 -0500f28cdc7db7c73dde06d0de691ed5dc78302a2e32I clipped sigma_sqd_w to prevent interpolated values of iteditadvance_clubb_core_module.F90advance_clubb_core_module.F90model_flags.F90fe9d81553653c1039c48f6732dfb3ccfae53cb801539710115000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduI added a new option to diagnose the dissipation time scale, tau, first and then use it to diagnose the mixing length, Lscale, as Lscale = tau * tke. The purpose is twofold: 1) reduce computational expense of computing Lscale; and 2) increase tau near the ocean surface, in the hopes of improving hurricane surface winds. The option is currently turned off with the flag l_diag_Lscale_from_tau, and so the results are an exact match to those produced by the prior code. For #842. 2018-10-16 12:15:15 -0500fe9d81553653c1039c48f6732dfb3ccfae53cb80I added a new option to diagnose the dissipation time scale, tau, firsteditmodel_flags.F90editadvance_clubb_core_module.F90advance_xm_wpxp_module.F906fbc9a4abf9ae6aba74d7c54e40c6a6b03031ea71541017963000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduI found a new way to diagnose upthvp. Instead of using a bound on correlations, it relies on the formula upthvp = upthlp + 200 K uprtp + 2000 K uprcp. upthlp and uprtp are then diagnosed based on a budget equation from Andre et al. The new formula produces more upthvp aloft, where upwp is small. The budget of upwp for the BOMEX case looks plausible. I also discovered that when upthvp is better diagnosed, then the upwp_pr4 term is unnecessary. So I zeroed it out for now. For #841. 2018-10-31 15:32:43 -05006fbc9a4abf9ae6aba74d7c54e40c6a6b03031ea7I found a new way to diagnose upthvp. Instead of using a bound on correlations, it relieseditadvance_xm_wpxp_module.F90advance_xm_wpxp_module.F90970984d58351c5682e819dc42b48d4824bacc67b1541777541000http://carson.math.uwm.edu/jenkins/user/mcfadd34mcfadd34mcfadd34@uwm.eduintroducing error into clubb core for testing larson-group/sys_admin#533 2018-11-09 09:32:21 -0600970984d58351c5682e819dc42b48d4824bacc67bintroducing error into clubb core for testing larson-group/sys_admin#533editadvance_xm_wpxp_module.F90advance_xm_wpxp_module.F90ab452aecedc7073f07314bdc6b068de879727ae61541788295000http://carson.math.uwm.edu/jenkins/user/mcfadd34mcfadd34mcfadd34@uwm.edureverting error that was introduced larson-group/sys_admin#533 2018-11-09 12:31:35 -0600ab452aecedc7073f07314bdc6b068de879727ae6reverting error that was introduced larson-group/sys_admin#533editadvance_xm_wpxp_module.F90parameters_tunable.F90model_flags.F90fd04a5135f41fc7ba52f9012aa2864357fb965f01542138244000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am briefly changing some of the flag and parameter settings in CLUBB to match what is currently used by CAM. This change will be undone with the next trunk (master) commit. 2018-11-13 13:44:04 -0600fd04a5135f41fc7ba52f9012aa2864357fb965f0I am briefly changing some of the flag and parameter settings in CLUBBeditmodel_flags.F90editparameters_tunable.F90parameters_tunable.F90model_flags.F909a2cfb9ac48201c27fe347841ab5cb5f38551c211542139368000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduRevert "I am briefly changing some of the flag and parameter settings in CLUBB" This reverts commit adc5247053fe1bb22a8e73f747a39ed9d467d3fd. 2018-11-13 14:02:48 -06009a2cfb9ac48201c27fe347841ab5cb5f38551c21Revert "I am briefly changing some of the flag and parameter settings in CLUBB"editmodel_flags.F90editparameters_tunable.F90pdf_closure_module.F908b4636b0b9ba044518efadf97f44604fb52658e41542840937000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added a couple of comments reminding users to change the conditions in the SILHS check if the conditions change in the calculation of cloud fraction in PDF closure. 2018-11-21 16:55:37 -06008b4636b0b9ba044518efadf97f44604fb52658e4I added a couple of comments reminding users to change the conditions ineditpdf_closure_module.F90parameters_tunable.F90model_flags.F9037c8f1b5b614f57901e66d7ee8e6e07d09c57c541544053895000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduRevert "Revert "I am briefly changing some of the flag and parameter settings in CLUBB"" This reverts commit 7e8b4f7f20f25bccdbcaca0fccb970d793518133. I am briefly re-setting the CAM-specific flag and parameter settings for CLUBB for use in CAM-CLUBB. I am going to make (another) tag of this revision, and then again revert this revision. 2018-12-05 17:51:35 -060037c8f1b5b614f57901e66d7ee8e6e07d09c57c54Revert "Revert "I am briefly changing some of the flag and parameter settings in CLUBB""editmodel_flags.F90editparameters_tunable.F90parameters_tunable.F90model_flags.F9066cc9401b0f477b7d9875c4354ccb974788834871544054506000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduRevert "Revert "Revert "I am briefly changing some of the flag and parameter settings in CLUBB""" This reverts commit a56d278f12df2c85116c41459bd54c254ee94b62. I again reverting back from the flag and parameter settings used in CAM-CLUBB and returning the CLUBB master to its normal settings. 2018-12-05 18:01:46 -060066cc9401b0f477b7d9875c4354ccb97478883487Revert "Revert "Revert "I am briefly changing some of the flag and parameter settings in CLUBB"""editmodel_flags.F90editparameters_tunable.F90stats_zm_module.F90stats_variables.F90advance_xm_wpxp_module.F904c7b25bb90d21e435fd03474d328228fc11d097b1545156359000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduI committed a subroutine, diagnose_upxp, that calculates upthlp, uprtp, vpthlp, vprtp using a simple diagnostic version of Eqn. 7 of Andre et al. (1978). Ultimately, CLUBB will use this in order to compute the buoyancy terms in the upwp and vpwp budgets. The results match the prior repo results bit for bit if, in the prior code, I pull tau_C6_zm inside the parentheses in the prior calculation of upthlp and uprtp: upthvp = - 0.3_core_rknd * tau_C6_zm * ( upwp * ddzt( thlm ) + wpthlp * ddzt( um ) & + 200.0_core_rknd * ( upwp * ddzt( rtm ) + wprtp * ddzt( um ) ) ) & This is needed to avoid a change in the order of operations, which changes the results in IEEE arithmetic. I also need to set C6=1 and C7=0 in subroutine diagnose_upxp. However, what I am committing includes C6 and C7 in subroutine diagnose_upxp. It doesn't change the results much, but nevertheless the results are BIT_CHANGING. In addition, four new stats are added to all_stats.in and standard_stats.in: upthlp, uprtp, vpthlp, and vprtp. For #841. 2018-12-18 12:05:59 -06004c7b25bb90d21e435fd03474d328228fc11d097bI committed a subroutine, diagnose_upxp, that calculateseditstats_zm_module.F90editadvance_xm_wpxp_module.F90editstats_variables.F90pdf_closure_module.F906edf0adb68cffee7a4ee15a75bdbedac20d2d42e1545352741000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@mitch.math.uwm.eduImproved the computational efficiency of pdf_closure. This speed the code up by about 6% overall. Because it changed the order of some calculations it is BIT_CHANGING but does not change plots. clubb issue #834 2018-12-20 18:39:01 -06006edf0adb68cffee7a4ee15a75bdbedac20d2d42eImproved the computational efficiency of pdf_closure. This speed the code up by about 6% overall. Because it changed the order of some calculations it is BIT_CHANGING but does not change plots. clubb issue #834editpdf_closure_module.F90setup_clubb_pdf_params.F90ec1fb66c9630d79bc710eeca12df3716ba7b534d1545526862000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am modifying one part of setup_clubb_pdf_params.F90 to be taken out of a large outer "do" loop over all vertical level, and instead, promote single-level variable declarations to arrays and use where...elsewhere statements rather than else...elseif statments. The part of setup_clubb_pdf_params.F90 that is being modified is the part of the code that calculates the PDF component (in-precip) means and (in-precip) standard deviations of hydrometeor species for the hydrometeor portion of the PDF. This is being done in an effort to speed up CLUBB. This does not pertain to CLUBB core, but it does pertain to analytic KK or SILHS cases. When the gfortan optimization level is decreased to -O0 or -O1, the results in GrADS output files from this revision are an exact match to the results in GrADS output files from the previous revision for all cases. When the gfortran optimization level is left at the current default of -O2, the results remain an exact match for many cases, including some that use upscaled KK or SILHS, but results change for ARM 97, DYCOMS-II RF02 DO, ASTEX A209, TWP-ICE, and MC3E, which tecnically makes this revision BIT_CHANGING. 2018-12-22 19:01:02 -0600ec1fb66c9630d79bc710eeca12df3716ba7b534dI am modifying one part of setup_clubb_pdf_params.F90 to be taken out of a largeeditsetup_clubb_pdf_params.F90pdf_utilities.F90setup_clubb_pdf_params.F90Nc_Ncn_eqns.F90b19476be5eb8e937f24c39f06a37f3981da450971546468210000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am updating the code within setup_clubb_pdf_parameters.F90 in order to take more code out of the outer loop over all vertical levels and internally promote scalars to vectors. This is designed to speed up the code for analytic KK or SILHS runs. The results in GrADS output files from this revision is an exact match to the results in GrADS output files from the previous revision for all cases. 2019-01-02 16:30:10 -0600b19476be5eb8e937f24c39f06a37f3981da45097I am updating the code within setup_clubb_pdf_parameters.F90 in order to takeeditsetup_clubb_pdf_params.F90editNc_Ncn_eqns.F90editpdf_utilities.F90pdf_closure_module.F90adg1_adg2_3d_luhar_pdf.F90ae02afd6021e9f3e38b95c203221042af7d877521546539880000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduTo diagnose uprcp using CLUBB's PDF machinery, I fed some variables related to horizontal wind through some argument lists. The code change is incomplete at this point. The results do not change because the variables are declared locally in subroutine pdf_closure, and nothing is done with the output, uprcp. The wind variables are not even initialized at this point. Nonetheless, the results of the arm case are bit-for-bit identical with the prior results. The units tests still pass. For #841. 2019-01-03 12:24:40 -0600ae02afd6021e9f3e38b95c203221042af7d87752To diagnose uprcp using CLUBB's PDF machinery,editadg1_adg2_3d_luhar_pdf.F90editpdf_closure_module.F90advance_clubb_core_module.F90pdf_closure_module.F906873c26df22486e27273dfbdf4f80a09e605082a1546624367000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduContinuing with diagnosis of uprcp using CLUBB's PDF, I fed the arguments through subroutine pdf_closure. I have yet to feed them through pdf_closure_driver. For the arm case, the results are bit-for-bit identical. For #841. 2019-01-04 11:52:47 -06006873c26df22486e27273dfbdf4f80a09e605082aContinuing with diagnosis of uprcp using CLUBB's PDF,editadvance_clubb_core_module.F90editpdf_closure_module.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90d2812cc427f191ac3810fa070100ed0daea03ce91546711817000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduMore code to diagnose uprcp using CLUBB's PDF. I fed the relevant arguments through pdf_closure_driver and advance_xm_wpxp. The results are still bit-for-bit identical because uprcp does not (yet) interact with the rest of the code. I put some idiot-proofing in setup_clubb_core because the arguments have not yet been fed through advance_clubb_core and preserved from time step to time step. The unit tests passed. For #841. 2019-01-05 12:10:17 -0600d2812cc427f191ac3810fa070100ed0daea03ce9More code to diagnose uprcp using CLUBB's PDF.editadvance_xm_wpxp_module.F90editadvance_clubb_core_module.F90advance_clubb_core_module.F907e26b5bc89f6b289ee3b8037c7aee3fc748ff0181546715059000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduCorrection for the last uprcp-related commit: uprcp_zt is now interpolated to the zm levels in the case in which the pdf closure is called only once. The answers are still bit-for-bit identical. For #841. 2019-01-05 13:04:19 -06007e26b5bc89f6b289ee3b8037c7aee3fc748ff018Correction for the last uprcp-related commit:editadvance_clubb_core_module.F90pdf_utilities.F90Nc_Ncn_eqns.F902e9ec3492f275db7e1673a66b31b2dc7e0a1e0101546989949000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am correcting the code so that the Nightly Uninitialized Variables Test (Oracle Fortran) works correctly again. I've noticed that FORTRAN's where statement doesn't always prevent a certain part of a where ... elsewhere block from being entered in the same way that it prevents a certain part of an if ... elseif block from being entered. Code that is not supposed to be entered under certain conditions gets entered and then the mask is applied later, throwing away the results. However, if the intrusion causes a floating point exception for whatever reason, the run stops. I remember overhearing talk between Gunther and Vince about the where statement "guessing" wrong sometimes. Is there a way to stop it from "guessing" wrong or at least reduce the number of wrong "guesses"? 2019-01-08 17:25:49 -06002e9ec3492f275db7e1673a66b31b2dc7e0a1e010I am correcting the code so that the Nightly Uninitialized Variables TesteditNc_Ncn_eqns.F90editpdf_utilities.F90setup_clubb_pdf_params.F90559b1e46e16f3fc7c3c426ee68e34c6cc9ec77991547075606000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am continuing to pull parts of setup_pdf_parameters outside of a large "do" loop over all vertical levels and promote subroutines that are called from setup_pdf_parameters to cover the whole array of vertical levels, rather than just one level at a time. This code change is simply for a statistical output subroutine (pdf_param_hm_stats) within setup_pdf_parameters. This all is in an effort to speed up the code. This revision outputs stats at thermodynamic level 1 (which is below the model surface), whereas the subroutine wasn't previously called at level 1. This makes the results BIT_CHANGING, but only for the stats that are output at level 1 of the zt output files. The results in other GrADS output files (zm, sfc, etc.) from this revision are an exact match to the results in the same GrADS output files from the previous revision for all cases. 2019-01-09 17:13:26 -0600559b1e46e16f3fc7c3c426ee68e34c6cc9ec7799I am continuing to pull parts of setup_pdf_parameters outside of a large "do"editsetup_clubb_pdf_params.F90setup_clubb_pdf_params.F90495d473a8f734fbab6da71b24c0a6ca171aab6d71547146438000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am pulling statistical output subroutine pdf_param_ln_hm_stats outside of the large "do" loop in setup_pdf_parameters. This is part of a larger code speed-up effort. The results in GrADS output files from this revision are an exact match to the results in GrADS output files from the previous revision for all cases. 2019-01-10 12:53:58 -0600495d473a8f734fbab6da71b24c0a6ca171aab6d7I am pulling statistical output subroutine pdf_param_ln_hm_stats outsideeditsetup_clubb_pdf_params.F90pdf_utilities.F90ab433cfbf941bd9b7042f3ca7037e46cfdd3f47d1547252742000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduChanging the range of the correlation values determined in calc_comp_corrs_binormal from [ -1.0, 1.0 ] to [ -0.99, 0.99 ] (based on value of max_mag_correlation = .99). This is the subroutine that calculates corr_rt_thl_x and should fix the issue with the WRF WPS Katrina bitten test as discussed in the commets of commit ad0ee5b9b3c253329df1208560b46d1dc4fca1c2. I suspect that it will fix the WRF-CLUBB-SILHS Restart Test as well, but I am basing that mostly off hope. 2019-01-11 18:25:42 -0600ab433cfbf941bd9b7042f3ca7037e46cfdd3f47dChanging the range of the correlation values determined in calc_comp_corrs_binormal from [ -1.0, 1.0 ] to [ -0.99, 0.99 ] (based on value of max_mag_correlation = .99). This is the subroutine that calculates corr_rt_thl_x and should fix the issue with the WRF WPS Katrina bitten test as discussed in the commets of commit ad0ee5b9b3c253329df1208560b46d1dc4fca1c2. I suspect that it will fix the WRF-CLUBB-SILHS Restart Test as well, but I am basing that mostly off hope.editpdf_utilities.F90stats_variables.F90460f0559e1c307e6e01794b66d6afc26284eef711547566530000http://carson.math.uwm.edu/jenkins/user/mcfadd34mcfadd34mcfadd34@uwm.educommenting out threadprivate command to test openmp bitten test larson-group/sys_admin#566 2019-01-15 09:35:30 -0600460f0559e1c307e6e01794b66d6afc26284eef71commenting out threadprivate command to test openmp bitten test larson-group/sys_admin#566editstats_variables.F90stats_variables.F905659e7c24d5ebc1c52e9d4868aede6f4b8d106231547569661000http://carson.math.uwm.edu/jenkins/user/mcfadd34mcfadd34mcfadd34@uwm.eduuncommenting threadprivate larson-group/sys_admin#566 2019-01-15 10:27:41 -06005659e7c24d5ebc1c52e9d4868aede6f4b8d10623uncommenting threadprivate larson-group/sys_admin#566editstats_variables.F90setup_clubb_pdf_params.F902820b9199e5e5340b41a0331328f091283cc09311547593831000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI have changed the structure of setup_pdf_parameters so that the subroutine that packs up the hydrometeor PDF parameters, subroutine pack_hydromet_pdf_params, is called from outside the loop over all vertical levels. Within pack_hydromet_pdf_params, variables have been promoted to arrays over all vertical levels. This leaves the reamining outer loops over all vertical levels to include only a few subroutines (diagnosing correlations and the Cholesky stuff). The results in GrADS output files from this revision are an exact match to the results in GrADS output files from the previous revision for all cases. 2019-01-15 17:10:31 -06002820b9199e5e5340b41a0331328f091283cc0931I have changed the structure of setup_pdf_parameters so that the subroutine thateditsetup_clubb_pdf_params.F90pdf_closure_module.F9079a4333484ac252ffe654daacb9a46593099c6a21547758965000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduReturned max check to the calculation of rcm. This should fix the PGI Compiler Nightly Test and could be BIT_CHANGING. 2019-01-17 15:02:45 -060079a4333484ac252ffe654daacb9a46593099c6a2Returned max check to the calculation of rcm. This should fix the PGI Compiler Nightly Test and could be BIT_CHANGING.editpdf_closure_module.F90stats_variables.F90stats_zm_module.F90advance_xm_wpxp_module.F9049feb7636991743ae49e11deacc358da1afff9ee1547849925000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduI am turning on the new calculation of uprcp that uses CLUBB's PDF. Also, I am re-introducing the pressure term upwp_pr4, because it is a useful preconditioner for producing an upgradient flux in upwp. This commit is BIT_CHANGING both because the answers change and because new outputs (uprcp, upthvp, ...) are written to disk. The gabls3_night case is degraded, but the other cases look comparable or better than before. For #841. 2019-01-18 16:18:45 -060049feb7636991743ae49e11deacc358da1afff9eeI am turning on the new calculation of uprcp that uses CLUBB's PDF.editstats_variables.F90editadvance_xm_wpxp_module.F90editstats_zm_module.F90setup_clubb_pdf_params.F904cea0a0f193d06e73a5877c561e63deb709cb7821548367895000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI modified the code in setup_clubb_pdf_params.F90 to use only one call to function pdf2hydromet_idx or function hydromet2pdf_idx within a loop, instead of multiple calls within array indices for different variables. This cuts down on excessive calls and also makes the code a little more nicely readable. The results in GrADS output files from this revision are an exact match to the results in GrADS output files from the previous revision for all cases. 2019-01-24 16:11:35 -06004cea0a0f193d06e73a5877c561e63deb709cb782I modified the code in setup_clubb_pdf_params.F90 to use only one call toeditsetup_clubb_pdf_params.F90parameters_tunable.F9026acd1f23eba8ae32b195168c32a075c2baa1b461548854661000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am updating CLUBB_core and SILHS in the clubb_E3SM_silhs branch to match the clubb and silhs directories in the bmg929/atm/clubb_silhs_v2 branch of E3SM. This commit can be considered a list of modifications that were done to the CLUBB code in the clubb_silhs branch of E3SM. It should be noted that the version of CLUBB used in the clubb-silhs branches of E3SM is r8220. This commit provides a base to marge up CLUBB and SILHS to more current versions for use in E3SM CLUBB-SILHS. 2019-01-30 07:24:21 -060026acd1f23eba8ae32b195168c32a075c2baa1b46I am updating CLUBB_core and SILHS in the clubb_E3SM_silhs branch toeditparameters_tunable.F90parameters_tunable.F90model_flags.F90cd399238c1e54c874b145501fcb815d6e4a2b56d1548869329000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am setting model flags and tunable parameters in the clubb_E3SM_silhs branch in a backwards-compatible fashion to r8220, which was the version of CLUBB and SILHS that was previously used in E3SM-CLUBB-SILHS. 2019-01-30 11:28:49 -0600cd399238c1e54c874b145501fcb815d6e4a2b56dI am setting model flags and tunable parameters in the clubb_E3SM_silhs brancheditmodel_flags.F90editparameters_tunable.F90transform_to_pdf_module.F90f8c3b05eee249e8acb82087135d10a3349180c721548885592000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI temporarily set l_clip_extreme_chi_sample_pts back to false in the clubb_E3SM_silhs branch. This is being done to test for backwards compatibility while upgrading E3SM-CLUBB-SILHS. The goal is to produce a version of SILHS that is similar in all ways to the version of SILHS that was found in r8220. Once the merger is complete, this flag will likely be reset back to true. 2019-01-30 15:59:52 -0600f8c3b05eee249e8acb82087135d10a3349180c72I temporarily set l_clip_extreme_chi_sample_pts back to false in theedittransform_to_pdf_module.F90transform_to_pdf_module.F90d0fdb430ac89f446a02c3fc2a04cfeb83bf861031549729862000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduRevert "I temporarily set l_clip_extreme_chi_sample_pts back to false in the" I am setting l_clip_extreme_chi_sample_pts back to true for use in E3SM-CLUBB-SILHS. This reverts commit 677c6f9d54ef542325ca3308980c6c22cac6207a. 2019-02-09 08:31:02 -0800d0fdb430ac89f446a02c3fc2a04cfeb83bf86103Revert "I temporarily set l_clip_extreme_chi_sample_pts back to false in the"edittransform_to_pdf_module.F90advance_xm_wpxp_module.F90lapack_wrap.F90719a2e336400711fd23caf13f000f9b76bc1cbe61552087005000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI improved the error messages when LU decomp. fails within advance_xm_wpxp_module.F90. 2019-03-08 17:16:45 -0600719a2e336400711fd23caf13f000f9b76bc1cbe6I improved the error messages when LU decomp. fails withineditadvance_xm_wpxp_module.F90editlapack_wrap.F90advance_xm_wpxp_module.F909bdd16bbeac12acbb5cd1abacd3651e9fb9864eb1552501314000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduImproved error message prints in advance_xm_wpxp. 2019-03-13 13:21:54 -05009bdd16bbeac12acbb5cd1abacd3651e9fb9864ebImproved error message prints in advance_xm_wpxp.editadvance_xm_wpxp_module.F90advance_wp2_wp3_module.F909ebad48929103e747598b00f2a5e1ca1916d7a2e1552534478000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added improved LHS and RHS print statements when a LU decomp. error occurs in advance_wp2_wp3. 2019-03-13 22:34:38 -05009ebad48929103e747598b00f2a5e1ca1916d7a2eI added improved LHS and RHS print statements when a LU decomp. error occurseditadvance_wp2_wp3_module.F90clubb_api_module.F90e89d13da7946db4a7751cacfb92a92f419f268d41552536682000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added params_list to the list of variables that are accessible through clubb_api_module. 2019-03-13 23:11:22 -0500e89d13da7946db4a7751cacfb92a92f419f268d4I added params_list to the list of variables that are accessible througheditclubb_api_module.F90advance_clubb_core_module.F90sigma_sqd_w_module.F902dcd21b8d1335f13ae48c5e9202048cbdabcd7a31553795121000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am making the first step for updating the code that calculates sigma_sqd_w. I have included upwp^2/(up2*wp2) and vpwp^2/(vp2*wp2) in the calculation of the maximum squared correlation for the limit of sigma_sqd_w when the l_predict_upwp_vpwp flag is enabled. When the l_predict_upwp_vpwp flag is turned off, the results in GrADS output files from this revision are an exact match to the results in GrADS output files from the previous revision for all cases. When the l_predict_upwp_vpwp flag in enabled (which it is by default), this revision is BIT_CHANGING. However, only a couple of cases show visible changes on the plots. Git Issue Reference: #852. 2019-03-28 12:45:21 -05002dcd21b8d1335f13ae48c5e9202048cbdabcd7a3I am making the first step for updating the code that calculates sigma_sqd_w.editadvance_clubb_core_module.F90editsigma_sqd_w_module.F90advance_clubb_core_module.F9020c0f6ab99737edaa2ba6f320ba059ab7fc3783f1553982073000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduI added a log-law height dependence to the code that diagnoses tau directly, rather than diagnosing the mixing length, Lscale (l_diag_Lscale_from_tau = .true.). However, that option is set to .false. by default, and hence the nightly test results should be unchanged. For #842. 2019-03-30 16:41:13 -050020c0f6ab99737edaa2ba6f320ba059ab7fc3783fI added a log-law height dependence to the code that diagnoseseditadvance_clubb_core_module.F90clubb_api_module.F905c39d243769b471253986d92bdfb11d92ae08d5b1556160033000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added fill_holes_hydromet_api to clubb_api_module.F90. 2019-04-24 21:40:33 -05005c39d243769b471253986d92bdfb11d92ae08d5bI added fill_holes_hydromet_api to clubb_api_module.F90.editclubb_api_module.F90mt95.f90stats_variables.F90model_flags.F90gmres_cache.F901dd81aca877e9ea8bfa88c91c46fcf5e611852851558450464000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduI added a new python script, check_for_missing_threadprivate.py, which checks whether a module variable in CLUBB or SILHS has been declared but not designated as a threadprivate. In such a case, the variables are not thread safe and different threads may store a variable in the same memory location, causing errors. In particular, such an omission may cause CAM-CLUBB-SILHS to produce different results when different numbers of openmp threads are selected. I then added some threadprivate statements in order to make the test pass. For larson-group/cam#121. 2019-05-21 09:54:24 -05001dd81aca877e9ea8bfa88c91c46fcf5e61185285I added a new python script, check_for_missing_threadprivate.py,editmt95.f90editgmres_cache.F90editstats_variables.F90editmodel_flags.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90clubb_api_module.F90numerical_check.F90pdf_closure_module.F90pdf_parameter_module.F90stats_clubb_utilities.F90variables_diagnostic_module.F90setup_clubb_pdf_params.F90variables_prognostic_module.F9072bfbae28a4d94532738cb031a1a5620caa78e3e1559079583000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduModifying clubb's pdf_parameter type. It's now a type containing arrays, whereas before it was a type containing scalars, but used everywhere as an array of these types. This new way allows the elements of pdf_parameter to exist in contiguous memory sections, which improves computational efficiency when accessing a given parameter over all vertical levels. clubb issue #834 2019-05-28 16:39:43 -050072bfbae28a4d94532738cb031a1a5620caa78e3eModifying clubb's pdf_parameter type. It's now a type containing arrays, whereas before it was a type containing scalars, but used everywhere as an array of these types. This new way allows the elements of pdf_parameter to exist in contiguous memory sections, which improves computational efficiency when accessing a given parameter over all vertical levels. clubb issue #834editvariables_prognostic_module.F90editnumerical_check.F90editpdf_parameter_module.F90editpdf_closure_module.F90editstats_clubb_utilities.F90editvariables_diagnostic_module.F90editadvance_clubb_core_module.F90editadvance_xp2_xpyp_module.F90editclubb_api_module.F90editsetup_clubb_pdf_params.F90variables_diagnostic_module.F90variables_prognostic_module.F902f805be18b00c5bb0cb7a0fd6133372c91513b961559173799000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixed dycoms restart run failure. The pdf_parameter variables are accessed via a use statement in the section of code where the restart run attempts to set their values, but since they are allocatable they do not retain their allocated status once out of scope. Adding the save attribute to pdf_params and pdf_params_zm fixes the problem. These pdf_parameter variables used in clubb standalone are not used by host models, yet they are still allocated during host model runs, something that has been noted before and will be changed. clubb issue #834 2019-05-29 18:49:59 -05002f805be18b00c5bb0cb7a0fd6133372c91513b96Fixed dycoms restart run failure. The pdf_parameter variables are accessed via a use statement in the section of code where the restart run attempts to set their values, but since they are allocatable they do not retain their allocated status once out of scope. Adding the save attribute to pdf_params and pdf_params_zm fixes the problem. These pdf_parameter variables used in clubb standalone are not used by host models, yet they are still allocated during host model runs, something that has been noted before and will be changed. clubb issue #834editvariables_prognostic_module.F90editvariables_diagnostic_module.F90FileForTestingUpdateScript.txtfae81b119a174f67903ecdf4a576eb7b83f3a9111559313403000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdded temp test file Adding a test file to verify wrf updates are working 2019-05-31 09:36:43 -0500fae81b119a174f67903ecdf4a576eb7b83f3a911Added temp test fileaddFileForTestingUpdateScript.txtFileForTestingUpdateScript.txtcb11bc29e16abcdf34202a84e8c2ea5d7e3afbb11559313981000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRemove test file The wrf update is working now, no need to keep this file around. 2019-05-31 09:46:21 -0500cb11bc29e16abcdf34202a84e8c2ea5d7e3afbb1Remove test filedeleteFileForTestingUpdateScript.txtadvance_clubb_core_module.F90300de16a3e09fca0d7e720a1e3755832aff3098b1561766277000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding conditional statement around compute_Cx_Fnc_Richardson, see clubb issue #855. This change is bit identical. 2019-06-28 18:57:57 -0500300de16a3e09fca0d7e720a1e3755832aff3098bAdding conditional statement around compute_Cx_Fnc_Richardson, see clubb issue #855. This change is bit identical.editadvance_clubb_core_module.F90Skx_module.F9025e23c9a39541b8b5b4390afe03350b95bb9e5391562022485000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduOptimizing procedures within Skx_module. The reduction in runtime is greatly dependent on system and compiler option. See clubb issue #855 and comment by Gunther on 7-1-19 for explanation. This is BIT_CHANGING but the plots only differ in the sensitive cases. 2019-07-01 18:08:05 -050025e23c9a39541b8b5b4390afe03350b95bb9e539Optimizing procedures within Skx_module. The reduction in runtime is greatly dependent on system and compiler option. See clubb issue #855 and comment by Gunther on 7-1-19 for explanation. This is BIT_CHANGING but the plots only differ in the sensitive cases.editSkx_module.F90parameters_tunable.F90stats_zm_module.F90stats_variables.F90advance_clubb_core_module.F90parameter_indices.F907fd2d937257edeb8764cce7e742ab680900441751562182842000http://carson.math.uwm.edu/jenkins/user/guozhunguozhunguozhun@uwm.eduticket #842 we added 4 tunable parameters for tau, they are Coefficient of inverse tau term contributed by background constant value, Coefficient of inverse tau term contributed by surface log law, Coefficient of inverse tau term contributed by vertical wind shear and Coefficient of inverse tau term contributed by Brunt Vaisala frequency 2019-07-03 14:40:42 -05007fd2d937257edeb8764cce7e742ab68090044175ticket #842 we added 4 tunable parameters for tau, they are Coefficient of inverse tau term contributed by background constant value, Coefficient of inverse tau term contributed by surface log law, Coefficient of inverse tau term contributed by vertical wind shear and Coefficient of inverse tau term contributed by Brunt Vaisala frequencyeditparameter_indices.F90editparameters_tunable.F90editstats_zm_module.F90editstats_variables.F90editadvance_clubb_core_module.F90adg1_adg2_3d_luhar_pdf.F901f2facc146cb5190975cca5a6387fb6e79e72d251562888255000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduModifying ADG1_ADG2_responder_params for efficiency reasons. It changes the way varnce_x_(1/2) is set when wp2 > w_tol_sqd and xp2 <= x_tol. Previously in that case it set the variances to 0, but now it sets them to xp2 since xp2 ~= 0 in that case anyway. This allows the where statement to have only two cases, and less cases is more efficient. This is BIT_CHANGING, but only affect the sensitive cases and passes the G unit tests. larson-group/clubb#855 2019-07-11 18:37:35 -05001f2facc146cb5190975cca5a6387fb6e79e72d25Modifying ADG1_ADG2_responder_params for efficiency reasons. It changes the way varnce_x_(1/2) is set when wp2 > w_tol_sqd and xp2 <= x_tol. Previously in that case it set the variances to 0, but now it sets them to xp2 since xp2 ~= 0 in that case anyway. This allows the where statement to have only two cases, and less cases is more efficient. This is BIT_CHANGING, but only affect the sensitive cases and passes the G unit tests. larson-group/clubb#855editadg1_adg2_3d_luhar_pdf.F90pdf_closure_module.F907036e850e9581d27aa4e2915a2e8dc7da7c77d631562956898000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduReplacing the local variables used in pdf_closure_module with references to the variables in pdf_params which they are meant to be stored in. This removes the need to copy the local variables into the pdf_params structure at the end, saving about 3% runtime. This is not bit changing, but does make the code a little uglier. larson-group/clubb#855 2019-07-12 13:41:38 -05007036e850e9581d27aa4e2915a2e8dc7da7c77d63Replacing the local variables used in pdf_closure_module with references to the variables in pdf_params which they are meant to be stored in. This removes the need to copy the local variables into the pdf_params structure at the end, saving about 3% runtime. This is not bit changing, but does make the code a little uglier. larson-group/clubb#855editpdf_closure_module.F90pdf_utilities.F90new_tsdadg_pdf.F90pdf_closure_module.F90adg1_adg2_3d_luhar_pdf.F90new_pdf_main.F90a6744484daca24377722de22d516fe1931d6ac671562976298000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking procedure calls consistent with procedure definitions. Required updating after previous pdf_parameter related commit. larson-group/clubb#855 2019-07-12 19:04:58 -0500a6744484daca24377722de22d516fe1931d6ac67Making procedure calls consistent with procedure definitions. Required updating after previous pdf_parameter related commit. larson-group/clubb#855editpdf_closure_module.F90editpdf_utilities.F90editadg1_adg2_3d_luhar_pdf.F90editnew_pdf_main.F90editnew_tsdadg_pdf.F90LY93_pdf.F903d127ce9735789aaa773085437c70ea0ad7febb91562976519000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMissed one 2019-07-12 19:08:39 -05003d127ce9735789aaa773085437c70ea0ad7febb9Missed oneeditLY93_pdf.F90calc_pressure.F90e6b21ea2242dbb344bf34cebb0bbd9a3e7ea77311563325211000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI have added a new file, calc_pressure.F90, which contains code for initializing and updating the vertical profile of pressure and exner. 2019-07-16 20:00:11 -0500e6b21ea2242dbb344bf34cebb0bbd9a3e7ea7731I have added a new file, calc_pressure.F90, which contains code for initializingaddcalc_pressure.F90advance_clubb_core_module.F90clubb_api_module.F90calc_pressure.F90402505b5c37287ccd4d00e615b00b20c0c1becae1563416347000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI updated CLUBB so that pressure is updated after mean fields have been advanced every timestep. The results are BIT_CHANGING. 2019-07-17 21:19:07 -0500402505b5c37287ccd4d00e615b00b20c0c1becaeI updated CLUBB so that pressure is updated after mean fields have beeneditadvance_clubb_core_module.F90editclubb_api_module.F90editcalc_pressure.F90advance_wp2_wp3_module.F90advance_clubb_core_module.F90model_flags.F90clubb_api_module.F90db9f32467f1f0d7cd7a8f25054508fa61e3837581563833748000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduRemoving gmres code. The files gmres_wrap.F90, gmres_cache.F90, and csr_matrix_module.F90 have been removed, and any sections of code which refer to or are needed only for gmres have been removed as well. larson-group/clubb#855 2019-07-22 17:15:48 -0500db9f32467f1f0d7cd7a8f25054508fa61e383758Removing gmres code. The files gmres_wrap.F90, gmres_cache.F90, and csr_matrix_module.F90 have been removed, and any sections of code which refer to or are needed only for gmres have been removed as well. larson-group/clubb#855editadvance_clubb_core_module.F90editclubb_api_module.F90editmodel_flags.F90editadvance_wp2_wp3_module.F90gmres_wrap.F90gmres_cache.F90csr_matrix_module.F90427b92e4f01613d6f91ab932b002d7524a4a69fe1563838713000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduForgot to run previous commit with --all, so the gmres files were not removed. larson-group/clubb#855 2019-07-22 18:38:33 -0500427b92e4f01613d6f91ab932b002d7524a4a69feForgot to run previous commit with --all, so the gmres files were not removed. larson-group/clubb#855deletegmres_wrap.F90deletecsr_matrix_module.F90deletegmres_cache.F90advance_clubb_core_module.F90stats_variables.F90parameters_tunable.F90stats_zm_module.F90parameter_indices.F902d454818095f731d3864a0438459c86fc6bc48e41563920145000http://carson.math.uwm.edu/jenkins/user/guozhunguozhunguozhun@lasg.iap.ac.cnissue #842 We added two new tunuable parameters: C_invrs_tau_N2_xp2 and C_invrs_tau_N2_wp2. e.g. invrs_tau_wp2_zm = invrs_tau_zm_simp + C_invrs_tau_N2_wp2 * sqrt( max( zero_threshold,zt2zm( zm2zt( brunt_vaisala_freq_sqd ) ) - 1e-4_core_rknd) ). Correspondingly, invrs_tau_wp2_zm and invrs_tau_xp2_zm are used in advance_wp2_wp3 and advance_xp2_xpyp respectively. Also, tau_wp2_zm and tau_xp2_zm are added in output list. 2019-07-23 17:15:45 -05002d454818095f731d3864a0438459c86fc6bc48e4issue #842editadvance_clubb_core_module.F90editstats_variables.F90editparameter_indices.F90editparameters_tunable.F90editstats_zm_module.F90tunable_parameters.indb0b8dc2e7fa619f1a16a90499015816359d0b761563986631000http://carson.math.uwm.edu/jenkins/user/guozhunguozhunguozhun@lasg.iap.ac.cnWe added two new tunuable parameters: C_invrs_tau_N2_xp2 and C_invrs_tau_N2_wp2. e.g. invrs_tau_wp2_zm = invrs_tau_zm_simp + C_invrs_tau_N2_wp2 * sqrt( max( zero_threshold,zt2zm( zm2zt( brunt_vaisala_freq_sqd ) ) - 1e-4_core_rknd) ). Correspondingly, invrs_tau_wp2_zm and invrs_tau_xp2_zm are used in advance_wp2_wp3 and advance_xp2_xpyp respectively. Also, tau_wp2_zm and tau_xp2_zm are added in output list. issue #842 2019-07-24 11:43:51 -0500db0b8dc2e7fa619f1a16a90499015816359d0b76We added two new tunuable parameters: C_invrs_tau_N2_xp2 and C_invrs_tau_N2_wp2. e.g. invrs_tau_wp2_zm = invrs_tau_zm_simp + C_invrs_tau_N2_wp2 * sqrt( max( zero_threshold,zt2zm( zm2zt( brunt_vaisala_freq_sqd ) ) - 1e-4_core_rknd) ). Correspondingly, invrs_tau_wp2_zm and invrs_tau_xp2_zm are used in advance_wp2_wp3 and advance_xp2_xpyp respectively.edittunable_parameters.inparameters_tunable.F90advance_clubb_core_module.F90stats_zm_module.F90stats_variables.F90parameter_indices.F90ea09dc1146deb9249293bae86a80288eb8cf98ce1563986631000http://carson.math.uwm.edu/jenkins/user/guozhunguozhunguozhun@lasg.iap.ac.cnWe added two new tunuable parameters: C_invrs_tau_N2_xp2 and C_invrs_tau_N2_wp2. e.g. invrs_tau_wp2_zm = invrs_tau_zm_simp + C_invrs_tau_N2_wp2 * sqrt( max( zero_threshold,zt2zm( zm2zt( brunt_vaisala_freq_sqd ) ) - 1e-4_core_rknd) ). Correspondingly, invrs_tau_wp2_zm and invrs_tau_xp2_zm are used in advance_wp2_wp3 and advance_xp2_xpyp respectively. Also, tau_wp2_zm and tau_xp2_zm are added in output list. issue #842 2019-07-24 11:43:51 -0500ea09dc1146deb9249293bae86a80288eb8cf98ceWe added two new tunuable parameters: C_invrs_tau_N2_xp2 and C_invrs_tau_N2_wp2. e.g. invrs_tau_wp2_zm = invrs_tau_zm_simp + C_invrs_tau_N2_wp2 * sqrt( max( zero_threshold,zt2zm( zm2zt( brunt_vaisala_freq_sqd ) ) - 1e-4_core_rknd) ). Correspondingly, invrs_tau_wp2_zm and invrs_tau_xp2_zm are used in advance_wp2_wp3 and advance_xp2_xpyp respectively.editparameters_tunable.F90editadvance_clubb_core_module.F90editparameter_indices.F90editstats_zm_module.F90editstats_variables.F90tunable_parameters.infeaaa15913dcbe41b21b087b7cdb4f55dc191f0a1563986774000http://carson.math.uwm.edu/jenkins/user/guozhunguozhunguozhun@lasg.iap.ac.cnWe added two new tunuable parameters: C_invrs_tau_N2_xp2 and C_invrs_tau_N2_wp2. e.g. invrs_tau_wp2_zm = invrs_tau_zm_simp + C_invrs_tau_N2_wp2 * sqrt( max( zero_threshold,zt2zm( zm2zt( brunt_vaisala_freq_sqd ) ) - 1e-4_core_rknd) ). Correspondingly, invrs_tau_wp2_zm and invrs_tau_xp2_zm are used in advance_wp2_wp3 and advance_xp2_xpyp respectively. 1. Some typos are corrected. 2. New tunuable parameters are added in files named errer_$casename.in (issue #842) 2019-07-24 11:46:14 -0500feaaa15913dcbe41b21b087b7cdb4f55dc191f0aWe added two new tunuable parameters: C_invrs_tau_N2_xp2 and C_invrs_tau_N2_wp2. e.g. invrs_tau_wp2_zm = invrs_tau_zm_simp + C_invrs_tau_N2_wp2 * sqrt( max( zero_threshold,zt2zm( zm2zt( brunt_vaisala_freq_sqd ) ) - 1e-4_core_rknd) ). Correspondingly, invrs_tau_wp2_zm and invrs_tau_xp2_zm are used in advance_wp2_wp3 and advance_xp2_xpyp respectively. 1. Some typos are corrected. 2. New tunuable parameters are added in files named errer_$casename.in (issue #842)edittunable_parameters.inadvance_clubb_core_module.F90stats_zm_module.F90parameters_tunable.F90stats_variables.F90e3ffdf57d28b9601a073195721f51f94b85ef2cd1563986774000http://carson.math.uwm.edu/jenkins/user/guozhunguozhunguozhun@lasg.iap.ac.cnWe added two new tunuable parameters: C_invrs_tau_N2_xp2 and C_invrs_tau_N2_wp2. e.g. invrs_tau_wp2_zm = invrs_tau_zm_simp + C_invrs_tau_N2_wp2 * sqrt( max( zero_threshold,zt2zm( zm2zt( brunt_vaisala_freq_sqd ) ) - 1e-4_core_rknd) ). Correspondingly, invrs_tau_wp2_zm and invrs_tau_xp2_zm are used in advance_wp2_wp3 and advance_xp2_xpyp respectively. 1. Some typos are corrected. 2. New tunuable parameters are added in files named errer_$casename.in (issue #842) 2019-07-24 11:46:14 -0500e3ffdf57d28b9601a073195721f51f94b85ef2cdWe added two new tunuable parameters: C_invrs_tau_N2_xp2 and C_invrs_tau_N2_wp2. e.g. invrs_tau_wp2_zm = invrs_tau_zm_simp + C_invrs_tau_N2_wp2 * sqrt( max( zero_threshold,zt2zm( zm2zt( brunt_vaisala_freq_sqd ) ) - 1e-4_core_rknd) ). Correspondingly, invrs_tau_wp2_zm and invrs_tau_xp2_zm are used in advance_wp2_wp3 and advance_xp2_xpyp respectively. 1. Some typos are corrected. 2. New tunuable parameters are added in files named errer_$casename.in (issue #842)editadvance_clubb_core_module.F90editstats_zm_module.F90editparameters_tunable.F90editstats_variables.F90tunable_parameters.inbec3a8273b471c83c78f2f475e54ddb7511ebed11563987351000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdate tunable_parameters.in default C_invrs_tau_N2_xp2 = 0.2, it will let tau_zm=tau_xp2_zm=tau_wp2_tau 2019-07-24 11:55:51 -0500bec3a8273b471c83c78f2f475e54ddb7511ebed1Update tunable_parameters.inedittunable_parameters.inadvance_clubb_core_module.F905e7fdb331acf7bb7b479c37b1195df9b3acefc9f1563988934000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdate advance_clubb_core_module.F90 Correct my accidental deletion 2019-07-24 12:22:14 -05005e7fdb331acf7bb7b479c37b1195df9b3acefc9fUpdate advance_clubb_core_module.F90editadvance_clubb_core_module.F90mixing_length.F90advance_clubb_core_module.F90b3c3dc624ed09e4b8021ff3fd7596a9603e6b2911564098351000http://carson.math.uwm.edu/jenkins/user/guozhunguozhunguozhun@lasg.iap.ac.cnWe put Lscale's calculation into mixing_length.F90 (subroutine calc_Lscale_directly) 2019-07-25 18:45:51 -0500b3c3dc624ed09e4b8021ff3fd7596a9603e6b291We put Lscale's calculation into mixing_length.F90 (subroutine calc_Lscale_directly)editmixing_length.F90editadvance_clubb_core_module.F90tunable_parameters.in3ac916ce38c33c257203189f98243a14c17465771564098351000http://carson.math.uwm.edu/jenkins/user/guozhunguozhunguozhun@lasg.iap.ac.cnWe put Lscale's calculation into mixing_length.F90 (subroutine calc_Lscale_directly) 2019-07-25 18:45:51 -05003ac916ce38c33c257203189f98243a14c1746577We put Lscale's calculation into mixing_length.F90 (subroutine calc_Lscale_directly)edittunable_parameters.inmono_flux_limiter.F90185f2febb78c667d4bd6d22da4400587abf873d91564166838000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduEfficiency improvements to calc_turb_adv_range, more specifically the parts which split w into upward and downward components. This adds a case to zero out upward and downward components for values of w that are too small to matter, and now utilizes mkl_vml math functions to improve vectorization. These mkl_vml functions are only used when compiled with MKL, specified by adding -DMKL to compiler configuration files. This is BIT_CHANGING, plots only differ in the usual sensitive cases, and the budgets, G_unit_tests and time step tests all pass. larson-group/clubb#855 2019-07-26 13:47:18 -0500185f2febb78c667d4bd6d22da4400587abf873d9Efficiency improvements to calc_turb_adv_range, more specifically the parts which split w into upward and downward components. This adds a case to zero out upward and downward components for values of w that are too small to matter, and now utilizes mkl_vml math functions to improve vectorization. These mkl_vml functions are only used when compiled with MKL, specified by adding -DMKL to compiler configuration files. This is BIT_CHANGING, plots only differ in the usual sensitive cases, and the budgets, G_unit_tests and time step tests all pass. larson-group/clubb#855editmono_flux_limiter.F90mono_flux_limiter.F904e11b0aaa1aac032723d34da281c8604363d37d41564427207000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduThis should fix the uninitialized variables test. mean_vert_vel_up_down was using the upper and lower grid levels, but calc_mean_w_up_down_component was not setting them. These levels aren't actually used by the algorithm in calc_turb_adv_range, but I made calc_mean_w_up_down_component set them to zero anyway since it seems like the simplest and safest solution. larson-group/clubb#855 2019-07-29 14:06:47 -05004e11b0aaa1aac032723d34da281c8604363d37d4This should fix the uninitialized variables test. mean_vert_vel_up_down was using the upper and lower grid levels, but calc_mean_w_up_down_component was not setting them. These levels aren't actually used by the algorithm in calc_turb_adv_range, but I made calc_mean_w_up_down_component set them to zero anyway since it seems like the simplest and safest solution. larson-group/clubb#855editmono_flux_limiter.F90advance_clubb_core_module.F90parameters_tunable.F90parameter_indices.F9011e94b26a81887e767bbe3088dcf879951147d8d1564427709000http://carson.math.uwm.edu/jenkins/user/guozhunguozhunguozhun@lasg.iap.ac.cnAn additional damping is added to the invrs_tau term in the C8 equation. ticket #842 invrs_tau_wp3_zm = invrs_tau_wp2_zm & + C_invrs_tau_N2_clear_wp3 * sqrt( max( zero_threshold, & zt2zm( zm2zt( brunt_vaisala_freq_sqd ) ) ) ) & * min(one, max(zero_threshold, one & - ( (ice_supersat_frac_zm - 0.005_core_rknd )/(0.01- 0.005_core_rknd) ) ) ) C_invrs_tau_N2_clear_wp3 is tunable with its defalut value of 0. 2019-07-29 14:15:09 -050011e94b26a81887e767bbe3088dcf879951147d8dAn additional damping is added to the invrs_tau term in the C8 equation. ticket #842editadvance_clubb_core_module.F90editparameter_indices.F90editparameters_tunable.F90tunable_parameters.in5bd7c2c011fc0f116f9f3694b45767b3ee37641f1564427709000http://carson.math.uwm.edu/jenkins/user/guozhunguozhunguozhun@lasg.iap.ac.cnAn additional damping is added to the invrs_tau term in the C8 equation. ticket #842 invrs_tau_wp3_zm = invrs_tau_wp2_zm & + C_invrs_tau_N2_clear_wp3 * sqrt( max( zero_threshold, & zt2zm( zm2zt( brunt_vaisala_freq_sqd ) ) ) ) & * min(one, max(zero_threshold, one & - ( (ice_supersat_frac_zm - 0.005_core_rknd )/(0.01- 0.005_core_rknd) ) ) ) C_invrs_tau_N2_clear_wp3 is tunable with its defalut value of 0. 2019-07-29 14:15:09 -05005bd7c2c011fc0f116f9f3694b45767b3ee37641fAn additional damping is added to the invrs_tau term in the C8 equation. ticket #842edittunable_parameters.inmono_flux_limiter.F9026d56dd9fc34a7a2c2a75531877ce80e5d0dfdd41564431150000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding comment because commit 561fa037e7c3c326bc4bd71b6fc486e5d2a46065 was BIT_CHANGING, but missing the commit message specifying that. It was bit changing because the upper and lower levels of mean_w_up and mean_w_down are being output to stats as of commit 0b3ec0d5fc4b89b4a6f34964af3cfda8cb89b9f7, so changing the upper and lower level values changed the stats output, even though those values are not used in any calculations. 2019-07-29 15:12:30 -050026d56dd9fc34a7a2c2a75531877ce80e5d0dfdd4Adding comment because commit 561fa037e7c3c326bc4bd71b6fc486e5d2a46065 was BIT_CHANGING, but missing the commit message specifying that. It was bit changing because the upper and lower levels of mean_w_up and mean_w_down are being output to stats as of commit 0b3ec0d5fc4b89b4a6f34964af3cfda8cb89b9f7, so changing the upper and lower level values changed the stats output, even though those values are not used in any calculations.editmono_flux_limiter.F90stats_variables.F90advance_clubb_core_module.F90stats_zm_module.F902b595277fc89333b4662fbe5f8ad42cf85f609e71564532469000http://carson.math.uwm.edu/jenkins/user/guozhunguozhunguozhun@lasg.iap.ac.cnWe use zt2zm(ice_supersat_frac) replace ice_supersat_frac_zm in the additional damping of C8. Tau_wp3_zm is added in output list. Ticket #842 2019-07-30 19:21:09 -05002b595277fc89333b4662fbe5f8ad42cf85f609e7We use zt2zm(ice_supersat_frac) replace ice_supersat_frac_zm in the additional damping of C8.editstats_variables.F90editadvance_clubb_core_module.F90editstats_zm_module.F90adg1_adg2_3d_luhar_pdf.F9080905eb2df7a944184abc1c502abe3ce7555da7e1564601051000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduChanging ADG1_ADG2_responder_params to use a do loop with ifs instead of a where statement. This is about 1.5% faster and is bit identical. larson-group/clubb#855 2019-07-31 14:24:11 -050080905eb2df7a944184abc1c502abe3ce7555da7eChanging ADG1_ADG2_responder_params to use a do loop with ifs instead of a where statement. This is about 1.5% faster and is bit identical. larson-group/clubb#855editadg1_adg2_3d_luhar_pdf.F90calc_pressure.F907d01c3630acdd2ca14d9201b66aff0d81502d05f1564611614000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduPulling the calculation of p_in_Pa(_zm) out of the vertical loop in update_pressure, and precalculates one/kappa. This improved vectorization capabilities of the calculation of exponents, which is slow so that's important. Also added the option to use MKL_VML functions if -DMKL is specified, which is slightly more efficient. This saves about 1.5-2.5% and is bit identical if not using MKL. larson-group/clubb#855 2019-07-31 17:20:14 -05007d01c3630acdd2ca14d9201b66aff0d81502d05fPulling the calculation of p_in_Pa(_zm) out of the vertical loop in update_pressure, and precalculates one/kappa. This improved vectorization capabilities of the calculation of exponents, which is slow so that's important. Also added the option to use MKL_VML functions if -DMKL is specified, which is slightly more efficient. This saves about 1.5-2.5% and is bit identical if not using MKL. larson-group/clubb#855editcalc_pressure.F90adg1_adg2_3d_luhar_pdf.F90a60a7deb0a1df72dfa3601a043b4ddb001daab2c1564611783000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduRenaming width_factor to width_factor_1 to indicate that it is intended for use with the first pdf component, (two-width_factor_1) is the value for the second component. larson-group/clubb#855 2019-07-31 17:23:03 -0500a60a7deb0a1df72dfa3601a043b4ddb001daab2cRenaming width_factor to width_factor_1 to indicate that it is intended for use with the first pdf component, (two-width_factor_1) is the value for the second component. larson-group/clubb#855editadg1_adg2_3d_luhar_pdf.F90pdf_closure_module.F90915547ce2354ea058ecb18b93ef84775bc2e17eb1564696319000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduEfficiency improvements to transform_pdf_chi_eta_component. Moving the where statement to if statement inside loop to avoid sqrt operations. Reducing number of divide operations, and putting some code in a loop which reduces cache misses. This is BIT_CHANGING, but not answer changing, plots only differ slightly in the most sensitive cases. larson-group/clubb#855. 2019-08-01 16:51:59 -0500915547ce2354ea058ecb18b93ef84775bc2e17ebEfficiency improvements to transform_pdf_chi_eta_component. Moving the where statement to if statement inside loop to avoid sqrt operations. Reducing number of divide operations, and putting some code in a loop which reduces cache misses. This is BIT_CHANGING, but not answer changing, plots only differ slightly in the most sensitive cases. larson-group/clubb#855.editpdf_closure_module.F90pdf_closure_module.F901f578b33392b16cfa7367aa6a114c1f7352d984e1564708347000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduModifying calc_cloud_frac_component to optionally use mkl_vml functions. Added a different version of the procedure to handle the liquid cloud fraction specifically, so the ice_supersat_frac could remain as is. The structure of the procedure when using the MKL functions is based on the changes to calc_turb_adv_range in commit 0b3ec0d5fc4b89b4a6f34964af3cfda8cb89b9f7, since I've already tested that well and it seems to make sense to keep the code similar if it does similar things. This reduces runtime by about 2% when using MKL functions and about 0.5% otherwise. The procedures also use precalculated inverses where possible, so the results are BIT_CHANGING, but not answer changing. larson-group/clubb#855 2019-08-01 20:12:27 -05001f578b33392b16cfa7367aa6a114c1f7352d984eModifying calc_cloud_frac_component to optionally use mkl_vml functions. Added a different version of the procedure to handle the liquid cloud fraction specifically, so the ice_supersat_frac could remain as is. The structure of the procedure when using the MKL functions is based on the changes to calc_turb_adv_range in commit 0b3ec0d5fc4b89b4a6f34964af3cfda8cb89b9f7, since I've already tested that well and it seems to make sense to keep the code similar if it does similar things. This reduces runtime by about 2% when using MKL functions and about 0.5% otherwise. The procedures also use precalculated inverses where possible, so the results are BIT_CHANGING, but not answer changing. larson-group/clubb#855editpdf_closure_module.F90advance_xm_wpxp_module.F904504e3baf5bf7fec8011d83e2d8656712d9946071565219850000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduRefactoring the lhs and rhs setup procedures for xm_wpxp. There are a number of lhs terms that are very general, and used by all the lhs matricies. The code now calculates these terms in a new procedure calc_xm_wpxp_lhs_terms and passes those terms into the lhs setup. The same sort of thing is done with the first pressure terms and turbulent advection terms, those terms are shared between pairs of lhs/rhs calls. This is BIT_CHANGING, but is not answer changing. See comment on Jul 3 on ticket larson-group/clubb#855 2019-08-07 18:17:30 -05004504e3baf5bf7fec8011d83e2d8656712d994607Refactoring the lhs and rhs setup procedures for xm_wpxp. There are a number of lhs terms that are very general, and used by all the lhs matricies. The code now calculates these terms in a new procedure calc_xm_wpxp_lhs_terms and passes those terms into the lhs setup. The same sort of thing is done with the first pressure terms and turbulent advection terms, those terms are shared between pairs of lhs/rhs calls. This is BIT_CHANGING, but is not answer changing. See comment on Jul 3 on ticket larson-group/clubb#855editadvance_xm_wpxp_module.F90advance_clubb_core_module.F90eb88df13288af2a9454f5d34f20fdda75b3ac19e1565303811000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdate advance_clubb_core_module.F90 2019-08-08 17:36:51 -0500eb88df13288af2a9454f5d34f20fdda75b3ac19eUpdate advance_clubb_core_module.F90editadvance_clubb_core_module.F90advance_clubb_core_module.F9062f72f15b94edb88e01a1bd031faa32e321edbf11565303976000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdate advance_clubb_core_module.F90 2019-08-08 17:39:36 -050062f72f15b94edb88e01a1bd031faa32e321edbf1Update advance_clubb_core_module.F90editadvance_clubb_core_module.F90advance_clubb_core_module.F90model_flags.F90advance_helper_module.F90ae9c7332c1bbdd55ff49f2a4974fcdb7ce709f061565382207000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduI switched on direct diagnosis of tau rather than Lscale. That is, I set l_diag_Lscale_from_tau = .true. Thus, this commit is BIT_CHANGING. Because diagnosing tau changes answers, I retuned CLUBB, taking the opportunity to add some features seem better justified. For instance, we now damp wp2 using tke (l_damp_wp2_using_em = .true.) because doing so is more standard in turbulence modeling and because it may help reduce damping on Sc clouds. C7 is allowed to become larger in statically stable layers (l_use_C7_Richardson = .true.) because that is what the LES of Heinze show, and because doing so might help limit gravity waves above cloud. Many parameters have been retuned. I set C2rtthl = C2rt = C2thl because it seems more justifiable and because doing so produces the correct sign of wprtp_bp in Cu layers. Also, the "b" parameters have been set equal to the non-"b" parameters in order to reduce the number of tunable parameters. The "b" parameters were based on skewness, which is hard to control and tune. Instead, with this revised version, the tuning parameters are based mostly on thlm, which is more robust. I set C15=0 because this term is complex and hard to justify. c_K8 was increased because it smooths the solutions without dominating the wp3 budget. beta was reduced in order to make wp2xp larger and wpxp2 smaller. I included a bug fix to Cx_fnc_Richardson, which prevents C7 and C11 from exceeding the maximum set by Cx_max. The brunt vaisala frequency is reduced for slightly stable layers in order to allow Sc layers to remain well mixed. Further tuning is needed to reduce oscillations and temporal noise. Also, the momentum fields --- upwp, vpwp, up2, and vp2 --- need to be retuned. Otherwise, the results are comparable to the prior default. We're expecting a speed-up of 10% to 15% because computing CLUBB's mixing length directly is so costly. For #842. 2019-08-09 15:23:27 -0500ae9c7332c1bbdd55ff49f2a4974fcdb7ce709f06I switched on direct diagnosis of tau rather than Lscale.editmodel_flags.F90editadvance_helper_module.F90editadvance_clubb_core_module.F90configurable_model_flags.intunable_parameters.inc034fc21d9fbdc55e15091533e6ea709562af28f1565382207000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduI switched on direct diagnosis of tau rather than Lscale. That is, I set l_diag_Lscale_from_tau = .true. Thus, this commit is BIT_CHANGING. Because diagnosing tau changes answers, I retuned CLUBB, taking the opportunity to add some features seem better justified. For instance, we now damp wp2 using tke (l_damp_wp2_using_em = .true.) because doing so is more standard in turbulence modeling and because it may help reduce damping on Sc clouds. C7 is allowed to become larger in statically stable layers (l_use_C7_Richardson = .true.) because that is what the LES of Heinze show, and because doing so might help limit gravity waves above cloud. Many parameters have been retuned. I set C2rtthl = C2rt = C2thl because it seems more justifiable and because doing so produces the correct sign of wprtp_bp in Cu layers. Also, the "b" parameters have been set equal to the non-"b" parameters in order to reduce the number of tunable parameters. The "b" parameters were based on skewness, which is hard to control and tune. Instead, with this revised version, the tuning parameters are based mostly on thlm, which is more robust. I set C15=0 because this term is complex and hard to justify. c_K8 was increased because it smooths the solutions without dominating the wp3 budget. beta was reduced in order to make wp2xp larger and wpxp2 smaller. I included a bug fix to Cx_fnc_Richardson, which prevents C7 and C11 from exceeding the maximum set by Cx_max. The brunt vaisala frequency is reduced for slightly stable layers in order to allow Sc layers to remain well mixed. Further tuning is needed to reduce oscillations and temporal noise. Also, the momentum fields --- upwp, vpwp, up2, and vp2 --- need to be retuned. Otherwise, the results are comparable to the prior default. We're expecting a speed-up of 10% to 15% because computing CLUBB's mixing length directly is so costly. For #842. 2019-08-09 15:23:27 -0500c034fc21d9fbdc55e15091533e6ea709562af28fI switched on direct diagnosis of tau rather than Lscale.editconfigurable_model_flags.inedittunable_parameters.incalc_pressure.F90a3f5913c59b8c599216b06beb6650b779783f0d11565627451000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI updated the pressure initialization for cases that use sounding that is given in terms of pressure coordinates so that the initial profile of pressure is consistent with the pressure update code. This code is BIT_CHANGING for cases that use pressure coordinates in their soundings (MC3E, TWP-ICE, and the CGILS cases). 2019-08-12 11:30:51 -0500a3f5913c59b8c599216b06beb6650b779783f0d1I updated the pressure initialization for cases that use sounding that is giveneditcalc_pressure.F90calc_pressure.F90e573fabcb13ba98b412ce4ce75ade6b6f2ec50631565639019000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI changed the function calculate_thvm from a pre-defined vector of size nz to an elemental function. The results in GrADS output files from this revision are an exact match to the result in GrADS output files from the previous revision for all cases. A quick test of running BOMEX 5 times both before and after the changes showed a 1.16% speed increase for the new version with the elemental function. 2019-08-12 14:43:39 -0500e573fabcb13ba98b412ce4ce75ade6b6f2ec5063I changed the function calculate_thvm from a pre-defined vector of size nz toeditcalc_pressure.F90advance_clubb_core_module.F9051a86a3f221fffeef2d437cbe76a1445816cc3b21565640439000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI updated the calculation of thvm in advance_clubb_core to use the calculate_thvm function. The results in GrADS output files from this revision are an exact match to the results in GrADS output files from the previous revision for all cases. 2019-08-12 15:07:19 -050051a86a3f221fffeef2d437cbe76a1445816cc3b2I updated the calculation of thvm in advance_clubb_core to use theeditadvance_clubb_core_module.F90stats_variables.F909a3e6d37f6350cfbe66595183c646941b367559e1565650355000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding SAVE attribute to some stats variables, as it was causing compiler errors when using the newest version of the gfortran compiler. Also commenting out Lapack library dependency from gfortran config file, this required additional Lapack source files be added. Now, no Lapack library files are required to compile CLUBB, whereas before, the source was being compiled, but the missing dependencies we're being added from libraries. This is BIT_CHANGING in all cases when using the gfortran compiler, but only in some cases when using the ifort compiler. Some plots, such as rico, are noticably different when compiled with gfortran, but are bit identical when compiled with ifort. The intel implementation of Lapack used by the ifort compiler must be more similar to the source Lapack than was the Lapack library that was being used for the gfortran compiler. 2019-08-12 17:52:35 -05009a3e6d37f6350cfbe66595183c646941b367559eAdding SAVE attribute to some stats variables, as it was causing compiler errors when using the newest version of the gfortran compiler. Also commenting out Lapack library dependency from gfortran config file, this required additional Lapack source files be added. Now, no Lapack library files are required to compile CLUBB, whereas before, the source was being compiled, but the missing dependencies we're being added from libraries. This is BIT_CHANGING in all cases when using the gfortran compiler, but only in some cases when using the ifort compiler. Some plots, such as rico, are noticably different when compiled with gfortran, but are bit identical when compiled with ifort. The intel implementation of Lapack used by the ifort compiler must be more similar to the source Lapack than was the Lapack library that was being used for the gfortran compiler.editstats_variables.F90advance_xp2_xpyp_module.F90973528097e0ce042fbd3820dc7fef4bab9d930f51565657839000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding a subroutine in advance_xp2_xpyp to calculate the turbulent advection terms and modying the rhs and lhs setup procedures to accept these turbulent advection terms as inputs. Before, the turbulent advection terms were calcualted within the rhs and lhs setup procedures, but this resulted in expensive redundant calculations. larson-group/clubb#855 2019-08-12 19:57:19 -0500973528097e0ce042fbd3820dc7fef4bab9d930f5Adding a subroutine in advance_xp2_xpyp to calculate the turbulent advection terms and modying the rhs and lhs setup procedures to accept these turbulent advection terms as inputs. Before, the turbulent advection terms were calcualted within the rhs and lhs setup procedures, but this resulted in expensive redundant calculations. larson-group/clubb#855editadvance_xp2_xpyp_module.F90setup_clubb_pdf_params.F908e208d5eb9ed5621198bc25ed7ce599b6fd3b32c1565813536000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduChanging where statement that was causing floating point errors to a do with if's. This should allow code compiled with the newest version of gfortran to run to completion for microphysics enabled cases. This is BIT_CHANING in microphysics cases, but the values of the output arrays of the only changed subroutine only differ starting around roughly the 13th decimal place. larson-group/clubb#859 larson-group/sys_admin#626 2019-08-14 15:12:16 -05008e208d5eb9ed5621198bc25ed7ce599b6fd3b32cChanging where statement that was causing floating point errors to a do with if's. This should allow code compiled with the newest version of gfortran to run to completion for microphysics enabled cases. This is BIT_CHANING in microphysics cases, but the values of the output arrays of the only changed subroutine only differ starting around roughly the 13th decimal place. larson-group/clubb#859 larson-group/sys_admin#626editsetup_clubb_pdf_params.F90adg1_adg2_3d_luhar_pdf.F9041a78a1c734861469e5bcd2469a6f150563b56e61565886799000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am committing a test where I changed subroutine ADG1_w_closure from using nested where statements to using if statements within the context of an elemental subroutine. My notes are below: =============================================================================== Here's an intriguing idea to try in place of nested "where" statements. The article at: https://data-science-austria.at/2018/12/24/the-need-for-speed-part-2-c-vs-fortran-vs-c/ says that using FORTRAN ELEMENTAL subroutines and functions is just as fast as using FORTRAN serial loops with -O3 optimization (which is what we've been doing for optimization). The use of elemental subprograms contains many advantages: 1) The subprogram becomes much more versatile, because it can be used for scalars as well as arrays of varying sizes and dimensions. 2) In our case, the changesets become easier to follow, as they are basically a change from where statements to if ... then statements. There are no additional do loops and loop indices needed. These additional statements and indices can be confusing when comparing code differences and they clutter-up (a.k.a. uglify) subprograms. 3) The article states that this method should be just as fast for vectors of size 1000 and less. For CLUBB, this would be the number of height levels, which don't normally exceed 128. I tested the old version (where statements) and the new version for multiple runs of BOMEX and ARM, and the timings were equivalent. 4) This avoids the problem of code entering the portion of a "where" statement that it shouldn't be and crashing when floating point trapping is enabled. The use of elemental subprograms has the following limitations: 1) All input and output variables must be of the same size and dimension. In other words, whatever code is calling the elemental subroutine must feed it, as well as take as output, either all scalar values, or all vectors of size nz, or all 2-D arrays of size nx by ny, etc. 2) Elemental subprograms are also pure subprograms, so they have all the restrictions of pure subprograms (no print statements, etc.). ================================================================================ The results in GrADS output files from this revision are an exact match to the results in GrADS output files from the previous revision for all cases. Obligatory Larson Group GitHub Issue Reference: #859. 2019-08-15 11:33:19 -050041a78a1c734861469e5bcd2469a6f150563b56e6I am committing a test where I changed subroutine ADG1_w_closureeditadg1_adg2_3d_luhar_pdf.F90advance_xp2_xpyp_module.F9002066c0bf79abbe15aac432b24aee2a17798b09d1566416566000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduChanging determination of threshold used to clip large values of rtp2. Before it was possible that this large value clipping introduced a value before tolerance, if rtm was too small. Causing addition problems and potentially crashes. This is BIT_CHANGING. larson-group/clubb#862 2019-08-21 14:42:46 -050002066c0bf79abbe15aac432b24aee2a17798b09dChanging determination of threshold used to clip large values of rtp2. Before it was possible that this large value clipping introduced a value before tolerance, if rtm was too small. Causing addition problems and potentially crashes. This is BIT_CHANGING. larson-group/clubb#862editadvance_xp2_xpyp_module.F90pdf_closure_module.F90e7c7ca60b79b960a8d9b457dd866359044bb23ce1566428123000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFinally fixing line length error in pdf_closure 2019-08-21 17:55:23 -0500e7c7ca60b79b960a8d9b457dd866359044bb23ceFinally fixing line length error in pdf_closureeditpdf_closure_module.F90lapack_interfaces.F90matrix_operations.F90lapack_wrap.F903cdd4d6ac73bb48c637368df6ac83377017914ac1566603423000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding more Lapack source files, and a new file to interface with Lapack routines in general. This allows us to call a general interface procedure that can handle single or double precision routines. This should fix the ifort bug we've been seeing, and should be a more robust way to handle this double/single precision situation in general. Works with all compilers, and in single or double precision, producing bit identical results. See larson-group/clubb#861 2019-08-23 18:37:03 -05003cdd4d6ac73bb48c637368df6ac83377017914acAdding more Lapack source files, and a new file to interface with Lapack routines in general. This allows us to call a general interface procedure that can handle single or double precision routines. This should fix the ifort bug we've been seeing, and should be a more robust way to handle this double/single precision situation in general. Works with all compilers, and in single or double precision, producing bit identical results. See larson-group/clubb#861addlapack_interfaces.F90editmatrix_operations.F90editlapack_wrap.F90advance_xm_wpxp_module.F90feb1fe6742605fd9d6c20e12ee69991b52ed0b541567019770000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding blunt clipping to below ground level of xm variables, keeping their value at least tolerance. This prevents the crashing of mc3e caused by rtm being < 0. This is BIT_CHANGING, but only for mc3e, and the plots are very similar. Which must mean that mc3e is our only case where rtm becomes too small. larson-group/clubb#862 2019-08-28 14:16:10 -0500feb1fe6742605fd9d6c20e12ee69991b52ed0b54Adding blunt clipping to below ground level of xm variables, keeping their value at least tolerance. This prevents the crashing of mc3e caused by rtm being < 0. This is BIT_CHANGING, but only for mc3e, and the plots are very similar. Which must mean that mc3e is our only case where rtm becomes too small. larson-group/clubb#862editadvance_xm_wpxp_module.F90advance_clubb_core_module.F90stats_zm_module.F90parameters_tunable.F90parameter_indices.F90advance_xm_wpxp_module.F90advance_helper_module.F90f165ae4ca0cd02d825c185eaba700b0c6c715fd91567811198000http://carson.math.uwm.edu/jenkins/user/guozhunguozhunguozhun@uwm.eduThis commit is BIT_CHANGING. It is mainly because 1) We changed the equation of tau_xp2_zm, producing a better agreement with LES. 2) Many parameters have been retuned. We reduce nu2 and c_k2, because they bring us stronger scalar variances,especially for RFO1. We set C1=1, because it helps to reduce wp2 near cloud top. We also set C6=2 to generate stronger fluxes etc. Some other changes were made in this commit. They are 1) we modified subroutine calc_brunt_vaisala_freq_sqd by adding brunt_vaisala_freq_sqd_mixed, although brunt_vaisala_freq_sqd_dry is still used as default. 2) cloud fracting was considered in brunt_vaisala_freq_sqd as well as compute_Cx_Fnc_Richardson. 3) C_invrs_tau_N2_wpxp was added as a new parameter. 2019-09-06 18:06:38 -0500f165ae4ca0cd02d825c185eaba700b0c6c715fd9This commit is BIT_CHANGING. It is mainly because 1) We changed the equation of tau_xp2_zm, producing a better agreement with LES. 2) Many parameters have been retuned. We reduce nu2 and c_k2, because they bring us stronger scalar variances,especially for RFO1. We set C1=1, because it helps to reduce wp2 near cloud top. We also set C6=2 to generate stronger fluxes etc.editadvance_helper_module.F90editparameter_indices.F90editadvance_clubb_core_module.F90editstats_zm_module.F90editparameters_tunable.F90editadvance_xm_wpxp_module.F90tunable_parameters.ind7186c743f7723d7f398b86781caeeb2eefc437d1567811198000http://carson.math.uwm.edu/jenkins/user/guozhunguozhunguozhun@uwm.eduThis commit is BIT_CHANGING. It is mainly because 1) We changed the equation of tau_xp2_zm, producing a better agreement with LES. 2) Many parameters have been retuned. We reduce nu2 and c_k2, because they bring us stronger scalar variances,especially for RFO1. We set C1=1, because it helps to reduce wp2 near cloud top. We also set C6=2 to generate stronger fluxes etc. Some other changes were made in this commit. They are 1) we modified subroutine calc_brunt_vaisala_freq_sqd by adding brunt_vaisala_freq_sqd_mixed, although brunt_vaisala_freq_sqd_dry is still used as default. 2) cloud fracting was considered in brunt_vaisala_freq_sqd as well as compute_Cx_Fnc_Richardson. 3) C_invrs_tau_N2_wpxp was added as a new parameter. 2019-09-06 18:06:38 -0500d7186c743f7723d7f398b86781caeeb2eefc437dThis commit is BIT_CHANGING. It is mainly because 1) We changed the equation of tau_xp2_zm, producing a better agreement with LES. 2) Many parameters have been retuned. We reduce nu2 and c_k2, because they bring us stronger scalar variances,especially for RFO1. We set C1=1, because it helps to reduce wp2 near cloud top. We also set C6=2 to generate stronger fluxes etc.edittunable_parameters.inadvance_helper_module.F90ac210548b0f17a1dfab455f9b1d46e6011af8e651567963574000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdate advance_helper_module.F90 2019-09-08 12:26:14 -0500ac210548b0f17a1dfab455f9b1d46e6011af8e65Update advance_helper_module.F90editadvance_helper_module.F90advance_clubb_core_module.F9061228ff386d06aedecc69fb4797122fc3b1dc52a1567963704000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdate advance_clubb_core_module.F90 2019-09-08 12:28:24 -050061228ff386d06aedecc69fb4797122fc3b1dc52aUpdate advance_clubb_core_module.F90editadvance_clubb_core_module.F90advance_helper_module.F909c87ac3db2fa3a072b024b295dbb2931961e256e1568044019000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdate advance_helper_module.F90 Fixed a typo which cause a fail in Uninitialized Variables Test. 2019-09-09 10:46:59 -05009c87ac3db2fa3a072b024b295dbb2931961e256eUpdate advance_helper_module.F90editadvance_helper_module.F90parameters_tunable.F90c11c7882e433749159918d89176c892aa53b823e1568049431000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding C_invrs_tau_N2_wpxp to the initmax namelist. This should fix the fire tuning crashes. larson-group/sys_admin#626 2019-09-09 12:17:11 -0500c11c7882e433749159918d89176c892aa53b823eAdding C_invrs_tau_N2_wpxp to the initmax namelist. This should fix the fire tuning crashes. larson-group/sys_admin#626editparameters_tunable.F90new_hybrid_pdf.F9074b922513308db7dc1355a55eb6c90974943d1701568667521000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am adding a file for the new hybrid PDF, which combines the w equation set from the new PDF (setter variable) and an equation set for the responder variables similar to what is used for ADG1. 2019-09-16 15:58:41 -050074b922513308db7dc1355a55eb6c90974943d170I am adding a file for the new hybrid PDF, which combines the w equation setaddnew_hybrid_pdf.F90new_hybrid_pdf.F906ae78a67f971b37c6fdf70999e812c2cbba564371568672384000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI updated the function to calculate the implicit coefficient for the wp4 term, as well as added the function to calculate the implicit coefficient for the wp2xp terms for the new hybrid PDF. 2019-09-16 17:19:44 -05006ae78a67f971b37c6fdf70999e812c2cbba56437I updated the function to calculate the implicit coefficient for the wp4 term,editnew_hybrid_pdf.F90new_hybrid_pdf.F901cfb74544fc88bd03f57c8764ce100ee8a0651ea1568729503000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI made some changes to new_hybrid_pdf.F90 so that it would compile in its current state. 2019-09-17 09:11:43 -05001cfb74544fc88bd03f57c8764ce100ee8a0651eaI made some changes to new_hybrid_pdf.F90 so that it would compile in itseditnew_hybrid_pdf.F90new_hybrid_pdf.F909636e0e0bb6f1d6447761880fbbb34a0b69365ce1568744001000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI edited that subroutine that calculates the implicit coefficient and explicit term for the xp2 equation (wpxp2 term) for the new hybrid PDF. 2019-09-17 13:13:21 -05009636e0e0bb6f1d6447761880fbbb34a0b69365ceI edited that subroutine that calculates the implicit coefficient and expliciteditnew_hybrid_pdf.F90new_hybrid_pdf.F9091d3418f0eb9a96a0dabdac245bf463212f0bec61568758968000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI updated the subroutine that calculates the implicit coefficient and explicit term for the wpxpyp term in the xpyp predictive equation for the new hybrid PDF. 2019-09-17 17:22:48 -050091d3418f0eb9a96a0dabdac245bf463212f0bec6I updated the subroutine that calculates the implicit coefficient and expliciteditnew_hybrid_pdf.F90stats_variables.F90stats_lh_zt_module.F90stats_zt_module.F909b7da5ab8f5fcef54a61b7174324e236c012f9971568990372000http://carson.math.uwm.edu/jenkins/user/nselkenselkenselke@uwm.eduReplaced rrm_cond with rrm_evap and Nrm_cond with Nrm_evap because they described the same quantity. This is BIT_CHANGING just because the output now contains the N/rrm_evap instead of N/rrm_cond variable name. No changes were made to the values themselves. see #867 2019-09-20 09:39:32 -05009b7da5ab8f5fcef54a61b7174324e236c012f997Replaced rrm_cond with rrm_evap and Nrm_cond with Nrm_evap because they described the same quantity. This is BIT_CHANGING just because the output now contains the N/rrm_evap instead of N/rrm_cond variable name. No changes were made to the values themselves.editstats_zt_module.F90editstats_variables.F90editstats_lh_zt_module.F90new_hybrid_pdf_main.F90b535997cda4d30fb1751ebc4ba76d412462755031569341507000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am adding a new file, new_hybrid_pdf_main.F90, as a driver file for the new hybrid PDF. 2019-09-24 11:11:47 -0500b535997cda4d30fb1751ebc4ba76d41246275503I am adding a new file, new_hybrid_pdf_main.F90, as a driver file for the newaddnew_hybrid_pdf_main.F90new_hybrid_pdf_main.F90d03f5db1bbbb97e9db44aecd763d9de81c7cd8411569521049000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI worked more the functions for the new hybrid PDF. 2019-09-26 13:04:09 -0500d03f5db1bbbb97e9db44aecd763d9de81c7cd841I worked more the functions for the new hybrid PDF.editnew_hybrid_pdf_main.F90advance_xp2_xpyp_module.F903b3fa0f343d8202f19fe1f3e4f480f9efca0eae11570226820000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduRefactoring advance_xp2_xpyp to have the capability to perform only one combined solve when the lhs matricies are equivalent. larson-group/clubb#855 2019-10-04 17:07:00 -05003b3fa0f343d8202f19fe1f3e4f480f9efca0eae1Refactoring advance_xp2_xpyp to have the capability to perform only one combined solve when the lhs matricies are equivalent. larson-group/clubb#855editadvance_xp2_xpyp_module.F90pdf_utilities.F90setup_clubb_pdf_params.F907b4d6d73b34681ce3ebb3b2133a1b417178b882c1570539011000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI changed all the PDF utility functions in pdf_utilities.F90 to elemental functions. 2019-10-08 07:50:11 -05007b4d6d73b34681ce3ebb3b2133a1b417178b882cI changed all the PDF utility functions in pdf_utilities.F90 to elementaleditsetup_clubb_pdf_params.F90editpdf_utilities.F90pdf_utilities.F90fc7dd9a9251d4862a924755633e0242aaca241411570541067000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI forgot a "then" to go with an "elseif". 2019-10-08 08:24:27 -0500fc7dd9a9251d4862a924755633e0242aaca24141I forgot a "then" to go with an "elseif".editpdf_utilities.F90advance_xp2_xpyp_module.F9009460e50e11427c81d50af8196badfb77207e2871570570170000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding intent(in) attribute to rhs_ta terms and making scalar forcings local variables, since that is what they were supposed to be. larson-group/clubb#855 2019-10-08 16:29:30 -050009460e50e11427c81d50af8196badfb77207e287Adding intent(in) attribute to rhs_ta terms and making scalar forcings local variables, since that is what they were supposed to be. larson-group/clubb#855editadvance_xp2_xpyp_module.F90advance_xp2_xpyp_module.F90a6bf3fc74cfad569977dc2740bedeca0d63737c01570579988000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding case to and modifying xp2_xpyp_solve to remove the need for xp2_xpyp_solve_multiple. larson-group/clubb#855 2019-10-08 19:13:08 -0500a6bf3fc74cfad569977dc2740bedeca0d63737c0Adding case to and modifying xp2_xpyp_solve to remove the need for xp2_xpyp_solve_multiple. larson-group/clubb#855editadvance_xp2_xpyp_module.F90advance_xm_wpxp_module.F904e3165fe96a6b2071a388b787d2159b326a523981570831072000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduRefactoring advance_xm_wpxp to clean up code. Now subroutines solve_xm_wpxp_with_multiple_lhs and solve_xm_wpxp_with_single_lhs are called, rather than having huge chunks of similar code. Also changing the way calc_xm_wpxp_ta_terms works, it uses other input variables rather than coef_ and term_ arguements and instead calculates those locally to abstract functionality. This is BIT_CHANGING for some cases, but idenetical for some with some compilers. There are no visible differences in plots when tested with a number of different flags, and gabls2 (which uses scalars) are also the same. larson-group/clubb#855 2019-10-11 16:57:52 -05004e3165fe96a6b2071a388b787d2159b326a52398Refactoring advance_xm_wpxp to clean up code. Now subroutines solve_xm_wpxp_with_multiple_lhs and solve_xm_wpxp_with_single_lhs are called, rather than having huge chunks of similar code. Also changing the way calc_xm_wpxp_ta_terms works, it uses other input variables rather than coef_ and term_ arguements and instead calculates those locally to abstract functionality. This is BIT_CHANGING for some cases, but idenetical for some with some compilers. There are no visible differences in plots when tested with a number of different flags, and gabls2 (which uses scalars) are also the same. larson-group/clubb#855editadvance_xm_wpxp_module.F90new_hybrid_pdf_main.F909e77b1ad9feb229702bb7d2618aa870e8ca0476f1571148245000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am continuing to build the driver subroutine for the new hybrid PDF. 2019-10-15 09:04:05 -05009e77b1ad9feb229702bb7d2618aa870e8ca0476fI am continuing to build the driver subroutine for the new hybrid PDF.editnew_hybrid_pdf_main.F90new_hybrid_pdf_main.F902636b911d7c0ada3c7e221d34684aa2a9a6793d51571244715000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am continuing to work on the driver file for the new hybrid PDF. 2019-10-16 11:51:55 -05002636b911d7c0ada3c7e221d34684aa2a9a6793d5I am continuing to work on the driver file for the new hybrid PDF.editnew_hybrid_pdf_main.F90new_hybrid_pdf_main.F9019bfff3f4f90144b30c8143fb4fe50d5d8085c5a1571316332000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI have completed the main parts of the driver subroutine for the new hybrid PDF. 2019-10-17 07:45:32 -050019bfff3f4f90144b30c8143fb4fe50d5d8085c5aI have completed the main parts of the driver subroutine for the new hybrid PDF.editnew_hybrid_pdf_main.F90pdf_parameter_module.F90new_hybrid_pdf_main.F90363763a4cf6fd7200c76a6da2d71925fec4cbfa01571324271000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduThe code for the new hybrid PDF now compiles. 2019-10-17 09:57:51 -0500363763a4cf6fd7200c76a6da2d71925fec4cbfa0The code for the new hybrid PDF now compiles.editnew_hybrid_pdf_main.F90editpdf_parameter_module.F90pdf_closure_module.F90bd601ca08c9f0daeb8fa98f4579d7150bea6d3811571324344000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added an entry for the new hybrid PDF. 2019-10-17 09:59:04 -0500bd601ca08c9f0daeb8fa98f4579d7150bea6d381I added an entry for the new hybrid PDF.editpdf_closure_module.F90new_hybrid_pdf_main.F90new_hybrid_pdf.F9079f0955fbe6e20587d26ad6b920154b075ef784f1571339325000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI have added the new hybrid PDF to the G unit tests. 2019-10-17 14:08:45 -050079f0955fbe6e20587d26ad6b920154b075ef784fI have added the new hybrid PDF to the G unit tests.editnew_hybrid_pdf_main.F90editnew_hybrid_pdf.F90new_hybrid_pdf.F90b222dcbc135f4e89df4cfff38be930d9e8772b3b1571345095000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduMathematically, sigma_x_1_sqd and sigma_x_2_sqd cannot be less than 0. Numerically, this can happen when numerical round-off error causes epsilon-sized negative values. When this happens, reset the PDF component variance to 0. 2019-10-17 15:44:55 -0500b222dcbc135f4e89df4cfff38be930d9e8772b3bMathematically, sigma_x_1_sqd and sigma_x_2_sqd cannot be less than 0.editnew_hybrid_pdf.F90advance_clubb_core_module.F90pdf_closure_module.F90variables_prognostic_module.F908cfdc21a73477317533a6323d7bb6ffdd4a177f71571416566000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added code to interface the call to the new hybrid PDF with pdf_closure and have fed the necessary variables in from advance_clubb_core. 2019-10-18 11:36:06 -05008cfdc21a73477317533a6323d7bb6ffdd4a177f7I added code to interface the call to the new hybrid PDF with pdf_closureeditpdf_closure_module.F90editvariables_prognostic_module.F90editadvance_clubb_core_module.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90advance_xm_wpxp_module.F902b6ff6cccdbc1d75702d531d5bd62cd5aef226c91571530046000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI interfaced the implicit coefficients and explicit terms used in the turbulent advection code for the new hybrid PDF. The PDF can now be run interactively for wp3, all wpxp (wprtp, wpthlp, upwp, vpwp, and wpsclrp), rtp2, thlp2, and rtpthlp. 2019-10-19 19:07:26 -05002b6ff6cccdbc1d75702d531d5bd62cd5aef226c9I interfaced the implicit coefficients and explicit terms used in the turbulenteditadvance_xp2_xpyp_module.F90editadvance_xm_wpxp_module.F90editadvance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90e2bbcece49c6eb70c16dfdd66522d1fea66a48b71571530362000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI fixed a small error. The code compiles again now. 2019-10-19 19:12:42 -0500e2bbcece49c6eb70c16dfdd66522d1fea66a48b7I fixed a small error. The code compiles again now.editadvance_xp2_xpyp_module.F90advance_clubb_core_module.F90e19fe081dc9086a2fb47598e9e7e19187c1b4c8f1571936471000http://carson.math.uwm.edu/jenkins/user/pbroelspbroelspbroels@uwm.eduUpdated the larson-group.com urls to http://carson.math.uwm.edu/larson-group 2019-10-24 12:01:11 -0500e19fe081dc9086a2fb47598e9e7e19187c1b4c8fUpdated the larson-group.com urls to http://carson.math.uwm.edu/larson-groupeditadvance_clubb_core_module.F90advance_clubb_core_module.F90a1c0be95241fc9ce40fe7f9bc8e07607a6a1042d1571956527000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI have added code that allows CLUBB to run interactively using the new hybrid PDF. 2019-10-24 17:35:27 -0500a1c0be95241fc9ce40fe7f9bc8e07607a6a1042dI have added code that allows CLUBB to run interactively using the new hybrideditadvance_clubb_core_module.F90setup_clubb_pdf_params.F90c5a755bba80851cbaca3a58c3768f018a87113d11572019637000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am updating the subroutine that calculates PDF component means and standard deviations for hydrometeors. I am restoring it to its former glory (before where statements or pushed down loops), but I am turning it into an elemental subroutine. The results in GrADS output files from this revision are an exact match to the results in GrADS output files from the previous revision for all cases. 2019-10-25 11:07:17 -0500c5a755bba80851cbaca3a58c3768f018a87113d1I am updating the subroutine that calculates PDF component means and standardeditsetup_clubb_pdf_params.F90advance_clubb_core_module.F906486d4621e9999dc5c5fbb71b6ec4262bfc82a2e1572033711000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI placed proper thresholding on interpolated up2 and interpolated vp2 before the call to PDF closure. The results in GrADS output files from this revision are an exact match to the results in GrADS output files from the previous revision for all cases. 2019-10-25 15:01:51 -05006486d4621e9999dc5c5fbb71b6ec4262bfc82a2eI placed proper thresholding on interpolated up2 and interpolated vp2editadvance_clubb_core_module.F90new_hybrid_pdf_main.F90f66969bf1e01403e7e4694e1d11209af057162f21572039684000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added a limiter to keep the maximum magnitude of the correlations of fluxes to have a upper limit of max_mag_correlation_flux (which is the limit these correlations should have anyway). 2019-10-25 16:41:24 -0500f66969bf1e01403e7e4694e1d11209af057162f2I added a limiter to keep the maximum magnitude of the correlations ofeditnew_hybrid_pdf_main.F90setup_clubb_pdf_params.F90Nc_Ncn_eqns.F90d647c75c8a71abcbf4c990562dd33bd13000d9581572096033000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI upgraded Nc_Ncn_eqns.F90 to use elemental functions. The results in GrADS output files from this revision are an exact match to the results in GrADS output files from the previous revision for all cases. 2019-10-26 08:20:33 -0500d647c75c8a71abcbf4c990562dd33bd13000d958I upgraded Nc_Ncn_eqns.F90 to use elemental functions.editsetup_clubb_pdf_params.F90editNc_Ncn_eqns.F90setup_clubb_pdf_params.F900bbfad6256a0124264bbe3ce79762551170e719b1572097496000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduThe new hybrid PDF also uses this bit of code that sets the correlation of w and chi, as well as the correlation of w and eta, to 0 for use in the correlation arrays to obey PDF standards. 2019-10-26 08:44:56 -05000bbfad6256a0124264bbe3ce79762551170e719bThe new hybrid PDF also uses this bit of code that sets the correlationeditsetup_clubb_pdf_params.F90new_hybrid_pdf_main.F90pdf_closure_module.F904b682669ee973988cfa6434f90837f1aa428ea111572357782000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI made modifications to the new hybrid PDF so that that calculation of F_w temporarily becomes more ADG1/sigma_sqd_w-like. I also set sigma_sqd_w to 1 - F_w when the new hybrid PDF is used so that the calculation of skewness of responder variables becomes more consistent with F_w and the new hybrid PDF. 2019-10-29 09:03:02 -05004b682669ee973988cfa6434f90837f1aa428ea11I made modifications to the new hybrid PDF so that that calculation of F_weditnew_hybrid_pdf_main.F90editpdf_closure_module.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90clubb_api_module.F90pdf_closure_module.F90pdf_parameter_module.F90new_hybrid_pdf_main.F90new_pdf_main.F90variables_prognostic_module.F90b401721c1caf94bec4ca3a07a63d748967c9ecc61572467624000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added the ability to handle scalars interactively to the new hybrid PDF. 2019-10-30 15:33:44 -0500b401721c1caf94bec4ca3a07a63d748967c9ecc6I added the ability to handle scalars interactively to the new hybrid PDF.editadvance_clubb_core_module.F90editnew_hybrid_pdf_main.F90editnew_pdf_main.F90editpdf_parameter_module.F90editadvance_xm_wpxp_module.F90editclubb_api_module.F90editpdf_closure_module.F90editadvance_wp2_wp3_module.F90editvariables_prognostic_module.F90editadvance_xp2_xpyp_module.F90new_hybrid_pdf.F90a775bd9a19e95bc9df8854fa1348bff049acd7471572471442000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI found a couple of spots in the new hybrid PDF where I needed to add a wp2 > 0 to the conditionals in order to avoid any potential divide-by-zeros. 2019-10-30 16:37:22 -0500a775bd9a19e95bc9df8854fa1348bff049acd747I found a couple of spots in the new hybrid PDF where I needed to addeditnew_hybrid_pdf.F90clubb_api_module.F90916c1f752b8d36ebceae827e7c1ed2dba4acbbef1572475839000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added init_pdf_implicit_coefs_terms_api to clubb_api_module.F90. 2019-10-30 17:50:39 -0500916c1f752b8d36ebceae827e7c1ed2dba4acbbefI added init_pdf_implicit_coefs_terms_api to clubb_api_module.F90.editclubb_api_module.F90tunable_parameters.in6b6b492ad0add3bd59975fba69b7c454017354031572530661000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am setting the zeta variance ratio to 1 (symmetric design) by default, as that is producing more ADG1-like results to start off with. 2019-10-31 09:04:21 -05006b6b492ad0add3bd59975fba69b7c45401735403I am setting the zeta variance ratio to 1 (symmetric design) byedittunable_parameters.inclubb_api_module.F90afb54c36c23b91c8b3c7eb1fa24f1ca3f9fb8da61572559447000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduThe variable type implicit_coefs_terms needs to be made public so that it is available to host models. 2019-10-31 17:04:07 -0500afb54c36c23b91c8b3c7eb1fa24f1ca3f9fb8da6The variable type implicit_coefs_terms needs to be made publiceditclubb_api_module.F90new_hybrid_pdf_main.F90e62b062d69789b8034b91fddd0454be4a18f6e621572565760000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI changed the value of the coefficient in the F_w equation to 0.45 because it produces a result that is more similar to ADG1 results for most cases. This is a better spot to start testing, development, and tuning from. 2019-10-31 18:49:20 -0500e62b062d69789b8034b91fddd0454be4a18f6e62I changed the value of the coefficient in the F_w equation to 0.45editnew_hybrid_pdf_main.F90advance_clubb_core_module.F90clubb_api_module.F907a9ffd8b8ca3f2f5de3b51b75cf72ebf67d1246c1572707965000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am updating the code to pass up3, vp3, and sclrp3 out of advance_clubb_core and then back in again. They were temporarily being stored through use statements within advance_clubb_core. This does not change results of standalone CLUBB. However, prior to this change, these variables weren't being allocated for host model runs. This was causing a segmentation fault. 2019-11-02 10:19:25 -05007a9ffd8b8ca3f2f5de3b51b75cf72ebf67d1246cI am updating the code to pass up3, vp3, and sclrp3 out of advance_clubb_coreeditadvance_clubb_core_module.F90editclubb_api_module.F90advance_xp2_xpyp_module.F90e9b085012b811e7726988c0b3bbec21bb064ce111573243077000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI have started the process of adding the coding infrastructure for having different up2 and vp2 LHS for the new hybrid PDF. The default ADG1 code remains unchanged. 2019-11-08 13:57:57 -0600e9b085012b811e7726988c0b3bbec21bb064ce11I have started the process of adding the coding infrastructureeditadvance_xp2_xpyp_module.F90advance_xp2_xpyp_module.F90f48d9abfdfb56389af74f9542a229864cee47ac61573311461000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI have completed the addition of the ability to use different up2 and vp2 LHS for the new hybrid PDF. The default ADG1 PDF remains unaffected by these changes. 2019-11-09 08:57:41 -0600f48d9abfdfb56389af74f9542a229864cee47ac6I have completed the addition of the ability to use different up2editadvance_xp2_xpyp_module.F90parameters_tunable.F90model_flags.F90clubb_api_module.F906fa1cf9c290c207154a211f5fc860668576181d61573594095000http://carson.math.uwm.edu/jenkins/user/nselkenselkenselke@uwm.eduI have added 'l_use_precip_frac', 'l_do_expldiff_rtm_thlm', 'l_use_C11_Richardson' and 'l_prescribed_avg_deltaz' to the 'configurable_clubb_flags_nl' namelist. The latter was moved from 'model_setting' namelist. #856 2019-11-12 15:28:15 -06006fa1cf9c290c207154a211f5fc860668576181d6I have added 'l_use_precip_frac', 'l_do_expldiff_rtm_thlm', 'l_use_C11_Richardson' and 'l_prescribed_avg_deltaz' to the 'configurable_clubb_flags_nl' namelist. The latter was moved from 'model_setting' namelist. #856editparameters_tunable.F90editclubb_api_module.F90editmodel_flags.F90configurable_model_flags.inc691cebf902dbf4017a5e36b3b49cf93e37280211573594095000http://carson.math.uwm.edu/jenkins/user/nselkenselkenselke@uwm.eduI have added 'l_use_precip_frac', 'l_do_expldiff_rtm_thlm', 'l_use_C11_Richardson' and 'l_prescribed_avg_deltaz' to the 'configurable_clubb_flags_nl' namelist. The latter was moved from 'model_setting' namelist. #856 2019-11-12 15:28:15 -0600c691cebf902dbf4017a5e36b3b49cf93e3728021I have added 'l_use_precip_frac', 'l_do_expldiff_rtm_thlm', 'l_use_C11_Richardson' and 'l_prescribed_avg_deltaz' to the 'configurable_clubb_flags_nl' namelist. The latter was moved from 'model_setting' namelist. #856editconfigurable_model_flags.insetup_clubb_pdf_params.F90a3fa5e1a393d836c3bbc5622c69ecfd9aab2ed761573597176000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI made the l_calc_w_corr code (turned off by default) run again by changing subroutine calc_corr_w_hm_n to an elemental subroutine. Previously, runtime exceptions were found within the "where" statements. 2019-11-12 16:19:36 -0600a3fa5e1a393d836c3bbc5622c69ecfd9aab2ed76I made the l_calc_w_corr code (turned off by default) run again byeditsetup_clubb_pdf_params.F90model_flags.F90f5c0f864a1ef81dc3b1b08dc1f6a49a2caff860d1573750479000http://carson.math.uwm.edu/jenkins/user/nselkenselkenselke@uwm.eduI added a few more flags to the 'configurable_clubb_flags_nl' namelist. Also I gave 'l_use_wp3_pr3' the parameter attribute. This is done in preparation for the introduction of the 'clubb_config_flags_type'. #856 2019-11-14 10:54:39 -0600f5c0f864a1ef81dc3b1b08dc1f6a49a2caff860dI added a few more flags to the 'configurable_clubb_flags_nl' namelist. Also I gave 'l_use_wp3_pr3' the parameter attribute.editmodel_flags.F90configurable_model_flags.inff07bc52a3aaadf260f89d6b7232525ae43bfc891573750479000http://carson.math.uwm.edu/jenkins/user/nselkenselkenselke@uwm.eduI added a few more flags to the 'configurable_clubb_flags_nl' namelist. Also I gave 'l_use_wp3_pr3' the parameter attribute. This is done in preparation for the introduction of the 'clubb_config_flags_type'. #856 2019-11-14 10:54:39 -0600ff07bc52a3aaadf260f89d6b7232525ae43bfc89I added a few more flags to the 'configurable_clubb_flags_nl' namelist. Also I gave 'l_use_wp3_pr3' the parameter attribute.editconfigurable_model_flags.inadvance_wp2_wp3_module.F90advance_clubb_core_module.F90advance_xp2_xpyp_module.F90780fe29dcb36ae1ec349ba5c65f090059f2036851573771919000http://carson.math.uwm.edu/jenkins/user/nselkenselkenselke@uwm.eduI have started altering argument lists to feed clubb configurable flags through them. This commit has 'l_use_precip_frac', 'l_min_wp2_from_corr_wx', and 'l_min_xp2_from_corr_wx' covered. #856 2019-11-14 16:51:59 -0600780fe29dcb36ae1ec349ba5c65f090059f203685I have started altering argument lists to feed clubb configurable flags through them. This commit has 'l_use_precip_frac',editadvance_wp2_wp3_module.F90editadvance_clubb_core_module.F90editadvance_xp2_xpyp_module.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90mean_adv.F90advance_windm_edsclrm_module.F90mono_flux_limiter.F9037be56d2a4b786d7f12ddd69516cb4352ada61991573842974000http://carson.math.uwm.edu/jenkins/user/nselkenselkenselke@uwm.eduI continued to alter argument lists. This commit covers 'l_C2_cloud_frac', 'l_diffuse_rtm_and_thlm', 'l_stability_correct_Kh_N2_zm', 'l_upwind_wpxp_ta', 'l_upwind_xpyp_ta', 'l_upwind_xm_ma'. #856 2019-11-15 12:36:14 -060037be56d2a4b786d7f12ddd69516cb4352ada6199I continued to alter argument lists. This commit covers 'l_C2_cloud_frac', 'l_diffuse_rtm_and_thlm', 'l_stability_correct_Kh_N2_zm',editadvance_wp2_wp3_module.F90editmean_adv.F90editadvance_xm_wpxp_module.F90editmono_flux_limiter.F90editadvance_windm_edsclrm_module.F90editadvance_clubb_core_module.F90editadvance_xp2_xpyp_module.F90advance_wp2_wp3_module.F90mixing_length.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F909b71f7dbb101e9db7cc9806b71a84163a7ea74f81573859283000http://carson.math.uwm.edu/jenkins/user/nselkenselkenselke@uwm.eduI continued to alter argument lists. This commit covers ' l_vert_avg_closure', 'l_trapezoidal_rule_zt', 'l_trapezoidal_rule_zm', 'l_call_pdf_closure_twice', 'l_use_cloud_cover', 'l_stability_correct_tau_zm', 'l_damp_wp2_using_em', 'l_do_expldiff_rtm_thlm', 'l_Lscale_plume_centered', 'l_diag_Lscale_from_tau', 'l_use_ice_latent', 'l_use_C7_Richardson', 'l_use_C11_Richardson', 'l_rcm_supersat_adj', 'l_damp_wp3_Skw_squared', and 'l_prescribed_avg_deltaz'. #856 2019-11-15 17:08:03 -06009b71f7dbb101e9db7cc9806b71a84163a7ea74f8I continued to alter argument lists. This commit covers ' l_vert_avg_closure', 'l_trapezoidal_rule_zt', 'l_trapezoidal_rule_zm',editadvance_xm_wpxp_module.F90editadvance_clubb_core_module.F90editadvance_wp2_wp3_module.F90editmixing_length.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90clip_explicit.F90output_netcdf.F90sigma_sqd_w_module.F90stats_clubb_utilities.F90setup_clubb_pdf_params.F90advance_windm_edsclrm_module.F90advance_helper_module.F9063bfc28d22b334b76ebb1e8fe547ebe81c3df81a1574362548000http://carson.math.uwm.edu/jenkins/user/nselkenselkenselke@uwm.eduI continued to alter argument lists. This commit covers the last flags in the namelist 'configurable_clubb_flags_nl', namely 'l_predict_upwp_vpwp', 'l_tke_aniso', 'l_standard_term_ta', 'l_brunt_vaisala_freq_moist', 'l_use_thvm_in_bv_freq', and 'l_single_C2_Skw'. #856 2019-11-21 12:55:48 -060063bfc28d22b334b76ebb1e8fe547ebe81c3df81aI continued to alter argument lists. This commit covers the last flags in the namelist 'configurable_clubb_flags_nl', namely 'l_predict_upwp_vpwp',editadvance_xp2_xpyp_module.F90editadvance_xm_wpxp_module.F90editoutput_netcdf.F90editadvance_clubb_core_module.F90editclip_explicit.F90editsigma_sqd_w_module.F90editadvance_helper_module.F90editadvance_windm_edsclrm_module.F90editstats_clubb_utilities.F90editsetup_clubb_pdf_params.F90editadvance_wp2_wp3_module.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90output_netcdf.F90diagnose_correlations_module.F90stats_clubb_utilities.F90setup_clubb_pdf_params.F90advance_windm_edsclrm_module.F903d7dd80beb0c24b1cb5ceac4a565ae6f13fd80041574381544000http://carson.math.uwm.edu/jenkins/user/nselkenselkenselke@uwm.eduFinished altering argument lists. This commit covers the final seven flags, which are in different namelists. This includes 'l_calc_thlp2_rad', 'l_uv_nudge', 'l_rtm_nudge', 'l_diagnose_correlations', 'l_calc_w_corr', 'l_const_Nc_in_cloud', and 'l_fix_w_chi_eta_correlations'. #856 2019-11-21 18:12:24 -06003d7dd80beb0c24b1cb5ceac4a565ae6f13fd8004Finished altering argument lists. This commit covers the final seven flags, which are in different namelists.editoutput_netcdf.F90editadvance_xm_wpxp_module.F90editsetup_clubb_pdf_params.F90editdiagnose_correlations_module.F90editadvance_clubb_core_module.F90editadvance_windm_edsclrm_module.F90editstats_clubb_utilities.F90model_flags.F90e27846ed5438edd18859a6fa13a44871e0f9dad71574785619000http://carson.math.uwm.edu/jenkins/user/nselkenselkenselke@uwm.eduI introduced the 'clubb_config_flags_type'. Furthermore, I have created subroutines to set default values, to initialize the derived type and to print the derived type. However it is not used by now. #856 2019-11-26 10:26:59 -0600e27846ed5438edd18859a6fa13a44871e0f9dad7I introduced the 'clubb_config_flags_type'. Furthermore, I have created subroutines to set default values, to initialize the derived type and to print the derived type.editmodel_flags.F90advance_clubb_core_module.F90model_flags.F90clubb_api_module.F90parameters_tunable.F90stats_clubb_utilities.F90setup_clubb_pdf_params.F90corr_varnce_module.F90976026d16da3de89e4899700ff544352f642a3981576018347000http://carson.math.uwm.edu/jenkins/user/nselkenselkenselke@uwm.eduI enabled the use of the 'clubb_config_flags_type'. I changed 'clubb_standalone', 'clubb_tuner' and the G_unit_tests so that they now use it. The results are bit-for-bit identical. #856 2019-12-10 16:52:27 -0600976026d16da3de89e4899700ff544352f642a398I enabled the use of the 'clubb_config_flags_type'. I changed 'clubb_standalone', 'clubb_tuner' and the G_unit_tests so that they now use it. The results are bit-for-bit identical. #856editcorr_varnce_module.F90editparameters_tunable.F90editsetup_clubb_pdf_params.F90editclubb_api_module.F90editadvance_clubb_core_module.F90editmodel_flags.F90editstats_clubb_utilities.F90advance_clubb_core_module.F90cd4f009eb87b05355ab501f2a1e7c7666bcfea7a1576263181000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduI fed pdf_params_frz into subroutine advance_clubb_core via a use statement. Doing so avoids a seg fault with l_use_ice_latent = .true. Results are BFB for arm_97. For #871. 2019-12-13 12:53:01 -0600cd4f009eb87b05355ab501f2a1e7c7666bcfea7aI fed pdf_params_frz into subroutine advance_clubb_coreeditadvance_clubb_core_module.F90advance_clubb_core_module.F90parameters_tunable.F90clubb_api_module.F90b7b343873c52f374140f1b829c58798d231047131576288560000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding error code to arguement list of non-api routines where it was included in the api version. 2019-12-13 19:56:00 -0600b7b343873c52f374140f1b829c58798d23104713Adding error code to arguement list of non-api routines where it was included in the api version.editadvance_clubb_core_module.F90editclubb_api_module.F90editparameters_tunable.F90advance_clubb_core_module.F90mixing_length.F90clubb_api_module.F903108bbdf54aa0f815048daf566c0015714ec82c11576621906000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMoving location of error messages that were in advance_clubb_core. Adding error code setting to those spots as well, they should be fatal. 2019-12-17 16:31:46 -06003108bbdf54aa0f815048daf566c0015714ec82c1Moving location of error messages that were in advance_clubb_core. Adding error code setting to those spots as well, they should be fatal.editclubb_api_module.F90editadvance_clubb_core_module.F90editmixing_length.F90clubb_api_module.F900cfd69bf18f68389e4d86b7fac53b3e828e98f8c1576699854000http://carson.math.uwm.edu/jenkins/user/sdomkeSteffen Domkesdomke@uwm.eduAdded use statement for pdf_params_frz in src/CLUBB_core/clubb_api_module.f90 and made it public. This was done to be able to use the variable in SAM's SGS_CLUBB package. https://github.com/larson-group/clubb/issues/871 2019-12-18 14:10:54 -06000cfd69bf18f68389e4d86b7fac53b3e828e98f8cAdded use statement for pdf_params_frz in src/CLUBB_core/clubb_api_module.f90 and made it public.editclubb_api_module.F90advance_clubb_core_module.F908105cfd6a2a86d2adf95bfe73e9ee210219dd5801576855679000http://carson.math.uwm.edu/jenkins/user/nselkenselkenselke@uwm.eduI have fixed the warnings for lines exceeding 100 characters. 2019-12-20 09:27:59 -06008105cfd6a2a86d2adf95bfe73e9ee210219dd580I have fixed the warnings for lines exceeding 100 characters.editadvance_clubb_core_module.F90advance_clubb_core_module.F90clubb_api_module.F90234b88f48750523927211d4908d6ed086592941b1576880962000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduPassing individual flags into setup_clubb_core, rather than the type container for them. This is done for code clarity. 2019-12-20 16:29:22 -0600234b88f48750523927211d4908d6ed086592941bPassing individual flags into setup_clubb_core, rather than the type container for them. This is done for code clarity.editadvance_clubb_core_module.F90editclubb_api_module.F90parameters_tunable.F9011b379246a683faec006978acd3764328492619f1578600058000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comTrivial update to test if cams autoupdate works 2020-01-09 14:00:58 -060011b379246a683faec006978acd3764328492619fTrivial update to test if cams autoupdate workseditparameters_tunable.F90parameters_tunable.F90model_flags.F906b20ec2a88f083ee48eac3e39d0e7f94852afcc71578723242000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduRevert "I am setting model flags and tunable parameters in the clubb_E3SM_silhs branch" I am reverting commit da00f00. In that commit, I set some tunable parameters and flags to be consistent with an old version of E3SM-CLUBB-SILHS. However, results from those old cases are hopelessly lost anyway, and we should keep flags and parameters consistent with today's CLUBB. Secondly, the code change in da00f00 is blocking a merge of the modern CLUBB master into this branch. This reverts commit da00f00f1bd353a7e413a738e1424ddddd751a2b. 2020-01-11 00:14:02 -06006b20ec2a88f083ee48eac3e39d0e7f94852afcc7Revert "I am setting model flags and tunable parameters in the clubb_E3SM_silhs branch"editparameters_tunable.F90editmodel_flags.F90parameters_tunable.F901b3ce367c1fd861f61265a4b797c300cbf0a016a1579036682000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI placed E3SM preprocessor commands around E3SM-specific code in parameters_tunable.F90. 2020-01-14 15:18:02 -06001b3ce367c1fd861f61265a4b797c300cbf0a016aI placed E3SM preprocessor commands around E3SM-specific code ineditparameters_tunable.F90latin_hypercube_driver_module.F90167b63c98f5944d7d45de97507e8d910b376992c1579122114000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduRestoring assertion check for the vertical correlation calculation. larson-group/clubb#869 2020-01-15 15:01:54 -0600167b63c98f5944d7d45de97507e8d910b376992cRestoring assertion check for the vertical correlation calculation. larson-group/clubb#869editlatin_hypercube_driver_module.F90parameters_silhs.F90latin_hypercube_driver_module.F90c927e76c34601e24c555ad799e32bb83e560a0a21579138765000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduChanging the error treshold in assert_correct_cloud_normal to use the previously defined single precision threshold. This should fix occasional errors. larson-group/clubb#869 2020-01-15 19:39:25 -0600c927e76c34601e24c555ad799e32bb83e560a0a2Changing the error treshold in assert_correct_cloud_normal to use the previously defined single precision threshold. This should fix occasional errors. larson-group/clubb#869editparameters_silhs.F90editlatin_hypercube_driver_module.F90parameters_tunable.F90e6f8822a24416b4d853465f7bd797ea5a8fb92dd1579207489000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added E3SM's clubb_ parameters that can be read in from the E3SM clubb_param_nl namelist that are now found on E3SM's master branch (and weren't previously). This is within the #ifdef E3SM preprocessor directive and won't affect CLUBB except in the context of E3SM. 2020-01-16 14:44:49 -0600e6f8822a24416b4d853465f7bd797ea5a8fb92ddI added E3SM's clubb_ parameters that can be read in from theeditparameters_tunable.F90parameters_tunable.F9001cd689e03930500afd5a99d8b980dbf78b4bc2b1579215203000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added the remainder the clubb_ terms that were added previously to the zhun/atm/clubb_silhs_v2 branch of the UWM E3SM repository. This only affects code in the #ifdef E3SM preprocessor flag. 2020-01-16 16:53:23 -060001cd689e03930500afd5a99d8b980dbf78b4bc2bI added the remainder the clubb_ terms that were added previously toeditparameters_tunable.F90latin_hypercube_driver_module.F9027ac5d4ef6f344b80445522f9e313392896a24951579642680000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduChanging error threshold in assert_correct_cloud_normal and fixing bug where we weren't passing the correct array section. This should fix the WRF parallel test and the PGI test. larson-group/clubb#869 2020-01-21 15:38:00 -060027ac5d4ef6f344b80445522f9e313392896a2495Changing error threshold in assert_correct_cloud_normal and fixing bug where we weren't passing the correct array section. This should fix the WRF parallel test and the PGI test. larson-group/clubb#869editlatin_hypercube_driver_module.F90transform_to_pdf_module.F90latin_hypercube_driver_module.F90b6025d4bae73e4715cd9ba9d404464f8daae4c4e1579714696000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduSmall updates to acc kernel statments for general performance improvement. This is bit-for-bit. larson-group/clubb#869 2020-01-22 11:38:16 -0600b6025d4bae73e4715cd9ba9d404464f8daae4c4eSmall updates to acc kernel statments for general performance improvement. This is bit-for-bit. larson-group/clubb#869edittransform_to_pdf_module.F90editlatin_hypercube_driver_module.F90latin_hypercube_driver_module.F905f9e2a7a767c2b2ee554bfccc0c9908d50f4043d1579716158000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduRedoing some data directives to only copy data that we need off the device. Data that is needed by assertion checks and stats will be updated conditionally. This will make the code faster when no stats/assertion checks are being done, but slower when it is. This is all bit-for-bit. larson-group/clubb#869 2020-01-22 12:02:38 -06005f9e2a7a767c2b2ee554bfccc0c9908d50f4043dRedoing some data directives to only copy data that we need off the device. Data that is needed by assertion checks and stats will be updated conditionally. This will make the code faster when no stats/assertion checks are being done, but slower when it is. This is all bit-for-bit. larson-group/clubb#869editlatin_hypercube_driver_module.F90transform_to_pdf_module.F901f9d2abc6ca0b7b180c4d0f6f18197c40ef594e11579897098000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding space because commit a8e61923fa19887baef220aa1a7c8be0f773770f was BIT_CHANGING. larson-group/clubb#869 2020-01-24 14:18:18 -06001f9d2abc6ca0b7b180c4d0f6f18197c40ef594e1Adding space because commit a8e61923fa19887baef220aa1a7c8be0f773770f was BIT_CHANGING. larson-group/clubb#869edittransform_to_pdf_module.F90transform_to_pdf_module.F90c58014f82bae800df319de3edfed14f6d221964f1579899486000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduSimple performance improvement refactoring. Merging loops and creating tmp variable to use to help reduce memory usage. This changes the order of operations so this is BIT_CHANGING. larson-group/clubb#869 2020-01-24 14:58:06 -0600c58014f82bae800df319de3edfed14f6d221964fSimple performance improvement refactoring. Merging loops and creating tmp variable to use to help reduce memory usage. This changes the order of operations so this is BIT_CHANGING. larson-group/clubb#869edittransform_to_pdf_module.F90latin_hypercube_driver_module.F908e5716b6671ee0b87017b2816ab718e90d1bb0281580239752000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduSmall performance improvement. Almost reverting the loops to their previous form using the unbounded_point variable. This is all bit-for-bit. larson-group/clubb#869 2020-01-28 13:29:12 -06008e5716b6671ee0b87017b2816ab718e90d1bb028Small performance improvement. Almost reverting the loops to their previous form using the unbounded_point variable. This is all bit-for-bit. larson-group/clubb#869editlatin_hypercube_driver_module.F90silhs_api_module.F90latin_hypercube_driver_module.F90faf11c1f824a5fc95ecb21de0a2225ba20036ea61580253302000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduRemoving lh_clipped_vars and replacing functionality with arrays. larson-group/clubb#869 2020-01-28 17:15:02 -0600faf11c1f824a5fc95ecb21de0a2225ba20036ea6Removing lh_clipped_vars and replacing functionality with arrays. larson-group/clubb#869editlatin_hypercube_driver_module.F90editsilhs_api_module.F90latin_hypercube_driver_module.F905b5269b0631c07c51addb22c912d77223d3cd0091580414158000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdate latin_hypercube_driver_module.F90 2020-01-30 13:55:58 -06005b5269b0631c07c51addb22c912d77223d3cd009Update latin_hypercube_driver_module.F90editlatin_hypercube_driver_module.F90parameters_tunable.F90dfe257f9bd88ba731787533dc5bc35ffb1b87c351580414204000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdate parameters_tunable.F90 2020-01-30 13:56:44 -0600dfe257f9bd88ba731787533dc5bc35ffb1b87c35Update parameters_tunable.F90editparameters_tunable.F90transform_to_pdf_module.F90latin_hypercube_driver_module.F90b6b18c6a112162a8ef8fbf13aa3478a4b7062d7d1581022293000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduGPUizing clip_transform_silhs_output and pushing data directives up call tree. This is all bit-for-bit. larson-group/clubb#869 2020-02-06 14:51:33 -0600b6b18c6a112162a8ef8fbf13aa3478a4b7062d7dGPUizing clip_transform_silhs_output and pushing data directives up call tree. This is all bit-for-bit. larson-group/clubb#869editlatin_hypercube_driver_module.F90edittransform_to_pdf_module.F90transform_to_pdf_module.F90latin_hypercube_driver_module.F90b7c52042cb960e2a85c4402ec4e1da7791ab56a31581030860000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking some data copying regions asyncronous with compute regions, improving performance. This is bit-for-bit. larson-group/clubb#869 2020-02-06 17:14:20 -0600b7c52042cb960e2a85c4402ec4e1da7791ab56a3Making some data copying regions asyncronous with compute regions, improving performance. This is bit-for-bit. larson-group/clubb#869editlatin_hypercube_driver_module.F90edittransform_to_pdf_module.F90stats_type_utilities.F90bde68d858a6c622fc6acdd4c2255c6125c632a381581722411000http://carson.math.uwm.edu/jenkins/user/nselkenselkenselke@uwm.eduI changed the dummy argument 'value' in the 'stat_update_var' subroutine from explicit to assumed size. #874 2020-02-14 17:20:11 -0600bde68d858a6c622fc6acdd4c2255c6125c632a38I changed the dummy argument 'value' in the 'stat_update_var' subroutine from explicit to assumed size. #874editstats_type_utilities.F90advance_clubb_core_module.F90model_flags.F90clubb_api_module.F90f4cbd72beba82c17113c6a38d43a72e88bfe2fc51581778729000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added the new l_update_pressure configurable flag to clubb_config_flags. When this flag is enabled (which it is by default), CLUBB updates pressure and exner every timestep. This new flags allows this feature to easily be turned off within the context of host models, such as CAM and E3SM. The results in GrADS output files from this revision are an exact match to the results in GrADS output files from the previous revision for all cases. 2020-02-15 08:58:49 -0600f4cbd72beba82c17113c6a38d43a72e88bfe2fc5I added the new l_update_pressure configurable flag to clubb_config_flags.editclubb_api_module.F90editmodel_flags.F90editadvance_clubb_core_module.F90configurable_model_flags.in081305f3f0bcfe634f5cc2c6b2d8dd5bf3c645421581778729000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added the new l_update_pressure configurable flag to clubb_config_flags. When this flag is enabled (which it is by default), CLUBB updates pressure and exner every timestep. This new flags allows this feature to easily be turned off within the context of host models, such as CAM and E3SM. The results in GrADS output files from this revision are an exact match to the results in GrADS output files from the previous revision for all cases. 2020-02-15 08:58:49 -0600081305f3f0bcfe634f5cc2c6b2d8dd5bf3c64542I added the new l_update_pressure configurable flag to clubb_config_flags.editconfigurable_model_flags.innew_hybrid_pdf_main.F90a32a63a586047be39f39af42106bfb5f31efb6721582228068000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added some code I used in the special input fields branch to make the PDF of w symmetric, so that the PDF at a value of positive skewness of w (for example, +2) looks like a mirror image of the PDF at the opposite value of negative skewness (for example, -2). 2020-02-20 13:47:48 -0600a32a63a586047be39f39af42106bfb5f31efb672I added some code I used in the special input fields branch to makeeditnew_hybrid_pdf_main.F90numerical_check.F909225a01acef12413480c3deb0cc2dfd804127c271584200643000http://carson.math.uwm.edu/jenkins/user/guozhunguozhunguozhun@uwm.eduAn improved NaN-Inf checker. It is based on IEEE_ARITHMETIC. (issue#875)[https://github.com/larson-group/clubb/issues/875] 2020-03-14 10:44:03 -05009225a01acef12413480c3deb0cc2dfd804127c27An improved NaN-Inf checker. It is based on IEEE_ARITHMETIC. (issue#875)[https://github.com/larson-group/clubb/issues/875]editnumerical_check.F90stats_type_utilities.F900dca127542d480d4f81bb75019c575e2b3addf851584204136000http://carson.math.uwm.edu/jenkins/user/nselkenselkenselke@uwm.eduI revert the changes from commit 'fbcbd86' from February 14th 2020 to resolve an issue with SAM CLUBB. For details see #874. 2020-03-14 11:42:16 -05000dca127542d480d4f81bb75019c575e2b3addf85I revert the changes from commit 'fbcbd86' from February 14th 2020 to resolve an issue with SAM CLUBB. For details see #874.editstats_type_utilities.F90variables_prognostic_module.F9064b5afb6666c2d345052d96f8f1d8ae54761daf81584638975000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI got rid of the "allocatable", "allocate", and "deallocate" statements in regards to pdf_params and pdf_params_frz because NCAR could not get CAM to run using the NAG compiler. As it turns out, the code can run on group computers without these statements. 2020-03-19 12:29:35 -050064b5afb6666c2d345052d96f8f1d8ae54761daf8I got rid of the "allocatable", "allocate", and "deallocate" statementseditvariables_prognostic_module.F90error_code.F90279fab75ad386341b7d26f56991681e86ee9eef31584682838000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI placed an ifndef CLUBB_CAM preprocessor flag around the code in error_code.F90 that uses the FORTRAN intrinsic call to getpid(). This causes problems for NCAR when they try to compile CAM using the NAG compiler. 2020-03-20 00:40:38 -0500279fab75ad386341b7d26f56991681e86ee9eef3I placed an ifndef CLUBB_CAM preprocessor flag around the code inediterror_code.F90parameters_tunable.F9025b836771d9185938dffb4327d6444a6e3bcb0051585575594000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comI reduced the minimum possible value of lmin from 4.0 to 1.0. This is because Mark Taylor found that for the E3SM model, reducing lmin from 4 to 1 prevents excessive cooling at the surface near Greenland. For more information about this "Tlay" error, see [here](https://acme-climate.atlassian.net/wiki/spaces/NGDNA/pages/1296793934/CLUBB+lmin+coeff+sensitivity?focusedCommentId=1296892065#comment-1296892065) and [here](https://acme-climate.atlassian.net/wiki/spaces/NGDNA/pages/1235255422/Tlay+Error+in+ne256pg2+Runs+cold+temperature+plots). larson-group/climate_process_team#196 2020-03-30 08:39:54 -050025b836771d9185938dffb4327d6444a6e3bcb005I reduced the minimum possible value of lmin from 4.0 to 1.0.editparameters_tunable.F90advance_clubb_core_module.F905a748b32a36b1c101fd9ba323db0a204a96f16ac1585586425000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comI made a print/write statement debug level 3 because it was filling up the logs of global CAM and E3SM simulations. For #755 and #800 2020-03-30 11:40:25 -05005a748b32a36b1c101fd9ba323db0a204a96f16acI made a print/write statement debug level 3editadvance_clubb_core_module.F90advance_xm_wpxp_module.F90a050d6abf83b7403c321a47e310b9df7c350e8671585586685000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comI made a second print/write statement debug level 3 because it was also filling up the logs of global CAM and E3SM simulations. For #755 and #800. 2020-03-30 11:44:45 -0500a050d6abf83b7403c321a47e310b9df7c350e867I made a second print/write statement debug level 3editadvance_xm_wpxp_module.F90advance_clubb_core_module.F90f1873bdcf6480583a05d39372926472755e0c0551585587118000http://carson.math.uwm.edu/jenkins/user/guozhunguozhunguozhun@uwm.eduI fix a print/write statement debug level3. For #755 and #800 2020-03-30 11:51:58 -0500f1873bdcf6480583a05d39372926472755e0c055I fix a print/write statement debug level3. For #755 and #800editadvance_clubb_core_module.F90advance_clubb_core_module.F90clubb_api_module.F90f58158365d6813e0b2ee60497eb0774176abf0641586811945000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am replacing the "use" statements that referenced variables_diagnostic_module from advance_clubb_core and replacing them with local declarations. This requires that some additional variables are passed into and out of advance_clubb_core. Additionally, Lscale is now recalculated outside of advance_clubb_core using TKE and Kh for use in SILHS code. This makes this commit BIT_CHANGING. CLUBB GitHub Issue Reference: #876. 2020-04-13 16:05:45 -0500f58158365d6813e0b2ee60497eb0774176abf064I am replacing the "use" statements that referencededitadvance_clubb_core_module.F90editclubb_api_module.F90stats_clubb_utilities.F90advance_clubb_core_module.F900f67628552092a7d229225bac08badff3b074d621586827490000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI "brought back the stats" by passing the stats from advance_clubb_core to stats_accumulate, getting rid of the "use" statements. This commit is BIT_CHANGING, since it changes stats output. 2020-04-13 20:24:50 -05000f67628552092a7d229225bac08badff3b074d62I "brought back the stats" by passing the stats from advance_clubb_coreeditstats_clubb_utilities.F90editadvance_clubb_core_module.F90advance_clubb_core_module.F90dd9ad18fdb32917c840b9406d2ae629f51ff91b91586888964000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduRemoving the reference to variables_diagnostic_module (sigma_sqd_w_zt and rtm_ref) from subroutine pdf_closure_driver in advance_clubb_core. 2020-04-14 13:29:24 -0500dd9ad18fdb32917c840b9406d2ae629f51ff91b9Removing the reference to variables_diagnostic_module (sigma_sqd_w_zt and rtm_ref)editadvance_clubb_core_module.F90advance_clubb_core_module.F90clubb_api_module.F907a05c93c702035d8a08b1121d7e927af63e186f31586895654000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduResults were changed yesterday for some cases because thlprcp was no longer being output from advance_clubb_core for use in the calculate_thlp2_rad. This was previously accomplished through a "use" statement. The variable thlprcp is now output through the argument list of advance_clubb_core. This commit is BIT_CHANGING. 2020-04-14 15:20:54 -05007a05c93c702035d8a08b1121d7e927af63e186f3Results were changed yesterday for some cases because thlprcp waseditclubb_api_module.F90editadvance_clubb_core_module.F90advance_clubb_core_module.F906f41957ecc761aa393647629c997eb41fdb01b581586993873000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI have resolved all the issues surrounding recent CLUBB commits that remove "use" statements from the code. The commit 068a7b2 (April 8, 2020) was the commit before these refactorings started. When Lscale, Skw_zm, and thvm are passed out of CLUBB core, the code returns to a bit-for-bit match to commit 068a7b2. However, rather than pass these variables out of advance_clubb_core, it is more convenient to recalculate them locally in clubb_driver. This changes results for (a) SILHS cases, owing to the change to Lscale, and (b) all cases that advance microphysics, owing to the change to Skw_zm. The net result is that this commit is BIT_CHANGING. For cases that advance microphysics and/or use SILHS, the net result is BIT_CHANGING when compared to 068a7b2. For all other cases (BOMEX, etc.), the results are an exact match. It is important to note that host models that use CLUBB (without SILHS) will not be affected by these changes. Host models that use SILHS will only be affected by the change to Lscale. However, this code has already been applied to CAM and E3SM, so the only changes will to SILHS code in SAM and WRF. Larson Group Issue Reference: #876. 2020-04-15 18:37:53 -05006f41957ecc761aa393647629c997eb41fdb01b58I have resolved all the issues surrounding recent CLUBB commits thateditadvance_clubb_core_module.F90output_netcdf.F903603a68adcce4975fbb94a240e11deacf53efe081587852453000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comI removed code that stops a run if the output time step is less than a minute. This restriction is unnecessary if netcdf is used as the output file format. 2020-04-25 17:07:33 -05003603a68adcce4975fbb94a240e11deacf53efe08I removed code that stops a run if the output time step is less than a minute.editoutput_netcdf.F90numerical_check.F905249de8f91cd1474ce792ec4c8cd7536491a3c271588201621000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI removed references to variables_prognostic_module and variables_diagnostic_module from numerical_check.F90. CLUBB GitHub Issue Reference: #876. 2020-04-29 18:07:01 -05005249de8f91cd1474ce792ec4c8cd7536491a3c27I removed references to variables_prognostic_module andeditnumerical_check.F90advance_clubb_core_module.F903b091ac242ff2f9062505f5bff01ead16d7612e01588279420000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduFixed a boo-boo. CLUBB GitHub Issue Reference: #876. 2020-04-30 15:43:40 -05003b091ac242ff2f9062505f5bff01ead16d7612e0Fixed a boo-boo.editadvance_clubb_core_module.F90model_flags.F9036fe4d36102c43fa039370832fe42a56ded17dbc1588284059000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comI set `l_diag_Lscale_from_tau = .true.` in source code in order to match the value in configurable_model_flags.in. I did so to avoid confusion, but also to check whether doing so will allow the WRF-CLUBB lines nightly plots to better match the CLUBB standalone lines. For larson-group/wrf#105. 2020-04-30 17:00:59 -050036fe4d36102c43fa039370832fe42a56ded17dbcI set `l_diag_Lscale_from_tau = .true.` in source codeeditmodel_flags.F90stats_clubb_utilities.F9029ad608ebd198f28b74757885b31ac09cf6d49891588625963000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI removed references to variable_diagnostic_module for various Kessler Autoconversion variables that are being output to statistics. CLUBB Git Issue Reference: #876. 2020-05-04 15:59:23 -050029ad608ebd198f28b74757885b31ac09cf6d4989I removed references to variable_diagnostic_module for various Kesslereditstats_clubb_utilities.F90setup_clubb_pdf_params.F90clubb_api_module.F9006e6739507c93d6cc3c2aadb4d262a024b0f3eab1588632211000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI removed the reference to use variables_diagnostic_module for Kh_zm found in setup_clubb_pdf_params.F90. The variable Kh_zm can easily be passed in instead. CLUBB Git Issue Reference: #876. 2020-05-04 17:43:31 -050006e6739507c93d6cc3c2aadb4d262a024b0f3eabI removed the reference to use variables_diagnostic_module for Kh_zmeditclubb_api_module.F90editsetup_clubb_pdf_params.F90diagnose_correlations_module.F906f2f593c5bd5306818c121ecfb043d9fc6687c9a1588635738000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduRemoved a reference to variables_diagnostic_module for Kh_zm in approx_w_corr. I passed the variable in instead. CLUBB Github Issue Reference: #876. 2020-05-04 18:42:18 -05006f2f593c5bd5306818c121ecfb043d9fc6687c9aRemoved a reference to variables_diagnostic_module for Kh_zm ineditdiagnose_correlations_module.F90clubb_api_module.F90efec25c6dc6ff1e4d8a4162088208012a97e00391588637567000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am able to remove references to variables_prognostic_module and variables_diagnostic_module from clubb_api_module. CLUBB GitHub Issue References: #876. 2020-05-04 19:12:47 -0500efec25c6dc6ff1e4d8a4162088208012a97e0039I am able to remove references to variables_prognostic_module andeditclubb_api_module.F90mixing_length.F90advance_clubb_core_module.F90model_flags.F90variables_diagnostic_module.F90clubb_api_module.F90variables_prognostic_module.F90752666bf1bdfa947fe94b37b82aa090098df8cc31588697383000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI removed the l_use_ice_latent flag from the code, and along with it all the _frz variables. The results in GrADS output files from this revision are an exact match to the results in GraDS output files from the previous revision for all cases. CLUBB GitHub Issue Reference: #876. 2020-05-05 11:49:43 -0500752666bf1bdfa947fe94b37b82aa090098df8cc3I removed the l_use_ice_latent flag from the code, and along with iteditvariables_prognostic_module.F90editmodel_flags.F90editmixing_length.F90editvariables_diagnostic_module.F90editadvance_clubb_core_module.F90editclubb_api_module.F90configurable_model_flags.inf36fde9791fa4f1ef14f301186af68df5e15ac321588697383000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI removed the l_use_ice_latent flag from the code, and along with it all the _frz variables. The results in GrADS output files from this revision are an exact match to the results in GraDS output files from the previous revision for all cases. CLUBB GitHub Issue Reference: #876. 2020-05-05 11:49:43 -0500f36fde9791fa4f1ef14f301186af68df5e15ac32I removed the l_use_ice_latent flag from the code, and along with iteditconfigurable_model_flags.inadvance_clubb_core_module.F90variables_diagnostic_module.F90clubb_api_module.F90variables_prognostic_module.F90e81b40abf9a543b2a1bc51d8e266903d13a9fc2f1588984893000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI have completed the project of removing variables_prognostic_module and variables_diagnostic_module from the CLUBB code. The results in GrADS output files from this revision are an exact match to the results found in GrADS output files from the previous revision for all cases. CLUBB Git Issue Reference: #876. 2020-05-08 19:41:33 -0500e81b40abf9a543b2a1bc51d8e266903d13a9fc2fI have completed the project of removing variables_prognostic_moduleeditadvance_clubb_core_module.F90editclubb_api_module.F90deletevariables_prognostic_module.F90deletevariables_diagnostic_module.F90parameters_tunable.F901bdd34c6481b3c01f82b877f62a93ba370e5b9ed1589154053000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comI added some missing threadprivate statements in order to eliminate a warning from the check_for_missing_threadprivate.py script. 2020-05-10 18:40:53 -05001bdd34c6481b3c01f82b877f62a93ba370e5b9edI added some missing threadprivate statementseditparameters_tunable.F90advance_wp2_wp3_module.F90e2826f017c87d3cd240aa7fc22795fe1a4ac161c1589849026000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI have taken the code from wp2_term_ta_all and placed it in the subroutine wp2_term_ta. This combines the former, verbose description with the new optimized code. This also eliminates an unused function and gets rid of a compiler warning. 2020-05-18 19:43:46 -0500e2826f017c87d3cd240aa7fc22795fe1a4ac161cI have taken the code from wp2_term_ta_all and placed it in the subroutineeditadvance_wp2_wp3_module.F90advance_wp2_wp3_module.F90e0d302767e3733455f3dde87b01472c1eb9ee1a61589929080000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am updating wp3_term_ta_new_pdf_lhs to use the optimized code from wp3_term_ta_new_pdf_lhs_all, and then I am removing wp3_term_ta_new_pdf_lhs_all from the code. This eliminates a compiler error. 2020-05-19 17:58:00 -0500e0d302767e3733455f3dde87b01472c1eb9ee1a6I am updating wp3_term_ta_new_pdf_lhs to use the optimized code fromeditadvance_wp2_wp3_module.F90parameters_tunable.F90df5510e777de2b9360c836491d81db6920bf07be1590592049000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comThis commit is BIT_CHANGING. It makes the parameter values in parameters_tunable.F90 agree with those in tunable_parameters.in 2020-05-27 10:07:29 -0500df5510e777de2b9360c836491d81db6920bf07beThis commit is BIT_CHANGING. It makes the parameter values in parameters_tunable.F90 agree with those in tunable_parameters.ineditparameters_tunable.F90advance_clubb_core_module.F90advance_xp2_xpyp_module.F90249ed5dd4ff58c54c3bcd841658e556f7ee999b31591212970000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am making the change of using tau_wp2_zm to damp up2 and vp2, rather than tau_xp2_zm, when l_diag_Lscale_from_tau is enabled. The previous code was causing up2 and vp2 to become large and unstable. Additionally, I placed a limiter on tau based on Lscale_max in the CLUBB code for the situation where l_diag_Lscale_from_tau is enabled. This will help constrict tau, and thereby the magnitudes of turbulent fields, in a host model as grid spacing starts to become arbitrarily small and resolved features take over. This revision is BIT_CHANGING. 2020-06-03 14:36:10 -0500249ed5dd4ff58c54c3bcd841658e556f7ee999b3I am making the change of using tau_wp2_zm to damp up2 and vp2,editadvance_xp2_xpyp_module.F90editadvance_clubb_core_module.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90model_flags.F90clubb_api_module.F90advance_xm_wpxp_module.F90pdf_closure_module.F90setup_clubb_pdf_params.F90a59618b0d5bb86a20829495f774d7b95b59fa7c01591892411000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI have added the integer flags iiPDF_type and ipdf_call_placement to the clubb_config_flags type. They have also been added to configurable_model_flags.in. The results in GrADS output files from this revision are an exact match to the result in GrADS output files from the previous revision for all cases. 2020-06-11 11:20:11 -0500a59618b0d5bb86a20829495f774d7b95b59fa7c0I have added the integer flags iiPDF_type and ipdf_call_placementeditmodel_flags.F90editpdf_closure_module.F90editadvance_wp2_wp3_module.F90editclubb_api_module.F90editadvance_clubb_core_module.F90editadvance_xp2_xpyp_module.F90editadvance_xm_wpxp_module.F90editsetup_clubb_pdf_params.F90configurable_model_flags.ind4e1cc78a447eda4ffd31d480db1fb7c0c6eefd61591892411000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI have added the integer flags iiPDF_type and ipdf_call_placement to the clubb_config_flags type. They have also been added to configurable_model_flags.in. The results in GrADS output files from this revision are an exact match to the result in GrADS output files from the previous revision for all cases. 2020-06-11 11:20:11 -0500d4e1cc78a447eda4ffd31d480db1fb7c0c6eefd6I have added the integer flags iiPDF_type and ipdf_call_placementeditconfigurable_model_flags.inclubb_api_module.F90935b507b50e147ce7e4cb1aefde6b167312b5aa01591904998000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am going to make primary PDF type options and primary PDF call position options available to host models. 2020-06-11 14:49:58 -0500935b507b50e147ce7e4cb1aefde6b167312b5aa0I am going to make primary PDF type options and primary PDF calleditclubb_api_module.F90mixing_length.F90advance_xp2_xpyp_module.F90stats_clubb_utilities.F90lapack_wrap.F9003a057fc0fa742bf5903cebd6c39a6cabe084a541592253292000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added E3SM customizations to CLUBB's master branch. This is meant for updating CLUBB in the E3SM master branch. 2020-06-15 15:34:52 -050003a057fc0fa742bf5903cebd6c39a6cabe084a54I added E3SM customizations to CLUBB's master branch. This is meanteditadvance_xp2_xpyp_module.F90editlapack_wrap.F90editmixing_length.F90editstats_clubb_utilities.F90parameters_tunable.F901d961006eb841164ff42b461bf2cc5465c0fe4de1592499699000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am updating the clubb_ list of namelist parameters used in E3SM to include every parameter that E3SM has customized in CLUBB. The goal is to make it so E3SM does not need to customize the CLUBB side of E3SM-CLUBB at all, making future upgrades easier. 2020-06-18 12:01:39 -05001d961006eb841164ff42b461bf2cc5465c0fe4deI am updating the clubb_ list of namelist parameters used in E3SMeditparameters_tunable.F90parameters_tunable.F903a2dcd52a4c69c428255318e8e22ee90adb7a4911592499991000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduTypo 2020-06-18 12:06:31 -05003a2dcd52a4c69c428255318e8e22ee90adb7a491Typoeditparameters_tunable.F90parameters_tunable.F90ca809e21e6bf2df918484017d9126c244003e1ef1592500303000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduFixed more typos 2020-06-18 12:11:43 -0500ca809e21e6bf2df918484017d9126c244003e1efFixed more typoseditparameters_tunable.F90new_hybrid_pdf_main.F9029c5dd3a6fd55e6a294aed63e5e6029810e970fa1592517157000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am changing the new hybrid PDF's calculation of F_w to use tunable parameter gamma (technically, the gamma_Skw_fnc). In the ADG1 PDF, when gamma_Skw_fnc goes to 0, the standard deviations of w in each PDF component both go to 0, and the spread between the PDF component means of w is at its maximum. When gamma_Skw_fnc goes to 1, the standard deviations of w in each PDF component become large, and the spread between the PDF component means of w becomes small. The new hybrid PDF is based on the same concept, except that I had been using a hard-wired 0.75 in the place of gamma or the gamma_Skw_fnc. Re-using the tunable parameters for gamma here makes sense, since it's the same concept and this makes tuning easier. 2020-06-18 16:52:37 -050029c5dd3a6fd55e6a294aed63e5e6029810e970faI am changing the new hybrid PDF's calculation of F_w to useeditnew_hybrid_pdf_main.F90advance_clubb_core_module.F90bfde3dd3cab8d57d726caebb7544a3f171dd24bc1592857658000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI updated the xp3 calculation for PDF types other than ADG1. ADG1 is stuck into using the LG 2005 ansatz, exactly as written. Other PDF types are not stuck using this. Rather than re-invent the wheel, these other PDF types can still use the LG 2005 ansatz equation, but sigma_sqd_w_zt (specific to ADG1) has been replaced with a tunable function relavant to other PDF types. This tunable function is called xp3_coef_fnc. The results in GrADS output files from the previous revision are an exact match to the results in GrADS output files from the current revision for all cases for the default ADG1 PDF. 2020-06-22 15:27:38 -0500bfde3dd3cab8d57d726caebb7544a3f171dd24bcI updated the xp3 calculation for PDF types other than ADG1.editadvance_clubb_core_module.F90advance_clubb_core_module.F90b9a3fc1cb5be1eedbf0543b5a29bf413d833246b1592922724000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduThis xp3_coef_ parameters produce new hybrid PDF results similar to the old ones for a starting point. 2020-06-23 09:32:04 -0500b9a3fc1cb5be1eedbf0543b5a29bf413d833246bThis xp3_coef_ parameters produce new hybrid PDF results similar to the oldeditadvance_clubb_core_module.F90advance_clubb_core_module.F90parameters_tunable.F90parameter_indices.F9017b61c278e074b0f13c0b7a3c7249b68c911d0961592937236000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added the 2 new parameters in the simple xp3 equation (for PDF types other than ADG1) to the list of CLUBB tunable parameters. The results in GrADS output files from this revision are an exact match to the results in GrADS output files from the previous revision for all cases. 2020-06-23 13:33:56 -050017b61c278e074b0f13c0b7a3c7249b68c911d096I added the 2 new parameters in the simple xp3 equation (for PDFeditadvance_clubb_core_module.F90editparameter_indices.F90editparameters_tunable.F90tunable_parameters.inc0b90072ce137d77b0354d2884c936f1cfec00b01592937236000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added the 2 new parameters in the simple xp3 equation (for PDF types other than ADG1) to the list of CLUBB tunable parameters. The results in GrADS output files from this revision are an exact match to the results in GrADS output files from the previous revision for all cases. 2020-06-23 13:33:56 -0500c0b90072ce137d77b0354d2884c936f1cfec00b0I added the 2 new parameters in the simple xp3 equation (for PDFedittunable_parameters.inadvance_wp2_wp3_module.F90ec26fc272f08735e68e710da38363b7efd0dd57c1594325433000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI have combined the wp3_term_ta_ADG1_lhs and wp3_term_ta_ADG1_lhs_all routines into one subroutine. This is done to remove a compiler warning, simplify the code, and prep the code for the wp3 partial upwinding. The results in GrADS output files from this revision are an exact match to the results in GrADS output files from the previous revision for all cases. Larson Group GitHub Issue Reference: #877. 2020-07-09 15:10:33 -0500ec26fc272f08735e68e710da38363b7efd0dd57cI have combined the wp3_term_ta_ADG1_lhs and wp3_term_ta_ADG1_lhs_alleditadvance_wp2_wp3_module.F90advance_wp2_wp3_module.F90advance_clubb_core_module.F90306b627bcb23d1b499a98adeaed955ca6abb177f1594340218000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added the partially upwinded implementation of the wp3 turbulent advection term for ADG1 to the code. It is turned off by default. The results in GrADS output files from this revision are an exact match to the results in GrADS output files from the previous revision for all cases. Larson Group GitHub Issue Reference: #877. 2020-07-09 19:16:58 -0500306b627bcb23d1b499a98adeaed955ca6abb177fI added the partially upwinded implementation of the wp3 turbulent advectioneditadvance_wp2_wp3_module.F90editadvance_clubb_core_module.F90advance_wp2_wp3_module.F90mixing_length.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90output_netcdf.F90pdf_closure_module.F90Skx_module.F90adg1_adg2_3d_luhar_pdf.F90calc_roots.F90surface_varnce_module.F90mono_flux_limiter.F908d6af15804e294c451e5055c922a26971c8d95301594355055000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comRemoved unused module imports 2020-07-09 23:24:15 -05008d6af15804e294c451e5055c922a26971c8d9530Removed unused module importseditadg1_adg2_3d_luhar_pdf.F90editmono_flux_limiter.F90editsurface_varnce_module.F90editpdf_closure_module.F90editcalc_roots.F90editadvance_wp2_wp3_module.F90editoutput_netcdf.F90editmixing_length.F90editadvance_xp2_xpyp_module.F90editadvance_xm_wpxp_module.F90editSkx_module.F90editadvance_clubb_core_module.F90est_kessler_microphys_module.F90latin_hypercube_driver_module.F9095246a59cf7daf42bea1f966cd0bfe71eaae04f01594355055000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comRemoved unused module imports 2020-07-09 23:24:15 -050095246a59cf7daf42bea1f966cd0bfe71eaae04f0Removed unused module importseditest_kessler_microphys_module.F90editlatin_hypercube_driver_module.F90output_netcdf.F905aff71092d08c4cbcbbdc88c9c4823996750edfc1594358588000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comRemoved a comma that I missed while removing unused imports (#878) 2020-07-10 00:23:08 -05005aff71092d08c4cbcbbdc88c9c4823996750edfcRemoved a comma that I missed while removing unused imports (#878)editoutput_netcdf.F90advance_wp2_wp3_module.F90advance_clubb_core_module.F90model_flags.F90clubb_api_module.F9057147620713193e3f760ea88538641e52349ab841594405853000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am adding l_partial_upwind_wp3 to the list of clubb_config_flags. Larson Group GitHub Issue Reference: #877. 2020-07-10 13:30:53 -050057147620713193e3f760ea88538641e52349ab84I am adding l_partial_upwind_wp3 to the list of clubb_config_flags.editadvance_wp2_wp3_module.F90editmodel_flags.F90editclubb_api_module.F90editadvance_clubb_core_module.F90configurable_model_flags.inbca72900e7def207f09786461054c2735689147e1594405853000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am adding l_partial_upwind_wp3 to the list of clubb_config_flags. Larson Group GitHub Issue Reference: #877. 2020-07-10 13:30:53 -0500bca72900e7def207f09786461054c2735689147eI am adding l_partial_upwind_wp3 to the list of clubb_config_flags.editconfigurable_model_flags.inparameters_silhs.F90latin_hypercube_driver_module.F906e6f394fa3e64d52dd788789db41f5cd35349ade1594769616000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduDeprecating use of l_Lscale_vert_avg in SILHS. This is causing problems with the GPUization efforts, described in larson-group/cam#129 2020-07-14 18:33:36 -05006e6f394fa3e64d52dd788789db41f5cd35349adeDeprecating use of l_Lscale_vert_avg in SILHS. This is causing problems with the GPUization efforts, described in larson-group/cam#129editparameters_silhs.F90editlatin_hypercube_driver_module.F90configurable_model_flags.in53e11d4bc74ec8726ae4917a179846de5908aba81594835925000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding clubb case files that were missed from last commit larson-group/cam#129 2020-07-15 12:58:45 -050053e11d4bc74ec8726ae4917a179846de5908aba8Adding clubb case files that were missed from last commit larson-group/cam#129editconfigurable_model_flags.inadvance_wp2_wp3_module.F900564f82db8dd12fafc465a90d1a283989482f3921594844985000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI started the process of paring 2 subprograms back down to 1 in advance_wp2_wp3_module. Everything remains an exact match. CLUBB Issue ref: #878. 2020-07-15 15:29:45 -05000564f82db8dd12fafc465a90d1a283989482f392I started the process of paring 2 subprograms back down to 1 ineditadvance_wp2_wp3_module.F90advance_wp2_wp3_module.F908b33c3ed3462f2c340836eb9276e7123eeef25941594850157000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI pared two more sets of equivalent subprograms down to 1 (each). Bittos are ditto Git Issue #878 2020-07-15 16:55:57 -05008b33c3ed3462f2c340836eb9276e7123eeef2594I pared two more sets of equivalent subprograms down to 1 (each).editadvance_wp2_wp3_module.F90advance_wp2_wp3_module.F90034ddd2f57c2ba3d33368744e6268aec8fc4510a1594856144000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduParing down 2 equivalent subprograms to 1 again. Just call me "The Reducer" Bittos are ditto Issue #878 2020-07-15 18:35:44 -0500034ddd2f57c2ba3d33368744e6268aec8fc4510aParing down 2 equivalent subprograms to 1 again.editadvance_wp2_wp3_module.F90advance_wp2_wp3_module.F909a48a69a9139f2d8b3ed6c0b9d729fe2439d7fa41594966970000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI condensed two more sets of doubled subprograms down to 1 (each) in advance_wp2_wp3_module.F90. Bittos are ditto. Big Issue #878. 2020-07-17 01:22:50 -05009a48a69a9139f2d8b3ed6c0b9d729fe2439d7fa4I condensed two more sets of doubled subprograms down to 1 (each)editadvance_wp2_wp3_module.F90advance_wp2_wp3_module.F90f6211090a551eae9f5de3c2b60944efcc10e14581595010013000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduReduced two more sets of "doubled" subprograms down. Bit-for-bit 2020-07-17 13:20:13 -0500f6211090a551eae9f5de3c2b60944efcc10e1458Reduced two more sets of "doubled" subprograms down.editadvance_wp2_wp3_module.F90latin_hypercube_driver_module.F90c1b8935e7a81f9c4c6706b949e764cb1b46ea7261595023743000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduUpdating silhs to prepare the column loop commit. This is being committed seperately because it is BIT_CHANGING, due to the way we are initializing the random number generator on CPUs. larson-group/cam#129 2020-07-17 17:09:03 -0500c1b8935e7a81f9c4c6706b949e764cb1b46ea726Updating silhs to prepare the column loop commit. This is being committed seperately because it is BIT_CHANGING, due to the way we are initializing the random number generator on CPUs. larson-group/cam#129editlatin_hypercube_driver_module.F90silhs_api_module.F90transform_to_pdf_module.F90latin_hypercube_driver_module.F90456aaaad293ba2c1218c740543884c90dc9154511595026759000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding column loop index to silhs, and pushing loops down to allow parallelization over the column index. This requries changing the api, but it is bit-for-bit running on both gpus and cpus. larson-group/cam#129 2020-07-17 17:59:19 -0500456aaaad293ba2c1218c740543884c90dc915451Adding column loop index to silhs, and pushing loops down to allow parallelization over the column index. This requries changing the api, but it is bit-for-bit running on both gpus and cpus. larson-group/cam#129editsilhs_api_module.F90editlatin_hypercube_driver_module.F90edittransform_to_pdf_module.F90advance_clubb_core_module.F90097dc4653aefee568ab81cf9f5ce6d112cd172bc1595170691000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comI updated CLUBB's copyright date range. 2020-07-19 09:58:11 -0500097dc4653aefee568ab81cf9f5ce6d112cd172bcI updated CLUBB's copyright date range.editadvance_clubb_core_module.F90silhs_api_module.F909301e56822e1b0f7d4d5ec1a7cfa21fb27ee48aa1595279402000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding interface in silhs_api to distinguish single vs multiple comulmn calls. This seems to be a better solution than the previous attempt that broke the nightly tests. When calling silhs a single column at a time, the api will copy the single column data into arrays with a grid column index, allowing us to leave the host models the same. larson-group/cam#129 2020-07-20 16:10:02 -05009301e56822e1b0f7d4d5ec1a7cfa21fb27ee48aaAdding interface in silhs_api to distinguish single vs multiple comulmn calls. This seems to be a better solution than the previous attempt that broke the nightly tests. When calling silhs a single column at a time, the api will copy the single column data into arrays with a grid column index, allowing us to leave the host models the same. larson-group/cam#129editsilhs_api_module.F90pdf_closure_module.F90bca9c6c8c0fb9a04fe5bd806cea2cd892bd9a95b1595347943000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comRemoved unused parameters [-Wunused-parameter] Output files are the same Issue #878 2020-07-21 11:12:23 -0500bca9c6c8c0fb9a04fe5bd806cea2cd892bd9a95bRemoved unused parameters [-Wunused-parameter]editpdf_closure_module.F90est_kessler_microphys_module.F90449ee02d46ebe4950dc9b8a3b4a0ee87b8b862721595347943000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comRemoved unused parameters [-Wunused-parameter] Output files are the same Issue #878 2020-07-21 11:12:23 -0500449ee02d46ebe4950dc9b8a3b4a0ee87b8b86272Removed unused parameters [-Wunused-parameter]editest_kessler_microphys_module.F90advance_wp2_wp3_module.F90632fe0cffdcec677fb17c73e49fb19b8b3652c501595441614000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduTaking more duplicated subprograms and paring them down to 1. bit-4-bit; #878 2020-07-22 13:13:34 -0500632fe0cffdcec677fb17c73e49fb19b8b3652c50Taking more duplicated subprograms and paring them down to 1.editadvance_wp2_wp3_module.F90precipitation_fraction.F90advance_xp2_xpyp_module.F90parameters_tunable.F90advance_clubb_core_module.F90corr_varnce_module.F909d86e038a81f32899f20fe4c88883959891b8df01595452586000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comReplaced real checks with an epsilon approach [-Wcompare-reals] This commit should be BIT_CHANGING I accidentally put in a couple extra imports, will clean those out later Issue #878 2020-07-22 16:16:26 -05009d86e038a81f32899f20fe4c88883959891b8df0Replaced real checks with an epsilon approach [-Wcompare-reals]editadvance_xp2_xpyp_module.F90editcorr_varnce_module.F90editparameters_tunable.F90editprecipitation_fraction.F90editadvance_clubb_core_module.F90transform_to_pdf_module.F90silhs_importance_sample_module.F90fc375203e4d5f3ad2dd3ba40a8aedbdc2dd803521595452586000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comReplaced real checks with an epsilon approach [-Wcompare-reals] This commit should be BIT_CHANGING I accidentally put in a couple extra imports, will clean those out later Issue #878 2020-07-22 16:16:26 -0500fc375203e4d5f3ad2dd3ba40a8aedbdc2dd80352Replaced real checks with an epsilon approach [-Wcompare-reals]edittransform_to_pdf_module.F90editsilhs_importance_sample_module.F90corr_varnce_module.F904b370fe2ff24fd2d86598424c74361424ad9a94d1595456190000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comRemoved unused imports [-Wunused-parameter] Output is the same Issue #878 2020-07-22 17:16:30 -05004b370fe2ff24fd2d86598424c74361424ad9a94dRemoved unused imports [-Wunused-parameter]editcorr_varnce_module.F90transform_to_pdf_module.F90silhs_importance_sample_module.F906847aef50658a5a288954b592c9b6adf2cc491cd1595456190000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comRemoved unused imports [-Wunused-parameter] Output is the same Issue #878 2020-07-22 17:16:30 -05006847aef50658a5a288954b592c9b6adf2cc491cdRemoved unused imports [-Wunused-parameter]edittransform_to_pdf_module.F90editsilhs_importance_sample_module.F90precipitation_fraction.F9005f74998aa1912a02200c80b70fb9cac56d08e8a1595457956000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comRemoved styleguide violations from my code No change Issue #878 2020-07-22 17:45:56 -050005f74998aa1912a02200c80b70fb9cac56d08e8aRemoved styleguide violations from my codeeditprecipitation_fraction.F90parameters_tunable.F906cf01d6f24826da6eaaaec443d1c95ab8666bf8f1595520309000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comFixed a backwards epsilon comparison from 8e8e71e Results look identical Issue #878 2020-07-23 11:05:09 -05006cf01d6f24826da6eaaaec443d1c95ab8666bf8fFixed a backwards epsilon comparison from 8e8e71eeditparameters_tunable.F90advance_wp2_wp3_module.F90d9c9f9014093b3cfe7216f227621ff7bff260a2b1595525828000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduRemoved the "doubling" of the remainder of the subprograms from advance_wp2_wp3_module.F90. Bit-for-bit; #878. 2020-07-23 12:37:08 -0500d9c9f9014093b3cfe7216f227621ff7bff260a2bRemoved the "doubling" of the remainder of the subprograms fromeditadvance_wp2_wp3_module.F90silhs_importance_sample_module.F9022eea6c0663459539b20863acdf61094a4ee94111595540475000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduChanging epsilon used in equality comparison. The previous epsilon seems to be too large, and was causing failures in runs. larson-group/clubb#878 2020-07-23 16:41:15 -050022eea6c0663459539b20863acdf61094a4ee9411Changing epsilon used in equality comparison. The previous epsilon seems to be too large, and was causing failures in runs. larson-group/clubb#878editsilhs_importance_sample_module.F90latin_hypercube_driver_module.F909cf48dc3ffd702155f175a832543b1ccea5c2cc11595543971000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduSmall changes to generate_all_uniform_samples. I was encountering a gpu problem with this code when run in cam. I'm not certain why this is an issue, but this changes fixes it and is bit-for-bit on both cpus and gpus. larson-group/cam#129 2020-07-23 17:39:31 -05009cf48dc3ffd702155f175a832543b1ccea5c2cc1Small changes to generate_all_uniform_samples. I was encountering a gpu problem with this code when run in cam. I'm not certain why this is an issue, but this changes fixes it and is bit-for-bit on both cpus and gpus. larson-group/cam#129editlatin_hypercube_driver_module.F90advance_xp2_xpyp_module.F90483e2dd3ae6245537b6c0b32ae8edb726e0ec49d1595608276000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comChanged the length of solve_type_str to 20 [-Wcharacter-trucation] Unchanged Issue #878 2020-07-24 11:31:16 -0500483e2dd3ae6245537b6c0b32ae8edb726e0ec49dChanged the length of solve_type_str to 20 [-Wcharacter-trucation]editadvance_xp2_xpyp_module.F90advance_clubb_core_module.F90pdf_closure_module.F90numerical_check.F90f10b9dd183a5aabfab4130401217a1f3a21901451595619599000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comRemoved unused arguments [-Wunused-dummy-argument] Unchanged The removed lines were commented out, opposed to deleted An if statement with continue was added to remove the warning without changing the method signature (clubb_driver.F90) Issue #878 2020-07-24 14:39:59 -0500f10b9dd183a5aabfab4130401217a1f3a2190145Removed unused arguments [-Wunused-dummy-argument]editnumerical_check.F90editpdf_closure_module.F90editadvance_clubb_core_module.F90silhs_api_module.F90latin_hypercube_driver_module.F907f8e2668c4728e4a1839307214d9ab340c7f80221595619599000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comRemoved unused arguments [-Wunused-dummy-argument] Unchanged The removed lines were commented out, opposed to deleted An if statement with continue was added to remove the warning without changing the method signature (clubb_driver.F90) Issue #878 2020-07-24 14:39:59 -05007f8e2668c4728e4a1839307214d9ab340c7f8022Removed unused arguments [-Wunused-dummy-argument]editlatin_hypercube_driver_module.F90editsilhs_api_module.F90advance_clubb_core_module.F9008c14a70ec4411e52e17b7c44d135a634640d8021595622374000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comRemoved unused variables [-Wunused-variable] Unchanged Issue #878 2020-07-24 15:26:14 -050008c14a70ec4411e52e17b7c44d135a634640d802Removed unused variables [-Wunused-variable]editadvance_clubb_core_module.F90latin_hypercube_driver_module.F900368ceb837a6b9adee914c68662dadfd7f25ee9f1595622374000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comRemoved unused variables [-Wunused-variable] Unchanged Issue #878 2020-07-24 15:26:14 -05000368ceb837a6b9adee914c68662dadfd7f25ee9fRemoved unused variables [-Wunused-variable]editlatin_hypercube_driver_module.F90advance_wp2_wp3_module.F90advance_xm_wpxp_module.F90fe8a2ccd15709427486d06dafd69dc519867e4a51595651752000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI have tidied up advance_wp2_wp3_module.F90, and I have removed all doubled subprograms from advance_xm_wpxp_module.F90. The results in GrADS output files from this revision is an exact match to the results in GrADS output files from the previous revision for all cases. Git Issue: #878. 2020-07-24 23:35:52 -0500fe8a2ccd15709427486d06dafd69dc519867e4a5I have tidied up advance_wp2_wp3_module.F90, and I have removed all doublededitadvance_xm_wpxp_module.F90editadvance_wp2_wp3_module.F90advance_clubb_core_module.F90d8bc4555b03e0c49bb2b8808efe15ae35e017c751595867355000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comRemoved continue and undid edits to _api fuction signatures Unchanged I left the edits to underlying fuctions, as they never used the argument in the code Issue #878 2020-07-27 11:29:15 -0500d8bc4555b03e0c49bb2b8808efe15ae35e017c75Removed continue and undid edits to _api fuction signatureseditadvance_clubb_core_module.F90silhs_api_module.F90d7e922c9ca41866d18f23e65a3478ec02c98874d1595867355000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comRemoved continue and undid edits to _api fuction signatures Unchanged I left the edits to underlying fuctions, as they never used the argument in the code Issue #878 2020-07-27 11:29:15 -0500d7e922c9ca41866d18f23e65a3478ec02c98874dRemoved continue and undid edits to _api fuction signatureseditsilhs_api_module.F90advance_xm_wpxp_module.F90turbulent_adv_pdf.F90advance_xp2_xpyp_module.F90914eb7dae9384c3270c7b2c99eee761501283f0a1595888691000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI handled the "doubled" subprograms in turbulent_adv_pdf.F90. The results in GrADS output files from this revision are an exact match to the results in GrADS output files from the previous revision for all cases. CLUBB Git Issue Reference: #878. 2020-07-27 17:24:51 -0500914eb7dae9384c3270c7b2c99eee761501283f0aI handled the "doubled" subprograms in turbulent_adv_pdf.F90.editadvance_xm_wpxp_module.F90editturbulent_adv_pdf.F90editadvance_xp2_xpyp_module.F90silhs_importance_sample_module.F906bdf29385494f979f22af881d5da3986ecc321941595977411000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking change explained in larson-group/clubb#878 2020-07-28 18:03:31 -05006bdf29385494f979f22af881d5da3986ecc32194Making change explained in larson-group/clubb#878editsilhs_importance_sample_module.F90silhs_api_module.F90a5ab148417dedb799c61717b7a44a34430fed4451596045831000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comRemoved some unused variables (ifort) Unchanged Issue #878 2020-07-29 13:03:51 -0500a5ab148417dedb799c61717b7a44a34430fed445Removed some unused variables (ifort)editsilhs_api_module.F90mixing_length.F90advance_clubb_core_module.F903f2c34376025ac4068b02cef98494749c4e805251596045831000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comRemoved some unused variables (ifort) Unchanged Issue #878 2020-07-29 13:03:51 -05003f2c34376025ac4068b02cef98494749c4e80525Removed some unused variables (ifort)editmixing_length.F90editadvance_clubb_core_module.F90silhs_api_module.F90latin_hypercube_driver_module.F90e842d008e8fe68edd0da7490e49615d91082013d1596062769000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding functionality to pass in a seed for the random number generator. This allows CPU restart runs to function correctly. Because this also changes the seed, this is BIT_CHANGING. larson-group/cam#129 2020-07-29 17:46:09 -0500e842d008e8fe68edd0da7490e49615d91082013dAdding functionality to pass in a seed for the random number generator. This allows CPU restart runs to function correctly. Because this also changes the seed, this is BIT_CHANGING. larson-group/cam#129editlatin_hypercube_driver_module.F90editsilhs_api_module.F90silhs_importance_sample_module.F908a2c24804fd34888208aa27b643ab52e33e067031596126782000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comRemoved unused import [-Wunused-variable] Unchanged Issue #878 2020-07-30 11:33:02 -05008a2c24804fd34888208aa27b643ab52e33e06703Removed unused import [-Wunused-variable]editsilhs_importance_sample_module.F90pdf_closure_module.F905bb72140ec0db6dab4e53e75ecbb8510c01aecfa1596663751000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comRemoves unused function calc_cloud_frac [-Wunused-function] Unchanged Issue #878 2020-08-05 16:42:31 -05005bb72140ec0db6dab4e53e75ecbb8510c01aecfaRemoves unused function calc_cloud_frac [-Wunused-function]editpdf_closure_module.F90lapack_wrap.F90c97ab5e47db3ed88257fcc45e1de5caef4afa3b71596668117000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comFixes style issue Moves comment from line over 100 characters long to the line above Issue #878 2020-08-05 17:55:17 -0500c97ab5e47db3ed88257fcc45e1de5caef4afa3b7Fixes style issueeditlapack_wrap.F90parameters_tunable.F907baba2d841e751bb06d54b66ddaddda8083e3d791596669082000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comRemoved import without only as it was unused Issue #878 2020-08-05 18:11:22 -05007baba2d841e751bb06d54b66ddaddda8083e3d79Removed import without only as it was unusededitparameters_tunable.F90parameters_tunable.F908391e3009cda96dfa0b4e0e3fe3784fe7ba2019e1596727382000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comAdds mpishorthand back with only, it appears to be used somewhere Unchanged I didn't receive any warnings, because the code was incased in #ifdef SPMD Issue #878 2020-08-06 10:23:02 -05008391e3009cda96dfa0b4e0e3fe3784fe7ba2019eAdds mpishorthand back with only, it appears to be used somewhereeditparameters_tunable.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90diffusion.F90advance_windm_edsclrm_module.F90advance_xm_wpxp_module.F90206d072088418f9ca4f5ffb8ddd71121628adcea1597427608000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI have pared two subprograms down to one again, this time for the subprograms found in module diffusion. As part of this, the calls to diffusion (for turbulent advection) in advance_microphys_module.F90 needed to be upgraded to use the fully optimized version of the code. As a result, this revision is BIT_CHANGING, but only for cases that use microphysics. A print out of the LHS array from the call to diffusion shows that numbers are in agreement until you reach the point of numerical roundoff. CLUBB Git Issue Reference: #878. 2020-08-14 12:53:28 -0500206d072088418f9ca4f5ffb8ddd71121628adceaI have pared two subprograms down to one again, this time for theeditadvance_wp2_wp3_module.F90editadvance_windm_edsclrm_module.F90editdiffusion.F90editadvance_xp2_xpyp_module.F90editadvance_xm_wpxp_module.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90advance_xm_wpxp_module.F90advance_windm_edsclrm_module.F90mean_adv.F90mono_flux_limiter.F904df2dce7f6eeccf089d00ca91c7a158eef35dd441597683534000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI pared down subprogram pairs again, this time for mean advection. The results from this revision are an exact match to the result from the previous revision for all cases. Larson Group Issue Reference: #878. 2020-08-17 11:58:54 -05004df2dce7f6eeccf089d00ca91c7a158eef35dd44I pared down subprogram pairs again, this time for mean advection.editadvance_wp2_wp3_module.F90editmean_adv.F90editadvance_xp2_xpyp_module.F90editadvance_xm_wpxp_module.F90editmono_flux_limiter.F90editadvance_windm_edsclrm_module.F90parameters_tunable.F90parameter_indices.F90advance_xm_wpxp_module.F900a804e329df446504755639568533d43c71aa38c1597689543000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added altitude_threshold to the list of CLUBB's tunable parameters. The results in GrADS output files from this revision are an exact match to the results in GrADS output files from the previous revision for all cases. However, NetCDF output files are not an exact match, owing to the presence of the new tunable parameter listed in the output files. That technically makes this revision BIT_CHANGING. 2020-08-17 13:39:03 -05000a804e329df446504755639568533d43c71aa38cI added altitude_threshold to the list of CLUBB's tunable parameters.editparameter_indices.F90editadvance_xm_wpxp_module.F90editparameters_tunable.F90tunable_parameters.inebcd262f4b199e4874305d4af9bc8d6908b637dc1597689543000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added altitude_threshold to the list of CLUBB's tunable parameters. The results in GrADS output files from this revision are an exact match to the results in GrADS output files from the previous revision for all cases. However, NetCDF output files are not an exact match, owing to the presence of the new tunable parameter listed in the output files. That technically makes this revision BIT_CHANGING. 2020-08-17 13:39:03 -0500ebcd262f4b199e4874305d4af9bc8d6908b637dcI added altitude_threshold to the list of CLUBB's tunable parameters.edittunable_parameters.instats_zm_module.F90stats_zt_module.F90stats_sfc_module.F90afdb66e5b0ec6643891aa6759fe061492bbcd9421597868232000http://carson.math.uwm.edu/jenkins/user/strikestrikestrike@uwm.eduUpdating clubb variables to output their var_description in the form '[variable name using sci notation], [Textual descirption]' in an effort to provide more standardized titles for pyplotgenplots. 2020-08-19 15:17:12 -0500afdb66e5b0ec6643891aa6759fe061492bbcd942Updating clubb variables to output their var_description in the form '[variable name using sci notation], [Textual descirption]' in an effort to provide more standardized titles for pyplotgenplots.editstats_zt_module.F90editstats_sfc_module.F90editstats_zm_module.F90stats_zm_module.F90stats_sfc_module.F90stats_zt_module.F907466fd80923756687e034cef32675207de0dedfb1597950288000http://carson.math.uwm.edu/jenkins/user/strikestrikestrike@uwm.eduUpdating previous commit to not have lines over 100 characters. This commit shouldn't be BIT_CHANGING, but the previous commit was (and was supposed to be). 2020-08-20 14:04:48 -05007466fd80923756687e034cef32675207de0dedfbUpdating previous commit to not have lines over 100 characters. This commit shouldn't be BIT_CHANGING, but the previous commit was (and was supposed to be).editstats_zm_module.F90editstats_sfc_module.F90editstats_zt_module.F90output_netcdf.F90output_grads.F904e98f884fb43d06669dce6e29513e936baed3ecf1598309445000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comAdds more debug lines Issue #881 2020-08-24 17:50:45 -05004e98f884fb43d06669dce6e29513e936baed3ecfAdds more debug lineseditoutput_grads.F90editoutput_netcdf.F90output_netcdf.F90output_grads.F90e3e4966b3e37f727fbee943081a479a078b4047d1598309843000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comRemoves debug lines Issue #881 2020-08-24 17:57:23 -0500e3e4966b3e37f727fbee943081a479a078b4047dRemoves debug lineseditoutput_grads.F90editoutput_netcdf.F90output_netcdf.F9027cebcd0b77b6b1a826b3d9ec6edc182131e52ca1598382981000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comAdds debug lines and changes format Issue #881 2020-08-25 14:16:21 -050027cebcd0b77b6b1a826b3d9ec6edc182131e52caAdds debug lines and changes formateditoutput_netcdf.F90output_netcdf.F90e69122b8c716881ac5818694b75940a10ae4c3781598384297000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comModifies debug line Issue #881 2020-08-25 14:38:17 -0500e69122b8c716881ac5818694b75940a10ae4c378Modifies debug lineeditoutput_netcdf.F90output_netcdf.F9052244022211caf4b18ed05a98bc946b8c8e2f1bf1598388387000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comModifies debug line Issue #881 2020-08-25 15:46:27 -050052244022211caf4b18ed05a98bc946b8c8e2f1bfModifies debug lineeditoutput_netcdf.F90output_netcdf.F905c207cd1008c3a8d8b6961acfca06ffd42ebef381598472032000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comInitialize ncf%ntimes to 0 when opening netcdf for writing Issue #881 2020-08-26 15:00:32 -05005c207cd1008c3a8d8b6961acfca06ffd42ebef38Initialize ncf%ntimes to 0 when opening netcdf for writingeditoutput_netcdf.F90output_netcdf.F902855a9acb24ba4238edd801a4cd86335676153321598474183000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comRemoves debug lines Issue #881 2020-08-26 15:36:23 -05002855a9acb24ba4238edd801a4cd8633567615332Removes debug lineseditoutput_netcdf.F90stat_file_module.F901d2c3305ba6770d82b958af367a53bc676361dd81598555787000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comChanges length of units variable in stat_file_module from 20 to 25 BIT_CHANGING The previous length of 20 was cutting off the last character for the unit `kg^{3} kg^{-3} s^{-1}`, which was causing checkBudget.py to fail. I upped it to 25 because that is a nice number. Issue #881 2020-08-27 14:16:27 -05001d2c3305ba6770d82b958af367a53bc676361dd8Changes length of units variable in stat_file_module from 20 to 25editstat_file_module.F90output_2D_samples_module.F90e39f3a9976193002fed4fa62d4390801cb80a24c1600356560000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comThis commit resolves issue #885 and gets the 2D output working, if the relevant flags are set to true. A duplicated allocate statement is eliminated, and to ensure that the 2D output occurs at the right intervals (every stats_tout seconds) I have also added approrpiate if statements at the beginning of the 2D output subroutines. 2020-09-17 10:29:20 -0500e39f3a9976193002fed4fa62d4390801cb80a24cThis commit resolves issue #885 and gets the 2D output working, if the relevant flags are set to true. A duplicated allocate statement is eliminated, and to ensure that the 2D output occurs at the right intervals (every stats_tout seconds) I have also added approrpiate if statements at the beginning of the 2D output subroutines.editoutput_2D_samples_module.F90silhs_api_module.F90f29953024a9efa8f3b396d8020a8588c691ef9a21600450428000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comAdding API subroutines for latin_hypercube_2D_output and latin_hypercube_2D_close. This will aid in implementing the SILHS 2D output subroutines in host models. The new API subroutines necessitated some minor changes in clubb_driver.F90 as well. Mainly relevant to https://github.com/larson-group/wrf/issues/110 (WRF repo), but see also #885 (CLUBB repo). 2020-09-18 12:33:48 -0500f29953024a9efa8f3b396d8020a8588c691ef9a2Adding API subroutines for latin_hypercube_2D_output and latin_hypercube_2D_close. This will aid in implementing the SILHS 2D output subroutines in host models. The new API subroutines necessitated some minor changes in clubb_driver.F90 as well. Mainly relevant to https://github.com/larson-group/wrf/issues/110 (WRF repo), but see also #885 (CLUBB repo).editsilhs_api_module.F90setup_clubb_pdf_params.F90faaa09a9dd4400fece94bd30bdef37d5549483601600849530000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI updated the stats code in setup_clubb_pdf_params.F90 and in latin_hypercube_driver_module.F90 to loop over stat_update_var_pt up to level nz, rather than call stat_update_var. This is done to allow E3SM-CLUBB-SILHS to run without issue. In that code base, SILHS and CLUBB have differing numbers of vertical levels. The results in output files from this revision are an exact match to the results in output files from the previous revision for all cases. 2020-09-23 03:25:30 -0500faaa09a9dd4400fece94bd30bdef37d554948360I updated the stats code in setup_clubb_pdf_params.F90 and ineditsetup_clubb_pdf_params.F90latin_hypercube_driver_module.F90b61ffdbef6993ce180a00aff3936f775316396311600849530000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI updated the stats code in setup_clubb_pdf_params.F90 and in latin_hypercube_driver_module.F90 to loop over stat_update_var_pt up to level nz, rather than call stat_update_var. This is done to allow E3SM-CLUBB-SILHS to run without issue. In that code base, SILHS and CLUBB have differing numbers of vertical levels. The results in output files from this revision are an exact match to the results in output files from the previous revision for all cases. 2020-09-23 03:25:30 -0500b61ffdbef6993ce180a00aff3936f77531639631I updated the stats code in setup_clubb_pdf_params.F90 and ineditlatin_hypercube_driver_module.F90silhs_api_module.F90output_2D_samples_module.F90latin_hypercube_driver_module.F90e0f1e9b683592ca8513e732120a20df0d2438f1e1601385131000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comThis commit primarily overhauls the way the 2D SILHS samples are output to netCDF. Now, instead of being output along the latitude dimension in a 4d netCDF file, the SILHS samples are output along the "lh_sample_number" dimension of a 5d netCDF file. Furthermore the lat/lon dimensions of the 2D SILHS sample files are now output with the correct lat/lon information. Also, "rlat" and "rlon" are changed to "lat_vals" and "lon_vals" throughout the CLUBB repo for clarity. Most of the files changes are because of this. (Some host models, e.g. WRF, may still use "rlat" and "rlon" in the code where they interface with CLUBB.) See issue #887. 2020-09-29 08:12:11 -0500e0f1e9b683592ca8513e732120a20df0d2438f1eThis commit primarily overhauls the way the 2D SILHS samples are output to netCDF. Now, instead of being output along the latitude dimension in a 4d netCDF file, the SILHS samples are output along the "lh_sample_number" dimension of a 5d netCDF file. Furthermore the lat/lon dimensions of the 2D SILHS sample files are now output with the correct lat/lon information.editoutput_2D_samples_module.F90editsilhs_api_module.F90editlatin_hypercube_driver_module.F90output_netcdf.F90output_grads.F90stats_type_utilities.F90stat_file_module.F90stats_clubb_utilities.F90clubb_api_module.F906482c644791940f0cad2e1cd53c61844f6f565001601385131000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comThis commit primarily overhauls the way the 2D SILHS samples are output to netCDF. Now, instead of being output along the latitude dimension in a 4d netCDF file, the SILHS samples are output along the "lh_sample_number" dimension of a 5d netCDF file. Furthermore the lat/lon dimensions of the 2D SILHS sample files are now output with the correct lat/lon information. Also, "rlat" and "rlon" are changed to "lat_vals" and "lon_vals" throughout the CLUBB repo for clarity. Most of the files changes are because of this. (Some host models, e.g. WRF, may still use "rlat" and "rlon" in the code where they interface with CLUBB.) See issue #887. 2020-09-29 08:12:11 -05006482c644791940f0cad2e1cd53c61844f6f56500This commit primarily overhauls the way the 2D SILHS samples are output to netCDF. Now, instead of being output along the latitude dimension in a 4d netCDF file, the SILHS samples are output along the "lh_sample_number" dimension of a 5d netCDF file. Furthermore the lat/lon dimensions of the 2D SILHS sample files are now output with the correct lat/lon information.editoutput_grads.F90editoutput_netcdf.F90editstats_type_utilities.F90editclubb_api_module.F90editstats_clubb_utilities.F90editstat_file_module.F90latin_hypercube_driver_module.F904fabcab89058c3d216ee6c6ef3ec977e14476e101601407797000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduUndoing accidental find and replace. larson-group/cam#129 2020-09-29 14:29:57 -05004fabcab89058c3d216ee6c6ef3ec977e14476e10Undoing accidental find and replace. larson-group/cam#129editlatin_hypercube_driver_module.F90stats_zm_module.F90stats_zt_module.F90stats_sfc_module.F90835b96e74437f9a1ecd703a6682c75a19568c7c31601659393000http://carson.math.uwm.edu/jenkins/user/nchiefnchiefnchief@gmail.comUpdated titles listed for change here: https://github.com/larson-group/sys_admin/issues/542#issuecomment-685963832 Moved wp2thvp just after the Cloud water contribution to wp2thvp panel 2020-10-02 12:23:13 -0500835b96e74437f9a1ecd703a6682c75a19568c7c3Updated titles listed for change here: https://github.com/larson-group/sys_admin/issues/542#issuecomment-685963832editstats_zt_module.F90editstats_zm_module.F90editstats_sfc_module.F90stats_zt_module.F9016a52f15f8eec9cd96250e2824c9902bfe9256d51601737119000http://carson.math.uwm.edu/jenkins/user/strikestrikestrike@uwm.eduFix super serious 1 character bug that broke all of the things 2020-10-03 09:58:39 -050016a52f15f8eec9cd96250e2824c9902bfe9256d5Fix super serious 1 character bug that broke all of the thingseditstats_zt_module.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90parameter_indices.F90advance_xm_wpxp_module.F90clubb_api_module.F90parameters_tunable.F90stats_variables.F90stats_zm_module.F90advance_helper_module.F9009188158a0ffe085e949f4497fd417be6fca2c501602204599000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am committing Zhun's changes to the CLUBB portion of his E3SM-CLUBB-SILHS branch to the clubb_E3SM_SILHS_branch_merge branch of CLUBB. The goal is for this code to eventually be merged into the CLUBB master. 2020-10-08 19:49:59 -050009188158a0ffe085e949f4497fd417be6fca2c50I am committing Zhun's changes to the CLUBB portion of hiseditadvance_clubb_core_module.F90editparameter_indices.F90editadvance_helper_module.F90editparameters_tunable.F90editstats_variables.F90editadvance_xp2_xpyp_module.F90editadvance_xm_wpxp_module.F90editclubb_api_module.F90editstats_zm_module.F90tunable_parameters.in27379d1a62179da1a674560361b9dd348b86215c1603751355000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI modified tunable_parameters.in to use some of the parameter values that are in the E3SM-CLUBB-SILHS branch. The only parameters changed are the ones that are found in the namelists for both CAM (master) and E3SM (master). 2020-10-26 17:29:15 -050027379d1a62179da1a674560361b9dd348b86215cI modified tunable_parameters.in to use some of the parameter values thatedittunable_parameters.instats_zm_module.F90121e67c4b158a54e87e7817956bb4a12f706e9c31604414984000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdate stats_zm_module.F90 Added apostrophe to thl'thv' for consistency. 2020-11-03 08:49:44 -0600121e67c4b158a54e87e7817956bb4a12f706e9c3Update stats_zm_module.F90editstats_zm_module.F90parameters_tunable.F90parameter_indices.F90b65048d5fb0571e486c365ef27f0863fda44a2d01604690665000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added Cx_min, Cx_max, Richardson_num_min, and Richardson_num_max to the list of CLUBB's tunable parameters. 2020-11-06 13:24:25 -0600b65048d5fb0571e486c365ef27f0863fda44a2d0I added Cx_min, Cx_max, Richardson_num_min, and Richardson_num_maxeditparameters_tunable.F90editparameter_indices.F90tunable_parameters.in9b55d6c312e838c36b6f4ca9938b38edb5e99a371604690665000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added Cx_min, Cx_max, Richardson_num_min, and Richardson_num_max to the list of CLUBB's tunable parameters. 2020-11-06 13:24:25 -06009b55d6c312e838c36b6f4ca9938b38edb5e99a37I added Cx_min, Cx_max, Richardson_num_min, and Richardson_num_maxedittunable_parameters.inadvance_helper_module.F908d20eb1aa94009fcd9c89f703d10e9ba438e48451604691057000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI connected the new tunable parameters to advance_helper_module.F90. 2020-11-06 13:30:57 -06008d20eb1aa94009fcd9c89f703d10e9ba438e4845I connected the new tunable parameters to advance_helper_module.F90.editadvance_helper_module.F90configurable_model_flags.in8494d30c9d26bfdf43013b71673ac079f3e3e8691605747985000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added l_use_shear_Richardson to CLUBB's configurable model flags. 2020-11-18 19:06:25 -06008494d30c9d26bfdf43013b71673ac079f3e3e869I added l_use_shear_Richardson to CLUBB's configurable model flags.editconfigurable_model_flags.inadvance_clubb_core_module.F90model_flags.F90clubb_api_module.F90advance_helper_module.F9025ed680064c8ab4ee4f74c34b440257faf9fd70e1605747985000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI added l_use_shear_Richardson to CLUBB's configurable model flags. 2020-11-18 19:06:25 -060025ed680064c8ab4ee4f74c34b440257faf9fd70eI added l_use_shear_Richardson to CLUBB's configurable model flags.editclubb_api_module.F90editadvance_clubb_core_module.F90editadvance_helper_module.F90editmodel_flags.F90configurable_model_flags.inb0bbc88d76bc5672a18857ef2f975cfd8ee3fa9a1606141860000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comAdding linear multistep method (LMM) stepping flag (l_lmm_stepping) to provide capability of overstepping-and-then-averaging results from advance_wp2_wp3, advance_xm_xpwp, and advance_xp2_xpyp. This is intended to help smooth high-frequency oscillations. Flag is set to false by default so has no impact on standard runs. 2020-11-23 08:31:00 -0600b0bbc88d76bc5672a18857ef2f975cfd8ee3fa9aAdding linear multistep method (LMM) stepping flag (l_lmm_stepping) to provide capability of overstepping-and-then-averaging results from advance_wp2_wp3, advance_xm_xpwp, and advance_xp2_xpyp. This is intended to help smooth high-frequency oscillations. Flag is set to false by default so has no impact on standard runs.editconfigurable_model_flags.inadvance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90model_flags.F90advance_xm_wpxp_module.F90clubb_api_module.F903dc70ce717348532fbc888574f7f0825ea8a401e1606141860000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comAdding linear multistep method (LMM) stepping flag (l_lmm_stepping) to provide capability of overstepping-and-then-averaging results from advance_wp2_wp3, advance_xm_xpwp, and advance_xp2_xpyp. This is intended to help smooth high-frequency oscillations. Flag is set to false by default so has no impact on standard runs. 2020-11-23 08:31:00 -06003dc70ce717348532fbc888574f7f0825ea8a401eAdding linear multistep method (LMM) stepping flag (l_lmm_stepping) to provide capability of overstepping-and-then-averaging results from advance_wp2_wp3, advance_xm_xpwp, and advance_xp2_xpyp. This is intended to help smooth high-frequency oscillations. Flag is set to false by default so has no impact on standard runs.editadvance_xm_wpxp_module.F90editadvance_xp2_xpyp_module.F90editadvance_clubb_core_module.F90editadvance_wp2_wp3_module.F90editclubb_api_module.F90editmodel_flags.F90tunable_parameters.in5886ca801202a25157d12ae49f47f9ece1ef749a1606328447000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI forgot to add rtp2_clip_coef to tunable_parameters.in (this doesn't affect the results, but it still should be placed there). 2020-11-25 12:20:47 -06005886ca801202a25157d12ae49f47f9ece1ef749aI forgot to add rtp2_clip_coef to tunable_parameters.in (this doesn't affectedittunable_parameters.inadvance_xm_wpxp_module.F90954c6c2dbef62f96755207776d56cbd9b4e9cb5d1606338607000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduIn order to prevent dycoms2_rf02_so from crashing, I replaced C7_Skw_fnc by 0.7 in upwp_pr4 and vpwp_pr4. This prevents an excessive wind gradient (dum/dz) from forming near the lower surface. This commit is BIT_CHANGING. For larson-group/e3sm#30. 2020-11-25 15:10:07 -0600954c6c2dbef62f96755207776d56cbd9b4e9cb5dIn order to prevent dycoms2_rf02_so from crashing,editadvance_xm_wpxp_module.F90advance_xm_wpxp_module.F90e65f26062f1a7b61581f530a81532795bff72cbd1606338983000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduI updated the recording of the budget terms for upwp_pr4 and vpwp_pr4. The simulation should be BFB, but because the budget term is updated consistently now, this commit is BIT_CHANGING. For larson-group/e3sm#30. 2020-11-25 15:16:23 -0600e65f26062f1a7b61581f530a81532795bff72cbdI updated the recording of the budget terms for upwp_pr4 and vpwp_pr4.editadvance_xm_wpxp_module.F90advance_helper_module.F90cacdab660c210f30178d483c8545d39a7b2568ab1606763229000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comAdding the smooth_min and smooth_max functions to the repo. These are not yet implemented in CLUBB but are now available for use and testing. See issue #894. 2020-11-30 13:07:09 -0600cacdab660c210f30178d483c8545d39a7b2568abAdding the smooth_min and smooth_max functions to the repo. These are not yet implemented in CLUBB but are now available for use and testing. See issue #894.editadvance_helper_module.F90advance_helper_module.F90c2066af74a5d49e40558fc1d59352f118028c96c1606772963000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comAdding some comments describing zm and zt for the new interface functions, and fixing a problem in the "array_sclr" versions of the functions. See issue #894. 2020-11-30 15:49:23 -0600c2066af74a5d49e40558fc1d59352f118028c96cAdding some comments describing zm and zt for the new interface functions, and fixing a problem in the "array_sclr" versions of the functions. See issue #894.editadvance_helper_module.F90transform_to_pdf_module.F90latin_hypercube_driver_module.F9013f11f11a25ca3c19dd944fc13003b1542e86d201606856173000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduModifying some array dimensions to speed up multiply_Cholesky. This cuts the cost of multiply_Cholesky by about 60% in cam but only about 15% in clubb_standalone. larson-group/cam#129 2020-12-01 14:56:13 -060013f11f11a25ca3c19dd944fc13003b1542e86d20Modifying some array dimensions to speed up multiply_Cholesky. This cuts the cost of multiply_Cholesky by about 60% in cam but only about 15% in clubb_standalone. larson-group/cam#129editlatin_hypercube_driver_module.F90edittransform_to_pdf_module.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90advance_xp3_module.F90advance_xm_wpxp_module.F90stats_zt_module.F90stats_zm_module.F90stats_variables.F9051f8757f2ece02721c4c95797df4b6738111fead1607615302000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comThis commit replaces division by tau with multiplication by inverse tau in most cases. It is BIT_CHANGING, not only because the results change (only very slightly in some cases, but more significantly in sensitive cases like ARM_97, RICO, etc.) but also because some of the old tau_*_zm or tau_*_zt output variables are replaced with invrs_tau_* variables, hence the netcdf files will differ and there are minor changes to stats input files. Spurious source test also needed to be slightly modified to accommodate a new variable fed into the advance_xm_wpxp subroutine. There is also some minor cleanup. See issue #899. 2020-12-10 09:48:22 -060051f8757f2ece02721c4c95797df4b6738111feadThis commit replaces division by tau with multiplication by inverse tau in most cases. It is BIT_CHANGING, not only because the results change (only very slightly in some cases, but more significantly in sensitive cases like ARM_97, RICO, etc.) but also because some of the old tau_*_zm or tau_*_zt output variables are replaced with invrs_tau_* variables, hence the netcdf files will differ and there are minor changes to stats input files. Spurious source test also needed to be slightly modified to accommodate a new variable fed into the advance_xm_wpxp subroutine.editadvance_xp2_xpyp_module.F90editadvance_clubb_core_module.F90editadvance_xm_wpxp_module.F90editadvance_xp3_module.F90editstats_zm_module.F90editadvance_wp2_wp3_module.F90editstats_variables.F90editstats_zt_module.F90advance_clubb_core_module.F90clubb_api_module.F90d08fdc395bde39bc7b72378b25216f1957c06ec91607641700000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am committing a bug fix to the invrs_tau_zm equation that was introduced with the code merge from E3SM. I am also adding some changes to the clubb_api_module that should have been brought over at that time. This commit is BIT_CHANGING with the bug fix. 2020-12-10 17:08:20 -0600d08fdc395bde39bc7b72378b25216f1957c06ec9I am committing a bug fix to the invrs_tau_zm equation that waseditclubb_api_module.F90editadvance_clubb_core_module.F90stats_zm_module.F90advance_clubb_core_module.F90fc1a13766333b94e05f14ffbbd1ebbc88393c58d1607984534000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comCLUBB and pyplotgen changes: 1. Putting smoothing on thlm before the Brunt-Vaisala frequency calculation. We find this helps smooth oscillations in that variable, see issue #894. Also fixing spelling mistake in stats_zm_module.F90, and adding bv_freq_sqd to nightly_stats.in. For all these reasons this commit is BIT_CHANGING, but only the thlm smoothing will change the physical results. 2. Pyplotgen: I moved Brunt-Vaisala to VariableGroupBase.py so it should show up in the nightly plots, I got rid of VariableGroupTaus from the default Case definitions, and made a couple other minor changes including making the solid line thicker for standard CLUBB plots. 2020-12-14 16:22:14 -0600fc1a13766333b94e05f14ffbbd1ebbc88393c58dCLUBB and pyplotgen changes:editstats_zm_module.F90editadvance_clubb_core_module.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90advance_xp3_module.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90advance_windm_edsclrm_module.F90dc88808be3203de9536f2dbe34a77dc209d903381608165333000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI fixed the LMM stepping bug that was affecting E3SM (because l_predict_upwp_vpwp is false over there) in advance_xm_wpxp_module.F90. I also added it to all predictive fields. The results in NetCDF output files from this revision is an exact match to the results in NetCDF output files from the previous revision for all cases because LMM stepping is turned off by default. 2020-12-16 18:35:33 -0600dc88808be3203de9536f2dbe34a77dc209d90338I fixed the LMM stepping bug that was affecting E3SM (becauseeditadvance_xp2_xpyp_module.F90editadvance_xm_wpxp_module.F90editadvance_wp2_wp3_module.F90editadvance_windm_edsclrm_module.F90editadvance_xp3_module.F90editadvance_clubb_core_module.F90advance_xm_wpxp_module.F90378b99093fca66e7223cae49ad0ca088e0f0148a1608165625000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduFixed alignment. 2020-12-16 18:40:25 -0600378b99093fca66e7223cae49ad0ca088e0f0148aFixed alignment.editadvance_xm_wpxp_module.F90parameters_tunable.F90advance_clubb_core_module.F90model_flags.F90parameter_indices.F90clubb_api_module.F90df97ac5bcdd52b069a9cc74f9321c3ffb5cc69811608225144000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comThis commit introduces a new flag, l_e3sm_config, which enables the user to switch on or off some of the changes introduced in connection with the E3SM merge (see commit https://github.com/larson-group/clubb/commit/cf5b2e4b80d8bd3ca411b9b5e6d5a2afece04795). It also introduces two new tunable parameters, C_invrs_tau_wpxp_Ri and C_invrs_tau_wpxp_N2_thresh, to replace two "magic numbers" in the code. The primary code changes are in advance_clubb_core_module.F90. This is a BIT_CHANGING commit due to the new parameters affecting the netcdf output but the physical results should remain the same for now. See relevant issues #894 and #897. 2020-12-17 11:12:24 -0600df97ac5bcdd52b069a9cc74f9321c3ffb5cc6981This commit introduces a new flag, l_e3sm_config, which enables the user to switch on or off some of the changes introduced in connection with the E3SM merge (see commit https://github.com/larson-group/clubb/commit/cf5b2e4b80d8bd3ca411b9b5e6d5a2afece04795). It also introduces two new tunable parameters, C_invrs_tau_wpxp_Ri and C_invrs_tau_wpxp_N2_thresh, to replace two "magic numbers" in the code. The primary code changes are in advance_clubb_core_module.F90.editparameters_tunable.F90editmodel_flags.F90editparameter_indices.F90editclubb_api_module.F90editadvance_clubb_core_module.F90tunable_parameters.inconfigurable_model_flags.inad7085721305de055a23bc851cd6b77f9f9afd951608225144000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comThis commit introduces a new flag, l_e3sm_config, which enables the user to switch on or off some of the changes introduced in connection with the E3SM merge (see commit https://github.com/larson-group/clubb/commit/cf5b2e4b80d8bd3ca411b9b5e6d5a2afece04795). It also introduces two new tunable parameters, C_invrs_tau_wpxp_Ri and C_invrs_tau_wpxp_N2_thresh, to replace two "magic numbers" in the code. The primary code changes are in advance_clubb_core_module.F90. This is a BIT_CHANGING commit due to the new parameters affecting the netcdf output but the physical results should remain the same for now. See relevant issues #894 and #897. 2020-12-17 11:12:24 -0600ad7085721305de055a23bc851cd6b77f9f9afd95This commit introduces a new flag, l_e3sm_config, which enables the user to switch on or off some of the changes introduced in connection with the E3SM merge (see commit https://github.com/larson-group/clubb/commit/cf5b2e4b80d8bd3ca411b9b5e6d5a2afece04795). It also introduces two new tunable parameters, C_invrs_tau_wpxp_Ri and C_invrs_tau_wpxp_N2_thresh, to replace two "magic numbers" in the code. The primary code changes are in advance_clubb_core_module.F90.edittunable_parameters.ineditconfigurable_model_flags.inparameter_indices.F90034049b46393a096da28099eef60ca5801a7f3291608239444000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdate parameter_indices.F90 Switching the order of two variables. Was causing the values of these parameters to be reversed in some output files (but no effect on physical results). 2020-12-17 15:10:44 -0600034049b46393a096da28099eef60ca5801a7f329Update parameter_indices.F90editparameter_indices.F90configurable_model_flags.intunable_parameters.inf1d2e7953ef08774f436bcdc2991c70c9676b9561608322618000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comSetting parameters and flags to be consistent with the CLUBB repo prior to the October 8 commit merging some E3SM code (https://github.com/larson-group/clubb/commit/cf5b2e4b80d8bd3ca411b9b5e6d5a2afece04795). This should help to basically recover the plots from before the merge, which is useful for single-column model testing. The parameters and flags for the E3SM results can be found in the input/tunable_parameters_e3sm/ folder. See issue #897. 2020-12-18 14:16:58 -0600f1d2e7953ef08774f436bcdc2991c70c9676b956Setting parameters and flags to be consistent with the CLUBB repo prior to the October 8 commit merging some E3SM code (https://github.com/larson-group/clubb/commit/cf5b2e4b80d8bd3ca411b9b5e6d5a2afece04795). This should help to basically recover the plots from before the merge, which is useful for single-column model testing.editconfigurable_model_flags.inedittunable_parameters.inmodel_flags.F903992f76b8f461365f321eddd00d1951c7540475a1608325274000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdate model_flags.F90 Setting l_use_shear_Richardson to false in model_flags.in to be consistent with the default configurable_model_flags.in file. This will ensure consistency with other nightly tests (eg WRF and SAM) that do not read configureable_model_flags.in. 2020-12-18 15:01:14 -06003992f76b8f461365f321eddd00d1951c7540475aUpdate model_flags.F90editmodel_flags.F90advance_wp2_wp3_module.F90advance_clubb_core_module.F90model_flags.F90clubb_api_module.F9013cf0163bb65ea786b232a7a4ebea978fe958d441610388625000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comAdding new flag that allows the user to implement the TKE formulation of the wp3 C15 term (known currently as bp2, but ultimately will be called pr3). See issue #884. 2021-01-11 12:10:25 -060013cf0163bb65ea786b232a7a4ebea978fe958d44Adding new flag that allows the user to implement the TKE formulation of the wp3 C15 term (known currently as bp2, but ultimately will be called pr3). See issue #884.editmodel_flags.F90editclubb_api_module.F90editadvance_wp2_wp3_module.F90editadvance_clubb_core_module.F90configurable_model_flags.ine17eed6901ff64e2500768c2a44e9d792f04f5561610388625000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comAdding new flag that allows the user to implement the TKE formulation of the wp3 C15 term (known currently as bp2, but ultimately will be called pr3). See issue #884. 2021-01-11 12:10:25 -0600e17eed6901ff64e2500768c2a44e9d792f04f556Adding new flag that allows the user to implement the TKE formulation of the wp3 C15 term (known currently as bp2, but ultimately will be called pr3). See issue #884.editconfigurable_model_flags.inadvance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90parameter_indices.F90advance_xm_wpxp_module.F90clubb_api_module.F90parameters_tunable.F90217a6182be062dc94ac62d8880a181ec82011b971610658263000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comSeparating out the parameter C5 into C_uu_shr and C_uu_buoy, consistent with the formalism of Mironov and Machulskaya 2017. C5 has been effectively renamed C_uu_shr, and a new parameter C_uu_buoy has been introduced. See https://github.com/larson-group/clubb/issues/901. This commit is BIT_CHANGING, both because it will change the names of parameters output to netcdf, and because it changes the results of the more sensitive CLUBB test cases (like ARM_97), since there is an order-of-operations change involved in the subroutine "wp2_term_pr3_rhs" in advance_wp2_wp3_module.F90. 2021-01-14 15:04:23 -0600217a6182be062dc94ac62d8880a181ec82011b97Separating out the parameter C5 into C_uu_shr and C_uu_buoy, consistent with the formalism of Mironov and Machulskaya 2017. C5 has been effectively renamed C_uu_shr, and a new parameter C_uu_buoy has been introduced. See https://github.com/larson-group/clubb/issues/901.editadvance_clubb_core_module.F90editparameters_tunable.F90editadvance_wp2_wp3_module.F90editadvance_xm_wpxp_module.F90editparameter_indices.F90editadvance_xp2_xpyp_module.F90editclubb_api_module.F90tunable_parameters.inf1213e1022b9012cf4f09f81058c2c386c716a301610658263000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comSeparating out the parameter C5 into C_uu_shr and C_uu_buoy, consistent with the formalism of Mironov and Machulskaya 2017. C5 has been effectively renamed C_uu_shr, and a new parameter C_uu_buoy has been introduced. See https://github.com/larson-group/clubb/issues/901. This commit is BIT_CHANGING, both because it will change the names of parameters output to netcdf, and because it changes the results of the more sensitive CLUBB test cases (like ARM_97), since there is an order-of-operations change involved in the subroutine "wp2_term_pr3_rhs" in advance_wp2_wp3_module.F90. 2021-01-14 15:04:23 -0600f1213e1022b9012cf4f09f81058c2c386c716a30Separating out the parameter C5 into C_uu_shr and C_uu_buoy, consistent with the formalism of Mironov and Machulskaya 2017. C5 has been effectively renamed C_uu_shr, and a new parameter C_uu_buoy has been introduced. See https://github.com/larson-group/clubb/issues/901.edittunable_parameters.insilhs_api_module.F90latin_hypercube_driver_module.F907e1baf2139189deaa6c2da15181bb8cdcf55c4b51610686189000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am now passing vert_decorr_coef into SILHS instead of involving a USE statement. 2021-01-14 22:49:49 -06007e1baf2139189deaa6c2da15181bb8cdcf55c4b5I am now passing vert_decorr_coef into SILHS instead of involvingeditlatin_hypercube_driver_module.F90editsilhs_api_module.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F9074bc7b14e4dea9c34e9d28071afac13e80a79e821610740288000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comThis commits further updates related to splitting the parameter C5 into C_uu_shr and C_uu_buoy (see this commit: https://github.com/larson-group/clubb/commit/3f75a27dd94673a2b8603c24b989da106e759b39). Changes include correcting one instance where C_uu_shr was passed to a function when C_uu_buoy should've been passed, and also now applying the changes to up2 and vp2, which was overlooked before. I've also updated the comments to remove, where appropriate, references to "C_5" that were missed before (in a few places I have left the C_5 in place but included a note indicating that it has now been broken up). This commit is BIT_CHANGING, similar to the previous commit, because of the order-of-operations change in the pr2 term for up2 and vp2. This leaves more stable cases like BOMEX bit-for-bit identical, but changes outcomes for more senstive cases like ARM_97. See issue #901. 2021-01-15 13:51:28 -060074bc7b14e4dea9c34e9d28071afac13e80a79e82This commits further updates related to splitting the parameter C5 into C_uu_shr and C_uu_buoy (see this commit: https://github.com/larson-group/clubb/commit/3f75a27dd94673a2b8603c24b989da106e759b39). Changes include correcting one instance where C_uu_shr was passed to a function when C_uu_buoy should've been passed, and also now applying the changes to up2 and vp2, which was overlooked before. I've also updated the comments to remove, where appropriate, references to "C_5" that were missed before (in a few places I have left the C_5 in place but included a note indicating that it has now been broken up).editadvance_wp2_wp3_module.F90editadvance_xp2_xpyp_module.F90advance_xp2_xpyp_module.F904af03a62d94eec9f15856429b959b164e0c73d541611079334000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comAdding a test to make sure new C_uu_buoy parameter is within the valid range. See #901. 2021-01-19 12:02:14 -06004af03a62d94eec9f15856429b959b164e0c73d54Adding a test to make sure new C_uu_buoy parameter is within the valid range. See #901.editadvance_xp2_xpyp_module.F90tunable_parameters.inconfigurable_model_flags.in9fd71af1ee2216a5960e4250b0766cfbeaf6e4b81611176566000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comThis commit renames the wp3 budget term from "bp2" to "pr_turb", and renames the related parameter "C15" to "C_wp3_turb". The majority of files changed are supplemental files such as postprocessing files for plotgen and pyplotgen and tuner files and input files. This commit is BIT_CHANGING, but only because it renames a variable and a parameter. Results should be bit-for-bit with previous results. See issue #901. 2021-01-20 15:02:46 -06009fd71af1ee2216a5960e4250b0766cfbeaf6e4b8This commit renames the wp3 budget term from "bp2" to "pr_turb", and renames the related parameter "C15" to "C_wp3_turb". The majority of files changed are supplemental files such as postprocessing files for plotgen and pyplotgen and tuner files and input files.edittunable_parameters.ineditconfigurable_model_flags.inadvance_wp2_wp3_module.F90advance_clubb_core_module.F90model_flags.F90parameter_indices.F90clubb_api_module.F90stats_zt_module.F90stats_variables.F90parameters_tunable.F90405016e402e3fa788758ba73639fdd4c892e95ad1611176566000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comThis commit renames the wp3 budget term from "bp2" to "pr_turb", and renames the related parameter "C15" to "C_wp3_turb". The majority of files changed are supplemental files such as postprocessing files for plotgen and pyplotgen and tuner files and input files. This commit is BIT_CHANGING, but only because it renames a variable and a parameter. Results should be bit-for-bit with previous results. See issue #901. 2021-01-20 15:02:46 -0600405016e402e3fa788758ba73639fdd4c892e95adThis commit renames the wp3 budget term from "bp2" to "pr_turb", and renames the related parameter "C15" to "C_wp3_turb". The majority of files changed are supplemental files such as postprocessing files for plotgen and pyplotgen and tuner files and input files.editadvance_wp2_wp3_module.F90editadvance_clubb_core_module.F90editmodel_flags.F90editparameter_indices.F90editstats_zt_module.F90editclubb_api_module.F90editstats_variables.F90editparameters_tunable.F90parameters_silhs.F90silhs_api_module.F907a13d2a715a4954d2fb1e1b2485f5f56026e77341611270040000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduThis will allow for a better interface of SILHS parameter vert_decorr_coef with host model codes. 2021-01-21 17:00:40 -06007a13d2a715a4954d2fb1e1b2485f5f56026e7734This will allow for a better interface of SILHS parametereditparameters_silhs.F90editsilhs_api_module.F90parameters_silhs.F907bd738c4f823c16c0e3b7fe2e5eb25382dabd2171611270711000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduFixed a preprocessor command. 2021-01-21 17:11:51 -06007bd738c4f823c16c0e3b7fe2e5eb25382dabd217Fixed a preprocessor command.editparameters_silhs.F90silhs_api_module.F9050254f89a49d5b72abedf72ac7356f92ced3aca51611288887000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI'm adding the api entry for read_silhs_parameters, called read_silhs_parameters_api. 2021-01-21 22:14:47 -060050254f89a49d5b72abedf72ac7356f92ced3aca5I'm adding the api entry for read_silhs_parameters, callededitsilhs_api_module.F90silhs_api_module.F90ad27d2d29f4e532b67fb52c8f075e3251403e9c61611608667000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduRevert "I'm adding the api entry for read_silhs_parameters, called" This reverts commit f2dc5c25386fd37bc1bf8ccff7844c66ee79ac36. 2021-01-25 15:04:27 -0600ad27d2d29f4e532b67fb52c8f075e3251403e9c6Revert "I'm adding the api entry for read_silhs_parameters, called"editsilhs_api_module.F90parameters_silhs.F909672d1836e6cf847d0ab804cd0782b3bc22c22ef1611608682000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduRevert "Fixed a preprocessor command." This reverts commit b349140012f53280aaf8294c1c3d6bc95f8d85b2. 2021-01-25 15:04:42 -06009672d1836e6cf847d0ab804cd0782b3bc22c22efRevert "Fixed a preprocessor command."editparameters_silhs.F90silhs_api_module.F90parameters_silhs.F9056af2a083547f0f5d0fc34ff2cd726898f19d8d41611608697000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduRevert "This will allow for a better interface of SILHS parameter" This reverts commit 47032b78a9fd8ddf19c30483abff933e099c9e43. 2021-01-25 15:04:57 -060056af2a083547f0f5d0fc34ff2cd726898f19d8d4Revert "This will allow for a better interface of SILHS parameter"editsilhs_api_module.F90editparameters_silhs.F90silhs_api_module.F90bf77152b7ac0acae64e849466f25f2bf3ccf986f1611609376000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI updated silhs_api_module so that vert_decorr_coef is publically available for some host models (e.g. SAM and WRF). 2021-01-25 15:16:16 -0600bf77152b7ac0acae64e849466f25f2bf3ccf986fI updated silhs_api_module so that vert_decorr_coef is publically availableeditsilhs_api_module.F90configurable_model_flags.in91ac5780287100db6cb8e01683808f6755fc13961611674403000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comIncorporating Shixuan Zhang's and Chris Vogl's "l_godunov_upwind_wpxp_ta" flag and related code. The flag is set to false by default so results are unaffected. See #902. 2021-01-26 09:20:03 -060091ac5780287100db6cb8e01683808f6755fc1396Incorporating Shixuan Zhang's and Chris Vogl's "l_godunov_upwind_wpxp_ta" flag and related code. The flag is set to false by default so results are unaffected. See #902.editconfigurable_model_flags.inadvance_clubb_core_module.F90model_flags.F90turbulent_adv_pdf.F90advance_xm_wpxp_module.F90clubb_api_module.F904165ae0836d60e74a5eee2e1bf5f1be885a1ff6a1611674403000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comIncorporating Shixuan Zhang's and Chris Vogl's "l_godunov_upwind_wpxp_ta" flag and related code. The flag is set to false by default so results are unaffected. See #902. 2021-01-26 09:20:03 -06004165ae0836d60e74a5eee2e1bf5f1be885a1ff6aIncorporating Shixuan Zhang's and Chris Vogl's "l_godunov_upwind_wpxp_ta" flag and related code. The flag is set to false by default so results are unaffected. See #902.editturbulent_adv_pdf.F90editadvance_xm_wpxp_module.F90editclubb_api_module.F90editmodel_flags.F90editadvance_clubb_core_module.F90configurable_model_flags.in41b3781685ad4a7c20f704e51e8ba4aad14db10c1611679455000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdate configurable_model_flags.in Turning off flag, was turned on by mistake. 2021-01-26 10:44:15 -060041b3781685ad4a7c20f704e51e8ba4aad14db10cUpdate configurable_model_flags.ineditconfigurable_model_flags.inadvance_xm_wpxp_module.F90bdc11caa173990eaf25cc2e91a95c472ab5a6abd1611776290000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comUpdating advance_xm_wpxp_module so that the upwp_pr4 term uses the parameter C_uu_shr instead of the hard-coded value 0.7. Also updating the value of C_uu_shr from 0.3 to 0.4 after testing priority-cases with the new upwp_pr4 term. This commit is BIT_CHANGING. See #901. 2021-01-27 13:38:10 -0600bdc11caa173990eaf25cc2e91a95c472ab5a6abdUpdating advance_xm_wpxp_module so that the upwp_pr4 term uses the parameter C_uu_shr instead of the hard-coded value 0.7. Also updating the value of C_uu_shr from 0.3 to 0.4 after testing priority-cases with the new upwp_pr4 term.editadvance_xm_wpxp_module.F90tunable_parameters.in3e838cd2412d5779ae18f78f1b8b455c7c2e55931611776290000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comUpdating advance_xm_wpxp_module so that the upwp_pr4 term uses the parameter C_uu_shr instead of the hard-coded value 0.7. Also updating the value of C_uu_shr from 0.3 to 0.4 after testing priority-cases with the new upwp_pr4 term. This commit is BIT_CHANGING. See #901. 2021-01-27 13:38:10 -06003e838cd2412d5779ae18f78f1b8b455c7c2e5593Updating advance_xm_wpxp_module so that the upwp_pr4 term uses the parameter C_uu_shr instead of the hard-coded value 0.7. Also updating the value of C_uu_shr from 0.3 to 0.4 after testing priority-cases with the new upwp_pr4 term.edittunable_parameters.inlatin_hypercube_driver_module.F9063c8e9a172cdc920b1f49fd39aafc1f0503cc1a41611783834000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMoving the acc update host directive to after the wait directives in silhs. Since silhs runs with asyncronous kernel calls the update was occasionally happening before some clipping was finished, causing problems in assert_correct_cloud_normal. This is only a problem when compiling with OpenACC enabled, so it should be bit identical for all our tests. larson-group/cam#129 2021-01-27 15:43:54 -060063c8e9a172cdc920b1f49fd39aafc1f0503cc1a4Moving the acc update host directive to after the wait directives in silhs. Since silhs runs with asyncronous kernel calls the update was occasionally happening before some clipping was finished, causing problems in assert_correct_cloud_normal. This is only a problem when compiling with OpenACC enabled, so it should be bit identical for all our tests. larson-group/cam#129editlatin_hypercube_driver_module.F90parameters_tunable.F9076c180d60652ae4e949b261d8ed4a196f14f312d1611840176000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdate parameters_tunable.F90 Updating to match default tunable_parameters.in. 2021-01-28 07:22:56 -060076c180d60652ae4e949b261d8ed4a196f14f312dUpdate parameters_tunable.F90editparameters_tunable.F90silhs_api_module.F90transform_to_pdf_module.F90latin_hypercube_driver_module.F90math_utilities.F90est_kessler_microphys_module.F90lh_microphys_var_covar_module.F90output_2D_samples_module.F900ad9f3a979d7ee40ab1ed902502468de4a46c2f61612480793000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduReording vertical and subcolumn dimensions in SILHS. This is BIT_CHANING in some cases, seemly due to an outputting error for the precip_rate field, but plotted results are identical. larson-group/cam#129 2021-02-04 17:19:53 -06000ad9f3a979d7ee40ab1ed902502468de4a46c2f6Reording vertical and subcolumn dimensions in SILHS. This is BIT_CHANING in some cases, seemly due to an outputting error for the precip_rate field, but plotted results are identical. larson-group/cam#129editoutput_2D_samples_module.F90editest_kessler_microphys_module.F90editsilhs_api_module.F90editlatin_hypercube_driver_module.F90edittransform_to_pdf_module.F90editlh_microphys_var_covar_module.F90editmath_utilities.F90latin_hypercube_driver_module.F900f7d70b05fdf184b57e9ceaa62e16b95da2948351613506124000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduChanging dimension order of rand_pool to make consistent with previous reorderings. This is BIT_CHANGING for silhs cases since it changes the order in which random numbers are used. larson-group/cam#129 2021-02-16 14:08:44 -06000f7d70b05fdf184b57e9ceaa62e16b95da294835Changing dimension order of rand_pool to make consistent with previous reorderings. This is BIT_CHANGING for silhs cases since it changes the order in which random numbers are used. larson-group/cam#129editlatin_hypercube_driver_module.F90calendar.F90clubb_api_module.F90input_reader.F90pos_definite_module.F90output_netcdf.F90diagnose_correlations_module.F90grid_class.F90parameters_tunable.F90new_pdf.F90sponge_layer_damping.F90advance_helper_module.F90mixing_length.F90file_functions.F90saturation.F90output_grads.F90advance_clubb_core_module.F90fill_holes.F90interpolation.F90stats_clubb_utilities.F90new_hybrid_pdf_main.F90matrix_operations.F90corr_varnce_module.F9076854dadc00cb0ece5d773ef7cc623bf83980d951613874481000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@users.noreply.github.comChanges non-success `stop` statements to `error stop` Changes files in the src/CLUBB_core directory larson-group/sys_admin#725 2021-02-20 20:28:01 -060076854dadc00cb0ece5d773ef7cc623bf83980d95Changes non-success `stop` statements to `error stop`editsaturation.F90editdiagnose_correlations_module.F90editfill_holes.F90editinterpolation.F90editgrid_class.F90editadvance_helper_module.F90editclubb_api_module.F90editinput_reader.F90editparameters_tunable.F90editnew_pdf.F90editpos_definite_module.F90editsponge_layer_damping.F90editmixing_length.F90editadvance_clubb_core_module.F90editmatrix_operations.F90editnew_hybrid_pdf_main.F90editcalendar.F90editoutput_netcdf.F90editoutput_grads.F90editcorr_varnce_module.F90editstats_clubb_utilities.F90editfile_functions.F90silhs_importance_sample_module.F90est_kessler_microphys_module.F90output_2D_samples_module.F90latin_hypercube_driver_module.F90a4ddd4f89fffdfbf923b7b3d28c3e292777c24b41613874481000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@users.noreply.github.comChanges non-success `stop` statements to `error stop` Changes files in `src/SILHS` directory larson-group/sys_admin#725 2021-02-20 20:28:01 -0600a4ddd4f89fffdfbf923b7b3d28c3e292777c24b4Changes non-success `stop` statements to `error stop`editoutput_2D_samples_module.F90editest_kessler_microphys_module.F90editlatin_hypercube_driver_module.F90editsilhs_importance_sample_module.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90model_flags.F90clubb_api_module.F90turbulent_adv_pdf.F90d985b8a9601d3a02a009424bcc801294b1eb04631614367438000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comAdding Shixuan's godunov_xpyp_ta updates here in case we want to merge them into our master branch. See #902. 2021-02-26 13:23:58 -0600d985b8a9601d3a02a009424bcc801294b1eb0463Adding Shixuan's godunov_xpyp_ta updates here in case we want to merge them into our master branch. See #902.editadvance_xp2_xpyp_module.F90editclubb_api_module.F90editturbulent_adv_pdf.F90editadvance_clubb_core_module.F90editmodel_flags.F90configurable_model_flags.indd289072a05230e2802f7c5e6f752b01340cb81e1614367438000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comAdding Shixuan's godunov_xpyp_ta updates here in case we want to merge them into our master branch. See #902. 2021-02-26 13:23:58 -0600dd289072a05230e2802f7c5e6f752b01340cb81eAdding Shixuan's godunov_xpyp_ta updates here in case we want to merge them into our master branch. See #902.editconfigurable_model_flags.inadvance_wp2_wp3_module.F908aebfdf2b109ec3d6fdc434375805fc1a4d6760a1614626041000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comTurning on wp3 pr_turb term. This commit sets C_wp3_turb=1 and l_use_tke_in_wp3_pr_turb_term=.true. and is BIT_CHANGING. Also in the pr_turb term I have converted the wp2_zt outside the derivative to a wp2 (momentum levels) inside the derivative. See #884. 2021-03-01 13:14:01 -06008aebfdf2b109ec3d6fdc434375805fc1a4d6760aTurning on wp3 pr_turb term.editadvance_wp2_wp3_module.F90configurable_model_flags.intunable_parameters.ine50b65d0773663559f42a6b7901e4f73aeeeb31d1614626041000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comTurning on wp3 pr_turb term. This commit sets C_wp3_turb=1 and l_use_tke_in_wp3_pr_turb_term=.true. and is BIT_CHANGING. Also in the pr_turb term I have converted the wp2_zt outside the derivative to a wp2 (momentum levels) inside the derivative. See #884. 2021-03-01 13:14:01 -0600e50b65d0773663559f42a6b7901e4f73aeeeb31dTurning on wp3 pr_turb term.editconfigurable_model_flags.inedittunable_parameters.inparameters_tunable.F90parameter_indices.F90surface_varnce_module.F90clubb_api_module.F90f9dd235e6cea6c1c32168b7122b2054d078380481615074952000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduChanged the variable up2_vp2_factor to up2_sfc_coef in all files 2021-03-06 17:55:52 -0600f9dd235e6cea6c1c32168b7122b2054d07838048Changed the variable up2_vp2_factor to up2_sfc_coef in all fileseditparameter_indices.F90editparameters_tunable.F90editsurface_varnce_module.F90editclubb_api_module.F90tunable_parameters.in1a0959d3f3c5b5d8f9fae84fbe5229e5ff3b86341615074952000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduChanged the variable up2_vp2_factor to up2_sfc_coef in all files 2021-03-06 17:55:52 -06001a0959d3f3c5b5d8f9fae84fbe5229e5ff3b8634Changed the variable up2_vp2_factor to up2_sfc_coef in all filesedittunable_parameters.inadvance_clubb_core_module.F90surface_varnce_module.F9013d8c614dd9a7ab539ab349ebeab61758bb666ae1615324148000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@uwm.eduI added an option to improve dry, convecting boundary layers. The new option is triggered by setting l_vary_convect_depth=.true. The option reduces the spurious surface spike in thlp2 in Wangara. The option calculates the Deardorff convective velocity using a variable estimate of layer depth based on the depth over which wpthlp is positive near the ground. thlp2_sfc is then diagnosed by assuming maximal correlation between thl and vertical velocity, w. Currently, l_vary_convect_depth is set to false, and hence the answers remain BFB. For #905. 2021-03-09 15:09:08 -060013d8c614dd9a7ab539ab349ebeab61758bb666aeI added an option to improve dry, convecting boundary layers.editsurface_varnce_module.F90editadvance_clubb_core_module.F90advance_xp2_xpyp_module.F90e5caa86acac2277408322ef32ba0587ed9194fe31615986503000http://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonvlarson@users.noreply.github.comThis commit switches the names, but not the values, of the dp1 and pr1 variables for up2 and vp2. In other words, up2_dp1 <---> up2_pr1 and vp2_dp1 <---> vp2_pr1. This makes the terms in these equations more consistent with the terms in the wp2 equation. I believe this commit is BIT_CHANGING since it will affect the values of these variables even though the nightly plot profiles should not change (but the budget plots would have these lines swapped). 2021-03-17 08:08:23 -0500e5caa86acac2277408322ef32ba0587ed9194fe3This commit switches the names, but not the values, of the dp1 and pr1 variables for up2 and vp2. In other words, up2_dp1 <---> up2_pr1 and vp2_dp1 <---> vp2_pr1. This makes the terms in these equations more consistent with the terms in the wp2 equation. I believe this commit is BIT_CHANGING since it will affect the values of these variables even though the nightly plot profiles should not change (but the budget plots would have these lines swapped).editadvance_xp2_xpyp_module.F90stats_sfc_module.F90grid_class.F90advance_clubb_core_module.F90surface_varnce_module.F90sfc_varnce_module.F90numerical_check.F90df7d5489d978444c7ca8a4ae9cd9f6411d9f024f1616100132000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduChanged surface to sfc in all instances where requested 2021-03-18 15:42:12 -0500df7d5489d978444c7ca8a4ae9cd9f6411d9f024fChanged surface to sfc in all instances where requestededitgrid_class.F90editnumerical_check.F90editstats_sfc_module.F90editadvance_clubb_core_module.F90deletesurface_varnce_module.F90addsfc_varnce_module.F90stats_sfc_module.F90b963c2ef6d96de64d0efc4523c28aae810cd0b941616102621000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUndid sfc change in stats_sfc_module.F90 2021-03-18 16:23:41 -0500b963c2ef6d96de64d0efc4523c28aae810cd0b94Undid sfc change in stats_sfc_module.F90editstats_sfc_module.F90grid_class.F90b47281e4a8aa2231716f381b9c11a2b2a6ad9ce21616102639000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUndid sfc change to grid_class.F90 2021-03-18 16:23:59 -0500b47281e4a8aa2231716f381b9c11a2b2a6ad9ce2Undid sfc change to grid_class.F90editgrid_class.F90numerical_check.F90ee6b3685c962fdd07d6c405a74bc22b2fed6cb121616102659000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUndid sfc change in numerical_check.F90 2021-03-18 16:24:19 -0500ee6b3685c962fdd07d6c405a74bc22b2fed6cb12Undid sfc change in numerical_check.F90editnumerical_check.F90setup_clubb_pdf_params.F90clubb_api_module.F905a8b661e439baa46b7deabf6e7625a2a46dad1881616623371000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduPushing grid column loop into setup_pdf_params. Adding iterface too, allowing us to call it with single or multiple columns so that the host models don't need updating to work with this change. This is bit-for-bit, tested with clubb_standalone and cam coarse res run. larson-group/cam#129 2021-03-24 17:02:51 -05005a8b661e439baa46b7deabf6e7625a2a46dad188Pushing grid column loop into setup_pdf_params. Adding iterface too, allowing us to call it with single or multiple columns so that the host models don't need updating to work with this change. This is bit-for-bit, tested with clubb_standalone and cam coarse res run. larson-group/cam#129editsetup_clubb_pdf_params.F90editclubb_api_module.F90setup_clubb_pdf_params.F90626a34a5add8859578c79290929d28b9a582a9c81616632453000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduBroke up column loop inside setup_pdf_params. This is all bit-for-bit. larson-group/cam#129 2021-03-24 19:34:13 -0500626a34a5add8859578c79290929d28b9a582a9c8Broke up column loop inside setup_pdf_params. This is all bit-for-bit. larson-group/cam#129editsetup_clubb_pdf_params.F90setup_clubb_pdf_params.F90e1ca5e193a0a11a8ca9ddbdad6a1dcb99826dff71616632485000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixed typo bug. larson-group/cam#129 2021-03-24 19:34:45 -0500e1ca5e193a0a11a8ca9ddbdad6a1dcb99826dff7Fixed typo bug. larson-group/cam#129editsetup_clubb_pdf_params.F90setup_clubb_pdf_params.F9083811d1b6b9ea21bf7de99ca5a089c8f577ea1f01616795595000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduPushed down some more loops in setup_pdf_params. All bit-for-bit. larson-group/cam#129 2021-03-26 16:53:15 -050083811d1b6b9ea21bf7de99ca5a089c8f577ea1f0Pushed down some more loops in setup_pdf_params. All bit-for-bit. larson-group/cam#129editsetup_clubb_pdf_params.F90setup_clubb_pdf_params.F907d3c765381a54780d7afe18727357a13cf8f89021617149848000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMore pushing loops down. All bit-for-bit. larson-group/cam#129 2021-03-30 19:17:28 -05007d3c765381a54780d7afe18727357a13cf8f8902More pushing loops down. All bit-for-bit. larson-group/cam#129editsetup_clubb_pdf_params.F90setup_clubb_pdf_params.F908a392e2906267efd3cf17d2218d908bc642e2b651617226775000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMore loop pushing. All bit-for-bit. larson-group/cam#129 2021-03-31 16:39:35 -05008a392e2906267efd3cf17d2218d908bc642e2b65More loop pushing. All bit-for-bit. larson-group/cam#129editsetup_clubb_pdf_params.F90setup_clubb_pdf_params.F905eea93b439a4b65bd66ee2c99ea450c12700d4651617308426000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMore loop pushing. All bit-for-bit. larson-group/cam#129 2021-04-01 15:20:26 -05005eea93b439a4b65bd66ee2c99ea450c12700d465More loop pushing. All bit-for-bit. larson-group/cam#129editsetup_clubb_pdf_params.F90setup_clubb_pdf_params.F90ddd03bfb9937fcf53449bd60f6daeab26a1c1a4e1617736320000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding comments explaining why component_corr_x_hm_n_ip uses corr_array_n_cloud twice. larson-group/cam#129 2021-04-06 14:12:00 -0500ddd03bfb9937fcf53449bd60f6daeab26a1c1a4eAdding comments explaining why component_corr_x_hm_n_ip uses corr_array_n_cloud twice. larson-group/cam#129editsetup_clubb_pdf_params.F90precipitation_fraction.F90setup_clubb_pdf_params.F903dfd524a9fb317bb2ba2bc1144725e4e6b1303f91617751722000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMore loop pushing, all bit-for-bit. larson-group/cam#129 2021-04-06 18:28:42 -05003dfd524a9fb317bb2ba2bc1144725e4e6b1303f9More loop pushing, all bit-for-bit. larson-group/cam#129editprecipitation_fraction.F90editsetup_clubb_pdf_params.F90mono_flux_limiter.F9020d8d29a86a4bd146281a4e07fde77759bccaae51617751805000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding one_half to use statement. This was a bug preventing compilation when using the ifort compiler with the MKL functions. 2021-04-06 18:30:05 -050020d8d29a86a4bd146281a4e07fde77759bccaae5Adding one_half to use statement. This was a bug preventing compilation when using the ifort compiler with the MKL functions.editmono_flux_limiter.F90mono_flux_limiter.F90459d33c483a695d8c5280a668c77b1ca11e1b6701617819873000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMoving use statement for one_half inside ifdef, since it is only needed if compilation with MKL functions is enabled. 2021-04-07 13:24:33 -0500459d33c483a695d8c5280a668c77b1ca11e1b670Moving use statement for one_half inside ifdef, since it is only needed if compilation with MKL functions is enabled.editmono_flux_limiter.F90setup_clubb_pdf_params.F90836ef0b2febf72beed7ee82884964687e6a409841617916504000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduReducing the number of calls to Cholesky_factor. This is bit-for-bit for all standalone cases and our coarse res version of cam. larson-group/cam#129 2021-04-08 16:15:04 -0500836ef0b2febf72beed7ee82884964687e6a40984Reducing the number of calls to Cholesky_factor. This is bit-for-bit for all standalone cases and our coarse res version of cam. larson-group/cam#129editsetup_clubb_pdf_params.F90setup_clubb_pdf_params.F90clubb_api_module.F9081f99a736be5ecab38c06863bced4837d694c08e1617922941000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduReordering dimensions of mu, sigma, corr_arrays, and cholesky matrices. This makes the dimension ordering more consistent with similar arrays and should help to reduce computational cost by reducing array slicing. This is all bit-for-bit. larson-group/cam#129 2021-04-08 18:02:21 -050081f99a736be5ecab38c06863bced4837d694c08eReordering dimensions of mu, sigma, corr_arrays, and cholesky matrices. This makes the dimension ordering more consistent with similar arrays and should help to reduce computational cost by reducing array slicing. This is all bit-for-bit. larson-group/cam#129editclubb_api_module.F90editsetup_clubb_pdf_params.F90transform_to_pdf_module.F90latin_hypercube_driver_module.F906392e9cc0de299d0de9ce962ba5da5104b1a87561617922941000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduReordering dimensions of mu, sigma, corr_arrays, and cholesky matrices. This makes the dimension ordering more consistent with similar arrays and should help to reduce computational cost by reducing array slicing. This is all bit-for-bit. larson-group/cam#129 2021-04-08 18:02:21 -05006392e9cc0de299d0de9ce962ba5da5104b1a8756Reordering dimensions of mu, sigma, corr_arrays, and cholesky matrices. This makes the dimension ordering more consistent with similar arrays and should help to reduce computational cost by reducing array slicing. This is all bit-for-bit. larson-group/cam#129editlatin_hypercube_driver_module.F90edittransform_to_pdf_module.F90setup_clubb_pdf_params.F90ca2f0784973138d286bb3bef8f26ac27e039fbef1617998854000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduPerformance improvements from chaning loop orderings and redundant operation reduction. All bit-for-bit. larson-group/cam#129 2021-04-09 15:07:34 -0500ca2f0784973138d286bb3bef8f26ac27e039fbefPerformance improvements from chaning loop orderings and redundant operation reduction. All bit-for-bit. larson-group/cam#129editsetup_clubb_pdf_params.F90setup_clubb_pdf_params.F9006ffbc2944cd085910cc68344ca3646934145a931618000160000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduReordering dimensions on some arrays. This is bit-for-bit. larson-group/cam#129 2021-04-09 15:29:20 -050006ffbc2944cd085910cc68344ca3646934145a93Reordering dimensions on some arrays. This is bit-for-bit. larson-group/cam#129editsetup_clubb_pdf_params.F90setup_clubb_pdf_params.F90746f45a04d2e889f4feb1dfb69b0a7f5b19e04c21618001640000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduReducing operations. All bit-for-bit. larson-group/cam#129 2021-04-09 15:54:00 -0500746f45a04d2e889f4feb1dfb69b0a7f5b19e04c2Reducing operations. All bit-for-bit. larson-group/cam#129editsetup_clubb_pdf_params.F90pdf_utilities.F90setup_clubb_pdf_params.F900b60550541c0d76dcc5a42894822d0d3c4899b7c1618007396000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding 2D subroutine versions of some functions to improve performance. This is all bit-for-bit. larson-group/cam#129 2021-04-09 17:29:56 -05000b60550541c0d76dcc5a42894822d0d3c4899b7cAdding 2D subroutine versions of some functions to improve performance. This is all bit-for-bit. larson-group/cam#129editsetup_clubb_pdf_params.F90editpdf_utilities.F90setup_clubb_pdf_params.F9075c4cd9461c1cca785c96bb85d5bad923b3084151618014437000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduSome small cleanup, all just formatting. larson-group/cam#129 2021-04-09 19:27:17 -050075c4cd9461c1cca785c96bb85d5bad923b308415Some small cleanup, all just formatting. larson-group/cam#129editsetup_clubb_pdf_params.F90advance_clubb_core_module.F903dafc67dc7207d5794d9a4c66c095e7366e4afbf1618072037000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduChanged ustar from an array to a scalar issue #909 2021-04-10 11:27:17 -05003dafc67dc7207d5794d9a4c66c095e7366e4afbfChanged ustar from an array to a scalar issue #909editadvance_clubb_core_module.F90stats_variables.F90advance_clubb_core_module.F90stats_zm_module.F903c65841d1646f218145bbfc448e694e0b819c0961618079098000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduRenamed Ri_zm to sqrt_Ri_zm and iRi_zm to isqrt_Ri_zm #909 2021-04-10 13:24:58 -05003c65841d1646f218145bbfc448e694e0b819c096Renamed Ri_zm to sqrt_Ri_zm and iRi_zm to isqrt_Ri_zm #909editstats_variables.F90editadvance_clubb_core_module.F90editstats_zm_module.F90advance_clubb_core_module.F90mixing_length.F90083074dbb32c7c4fbee30f0ec93ee1108ad00f821618088325000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduCreated new subroutine and ensured it's BFB. All cases run sucessfully #909 2021-04-10 15:58:45 -0500083074dbb32c7c4fbee30f0ec93ee1108ad00f82Created new subroutine and ensured it's BFB. All cases run sucessfully #909editadvance_clubb_core_module.F90editmixing_length.F90advance_clubb_core_module.F90mixing_length.F90cc9e3f188d62b243bb65dfea2082e7b22ad21f7c1618674656000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduadded in missing flag which was causing memory errors #909 2021-04-17 10:50:56 -0500cc9e3f188d62b243bb65dfea2082e7b22ad21f7cadded in missing flag which was causing memory errors #909editadvance_clubb_core_module.F90editmixing_length.F90mixing_length.F905630905cce78e4f538126d288ffeae5ebffb3bd71618679816000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.educonfirmed BFB with e3sam flag set to false and true, no other issues detected in mixing_length #909 2021-04-17 12:16:56 -05005630905cce78e4f538126d288ffeae5ebffb3bd7confirmed BFB with e3sam flag set to false and true, no other issues detected in mixing_length #909editmixing_length.F90stats_zm_module.F902838d3adef376202e2fcf4112c1ee43c94231c721619035906000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdate stats_zm_module.F90 Removed units from description to eliminate redundancy. 2021-04-21 15:11:46 -05002838d3adef376202e2fcf4112c1ee43c94231c72Update stats_zm_module.F90editstats_zm_module.F90setup_clubb_pdf_params.F90bb689e837ad32290f9e7cac225a1266db2bed0f11619041140000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding dummy dimensions to calls to procedures that operate over 2 dimensions now, and remove 1D versions of those procedures. larson-group/cam#129 2021-04-21 16:39:00 -0500bb689e837ad32290f9e7cac225a1266db2bed0f1Adding dummy dimensions to calls to procedures that operate over 2 dimensions now, and remove 1D versions of those procedures. larson-group/cam#129editsetup_clubb_pdf_params.F90hydromet_pdf_parameter_module.F90setup_clubb_pdf_params.F90clubb_api_module.F90a8e1b1620d5ae765286eb6469fd893dc19b5e1541619140595000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduSeparating precip fractions from hyrdromet_pdf_params and creating a type of it's own for it. This is bit-for-bit. larson-group/cam#129 2021-04-22 20:16:35 -0500a8e1b1620d5ae765286eb6469fd893dc19b5e154Separating precip fractions from hyrdromet_pdf_params and creating a type of it's own for it. This is bit-for-bit. larson-group/cam#129editclubb_api_module.F90editsetup_clubb_pdf_params.F90edithydromet_pdf_parameter_module.F90silhs_api_module.F90latin_hypercube_driver_module.F90silhs_importance_sample_module.F908a23c35833576ef995f50fdaaff19c901989d3511619140595000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduSeparating precip fractions from hyrdromet_pdf_params and creating a type of it's own for it. This is bit-for-bit. larson-group/cam#129 2021-04-22 20:16:35 -05008a23c35833576ef995f50fdaaff19c901989d351Separating precip fractions from hyrdromet_pdf_params and creating a type of it's own for it. This is bit-for-bit. larson-group/cam#129editsilhs_api_module.F90editlatin_hypercube_driver_module.F90editsilhs_importance_sample_module.F90pdf_utilities.F90precipitation_fraction.F90setup_clubb_pdf_params.F90clubb_api_module.F909291cc6f06418e89d903e401f04caefe62ee72961619220291000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFormatting and condensing if statements. All bit-for-bit. larson-group/cam#129 2021-04-23 18:24:51 -05009291cc6f06418e89d903e401f04caefe62ee7296Formatting and condensing if statements. All bit-for-bit. larson-group/cam#129editclubb_api_module.F90editpdf_utilities.F90editsetup_clubb_pdf_params.F90editprecipitation_fraction.F90setup_clubb_pdf_params.F90clubb_api_module.F90411f4fc5a1518d746b88dc254811231681d0a6581619223182000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduMaking hydromet_pdf_params optional in setup_pdf_parameters. larson-group/cam#129 2021-04-23 19:13:02 -0500411f4fc5a1518d746b88dc254811231681d0a658Making hydromet_pdf_params optional in setup_pdf_parameters. larson-group/cam#129editclubb_api_module.F90editsetup_clubb_pdf_params.F90mixing_length.F90advance_clubb_core_module.F905733151420dd3f25f57b270e0a6eb4c38e889ea81619555277000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@brock.math.uwm.eduReformatted mixing length to be more compliant with the coding standard #909 2021-04-27 15:27:57 -05005733151420dd3f25f57b270e0a6eb4c38e889ea8Reformatted mixing length to be more compliant with the coding standard #909editmixing_length.F90editadvance_clubb_core_module.F90mixing_length.F909dbd2b39f631f080bb509e1dff6ee5eadb0aebea1619555727000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@brock.math.uwm.eduadded a reference to new subroutine #909 2021-04-27 15:35:27 -05009dbd2b39f631f080bb509e1dff6ee5eadb0aebeaadded a reference to new subroutine #909editmixing_length.F90silhs_api_module.F90est_kessler_microphys_module.F90lh_microphys_var_covar_module.F90latin_hypercube_driver_module.F90e32474f6f7a50bbc43c9352a829d8f51919fb2541619728413000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding second dimension to allocatable arrays in pdf_parameter type. This also requires lots of dummy dimensions in clubb where pdf_params is used, since clubb only works over a single column, but silhs does not need such a dummy dimension. larson-group/cam#129 2021-04-29 15:33:33 -0500e32474f6f7a50bbc43c9352a829d8f51919fb254Adding second dimension to allocatable arrays in pdf_parameter type. This also requires lots of dummy dimensions in clubb where pdf_params is used, since clubb only works over a single column, but silhs does not need such a dummy dimension. larson-group/cam#129editest_kessler_microphys_module.F90editsilhs_api_module.F90editlatin_hypercube_driver_module.F90editlh_microphys_var_covar_module.F90mixing_length.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90clubb_api_module.F90numerical_check.F90pdf_closure_module.F90pdf_parameter_module.F90stats_clubb_utilities.F90setup_clubb_pdf_params.F90435b6db3c46b177b9001d80a01dc514a6d7d21081619728413000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding second dimension to allocatable arrays in pdf_parameter type. This also requires lots of dummy dimensions in clubb where pdf_params is used, since clubb only works over a single column, but silhs does not need such a dummy dimension. larson-group/cam#129 2021-04-29 15:33:33 -0500435b6db3c46b177b9001d80a01dc514a6d7d2108Adding second dimension to allocatable arrays in pdf_parameter type. This also requires lots of dummy dimensions in clubb where pdf_params is used, since clubb only works over a single column, but silhs does not need such a dummy dimension. larson-group/cam#129editclubb_api_module.F90editpdf_closure_module.F90editadvance_clubb_core_module.F90editadvance_xp2_xpyp_module.F90editmixing_length.F90editpdf_parameter_module.F90editsetup_clubb_pdf_params.F90editstats_clubb_utilities.F90editnumerical_check.F90latin_hypercube_driver_module.F9033438476ecd7e056fa1c9acad479f9e5d07275381619732066000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing lines that exceed 100 characters. 2021-04-29 16:34:26 -050033438476ecd7e056fa1c9acad479f9e5d0727538Fixing lines that exceed 100 characters.editlatin_hypercube_driver_module.F90mixing_length.F90input_reader.F90advance_xp2_xpyp_module.F90pdf_closure_module.F90advance_clubb_core_module.F90setup_clubb_pdf_params.F902914cd2f18a991c5aac68c9e4decb9a671bdc24c1619732066000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing lines that exceed 100 characters. 2021-04-29 16:34:26 -05002914cd2f18a991c5aac68c9e4decb9a671bdc24cFixing lines that exceed 100 characters.editsetup_clubb_pdf_params.F90editadvance_xp2_xpyp_module.F90editinput_reader.F90editadvance_clubb_core_module.F90editmixing_length.F90editpdf_closure_module.F90latin_hypercube_driver_module.F906cccc97628f336e094482e6d6b8dd656918e5d1e1619735494000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduPushing loops related to pdf_params down. larson-group/cam#129 2021-04-29 17:31:34 -05006cccc97628f336e094482e6d6b8dd656918e5d1ePushing loops related to pdf_params down. larson-group/cam#129editlatin_hypercube_driver_module.F90advance_clubb_core_module.F90f1f64bdc39de16e140bec54e02a24bfd454349aa1620078062000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.educlubb warnings introduced from merge have been removed #909 2021-05-03 16:41:02 -0500f1f64bdc39de16e140bec54e02a24bfd454349aaclubb warnings introduced from merge have been removed #909editadvance_clubb_core_module.F90stats_zm_module.F90sigma_sqd_w_module.F90c4b005c8774c7fcda4a675f93c5048e8763ddcb51620165243000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@uwm.eduChanged safeguard threshold in sigma_sqd_w. This is BIT_CHANGING. For ticket #917. 2021-05-04 16:54:03 -0500c4b005c8774c7fcda4a675f93c5048e8763ddcb5Changed safeguard threshold in sigma_sqd_w.editstats_zm_module.F90editsigma_sqd_w_module.F90stats_variables.F90advance_wp2_wp3_module.F90stats_zt_module.F900ff19bb07774aa8f1428a14343d3011006c29fe21620739983000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comAdding some new code that puts the diffusion term d(wp2*em)/dz into a new function, creates a new wp3 budget term (wp3_pr_dfsn), and adds that new budget term to pyplotgen. 2021-05-11 08:33:03 -05000ff19bb07774aa8f1428a14343d3011006c29fe2Adding some new code that puts the diffusion term d(wp2*em)/dz into a new function, creates a new wp3 budget term (wp3_pr_dfsn), and adds that new budget term to pyplotgen.editstats_zt_module.F90editstats_variables.F90editadvance_wp2_wp3_module.F90advance_wp2_wp3_module.F90parameters_tunable.F90parameter_indices.F90clubb_api_module.F90f45b1489eb4795f960dae317fe379c48a4fa12ab1620739983000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comAdding new coefficient to control the wp3 pressure diffusion term. 2021-05-11 08:33:03 -0500f45b1489eb4795f960dae317fe379c48a4fa12abAdding new coefficient to control the wp3 pressure diffusion term.editparameters_tunable.F90editadvance_wp2_wp3_module.F90editclubb_api_module.F90editparameter_indices.F90advance_wp2_wp3_module.F902bb6466cf7c606f404b75d87bdaa24c8a91f83bf1620739983000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comSome minor updates to advance_wp2_wp3 relevant to the pr_turb and pr_dfsn terms. 2021-05-11 08:33:03 -05002bb6466cf7c606f404b75d87bdaa24c8a91f83bfSome minor updates to advance_wp2_wp3 relevant to the pr_turb and pr_dfsn terms.editadvance_wp2_wp3_module.F90advance_wp2_wp3_module.F90stats_clubb_utilities.F90f31e107d90fe179831f51a9c36a6f2120ff92f5b1620739983000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comConverting em*d(em)/dz to d(em^2)/dz in the wp3_pr_turb term and fixing a typo. 2021-05-11 08:33:03 -0500f31e107d90fe179831f51a9c36a6f2120ff92f5bConverting em*d(em)/dz to d(em^2)/dz in the wp3_pr_turb term and fixing a typo.editadvance_wp2_wp3_module.F90editstats_clubb_utilities.F90advance_wp2_wp3_module.F90parameters_tunable.F90parameter_indices.F90clubb_api_module.F90940e82e287987a4884a22037d10ec38837f137d41620739983000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comRenaming C_wp3_turb --> C_wp3_pr_turb (BIT_CHANGING due to name change in netcdf output). See #884. 2021-05-11 08:33:03 -0500940e82e287987a4884a22037d10ec38837f137d4Renaming C_wp3_turb --> C_wp3_pr_turb (BIT_CHANGING due to name change in netcdf output).editadvance_wp2_wp3_module.F90editclubb_api_module.F90editparameters_tunable.F90editparameter_indices.F90advance_wp2_wp3_module.F90pdf_closure_module.F90stats_variables.F90stats_clubb_utilities.F90stats_zm_module.F90advance_clubb_core_module.F90de3c925f59bcfd893d04eb2855548136a17e351e1620739983000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comThese changes add the new fourth-order moment variables wp2up2 and wp2vp2 to the CLUBB code. This requires a new function in pdf_closure_module since they must be calculated separately with a new formula, and they are fed through into advance_wp2_wp3 for use with the pr_dfsn subroutine. They are also added to the standard stats file and will be output to netcdf, hence this commit is BIT_CHANGING. The new variables are also added to pyplotgen as part of VariableGroupWs.py where wp4 is found. See #920. 2021-05-11 08:33:03 -0500de3c925f59bcfd893d04eb2855548136a17e351eThese changes add the new fourth-order moment variables wp2up2 and wp2vp2 to the CLUBB code. This requires a new function in pdf_closure_module since they must be calculated separately with a new formula, and they are fed through into advance_wp2_wp3 for use with the pr_dfsn subroutine. They are also added to the standard stats file and will be output to netcdf, hence this commit is BIT_CHANGING.editstats_variables.F90editstats_clubb_utilities.F90editpdf_closure_module.F90editadvance_wp2_wp3_module.F90editstats_zm_module.F90editadvance_clubb_core_module.F90tunable_parameters.ina52e22d9e89e61f7958b52f7fd3d4c7bc6bb0a821620739983000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comAdding new coefficient to control the wp3 pressure diffusion term. 2021-05-11 08:33:03 -0500a52e22d9e89e61f7958b52f7fd3d4c7bc6bb0a82Adding new coefficient to control the wp3 pressure diffusion term.edittunable_parameters.inadvance_wp2_wp3_module.F903e4c7b2d0ba9402c006006c3743bcb9ed918ad4a1620739983000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comPutting the wp3_pr_turb formulation back to its d(rho*wp2*em)/dz form. This would be a BIT_CHANGING commit since it would change the answers for the pr_turb term. However once this branch is merged into the master branch, results should be bit-for-bit since this term was only modified in the alternate branch. See #920. 2021-05-11 08:33:03 -05003e4c7b2d0ba9402c006006c3743bcb9ed918ad4aPutting the wp3_pr_turb formulation back to its d(rho*wp2*em)/dz form. This would be a BIT_CHANGING commit since it would change the answers for the pr_turb term. However once this branch is merged into the master branch, results should be bit-for-bit since this term was only modified in the alternate branch.editadvance_wp2_wp3_module.F90tunable_parameters.in65a68628bc05865c87e2c6833df4934b69f53bfb1620739983000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comThese changes add the new fourth-order moment variables wp2up2 and wp2vp2 to the CLUBB code. This requires a new function in pdf_closure_module since they must be calculated separately with a new formula, and they are fed through into advance_wp2_wp3 for use with the pr_dfsn subroutine. They are also added to the standard stats file and will be output to netcdf, hence this commit is BIT_CHANGING. The new variables are also added to pyplotgen as part of VariableGroupWs.py where wp4 is found. See #920. 2021-05-11 08:33:03 -050065a68628bc05865c87e2c6833df4934b69f53bfbThese changes add the new fourth-order moment variables wp2up2 and wp2vp2 to the CLUBB code. This requires a new function in pdf_closure_module since they must be calculated separately with a new formula, and they are fed through into advance_wp2_wp3 for use with the pr_dfsn subroutine. They are also added to the standard stats file and will be output to netcdf, hence this commit is BIT_CHANGING.edittunable_parameters.instats_type_utilities.F90interpolation.F90advance_clubb_core_module.F90advance_windm_edsclrm_module.F90calc_pressure.F90advance_helper_module.F903c6fc8de1942c935d48433c37c2250ba655681e51620766665000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@uwm.eduAdded intent comments for the following files: advance_clubb_core_module, advance_helper_module, and advance_windm_edsclrm_module. These changes are BFB. For ticket #924. 2021-05-11 15:57:45 -05003c6fc8de1942c935d48433c37c2250ba655681e5Added intent comments for the following files:editadvance_helper_module.F90editadvance_windm_edsclrm_module.F90editstats_type_utilities.F90editinterpolation.F90editadvance_clubb_core_module.F90editcalc_pressure.F90configurable_model_flags.inb4a6c7c955a95b25df433292cafcce079b8b37141620854783000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comSetting l_update_pressure = .false. since it was causing a problem with the MC3E test and is turned off in all host models anyway. This is BIT_CHANGING. See https://github.com/larson-group/e3sm/issues/6. 2021-05-12 16:26:23 -0500b4a6c7c955a95b25df433292cafcce079b8b3714Setting l_update_pressure = .false. since it was causing a problem with the MC3E test and is turned off in all host models anyway.editconfigurable_model_flags.inadvance_clubb_core_module.F90pdf_closure_module.F900799b154b8dd0feb9ebe8189be0f004b142d08a31620868004000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comRemoving "if" statement around calculation of wp4 in pdf_closure_module.F90 and the same "if" statement around some further manipulation of wp4 in advance_clubb_core. Results are bit-for-bit with this change, since normally all cases calculate wp4 anyway since the "if" condition was always satisfied in normal runs (but not, for example, in some tuning runs). This was done because the new wp3_pr_dfsn term needs wp4 in its current formulation so it needs to always be calculated. See #920. 2021-05-12 20:06:44 -05000799b154b8dd0feb9ebe8189be0f004b142d08a3Removing "if" statement around calculation of wp4 in pdf_closure_module.F90 and the same "if" statement around some further manipulation of wp4 in advance_clubb_core. Results are bit-for-bit with this change, since normally all cases calculate wp4 anyway since the "if" condition was always satisfied in normal runs (but not, for example, in some tuning runs). This was done because the new wp3_pr_dfsn term needs wp4 in its current formulation so it needs to always be calculated.editadvance_clubb_core_module.F90editpdf_closure_module.F90advance_clubb_core_module.F904637d2f68f4d5b3fa73a677f17e83669b2d363341620911586000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comRemoving some "use" statement variables from advance_clubb_core, since they are no longer used here but are now used in mixing_length.F90. See #909. 2021-05-13 08:13:06 -05004637d2f68f4d5b3fa73a677f17e83669b2d36334Removing some "use" statement variables from advance_clubb_core, since they are no longer used here but are now used in mixing_length.F90.editadvance_clubb_core_module.F90advance_helper_module.F904856129fd79896091b3eecfdcdaab73c812e607e1620921894000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comFixed comment regarding wp3 splatting term. 2021-05-13 11:04:54 -05004856129fd79896091b3eecfdcdaab73c812e607eFixed comment regarding wp3 splatting term.editadvance_helper_module.F90advance_wp2_wp3_module.F90clip_explicit.F909833dff319c94c1908ae15e112a800a3587f5df31621706433000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduAdded intent comments. For file advance_wp2_wp3_module.F90. Results are confirmed to be BFB. For ticket #924. 2021-05-22 13:00:33 -05009833dff319c94c1908ae15e112a800a3587f5df3Added intent comments.editclip_explicit.F90editadvance_wp2_wp3_module.F90pos_definite_module.F90advance_xm_wpxp_module.F90mono_flux_limiter.F90lapack_wrap.F906559732d33be2ec8f4ebc58a5ec029d4549ccc351621710963000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduAdded intent comments. For the file advance_xm_wpxp_module.F90. I also changed the order of arguments in certain arugment lists to conform to the coding standard. Changes confirmed to be BFB. For ticket #924. 2021-05-22 14:16:03 -05006559732d33be2ec8f4ebc58a5ec029d4549ccc35Added intent comments.editmono_flux_limiter.F90editlapack_wrap.F90editadvance_xm_wpxp_module.F90editpos_definite_module.F90advance_xp2_xpyp_module.F90advance_helper_module.F90d774cff18029de5cc9943c8ea83f4aded41df5b71621713185000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduAdded intent comments for advance_xp2_xpyp_module.F90. Additionally, I made changes to certain argument lists to better reflect the coding standard. Changed confirmed to be BFB. For ticket #924. 2021-05-22 14:53:05 -0500d774cff18029de5cc9943c8ea83f4aded41df5b7Added intent comments for advance_xp2_xpyp_module.F90.editadvance_helper_module.F90editadvance_xp2_xpyp_module.F90clip_explicit.F907e0741b435d5318010ea92055b2329e08dba34181621951468000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comMakes surface clipping of wp3 consistent with clipping aloft, per #921. This is BIT_CHANGING since it affects how clipping is applied near the surface. 2021-05-25 09:04:28 -05007e0741b435d5318010ea92055b2329e08dba3418Makes surface clipping of wp3 consistent with clipping aloft, per #921. This is BIT_CHANGING since it affects how clipping is applied near the surface.editclip_explicit.F90clip_explicit.F90dbe9250e6217d60ef45b38553618402e151d939d1621951468000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comDeleting comments around the old "magic number" for the near-surface clipping. See #921. 2021-05-25 09:04:28 -0500dbe9250e6217d60ef45b38553618402e151d939dDeleting comments around the old "magic number" for the near-surface clipping.editclip_explicit.F90parameters_tunable.F90332f11bd30bb9aaf57f218d7fe3769e2cc2016701622231456000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduFixing fortran standards violation causing compiler errors with nvfortran. See larson-group/clubb#900 and larson-group/clubb#928. 2021-05-28 14:50:56 -0500332f11bd30bb9aaf57f218d7fe3769e2cc201670Fixing fortran standards violation causing compiler errors with nvfortran. See larson-group/clubb#900 and larson-group/clubb#928.editparameters_tunable.F90parameters_tunable.F90new_hybrid_pdf_main.F90advance_helper_module.F90242a46454b543774c56a2c6b15b74b86eaf5b5bc1622648527000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduChanged some elements of clubb to allow for better script execution 2021-06-02 10:42:07 -0500242a46454b543774c56a2c6b15b74b86eaf5b5bcChanged some elements of clubb to allow for better script executioneditnew_hybrid_pdf_main.F90editadvance_helper_module.F90editparameters_tunable.F90advance_helper_module.F90153d245615688f92096d7ef460fb65d04f97571e1622651931000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduFixed clubb not compiling 2021-06-02 11:38:51 -0500153d245615688f92096d7ef460fb65d04f97571eFixed clubb not compilingeditadvance_helper_module.F90clubb_api_module.F90clip_explicit.F90advance_xm_wpxp_module.F90stats_type_utilities.F90setup_clubb_pdf_params.F90advance_windm_edsclrm_module.F90new_pdf_main.F90mono_flux_limiter.F90advance_helper_module.F90mixing_length.F90new_tsdadg_pdf.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90LY93_pdf.F90Skx_module.F90pdf_closure_module.F90adg1_adg2_3d_luhar_pdf.F90calc_pressure.F90new_hybrid_pdf_main.F90diffusion.F90numerical_check.F90pos_definite_module.F90parameters_tunable.F90new_pdf.F90sponge_layer_damping.F90turbulent_adv_pdf.F90advance_xp3_module.F90advance_clubb_core_module.F90mean_adv.F90fill_holes.F90stats_clubb_utilities.F90fdcdbc1e4834f13714c9d2a4464cd02dc410b0321622741937000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduFeeding gr through the arg list where need only in the CLUBB_core dir. Note, that since some of the functions/subroutines in CLUBB_core are used elsewhere throughout clubb, other parts of clubb such as a file in SILHS, and a few in the outer layer of the source folder needed to be updated in order to reflect the changes. However, everything outside of the CLUBB_core directory still uses use statements in order to use gr from grid class. For ticket #886. All changes are confirmed BFB identical. 2021-06-03 12:38:57 -0500fdcdbc1e4834f13714c9d2a4464cd02dc410b032Feeding gr through the arg list where need only in the CLUBB_core dir.editadvance_xp3_module.F90editstats_clubb_utilities.F90editadvance_windm_edsclrm_module.F90editSkx_module.F90editmixing_length.F90editnumerical_check.F90editnew_pdf.F90editpdf_closure_module.F90editsetup_clubb_pdf_params.F90editturbulent_adv_pdf.F90editclubb_api_module.F90editsponge_layer_damping.F90editadvance_xp2_xpyp_module.F90editnew_tsdadg_pdf.F90editcalc_pressure.F90editdiffusion.F90editnew_hybrid_pdf_main.F90editadvance_wp2_wp3_module.F90editpos_definite_module.F90editstats_type_utilities.F90editclip_explicit.F90editmono_flux_limiter.F90editnew_pdf_main.F90editadvance_helper_module.F90editfill_holes.F90editmean_adv.F90editadg1_adg2_3d_luhar_pdf.F90editadvance_clubb_core_module.F90editparameters_tunable.F90editLY93_pdf.F90editadvance_xm_wpxp_module.F90latin_hypercube_driver_module.F90b8be2708ee69c2ba48379def5c0cb16c852f36111622741937000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduFeeding gr through the arg list where need only in the CLUBB_core dir. Note, that since some of the functions/subroutines in CLUBB_core are used elsewhere throughout clubb, other parts of clubb such as a file in SILHS, and a few in the outer layer of the source folder needed to be updated in order to reflect the changes. However, everything outside of the CLUBB_core directory still uses use statements in order to use gr from grid class. For ticket #886. All changes are confirmed BFB identical. 2021-06-03 12:38:57 -0500b8be2708ee69c2ba48379def5c0cb16c852f3611Feeding gr through the arg list where need only in the CLUBB_core dir.editlatin_hypercube_driver_module.F90clubb_api_module.F900b4086681549ba1ade7cd159f63992e231de132b1622745453000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduReverted changes to clubb_api. For #886 2021-06-03 13:37:33 -05000b4086681549ba1ade7cd159f63992e231de132bReverted changes to clubb_api. For #886editclubb_api_module.F90clubb_api_module.F90advance_xm_wpxp_module.F90clip_explicit.F90numerical_check.F90new_pdf.F90new_pdf_main.F90advance_windm_edsclrm_module.F90mono_flux_limiter.F90advance_helper_module.F90advance_wp2_wp3_module.F90mixing_length.F90advance_xp2_xpyp_module.F90advance_xp3_module.F90LY93_pdf.F90advance_clubb_core_module.F90fill_holes.F90Skx_module.F90pdf_closure_module.F90adg1_adg2_3d_luhar_pdf.F90ac4315a4656171d60e7612e105a31aa2bf1086871622821498000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduReplacing use gr statements with feeding gr throught the arg list. This commit is for slight improvement to the script in order to better adhere to the coding standard. For ticket #886. Results confirmed to be BFB identical. 2021-06-04 10:44:58 -0500ac4315a4656171d60e7612e105a31aa2bf108687Replacing use gr statements with feeding gr throught the arg list.editadvance_xp3_module.F90editadvance_wp2_wp3_module.F90editclubb_api_module.F90editSkx_module.F90editmono_flux_limiter.F90editnew_pdf_main.F90editadvance_xp2_xpyp_module.F90editmixing_length.F90editadvance_windm_edsclrm_module.F90editpdf_closure_module.F90editnumerical_check.F90editfill_holes.F90editadvance_helper_module.F90editLY93_pdf.F90editadg1_adg2_3d_luhar_pdf.F90editadvance_xm_wpxp_module.F90editnew_pdf.F90editclip_explicit.F90editadvance_clubb_core_module.F90clip_explicit.F90advance_xm_wpxp_module.F90Nc_Ncn_eqns.F90calc_roots.F90setup_clubb_pdf_params.F90advance_windm_edsclrm_module.F90new_pdf_main.F90advance_helper_module.F90pdf_utilities.F90advance_wp2_wp3_module.F90mixing_length.F90file_functions.F90advance_xp2_xpyp_module.F90output_grads.F90stats_rad_zt_module.F90Skx_module.F90calc_pressure.F90index_mapping.F90clip_semi_implicit.F90numerical_check.F90pos_definite_module.F90output_netcdf.F90stats_lh_sfc_module.F90hydromet_pdf_parameter_module.F90saturation.F90advance_xp3_module.F90mean_adv.F90stats_zt_module.F90sigma_sqd_w_module.F90stats_sfc_module.F90stats_zm_module.F90parameters_model.F90matrix_operations.F90calendar.F90clubb_api_module.F90input_reader.F90stats_lh_zt_module.F90stats_type_utilities.F90diagnose_correlations_module.F90grid_class.F90mono_flux_limiter.F90new_tsdadg_pdf.F90LY93_pdf.F90stats_rad_zm_module.F90new_hybrid_pdf.F90pdf_closure_module.F90adg1_adg2_3d_luhar_pdf.F90new_hybrid_pdf_main.F90corr_varnce_module.F90precipitation_fraction.F90diffusion.F90endian.F90pdf_parameter_module.F90parameters_tunable.F90new_pdf.F90sponge_layer_damping.F90turbulent_adv_pdf.F90advance_clubb_core_module.F90lapack_wrap.F90fill_holes.F90stats_clubb_utilities.F90interpolation.F90T_in_K_module.F90sfc_varnce_module.F90b2e07aedb378d4a517568df6fd3bad22c525cb101623083951000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduAdding proper indentation to needed files. The purpose of this commit is to make the indentation uniform across clubb in order to make script execution easier for replacing gr occurances across clubb. Related to ticket #886. Results are BFB identical. 2021-06-07 11:39:11 -0500b2e07aedb378d4a517568df6fd3bad22c525cb10Adding proper indentation to needed files.editadvance_xp3_module.F90editpdf_closure_module.F90editprecipitation_fraction.F90editstats_type_utilities.F90editclip_explicit.F90editpos_definite_module.F90editpdf_utilities.F90editsetup_clubb_pdf_params.F90editadg1_adg2_3d_luhar_pdf.F90editmatrix_operations.F90editfile_functions.F90editnew_hybrid_pdf_main.F90editendian.F90editcalc_roots.F90editsigma_sqd_w_module.F90editadvance_wp2_wp3_module.F90editdiagnose_correlations_module.F90editsaturation.F90editadvance_xm_wpxp_module.F90editmean_adv.F90editnew_hybrid_pdf.F90editstats_clubb_utilities.F90editstats_sfc_module.F90editturbulent_adv_pdf.F90editclubb_api_module.F90editfill_holes.F90editinput_reader.F90editinterpolation.F90editmono_flux_limiter.F90editoutput_netcdf.F90editT_in_K_module.F90editdiffusion.F90editpdf_parameter_module.F90editadvance_clubb_core_module.F90editcalendar.F90editstats_zt_module.F90editmixing_length.F90editoutput_grads.F90editNc_Ncn_eqns.F90editstats_rad_zm_module.F90editgrid_class.F90editadvance_xp2_xpyp_module.F90editclip_semi_implicit.F90edithydromet_pdf_parameter_module.F90editstats_zm_module.F90editlapack_wrap.F90editnew_pdf.F90editnumerical_check.F90editparameters_model.F90editcalc_pressure.F90editnew_tsdadg_pdf.F90editsponge_layer_damping.F90editadvance_windm_edsclrm_module.F90editcorr_varnce_module.F90editindex_mapping.F90editLY93_pdf.F90editadvance_helper_module.F90editstats_lh_zt_module.F90editstats_rad_zt_module.F90editstats_lh_sfc_module.F90editSkx_module.F90editparameters_tunable.F90editsfc_varnce_module.F90editnew_pdf_main.F90clip_explicit.F90advance_xm_wpxp_module.F90Nc_Ncn_eqns.F90calc_roots.F90setup_clubb_pdf_params.F90advance_windm_edsclrm_module.F90new_pdf_main.F90advance_helper_module.F90mixing_length.F90advance_wp2_wp3_module.F90pdf_utilities.F90file_functions.F90advance_xp2_xpyp_module.F90output_grads.F90stats_rad_zt_module.F90Skx_module.F90calc_pressure.F90index_mapping.F90clip_semi_implicit.F90numerical_check.F90pos_definite_module.F90output_netcdf.F90stats_lh_sfc_module.F90hydromet_pdf_parameter_module.F90saturation.F90advance_xp3_module.F90stats_zt_module.F90mean_adv.F90stats_sfc_module.F90sigma_sqd_w_module.F90stats_zm_module.F90parameters_model.F90matrix_operations.F90calendar.F90clubb_api_module.F90input_reader.F90stats_lh_zt_module.F90stats_type_utilities.F90diagnose_correlations_module.F90grid_class.F90mono_flux_limiter.F90new_tsdadg_pdf.F90LY93_pdf.F90stats_rad_zm_module.F90new_hybrid_pdf.F90pdf_closure_module.F90adg1_adg2_3d_luhar_pdf.F90new_hybrid_pdf_main.F90corr_varnce_module.F90precipitation_fraction.F90diffusion.F90endian.F90parameters_tunable.F90pdf_parameter_module.F90new_pdf.F90sponge_layer_damping.F90turbulent_adv_pdf.F90advance_clubb_core_module.F90lapack_wrap.F90fill_holes.F90stats_clubb_utilities.F90interpolation.F90T_in_K_module.F90sfc_varnce_module.F90682a70d581028bc852664c1bae4c9691d120f87d1623087742000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduFixing spacing issue on blank lines. #886 2021-06-07 12:42:22 -0500682a70d581028bc852664c1bae4c9691d120f87dFixing spacing issue on blank lines. #886editmatrix_operations.F90editadvance_clubb_core_module.F90editmono_flux_limiter.F90editT_in_K_module.F90editstats_rad_zm_module.F90editcalendar.F90editnew_hybrid_pdf.F90editnew_pdf.F90editnew_tsdadg_pdf.F90editinput_reader.F90editmixing_length.F90editnumerical_check.F90editcalc_pressure.F90editindex_mapping.F90editadvance_windm_edsclrm_module.F90editpdf_closure_module.F90editstats_zt_module.F90editNc_Ncn_eqns.F90editstats_zm_module.F90editsfc_varnce_module.F90editstats_clubb_utilities.F90editSkx_module.F90editstats_sfc_module.F90editoutput_grads.F90editnew_hybrid_pdf_main.F90editendian.F90editadvance_helper_module.F90editmean_adv.F90editadvance_xp2_xpyp_module.F90editlapack_wrap.F90editpos_definite_module.F90editfile_functions.F90editparameters_tunable.F90editadg1_adg2_3d_luhar_pdf.F90editstats_type_utilities.F90editgrid_class.F90editpdf_parameter_module.F90editsigma_sqd_w_module.F90editstats_lh_sfc_module.F90editcalc_roots.F90editdiagnose_correlations_module.F90editnew_pdf_main.F90editfill_holes.F90editturbulent_adv_pdf.F90editsponge_layer_damping.F90editclip_semi_implicit.F90editclubb_api_module.F90editcorr_varnce_module.F90editoutput_netcdf.F90editinterpolation.F90editparameters_model.F90editclip_explicit.F90editadvance_wp2_wp3_module.F90editsetup_clubb_pdf_params.F90editsaturation.F90editLY93_pdf.F90editadvance_xp3_module.F90editprecipitation_fraction.F90edithydromet_pdf_parameter_module.F90editstats_rad_zt_module.F90editpdf_utilities.F90editadvance_xm_wpxp_module.F90editstats_lh_zt_module.F90editdiffusion.F90diffusion.F90clubb_api_module.F90advance_xm_wpxp_module.F90numerical_check.F90output_netcdf.F90diagnose_correlations_module.F90grid_class.F90sponge_layer_damping.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90output_grads.F90advance_clubb_core_module.F90lapack_wrap.F90stats_clubb_utilities.F90interpolation.F90corr_varnce_module.F90matrix_operations.F9068a2ab4afb0a6d86b78f100acfac6052fc6130961623091143000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduFixed comment changes. #886 2021-06-07 13:39:03 -050068a2ab4afb0a6d86b78f100acfac6052fc613096Fixed comment changes. #886editsponge_layer_damping.F90editoutput_grads.F90editstats_clubb_utilities.F90editclubb_api_module.F90editdiagnose_correlations_module.F90editgrid_class.F90editinterpolation.F90editcorr_varnce_module.F90editnumerical_check.F90editlapack_wrap.F90editoutput_netcdf.F90editdiffusion.F90editadvance_clubb_core_module.F90editadvance_xm_wpxp_module.F90editadvance_wp2_wp3_module.F90editadvance_xp2_xpyp_module.F90editmatrix_operations.F90diffusion.F90advance_xm_wpxp_module.F90clubb_api_module.F90setup_clubb_pdf_params.F90new_pdf.F90advance_helper_module.F90mixing_length.F90file_functions.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90new_hybrid_pdf.F90stats_zt_module.F90fill_holes.F90pdf_closure_module.F90stats_clubb_utilities.F9024d2d6e02bddf69942f70e2e54d1955d9e52a1841623091511000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduFixed incorrect spacing on use 2021-06-07 13:45:11 -050024d2d6e02bddf69942f70e2e54d1955d9e52a184Fixed incorrect spacing on useeditfill_holes.F90editpdf_closure_module.F90editadvance_xp2_xpyp_module.F90editfile_functions.F90editadvance_xm_wpxp_module.F90editstats_clubb_utilities.F90editadvance_clubb_core_module.F90editdiffusion.F90editsetup_clubb_pdf_params.F90editadvance_helper_module.F90editstats_zt_module.F90editclubb_api_module.F90editmixing_length.F90editnew_hybrid_pdf.F90editnew_pdf.F90diffusion.F90clubb_api_module.F90advance_xm_wpxp_module.F90setup_clubb_pdf_params.F90new_pdf.F90advance_helper_module.F90mixing_length.F90file_functions.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90new_hybrid_pdf.F90stats_zt_module.F90fill_holes.F90pdf_closure_module.F90stats_clubb_utilities.F905427e211e24f065ce2c7f82da5b8f69e33e35b8d1623092331000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduRevert "Fixed incorrect spacing on use" This reverts commit 76d990d7b5c9eff30a359fbc4709d9278dc2eb2b. 2021-06-07 13:58:51 -05005427e211e24f065ce2c7f82da5b8f69e33e35b8dRevert "Fixed incorrect spacing on use"editmixing_length.F90editstats_clubb_utilities.F90editclubb_api_module.F90editnew_hybrid_pdf.F90editpdf_closure_module.F90editsetup_clubb_pdf_params.F90editfill_holes.F90editadvance_xp2_xpyp_module.F90editnew_pdf.F90editfile_functions.F90editdiffusion.F90editstats_zt_module.F90editadvance_helper_module.F90editadvance_clubb_core_module.F90editadvance_xm_wpxp_module.F90mixing_length.F90file_functions.F90diffusion.F90advance_clubb_core_module.F90new_hybrid_pdf.F90clubb_api_module.F90pdf_closure_module.F90stats_clubb_utilities.F90new_pdf.F90advance_helper_module.F90c3e921120e4a8ecb5da2345ee56e32dd582908481623092618000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduFixed spacing 2021-06-07 14:03:38 -0500c3e921120e4a8ecb5da2345ee56e32dd58290848Fixed spacingeditfile_functions.F90editnew_hybrid_pdf.F90editpdf_closure_module.F90editnew_pdf.F90editadvance_helper_module.F90editdiffusion.F90editmixing_length.F90editstats_clubb_utilities.F90editadvance_clubb_core_module.F90editclubb_api_module.F90mixing_length.F90file_functions.F90diffusion.F90advance_clubb_core_module.F90clubb_api_module.F90new_hybrid_pdf.F90pdf_closure_module.F90stats_clubb_utilities.F90new_pdf.F90advance_helper_module.F902e02d7f843134d047e78118076171e3e13babb3d1623094110000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduFixed spacing going too far 2021-06-07 14:28:30 -05002e02d7f843134d047e78118076171e3e13babb3dFixed spacing going too fareditclubb_api_module.F90editdiffusion.F90editadvance_helper_module.F90editadvance_clubb_core_module.F90editmixing_length.F90editpdf_closure_module.F90editstats_clubb_utilities.F90editnew_pdf.F90editnew_hybrid_pdf.F90editfile_functions.F90diffusion.F90advance_xm_wpxp_module.F90clubb_api_module.F90new_pdf.F90setup_clubb_pdf_params.F90advance_helper_module.F90file_functions.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90new_hybrid_pdf.F90stats_zt_module.F90pdf_closure_module.F90stats_clubb_utilities.F90T_in_K_module.F90d3b117d1c334e9f97273a15eac2f3f5527d6b0001623095035000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduFixed comments being pushed over 2021-06-07 14:43:55 -0500d3b117d1c334e9f97273a15eac2f3f5527d6b000Fixed comments being pushed overeditstats_zt_module.F90editadvance_xm_wpxp_module.F90editT_in_K_module.F90editadvance_xp2_xpyp_module.F90editnew_hybrid_pdf.F90editclubb_api_module.F90editadvance_helper_module.F90editdiffusion.F90editpdf_closure_module.F90editstats_clubb_utilities.F90editnew_pdf.F90editfile_functions.F90editadvance_clubb_core_module.F90editsetup_clubb_pdf_params.F90mixing_length.F90file_functions.F90diffusion.F90advance_clubb_core_module.F90new_hybrid_pdf.F90clubb_api_module.F90pdf_closure_module.F90stats_clubb_utilities.F90new_pdf.F90advance_helper_module.F90fe3ae735b4f499d039623a5ee0d772e084f6b8ac1623160082000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduFixed not all variables being indented properly 2021-06-08 08:48:02 -0500fe3ae735b4f499d039623a5ee0d772e084f6b8acFixed not all variables being indented properlyeditadvance_clubb_core_module.F90editnew_hybrid_pdf.F90editdiffusion.F90editpdf_closure_module.F90editadvance_helper_module.F90editfile_functions.F90editmixing_length.F90editstats_clubb_utilities.F90editclubb_api_module.F90editnew_pdf.F90mixing_length.F90file_functions.F90diffusion.F90advance_clubb_core_module.F90new_hybrid_pdf.F90pdf_closure_module.F90stats_clubb_utilities.F90new_pdf.F90a593cc9f999ce4cac08cfbe08b594786ce8dc4231623160508000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduFixed indentation going beyond variables 2021-06-08 08:55:08 -0500a593cc9f999ce4cac08cfbe08b594786ce8dc423Fixed indentation going beyond variableseditfile_functions.F90editmixing_length.F90editadvance_clubb_core_module.F90editpdf_closure_module.F90editdiffusion.F90editnew_hybrid_pdf.F90editnew_pdf.F90editstats_clubb_utilities.F90file_functions.F909b945635dc114c5d74ed06a38fe5106b3e1be3661623161215000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduFixed file_functions indentation being off 2021-06-08 09:06:55 -05009b945635dc114c5d74ed06a38fe5106b3e1be366Fixed file_functions indentation being offeditfile_functions.F90mixing_length.F90diffusion.F90new_hybrid_pdf.F90clubb_api_module.F90pdf_closure_module.F90new_pdf.F90advance_helper_module.F901e40b9d5b6246903ec09aefb1bba47f234f1e42e1623162163000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduFixed indentation on operations being wrong 2021-06-08 09:22:43 -05001e40b9d5b6246903ec09aefb1bba47f234f1e42eFixed indentation on operations being wrongeditnew_hybrid_pdf.F90editadvance_helper_module.F90editclubb_api_module.F90editnew_pdf.F90editmixing_length.F90editpdf_closure_module.F90editdiffusion.F90new_pdf.F90new_hybrid_pdf.F90e9a76e155c9e8c66eb17e0f27ffc04771b0d82d11623162859000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduReverted incorrect changes to new_pdf and new_hybrid_pdf 2021-06-08 09:34:19 -0500e9a76e155c9e8c66eb17e0f27ffc04771b0d82d1Reverted incorrect changes to new_pdf and new_hybrid_pdfeditnew_pdf.F90editnew_hybrid_pdf.F90clip_explicit.F90advance_xm_wpxp_module.F90setup_clubb_pdf_params.F90new_pdf_main.F90advance_windm_edsclrm_module.F90advance_helper_module.F90mixing_length.F90advance_wp2_wp3_module.F90file_functions.F90advance_xp2_xpyp_module.F90output_grads.F90Skx_module.F90calc_pressure.F90clip_semi_implicit.F90numerical_check.F90pos_definite_module.F90output_netcdf.F90stats_lh_sfc_module.F90saturation.F90advance_xp3_module.F90mean_adv.F90stats_sfc_module.F90parameters_model.F90matrix_operations.F90calendar.F90clubb_api_module.F90stats_lh_zt_module.F90input_reader.F90stats_type_utilities.F90diagnose_correlations_module.F90grid_class.F90mono_flux_limiter.F90new_tsdadg_pdf.F90LY93_pdf.F90stats_rad_zm_module.F90pdf_closure_module.F90adg1_adg2_3d_luhar_pdf.F90new_hybrid_pdf_main.F90corr_varnce_module.F90diffusion.F90endian.F90parameters_tunable.F90new_pdf.F90sponge_layer_damping.F90turbulent_adv_pdf.F90advance_clubb_core_module.F90lapack_wrap.F90fill_holes.F90stats_clubb_utilities.F90interpolation.F90T_in_K_module.F901651f274501bfb73675497070e4d5641d04411fa1623168054000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduFixed spacing issue when adding in gr. BFB identical. For #886. 2021-06-08 11:00:54 -05001651f274501bfb73675497070e4d5641d04411faFixed spacing issue when adding in gr. BFB identical. For #886.editfile_functions.F90editstats_rad_zm_module.F90editsaturation.F90editstats_clubb_utilities.F90editmatrix_operations.F90editsetup_clubb_pdf_params.F90editpos_definite_module.F90editmixing_length.F90editadvance_xp2_xpyp_module.F90editmean_adv.F90editparameters_tunable.F90editoutput_netcdf.F90editstats_sfc_module.F90editcorr_varnce_module.F90editstats_lh_zt_module.F90editadvance_wp2_wp3_module.F90editcalendar.F90editadg1_adg2_3d_luhar_pdf.F90editSkx_module.F90editnumerical_check.F90editclip_explicit.F90editclip_semi_implicit.F90editLY93_pdf.F90editadvance_helper_module.F90editnew_pdf.F90editendian.F90editstats_type_utilities.F90editT_in_K_module.F90editnew_pdf_main.F90editnew_hybrid_pdf_main.F90editdiagnose_correlations_module.F90editparameters_model.F90editstats_lh_sfc_module.F90editadvance_xp3_module.F90editmono_flux_limiter.F90editgrid_class.F90editclubb_api_module.F90editcalc_pressure.F90editadvance_clubb_core_module.F90editpdf_closure_module.F90editdiffusion.F90editoutput_grads.F90editsponge_layer_damping.F90editadvance_windm_edsclrm_module.F90editturbulent_adv_pdf.F90editinterpolation.F90editnew_tsdadg_pdf.F90editadvance_xm_wpxp_module.F90editfill_holes.F90editinput_reader.F90editlapack_wrap.F90latin_hypercube_driver_module.F90e79fc26972ad2e909bf545778f1b42bbc2780b321623168054000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduFixed spacing issue when adding in gr. BFB identical. For #886. 2021-06-08 11:00:54 -0500e79fc26972ad2e909bf545778f1b42bbc2780b32Fixed spacing issue when adding in gr. BFB identical. For #886.editlatin_hypercube_driver_module.F90advance_xm_wpxp_module.F90clubb_api_module.F90pos_definite_module.F90grid_class.F90setup_clubb_pdf_params.F90advance_helper_module.F90mono_flux_limiter.F90mixing_length.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90advance_xp3_module.F90calc_pressure.F907bda97ac8ad514e02e6e6ad3e2562d52d5c071421623708447000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduRemoving gr as a module variable from grid_class. gr is now a module variable in clubb_api_module. This was done in order to not break host models. Additonally, gr is now being fed through the arg list of all functions and subroutines that use gr within grid_class. Results are BFB identical. For ticket #886. 2021-06-14 17:07:27 -05007bda97ac8ad514e02e6e6ad3e2562d52d5c07142Removing gr as a module variable from grid_class.editpos_definite_module.F90editsetup_clubb_pdf_params.F90editadvance_clubb_core_module.F90editmixing_length.F90editadvance_xm_wpxp_module.F90editadvance_xp2_xpyp_module.F90editcalc_pressure.F90editadvance_helper_module.F90editgrid_class.F90editadvance_wp2_wp3_module.F90editmono_flux_limiter.F90editadvance_xp3_module.F90editclubb_api_module.F90latin_hypercube_driver_module.F90fc2e13eb263eb0cf9ac8e12f0a6965e6a01478ec1623708447000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduRemoving gr as a module variable from grid_class. gr is now a module variable in clubb_api_module. This was done in order to not break host models. Additonally, gr is now being fed through the arg list of all functions and subroutines that use gr within grid_class. Results are BFB identical. For ticket #886. 2021-06-14 17:07:27 -0500fc2e13eb263eb0cf9ac8e12f0a6965e6a01478ecRemoving gr as a module variable from grid_class.editlatin_hypercube_driver_module.F90stats_zm_module.F908601df2406dafdfdf0d57a77067b9553dc19d6e91623854429000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comFixing typo in stats_zm_module.F90. Background: Since this commit https://github.com/larson-group/clubb/commit/466c5383fa5c0cc85316c6d117826974a5e2e0a3# in August 2020 the upwp budget lines in Pyplotgen have not appeared to be balanced for any cases. It turns out the reason is that a comma and space were added to the upwp_tp variable name in stats_zm_module.F90 in the August 2020 commit. This unusual naming causes pyplotgen not to recognize this variable, so it doesn't get plotted and the lines appear unbalanced. However, since the budget balance test still found the variable, it kept passing successfully. This commit will fix the issue with the pyplotgen plotting by reverting the name to the standard format. This is BIT_CHANGING since it will affect the name of the upwp_tp variable in the X_zm.nc netcdf file, but it will not change results. 2021-06-16 09:40:29 -05008601df2406dafdfdf0d57a77067b9553dc19d6e9Fixing typo in stats_zm_module.F90. Background: Since this commit https://github.com/larson-group/clubb/commit/466c5383fa5c0cc85316c6d117826974a5e2e0a3# in August 2020 the upwp budget lines in Pyplotgen have not appeared to be balanced for any cases. It turns out the reason is that a comma and space were added to the upwp_tp variable name in stats_zm_module.F90 in the August 2020 commit. This unusual naming causes pyplotgen not to recognize this variable, so it doesn't get plotted and the lines appear unbalanced. However, since the budget balance test still found the variable, it kept passing successfully. This commit will fix the issue with the pyplotgen plotting by reverting the name to the standard format.editstats_zm_module.F90stats_sfc_module.F901978bbce511f3b7a9631d61a8c1028bf2072bfbf1623855537000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comFixing a typo from an earlier commit. See comments in this other commit where a similar typo was fixed: https://github.com/larson-group/clubb/commit/a4f5f736cb16168f40fdc01e454930ffa05fbb4d. 2021-06-16 09:58:57 -05001978bbce511f3b7a9631d61a8c1028bf2072bfbfFixing a typo from an earlier commit.editstats_sfc_module.F90clubb_api_module.F9009858d30f6551ef8ad290e02deecf27b321befd81624289253000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduFeeding gr through arg list for functions outside of CLUBB_core. Gr has been removed as a moduler variable from clubb_api_module and has been moved to clubb_driver as the top level moduler variable. There is only one instance where a use clubb_driver gr statement is used and that is within clubb_tuner. Results are BFB identical. For ticket #886. 2021-06-21 10:27:33 -050009858d30f6551ef8ad290e02deecf27b321befd8Feeding gr through arg list for functions outside of CLUBB_core.editclubb_api_module.F90silhs_api_module.F90latin_hypercube_driver_module.F9024bc6821388ce95985f023733ada790ec18437781624289253000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduFeeding gr through arg list for functions outside of CLUBB_core. Gr has been removed as a moduler variable from clubb_api_module and has been moved to clubb_driver as the top level moduler variable. There is only one instance where a use clubb_driver gr statement is used and that is within clubb_tuner. Results are BFB identical. For ticket #886. 2021-06-21 10:27:33 -050024bc6821388ce95985f023733ada790ec1843778Feeding gr through arg list for functions outside of CLUBB_core.editsilhs_api_module.F90editlatin_hypercube_driver_module.F90grid_class.F90advance_clubb_core_module.F90clubb_api_module.F907c6ca69bbc46a81d7689d02bc7e50835713e1d311624564146000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduMoving 'gr' from front of arg list when being used as intent(inout) to conform to standard. #886. BFB. 2021-06-24 14:49:06 -05007c6ca69bbc46a81d7689d02bc7e50835713e1d31Moving 'gr' from front of arg list when being used as intent(inout) to conform to standard. #886. BFB.editclubb_api_module.F90editgrid_class.F90editadvance_clubb_core_module.F90clubb_api_module.F905127df88dd9725018f5dbf4097192088202d7da91624641544000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduThe purpose of this commit is to see whether or not causing changes in sam's version of clubb will cause errors when the master branch of clubb gets merged intosam. Please ignore this commit unless everything breaks, in which case this is the reason why everything is broken. 2021-06-25 12:19:04 -05005127df88dd9725018f5dbf4097192088202d7da9The purpose of this commit is to see whether or not causing changes in sam's version of clubb will cause errors when the master branch of clubb gets merged intosam. Please ignore this commit unless everything breaks, in which case this is the reason why everything is broken.editclubb_api_module.F90error_code.F90a147663e583384f9f1a925770aecadc6225554d51625077120000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdd error header for CLUBB in CAM 2021-06-30 13:18:40 -0500a147663e583384f9f1a925770aecadc6225554d5Add error header for CLUBB in CAMediterror_code.F90mixing_length.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90diffusion.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90clubb_api_module.F90pdf_closure_module.F90advance_windm_edsclrm_module.F90advance_helper_module.F90cd3da20176118cbba413ee8f49edca31bce4bbc41625149291000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduFixing the ordering of gr in the clubb_api arg list for affected subroutines. Additionally, this commit removes the clubb code standard violation of exceeding more the 100 characters per line. Lastly, the grid typing is being added to clubb_api_module as a public variable so that the host models have access to the type without having to bypass the api For ticket #886. 2021-07-01 09:21:31 -0500cd3da20176118cbba413ee8f49edca31bce4bbc4Fixing the ordering of gr in the clubb_api arg list for affected subroutines.editadvance_xp2_xpyp_module.F90editmixing_length.F90editadvance_xm_wpxp_module.F90editdiffusion.F90editadvance_clubb_core_module.F90editadvance_wp2_wp3_module.F90editadvance_helper_module.F90editclubb_api_module.F90editpdf_closure_module.F90editadvance_windm_edsclrm_module.F90mixing_length.F90advance_windm_edsclrm_module.F90fd4054ccb17b0f17e0f1b05021ef24866c9f99521625160233000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduFixing coding standard violations 2021-07-01 12:23:53 -0500fd4054ccb17b0f17e0f1b05021ef24866c9f9952Fixing coding standard violationseditadvance_windm_edsclrm_module.F90editmixing_length.F90advance_clubb_core_module.F90479e56bfbcbe71564edb1b1c2b123c95e740a7171625696754000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduImproving error messages in setup_clubb_core. larson-group/e3sm#38 2021-07-07 17:25:54 -0500479e56bfbcbe71564edb1b1c2b123c95e740a717Improving error messages in setup_clubb_core. larson-group/e3sm#38editadvance_clubb_core_module.F90precipitation_fraction.F90clubb_api_module.F90advance_xm_wpxp_module.F90clip_explicit.F90setup_clubb_pdf_params.F90advance_windm_edsclrm_module.F90advance_helper_module.F90mono_flux_limiter.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90advance_xp3_module.F90advance_clubb_core_module.F90stats_rad_zt_module.F90stats_rad_zm_module.F90stats_zt_module.F90fill_holes.F90stats_sfc_module.F90stats_clubb_utilities.F90stats_zm_module.F900295787fe7c55013beb522ef0d58f0d429b03a901626973646000http://carson.math.uwm.edu/jenkins/user/72510114+rhodeskeegan72510114+RhodesKeegan72510114+RhodesKeegan@users.noreply.github.comFeeding stats variables through the argument lists of needed subroutines. The purpose of this commit is to prep clubb for having all stats variables be fed through the argument list in the entirety of clubb and host models where needed. This is for ticket #733. Results have been confirmed to be BFB identical. 2021-07-22 12:07:26 -05000295787fe7c55013beb522ef0d58f0d429b03a90Feeding stats variables through the argument lists of needed subroutines.editadvance_xp3_module.F90editstats_clubb_utilities.F90editclubb_api_module.F90editstats_rad_zt_module.F90editfill_holes.F90editprecipitation_fraction.F90editsetup_clubb_pdf_params.F90editstats_zm_module.F90editadvance_clubb_core_module.F90editstats_rad_zm_module.F90editadvance_wp2_wp3_module.F90editadvance_helper_module.F90editadvance_xm_wpxp_module.F90editstats_zt_module.F90editadvance_xp2_xpyp_module.F90editmono_flux_limiter.F90editstats_sfc_module.F90editclip_explicit.F90editadvance_windm_edsclrm_module.F90precipitation_fraction.F90advance_xm_wpxp_module.F90clubb_api_module.F90clip_explicit.F90setup_clubb_pdf_params.F90advance_windm_edsclrm_module.F90mono_flux_limiter.F90advance_helper_module.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90advance_xp3_module.F90stats_rad_zm_module.F90stats_rad_zt_module.F90stats_zt_module.F90fill_holes.F90stats_sfc_module.F90stats_zm_module.F90stats_clubb_utilities.F906eef92139f3e787d4c6b2fe9759ab350e749be9f1626973646000http://carson.math.uwm.edu/jenkins/user/72510114+rhodeskeegan72510114+RhodesKeegan72510114+RhodesKeegan@users.noreply.github.comFixing spacing issues along with placing the stats varibales on their own lines. Additionally, this commit relabels arg list intent along with the intent of stats vars. Stats variables are still not in the correct spot in the arg list as per the standard, however, they are on their own line where they are correctly labeled. For ticket #733. Results are confirmed BFB identical. 2021-07-22 12:07:26 -05006eef92139f3e787d4c6b2fe9759ab350e749be9fFixing spacing issues along with placing the stats varibales on their own lines.editadvance_windm_edsclrm_module.F90editfill_holes.F90editstats_zt_module.F90editmono_flux_limiter.F90editprecipitation_fraction.F90editstats_zm_module.F90editadvance_xm_wpxp_module.F90editadvance_clubb_core_module.F90editadvance_helper_module.F90editsetup_clubb_pdf_params.F90editstats_clubb_utilities.F90editstats_rad_zm_module.F90editstats_sfc_module.F90editadvance_xp3_module.F90editclubb_api_module.F90editstats_rad_zt_module.F90editadvance_wp2_wp3_module.F90editadvance_xp2_xpyp_module.F90editclip_explicit.F90mixing_length.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90advance_xm_wpxp_module.F90clubb_api_module.F90stats_lh_zt_module.F90stats_lh_sfc_module.F90stats_clubb_utilities.F90setup_clubb_pdf_params.F90advance_windm_edsclrm_module.F90mono_flux_limiter.F90d5fbfd0ad95031e40271cc6c706122f1565d29241626973646000http://carson.math.uwm.edu/jenkins/user/72510114+rhodeskeegan72510114+RhodesKeegan72510114+RhodesKeegan@users.noreply.github.comChanging more subroutines to include stats vars in their arg lists. There were a few subroutines that were not detected on the first script for subroutines that would need to be changed. This commit picks up on those subroutines and correctly makes the change. Additionally, this commit also makes the stats vars show up in the same spot consistantly throughout all affected subroutines. For ticket #733. Results are confirmed BFB identical. 2021-07-22 12:07:26 -0500d5fbfd0ad95031e40271cc6c706122f1565d2924Changing more subroutines to include stats vars in their arg lists.editmixing_length.F90editadvance_clubb_core_module.F90editmono_flux_limiter.F90editsetup_clubb_pdf_params.F90editadvance_xm_wpxp_module.F90editadvance_wp2_wp3_module.F90editadvance_xp2_xpyp_module.F90editstats_lh_zt_module.F90editstats_lh_sfc_module.F90editstats_clubb_utilities.F90editclubb_api_module.F90editadvance_windm_edsclrm_module.F90stats_clubb_utilities.F90clubb_api_module.F9077d0af2a8bf800247ce6384510b37642d5eb147c1626973646000http://carson.math.uwm.edu/jenkins/user/72510114+rhodeskeegan72510114+RhodesKeegan72510114+RhodesKeegan@users.noreply.github.comFixing incorrect subroutine arg list 2021-07-22 12:07:26 -050077d0af2a8bf800247ce6384510b37642d5eb147cFixing incorrect subroutine arg listeditclubb_api_module.F90editstats_clubb_utilities.F90stats_clubb_utilities.F90clubb_api_module.F90d13ff64ce37dfe05703c7f5feca642a0d79294611626973646000http://carson.math.uwm.edu/jenkins/user/72510114+rhodeskeegan72510114+RhodesKeegan72510114+RhodesKeegan@users.noreply.github.comFixing host models not compiling. Host models now compile. For ticket #733 Results remain BFB identical. 2021-07-22 12:07:26 -0500d13ff64ce37dfe05703c7f5feca642a0d7929461Fixing host models not compiling.editstats_clubb_utilities.F90editclubb_api_module.F90precipitation_fraction.F90advance_xm_wpxp_module.F90clubb_api_module.F90clip_explicit.F90stats_lh_zt_module.F90stats_lh_sfc_module.F90setup_clubb_pdf_params.F90advance_windm_edsclrm_module.F90mono_flux_limiter.F90advance_helper_module.F90mixing_length.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90advance_xp3_module.F90advance_clubb_core_module.F90stats_rad_zm_module.F90stats_rad_zt_module.F90stats_zt_module.F90fill_holes.F90stats_sfc_module.F90stats_clubb_utilities.F90stats_zm_module.F90ccebf94a0df8e2ea3c8aed4a2f5310abcf23976b1626973646000http://carson.math.uwm.edu/jenkins/user/72510114+rhodeskeegan72510114+RhodesKeegan72510114+RhodesKeegan@users.noreply.github.comFixing argument list so that way the coding standard is upheld. For ticket #733. Results remain BFB identical. 2021-07-22 12:07:26 -0500ccebf94a0df8e2ea3c8aed4a2f5310abcf23976bFixing argument list so that way the coding standard is upheld.editadvance_xm_wpxp_module.F90editstats_clubb_utilities.F90editstats_zm_module.F90editstats_rad_zm_module.F90editadvance_windm_edsclrm_module.F90editmono_flux_limiter.F90editmixing_length.F90editadvance_wp2_wp3_module.F90editsetup_clubb_pdf_params.F90editadvance_xp2_xpyp_module.F90editadvance_xp3_module.F90editfill_holes.F90editclubb_api_module.F90editstats_zt_module.F90editadvance_clubb_core_module.F90editstats_sfc_module.F90editprecipitation_fraction.F90editstats_lh_zt_module.F90editstats_rad_zt_module.F90editclip_explicit.F90editstats_lh_sfc_module.F90editadvance_helper_module.F90new_hybrid_pdf_main.F903521e3a711eb77add3f4e847ccb466c1a202b91e1627072017000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI changed the name to calc_responder_driver because I thought that calc_responder_var_lev (which it had recently been changed to) wasn't very fitting. 2021-07-23 15:26:57 -05003521e3a711eb77add3f4e847ccb466c1a202b91eI changed the name to calc_responder_driver because I thought thateditnew_hybrid_pdf_main.F90advance_wp2_wp3_module.F90advance_clubb_core_module.F90parameter_indices.F90stats_zt_module.F90pdf_closure_module.F90stats_zm_module.F90stats_clubb_utilities.F90parameters_tunable.F90stats_variables.F909804df96e177cde81e75b0c5a8e58b7d7425564a1627323773000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comCode changes to introduce wp2_pr_dfsn, the wp2 pressure diffusion term, consistent with Lumley 1978. Related to #920. This is BIT_CHANGING, but only because it will introduce some new output variables in the netcdf files. It will not affect results currently since the pressure diffusion coefficient is set to zero. 2021-07-26 13:22:53 -05009804df96e177cde81e75b0c5a8e58b7d7425564aCode changes to introduce wp2_pr_dfsn, the wp2 pressure diffusion term, consistent with Lumley 1978. Related to #920.editstats_zm_module.F90editstats_clubb_utilities.F90editadvance_clubb_core_module.F90editadvance_wp2_wp3_module.F90editstats_zt_module.F90editparameters_tunable.F90editstats_variables.F90editparameter_indices.F90editpdf_closure_module.F90advance_wp2_wp3_module.F90c65a56c6e983570429eb26e39c141632068f8c6c1627323773000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comFixing comment for the wp2_term_pr_dfsn subroutine. Related to #920. 2021-07-26 13:22:53 -0500c65a56c6e983570429eb26e39c141632068f8c6cFixing comment for the wp2_term_pr_dfsn subroutine. Related to #920.editadvance_wp2_wp3_module.F90advance_wp2_wp3_module.F90467f228ea4cef740a258bb2161503c2cfcfffb211627323773000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comUpdating wp3 pressure diffusion term to be consistent with the Lumley 1978 formula for the perturbation pressure. For #920. 2021-07-26 13:22:53 -0500467f228ea4cef740a258bb2161503c2cfcfffb21Updating wp3 pressure diffusion term to be consistent with the Lumley 1978 formula for the perturbation pressure. For #920.editadvance_wp2_wp3_module.F90advance_wp2_wp3_module.F90advance_clubb_core_module.F9098f49a6825f2babc94b700d70e39e0539a7cc2541627323773000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comMaking requested changes to the wp2 pressure diffuion additions, including correcting some grid-level related issues. Related to #920. 2021-07-26 13:22:53 -050098f49a6825f2babc94b700d70e39e0539a7cc254Making requested changes to the wp2 pressure diffuion additions, including correcting some grid-level related issues. Related to #920.editadvance_wp2_wp3_module.F90editadvance_clubb_core_module.F90advance_wp2_wp3_module.F90stats_clubb_utilities.F90advance_clubb_core_module.F904b64520fe5255ba8d66fece5639907f2f6aa61db1627323773000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comFixing some comments. 2021-07-26 13:22:53 -05004b64520fe5255ba8d66fece5639907f2f6aa61dbFixing some comments.editadvance_wp2_wp3_module.F90editstats_clubb_utilities.F90editadvance_clubb_core_module.F90tunable_parameters.in28673d8fc91cbcd4286f028be44ab6f73c5491f11627323773000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comCode changes to introduce wp2_pr_dfsn, the wp2 pressure diffusion term, consistent with Lumley 1978. Related to #920. This is BIT_CHANGING, but only because it will introduce some new output variables in the netcdf files. It will not affect results currently since the pressure diffusion coefficient is set to zero. 2021-07-26 13:22:53 -050028673d8fc91cbcd4286f028be44ab6f73c5491f1Code changes to introduce wp2_pr_dfsn, the wp2 pressure diffusion term, consistent with Lumley 1978. Related to #920.edittunable_parameters.inpdf_closure_module.F90stats_zt_module.F90523614e1b29f4f63efa12eec0e45bb586811122a1627331205000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comCorrecting a typo bug and adding some descriptive comments to two new variables. This is a BIT_CHANGING commit becuase it will affect the newly calculated variables and descriptions in the output files, but it won't affect any plotted results. Related to #920. 2021-07-26 15:26:45 -0500523614e1b29f4f63efa12eec0e45bb586811122aCorrecting a typo bug and adding some descriptive comments to two new variables. This is a BIT_CHANGING commit becuase it will affect the newly calculated variables and descriptions in the output files, but it won't affect any plotted results. Related to #920.editstats_zt_module.F90editpdf_closure_module.F90stats_variables.F90clubb_api_module.F900a931b874d79ba2f749da6be1c80f9be039388eb1627409573000http://carson.math.uwm.edu/jenkins/user/72510114+rhodeskeegan72510114+RhodesKeegan72510114+RhodesKeegan@users.noreply.github.comMoving the stats variables to module variables of clubb_driver. This change means I had to modify clubb_api_module's arg list along with other arg lists throughout clubb. Everything compiles and results remain BFB identical. For ticket #733. 2021-07-27 13:12:53 -05000a931b874d79ba2f749da6be1c80f9be039388ebMoving the stats variables to module variables of clubb_driver.editstats_variables.F90editclubb_api_module.F90silhs_api_module.F90latin_hypercube_driver_module.F90bad9a3eb391637b1ff6c9df434e237e1088b10df1627409573000http://carson.math.uwm.edu/jenkins/user/72510114+rhodeskeegan72510114+RhodesKeegan72510114+RhodesKeegan@users.noreply.github.comMoving the stats variables to module variables of clubb_driver. This change means I had to modify clubb_api_module's arg list along with other arg lists throughout clubb. Everything compiles and results remain BFB identical. For ticket #733. 2021-07-27 13:12:53 -0500bad9a3eb391637b1ff6c9df434e237e1088b10dfMoving the stats variables to module variables of clubb_driver.editlatin_hypercube_driver_module.F90editsilhs_api_module.F90advance_clubb_core_module.F90setup_clubb_pdf_params.F90advance_xp2_xpyp_module.F9082f133b444e8397d161e498331b5cbaefbb1a9921627569049000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduFixing coding standard viloation of lines exceeding 100 characters. Violations were introduced as a result of changes made by ticket #733, this commit resolves the coding standard violations. Results BFB identical. 2021-07-29 09:30:49 -050082f133b444e8397d161e498331b5cbaefbb1a992Fixing coding standard viloation of lines exceeding 100 characters.editsetup_clubb_pdf_params.F90editadvance_clubb_core_module.F90editadvance_xp2_xpyp_module.F90silhs_api_module.F90be45e7398fb94d31cb5e3b967809bc3652bd2a451627569049000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduFixing coding standard viloation of lines exceeding 100 characters. Violations were introduced as a result of changes made by ticket #733, this commit resolves the coding standard violations. Results BFB identical. 2021-07-29 09:30:49 -0500be45e7398fb94d31cb5e3b967809bc3652bd2a45Fixing coding standard viloation of lines exceeding 100 characters.editsilhs_api_module.F90advance_wp2_wp3_module.F90parameters_tunable.F90stats_variables.F90parameter_indices.F90stats_zt_module.F90bd7552a5cd558f1086549641269ef5391cf585b91627579701000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comAdding wp3_pr_tp (aka "negative nose" term) to wp3 equation. Related to #920. This is not set up to change results currently, since the coefficient of the new term is zero, but it is BIT_CHANGING since it will include new output in the netcdf files. Also includes updates to pyplotgen to accommodate the new term. 2021-07-29 12:28:21 -0500bd7552a5cd558f1086549641269ef5391cf585b9Adding wp3_pr_tp (aka "negative nose" term) to wp3 equation. Related to #920.editadvance_wp2_wp3_module.F90editstats_zt_module.F90editparameters_tunable.F90editstats_variables.F90editparameter_indices.F90parameters_tunable.F90advance_wp2_wp3_module.F90stats_zt_module.F90b8bad9e4a98d18e532dddc063856d55cd1456ab41627579701000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comChanging the way the new wp3_pr_tp term works, by generalizing the wp3_terp_pr_lhs subroutine. Also cleaning up comments and changing the description of the wp3_pr_tp variable in the netcdf output files, hence this commit is BIT_CHANGING, although it will not affect numerical results since the wp3_pr_tp coefficient (C_wp3_pr_tp) is set to zero. Related to #920. 2021-07-29 12:28:21 -0500b8bad9e4a98d18e532dddc063856d55cd1456ab4Changing the way the new wp3_pr_tp term works, by generalizing the wp3_terp_pr_lhs subroutine. Also cleaning up comments and changing the description of the wp3_pr_tp variable in the netcdf output files, hence this commit is BIT_CHANGING, although it will not affect numerical results since the wp3_pr_tp coefficient (C_wp3_pr_tp) is set to zero.editparameters_tunable.F90editadvance_wp2_wp3_module.F90editstats_zt_module.F90tunable_parameters.in82a9baeefd4116bb99dff5544b88d3cd9ab32c9a1627579701000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comAdding wp3_pr_tp (aka "negative nose" term) to wp3 equation. Related to #920. This is not set up to change results currently, since the coefficient of the new term is zero, but it is BIT_CHANGING since it will include new output in the netcdf files. Also includes updates to pyplotgen to accommodate the new term. 2021-07-29 12:28:21 -050082a9baeefd4116bb99dff5544b88d3cd9ab32c9aAdding wp3_pr_tp (aka "negative nose" term) to wp3 equation. Related to #920.edittunable_parameters.insetup_clubb_pdf_params.F9034cf74a954230451ecf06007e9b5dd8ead72c8a31627654958000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduRemoving l_interp_prescribed_params from setup_clubb_pdf_params. The flag has been removed and so has any code underneat a logic statement involving this statement unless it has multiple flags. The else statement in the if block involving this flag has been set to execute without an if block. For ticket #916 Results are BFB identical. Additionally, complex logic statements with the use of more flags had those flags adjusted and BFB results were also confirmed with these changes. 2021-07-30 09:22:38 -050034cf74a954230451ecf06007e9b5dd8ead72c8a3Removing l_interp_prescribed_params from setup_clubb_pdf_params.editsetup_clubb_pdf_params.F90calendar.F90clubb_api_module.F90clip_explicit.F90input_reader.F90diagnose_correlations_module.F90grid_class.F90setup_clubb_pdf_params.F90mono_flux_limiter.F90mixing_length.F90advance_wp2_wp3_module.F90file_functions.F90advance_xp2_xpyp_module.F90output_grads.F90stats_rad_zt_module.F90stats_rad_zm_module.F90pdf_closure_module.F90adg1_adg2_3d_luhar_pdf.F90code_timer_module.F90corr_varnce_module.F90precipitation_fraction.F90clip_semi_implicit.F90numerical_check.F90output_netcdf.F90mt95.f90pdf_parameter_module.F90parameters_tunable.F90sponge_layer_damping.F90advance_xp3_module.F90advance_clubb_core_module.F90stats_zt_module.F90fill_holes.F90stats_clubb_utilities.F90interpolation.F90stats_zm_module.F90sfc_varnce_module.F90matrix_operations.F90e4741e2adf4b6cc29301ba7945131193798c89fa1627927021000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduAdding comments labeling subroutine calls with intent. Goes all the way up until stats_clubb_utils. BFB identical. For ticket #942. 2021-08-02 12:57:01 -0500e4741e2adf4b6cc29301ba7945131193798c89faAdding comments labeling subroutine calls with intent.editclubb_api_module.F90editdiagnose_correlations_module.F90editpdf_parameter_module.F90editmatrix_operations.F90editstats_clubb_utilities.F90editmono_flux_limiter.F90editadvance_xp3_module.F90editfile_functions.F90editsfc_varnce_module.F90editcalendar.F90editadvance_clubb_core_module.F90editprecipitation_fraction.F90editadg1_adg2_3d_luhar_pdf.F90editclip_semi_implicit.F90editoutput_grads.F90editstats_zt_module.F90editadvance_xp2_xpyp_module.F90editinterpolation.F90editinput_reader.F90editoutput_netcdf.F90editmt95.f90editcode_timer_module.F90editcorr_varnce_module.F90editclip_explicit.F90editmixing_length.F90editnumerical_check.F90editstats_rad_zt_module.F90editstats_zm_module.F90editadvance_wp2_wp3_module.F90editfill_holes.F90editparameters_tunable.F90editsponge_layer_damping.F90editpdf_closure_module.F90editgrid_class.F90editstats_rad_zm_module.F90editsetup_clubb_pdf_params.F90output_grads.F90stats_rad_zt_module.F90stats_rad_zm_module.F90output_netcdf.F90stats_lh_zt_module.F90stats_lh_sfc_module.F90stats_type_utilities.F90stats_clubb_utilities.F90fb672a147e82517a40817f2c816018783e1146531628008649000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduAdding intent labels for subroutines throughout clubb. All calls to subroutines now have intent comments next to them all the way up through stats_sfc_module. Results are BFB identical. For ticket #942. 2021-08-03 11:37:29 -0500fb672a147e82517a40817f2c816018783e114653Adding intent labels for subroutines throughout clubb.editoutput_netcdf.F90editstats_lh_sfc_module.F90editstats_clubb_utilities.F90editoutput_grads.F90editstats_type_utilities.F90editstats_rad_zt_module.F90editstats_rad_zm_module.F90editstats_lh_zt_module.F90advance_wp2_wp3_module.F90dea9cab76b9e14a4f3139dbeaf18de3ca96526091628009021000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRemoving unnecessary constant from use statement 2021-08-03 11:43:41 -0500dea9cab76b9e14a4f3139dbeaf18de3ca9652609Removing unnecessary constant from use statementeditadvance_wp2_wp3_module.F90parameters_tunable.F90dc17ecf04d73f6aa9fbb48fb7a83cc77b1ad386d1628617949000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduEliminating l_nu_grid_dependent as requested. For ticket #926. Results are BFB identical. 2021-08-10 12:52:29 -0500dc17ecf04d73f6aa9fbb48fb7a83cc77b1ad386dEliminating l_nu_grid_dependent as requested.editparameters_tunable.F90advance_clubb_core_module.F90parameters_tunable.F90c22a22b3ba84044037834f62a458b81b02f637941628620641000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduEliminating l_use_buoy_mod_Km_zm. For ticket #926 if we use a buoyancy-modified expression for Km_zm. Results are BFB identical. 2021-08-10 13:37:21 -0500c22a22b3ba84044037834f62a458b81b02f63794Eliminating l_use_buoy_mod_Km_zm.editadvance_clubb_core_module.F90editparameters_tunable.F90advance_clubb_core_module.F90advance_xp2_xpyp_module.F900e8980b576ec718cf4b7247695ec1f1dc9b70c601628624038000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduEliminating l_iter_xp2_xpyp flag. For ticket #926. Results are BFB identical. 2021-08-10 14:33:58 -05000e8980b576ec718cf4b7247695ec1f1dc9b70c60Eliminating l_iter_xp2_xpyp flag.editadvance_xp2_xpyp_module.F90editadvance_clubb_core_module.F90advance_clubb_core_module.F90bafa3df6283a00134563e5b093f72e304e3352ba1628702483000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduEliminating l_apply_rule_to_pdf_params flag. For ticket #926. Results are BFB identical. 2021-08-11 12:21:23 -0500bafa3df6283a00134563e5b093f72e304e3352baEliminating l_apply_rule_to_pdf_params flag.editadvance_clubb_core_module.F90mean_adv.F9080351a9f31586a6da5e46acb59fd423b2d1c09441628703668000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduEliminating l_ub_const_deriv flag. For ticket #926. Results are BFB identical. 2021-08-11 12:41:08 -050080351a9f31586a6da5e46acb59fd423b2d1c0944Eliminating l_ub_const_deriv flag.editmean_adv.F90interpolation.F905861ea0ed9217c2525090a2f50d4158a97da5a931628705685000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduEliminating l_equation_21 flag. For ticket #926. Results are BFB identical 2021-08-11 13:14:45 -05005861ea0ed9217c2525090a2f50d4158a97da5a93Eliminating l_equation_21 flag.editinterpolation.F90advance_wp2_wp3_module.F901725bbe1b3bd91c664ab406db4e94866accbc0cc1628708452000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduEliminating l_wp3_2nd_buoyancy flag. Code surrounding the flag is still present. For ticket #926. Results are BFB identical. 2021-08-11 14:00:52 -05001725bbe1b3bd91c664ab406db4e94866accbc0ccEliminating l_wp3_2nd_buoyancy flag.editadvance_wp2_wp3_module.F90advance_clubb_core_module.F90895a8f6e2d8b44c47b7f4b8a0b439beafa482b8f1628710372000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduEliminating l_refine_grid_in_cloud and l_interactive_refined. For ticket #926. Results are BFB identical. 2021-08-11 14:32:52 -0500895a8f6e2d8b44c47b7f4b8a0b439beafa482b8fEliminating l_refine_grid_in_cloud and l_interactive_refined.editadvance_clubb_core_module.F90advance_clubb_core_module.F90advance_xp2_xpyp_module.F907cbdaaf3133b7eedf3a9cdd66e1be178a62c3af21628713599000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduEliminating l_use_experimental_term_pr2 and l_use_vert_avg_winds For ticket #926 Results are BFB identical. 2021-08-11 15:26:39 -05007cbdaaf3133b7eedf3a9cdd66e1be178a62c3af2Eliminating l_use_experimental_term_pr2 and l_use_vert_avg_windseditadvance_clubb_core_module.F90editadvance_xp2_xpyp_module.F90advance_clubb_core_module.F90advance_wp2_wp3_module.F90model_flags.F90a17efb420b3b5c93d2ca5d39e14d36732c3b1a2a1628777541000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduEliminating l_use_wp3_pr3 flag. For ticket #926. Results are BFB identical. 2021-08-12 09:12:21 -0500a17efb420b3b5c93d2ca5d39e14d36732c3b1a2aEliminating l_use_wp3_pr3 flag.editadvance_clubb_core_module.F90editmodel_flags.F90editadvance_wp2_wp3_module.F90advance_wp2_wp3_module.F90output_netcdf.F90parameters_tunable.F90model_flags.F90advance_xm_wpxp_module.F90924185803f23f0b081f3719fd41a3396b4753a2a1628781691000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduEliminating l_clip_semi_implicit flag. For ticket #926. This commit is BIT_CHANGING due to how the flag needed to be removed. More details on why this commit is bit changing can be seen on the ticket page. 2021-08-12 10:21:31 -0500924185803f23f0b081f3719fd41a3396b4753a2aEliminating l_clip_semi_implicit flag.editoutput_netcdf.F90editadvance_xm_wpxp_module.F90editmodel_flags.F90editparameters_tunable.F90editadvance_wp2_wp3_module.F90advance_clubb_core_module.F90stats_type_utilities.F90numerical_check.F9052350475884c0c6da4817a725a99ad5746b017f11628783267000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduAdding intent labels for subroutines throughout clubb. Remaining files now have intent comments for subroutines. Additionally, all lines are now less than 100 characters. For ticket #942. Results are BFB identical. 2021-08-12 10:47:47 -050052350475884c0c6da4817a725a99ad5746b017f1Adding intent labels for subroutines throughout clubb.editstats_type_utilities.F90editadvance_clubb_core_module.F90editnumerical_check.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90model_flags.F90parameter_indices.F90clubb_api_module.F90output_netcdf.F90parameters_tunable.F90stats_clubb_utilities.F90d6771b9ce7eaf03049fb5a7a002028ea528139e31628881583000http://carson.math.uwm.edu/jenkins/user/72510114+rhodeskeegan72510114+RhodesKeegan72510114+RhodesKeegan@users.noreply.github.comEliminating l_single_C2_Skw flag. Additionally, this commit also eliminates C2, C2b, and C2c. Since the flag along with the other variables are output to the .nc files, this commit will be BIT_CHANGING since these variables no longer exist. This is for ticket #926. 2021-08-13 14:06:23 -0500d6771b9ce7eaf03049fb5a7a002028ea528139e3Eliminating l_single_C2_Skw flag.editmodel_flags.F90editparameter_indices.F90editclubb_api_module.F90editadvance_xp2_xpyp_module.F90editparameters_tunable.F90editoutput_netcdf.F90editstats_clubb_utilities.F90editadvance_clubb_core_module.F90advance_xp2_xpyp_module.F90advance_clubb_core_module.F90model_flags.F90parameter_indices.F90clubb_api_module.F90output_netcdf.F90parameters_tunable.F90stats_clubb_utilities.F9051022e222d451e836733546815b8f88995c534fe1628881583000http://carson.math.uwm.edu/jenkins/user/72510114+rhodeskeegan72510114+RhodesKeegan72510114+RhodesKeegan@users.noreply.github.comEliminating l_single_C2_Skw flag. Additionally, this commit also eliminates C2, C2b, and C2c. Since the flag along with the other variables are output to the .nc files, this commit will be BIT_CHANGING since these variables no longer exist. This is for ticket #926. 2021-08-13 14:06:23 -050051022e222d451e836733546815b8f88995c534feEliminating l_single_C2_Skw flag.editmodel_flags.F90editoutput_netcdf.F90editclubb_api_module.F90editadvance_clubb_core_module.F90editadvance_xp2_xpyp_module.F90editparameters_tunable.F90editstats_clubb_utilities.F90editparameter_indices.F90tunable_parameters.inconfigurable_model_flags.inf71a21b8431dfa298ba2a02ca02633bf5273d63f1628881583000http://carson.math.uwm.edu/jenkins/user/72510114+rhodeskeegan72510114+RhodesKeegan72510114+RhodesKeegan@users.noreply.github.comEliminating l_single_C2_Skw flag. Additionally, this commit also eliminates C2, C2b, and C2c. Since the flag along with the other variables are output to the .nc files, this commit will be BIT_CHANGING since these variables no longer exist. This is for ticket #926. 2021-08-13 14:06:23 -0500f71a21b8431dfa298ba2a02ca02633bf5273d63fEliminating l_single_C2_Skw flag.edittunable_parameters.ineditconfigurable_model_flags.intunable_parameters.inconfigurable_model_flags.inccf7091f750fb78658630a662a911cf75213dfd01628881583000http://carson.math.uwm.edu/jenkins/user/72510114+rhodeskeegan72510114+RhodesKeegan72510114+RhodesKeegan@users.noreply.github.comEliminating l_single_C2_Skw flag. Additionally, this commit also eliminates C2, C2b, and C2c. Since the flag along with the other variables are output to the .nc files, this commit will be BIT_CHANGING since these variables no longer exist. This is for ticket #926. 2021-08-13 14:06:23 -0500ccf7091f750fb78658630a662a911cf75213dfd0Eliminating l_single_C2_Skw flag.edittunable_parameters.ineditconfigurable_model_flags.insilhs_api_module.F90latin_hypercube_driver_module.F90output_2D_samples_module.F9035ae5cdc76bf5d0be3bc8e6e8b0fe2b3d9f7d1e61628881583000http://carson.math.uwm.edu/jenkins/user/72510114+rhodeskeegan72510114+RhodesKeegan72510114+RhodesKeegan@users.noreply.github.comEliminating l_single_C2_Skw flag. Additionally, this commit also eliminates C2, C2b, and C2c. Since the flag along with the other variables are output to the .nc files, this commit will be BIT_CHANGING since these variables no longer exist. This is for ticket #926. 2021-08-13 14:06:23 -050035ae5cdc76bf5d0be3bc8e6e8b0fe2b3d9f7d1e6Eliminating l_single_C2_Skw flag.editlatin_hypercube_driver_module.F90editsilhs_api_module.F90editoutput_2D_samples_module.F90silhs_api_module.F90latin_hypercube_driver_module.F90output_2D_samples_module.F90fff33198f774b25a969928de6793f4d56edeec231628881583000http://carson.math.uwm.edu/jenkins/user/72510114+rhodeskeegan72510114+RhodesKeegan72510114+RhodesKeegan@users.noreply.github.comEliminating l_single_C2_Skw flag. Additionally, this commit also eliminates C2, C2b, and C2c. Since the flag along with the other variables are output to the .nc files, this commit will be BIT_CHANGING since these variables no longer exist. This is for ticket #926. 2021-08-13 14:06:23 -0500fff33198f774b25a969928de6793f4d56edeec23Eliminating l_single_C2_Skw flag.editsilhs_api_module.F90editlatin_hypercube_driver_module.F90editoutput_2D_samples_module.F90mixing_length.F906a1e0902cf77eeba533be047f9e84b621f397bce1628883473000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduEliminating l_include_ice and sat_ice_ratio. For ticket #926 Results are BFB identical. 2021-08-13 14:37:53 -05006a1e0902cf77eeba533be047f9e84b621f397bceEliminating l_include_ice and sat_ice_ratio.editmixing_length.F90mixing_length.F900154499867b83b4b920a9a873e563f80b10b06061628883473000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduEliminating l_include_ice and sat_ice_ratio. For ticket #926 Results are BFB identical. 2021-08-13 14:37:53 -05000154499867b83b4b920a9a873e563f80b10b0606Eliminating l_include_ice and sat_ice_ratio.editmixing_length.F90SRC/CLUBB/output_netcdf.F90SRC/CLUBB/advance_clubb_core_module.F90SRC/CLUBB/clubb_api_module.F90SRC/CLUBB/mixing_length.F90SRC/CLUBB/model_flags.F90SRC/CLUBB/parameter_indices.F90SRC/CLUBB/parameters_tunable.F90SRC/CLUBB/advance_xp2_xpyp_module.F90SRC/CLUBB/stats_clubb_utilities.F90c0e9615d06adf335b98e2bffa35fc00167fa41b01629207207000http://carson.math.uwm.edu/jenkins/user/rootrootroot@carson.math.uwm.eduRaw-copy updating SRC/CLUBB 2021-08-17 08:33:27 -0500c0e9615d06adf335b98e2bffa35fc00167fa41b0Raw-copy updating SRC/CLUBBeditSRC/CLUBB/advance_xp2_xpyp_module.F90editSRC/CLUBB/stats_clubb_utilities.F90editSRC/CLUBB/clubb_api_module.F90editSRC/CLUBB/advance_clubb_core_module.F90editSRC/CLUBB/model_flags.F90editSRC/CLUBB/mixing_length.F90editSRC/CLUBB/parameter_indices.F90editSRC/CLUBB/parameters_tunable.F90editSRC/CLUBB/output_netcdf.F90SRC/SILHS/latin_hypercube_driver_module.F90SRC/SILHS/output_2D_samples_module.F90SRC/SILHS/silhs_api_module.F9095fbefb53ec029357bc2eaf86f5ab4ce00b0261a1629207215000http://carson.math.uwm.edu/jenkins/user/rootrootroot@carson.math.uwm.eduRaw-copy updating SRC/SILHS 2021-08-17 08:33:35 -050095fbefb53ec029357bc2eaf86f5ab4ce00b0261aRaw-copy updating SRC/SILHSeditSRC/SILHS/output_2D_samples_module.F90editSRC/SILHS/silhs_api_module.F90editSRC/SILHS/latin_hypercube_driver_module.F90jenkins_tests/sam_clubb_silhs_gfortran_build/Jenkinsfile23fd1d12335d4bdbafb8c2331fb373e4ba2e25cc1629210474000http://carson.math.uwm.edu/jenkins/user/pbroelspbroelsroelspbr@gmail.comSwapping out old intel variable set script for new intel script. 2021-08-17 09:27:54 -050023fd1d12335d4bdbafb8c2331fb373e4ba2e25ccSwapping out old intel variable set script for new intel script.editjenkins_tests/sam_clubb_silhs_gfortran_build/Jenkinsfileadvance_clubb_core_module.F90model_flags.F90clubb_api_module.F905a57001670ee7b7d03e59cd02523bb9828e354821629213967000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduEliminating l_update_pressure flag. For ticket #926. Results are confirmed to be BFB identical. 2021-08-17 10:26:07 -05005a57001670ee7b7d03e59cd02523bb9828e35482Eliminating l_update_pressure flag.editclubb_api_module.F90editmodel_flags.F90editadvance_clubb_core_module.F90advance_clubb_core_module.F90model_flags.F90clubb_api_module.F9087fade11eec9686b269aed00bb9e08fd131fafe41629213967000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduEliminating l_update_pressure flag. For ticket #926. Results are confirmed to be BFB identical. 2021-08-17 10:26:07 -050087fade11eec9686b269aed00bb9e08fd131fafe4Eliminating l_update_pressure flag.editclubb_api_module.F90editmodel_flags.F90editadvance_clubb_core_module.F90configurable_model_flags.in5fc3ff64e5cd6474bfcee0474b27a9f169a496091629213967000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduEliminating l_update_pressure flag. For ticket #926. Results are confirmed to be BFB identical. 2021-08-17 10:26:07 -05005fc3ff64e5cd6474bfcee0474b27a9f169a49609Eliminating l_update_pressure flag.editconfigurable_model_flags.inconfigurable_model_flags.in42882275b15993dcfa4f9ed4a632cc6a98038a851629213967000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduEliminating l_update_pressure flag. For ticket #926. Results are confirmed to be BFB identical. 2021-08-17 10:26:07 -050042882275b15993dcfa4f9ed4a632cc6a98038a85Eliminating l_update_pressure flag.editconfigurable_model_flags.inSRC/SGS_CLUBB/clubb_sgs.F90CLUBB_PARAMETERS/configurable_model_flags.in824cf340304282896b4350053ef81428052d7e1b1629214341000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduReflecting changes made to clubb in host models 2021-08-17 10:32:21 -0500824cf340304282896b4350053ef81428052d7e1bReflecting changes made to clubb in host modelseditSRC/SGS_CLUBB/clubb_sgs.F90editCLUBB_PARAMETERS/configurable_model_flags.inSRC/CLUBB/clubb_api_module.F90SRC/CLUBB/model_flags.F90SRC/CLUBB/advance_clubb_core_module.F908c8a358049c596d3ddfb8dc8aced45a496524b5f1629259594000http://carson.math.uwm.edu/jenkins/user/larsongroupsysadminLarsonGroupSysAdminroot@carson.math.uwm.eduRaw-copy updating SRC/CLUBB 2021-08-17 23:06:34 -05008c8a358049c596d3ddfb8dc8aced45a496524b5fRaw-copy updating SRC/CLUBBeditSRC/CLUBB/advance_clubb_core_module.F90editSRC/CLUBB/clubb_api_module.F90editSRC/CLUBB/model_flags.F90advance_clubb_core_module.F90model_flags.F90advance_xm_wpxp_module.F90clubb_api_module.F90d0851f0cae643c24780d106d61a78fb1593c9b5f1629473006000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduEliminating l_upwind_wpxp_ta flag. For issue #926. Results are confirmed BFB identical. 2021-08-20 10:23:26 -0500d0851f0cae643c24780d106d61a78fb1593c9b5fEliminating l_upwind_wpxp_ta flag.editadvance_xm_wpxp_module.F90editmodel_flags.F90editclubb_api_module.F90editadvance_clubb_core_module.F90advance_clubb_core_module.F90model_flags.F90advance_xm_wpxp_module.F90clubb_api_module.F9083e7c97e95b713f89982fc94a9a5247d112a1cc91629473006000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduEliminating l_upwind_wpxp_ta flag. For issue #926. Results are confirmed BFB identical. 2021-08-20 10:23:26 -050083e7c97e95b713f89982fc94a9a5247d112a1cc9Eliminating l_upwind_wpxp_ta flag.editmodel_flags.F90editadvance_clubb_core_module.F90editadvance_xm_wpxp_module.F90editclubb_api_module.F90configurable_model_flags.in61659cb6d8547820e7067c6da746184da6be87601629473006000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduEliminating l_upwind_wpxp_ta flag. For issue #926. Results are confirmed BFB identical. 2021-08-20 10:23:26 -050061659cb6d8547820e7067c6da746184da6be8760Eliminating l_upwind_wpxp_ta flag.editconfigurable_model_flags.inconfigurable_model_flags.in90c963cfa42e84190c8cdff8f51c804073a9a7681629473006000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduEliminating l_upwind_wpxp_ta flag. For issue #926. Results are confirmed BFB identical. 2021-08-20 10:23:26 -050090c963cfa42e84190c8cdff8f51c804073a9a768Eliminating l_upwind_wpxp_ta flag.editconfigurable_model_flags.inSRC/SGS_CLUBB/clubb_sgs.F90CLUBB_PARAMETERS/configurable_model_flags.in2e8254c68878f32c21044e9457cd9aedbbf152a91629473152000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduReflecting changes made to clubb in host models 2021-08-20 10:25:52 -05002e8254c68878f32c21044e9457cd9aedbbf152a9Reflecting changes made to clubb in host modelseditSRC/SGS_CLUBB/clubb_sgs.F90editCLUBB_PARAMETERS/configurable_model_flags.inclip_explicit.F900578ed505c5ca0ef84141586d6c18195c4e28fdf1629917460000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdating the surface clipping coefficient... ...to avoid MC3E failure with PGI compiler. I find all cases run successfully with this coefficient, with ifort, gfortran, and PGI. 2021-08-25 13:51:00 -05000578ed505c5ca0ef84141586d6c18195c4e28fdfUpdating the surface clipping coefficient...editclip_explicit.F90clip_explicit.F908a6392b854e8b0d8c8b72f94aa18dce014c77b6b1629917460000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comUpdating the surface clipping coefficient... ...to avoid MC3E failure with PGI compiler. I find all cases run successfully with this coefficient, with ifort, gfortran, and PGI. 2021-08-25 13:51:00 -05008a6392b854e8b0d8c8b72f94aa18dce014c77b6bUpdating the surface clipping coefficient...editclip_explicit.F90configurable_model_flags.in616d74e051c03ae5587ba5f1104a5090ef9d30831630332047000http://carson.math.uwm.edu/jenkins/user/72510114+rhodeskeegan72510114+RhodesKeegan72510114+RhodesKeegan@users.noreply.github.comAdding in l_vary_convect_depth as requested. For ticket #905. Results are confirmed to be BFB identical. 2021-08-30 09:00:47 -0500616d74e051c03ae5587ba5f1104a5090ef9d3083Adding in l_vary_convect_depth as requested.editconfigurable_model_flags.inconfigurable_model_flags.in79fac5d8dc9e22c56ed0d0cebc00e0086d05ec8b1630332047000http://carson.math.uwm.edu/jenkins/user/72510114+rhodeskeegan72510114+RhodesKeegan72510114+RhodesKeegan@users.noreply.github.comAdding in l_vary_convect_depth as requested. For ticket #905. Results are confirmed to be BFB identical. 2021-08-30 09:00:47 -050079fac5d8dc9e22c56ed0d0cebc00e0086d05ec8bAdding in l_vary_convect_depth as requested.editconfigurable_model_flags.inadvance_clubb_core_module.F90model_flags.F90clubb_api_module.F90sfc_varnce_module.F9064c2cdc41031f3088268356bf8e8149aa33c54591630332047000http://carson.math.uwm.edu/jenkins/user/72510114+rhodeskeegan72510114+RhodesKeegan72510114+RhodesKeegan@users.noreply.github.comAdding in l_vary_convect_depth as requested. For ticket #905. Results are confirmed to be BFB identical. 2021-08-30 09:00:47 -050064c2cdc41031f3088268356bf8e8149aa33c5459Adding in l_vary_convect_depth as requested.editclubb_api_module.F90editadvance_clubb_core_module.F90editmodel_flags.F90editsfc_varnce_module.F90advance_clubb_core_module.F90model_flags.F90clubb_api_module.F90sfc_varnce_module.F90cebe3ad6391c3d2ba0720cbe910b43c78b9ef0f61630332047000http://carson.math.uwm.edu/jenkins/user/72510114+rhodeskeegan72510114+RhodesKeegan72510114+RhodesKeegan@users.noreply.github.comAdding in l_vary_convect_depth as requested. For ticket #905. Results are confirmed to be BFB identical. 2021-08-30 09:00:47 -0500cebe3ad6391c3d2ba0720cbe910b43c78b9ef0f6Adding in l_vary_convect_depth as requested.editmodel_flags.F90editclubb_api_module.F90editsfc_varnce_module.F90editadvance_clubb_core_module.F90SRC/SGS_CLUBB/clubb_sgs.F90CLUBB_PARAMETERS/configurable_model_flags.in91fe7ec1d97b14fc0b0f939eeabf303dd464c33f1630332061000http://carson.math.uwm.edu/jenkins/user/72510114+rhodeskeegan72510114+RhodesKeegan72510114+RhodesKeegan@users.noreply.github.comReflecting changes made to clubb in host models 2021-08-30 09:01:01 -050091fe7ec1d97b14fc0b0f939eeabf303dd464c33fReflecting changes made to clubb in host modelseditSRC/SGS_CLUBB/clubb_sgs.F90editCLUBB_PARAMETERS/configurable_model_flags.inSRC/CLUBB/model_flags.F90SRC/CLUBB/advance_clubb_core_module.F90SRC/CLUBB/sfc_varnce_module.F90SRC/CLUBB/clubb_api_module.F90c467eb4d70343d851a72e7459713a4e33805815a1630332061000http://carson.math.uwm.edu/jenkins/user/72510114+rhodeskeegan72510114+RhodesKeegan72510114+RhodesKeegan@users.noreply.github.comAdding clubb directory for testing 2021-08-30 09:01:01 -0500c467eb4d70343d851a72e7459713a4e33805815aAdding clubb directory for testingeditSRC/CLUBB/model_flags.F90editSRC/CLUBB/advance_clubb_core_module.F90editSRC/CLUBB/sfc_varnce_module.F90editSRC/CLUBB/clubb_api_module.F90SRC/CLUBB/model_flags.F90SRC/CLUBB/advance_clubb_core_module.F90SRC/CLUBB/sfc_varnce_module.F90SRC/CLUBB/clubb_api_module.F90d95f964e5166bf6be8c40b0e7a36c2cdbda9a5fc1630332061000http://carson.math.uwm.edu/jenkins/user/72510114+rhodeskeegan72510114+RhodesKeegan72510114+RhodesKeegan@users.noreply.github.comRemoving clubb and silhs directory for tonight's merge 2021-08-30 09:01:01 -0500d95f964e5166bf6be8c40b0e7a36c2cdbda9a5fcRemoving clubb and silhs directory for tonight's mergeeditSRC/CLUBB/clubb_api_module.F90editSRC/CLUBB/advance_clubb_core_module.F90editSRC/CLUBB/sfc_varnce_module.F90editSRC/CLUBB/model_flags.F90SRC/readiopdata_module.F90SRC/readiopdata_common_module.F9045537d72954f07741596cb14c43dbaf4ca3da19f1630365994000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comAdd new common module that exposes internal methods 2021-08-30 18:26:34 -050045537d72954f07741596cb14c43dbaf4ca3da19fAdd new common module that exposes internal methodseditSRC/readiopdata_module.F90addSRC/readiopdata_common_module.F90SRC/readiopdata_common_module.F90049da38859d9fddb1a3b8aa810bdaa217065bc1e1630365994000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comAdd module-level statements for subroutines 2021-08-30 18:26:34 -0500049da38859d9fddb1a3b8aa810bdaa217065bc1eAdd module-level statements for subroutineseditSRC/readiopdata_common_module.F90SRC/readiopdata_module.F90SRC/readiopdata_common_module.F9025a41534bfe4cb5c7572e38d06c32f12506b623e1630365994000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comFix issues that came from moving subroutines to the common module 2021-08-30 18:26:34 -050025a41534bfe4cb5c7572e38d06c32f12506b623eFix issues that came from moving subroutines to the common moduleeditSRC/readiopdata_common_module.F90editSRC/readiopdata_module.F90SRC/readiopdata_module.F90SRC/readiopdata_common_module.F901a1daf9b2e065522ed4bf109397250e86d0df4fe1630365994000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comAdd input file and dimensions to readiopdata_common 2021-08-30 18:26:34 -05001a1daf9b2e065522ed4bf109397250e86d0df4feAdd input file and dimensions to readiopdata_commoneditSRC/readiopdata_common_module.F90editSRC/readiopdata_module.F90SRC/readiopdata_module.F90SRC/readiopdata_common_module.F90eb9682b7084480d6575227a948a79647365741471630365994000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comAdd surface variables to readiopdata_common 2021-08-30 18:26:34 -0500eb9682b7084480d6575227a948a7964736574147Add surface variables to readiopdata_commoneditSRC/readiopdata_module.F90editSRC/readiopdata_common_module.F90SRC/readiopdata_module.F90SRC/readiopdata_common_module.F9093688a028b86692fc20574f6bb86f2198b63fecc1630365994000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comAdd time/pressure variables to readiopdata_common 2021-08-30 18:26:34 -050093688a028b86692fc20574f6bb86f2198b63feccAdd time/pressure variables to readiopdata_commoneditSRC/readiopdata_module.F90editSRC/readiopdata_common_module.F90SRC/readiopdata_module.F90SRC/readiopdata_common_module.F90e34335b2b9607fb6db3d86c56865e1cccb5887401630365994000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comAdd soundings to readiopdata_common 2021-08-30 18:26:34 -0500e34335b2b9607fb6db3d86c56865e1cccb588740Add soundings to readiopdata_commoneditSRC/readiopdata_common_module.F90editSRC/readiopdata_module.F90SRC/readiopdata_module.F90SRC/readiopdata_common_module.F90fa8c6cac65e9291c08924515cf3dcabc032bf1361630365994000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comAdd remaining surface and sounding code to readiopdata_common 2021-08-30 18:26:34 -0500fa8c6cac65e9291c08924515cf3dcabc032bf136Add remaining surface and sounding code to readiopdata_commoneditSRC/readiopdata_common_module.F90editSRC/readiopdata_module.F90SRC/readiopdata_module.F90SRC/readiopdata_common_module.F90c18a0fe8bb1e1caf86991252ecc92a6267bd7c371630365994000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comRemove unnecessary arguments from readiopdata_common 2021-08-30 18:26:34 -0500c18a0fe8bb1e1caf86991252ecc92a6267bd7c37Remove unnecessary arguments from readiopdata_commoneditSRC/readiopdata_common_module.F90editSRC/readiopdata_module.F90SRC/readiopdata_module.F90SRC/readiopdata_common_module.F90130223f612faf45ce4f7d75fb3524876801766441630365994000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comRename readiopdata_common to readiopdata_core 2021-08-30 18:26:34 -0500130223f612faf45ce4f7d75fb352487680176644Rename readiopdata_common to readiopdata_coreeditSRC/readiopdata_module.F90editSRC/readiopdata_common_module.F90SRC/readiopdata_module.F90SRC/readiopdata_common_module.F9044c0408fb401a36288b451680d0f862d2156b6771630365994000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comRename readiopdata_core subroutine to readiopdata_core_snd 2021-08-30 18:26:34 -050044c0408fb401a36288b451680d0f862d2156b677Rename readiopdata_core subroutine to readiopdata_core_sndeditSRC/readiopdata_common_module.F90editSRC/readiopdata_module.F90SRC/readiopdata_module.F90SRC/readiopdata_common_module.F902848d3111c689c2d7c8fbf4c47a4fa29d4fbce0a1630365994000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comCreate readiopdata_core_dims subroutine Add zsnd to readiopdata_core_snd arguments 2021-08-30 18:26:34 -05002848d3111c689c2d7c8fbf4c47a4fa29d4fbce0aCreate readiopdata_core_dims subroutineeditSRC/readiopdata_common_module.F90editSRC/readiopdata_module.F90SRC/readiopdata_module.F90SRC/readiopdata_common_module.F906b96e862ef0495cbda003da9ed5c0d8a62f4897a1630365994000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comCreate readiopdata_core_sfc subroutine 2021-08-30 18:26:34 -05006b96e862ef0495cbda003da9ed5c0d8a62f4897aCreate readiopdata_core_sfc subroutineeditSRC/readiopdata_module.F90editSRC/readiopdata_common_module.F90SRC/readiopdata_module.F90SRC/readiopdata_core_module.F90SRC/readiopdata_common_module.F904af5c52ee5bba396f95a60b691e72d629dde51ad1630365994000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comClean up readiopdata_core 2021-08-30 18:26:34 -05004af5c52ee5bba396f95a60b691e72d629dde51adClean up readiopdata_coredeleteSRC/readiopdata_common_module.F90editSRC/readiopdata_module.F90addSRC/readiopdata_core_module.F90SRC/readiopdata_module.F90SRC/readiopdata_core_module.F9091e8e708dbe0464805cb0f7c3936bb47009c7fd31630365994000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comCreate readiopdata_core_frc subroutine 2021-08-30 18:26:34 -050091e8e708dbe0464805cb0f7c3936bb47009c7fd3Create readiopdata_core_frc subroutineeditSRC/readiopdata_module.F90editSRC/readiopdata_core_module.F90SRC/readiopdata_module.F90SRC/readiopdata_core_module.F901d782967ea1bdf7a59881c8433daeea92deb2ebc1630365994000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comFix readiopdata_core for use as a shared module in clubb 2021-08-30 18:26:34 -05001d782967ea1bdf7a59881c8433daeea92deb2ebcFix readiopdata_core for use as a shared module in clubbeditSRC/readiopdata_module.F90editSRC/readiopdata_core_module.F90SRC/readiopdata_core_module.F9055c77b14e0600dadd4dbb24c1042eea6f4b51dc81630365994000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comChange comparison operators to match clubb standard 2021-08-30 18:26:34 -050055c77b14e0600dadd4dbb24c1042eea6f4b51dc8Change comparison operators to match clubb standardeditSRC/readiopdata_core_module.F90SRC/readiopdata_core_module.F90d5fd6438033d4507028bb11d0b16734093611c041630365994000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comChange file name in print statements to readiopdata_core_module.F90 2021-08-30 18:26:34 -0500d5fd6438033d4507028bb11d0b16734093611c04Change file name in print statements to readiopdata_core_module.F90editSRC/readiopdata_core_module.F90SRC/readiopdata_core_module.F90SRC/READIOPDATA_CORE/readiopdata_core_module.F90d94bfc2c876eff4f3b24fed8c2cf8eefedb56b201630365994000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comMove readiopdata_core_module.F90 to a subdirectory for use with git-subtree 2021-08-30 18:26:34 -0500d94bfc2c876eff4f3b24fed8c2cf8eefedb56b20Move readiopdata_core_module.F90 to a subdirectory for use with git-subtreeaddSRC/READIOPDATA_CORE/readiopdata_core_module.F90deleteSRC/readiopdata_core_module.F90Build0de6a42f2a86f835db355dbf7e4ceaf49a93ac6c1630365994000http://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldcisenfireldc@gmail.comAdd SRC/READIOPDATA_CORE to build paths 2021-08-30 18:26:34 -05000de6a42f2a86f835db355dbf7e4ceaf49a93ac6cAdd SRC/READIOPDATA_CORE to build pathseditBuildadvance_clubb_core_module.F901016f8e33ad0f6476ee40bc5dd690451bc0b869b1630547434000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRemoving a couple of unused parameters from use statement. These are not caught by the gfortran compiler for whatever reason but the ifort compiler warned about them. 2021-09-01 20:50:34 -05001016f8e33ad0f6476ee40bc5dd690451bc0b869bRemoving a couple of unused parameters from use statement.editadvance_clubb_core_module.F90advance_clubb_core_module.F90b24820513db462e4a5b1cae18b4a901d7e9bd8a21630547434000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRemoving a couple of unused parameters from use statement. These are not caught by the gfortran compiler for whatever reason but the ifort compiler warned about them. 2021-09-01 20:50:34 -0500b24820513db462e4a5b1cae18b4a901d7e9bd8a2Removing a couple of unused parameters from use statement.editadvance_clubb_core_module.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90clip_explicit.F90dafbfbd0f0baf9f01fcb08b22f2a17333606a56a1630599690000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduPushing k loop down through clip_variance_level. This change is for the files advance_wp2_wp3_module and advance_xp2_xpyp_module. In order to make this change, I added a new variable in the upper-level subroutine that is an array version of the variable 'threshold' and passed it along to the lower subroutine. The loop is still present in order to calculate the values of threshold, however, the calls to the subroutine is outside of the loop. The only calculations inside the loop is for and intrensic function, max. All results are BFB identical for default case along with l_stats_samp being set to true. For ticket #951. 2021-09-02 11:21:30 -0500dafbfbd0f0baf9f01fcb08b22f2a17333606a56aPushing k loop down through clip_variance_level.editadvance_xp2_xpyp_module.F90editadvance_wp2_wp3_module.F90editclip_explicit.F90advance_wp2_wp3_module.F90advance_xp2_xpyp_module.F90clip_explicit.F90ed78e345853d9af1f71e7300220392469b690b671630599690000http://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskrhodesk@msoe.eduPushing k loop down through clip_variance_level. This change is for the files advance_wp2_wp3_module and advance_xp2_xpyp_module. In order to make this change, I added a new variable in the upper-level subroutine that is an array version of the variable 'threshold' and passed it along to the lower subroutine. The loop is still present in order to calculate the values of threshold, however, the calls to the subroutine is outside of the loop. The only calculations inside the loop is for and intrensic function, max. All results are BFB identical for default case along with l_stats_samp being set to true. For ticket #951. 2021-09-02 11:21:30 -0500ed78e345853d9af1f71e7300220392469b690b67Pushing k loop down through clip_variance_level.editadvance_wp2_wp3_module.F90editadvance_xp2_xpyp_module.F90editclip_explicit.F90parameters_tunable.F9072b5c72ac5985e9a585e44d615243bcbc6582ae81630630020000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comUdpates to make it possible for us to keep certain parameters equal to each other during tuning. Includes: * a new subroutine in parameters_tunable.F90 that will read a new namelist in the error_*.in files * updates to src/error.F90 to make sure the intended parameters are held equal throughout the tuning run * updates to src.error.F90 to print the variables that were held equal at the end of the tuning run, together with their beginning and ending values, and updates to ensure that the new tuned values are copied into the new paramters_tunable_*.in file so they can be used for plotting or restarting the tuner. * includes several simple error checks See #939. 2021-09-02 19:47:00 -050072b5c72ac5985e9a585e44d615243bcbc6582ae8Udpates to make it possible for us to keep certain parameters equal to each other during tuning.editparameters_tunable.F90parameters_tunable.F90747e30bcbd918a4dde0b1491b3ebfeaebdac9b591630630020000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comUdpates to make it possible for us to keep certain parameters equal to each other during tuning. Includes: * a new subroutine in parameters_tunable.F90 that will read a new namelist in the error_*.in files * updates to src/error.F90 to make sure the intended parameters are held equal throughout the tuning run * updates to src.error.F90 to print the variables that were held equal at the end of the tuning run, together with their beginning and ending values, and updates to ensure that the new tuned values are copied into the new paramters_tunable_*.in file so they can be used for plotting or restarting the tuner. * includes several simple error checks See #939. 2021-09-02 19:47:00 -0500747e30bcbd918a4dde0b1491b3ebfeaebdac9b59Udpates to make it possible for us to keep certain parameters equal to each other during tuning.editparameters_tunable.F90parameters_tunable.F9094146014302b085c13961f6e0eab2dadedca02431630630020000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comFurther tuner updates. These updates introduce the option to give a minimum value for tuned parameters. Error checks are included. See #939. 2021-09-02 19:47:00 -050094146014302b085c13961f6e0eab2dadedca0243Further tuner updates. These updates introduce the option to give a minimum value for tuned parameters. Error checks are included.editparameters_tunable.F90parameters_tunable.F90c787271c923e08a7bfa8db303bfee6588f840abf1630630020000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comFurther tuner updates. These updates introduce the option to give a minimum value for tuned parameters. Error checks are included. See #939. 2021-09-02 19:47:00 -0500c787271c923e08a7bfa8db303bfee6588f840abfFurther tuner updates. These updates introduce the option to give a minimum value for tuned parameters. Error checks are included.editparameters_tunable.F90parameters_tunable.F905c73ee72a0175108bcc4b103ebd44c696a92a50a1630630020000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comUpdating some comments related to the tuner updates. See #939. 2021-09-02 19:47:00 -05005c73ee72a0175108bcc4b103ebd44c696a92a50aUpdating some comments related to the tuner updates.editparameters_tunable.F90parameters_tunable.F9068848116981910e70725c5fcc14d78e78f3f87ed1630630020000http://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens8259519056+bstephens82@users.noreply.github.comUpdating some comments related to the tuner updates. See #939. 2021-09-02 19:47:00 -050068848116981910e70725c5fcc14d78e78f3f87edUpdating some comments related to the tuner updates.editparameters_tunable.F90advance_clubb_core_module.F903b29c310d2e96d7e9fe9e5078ac6ee6a2f2fb7591631320025000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding space to trigger autoupdate. larson-group/sys_admin#755 2021-09-10 19:27:05 -05003b29c310d2e96d7e9fe9e5078ac6ee6a2f2fb759Adding space to trigger autoupdate. larson-group/sys_admin#755editadvance_clubb_core_module.F90advance_clubb_core_module.F90ed5bed1dc8054413f5792e6d3abe64789523d7301631320025000http://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhuebler@uwm.eduAdding space to trigger autoupdate. larson-group/sys_admin#755 2021-09-10 19:27:05 -0500ed5bed1dc8054413f5792e6d3abe64789523d730Adding space to trigger autoupdate. larson-group/sys_admin#755editadvance_clubb_core_module.F90advance_clubb_core_module.F90a7a1f100a8a3938b9a1717165b7daa1a6858c5141631562742000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comRemove space to trigger autoupdate. larson-group/sys_admin#755 2021-09-13 14:52:22 -0500a7a1f100a8a3938b9a1717165b7daa1a6858c514Remove space to trigger autoupdate. larson-group/sys_admin#755editadvance_clubb_core_module.F90advance_clubb_core_module.F90579ae7bf3eba658a981d771ded27f16906ed78961631743991000http://carson.math.uwm.edu/jenkins/user/noreplynoreplynoreply@github.comAdd space to trigger nightly tests. For larson-group/sys_admin#755. 2021-09-15 17:13:11 -0500579ae7bf3eba658a981d771ded27f16906ed7896Add space to trigger nightly tests. For larson-group/sys_admin#755.editadvance_clubb_core_module.F90SRC/statistics.F90RUNDATA/lst529f3c72a3fdc4f9ec56347796f140479766c1e21631813013000http://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephensbenjamin.andrew.stephens@gmail.comAdding a more direct calculation of W2PRESDFSN, which differs slightly from W2PRES near the surface but is very similar aloft. 2021-09-16 11:23:33 -0600529f3c72a3fdc4f9ec56347796f140479766c1e2Adding a more direct calculation of W2PRESDFSN, which differs slightly from W2PRES near the surface but is very similar aloft.editSRC/statistics.F90editRUNDATA/lstadvance_clubb_core_module.F903f4274296a097f61485983e5106c6480143821141632526019000http://carson.math.uwm.edu/jenkins/user/bmg2bmg2bmg2@uwm.eduI am fixing a bug that was introduced in 6b0348e, where the logical flow was distorted within the trapezoidal rule code. This change does not affect standard CLUBB, where the trapezoidal rule is not used by default. However, it is important for CAM-CLUBB. 2021-09-24 18:26:59 -05003f4274296a097f61485983e5106c648014382114I am fixing a bug that was introduced in 6b0348e, where the logicaleditadvance_clubb_core_module.F90githttp://carson.math.uwm.edu/jenkins/user/isenfireldcisenfireldchttp://carson.math.uwm.edu/jenkins/user/larsongroupsysadminLarsonGroupSysAdminhttp://carson.math.uwm.edu/jenkins/user/bmg2bmg2http://carson.math.uwm.edu/jenkins/user/guozhunguozhunhttp://carson.math.uwm.edu/jenkins/user/sdomkeSteffen Domkehttp://carson.math.uwm.edu/jenkins/user/savvasavvahttp://carson.math.uwm.edu/jenkins/user/nselkenselkehttp://carson.math.uwm.edu/jenkins/user/roessle9roessle9http://carson.math.uwm.edu/jenkins/user/pbroelspbroelshttp://carson.math.uwm.edu/jenkins/user/nchiefnchiefhttp://carson.math.uwm.edu/jenkins/user/rautrauthttp://carson.math.uwm.edu/jenkins/user/72510114+rhodeskeegan72510114+RhodesKeeganhttp://carson.math.uwm.edu/jenkins/user/hoc_browserhoc_browserhttp://carson.math.uwm.edu/jenkins/user/rhodeskrhodeskhttp://carson.math.uwm.edu/jenkins/user/benjamin.andrew.stephensbenjamin.andrew.stephenshttp://carson.math.uwm.edu/jenkins/user/weberjkweberjkhttp://carson.math.uwm.edu/jenkins/user/vlarsonVince Larsonhttp://carson.math.uwm.edu/jenkins/user/59519056+bstephens8259519056+bstephens82http://carson.math.uwm.edu/jenkins/user/rootroothttp://carson.math.uwm.edu/jenkins/user/strikestrikehttp://carson.math.uwm.edu/jenkins/user/griffinbBrian Griffinhttp://carson.math.uwm.edu/jenkins/user/noreplynoreplyhttp://carson.math.uwm.edu/jenkins/user/hueblerGunther Hueblerhttp://carson.math.uwm.edu/jenkins/user/mcfadd34mcfadd34false46http://carson.math.uwm.edu/jenkins/job/branch_sam_test/46/44http://carson.math.uwm.edu/jenkins/job/branch_sam_test/44/BRANCHorigin/l_vary_convect_depth_additionTESTsam_clubb_silhs_gfortran_buildStarted by user rhodeskrhodeskrhodesk409687fd653c50c09e15df81168c05b1fdaa1d8f989687fd653c50c09e15df81168c05b1fdaa1d8f98refs/remotes/origin/flag_removal9687fd653c50c09e15df81168c05b1fdaa1d8f989687fd653c50c09e15df81168c05b1fdaa1d8f98refs/remotes/origin/flag_removal79ddfec7a3b139dfeeb8cfdaf78ad0f09d9c36f829ddfec7a3b139dfeeb8cfdaf78ad0f09d9c36f82refs/remotes/origin/stats_testing9ddfec7a3b139dfeeb8cfdaf78ad0f09d9c36f829ddfec7a3b139dfeeb8cfdaf78ad0f09d9c36f82refs/remotes/origin/stats_testing43ac319abf904ec136d6e0b259b9c74de95e4ac85aac319abf904ec136d6e0b259b9c74de95e4ac85arefs/remotes/origin/l_vary_convect_depth_additionac319abf904ec136d6e0b259b9c74de95e4ac85aac319abf904ec136d6e0b259b9c74de95e4ac85arefs/remotes/origin/l_vary_convect_depth_addition3fcb64a792d6631be39938f67e613ded134dd5dcafcb64a792d6631be39938f67e613ded134dd5dcarefs/remotes/origin/changes_to_not_breakfcb64a792d6631be39938f67e613ded134dd5dcafcb64a792d6631be39938f67e613ded134dd5dcarefs/remotes/origin/changes_to_not_break2814edaf741e6d665c0f89a28cfaeca1a95ea693d714edaf741e6d665c0f89a28cfaeca1a95ea693d7refs/remotes/origin/readiopdata_nf9014edaf741e6d665c0f89a28cfaeca1a95ea693d714edaf741e6d665c0f89a28cfaeca1a95ea693d7refs/remotes/origin/readiopdata_nf9024b8d176c11a7fc2b842245dcaec35cd93959f64c9b8d176c11a7fc2b842245dcaec35cd93959f64c9refs/remotes/origin/stats_for_hostb8d176c11a7fc2b842245dcaec35cd93959f64c9b8d176c11a7fc2b842245dcaec35cd93959f64c9refs/remotes/origin/stats_for_host4181de9ac556f33464591d16d960243732834be6f281de9ac556f33464591d16d960243732834be6f2refs/remotes/origin/master81de9ac556f33464591d16d960243732834be6f281de9ac556f33464591d16d960243732834be6f2refs/remotes/origin/masterac319abf904ec136d6e0b259b9c74de95e4ac85aac319abf904ec136d6e0b259b9c74de95e4ac85arefs/remotes/origin/l_vary_convect_depth_additionhttps://github.com/larson-group/sam_clubb.gitfalse#43963529778629branch_sam_test #4343false438367SUCCESS1629480276946http://carson.math.uwm.edu/jenkins/job/branch_sam_test/43/false44http://carson.math.uwm.edu/jenkins/job/branch_sam_test/44/42http://carson.math.uwm.edu/jenkins/job/branch_sam_test/42/